Re: [PATCH 08/12] arm64: dts: qcom: sm6115-pro1x: Update copyright year

2024-07-22 Thread Krzysztof Kozlowski
On 22/07/2024 09:10, Dang Huynh wrote: > It's 2024, let's update the copyright year. > > Signed-off-by: Dang Huynh > --- > arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts >

Re: [PATCH] arm64: dts: exynos: exynos7885-jackpotlte: Correct RAM amount to 4GB

2024-07-13 Thread Krzysztof Kozlowski
On 13/07/2024 19:58, David Virag wrote: > All known jackpotlte variants have 4GB of RAM, let's use it all. > RAM was set to 3GB from a mistake in the vendor provided DTS file. Hm, vendor DTS rarely has a mistake of missing 1 GB of RAM, so I assume there was some reason behind it. Trusted apps?

Re: [PATCH v2 1/8] dt-bindings: interconnect: qcom: Add Qualcomm MSM8976 NoC

2024-07-07 Thread Krzysztof Kozlowski
On 06/07/2024 16:06, Adam Skladowski wrote: > > On 7/5/24 08:55, Krzysztof Kozlowski wrote: >> On 04/07/2024 22:02, Adam Skladowski wrote: >>> Add bindings for Qualcomm MSM8976 Network-On-Chip interconnect devices. >>> >>> Signed-off-by: Adam Skladowski

Re: [PATCH v2 7/8] dt-bindings: interconnect: qcom: msm8939: Fix example

2024-07-05 Thread Krzysztof Kozlowski
correct example would be the snoc, because it is the most complete, but well... Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 3/8] dt-bindings: interconnect: qcom: Add Qualcomm MSM8937 NoC

2024-07-05 Thread Krzysztof Kozlowski
On 04/07/2024 22:02, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8937 Network-On-Chip interconnect devices. > > Signed-off-by: Adam Skladowski > --- > .../bindings/interconnect/qcom,msm8937.yaml | 63 + > .../dt-bindings/interconnect/qcom,msm8937.h | 93

Re: [PATCH v2 1/8] dt-bindings: interconnect: qcom: Add Qualcomm MSM8976 NoC

2024-07-05 Thread Krzysztof Kozlowski
On 04/07/2024 22:02, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8976 Network-On-Chip interconnect devices. > > Signed-off-by: Adam Skladowski > --- > .../bindings/interconnect/qcom,msm8976.yaml | 63 > .../dt-bindings/interconnect/qcom,msm8976.h | 97

Re: [PATCH v2 0/8] msm8937/msm8976/qcs404 icc patches

2024-07-05 Thread Krzysztof Kozlowski
On 04/07/2024 22:02, Adam Skladowski wrote: > This series introduce new ICC drivers for some legacy socs > while at it also updates a bit of qcs404 driver which seems > to not receive much attention lately. > Please take in consideration i do not own any qcs404 board > so i cannot test anything

Re: [PATCH v3 1/2] dt-bindings: arm: qcom: Document samsung,ms013g

2024-07-02 Thread Krzysztof Kozlowski
On 30/06/2024 15:29, Raymond Hackley wrote: > Document samsung,ms013g for Galaxy Grand 2. > > Signed-off-by: Raymond Hackley This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short

Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Document samsung,ms013g

2024-07-01 Thread Krzysztof Kozlowski
On 27/06/2024 21:30, Raymond Hackley wrote: > Document samsung,ms013g for Galaxy Grand 2. > > Signed-off-by: Raymond Hackley Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v9 4/8] remoteproc: qcom: Add ssr subdevice identifier

2024-06-25 Thread Krzysztof Kozlowski
On 25/06/2024 08:28, Gokul Sriram P wrote: > > On 6/21/2024 8:40 PM, Krzysztof Kozlowski wrote: >> On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote: >>> Add name for ssr subdevice on IPQ8074 SoC. >> Why? >   Oops! Missed the change. Will add and update. >&

Re: [PATCH 1/3] dt-bindings: arm: qcom: Add msm8916 based LG devices

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 11:26, Nikita Travkin wrote: > Add compatible values for the msm8916 based LG smartphones. > > Signed-off-by: Nikita Travkin > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 2 + Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v9 4/8] remoteproc: qcom: Add ssr subdevice identifier

2024-06-21 Thread Krzysztof Kozlowski
On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote: > Add name for ssr subdevice on IPQ8074 SoC. Why? > > Signed-off-by: Nikhil Prakash V > Signed-off-by: Sricharan R > Signed-off-by: Gokul Sriram Palanisamy Three people developed that single line? Something is really odd with your DCO

Re: [PATCH v9 8/8] arm64: dts: qcom: Enable Q6v5 WCSS for ipq8074 SoC

2024-06-21 Thread Krzysztof Kozlowski
On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote: > Enable remoteproc WCSS PIL driver with glink. Also, > configure shared memory and enables smp2p required for IPC. > > Signed-off-by: Nikhil Prakash V > Signed-off-by: Sricharan R > Signed-off-by: Gokul Sriram Palanisamy > --- >

Re: [PATCH v9 6/8] dt-bindings: clock: qcom: Add reset for WCSSAON

2024-06-21 Thread Krzysztof Kozlowski
On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote: > Add binding for WCSSAON reset required for Q6v5 reset on IPQ8074 SoC. > > Signed-off-by: Nikhil Prakash V > Signed-off-by: Sricharan R > Signed-off-by: Gokul Sriram Palanisamy Again, three people contributed to this one define? Best

Re: [PATCH v9 5/8] remoteproc: qcom: Update regmap offsets for halt register

2024-06-21 Thread Krzysztof Kozlowski
On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote: > Fixed issue in reading halt-regs parameter from device-tree. What issue? That's a terrible commit msg. Explain what is the problem, how can it be reproduced. > > Signed-off-by: Sricharan R > Signed-off-by: Gokul Sriram Palanisamy > --- >

Re: [PATCH v9 1/8] remoteproc: qcom: Add PRNG proxy clock

2024-06-21 Thread Krzysztof Kozlowski
On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote: > > -static int q6v5_wcss_init_clock(struct q6v5_wcss *wcss) > +static int ipq8074_init_clock(struct q6v5_wcss *wcss) > +{ > + int ret; > + > + wcss->prng_clk = devm_clk_get(wcss->dev, "prng"); Missing binding. Best regards, Krzysztof

Re: [PATCH 2/3] dt-bindings: arm: qcom: Add Sony Xperia Z3 Compact

2024-06-21 Thread Krzysztof Kozlowski
phone,fp2 >- oneplus,bacon >- samsung,klte > + - sony,xperia-aries Bindings come before users. With ordering fixed: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 1/4] dt-bindings: remoteproc: mpss: Document QDU1000/QRU1000 mpss devices

2024-06-20 Thread Krzysztof Kozlowski
On 20/06/2024 14:01, Komal Bajaj wrote: > From: Melody Olvera > > Document the compatible for the component used to boot the MPSS on the > QDU1000 and QRU1000 SoCs. > > The QDU1000 and QRU1000 mpss boot process now requires the specification > of an RMB register space to complete the handshake

Re: [PATCH 2/7] dt-bindings: clock: qcom,a53pll: Allow opp-table subnode

2024-06-20 Thread Krzysztof Kozlowski
> 1 file changed, 3 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/7] dt-bindings: clock: qcom,a53pll: Add msm8226-a7pll compatible

2024-06-20 Thread Krzysztof Kozlowski
On 19/06/2024 23:02, Luca Weiss wrote: > Add the compatible for the A7PLL found in MSM8226 SoCs. > > Signed-off-by: Luca Weiss > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/7] dt-bindings: mailbox: qcom: add compatible for MSM8226 SoC

2024-06-20 Thread Krzysztof Kozlowski
On 19/06/2024 23:02, Luca Weiss wrote: > Add the mailbox compatible for MSM8226 SoC. > > Signed-off-by: Luca Weiss > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS

2024-06-17 Thread Krzysztof Kozlowski
On 17/06/2024 11:34, Naina Mehta wrote: > Document the MPSS Peripheral Authentication Service on SDX75 platform. > > Signed-off-by: Naina Mehta > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 7/7] dt-bindings: interconnect: qcom: msm8939: Fix example

2024-06-10 Thread Krzysztof Kozlowski
On 09/06/2024 20:21, Adam Skladowski wrote: > For now example list snoc_mm as children of bimc which is obviously > not valid, change example and include rest of nocs in it. > > Fixes: 462baaf4c628 ("dt-bindings: interconnect: qcom: Fix and separate out > MSM8939") > Signed-off-by: Adam

Re: [PATCH 4/7] interconnect: qcom: Add MSM8937 interconnect provider driver

2024-06-10 Thread Krzysztof Kozlowski
On 09/06/2024 20:20, Adam Skladowski wrote: > Add driver for interconnect busses found in MSM8937 based platforms. > The topology consists of four NoCs that are partially controlled > by a RPM processor. > > Signed-off-by: Adam Skladowski > --- > + > +static const struct of_device_id

Re: [PATCH 3/7] dt-bindings: interconnect: Add Qualcomm MSM8937 DT bindings

2024-06-10 Thread Krzysztof Kozlowski
On 09/06/2024 20:20, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8937 Network-On-Chip interconnect devices. > > Signed-off-by: Adam Skladowski Since I expect resend, all trivial nits from patch #1 apply here as well. > --- > .../bindings/interconnect/qcom,msm8937.yaml | 81

Re: [PATCH 2/7] interconnect: qcom: Add MSM8976 interconnect provider driver

2024-06-10 Thread Krzysztof Kozlowski
On 09/06/2024 20:20, Adam Skladowski wrote: > Add driver for interconnect busses found in MSM8976 based platforms. > The topology consists of four NoCs that are partially controlled > by a RPM processor. > > Signed-off-by: Adam Skladowski > + > +static const struct qcom_icc_desc msm8976_snoc_mm

Re: [PATCH 1/7] dt-bindings: interconnect: Add Qualcomm MSM8976 DT bindings

2024-06-10 Thread Krzysztof Kozlowski
On 09/06/2024 20:20, Adam Skladowski wrote: > Add bindings for Qualcomm MSM8976 Network-On-Chip interconnect devices. > > Signed-off-by: Adam Skladowski A nit, subject: drop second/last, redundant "DT bindings". The "dt-bindings" prefix is already stating that these are bindings. See also:

Re: [PATCH v2 1/1] dt-bindings: remoteproc: imx_rproc: add minItems for power-domain

2024-06-10 Thread Krzysztof Kozlowski
On 07/06/2024 17:19, Frank Li wrote: > On Fri, Jun 07, 2024 at 09:32:26AM +0200, Krzysztof Kozlowski wrote: >> On 06/06/2024 17:00, Frank Li wrote: >>> "fsl,imx8qxp-cm4" and "fsl,imx8qm-cm4" need minimum 2 power domains. Keep >>> the same restriction

Re: [PATCH v2 1/1] dt-bindings: remoteproc: imx_rproc: add minItems for power-domain

2024-06-07 Thread Krzysztof Kozlowski
On 06/06/2024 17:00, Frank Li wrote: > "fsl,imx8qxp-cm4" and "fsl,imx8qm-cm4" need minimum 2 power domains. Keep > the same restriction for other compatible string. > > Signed-off-by: Frank Li > --- > > Notes: > Change from v1 to v2 > - set minitem to 2 at top > - Add imx8qm

Re: [PATCH v2 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-06-07 Thread Krzysztof Kozlowski
he correct mailbox for each host. The old qcom,ipc-N properties map to > the mboxes property by index, starting at 0 since that's a valid SMSM > host also. > > Mark the older qcom,ipc-N as deprecated and update the example with > mboxes. > > Signed-off-by: Luca Weiss > --

Re: [PATCH 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for mpss

2024-06-06 Thread Krzysztof Kozlowski
On 06/06/2024 16:38, Naina Mehta wrote: > The qlink_logging memory region is also used by the modem firmware, > add it to reserved memory regions. > Also split MPSS DSM region into 2 separate regions. > > Signed-off-by: Naina Mehta > --- > arch/arm64/boot/dts/qcom/sdx75.dtsi | 17

Re: [PATCH 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS

2024-06-06 Thread Krzysztof Kozlowski
On 06/06/2024 16:38, Naina Mehta wrote: > Document the MPSS Peripheral Authentication Service on SDX75 platform. > > Signed-off-by: Naina Mehta > --- > .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git >

Re: [PATCH v3 1/5] dt-bindings: remoteproc: qcom,sa8775p-pas: Document the SA8775p ADSP, CDSP and GPDSP

2024-06-06 Thread Krzysztof Kozlowski
775p-pas.yaml | 160 > + > 1 file changed, 160 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/1] dt-bindings: remoteproc: imx_rproc: add minItems for power-domain

2024-06-06 Thread Krzysztof Kozlowski
On 05/06/2024 21:34, Frank Li wrote: > "fsl,imx8qxp-cm4" just need 2 power domains. Keep the same restriction for > other compatible string. > > Signed-off-by: Frank Li > --- > > Notes: > pass dt_binding_check. > > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8

Re: [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs

2024-06-05 Thread Krzysztof Kozlowski
> --- > Changes in v3: > *) Use allOf keyword with separate ifs for each variant instead >of nested if/else conditions. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: arm: qcom: add HTC One (M8)

2024-06-03 Thread Krzysztof Kozlowski
On 03/06/2024 08:28, Alexandre Messier via B4 Relay wrote: > From: Alexandre Messier > > Add a compatible for the HTC One (M8), which is based on the > MSM8974Pro SoC. > > Signed-off-by: Alexandre Messier > --- Acked-by: Krzysztof Kozlowski --- This is an automa

Re: [PATCH] arm64: dts: qcom: sm8550-samsung-q5q: fix typo

2024-05-31 Thread Krzysztof Kozlowski
uot;arm64: dts: qcom: sm8550: Add support for Samsung Galaxy Z Fold5") Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs

2024-05-31 Thread Krzysztof Kozlowski
On 30/05/2024 18:48, Hari Nagalla wrote: > The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It > does not have an addressable l1dram . So, remove this optional sram > property from the bindings to fix device tree build warnings. > > Signed-off-by: Hari Nagalla > --- > Changes

Re: [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sa8775p-pas: Document the SA8775p ADSP, CDSP and GPDSP

2024-05-28 Thread Krzysztof Kozlowski
On 28/05/2024 09:26, Bartosz Golaszewski wrote: > On Mon, May 27, 2024 at 10:56 AM Krzysztof Kozlowski wrote: >> >> On 27/05/2024 10:43, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> Document the components used to boot the

Re: [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sa8775p-pas: Document the SA8775p ADSP, CDSP and GPDSP

2024-05-27 Thread Krzysztof Kozlowski
On 27/05/2024 10:43, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Document the components used to boot the ADSP, CDSP0, CDSP1, GPDSP0 and > GPDSP1 on the SA8775p SoC. > > Co-developed-by: Tengfei Fan Missing SoB. > Signed-off-by: Bartosz Golaszewski ... > + > +allOf: > + -

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-25 Thread Krzysztof Kozlowski
On 24/05/2024 19:55, Luca Weiss wrote: > On Donnerstag, 23. Mai 2024 08:19:11 MESZ Krzysztof Kozlowski wrote: >> On 23/05/2024 08:16, Luca Weiss wrote: >>> On Donnerstag, 23. Mai 2024 08:02:13 MESZ Krzysztof Kozlowski wrote: >>>> On 22/05/2024 19:34, Luca Weiss wro

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-23 Thread Krzysztof Kozlowski
On 23/05/2024 08:16, Luca Weiss wrote: > On Donnerstag, 23. Mai 2024 08:02:13 MESZ Krzysztof Kozlowski wrote: >> On 22/05/2024 19:34, Luca Weiss wrote: >>> On Mittwoch, 22. Mai 2024 08:49:43 MESZ Krzysztof Kozlowski wrote: >>>> On 21/05/2024 22:35, Luca Weiss wrote: &

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-23 Thread Krzysztof Kozlowski
On 22/05/2024 19:34, Luca Weiss wrote: > On Mittwoch, 22. Mai 2024 08:49:43 MESZ Krzysztof Kozlowski wrote: >> On 21/05/2024 22:35, Luca Weiss wrote: >>> On Dienstag, 21. Mai 2024 10:58:07 MESZ Krzysztof Kozlowski wrote: >>>> On 20/05/2024 17:11, Luca W

Re: [PATCH 2/5] dt-bindings: mailbox: qcom-ipcc: Add GPDSP0 and GPDSP1 clients

2024-05-22 Thread Krzysztof Kozlowski
On 22/05/2024 14:08, Bartosz Golaszewski wrote: > From: Tengfei Fan > > Add GPDSP0 and GPDSP1 clients for SA8775p platform. > > Signed-off-by: Tengfei Fan > Signed-off-by: Bartosz Golaszewski > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-22 Thread Krzysztof Kozlowski
On 21/05/2024 22:35, Luca Weiss wrote: > On Dienstag, 21. Mai 2024 10:58:07 MESZ Krzysztof Kozlowski wrote: >> On 20/05/2024 17:11, Luca Weiss wrote: >>> Hi Krzysztof >>> >>> Ack, sounds good. >>> >>> Maybe also from you, any opinion between

Re: [PATCH v5 2/7] dt-bindings: remoteproc: Add compatibility for TEE support

2024-05-21 Thread Krzysztof Kozlowski
On 21/05/2024 10:09, Arnaud Pouliquen wrote: > The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration > where the Cortex-M4 firmware is loaded by the Trusted execution Environment > (TEE). > For instance, this compatible is used in both the Linux and OP-TEE > device-tree: > - In

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-21 Thread Krzysztof Kozlowski
On 20/05/2024 17:11, Luca Weiss wrote: > Hi Krzysztof > > Ack, sounds good. > > Maybe also from you, any opinion between these two binding styles? > > So first using index of mboxes for the numbering, where for the known > usages the first element (and sometimes the 3rd - ipc-2) are empty <>. >

Re: [PATCH RFC 1/2] dt-bindings: soc: qcom,smsm: Allow specifying mboxes instead of qcom,ipc

2024-05-20 Thread Krzysztof Kozlowski
On 15/05/2024 17:06, Luca Weiss wrote: > Hi Rob, > > Any feedback on the below topic? Can be explained in description, like mboxes: description: Each entry corresponds to one remote processor maxItems: 5 Best regards, Krzysztof

Re: [PATCH v2 1/6] dt-bindings: iio: light: stk33xx: add vdd and leda regulators

2024-04-23 Thread Krzysztof Kozlowski
On 24/04/2024 00:33, Aren Moynihan wrote: > stk3310 and stk3311 are typically connected to power supplies for the > chip (vdd) and the infrared LED (leda). Add properties so we can power > these up / down appropriately. > > Signed-off-by: Aren Moynihan > --- > Reviewed-by

Re: [PATCH v2 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

2024-04-19 Thread Krzysztof Kozlowski
On 19/04/2024 10:42, Olivia Wen wrote: > From: "olivia.wen" > > Under different applications, the MT8188 SCP can be used as single-core > or dual-core. > > Signed-off-by: olivia.wen Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] dt-bindings: iio: light: stk33xx: add regulator for vdd supply

2024-04-14 Thread Krzysztof Kozlowski
On 14/04/2024 19:57, Aren Moynihan wrote: > Signed-off-by: Aren Moynihan > --- Why? Please provide proper commit msg which will explain why you are doing it (e.g. say about hardware). Anyway empty commit msgs cannot be accepted. Best regards, Krzysztof

Re: [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: Add pbs to SPMI device types

2024-04-12 Thread Krzysztof Kozlowski
On 12/04/2024 16:22, Luca Weiss wrote: > Add the PBS (Programmable Boot Sequencer) to the list of devices. > > Reviewed-by: Bjorn Andersson > Signed-off-by: Luca Weiss > --- > Changes in v2: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-11 Thread Krzysztof Kozlowski
On 10/04/2024 04:20, Ondřej Jirman wrote: > On Mon, Apr 08, 2024 at 10:12:30PM GMT, Krzysztof Kozlowski wrote: >> On 08/04/2024 17:17, Ondřej Jirman wrote: >>> >>> Now for things to not fail during suspend/resume based on PM callbacks >>> invocation o

Re: [PATCH 1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC

2024-04-11 Thread Krzysztof Kozlowski
On 31/03/2024 12:46, Karel Balej wrote: > Marvell 88PM886 is a PMIC with several subdevices such as onkey, > regulators or battery and charger. It comes in at least two revisions, > A0 and A1 -- only A1 is described here at the moment. > > Reviewed-by: Krzysztof Kozlowski > Si

Re: [PATCH 2/2] remoteproc: mediatek: Support MT8188 SCP core 1

2024-04-11 Thread Krzysztof Kozlowski
On 11/04/2024 05:37, olivia.wen wrote: > +}; > + > static const struct of_device_id mtk_scp_of_match[] = { > { .compatible = "mediatek,mt8183-scp", .data = _of_data }, > { .compatible = "mediatek,mt8186-scp", .data = _of_data }, > @@ -1323,6 +1362,7 @@ static const struct of_device_id

Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

2024-04-11 Thread Krzysztof Kozlowski
On 11/04/2024 05:37, olivia.wen wrote: > Under different applications, the MT8188 SCP can be used as single-core > or dual-core. > > Signed-off-by: olivia.wen Are you sure you use full name, not email login as name? > --- > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++- >

[PATCH] rpmsg: qcom_glink_ssr: fix module autoloading

2024-04-10 Thread Krzysztof Kozlowski
Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Krzysztof Kozlowski --- drivers/rpmsg/qcom_glink_ssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg

Re: [PATCH v2 2/2] ARM: dts: qcom: msm8974-hammerhead: Update gpio hog node name

2024-04-10 Thread Krzysztof Kozlowski
On 09/04/2024 20:36, Luca Weiss wrote: > Follow the gpio-hog bindings and use otg-hog as node name. > > Signed-off-by: Luca Weiss > --- > arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: K

Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Allow gpio-hog nodes

2024-04-10 Thread Krzysztof Kozlowski
e changed, 12 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/2] ARM: dts: qcom: msm8974: Use proper compatible for APCS syscon

2024-04-09 Thread Krzysztof Kozlowski
On 08/04/2024 21:32, Luca Weiss wrote: > Use the apcs-kpss-global compatible for the APCS global mailbox block > found on this SoC. > > This also resolves a dt-binding checker warning: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v14 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-04-09 Thread Krzysztof Kozlowski
reg/reg-names works and stable ABI is maintained. > > It also extends the examples for TCM split and lockstep modes. > > Signed-off-by: Radhey Shyam Pandey > Signed-off-by: Tanmay Shah Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Allow gpio-hog nodes

2024-04-09 Thread Krzysztof Kozlowski
On 08/04/2024 20:36, Luca Weiss wrote: > On Montag, 8. April 2024 19:26:49 CEST Konrad Dybcio wrote: >> >> On 4/8/24 18:39, Luca Weiss wrote: >>> Allow specifying a GPIO hog, as already used on >>> qcom-msm8974-lge-nexus5-hammerhead.dts. >>> >>> Signed-off-by: Luca Weiss >>> --- >>>

Re: [PATCH 1/2] dt-bindings: mailbox: qcom: Add MSM8974 APCS compatible

2024-04-09 Thread Krzysztof Kozlowski
On 08/04/2024 21:32, Luca Weiss wrote: > Add compatible for the Qualcomm MSM8974 APCS block. "... The block is already used in DTS, but without any SoC specific compatible." Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] dt-bindings: iio: imu: mpu6050: Improve i2c-gate disallow list

2024-04-09 Thread Krzysztof Kozlowski
where the Linux driver explicitly > disallows support for the auxiliary bus ("inv_mpu_i2c_aux_bus"). Since > the driver is also based on "default: return true" this should scale > better into the future. > > Signed-off-by: Luca Weiss Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 17:17, Ondřej Jirman wrote: > On Mon, Apr 08, 2024 at 03:27:00PM GMT, Krzysztof Kozlowski wrote: >> On 08/04/2024 14:48, Ondřej Jirman wrote: >>> Yeah, I understand where the confusion is. The driver is not for anx7688 >>> chip >>> really. The

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 14:48, Ondřej Jirman wrote: > On Mon, Apr 08, 2024 at 01:59:12PM GMT, Krzysztof Kozlowski wrote: >> On 08/04/2024 13:52, Ondřej Jirman wrote: >>> On Mon, Apr 08, 2024 at 01:24:03PM GMT, Krzysztof Kozlowski wrote: >>>> On 08/04/2024 13:21

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 13:51, Ondřej Jirman wrote: > Hi Krzysztof, > > On Mon, Apr 08, 2024 at 01:17:32PM GMT, Krzysztof Kozlowski wrote: >> On 08/04/2024 12:51, Pavel Machek wrote: >>> Add binding for anx7688 usb type-c bridge. I don't have a datasheet, >>> but I did

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 13:52, Ondřej Jirman wrote: > On Mon, Apr 08, 2024 at 01:24:03PM GMT, Krzysztof Kozlowski wrote: >> On 08/04/2024 13:21, Pavel Machek wrote: >>> Hi! >>> >>>>> Add binding for anx7688 usb type-c bridge. I don't have a datasheet, >>&g

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 13:21, Pavel Machek wrote: > Hi! > >>> Add binding for anx7688 usb type-c bridge. I don't have a datasheet, >>> but I did best I could. >>> >>> Signed-off-by: Pavel Machek >> >> ... >> >>> + cabledet-gpios: >>> +maxItems: 1 >>> +description: GPIO controlling CABLE_DET (C3)

Re: [PATCHv3 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-04-08 Thread Krzysztof Kozlowski
On 08/04/2024 12:51, Pavel Machek wrote: > Add binding for anx7688 usb type-c bridge. I don't have a datasheet, > but I did best I could. > > Signed-off-by: Pavel Machek ... > + cabledet-gpios: > +maxItems: 1 > +description: GPIO controlling CABLE_DET (C3) pin. > + > + avdd10-supply:

Re: [PATCH 3/3] dt-bindings: remoteproc: qcom,sdm845-adsp-pil: Fix qcom,halt-regs definition

2024-04-08 Thread Krzysztof Kozlowski
++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/3] dt-bindings: remoteproc: qcom,sc7280-wpss-pil: Fix qcom,halt-regs definition

2024-04-07 Thread Krzysztof Kozlowski
On 07/04/2024 11:58, Luca Weiss wrote: > Set the 'items' correctly for the qcom,halt-regs property and update the > description to match what it should be. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,qcs404-cdsp-pil: Fix qcom,halt-regs definition

2024-04-07 Thread Krzysztof Kozlowski
++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G (2013)

2024-03-25 Thread Krzysztof Kozlowski
On 24/03/2024 15:03, Stanislav Jakubek wrote: > Document the Motorola Moto G (2013), which is a smartphone based > on the Qualcomm MSM8226 SoC. > > Signed-off-by: Stanislav Jakubek > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + Acked-by: Krzysztof Kozlow

Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform

2024-03-21 Thread Krzysztof Kozlowski
On 21/03/2024 16:13, Tanmay Shah wrote: > > > On 3/21/24 2:39 AM, Krzysztof Kozlowski wrote: >> On 20/03/2024 16:14, Tanmay Shah wrote: >>> >>> >>> On 3/20/24 2:40 AM, Krzysztof Kozlowski wrote: >>>> On 19/03/2024 15:42, Tanmay Shah w

Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform

2024-03-21 Thread Krzysztof Kozlowski
On 20/03/2024 16:14, Tanmay Shah wrote: > > > On 3/20/24 2:40 AM, Krzysztof Kozlowski wrote: >> On 19/03/2024 15:42, Tanmay Shah wrote: >>> >>> >>> On 3/19/24 12:30 AM, Krzysztof Kozlowski wrote: >>>> On 19/03/2024 01:51, Tanmay Shah wrote:

Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform

2024-03-20 Thread Krzysztof Kozlowski
On 19/03/2024 15:42, Tanmay Shah wrote: > > > On 3/19/24 12:30 AM, Krzysztof Kozlowski wrote: >> On 19/03/2024 01:51, Tanmay Shah wrote: >>> Hello Krzysztof, >>> >>> Thanks for reviews. Please find my comments below. >>> >>> On 3/17/24

Re: [PATCH 1/3] dt-bindings: remoteproc: add Versal platform support

2024-03-18 Thread Krzysztof Kozlowski
On 19/03/2024 01:37, Tanmay Shah wrote: > Hello, > > Thanks for reviews, please find my comments below. > > On 3/17/24 9:50 AM, Conor Dooley wrote: >> On Fri, Mar 15, 2024 at 02:15:31PM -0700, Tanmay Shah wrote: >>> AMD-Xilinx Versal platform is successor of ZynqMP platform. Real-time >>>

Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform

2024-03-18 Thread Krzysztof Kozlowski
On 19/03/2024 01:51, Tanmay Shah wrote: > Hello Krzysztof, > > Thanks for reviews. Please find my comments below. > > On 3/17/24 1:53 PM, Krzysztof Kozlowski wrote: >> On 15/03/2024 22:15, Tanmay Shah wrote: >>> AMD-Xilinx Versal-NET platform is successor of Ve

Re: [PATCH v13 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-03-18 Thread Krzysztof Kozlowski
On 11/03/2024 18:59, Tanmay Shah wrote: > From: Radhey Shyam Pandey > > Introduce bindings for TCM memory address space on AMD-xilinx Zynq > UltraScale+ platform. It will help in defining TCM in device-tree > and make it's access platform agnostic and data-driven. > > Tightly-coupled

Re: [PATCH v13 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-03-18 Thread Krzysztof Kozlowski
On 12/03/2024 13:13, Krzysztof Kozlowski wrote: > On 11/03/2024 18:59, Tanmay Shah wrote: >> From: Radhey Shyam Pandey >> >> Introduce bindings for TCM memory address space on AMD-xilinx Zynq >> UltraScale+ platform. It will help in defining TCM in device-tree >&

Re: [PATCH 3/3] drivers: remoteproc: add Versal and Versal-NET support

2024-03-18 Thread Krzysztof Kozlowski
On 19/03/2024 02:06, Tanmay Shah wrote: > > > On 3/17/24 1:55 PM, Krzysztof Kozlowski wrote: >> On 15/03/2024 22:15, Tanmay Shah wrote: >>> AMD-Xilinx Versal and Versal-NET are successor of ZynqMP platform. ZynqMP >>> remoteproc driver is mostly compati

Re: [PATCH 3/3] drivers: remoteproc: add Versal and Versal-NET support

2024-03-17 Thread Krzysztof Kozlowski
On 15/03/2024 22:15, Tanmay Shah wrote: > AMD-Xilinx Versal and Versal-NET are successor of ZynqMP platform. ZynqMP > remoteproc driver is mostly compatible with new platforms except few > platform specific differences. > > Versal has same IP of cortex-R5 cores hence maintained compatible string

Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform

2024-03-17 Thread Krzysztof Kozlowski
On 15/03/2024 22:15, Tanmay Shah wrote: > AMD-Xilinx Versal-NET platform is successor of Versal platform. It > contains multiple clusters of cortex-R52 real-time processing units. > Each cluster contains two cores of cortex-R52 processors. Each cluster > can be configured in lockstep mode or split

Re: [PATCH 1/3] dt-bindings: remoteproc: add Versal platform support

2024-03-17 Thread Krzysztof Kozlowski
On 15/03/2024 22:15, Tanmay Shah wrote: > AMD-Xilinx Versal platform is successor of ZynqMP platform. Real-time > Processor Unit R5 cluster IP on Versal is same as of ZynqMP Platform. > Only difference is power-domains ID needed by power management firmware. > Hence, keeping the compatible

Re: [PATCH 3/3] dt-bindings: remoteproc: Add Arm remoteproc

2024-03-14 Thread Krzysztof Kozlowski
On 14/03/2024 14:49, Abdellatif El Khlifi wrote: >> Frankly at the moment I'd be inclined to say it isn't even a remoteproc >> binding (or driver) at all, it's a reset controller. Bindings are a contract >> for describing the hardware, not the current state of Linux driver support - >> if this

Re: [PATCH v13 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-03-12 Thread Krzysztof Kozlowski
On 12/03/2024 18:42, Tanmay Shah wrote: > > > On 3/12/24 7:13 AM, Krzysztof Kozlowski wrote: >> On 11/03/2024 18:59, Tanmay Shah wrote: >>> From: Radhey Shyam Pandey >>> >>> Introduce bindings for TCM memory address space on AMD-xilinx Zynq >>>

Re: [PATCH v13 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-03-12 Thread Krzysztof Kozlowski
tead of > keeping it flexible. > - Add "items:" list in power-domains property Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v12 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-03-12 Thread Krzysztof Kozlowski
On 11/03/2024 19:39, Tanmay Shah wrote: >>> + >>> +else: >>> + patternProperties: >>> +"^r5f@[0-9a-f]+$": >>> + type: object >>> + >>> + properties: >>> +reg: >>> + minItems: 1 >>> + items: >>> +- description:

Re: [PATCH v12 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-03-12 Thread Krzysztof Kozlowski
On 11/03/2024 17:27, Tanmay Shah wrote: >>> +then: >>> + patternProperties: >>> +"^r5f@[0-9a-f]+$": >>> + type: object >>> + >>> + properties: >>> +reg: >>> + minItems: 1 >>> + items: >>> +- description: ATCM

Re: [PATCHv2 1/2] dt-bindings: usb: typec: anx7688: start a binding document

2024-03-12 Thread Krzysztof Kozlowski
On 11/03/2024 22:22, Pavel Machek wrote: > Hi! > >> Add binding for anx7688 usb type-c bridge. I don't have a datasheet, >> but I did best I could. >> >> Signed-off-by: Pavel Machek > > Any more comments here? Automatic system told me I need to replace one > character... Well, I often do not

Re: [RFC PATCH v3 4/5] input: add onkey driver for Marvell 88PM886 PMIC

2024-03-11 Thread Krzysztof Kozlowski
On 11/03/2024 11:26, Karel Balej wrote: > Krzysztof Kozlowski, 2024-03-10T21:35:36+01:00: >> On 10/03/2024 12:35, Karel Balej wrote: >>> Dmitry Torokhov, 2024-03-04T17:10:59-08:00: >>>> On Mon, Mar 04, 2024 at 09:28:45PM +0100, Karel Balej wrote: >>>>>

Re: [RFC PATCH v3 4/5] input: add onkey driver for Marvell 88PM886 PMIC

2024-03-10 Thread Krzysztof Kozlowski
On 10/03/2024 12:35, Karel Balej wrote: > Dmitry Torokhov, 2024-03-04T17:10:59-08:00: >> On Mon, Mar 04, 2024 at 09:28:45PM +0100, Karel Balej wrote: >>> Dmitry, >>> >>> Dmitry Torokhov, 2024-03-03T12:39:46-08:00: On Sun, Mar 03, 2024 at 11:04:25AM +0100, Karel Balej wrote: > From: Karel

Re: [PATCH 2/3] dt-bindings: arm: qcom: Add Sony Xperia Z3

2024-03-10 Thread Krzysztof Kozlowski
On 10/03/2024 12:41, Luca Weiss wrote: > Add the compatible for this Sony smartphone. > > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Samsung Galaxy Note 3

2024-03-10 Thread Krzysztof Kozlowski
On 10/03/2024 15:13, Luca Weiss wrote: > Add the compatible for this Samsung smartphone ("phablet" as it was > named in that era). > > Signed-off-by: Luca Weiss > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v12 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

2024-03-09 Thread Krzysztof Kozlowski
On 01/03/2024 19:16, Tanmay Shah wrote: > From: Radhey Shyam Pandey > > Introduce bindings for TCM memory address space on AMD-xilinx Zynq > UltraScale+ platform. It will help in defining TCM in device-tree > and make it's access platform agnostic and data-driven. > > Tightly-coupled

Re: [PATCH v3 2/3] dt-bindings: input: imagis: Document touch keys

2024-03-07 Thread Krzysztof Kozlowski
On 06/03/2024 15:40, Duje Mihanović wrote: > IST3032C (and possibly some other models) has touch keys. Document this. > > Signed-off-by: Duje Mihanović > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [RFC PATCH v3 1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC

2024-03-04 Thread Krzysztof Kozlowski
regulator-max-microvolt = <3300000>; > +}; Messed indentation here and in following lines.. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/3] dt-bindings: remoteproc: Add Arm remoteproc

2024-03-01 Thread Krzysztof Kozlowski
On 01/03/2024 17:42, abdellatif.elkhl...@arm.com wrote: > From: Abdellatif El Khlifi > > introduce the bindings for Arm remoteproc support. > > Signed-off-by: Abdellatif El Khlifi > --- > .../bindings/remoteproc/arm,rproc.yaml| 69 +++ > MAINTAINERS

Re: [PATCH 2/3] arm64: dts: Add corstone1000 external system device node

2024-03-01 Thread Krzysztof Kozlowski
On 01/03/2024 17:42, abdellatif.elkhl...@arm.com wrote: > From: Abdellatif El Khlifi > > add device tree node for the external system core in Corstone-1000 > > Signed-off-by: Abdellatif El Khlifi > --- > arch/arm64/boot/dts/arm/corstone1000.dtsi | 10 +- > 1 file changed, 9

  1   2   3   4   5   6   7   8   9   10   >