Hi Adrian,
On Wed, Nov 18, 2020 at 05:57:09PM +0200, Adrian Hunter wrote:
[...]
> >>> The follow diagram depicts the flow for how the AUX event is arriving
> >>> ahead than MMAP2 event:
> >>>
> >>>T1: T3: T4:
> >>> perf process Open PMU devicePerf is
Hi Adrian,
On Wed, Nov 18, 2020 at 01:15:32PM +0200, Adrian Hunter wrote:
> On 18/11/20 12:55 pm, Leo Yan wrote:
> > Perf tool relies on MMAP/MMAP2 events to prepare DSO maps, it allocates
> > DSO maps for MMAP/MMAP2 events which is used for parsing symbol. Thus,
> > durin
event will be inserted into ordered list ahead than AUX event
and also will be handled before AUX event.
Signed-off-by: Leo Yan
---
tools/perf/util/session.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
zywara escreveu:
> > > > On 11/11/2020 15:35, Arnaldo Carvalho de Melo wrote:
> > > >
> > > > Hi Arnaldo,
> > > >
> > > > thanks for taking a look!
> > > >
> > > > > Em Wed, Nov 11, 2020 at 03:11:33PM +0800, Leo
On Wed, Nov 11, 2020 at 03:01:27PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Nov 11, 2020 at 05:58:27PM +, Dave Martin escreveu:
> >
> > On Wed, Nov 11, 2020 at 05:39:22PM +, Arnaldo Carvalho de Melo wrote:
> > > Em Wed, Nov 11, 2020 at 03:45:23PM +, Andr� Przywara escreveu:
Include header linux/bitops.h, directly use its BIT() macro and remove
the self defined macros.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 5 +
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 3 +--
2 files changed
and
changes to use the flat conditions checking, this is directive and can
easily map to the descriptions in ARMv8-a architecture reference manual
(ARM DDI 0487E.a), chapter 'D10.1.5 Statistical Profiling Extension
protocol packet headers'.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
).
Suggested-by: Dave Martin
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 128 +-
tools/perf/util/arm-spe.c | 2 +-
2 files changed, 68 insertions(+), 62 deletions(-)
diff --git a/tools/perf/util/arm-sp
This patch moves out the address parsing code from arm_spe_pkt_desc()
and uses the new introduced function arm_spe_pkt_desc_addr() to process
address packet.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 64 +++
1 file
, it misses to support memory layouts with 64KB pages.
This patch adds the conditions for checking bits [55:52] are 0xf, if
detects the pattern it will fill 0xff into the top byte of the address,
also adds comment to explain the fixing up.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
Minor refactoring to use macro for index mask.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 2 +-
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools
Move the enums of event types to arm-spe-pkt-decoder.h, thus function
arm_spe_pkt_desc() can them for bitmasks.
Suggested-by: Andre Przywara
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-decoder.h| 17 --
.../arm-spe-decoder/arm-spe
This patch defines macros for counter packet header, and uses macros to
replace hard code values in functions arm_spe_get_counter() and
arm_spe_pkt_desc().
In the function arm_spe_get_counter(), adds a new line for more
readable.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools
This patch moves out the counter packet parsing code from
arm_spe_pkt_desc() to the new function arm_spe_pkt_desc_counter().
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 43 ---
1 file changed, 28 insertions(+), 15
This patch moves out the event packet parsing from arm_spe_pkt_desc()
to the new function arm_spe_pkt_desc_event().
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 63 +++
1 file changed, 37 insertions(+), 26 deletions
Suggested-by: Andre Przywara
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 9 +++--
.../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 14 ++
2 files changed, 9 insertions(+), 14 deletions(-)
diff --git a/tools/perf/ut
The operation type packet is complex and contains subclass; the parsing
flow causes deep indentation; for more readable, this patch introduces
a new function arm_spe_pkt_desc_op_type() which is used for operation
type parsing.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe
Defines macros for operation packet header and formats (support sub
classes for 'other', 'branch', 'load and store', etc). Uses these
macros for operation packet decoding and dumping.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 26
;
- The incomplete predicate and empty predicate fields in the Events
packet.
Signed-off-by: Wei Li
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 36 +--
.../arm-spe-decoder/arm-spe-pkt-decoder.h | 16 +
2
log and code for more
clear description.
Co-developed-by: Andre Przywara
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/arm-spe-decoder
Signed-off-by: Leo Yan
Reviewed-by: Dave Martin
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 6 +-
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
This patch is to refactor address packet handling, it defines macros for
address packet's header and payload, these macros are used by decoder
and the dump flow.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-decoder.c| 29 ---
.../arm
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 260 +-
1 file changed, 126 insertions(+), 134 deletions(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
b/tools/perf/util/arm-spe-decoder/arm-spe-pkt
lue.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
in
Fix a typo: s/iff/if.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
b/tools/perf/util/arm-spe-decoder/arm
This patch defines macro to extract "sz" field from header, and renames
the function payloadlen() to arm_spe_payload_len().
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 18 +-
1 file changed, 9 insert
ents for
the fixup (Andre);
- Added Andre's review tag (using "b4 am" command);
- Changed the macros to SPE_PKT_IS_XXX() format to check operation types
(Andre).
Andre Przywara (1):
perf arm_spe: Decode memory tagging properties
Leo Yan (20):
perf arm-spe: Include bitops.h for BI
.
So this patch refactors function arm_spe_get_payload() with a new
argument 'ext_hdr' for support extended header; the packet processing
flows can invoke this function to unify the packet length calculation.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt
On Tue, Nov 10, 2020 at 03:19:29PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 10, 2020 at 11:08:29AM -0700, Mathieu Poirier escreveu:
> > On Tue, Nov 10, 2020 at 02:34:17PM +0800, Leo Yan wrote:
> > > Since the commit 943b69ac1884 ("perf parse-events: Set exclude
On Mon, Nov 09, 2020 at 04:52:35PM +, André Przywara wrote:
> On 06/11/2020 01:41, Leo Yan wrote:
> > arm_spe_pkt_desc() returns the length of consumed the buffer for
> > the success case; otherwise, it delivers the return value from
> > arm_spe_pkt_snprintf(), and re
ranch sample's modifiers, so that allows the
testing to work as expected.
Fixes: 943b69ac1884 ("perf parse-events: Set exclude_guest=1 for user-space
counting")
Signed-off-by: Leo Yan
---
tools/perf/tests/shell/test_arm_coresight.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Fix a typo: s/devce_name/device_name.
Fixes: fe0aed19b266 ("perf test: Introduce script for Arm CoreSight testing")
Signed-off-by: Leo Yan
---
Resend patches for adding "Fixes" tags.
tools/perf/tests/shell/test_arm_coresight.sh | 2 +-
1 file changed, 1 insertion(+), 1 del
Fix a typo: s/devce_name/device_name.
Signed-off-by: Leo Yan
---
tools/perf/tests/shell/test_arm_coresight.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/test_arm_coresight.sh
b/tools/perf/tests/shell/test_arm_coresight.sh
index 8d84fdbed6a6
ranch sample's modifiers, so that allows the
testing to work as expected.
Signed-off-by: Leo Yan
---
tools/perf/tests/shell/test_arm_coresight.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/test_arm_coresight.sh
b/tools/perf/tests/shell/test_arm_coresight.sh
This patch adds Arm SPE events for perf memory profiling:
'spe-load': event for only recording memory load ops;
'spe-store': event for only recording memory store ops;
'spe-ldst': event for recording memory load and store ops.
Signed-off-by: Leo Yan
---
tools/perf/arch/arm64/util/Build
-by: Leo Yan
Acked-by: Ian Rogers
---
tools/perf/builtin-mem.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
index 21ebe0f47e64..72ce4b8fbb0f 100644
--- a/tools/perf/builtin-mem.c
+++ b/tools/perf/builtin-mem.c
This patch adds the AUX callbacks in session structure, so support
AUX trace for "perf c2c" tool; make itrace memory event as default for
"perf c2c", this tells the AUX trace decoder to synthesize samples and
can be used for statistics.
Signed-off-by: Leo Yan
---
tools/per
This patch is to add itrace option '-M' to synthesize memory event.
Signed-off-by: Leo Yan
---
tools/perf/Documentation/itrace.txt | 1 +
tools/perf/util/auxtrace.c | 4
tools/perf/util/auxtrace.h | 2 ++
3 files changed, 7 insertions(+)
diff --git a/tools/perf
tells the AUX trace decoder to synthesize memory
samples.
Signed-off-by: Leo Yan
---
tools/perf/builtin-mem.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
index 72ce4b8fbb0f..fdfbff7592f4 100644
--- a/tools/perf/builtin-me
hardware event is not located in
'/sys/devices/cpu/events/' so it cannot be enabled for memory profiling.
This patch changes to search folder from '/sys/devices/cpu/events/' to
'/sys/devices', so it give flexibility to find events which can be used
for memory profiling.
Signed-off-by: Leo Yan
Acked
the required
operation to PERF_MEM_EVENTS__LOAD_STORE if the arch supports it.
Otherwise, the tool still rolls back to enable events
PERF_MEM_EVENTS__LOAD and PERF_MEM_EVENTS__STORE.
Signed-off-by: Leo Yan
---
tools/perf/builtin-c2c.c | 17 +
1 file changed, 13 insertions(+), 4
;perf c2c: Support memory event
PERF_MEM_EVENTS__LOAD_STORE", so can convert the load/store requests
to event PERF_MEM_EVENTS__LOAD_STORE (James Clark).
Leo Yan (9):
perf mem: Search event name with more flexible path
perf mem: Introduce weak function perf_mem_events__ptr()
perf
by the
function perf_mem_events__ptr(), marks the variable as 'static', this
allows the architectures to define its own memory event array.
Signed-off-by: Leo Yan
---
tools/perf/builtin-c2c.c | 18 --
tools/perf/builtin-mem.c | 21 ++---
tools/perf/util/mem-events.c
PERF_MEM_EVENTS__LOAD_STORE, the tool rolls back to enable both events
PERF_MEM_EVENTS__LOAD and PERF_MEM_EVENTS__STORE, which keeps the same
behaviour with before.
Signed-off-by: Leo Yan
---
tools/perf/builtin-mem.c | 24 ++--
tools/perf/util/mem-events.c | 13
Hi Stephen,
On Thu, Nov 05, 2020 at 02:50:56PM -0800, Stephen Boyd wrote:
> Quoting Leo Yan (2020-02-19 21:26:52)
> > This patch series adds support for thread stack and callchain; this patch
> > set depends on the instruction sample fix patch set [1].
> >
> > This pat
Hi Andre, Dave,
On Mon, Nov 02, 2020 at 03:50:01PM +, André Przywara wrote:
[...]
> > int arm_spe_pkt_desc(const struct arm_spe_pkt *packet, char *buf,
> > size_t buf_len)
> > {
> > - int ret, ns, el, idx = packet->index;
> > + int ns, el, idx = packet->index;
> >
;
- The incomplete predicate and empty predicate fields in the Events
packet.
Signed-off-by: Wei Li
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 36 +--
.../arm-spe-decoder/arm-spe-pkt-decoder.h | 16 +
2
Signed-off-by: Leo Yan
Reviewed-by: Dave Martin
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 6 +-
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
Defines macros for operation packet header and formats (support sub
classes for 'other', 'branch', 'load and store', etc). Uses these
macros for operation packet decoding and dumping.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 26
log and code for more
clear description.
Co-developed-by: Andre Przywara
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/arm-spe-decoder
The operation type packet is complex and contains subclass; the parsing
flow causes deep indentation; for more readable, this patch introduces
a new function arm_spe_pkt_desc_op_type() which is used for operation
type parsing.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe
Minor refactoring to use macro for index mask.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 2 +-
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools
Move the enums of event types to arm-spe-pkt-decoder.h, thus function
arm_spe_pkt_desc() can them for bitmasks.
Suggested-by: Andre Przywara
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-decoder.h| 17 --
.../arm-spe-decoder/arm-spe
This patch moves out the counter packet parsing code from
arm_spe_pkt_desc() to the new function arm_spe_pkt_desc_counter().
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 43 ---
1 file changed, 28 insertions(+), 15
Suggested-by: Andre Przywara
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 9 +++--
.../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 14 ++
2 files changed, 9 insertions(+), 14 deletions(-)
diff --git a/tools/perf/ut
, it misses to support memory layouts with 64KB pages.
This patch adds the conditions for checking bits [55:52] are 0xf, if
detects the pattern it will fill 0xff into the top byte of the address,
also adds comment to explain the fixing up.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
This patch moves out the event packet parsing from arm_spe_pkt_desc()
to the new function arm_spe_pkt_desc_event().
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 63 +++
1 file changed, 37 insertions(+), 26 deletions
This patch defines macros for counter packet header, and uses macros to
replace hard code values in functions arm_spe_get_counter() and
arm_spe_pkt_desc().
In the function arm_spe_get_counter(), adds a new line for more
readable.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools
).
Suggested-by: Dave Martin
Signed-off-by: Leo Yan
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 128 +-
tools/perf/util/arm-spe.c | 2 +-
2 files changed, 68 insertions(+), 62 deletions(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decod
and
changes to use the flat conditions checking, this is directive and can
easily map to the descriptions in ARMv8-a architecture reference manual
(ARM DDI 0487E.a), chapter 'D10.1.5 Statistical Profiling Extension
protocol packet headers'.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
.
So this patch refactors function arm_spe_get_payload() with a new
argument 'ext_hdr' for support extended header; the packet processing
flows can invoke this function to unify the packet length calculation.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt
This patch moves out the address parsing code from arm_spe_pkt_desc()
and uses the new introduced function arm_spe_pkt_desc_addr() to process
address packet.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 64 +++
1 file
This patch is to refactor address packet handling, it defines macros for
address packet's header and payload, these macros are used by decoder
and the dump flow.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-decoder.c| 29 ---
.../arm
lue.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
in
Fix a typo: s/iff/if.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
b/tools/perf/util/arm-spe-decoder/arm
This patch defines macro to extract "sz" field from header, and renames
the function payloadlen() to arm_spe_payload_len().
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 18 +-
1 file changed, 9 insert
Signed-off-by: Leo Yan
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 260 +-
1 file changed, 126 insertions(+), 134 deletions(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
index 04fd7fd7c15f
to check operation types
(Andre).
Andre Przywara (1):
perf arm_spe: Decode memory tagging properties
Leo Yan (20):
perf arm-spe: Include bitops.h for BIT() macro
perf arm-spe: Fix a typo in comment
perf arm-spe: Refactor payload size calculation
perf arm-spe: Refactor arm_spe_
Include header linux/bitops.h, directly use its BIT() macro and remove
the self defined macros.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 5 +
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 3 +--
2 files changed
".
Fixes: e4cef1f65061 ("perf lock: Fix state machine to recognize lock sequence")
Signed-off-by: Leo Yan
Acked-by: Jiri Olsa
---
v3: Corrected "Fixes" tag to reflect the first patch causing the issue
(Jiri)
tools/perf/builtin-lock.c | 2 +-
1 file changed, 1 insertio
he field name "flag" with "flags", so can read out
the correct flags for locking.
Fixes: e4cef1f65061 ("perf lock: Fix state machine to recognize lock sequence")
Signed-off-by: Leo Yan
Acked-by: Jiri Olsa
---
tools/perf/builtin-lock.c | 2 +-
1 file changed, 1 insertio
On Tue, Nov 03, 2020 at 12:13:04PM +, Dave Martin wrote:
> On Tue, Nov 03, 2020 at 10:13:49AM +, André Przywara wrote:
> > On 03/11/2020 06:40, Leo Yan wrote:
> >
> > Hi Dave, Leo,
> >
> > > On Mon, Nov 02, 2020 at 05:06:53PM +, Dave Martin wrote:
On Mon, Nov 02, 2020 at 04:25:36PM +, Dave Martin wrote:
> On Fri, Oct 30, 2020 at 02:57:23AM +0000, Leo Yan wrote:
> > From: Andre Przywara
> >
> > When SPE records a physical address, it can additionally tag the event
> > with information from the Memory Tag
Hi Dave,
On Mon, Nov 02, 2020 at 05:06:53PM +, Dave Martin wrote:
> On Fri, Oct 30, 2020 at 02:57:09AM +0000, Leo Yan wrote:
> > When outputs strings to the decoding buffer with function snprintf(),
> > SPE decoder needs to detects if any error returns from snprintf() and
On Mon, Nov 02, 2020 at 03:50:01PM +, André Przywara wrote:
> On 30/10/2020 02:57, Leo Yan wrote:
> > When outputs strings to the decoding buffer with function snprintf(),
> > SPE decoder needs to detects if any error returns from snprintf() and if
> > so needs
On Mon, Nov 02, 2020 at 05:56:26PM +0100, Jiri Olsa wrote:
> On Wed, Oct 21, 2020 at 08:39:48AM +0800, Leo Yan wrote:
> > When execute command "perf lock report", it hits failure and outputs log
> > as follows:
> >
> > perf: builtin-lock.c:623: report_lock
On Mon, Nov 02, 2020 at 05:42:13PM +0100, Jiri Olsa wrote:
> On Wed, Oct 21, 2020 at 08:39:47AM +0800, Leo Yan wrote:
> > The tracepoint "lock:lock_acquire" contains field "flags" but not
> > "flag". Current code wrongly retrieves value from field &qu
Hi Jiri,
On Wed, Oct 21, 2020 at 08:39:47AM +0800, Leo Yan wrote:
> The tracepoint "lock:lock_acquire" contains field "flags" but not
> "flag". Current code wrongly retrieves value from field "flag" and it
> always gets zero for the value, thu
Hi Jiri,
On Sat, Oct 31, 2020 at 09:21:03PM +0100, Jiri Olsa wrote:
> On Wed, Oct 28, 2020 at 02:38:10PM +0800, Leo Yan wrote:
> > This patches adds the AUX callbacks in session structure, so support
> > AUX trace for "perf c2c" tool.
> >
> > Signed-off
On Sat, Oct 31, 2020 at 09:23:07PM +0100, Jiri Olsa wrote:
> On Wed, Oct 28, 2020 at 02:38:07PM +0800, Leo Yan wrote:
>
> SNIP
>
> > struct stat st;
> >
> > + /*
> > +* If the event entry isn't valid, skip initialization
Signed-off-by: Leo Yan
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 6 +-
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
b/tools/perf/util/arm-spe
;
- The incomplete predicate and empty predicate fields in the Events
packet.
Signed-off-by: Wei Li
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 39 ++-
.../arm-spe-decoder/arm-spe-pkt-decoder.h | 16
2
Defines macros for operation packet header and formats (support sub
classes for 'other', 'branch', 'load and store', etc). Uses these
macros for operation packet decoding and dumping.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 26
.
So this patch refactors function arm_spe_get_payload() with a new
argument 'ext_hdr' for support extended header; the packet processing
flows can invoke this function to unify the packet length calculation.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt
' as the function's local
variable, this allows to remove the unnecessary braces and improve the
readability.
Suggested-by: Dave Martin
Signed-off-by: Leo Yan
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 267 --
1 file changed, 117 insertions(+), 150 deletions(-)
diff --git
log and code for more
clear description.
Co-developed-by: Andre Przywara
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/arm-spe-decoder
, it misses to support memory layouts with 64KB pages.
This patch adds the conditions for checking bits [55:52] are 0xf, if
detects the pattern it will fill 0xff into the top byte of the address,
also adds comment to explain the fixing up.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
The operation type packet is complex and contains subclass; the parsing
flow causes deep indentation; for more readable, this patch introduces
a new function arm_spe_pkt_desc_op_type() which is used for operation
type parsing.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe
This patch defines macros for counter packet header, and uses macros to
replace hard code values in functions arm_spe_get_counter() and
arm_spe_pkt_desc().
In the function arm_spe_get_counter(), adds a new line for more
readable.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools
Minor refactoring to use macro for index mask.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 2 +-
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools
Move the enums of event types to arm-spe-pkt-decoder.h, thus function
arm_spe_pkt_desc() can them for bitmasks.
Suggested-by: Andre Przywara
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-decoder.h| 17 --
.../arm-spe-decoder/arm-spe
This patch moves out the counter packet parsing code from
arm_spe_pkt_desc() to the new function arm_spe_pkt_desc_counter().
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 48 +++
1 file changed, 29 insertions(+), 19
This patch moves out the address parsing code from arm_spe_pkt_desc()
and uses the new introduced function arm_spe_pkt_desc_addr() to process
address packet.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 50 ---
1 file
and
changes to use the flat conditions checking, this is directive and can
easily map to the descriptions in ARMv8-a architecture reference manual
(ARM DDI 0487E.a), chapter 'D10.1.5 Statistical Profiling Extension
protocol packet headers'.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
Suggested-by: Andre Przywara
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 9 +++--
.../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 14 ++
2 files changed, 9 insertions(+), 14 deletions(-)
diff --git a/tools/perf/ut
This patch moves out the event packet parsing from arm_spe_pkt_desc()
to the new function arm_spe_pkt_desc_event().
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 66 +++
1 file changed, 38 insertions(+), 28 deletions
This patch is to refactor address packet handling, it defines macros for
address packet's header and payload, these macros are used by decoder
and the dump flow.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-decoder.c| 29 ---
.../arm
This patch defines macro to extract "sz" field from header, and renames
the function payloadlen() to arm_spe_payload_len().
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
.../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 18 +-
1 file changed, 9 insert
Fix a typo: s/iff/if.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
b/tools/perf/util/arm-spe-decoder/arm
Include header linux/bitops.h, directly use its BIT() macro and remove
the self defined macros.
Signed-off-by: Leo Yan
Reviewed-by: Andre Przywara
---
tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 5 +
tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 3 +--
2 files changed
201 - 300 of 2571 matches
Mail list logo
