Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

On Sun, Sep 11, 2016 at 11:52:35AM -0600, Jason Gunthorpe wrote: > On Sun, Sep 11, 2016 at 07:24:45PM +0200, Christoph Hellwig wrote: > > > > > I've posted some initial work toward a) a while ago, and once we > > > > > > Did it get merged? Do you have a pointer? > > > >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

On Sun, Sep 11, 2016 at 11:52:35AM -0600, Jason Gunthorpe wrote: > On Sun, Sep 11, 2016 at 07:24:45PM +0200, Christoph Hellwig wrote: > > > > > I've posted some initial work toward a) a while ago, and once we > > > > > > Did it get merged? Do you have a pointer? > > > >

Re: [PATCH 07/26] net/mlx4_core: constify local structures

igned-off-by: Julia Lawall <julia.law...@lip6.fr> Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH 07/26] net/mlx4_core: constify local structures

sed to a top-level macro call > 4. No pointer or array-typed field passed to a function or stored in a > variable. > Declare structures having all of these properties as const. > > Done using Coccinelle. > Based on a suggestion by Joe Perches . > > Signed-off-by: Julia Law

Re: [PATCH] IB/rdmavt: free the userspace memory region with kfree instead of vfree

y using kfree to free it. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> > --- > drivers/infiniband/sw/rdmavt/mr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driver

Re: [PATCH] IB/rdmavt: free the userspace memory region with kfree instead of vfree

Signed-off-by: Colin Ian King Thanks, Reviewed-by: Leon Romanovsky > --- > drivers/infiniband/sw/rdmavt/mr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/sw/rdmavt/mr.c > b/drivers/infiniband/sw/rdmavt/mr.c > index 80c4b6b..46

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

On Sun, Sep 11, 2016 at 03:34:21PM +0200, Christoph Hellwig wrote: > On Sat, Sep 10, 2016 at 11:01:51AM -0600, Jason Gunthorpe wrote: > > Sadly, it isn't a step backwards, it is status quo - at least as far > > as the uapi is concerned. > > Sort of, see below: > > > struct mlx5_create_cq { > >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

On Sun, Sep 11, 2016 at 03:34:21PM +0200, Christoph Hellwig wrote: > On Sat, Sep 10, 2016 at 11:01:51AM -0600, Jason Gunthorpe wrote: > > Sadly, it isn't a step backwards, it is status quo - at least as far > > as the uapi is concerned. > > Sort of, see below: > > > struct mlx5_create_cq { > >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

On Wed, Sep 07, 2016 at 08:37:23PM +0530, Parav Pandit wrote: > Hi Leon, > > >> Signed-off-by: Parav Pandit > >> +static struct rdmacg_resource_pool * > >> +get_cg_rpool_locked(struct rdma_cgroup *cg, struct rdmacg_device *device) > >> +{ > >> + struct

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

On Wed, Sep 07, 2016 at 08:37:23PM +0530, Parav Pandit wrote: > Hi Leon, > > >> Signed-off-by: Parav Pandit > >> +static struct rdmacg_resource_pool * > >> +get_cg_rpool_locked(struct rdma_cgroup *cg, struct rdmacg_device *device) > >> +{ > >> + struct rdmacg_resource_pool *rpool; > >> + > >>

Re: [PATCH] RDS: Simplify code

On Mon, Sep 05, 2016 at 06:38:21AM +0200, Christophe JAILLET wrote: > Le 04/09/2016 à 20:23, Leon Romanovsky a écrit : > >On Sun, Sep 04, 2016 at 05:57:20PM +0200, Christophe JAILLET wrote: > >>Le 04/09/2016 à 14:20, Leon Romanovsky a écrit : > >>>On Sat, Se

Re: [PATCH] RDS: Simplify code

On Mon, Sep 05, 2016 at 06:38:21AM +0200, Christophe JAILLET wrote: > Le 04/09/2016 à 20:23, Leon Romanovsky a écrit : > >On Sun, Sep 04, 2016 at 05:57:20PM +0200, Christophe JAILLET wrote: > >>Le 04/09/2016 à 14:20, Leon Romanovsky a écrit : > >>>On Sat, Se

Re: [PATCH] RDS: Simplify code

On Sun, Sep 04, 2016 at 05:57:20PM +0200, Christophe JAILLET wrote: > Le 04/09/2016 à 14:20, Leon Romanovsky a écrit : > >On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote: > >>Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to >

Re: [PATCH] RDS: Simplify code

On Sun, Sep 04, 2016 at 05:57:20PM +0200, Christophe JAILLET wrote: > Le 04/09/2016 à 14:20, Leon Romanovsky a écrit : > >On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote: > >>Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to >

Re: [PATCH] RDS: Simplify code

On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote: > Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to > 'list_splice_init'. It is not 100% accurate list_splice(y, z) INIT_LIST_HEAD(y) ==> if (!list_empty(y)) __list_splice(y, z, z>next);

Re: [PATCH] RDS: Simplify code

On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote: > Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to > 'list_splice_init'. It is not 100% accurate list_splice(y, z) INIT_LIST_HEAD(y) ==> if (!list_empty(y)) __list_splice(y, z, z>next);

Re: [PATCH 1/2] IB/hfi1: Fix a parameter of find_first_bit.

On Fri, Sep 02, 2016 at 10:39:11AM -0400, Doug Ledford wrote: > On 8/28/2016 2:06 AM, Leon Romanovsky wrote: > > On Fri, Aug 26, 2016 at 03:34:48PM -0400, Doug Ledford wrote: > >> On 8/26/2016 3:29 PM, Leon Romanovsky wrote: > >>> On Fri, Aug 26, 2016 at 02:01:

Re: [PATCH 1/2] IB/hfi1: Fix a parameter of find_first_bit.

On Fri, Sep 02, 2016 at 10:39:11AM -0400, Doug Ledford wrote: > On 8/28/2016 2:06 AM, Leon Romanovsky wrote: > > On Fri, Aug 26, 2016 at 03:34:48PM -0400, Doug Ledford wrote: > >> On 8/26/2016 3:29 PM, Leon Romanovsky wrote: > >>> On Fri, Aug 26, 2016 at 02:01:

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

On Wed, Aug 31, 2016 at 02:07:25PM +0530, Parav Pandit wrote: > Added rdma cgroup controller that does accounting, limit enforcement > on rdma/IB verbs and hw resources. > > Added rdma cgroup header file which defines its APIs to perform > charing/uncharing functionality. It also defined APIs for

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

On Wed, Aug 31, 2016 at 02:07:25PM +0530, Parav Pandit wrote: > Added rdma cgroup controller that does accounting, limit enforcement > on rdma/IB verbs and hw resources. > > Added rdma cgroup header file which defines its APIs to perform > charing/uncharing functionality. It also defined APIs for

Re: [PATCH v2] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible

Except the fact that we have a little bit different format for title ==> "IB/cxgb4: Mark symbols static for _free_qp" Looks ok, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH v2] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible

Except the fact that we have a little bit different format for title ==> "IB/cxgb4: Mark symbols static for _free_qp" Looks ok, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH 1/2] IB/hfi1: Fix a parameter of find_first_bit.

On Fri, Aug 26, 2016 at 03:34:48PM -0400, Doug Ledford wrote: > On 8/26/2016 3:29 PM, Leon Romanovsky wrote: > > On Fri, Aug 26, 2016 at 02:01:55PM -0400, Doug Ledford wrote: > >> On 8/26/2016 9:35 AM, Doug Ledford wrote: > >>> On 8/26/2016 12:49 AM, Christophe

Re: [PATCH 1/2] IB/hfi1: Fix a parameter of find_first_bit.

On Fri, Aug 26, 2016 at 03:34:48PM -0400, Doug Ledford wrote: > On 8/26/2016 3:29 PM, Leon Romanovsky wrote: > > On Fri, Aug 26, 2016 at 02:01:55PM -0400, Doug Ledford wrote: > >> On 8/26/2016 9:35 AM, Doug Ledford wrote: > >>> On 8/26/2016 12:49 AM, Christophe

Re: [PATCH 1/2] IB/hfi1: Fix a parameter of find_first_bit.

On Fri, Aug 26, 2016 at 02:01:55PM -0400, Doug Ledford wrote: > On 8/26/2016 9:35 AM, Doug Ledford wrote: > > On 8/26/2016 12:49 AM, Christophe JAILLET wrote: > >> The 2nd parameter of 'find_first_bit' is the number of bits to search. > >> In this case, we are passing 'sizeof(unsigned long)' which

Re: [PATCH 1/2] IB/hfi1: Fix a parameter of find_first_bit.

On Fri, Aug 26, 2016 at 02:01:55PM -0400, Doug Ledford wrote: > On 8/26/2016 9:35 AM, Doug Ledford wrote: > > On 8/26/2016 12:49 AM, Christophe JAILLET wrote: > >> The 2nd parameter of 'find_first_bit' is the number of bits to search. > >> In this case, we are passing 'sizeof(unsigned long)' which

Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit

ILLET <christophe.jail...@wanadoo.fr> Thanks, Acked-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit

number of bits of 'tmp' was expected here. So use > BITS_PER_LONG instead. > > It has been spotted by the following coccinelle script: > @@ > expression ret, x; > > @@ > * ret = \(find_first_bit \| find_first_zero_bit\) (x, sizeof(...)); > > Signed-off-by: Christoph

Re: [PATCH for-next 2/2] IB/hns: Add support of ACPI to the Hisilicon RoCE driver

On Wed, Aug 24, 2016 at 02:25:12PM +, Salil Mehta wrote: > > It looks like we should retain the int as a return type or if you have > some other opinion or if I have missed something here please share :) Thanks for the explanation. > > Best regards > Salil signature.asc Description: PGP

Re: [PATCH for-next 2/2] IB/hns: Add support of ACPI to the Hisilicon RoCE driver

On Wed, Aug 24, 2016 at 02:25:12PM +, Salil Mehta wrote: > > It looks like we should retain the int as a return type or if you have > some other opinion or if I have missed something here please share :) Thanks for the explanation. > > Best regards > Salil signature.asc Description: PGP

Re: [PATCH for-next 2/2] IB/hns: Add support of ACPI to the Hisilicon RoCE driver

On Wed, Aug 24, 2016 at 04:44:50AM +0800, Salil Mehta wrote: > This patch is meant to add support of ACPI to the Hisilicon RoCE > driver. > > Changes done are primarily meant to detect the type and then either > use DT specific or ACPI spcific functions. Where ever possible, > this patch tries to

Re: [PATCH for-next 2/2] IB/hns: Add support of ACPI to the Hisilicon RoCE driver

On Wed, Aug 24, 2016 at 04:44:50AM +0800, Salil Mehta wrote: > This patch is meant to add support of ACPI to the Hisilicon RoCE > driver. > > Changes done are primarily meant to detect the type and then either > use DT specific or ACPI spcific functions. Where ever possible, > this patch tries to

Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h

the Mellanox ethernet driver. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> I assume that it passed 0-day builds. Except the commit message, which doesn't follow SubmittingPatches guide, it looks good. Reviewed-by: Leon Romanovsky <leo...@mellanox.com> Thanks signature.asc Description: PGP signature

Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h

r. > > Signed-off-by: Chris Wilson I assume that it passed 0-day builds. Except the commit message, which doesn't follow SubmittingPatches guide, it looks good. Reviewed-by: Leon Romanovsky Thanks signature.asc Description: PGP signature

Re: [PATCH 16/22] IB/mlx4: Remove deprecated create_singlethread_workqueue

gt;work. > It has been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com> > --- > drivers/infiniband/hw/mlx4/main.c | 2 +- > 1 file changed, 1 i

Re: [PATCH 16/22] IB/mlx4: Remove deprecated create_singlethread_workqueue

gt;work. > It has been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar > --- > drivers/infiniband/hw/mlx4/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue

work (maps to > cache_work_func) and >dwork(maps to delayed_cache_work_func). > It has been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.co

Re: [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue

work (maps to > cache_work_func) and >dwork(maps to delayed_cache_work_func). > It has been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar Thanks, Acked-by: Leon Romanovsky &g

Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation

On Fri, Aug 19, 2016 at 03:27:20PM +, Marciniszyn, Mike wrote: > > Subject: [PATCH] IB/qib: Use memdup_user() rather than duplicating its > > diff --git a/drivers/infiniband/hw/qib/qib_fs.c > > I would be even more aggressive at reducing lines of code. > > For example do direct returns when

Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation

On Fri, Aug 19, 2016 at 03:27:20PM +, Marciniszyn, Mike wrote: > > Subject: [PATCH] IB/qib: Use memdup_user() rather than duplicating its > > diff --git a/drivers/infiniband/hw/qib/qib_fs.c > > I would be even more aggressive at reducing lines of code. > > For example do direct returns when

Re: [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue

_guid_work. > It has been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com> Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> > --- &

Re: [PATCH 22/22] IB/mlx4/alias_GUID: Remove deprecated create_singlethread_workqueue

_guid_work. > It has been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar Thanks, Reviewed-by: Leon Romanovsky > --- > drivers/infiniband/hw/mlx4/alias_GUID.c | 2

Re: [PATCH 18/22] IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue

>work > and >timeout_work. > > The workqueue "clean_wq" queues work item mcg_clean_task. > > Both have been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar <

Re: [PATCH 18/22] IB/mlx4/mcg: Remove deprecated create_singlethread_workqueue

>work > and >timeout_work. > > The workqueue "clean_wq" queues work item mcg_clean_task. > > Both have been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar > ---

Re: [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue

- > drivers/infiniband/hw/mlx5/mr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, Acked-by: Leon Romanovsky <leo...@mellanox.com> > > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c > index 8cf2ce5..fb0194d 100644 > --- a/dr

Re: [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue

lx5/mr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, Acked-by: Leon Romanovsky > > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c > index 8cf2ce5..fb0194d 100644 > --- a/drivers/infiniband/hw/mlx5/mr.c > +++ b/drivers/infiniba

Re: [PATCH 17/22] IB/mlx4/mad: Remove deprecated create_singlethread_workqueue

e workqueue "ud_wq" > queues work item [i]->work. > > Both the workqueues have been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@g

Re: [PATCH 17/22] IB/mlx4/mad: Remove deprecated create_singlethread_workqueue

e workqueue "ud_wq" > queues work item [i]->work. > > Both the workqueues have been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar Thanks, Reviewed-by: Leon Romanovs

Re: [PATCH 15/22] IB/mlx5/odp: Remove deprecated create_singlethread_workqueue

m _pfault->work. > It has been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com> Thanks, Acked-by: Leon Romanovsky <leo...@mellanox.com> &g

Re: [PATCH 15/22] IB/mlx5/odp: Remove deprecated create_singlethread_workqueue

m _pfault->work. > It has been identity converted. > > WQ_MEM_RECLAIM has been set to ensure forward progress under > memory pressure. > > Signed-off-by: Bhaktipriya Shridhar Thanks, Acked-by: Leon Romanovsky > --- > drivers/infiniband/hw/mlx5/odp.c | 4 ++-- > 1

Re: [PATCH 00/22] Remove deprecated create_workqueue instances

On Mon, Aug 15, 2016 at 11:27:01PM +0530, Bhaktipriya Shridhar wrote: > This patch set removes the instances of deprecated > create_singlethread_workqueue (scheduled for removal) in > drivers/infiniband by making the appropriate conversions. > > Bhaktipriya Shridhar (22): > IB/sa : Remove

Re: [PATCH 00/22] Remove deprecated create_workqueue instances

On Mon, Aug 15, 2016 at 11:27:01PM +0530, Bhaktipriya Shridhar wrote: > This patch set removes the instances of deprecated > create_singlethread_workqueue (scheduled for removal) in > drivers/infiniband by making the appropriate conversions. > > Bhaktipriya Shridhar (22): > IB/sa : Remove

Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation

On Fri, Aug 19, 2016 at 03:42:29PM +, Marciniszyn, Mike wrote: > > > > > > The bail_tmp: label is then not needed. > > > > You still need to free tmp allocation if qib_eeprom_write failed and this is > > your bail_tmp. > > > > Typo. The bail: label is not needed. Yeah, it makes sense.

Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation

On Fri, Aug 19, 2016 at 03:42:29PM +, Marciniszyn, Mike wrote: > > > > > > The bail_tmp: label is then not needed. > > > > You still need to free tmp allocation if qib_eeprom_write failed and this is > > your bail_tmp. > > > > Typo. The bail: label is not needed. Yeah, it makes sense.

Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation

issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH] IB/qib: Use memdup_user() rather than duplicating its implementation

e Coccinelle software. > > Signed-off-by: Markus Elfring Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: linux-next: build failure after merge of Linus' tree

On Mon, Aug 8, 2016 at 6:37 PM, Doug Ledford wrote: > On 8/7/2016 9:58 PM, Stephen Rothwell wrote: >> Hi all, >> >> With Linus' tree, today's linux-next build (powerpc allyesconfig) failed >> like this: >> >> drivers/infiniband/sw/built-in.o:(.opd+0x1698): multiple definition

Re: linux-next: build failure after merge of Linus' tree

On Mon, Aug 8, 2016 at 6:37 PM, Doug Ledford wrote: > On 8/7/2016 9:58 PM, Stephen Rothwell wrote: >> Hi all, >> >> With Linus' tree, today's linux-next build (powerpc allyesconfig) failed >> like this: >> >> drivers/infiniband/sw/built-in.o:(.opd+0x1698): multiple definition of >> `copy_data'

Re: [PATCH 0266/1285] Replace numeric parameter like 0444 with macro

onding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng@intel.com> > Signed-off-by: Baole Ni <baolex...@intel.com> L

Re: [PATCH 0266/1285] Replace numeric parameter like 0444 with macro

onding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni Looks good, Reviewed-By: Leon Romanovsky > --- > d

Re: [PATCH 0261/1285] Replace numeric parameter like 0444 with macro

onding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng@intel.com> > Signed-off-by: Baole Ni <baolex...@intel.com> &

Re: [PATCH 0261/1285] Replace numeric parameter like 0444 with macro

onding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- Thanks, Acked-by: Leon Romanovsky > drivers/infi

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Mon, Aug 01, 2016 at 11:11:19AM -0400, Tejun Heo wrote: > > Right now, I'm feeling that I'm participating in soapie where one sends > > patch for every line, waits and sends the same patch for another file. > > It is worth to send one patch set and let us to test it all in once. > > Yeah, I

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Mon, Aug 01, 2016 at 11:11:19AM -0400, Tejun Heo wrote: > > Right now, I'm feeling that I'm participating in soapie where one sends > > patch for every line, waits and sends the same patch for another file. > > It is worth to send one patch set and let us to test it all in once. > > Yeah, I

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Fri, Jul 29, 2016 at 08:22:37AM -0400, Tejun Heo wrote: > Hello, > > On Thu, Jul 28, 2016 at 12:37:35PM +0300, Leon Romanovsky wrote: > > Did you test this patch? Did you notice the memory reclaim path nature > > of this work? > > The conversion uses WQ_MEM_RECLAIM

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Fri, Jul 29, 2016 at 08:22:37AM -0400, Tejun Heo wrote: > Hello, > > On Thu, Jul 28, 2016 at 12:37:35PM +0300, Leon Romanovsky wrote: > > Did you test this patch? Did you notice the memory reclaim path nature > > of this work? > > The conversion uses WQ_MEM_RECLAIM

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Thu, Jul 28, 2016 at 01:49:49PM +0530, Bhaktipriya Shridhar wrote: > A dedicated workqueue has been used since the work items are being used > on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward > progress under memory pressure. > > The workqueue has a single work item.

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Thu, Jul 28, 2016 at 01:49:49PM +0530, Bhaktipriya Shridhar wrote: > A dedicated workqueue has been used since the work items are being used > on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward > progress under memory pressure. > > The workqueue has a single work item.

Re: [PATCH 1/1] Drivers: infiniband: hw: vmbus-nd: NetworkDirect driver for Linux

On Tue, Jul 26, 2016 at 07:05:37PM -0700, k...@exchange.microsoft.com wrote: > From: K. Y. Srinivasan > > This driver is a bridge driver that surfaces a Mellanox device in the Linux > guest and plugs into > the "NetworkDirect" RDMA infrastructure on the Windows host. Only a

Re: [PATCH 1/1] Drivers: infiniband: hw: vmbus-nd: NetworkDirect driver for Linux

On Tue, Jul 26, 2016 at 07:05:37PM -0700, k...@exchange.microsoft.com wrote: > From: K. Y. Srinivasan > > This driver is a bridge driver that surfaces a Mellanox device in the Linux > guest and plugs into > the "NetworkDirect" RDMA infrastructure on the Windows host. Only a subset of > the

Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

ng tasks while disconnecting the driver. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com> > --- > Changes in v2: > -Updated commit description as per the feedback received. > > drivers/net/ethernet/mellanox/mlx5/core/health.c | 7 ++- > 1

Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

ng tasks while disconnecting the driver. > > Signed-off-by: Bhaktipriya Shridhar > --- > Changes in v2: > -Updated commit description as per the feedback received. > > drivers/net/ethernet/mellanox/mlx5/core/health.c | 7 ++- > 1 file changed, 2 insertions(+), 5 d

Re: [PATCH 2/3] IB/mthca: Less function calls in mthca_reset() after error detection

the passed variables "bridge_header" > and "hca_header" contained a null pointer. > > Adjust jump targets according to the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Thanks, Reviewed-by: Leon Romanov

Re: [PATCH 2/3] IB/mthca: Less function calls in mthca_reset() after error detection

"bridge_header" > and "hca_header" contained a null pointer. > > Adjust jump targets according to the Linux coding style convention. > > Signed-off-by: Markus Elfring Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: Digital signature

Re: [PATCH 1/3] IB/mthca: Delete an unnecessary check before the function call "pci_dev_put"

test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: Digital signature

Re: [PATCH 1/3] IB/mthca: Delete an unnecessary check before the function call "pci_dev_put"

> > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: Digital signature

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Jul 19, 2016 at 10:49:57AM -0700, Joe Perches wrote: > On Tue, 2016-07-19 at 20:26 +0300, Leon Romanovsky wrote: > > On Tue, Jul 19, 2016 at 02:09:25PM +0300, Netanel Belgazal wrote: > > > This is the debugging message interface. > > > https://www.kernel.org/d

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Jul 19, 2016 at 10:49:57AM -0700, Joe Perches wrote: > On Tue, 2016-07-19 at 20:26 +0300, Leon Romanovsky wrote: > > On Tue, Jul 19, 2016 at 02:09:25PM +0300, Netanel Belgazal wrote: > > > This is the debugging message interface. > > > https://www.kernel.org/d

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Jul 19, 2016 at 02:09:25PM +0300, Netanel Belgazal wrote: > > > On 07/15/2016 08:00 AM, Leon Romanovsky wrote: > > On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > >> This is a driver for the ENA family of networking devices. > >> >

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Jul 19, 2016 at 02:09:25PM +0300, Netanel Belgazal wrote: > > > On 07/15/2016 08:00 AM, Leon Romanovsky wrote: > > On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > >> This is a driver for the ENA family of networking devices. > >> >

Re: [PATCH] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

On Sat, Jul 16, 2016 at 01:29:20PM +0530, Bhaktipriya Shridhar wrote: > The workqueue health->wq was used as per device private health thread. > This was done so that system error handling could be processed > concurrently. Not exactly, AFAIK it was intended to perform delayed work and not

Re: [PATCH] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

On Sat, Jul 16, 2016 at 01:29:20PM +0530, Bhaktipriya Shridhar wrote: > The workqueue health->wq was used as per device private health thread. > This was done so that system error handling could be processed > concurrently. Not exactly, AFAIK it was intended to perform delayed work and not

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Fri, Jul 15, 2016 at 08:17:59AM -0700, Benjamin Poirier wrote: > On 2016/07/15 08:00, Leon Romanovsky wrote: > > On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > > > This is a driver for the ENA family of networking devices. > > > > > > S

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Fri, Jul 15, 2016 at 08:17:59AM -0700, Benjamin Poirier wrote: > On 2016/07/15 08:00, Leon Romanovsky wrote: > > On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > > > This is a driver for the ENA family of networking devices. > > > > >

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > This is a driver for the ENA family of networking devices. > > Signed-off-by: Netanel Belgazal > --- > > Notes: ... > - Increase driver version to 1.0.2 ... > +static void

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > This is a driver for the ENA family of networking devices. > > Signed-off-by: Netanel Belgazal > --- > > Notes: ... > - Increase driver version to 1.0.2 ... > +static void ena_get_drvinfo(struct net_device *dev, > +

Re: [PATCH v11 21/22] IB/hns: Kconfig and Makefile for RoCE module

16/3/22/609 > > PATCH V3: > This fixes the comments given by Leon Romanovsky over the PATCH v2: > Link: https://lkml.org/lkml/2016/3/20/5 > > PATCH v2: > This fixes the comments given by Leon Romanovsky over the PATCH v1: > Link: https://lkml.org/lkml/2016/3/6/94 > Fixes the

Re: [PATCH v11 21/22] IB/hns: Kconfig and Makefile for RoCE module

t; > PATCH v10/v9/v8/v7/v6/v5: > - No change over the PATCH v4 > > PATCH v4: > This fixes the comments given by Christoph Hellwig over the PATCH v3: > Link: https://lkml.org/lkml/2016/3/22/609 > > PATCH V3: > This fixes the comments given by Leon Romanovsky over

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

On Thu, Jul 14, 2016 at 11:43:59AM +0800, oulijun wrote: > 在 2016/7/2 17:39, Lijun Ou 写道: > > > Hi, Doug & Sean Hefty & Hal Rosenstock > "Hello, I understand that maintainer is dealing with lots of patches not just > mine. Also, I could not see any further review comments from the community. >

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

On Thu, Jul 14, 2016 at 11:43:59AM +0800, oulijun wrote: > 在 2016/7/2 17:39, Lijun Ou 写道: > > > Hi, Doug & Sean Hefty & Hal Rosenstock > "Hello, I understand that maintainer is dealing with lots of patches not just > mine. Also, I could not see any further review comments from the community. >

Re: [PATCH] net/mlx4: Fix some indent inconsistancy

witch' block. > > Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Thanks Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: Digital signature

Re: [PATCH] net/mlx4: Fix some indent inconsistancy

witch' block. > > Signed-off-by: Christophe JAILLET Thanks Reviewed-by: Leon Romanovsky signature.asc Description: Digital signature

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

On Sat, Jul 02, 2016 at 05:39:02PM +0800, Lijun Ou wrote: This v11 > 28 files changed, 10626 insertions(+), 1 deletion(-) First version > 27 files changed, 11670 insertions(+), 11 deletions(-) 1K LOC less, we are moving in right direction. signature.asc Description: Digital signature

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

On Sat, Jul 02, 2016 at 05:39:02PM +0800, Lijun Ou wrote: This v11 > 28 files changed, 10626 insertions(+), 1 deletion(-) First version > 27 files changed, 11670 insertions(+), 11 deletions(-) 1K LOC less, we are moving in right direction. signature.asc Description: Digital signature

Re: [PATCH v10 07/22] IB/hns: Add event queue support

On Wed, Jun 29, 2016 at 04:53:39PM +0800, oulijun wrote: > >> + > >> + for (i = 0; i < npages; ++i) > >> + if (eq->buf_list[i].buf) > > > > Is it possible situation to have eq->buf_list[i].buf == NULL at the > > middle of iteration? > > > We have analysized it according to your

Re: [PATCH v10 07/22] IB/hns: Add event queue support

On Wed, Jun 29, 2016 at 04:53:39PM +0800, oulijun wrote: > >> + > >> + for (i = 0; i < npages; ++i) > >> + if (eq->buf_list[i].buf) > > > > Is it possible situation to have eq->buf_list[i].buf == NULL at the > > middle of iteration? > > > We have analysized it according to your

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

On Tue, Jun 28, 2016 at 02:31:41PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/27 16:31, oulijun wrote: > >Hi, Leon > >在 2016/6/27 16:01, Leon Romanovsky 写道: > >>On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: > >>> > >>>O

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

On Tue, Jun 28, 2016 at 02:31:41PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/27 16:31, oulijun wrote: > >Hi, Leon > >在 2016/6/27 16:01, Leon Romanovsky 写道: > >>On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: > >>> > >>>O

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/24 22:59, Leon Romanovsky wrote: > >On Thu, Jun 16, 2016 at 10:35:12PM +0800, Lijun Ou wrote: > >>This patch mainly added reset flow of RoCE engine in RoCE > >>driver. It is necessar

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/24 22:59, Leon Romanovsky wrote: > >On Thu, Jun 16, 2016 at 10:35:12PM +0800, Lijun Ou wrote: > >>This patch mainly added reset flow of RoCE engine in RoCE > >>driver. It is necessar

<    8   9   10   11   12   13   14   15   16   >