On Tue, Apr 9, 2024 at 8:36 PM Luca Weiss wrote:
> Allow specifying a GPIO hog, as already used on
> qcom-msm8974-lge-nexus5-hammerhead.dts.
>
> Signed-off-by: Luca Weiss
This patch applied to the pinctrl tree!
Yours,
Linus Walleij
needed. For the others more work needs to be done but this will be
> performed incrementally along with API changes/improvements. All these
> changes here are simple search/replace results.
>
> Signed-off-by: Wolfram Sang
Acked-by: Linus Walleij
Yours,
Linus Walleij
; Signed-off-by: Yan Zhao
My bug, obviously. :(
Reviewed-by: Linus Walleij
I thought this was already applied with the other fixes, but maybe it
was missed?
Yours,
Linus Walleij
eneric/page.h is not touched in this patch as
> it's referenced by page_to_virt() in that header while the whole header is
> going to be removed as a whole due to no one including it.
>
> Link:https://lore.kernel.org/all/20240131055159.2506-1-yan.y.z...@intel.com
> [1]
> Cc: Linus Wall
most conditions, especially when there's an offset in
> __va.
Ooops that's right, I wonder why I got it wrong.
Arithmetic made it not regress :/
Thank you so much for fixing this Yan!
Reviewed-by: Linus Walleij
Arnd: I think you can take most of them through the arch tree.
Yours,
Linus Walleij
On Wed, Jan 10, 2024 at 8:04 PM Duje Mihanović wrote:
> Add the "marvell,pxa1908-padconf" compatible to allow migrating to a
> separate pinctrl driver later.
>
> Signed-off-by: Duje Mihanović
Acked-by: Linus Walleij
I guess you will merge all of this through the S
On Wed, Jan 10, 2024 at 8:04 PM Duje Mihanović wrote:
> Add the "marvell,pxa1908-padconf" compatible to allow migrating to a
> separate pinctrl driver later.
>
> Reviewed-by: Rob Herring
> Signed-off-by: Duje Mihanović
Acked-by: Linus Walleij
Yours,
Linus Walleij
On Tue, Sep 19, 2023 at 2:46 PM Luca Weiss wrote:
> Allow the gpio-reserved-ranges property on SC7280 TLMM.
>
> Acked-by: Linus Walleij
> Acked-by: Krzysztof Kozlowski
> Signed-off-by: Luca Weiss
This patch 5/7 applied to the pinctrl tree!
Yours,
Linus Walleij
On Sat, Sep 23, 2023 at 3:14 PM Matti Lehtimäki
wrote:
> Add pin <-> wakeirq mappings to allow for waking up the AP from sleep
> through MPM-connected pins.
>
> Signed-off-by: Matti Lehtimäki
Both v2 patches applied!
Yours,
Linus Walleij
On Fri, Sep 22, 2023 at 6:56 PM Luca Weiss wrote:
> Add the I2C bus and UART interface found on the MSM8226. For the I2C bus
> we also first need to add the pinctrl function in the driver.
>
> Signed-off-by: Luca Weiss
v2 looks fine and ACKs in place, so patches applied!
Yours,
Linus Walleij
So in this case, since it is an I2C device, we are probably
fine without grabbing a reference.
But this is not a general rule for any (non-slow) bus, so
the idiomatic pattern to follow is better like this.
Yours,
Linus Walleij
se controlled environment
chambers for this. But I hope there is a better way.
Yours,
Linus Walleij
On Sat, Apr 10, 2021 at 10:45 PM Ezequiel Garcia wrote:
> Add RK3568/RK3566 SoC support to pinctrl.
>
> Signed-off-by: Ezequiel Garcia
Patch applied.
Yours,
Linus Walleij
ernel/git/linusw/linux-pinctrl.git/log/?h=devel
... or you can wait until kernel v5.13-rc1 is out and then we can merge
it, but it might even require rebasing after that.
Yours,
Linus Walleij
ockchip,gpio-bank.yaml.
>
> Signed-off-by: Johan Jonker
> ---
> Changed V2:
> changed example gpio nodename
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
ecursive dependency error.
>
> Signed-off-by: Julian Braha
Patch applied.
Yours,
Linus Walleij
pm_runtime_force_resume)
Now you have ordinary sleep PM for free. It will just
force the same suspend/resume callbacks and they are
guaranteed to be race free.
This doesn't work for everyone but surprisingly often this is
what you want.
Yours,
Linus Walleij
nd() will disable them, i.e.
handover to runtime PM with the device in resumed state.
I hope this is answering the question, not sure.
Yours,
Linus Walleij
ll also
> work for cases where pins have multiple configurations.
>
> Fixes: 440b144978ba ("pinctrl: at91-pio4: add support for slew-rate")
> Signed-off-by: Tudor Ambarus
Patch applied!
Yours,
Linus Walleij
ozlowski
(...)
> Please apply it directly, I don't have any patches for Samsung pinctrl
> in my tree.
OK! Patch applied!
Yours,
Linus Walleij
e if DMA_CMA is not available/functioning, for example, if no CMA
> area for DMA_CMA use has been setup via "cma=X". In the worst case, the
> driver cannot do it's job properly in some configurations.
Looks good to me. At least a lot better than what we have.
Reviewed-by:
the information in plaintext for now.
>
> Signed-off-by: Sebastian Reichel
Thanks for doing this Sebastian:
Reviewed-by: Linus Walleij
Long term I want to get rid of the "charging algorithm" device node,
as can be easily seen that is not a real hardware device but just
some mockery to get
ork on this series Hector, thanks for working so hard on this!
Yours,
Linus Walleij
Documentation/devicetree/bindings/iio/st,st-sensors.yaml
are slightly incorrect. Several sensors have more than 1 IRQ.
I was working on a refined version of the bindings but got
sidetracked.
https://lore.kernel.org/linux-iio/20210104093343.2134410-1-linus.wall...@linaro.org/
I'll try to get to it.
Yours,
Linus Walleij
On Thu, Apr 8, 2021 at 7:25 PM Guru Das Srinagesh wrote:
> Add support for the 2 GPIOs present on Qualcomm Technologies, Inc.
> PM8008.
>
> Acked-by: Bjorn Andersson
> Signed-off-by: Guru Das Srinagesh
Patches applied.
Yours,
Linus Walleij
actually using DMA_CMA. I suspect small allocations
will be contiguous and big allocations will start to fragment?
but it's just my guess. I guess "really need it"?
Yours,
Linus Walleij
On Tue, Mar 30, 2021 at 10:39 AM angkery wrote:
> From: Junlin Yang
>
> when devm_kcalloc fails, use -ENOMEM instead of -EINVAL,
> and consistent with other devm_kcalloc return values.
>
> Signed-off-by: Junlin Yang
Patch applied.
Yours,
Linus Walleij
is one IRQ line per GPIO
line, the hierarchical support should be used as outlined. GPIO_REGMAP
should be mostly (famous last words) orthogonal.
Yours,
Linus Walleij
c gpio bindings
> to YAML
Please collect the ACKs and rebase like Björn says, sort stuff alphabetically
and resend so I can try to apply it! The YAML conversion may need a nod from
the DT people as well.
Yours,
Linus Walleij
On Mon, Mar 22, 2021 at 11:43 AM Jianqun Xu wrote:
> Separate gpio driver from pinctrl driver.
I tried to apply this too, but it fails, can you rebase on the pinctrl "devel"
branch (I suppose the RK3568 driver got in the way).
Yours,
Linus Walleij
problem with your driver.
"my" drivers:
drivers/gpu/drm/mcde/Kconfig
drivers/gpu/drm/pl111/Kconfig
drivers/gpu/drm/tve200/Kconfig
certainly needs this as well, and pretty much anything that is
selecting DRM_KMS_CMA_HELPER or
DRM_GEM_CMA_HELPER "wants" DMA_CMA.
Yours,
Linus Walleij
; >
> > > Signed-off-by: Julian Braha
> >
> > Does it work to just:
> >
> > select GPIOLIB
> >
> > instead?
> >
> > The driver needs the library so...
> >
> > Yours,
> > Linus Walleij
> >
>
> Hi Linus,
>
> Looks
On Tue, Apr 6, 2021 at 3:49 AM Ran Wang wrote:
> Could this version be accepted, or any comment/suggestion?
Andy says yes, then it is a yes :)
FWIW
Acked-by: Linus Walleij
Yours,
Linus Walleij
.
>
> Fixes: 5513b411ea5b ("Documentation: rename pinctl to pin-control")
> Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Linus Walleij
I assume you will apply this Mauro?
Yours,
Linus Walleij
21
#else
(...)
This seems to correspond to your device tree so OK...
But it's annoying that we can't communicate with it.
This is usually because some other device is
"shading" the GPIO lines, i.e. hiding it.
drivers/net/sl_switch.c is not used on your platform (Vitesse switch)
and is a leftover from the Storlink reference design.
> > > BUT neither ethernet nor USB works.
> >
> > For USB try this patch:
> > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git/commit/?h=gemini-usb=cbaf6cdf770b90de5f10bfa5112c679f1dffe948
> >
>
> One of the USB port is now working.
Hey nice! :D
The USB patch is not very widely tested, so it may need some shaping
up.
> Note that I have also started to work on the gemini crypto driver.
I saw some nice debug prints! :D
I always wanted to get that to work, nice that you're working on
it!
Yours,
Linus Walleij
t;
> Signed-off-by: Dinghao Liu
Looks correct, this semantic ordering always confuse me
a bit:
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
is pretty important,
if you have vendor source code, please share so I can check how
they set it up.
> BUT neither ethernet nor USB works.
For USB try this patch:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git/commit/?h=gemini-usb=cbaf6cdf770b90de5f10bfa5112c679f1dffe948
Pls report progress! I hope we can mainline this device.
Yours,
Linus Walleij
im and gpio-aggregator
so why not.
I would create a Kconfig menu with "GPIO hardware hacking tools".
But Bartosz would need to agree on that idea.
> +config GPIO_LOGIC_ANALYZER
> + tristate "Simple GPIO logic analyzer"
> + depends on GPIOLIB || COMPILE_TEST
> + help
depends on EXPERT
I would say. Definitely not something for the average user.
Yours,
Linus Walleij
pinctrl: add a pincontrol driver for BCM6362")
> Signed-off-by: Álvaro Fernández Rojas
Patch applied! Thanks!
Yours,
Linus Walleij
Hi Linus,
here are some overly ripe fixes for the v5.12 kernel. I should
have sent earlier but had my head stuck in GDB.
All are driver fixes. Details in the signed tag.
Please pull it in!
Yours,
Linus Walleij
The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15
On Sun, Mar 28, 2021 at 7:18 PM Lars Povlsen wrote:
> Linus Walleij writes:
>
> > On Tue, Mar 23, 2021 at 2:10 PM Arnd Bergmann wrote:
> >
> >> From: Arnd Bergmann
> >>
> >> Building with 'make W=1' shows an array overflow:
> >>
>
t didn't see it. Good that we have so many layers.
I bet Álvaro will have a patch to fix it in no time.
Yours,
Linus Walleij
rite.
Yours,
Linus Walleij
On Mon, Mar 29, 2021 at 4:00 AM Brad Larson wrote:
> New drivers should include instead
> of legacy .
>
> Signed-off-by: Brad Larson
Fold into patch 1 as indicated by Greg.
Yours,
Linus Walleij
usw/linux-pinctrl.git/log/?h=ib-bcm63xx
If we get problems between GPIO and pin control you can
pull this in, but let's hope not!
Yours,
Linus Walleij
vel" branch so the build servers can churn at it! Later
today I will integrate it into linux-next.
Any remaining issues can certainly be fixed in-tree.
Thanks for your perseverance in cleaning up these SoCs!!
Now, what about a patch set for the IRQ support? :)
Yours,
Linus Walleij
nice.
Have you made any attempts to cooperate with anyone else in the
world on this, or is this Intel's personal playground?
Yours,
Linus Walleij
Cc: Bartosz Golaszewski
> Cc: Linus Walleij
> Cc: linux-g...@vger.kernel.org
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
o22",
>^
> Add the missing comma that must have accidentally been removed.
>
> Fixes: ac43c44a7a37 ("pinctrl: qcom: Add SDX55 pincontrol driver")
> Signed-off-by: Arnd Bergmann
Patch applied.
Yours,
Linus Walleij
inux.git/commit/?id=679db70801da9fda91d26caf13bf5b5ccc74e8e8
So it seems the most vulnerable spot was already
fixed by you, thanks! But I bet there are some more
spots.
Yours,
Linus Walleij
v3:
> - No changes
This looks OK to me:
Acked-by: Linus Walleij
It could potentially (like the other Rohm GPIO MFD PMIC drivers)
make some use of the gpio regmap library, but we have some
pending changes for that so look into it after the next merge
window.
I.e. for your TODO: look a
xes: be2dc859abd4 ("pinctrl: pinctrl-microchip-sgpio: Add irq support (for
> sparx5)")
> Signed-off-by: Arnd Bergmann
Patch applied.
Yours,
Linus Walleij
elay the new testing driver anymore so I intend to
> apply the entire series and take it upstream through the GPIO tree by
> the end of this week.
I say go ahead.
Acked-by: Linus Walleij
Yours,
Linus Walleij
On Tue, Mar 23, 2021 at 3:56 PM Bryan Brattlof wrote:
> Signed-off-by: Bryan Brattlof
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
On Tue, Mar 23, 2021 at 2:37 AM Wan Jiabing wrote:
> linux/io.h has been included at line 6, so remove the
> duplicate include at line 18.
>
> Signed-off-by: Wan Jiabing
Patch applied!
Yours,
Linus Walleij
s: e20849a8c883 ("usb: gadget: pch_udc: Convert to use GPIO descriptors")
> Signed-off-by: Andy Shevchenko
Ooops sorry.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
(different base
> types)
> .../pch_udc.c:1813:27:expected unsigned int [usertype] dataptr
> .../pch_udc.c:1813:27:got restricted __le32 [usertype]
>
> Fixes: f646cf94520e ("USB device driver of Topcliff PCH")
> Signed-off-by: Andy Shevchenko
Nice fix! Also easie
ot;)
> Signed-off-by: Geert Uytterhoeven
Patch applied.
I saw this was causing issues on S390.
Yours,
Linus Walleij
On Sun, Mar 21, 2021 at 4:32 AM Zhiyong Tao wrote:
> When multiple threads operate on the same register resource
> which include multiple pin, It will make the register resource
> wrong to control. So we add lock to avoid the case.
>
> Signed-off-by: Zhiyong Tao
Patch applied
n just grep for PROPERTY_ENTRY and you find some
examples of how we use it.
Yours,
Linus Walleij
+enum: [0, 1]
As concluded from driver review, replace this with
power-source which is already defined in
Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
Yours,
Linus Walleij
o comment.
> >
> > Linus?
While it is fine to add custom pin config options to pin controllers
for hopelessly idiomatic stuff, this does look like it should be
using PIN_CONFIG_POWER_SOURCE with the voltage rail
as parameter, see
include/linux/pinctrl/pinconf-generic.h
If you're not using that then tell us why.
Yours,
Linus Walleij
> Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
> Signed-off-by: Andy Shevchenko
Excellent solution!
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
; SCI events. Therefore, we need to hook from the driver into GPE handler of
> the ACPI subsystem in order to catch and report GPIO-related events.
>
> Validated on the Inlel Minnowboard (v1) platform.
>
> Signed-off-by: Andy Shevchenko
Looks good to me:
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
handle_bad_irq;
I always add a local variable like:
struct gpio_irq_chip *girq;
And assign with the arrow, so as to make it easier to read:
girq->parent_handler = NULL
etc.
+/- the above:
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
se.
This v4 patch set applied!
Yours,
Linus Walleij
On Tue, Mar 23, 2021 at 11:19 PM Randy Dunlap wrote:
> Fix a few typos and some punctuation.
> Also, change CONFIG_OF to CONFIG_OF_GPIO in one comment.
>
> Signed-off-by: Randy Dunlap
> Cc: Linus Walleij
> Cc: Bartosz Golaszewski
> Cc: linux-g...@vger.kernel.org
Revie
~~
> > >
> > > Cc: Russell King
> > > Cc: Nicolas Ferre
> > > Cc: Alexandre Belloni
> > > Cc: Ludovic Desroches
> > > Signed-off-by: Lee Jones
> >
> > I'm pretty sure you had my ack on v3 ;)
> >
> > Acked-by: Alexandre Belloni
> >
> > or again, alternatively, I can apply it with Linus' ack
>
> That would be my preference, thanks.
Acked-by: Linus Walleij
Yours,
Linus Walleij
e I will
just defer to after v5.13-rc1.
Yours,
Linus Walleij
be generic enough that a certain
hardware timestamp can be selected sooner or later.
But let's not overcomplicate things for now.
Yours,
Linus Walleij
& HAS_DMA
>>Selected by
>>- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
>>- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC &&
>> SND_ATMEL_SOC && ATMEL_SSC
>
> This one though is interesting.
This looks like nothing to me :/
As confused as ever about Kconfig.
Yours,
Linus Walleij
and he may want to take a look).
Yours,
Linus Walleij
: Len Brown
L: linux-a...@vger.kernel.org
Yours,
Linus Walleij
On Wed, Mar 10, 2021 at 5:43 AM Jian Cai wrote:
> On Sat, Mar 6, 2021 at 4:25 AM Linus Walleij wrote:
> > On Fri, Mar 5, 2021 at 12:23 AM Jian Cai wrote:
> > > On Wed, Mar 3, 2021 at 7:04 AM Linus Walleij
> > > wrote:
> > > I think gcc also has thes
On Mon, Mar 22, 2021 at 9:50 AM Alexander Sverdlin
wrote:
> On 20/03/2021 12:10, Linus Walleij wrote:
> >>> I'm wondering if the GPIO library support for IRQ hierarchy is what
> >>> you are looking for.
> > It is indeed what should be used.
>
> and what
rnel without U8500 support.
>
> Also, merely enabling CONFIG_COMPILE_TEST should not enable additional
> code, and thus should not enable this driver by default.
>
> Signed-off-by: Geert Uytterhoeven
Very nice. Good catch!
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
want to use this timestamp for
IIO devices? If it is just GPIOs and IRQs today, it will be
gyroscopes and accelerometers tomorrow, am I right?
Yours,
Linus Walleij
st effort and involves a bit of guesswork
and group effort and you are part of the group effort
now :)
Yours,
Linus Walleij
ssion
> from 2017, where
> Linus Walleij suggested to use it. Well, the initial patch was just 11-liner
> and PL061 is
> rather counterexample and doesn't fit well into the existing hierarchical
> infrastructure.
>
> >> Link:
> >> https://lore.kernel.org/linux
its can
be fixed in-tree.
Yours,
Linus Walleij
ds have multiple SIM slots that can be switched
> via some gpio pin.
>
> Not sure whether traditional pinmux would be a good match for that.
What is wrong with the subsystem
drivers/mux?
It's exactly for this usecase I think. Peter Rosin already wrote
a GPIO-controlled mux driver too.
Yours,
Linus Walleij
; Signed-off-by: Lina Iyer
> Signed-off-by: Bjorn Andersson
This patch 1/2 applied to the pin control tree.
Please take the DTS patch into the qcom SoC tree!
Yours,
Linus Walleij
n also be bolted
with a front-end pin controller (facing the pins) with
several GPIO+interrupt controller back-ends.
Then it gets the structure in this patch,
subnodes for each GPIO controller.
Our current bindings have all three examples
and it simply reflects the different ways HW
engineers have chosen to integrate their stuff.
Yours,
Linus Walleij
ialize ret to 0 to avoid uninitialized ret value in first
> loop or reusing ret value from first loop in second.
>
> Addresses-Coverity: ("Uninitialized variables")
> Signed-off-by: Michal Simek
> CC: Colin Ian King
> CC: Dan Carpenter
Patch applied!
Yours,
Linus Walleij
ted-by: TOTE Robot
> Signed-off-by: Jia-Ju Bai
Patch applied!
Yours,
Linus Walleij
e IMR registers may not match the reversed order in the other
> registers (DCBA, and BA-DC or DC-BA).
>
> Signed-off-by: Sander Vanheule
Overall this is a beautiful driver and it makes use of all the generic
frameworks I can think of. I don't see any reason not to merge
it so:
Reviewed-by:
vided for cases where the
> actual port ordering is not known yet, and enabling the interrupt
> controller may result in uncaught interrupts.
>
> Signed-off-by: Sander Vanheule
These bindings look good to me.
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
who knows what secure world
imperialists are out there).
This leaves Linux in control of the eMMC RPMB under all
circumstances as far as I can see.
Yours,
Linus Walleij
s it is absolutely necessary
that the secure world and the Linux storage drivers cooperate
so the solution is to let Linux handle this arbitration.
Now the question for this patch set is: is TEE software the only
user we need to care about?
Yours,
Linus Walleij
Hi Hector,
thanks for the long and detailed answer! I learn new things
all the time. (Maybe one day I add something too, who knows.)
I hope I'm not taking too much of your time, we're having fun :)
On Thu, Mar 11, 2021 at 9:02 PM Hector Martin wrote:
> On 11/03/2021 23.06, Linus Walleij wr
On Fri, Mar 12, 2021 at 9:36 AM Linus Walleij wrote:
> - The power maintainer (Sebastian) provide an ACK
Ooops I noticed actuall Sebastian already gave an ACK for these
patches:
https://lore.kernel.org/linux-pm/20210128001700.pkuyfpq6uzcjb5ud@earth.universe/
Sorry for keeping bad tr
There is a slew of defines, structs and enums and even a
function call only relevant for the charging code that
still lives in . Push it down to the
"ab8500-bm.h" header in the power supply subsystem where
it is actually used.
Signed-off-by: Linus Walleij
---
drivers/power/supply/a
patches. No hurry.
Linus Walleij (4):
mfd/power: ab8500: Require device tree
mfd/power: ab8500: Push data to power supply code
mfd/power: ab8500: Push algorithm to power supply code
mfd/power: ab8500: Push data to power supply code
drivers/mfd/ab8500-core.c | 17
as platform data to the MFD cells and then picked back
into the same subsystem that defined it in the first
place. This kills off a layer of indirection.
Acked-for-MFD-by: Lee Jones
Signed-off-by: Linus Walleij
---
drivers/mfd/ab8500-core.c | 17 +
.../power/supply}/ab8500
code needing to pass
data from boardfiles, which we don't do anymore.
Signed-off-by: Linus Walleij
---
.../power/supply/ab8500-chargalg.h | 6 +++---
drivers/power/supply/ab8500_charger.c | 2 +-
drivers/power/supply/abx500_chargalg.c
The core AB8500 driver and the whole platform is completely
dependent on being probed from device tree so remove the
non-DT probe paths.
Signed-off-by: Linus Walleij
---
drivers/power/supply/Kconfig | 2 +-
drivers/power/supply/ab8500_btemp.c| 10 --
drivers/power/supply
this as well.
Yours,
Linus Walleij
on applied to drm-misc-next.
Yours,
Linus Walleij
On Thu, Mar 11, 2021 at 3:58 PM Rob Herring wrote:
> On Wed, Mar 10, 2021 at 6:09 PM Linus Walleij
> wrote:
> > On Wed, Mar 10, 2021 at 6:51 PM Rob Herring wrote:
> >
> > > > +static const struct of_device_id bcm63xx_gpio_of_match[] = {
> > > >
1 - 100 of 19993 matches
Mail list logo
