From: Long Li
The ring buffer code uses %= to calculate index. For x86/64, %= compiles to
div, more than 10 times slower than sub.
Replace div with sub for this data heavy code path.
Signed-off-by: Long Li
---
drivers/hv/ring_buffer.c | 9 ++---
1 file changed, 6 insertions(+), 3
From: Long Li
Hyper-v host guarantees that a hypercall will finish in reasonable time.
Retry infinitely on transient failures to avoid returning error to upper layer.
Signed-off-by: Long Li
---
drivers/hv/connection.c | 30 ++
1 file changed, 14 insertions(+), 16
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Wednesday, January 4, 2017 1:48 PM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; de...@linuxdriverproject.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PAT
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Wednesday, January 4, 2017 12:51 PM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; de...@linuxdriverproject.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] Retry infinitely f
From: Long Li
Hyper-v host guarantees that a hypercall will succeed. Retry infinitely to
avoid returning transient failures to upper layer.
Signed-off-by: Long Li
---
drivers/hv/connection.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/hv
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, December 5, 2016 8:53 AM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Bjorn Helgaas ;
> de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; linux-
&
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of Long Li
> Sent: Tuesday, November 8, 2016 8:57 AM
> To: Greg KH
> Cc: linux-...@vger.kernel.org; Haiyang Zhang ;
> linux-kernel@vger.kernel.org;
From: Long Li
hv_do_hypercall assumes that we pass a segment from a physically
continuous buffer. Buffer allocated on the stack may not work if
CONFIG_VMAP_STACK=y is set.
Change to use kmalloc to allocate this buffer.
The v2 patch adds locking to access the pre-allocated buffer.
Signed-off
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Monday, November 7, 2016 11:00 PM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Bjorn Helgaas ;
> de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; linux-
> p...@v
From: Long Li
hv_do_hypercall assumes that we pass a segment from a physically continuous
buffer. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is
set. Use kmalloc to allocate this buffer.
Signed-off-by: Long Li
Reported-by: Haiyang Zhang
---
drivers/pci/host/pci
From: Long Li
We need to pass a segment from a physically continuous buffer to
hv_do_hypercall. Buffer allocated on the stack may not work if
CONFIG_VMAP_STACK=y is set. Moving the params buffer from stack to buffer
returned by kmalloc.
Signed-off-by: Long Li
Reported-by: Haiyang Zhang
From: Long Li
hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device
from host (e.g. by disabling SRIOV on a device). In hv_pci_remove, the bus is
already removed before the call, so we don't need to rescan the bus in the
workqueue scheduled from hv_pci_devices_pr
From: Long Li
A PCI_EJECT message can arrive at the same time we are calling
pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS message
or in create_root_hv_pci_bus(), in this case we could potentailly modify the
bus from multiple places. Properly lock the bus access
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Thursday, September 29, 2016 2:22 AM
> To: KY Srinivasan ; Long Li
> Cc: Haiyang Zhang ;
> de...@linuxdriverproject.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] hv
> -Original Message-
> From: Bjorn Helgaas [mailto:helg...@kernel.org]
> Sent: Tuesday, September 27, 2016 12:30 PM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; Bjorn Helgaas ;
> de...@linuxdriverproject.org; linux-...@vger.kernel.org; linux-
> ker...@
From: Long Li
A PCI_EJECT message can arrive at the same time we are calling
pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS message
or in create_root_hv_pci_bus(), in this case we could potentailly modify the
bus from multiple places. Properly lock the bus access
From: Long Li
hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device
from host (e.g. by disabling SRIOV on a device). In hv_pci_remove, the bus is
already removed before the call, so we don't need to rescan the bus in the
workqueue scheduled from hv_pci_devices_pr
> -Original Message-
> From: Dexuan Cui
> Sent: Tuesday, September 13, 2016 10:45 PM
> To: Long Li ; KY Srinivasan ;
> Haiyang Zhang ; Bjorn Helgaas
>
> Cc: de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; linux-
> p...@vger.kernel.org
> Subject:
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of Long Li
> Sent: Tuesday, September 13, 2016 10:33 AM
> To: Dexuan Cui ; KY Srinivasan
> ; Haiyang Zhang ; Bjorn
> Helgaas
> Cc: de...@linuxdriverp
> -Original Message-
> From: Dexuan Cui
> Sent: Tuesday, September 13, 2016 2:51 AM
> To: Long Li ; KY Srinivasan ;
> Haiyang Zhang ; Bjorn Helgaas
>
> Cc: de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; linux-
> p...@vger.kernel.org
> Subject:
From: Long Li
The host keeps sending heartbeat packets independent of guest responding to
them. In some situations, there might be multiple heartbeat packets pending in
the ring buffer. Don't lose them, read them all.
Signed-off-by: Long Li
---
drivers/hv/hv_util.c | 10 +++---
1
From: Long Li
hv_pci_devices_present is called in hv_pci_remove when we remove a PCI device
from host (e.g. by disabling SRIOV on a device). In hv_pci_remove, the bus is
already removed before the call, so we don't need to rescan the bus in the
workqueue scheduled from hv_pci_devices_pr
From: Long Li
A PCI_EJECT message can arrive at the same time we are calling
pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS message,
in this case we could potentailly modify the bus from two places. Properly lock
the bus access.
Signed-off-by: Long Li
---
drivers
> -Original Message-
> From: Johannes Thumshirn [mailto:jthumsh...@suse.de]
> Sent: Wednesday, September 7, 2016 12:47 AM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; James E.J. Bottomley
> ; Martin K. Petersen
> ; de...@linuxdriverproject.org; linux
From: Long Li
When sense message is present on error, we should pass along to the upper layer
to decide how to deal with the error. This patch fixes connectivity issues with
Fiber Channel devices.
---
drivers/scsi/storvsc_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
From: Long Li
Properly set SRB flags when hosting device supports tagged queuing. This patch
improves the performance on Fiber Channel disks.
---
drivers/scsi/storvsc_drv.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
From: Long Li
We no long have the restriction of page size limit in the SG list. Remove it.
The driver can properly handle default block segment size.
---
drivers/scsi/storvsc_drv.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
From: Long Li
This patch set fixes connectivity issues and improves performance for Fiber
Channel disks.
Long Li (3):
Use tagged SRB requests if supported by the device
Properly handle SRB_ERROR when sense message is present
Use block layer default segment size
drivers/scsi
ay, June 6, 2016 8:42 PM
> To: Long Li
> Cc: Tom Yan ; James E.J. Bottomley
> ; Martin K. Petersen
> ; linux-s...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] sd: remove redundant check for
> BLK_DEF_MAX_SECTORS
>
> >>>>> "Lon
change it again. If
they want max_sectors to be set by sd, they can use BLOCK LIMITS VPD to tell it
to do so.
> -Original Message-
> From: Tom Yan [mailto:tom.t...@gmail.com]
> Sent: Saturday, June 4, 2016 1:41 AM
> To: Long Li
> Cc: James E.J. Bottomley ; Martin K. Pete
ing values on optional VPD page 0xb0 "Block
Limits".
Signed-off-by: Long Li
---
drivers/scsi/sd.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 60bff78..d8c4047 100644
--- a/drivers/scsi/sd.c
+++ b/driv
Hi Martin,
Yes I would like to test it. Please let me know when they get in there.
Thanks
Long
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Tuesday, May 31, 2016 7:44 PM
> To: Long Li
> Cc: Bart Van Assche ; James
> -Original Message-
> From: Bart Van Assche [mailto:bart.vanass...@sandisk.com]
> Sent: Thursday, May 26, 2016 7:19 PM
> To: Long Li ; James E.J. Bottomley
> ; Martin K. Petersen
>
> Cc: KY Srinivasan ; linux-s...@vger.kernel.org; linux-
> ker...@vger.kernel.o
The block sector size should be in unit of 512 bytes, not in bytes.
Signed-off-by: Long Li
---
drivers/scsi/sd.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 428c03e..4bce17e 100644
--- a/drivers/scsi/sd.c
+++ b/drivers
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Friday, December 4, 2015 1:53 AM
> To: Long Li
> Cc: KY Srinivasan ; Haiyang Zhang
> ; James E.J. Bottomley ;
> de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; linux-
&
Introduce a logging level for storvsc to log certain error/warning messages.
Those messages are helpful in some environments, e.g. Microsoft Azure, for
customer support and troubleshooting purposes.
Signed-off-by: Long Li
---
drivers/scsi/storvsc_drv.c | 34
Thanks Joe.
I'll send out another patch.
> -Original Message-
> From: Joe Perches [mailto:j...@perches.com]
> Sent: Thursday, December 3, 2015 6:28 PM
> To: Long Li ; KY Srinivasan ;
> Haiyang Zhang ; James E.J. Bottomley
>
> Cc: de...@linuxdriverproject.org;
Introduce a logging level for storvsc to log certain error/warning messages.
Those messages are helpful in some environments, e.g. Microsoft Azure, for
customer support and troubleshooting purposes.
Signed-off-by: Long Li
---
drivers/scsi/storvsc_drv.c | 30 +-
1
> -Original Message-
> From: KY Srinivasan
> Sent: Friday, July 03, 2015 11:35 AM
> To: Vitaly Kuznetsov; linux-s...@vger.kernel.org
> Cc: Long Li; Haiyang Zhang; James E.J. Bottomley;
> de...@linuxdriverproject.org;
> linux-kernel@vger.kernel.org
> Subject: R
;
> Allow WRITE_SAME for Windows10 and above hosts.
>
Reviewed-by: Long Li
> Tested-by: Alex Ng
> Signed-off-by: Keith Mange
> Signed-off-by: K. Y. Srinivasan
> ---
> drivers/scsi/storvsc_drv.c |6 +-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
>
;
> From: keith.ma...@microsoft.com
>
> Currently we are making decisions based on vmbus protocol versions that have
> been negotiated; use storage potocol versions instead.
>
Reviewed-by: Long Li
> Tested-by: Alex Ng
> Signed-off-by: Keith Mange
> Signed-off-by:
t.com
>
> Use a single value to track protocol versions to simplify comparisons and to
> be
> consistent with vmbus version tracking.
>
Reviewed-by: Long Li
> Tested-by: Alex Ng
> Signed-off-by: Keith Mange
> Signed-off-by: K. Y. Srinivasan
> ---
> drivers/scs
based on ranges.
>
> From: keith.ma...@microsoft.com
>
> Rather than look for sets of specific protocol versions, make decisions based
> on
> ranges. This will be safer and require fewer changes going forward as we add
> more storage protocol versions.
>
Reviewed-by: Long Li
h.ma...@microsoft.com
>
> Use storage protocol version instead of vmbus protocol version when
> determining storage capabilities.
>
Reviewed-by: Long Li
> Tested-by: Alex Ng
> Signed-off-by: Keith Mange
> Signed-off-by: K. Y. Srinivasan
> ---
> drivers/scsi/st
om: keith.ma...@microsoft.com
>
> Use correct defaults for values determined by protocol negotiation, instead of
> resetting them with every scsi controller.
>
Reviewed-by: Long Li
> Tested-by: Alex Ng
> Signed-off-by: Keith Mange
> Signed-off-by:
tion without properly freeing up the maapings we may
> have acquired. Fix the bug.
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> Cc:
> ---
> drivers/scsi/storvsc_drv.c | 15 ---
> 1 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git
terlists presented are not chained.
> Fix the code to not make this assumption.
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> ---
> drivers/scsi/storvsc_drv.c | 98 +--
> 1 files changed, 57 insertions(+), 41 deletions(-)
ut that WS2008R2 cannot correctly
> handle these new limits. Fix this bug by setting the limits based on the host.
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> ---
> drivers/scsi/storvsc_drv.c | 15 ---
> 1 files changed, 12 insertions(+), 3 deletion
e host when the host notifies that a scan is needed.
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> ---
> drivers/scsi/storvsc_drv.c | 19 +++
> 1 files changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/d
support on these hosts.
>
> Suggested by: James Bottomley
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> ---
> drivers/scsi/storvsc_drv.c | 13 +
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/storvsc
ay have been removed prior to discovering LUNs that may have
> been added.
>
> Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
> ---
> drivers/scsi/storvsc_drv.c | 26 ++
> 1 files changed, 26 insertions(+), 0 deletions(-)
>
> diff --gi
Thanks Martin for the explanation.
I'll send out another patch.
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Thursday, December 11, 2014 7:04 PM
> To: Long Li
> Cc: Martin K. Petersen; KY Srinivasan; Haiyang Zhang;
> j
> -Original Message-
> From: Sitsofe Wheeler [mailto:sits...@gmail.com]
> Sent: Wednesday, December 10, 2014 12:58 PM
> To: Long Li
> Cc: KY Srinivasan; Haiyang Zhang; jbottom...@parallels.com; linux-
> s...@vger.kernel.org; de...@linuxdriverproject.org; linux-
> k
> >>>>> "Long" == Long Li writes:
>
> Long> MSFT targets currently claim SPC-2 compliance while they implement
> Long> post SPC-2 features. With this patch we can correctly handle
> Long> WRITE_SAME_16 issues.
>
> Handle the issues or han
MSFT targets currently claim SPC-2 compliance while they implement post SPC-2
features. With this patch we can correctly handle WRITE_SAME_16 issues.
This patch fixes an issue where the flag is setup too late in drive
initialization process.
Reviewed-by: K. Y. Srinivasan
Signed-off-by: Long
When ring buffer returns an error indicating retry, storvsc may not return a
proper error code to SCSI when bounce buffer is not used. This has introduced
I/O freeze on RAID running atop storvsc devices. This patch fixes it by always
returning a proper error code.
Signed-off-by: Long Li
Sitsofe, can you try the patch attached to see if it helps with the problem?
Long
-Original Message-
From: linux-kernel-ow...@vger.kernel.org
[mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Peter Zijlstra
Sent: Monday, November 10, 2014 1:44 AM
To: Sitsofe Wheeler
Cc: KY Sriniv
c: KY Srinivasan; Haiyang Zhang; Long Li; net...@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: skbuff_fclone_cache poison overwritten
While using 3.18.0-rc3.x86_64-00116-g6ac94d3 on a Hyper-V 2012 R2 the poison in
skbuff_fclone_cache was overwritten:
[39099.484435] sd 7:0:0:0: [sdi] Attached
:36 AM
To: Long Li
Cc: David Miller; o...@aepfle.de; net...@vger.kernel.org; jasow...@redhat.com;
linux-kernel@vger.kernel.org; a...@canonical.com; de...@linuxdriverproject.org
Subject: Re: [PATCH net 1/1] hyperv: Fix a bug in netvsc_send()
On Fri, Oct 10, 2014 at 11:39:00PM +, Long Li wrote
14 at 09:11:29PM -0400, David Miller wrote:
> From: "K. Y. Srinivasan"
> Date: Sun, 5 Oct 2014 10:42:51 -0700
>
> > After the packet is successfully sent, we should not touch the
> > packet as it may have been freed. This patch is based on the work
> > done b
501 - 560 of 560 matches
Mail list logo
