Re: [PATCH] sched_clock: add data pointer argument to read callback

2015-10-09 Thread Måns Rullgård
nt. If I've missed something that makes this a stupid idea, please tell. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource

2015-10-09 Thread Måns Rullgård
Stephen Boyd <sb...@codeaurora.org> writes: > On 10/09, Rob Herring wrote: >> +Stephen who has worked on this code. >> >> On Fri, Oct 9, 2015 at 11:19 AM, Måns Rullgård <m...@mansr.com> wrote: >> > Måns Rullgård <m...@mansr.com> writes: >&

Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs

2015-10-09 Thread Måns Rullgård
Marc Gonzalez <marc_gonza...@sigmadesigns.com> writes: > Måns Rullgård wrote: > >> Marc Gonzalez wrote: >> >>> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator. >>> Use it for clocksource, sched_clock, and delay_timer. >> >&g

Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource

2015-10-09 Thread Måns Rullgård
Måns Rullgård <m...@mansr.com> writes: > Rob Herring <robherri...@gmail.com> writes: > >> On Wed, Oct 7, 2015 at 11:47 AM, Måns Rullgård <m...@mansr.com> wrote: >>> What would be a proper way to select a sched_clock source? I realise >>>

Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource

2015-10-09 Thread Måns Rullgård
Stephen Boyd <sb...@codeaurora.org> writes: > On 10/09, Rob Herring wrote: >> +Stephen who has worked on this code. >> >> On Fri, Oct 9, 2015 at 11:19 AM, Måns Rullgård <m...@mansr.com> wrote: >> > Måns Rullgård <m...@mansr.com> writes: >&

Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for Tango SoCs

2015-10-09 Thread Måns Rullgård
your name on a commit? The fact that you keep rewriting, poorly, code you know I've already made available suggests this might be the case. You even admit in private that you couldn't have done this without looking at my tango3 tree. Frankly, I find your behaviour shameful. -- Måns Rullgård m...@mansr

Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource

2015-10-08 Thread Måns Rullgård
Rob Herring writes: > On Wed, Oct 7, 2015 at 11:47 AM, Måns Rullgård wrote: >> Mark Rutland writes: >> >>> On Wed, Oct 07, 2015 at 04:37:13PM +0100, Mans Rullgard wrote: >>>> This adds a DT binding for a generic mmio clocksource as implemented >>>&

Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource

2015-10-08 Thread Måns Rullgård
. > power management? I expect that the kernel needs to leave the clock > enabled at all times for this to possibly work. The platform I'm dealing with has a 32-bit register counting cycles of the external clock input which never stops. It also has a few counters with a configurable clock sourc

Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource

2015-10-08 Thread Måns Rullgård
viour of this source w.r.t. > power management? I expect that the kernel needs to leave the clock > enabled at all times for this to possibly work. The platform I'm dealing with has a 32-bit register counting cycles of the external clock input which never stops. It also has a few counte

Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource

2015-10-08 Thread Måns Rullgård
Rob Herring <robherri...@gmail.com> writes: > On Wed, Oct 7, 2015 at 11:47 AM, Måns Rullgård <m...@mansr.com> wrote: >> Mark Rutland <mark.rutl...@arm.com> writes: >> >>> On Wed, Oct 07, 2015 at 04:37:13PM +0100, Mans Rullgard wrote: >>>>

Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource

2015-10-07 Thread Måns Rullgård
hed-clock: boolean, register clocksource as sched_clock > > Likewise, this property doesn't belong in the DT for the same reasons as > clocksource-rating. What would be a proper way to select a sched_clock source? I realise it's a Linux-specific thing and DT is supposed to be generic,

Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource

2015-10-07 Thread Måns Rullgård
ual hardware parameters? >> +- linux,sched-clock: boolean, register clocksource as sched_clock > > Likewise, this property doesn't belong in the DT for the same reasons as > clocksource-rating. What would be a proper way to select a sched_clock source? I realise it's a Linux-spec

Re: [PATCH] ARM: debug: add support for alternate 8250 register layout

2015-10-02 Thread Måns Rullgård
Sergei Shtylyov writes: > On 10/2/2015 5:26 PM, Måns Rullgård wrote: > >>>> Some SoCs have a UART with a non-standard register layout. This >>>> allows the debug console to work with these. >>> >>>> Signed-off-by: Mans Rullgard >>>&

Re: [PATCH] ARM: debug: add support for alternate 8250 register layout

2015-10-02 Thread Måns Rullgård
out" >> + depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250 >> + > >So Alchemy UART got reused on ARM? The UART is actually a Palmchip IP core used by several SoC companies. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line &

Re: [PATCH] ARM: debug: add support for alternate 8250 register layout

2015-10-02 Thread Måns Rullgård
re out who the vendor is. I've been informed it is provided by Palmchip. I'll make a new patch. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH] ARM: debug: add support for alternate 8250 register layout

2015-10-02 Thread Måns Rullgård
50_AU >> + bool "8250 UART has Alchemy register layout" >> + depends on DEBUG_LL_UART_8250 || DEBUG_UART_8250 >> + > >So Alchemy UART got reused on ARM? The UART is actually a Palmchip IP core used by several SoC companies. -- Måns Rullgård m..

Re: [PATCH] ARM: debug: add support for alternate 8250 register layout

2015-10-02 Thread Måns Rullgård
e UART, but I've > not managed to figure out who the vendor is. I've been informed it is provided by Palmchip. I'll make a new patch. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

Re: [PATCH] ARM: debug: add support for alternate 8250 register layout

2015-10-02 Thread Måns Rullgård
Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> writes: > On 10/2/2015 5:26 PM, Måns Rullgård wrote: > >>>> Some SoCs have a UART with a non-standard register layout. This >>>> allows the debug console to work with these. >>> >>>> Sign

Re: Trivial clocksource driver

2015-09-29 Thread Måns Rullgård
Mason writes: > Hello Mans, > > On 29/09/2015 22:18, Måns Rullgård wrote: > >> Mason writes: >> >>> On 29/09/2015 20:32, Thomas Gleixner wrote: >>> >>>> On Tue, 29 Sep 2015, Mason wrote: >>>> >>>>> I am trying to

Re: Trivial clocksource driver

2015-09-29 Thread Måns Rullgård
hich includes a proper subject line, changelog, plus >> the necessary Makefile and Kconfig modifications. > > OK, I'll send a formal patch tomorrow. > There are no Kconfig modifications, is that OK? Why don't you use my driver? It's even simpler, and it works just fine on the 87xx chip. h

Re: Trivial clocksource driver

2015-09-29 Thread Måns Rullgård
Mason <slash@free.fr> writes: > Hello Mans, > > On 29/09/2015 22:18, Måns Rullgård wrote: > >> Mason writes: >> >>> On 29/09/2015 20:32, Thomas Gleixner wrote: >>> >>>> On Tue, 29 Sep 2015, Mason wrote: >>&

Re: Trivial clocksource driver

2015-09-29 Thread Måns Rullgård
t fine on the 87xx chip. https://github.com/mansr/linux-tangox/blob/master/drivers/clocksource/clksrc-tangox.c -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] clk: check for invalid parent index of orphans in __clk_init()

2015-09-15 Thread Måns Rullgård
trcmp(clk->name, orphan->parent_names[i])) >> > __clk_reparent(orphan, clk); >> > continue; >> > } >> > >> >> This works for me and is less invasive than the original patch series. &g

Re: [PATCH] clk: check for invalid parent index of orphans in __clk_init()

2015-09-15 Thread Måns Rullgård
gt;num_parents && >> > + !strcmp(clk->name, orphan->parent_names[i])) >> > __clk_reparent(orphan, clk); >> > continue; >> > } >> > >>

Re: Hardware spec prevents optimal performance in device driver

2015-05-10 Thread Måns Rullgård
roach keeps the data flowing as fast as possible. With the hardware you describe, there is unfortunately a trade-off between throughput and CPU efficiency. You'll have to decide which is more important to you. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscri

Re: Hardware spec prevents optimal performance in device driver

2015-05-10 Thread Måns Rullgård
is more important to you. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: RGB LED control (was Re: "advanced" LED controllers)

2015-03-09 Thread Måns Rullgård
r those that don't, perhaps we handle the conversion between perceived and > pwm in the core, e.g. by adding a new flag to led_classdev.flags to indicate > the need for conversion? Some LED controllers do the right thing in hardware, so any adjustment done in the core needs to be option

Re: RGB LED control (was Re: advanced LED controllers)

2015-03-09 Thread Måns Rullgård
to indicate the need for conversion? Some LED controllers do the right thing in hardware, so any adjustment done in the core needs to be optional. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: clk mux get_parent return type

2015-02-15 Thread Måns Rullgård
as dropped or if it just > got forgotten about (I haven't found a V3 which should have addressed > fixing all the get_parent return values yet). The patch author is apparently no longer at TI (mail bounces). That might explain a thing or two. -- Måns Rullgård m...@mansr.com -- To unsub

Re: clk mux get_parent return type

2015-02-15 Thread Måns Rullgård
as dropped or if it just > got forgotten about (I haven't found a V3 which should have addressed > fixing all the get_parent return values yet). I ran into this error myself just now, and it's quite annoying. It would be great if it got fixed. -- Måns Rullgård m...@mansr.com -- To unsub

Re: clk mux get_parent return type

2015-02-15 Thread Måns Rullgård
forgotten about (I haven't found a V3 which should have addressed fixing all the get_parent return values yet). I ran into this error myself just now, and it's quite annoying. It would be great if it got fixed. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line

Re: clk mux get_parent return type

2015-02-15 Thread Måns Rullgård
forgotten about (I haven't found a V3 which should have addressed fixing all the get_parent return values yet). The patch author is apparently no longer at TI (mail bounces). That might explain a thing or two. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line

Re: [PATCH 5/5] MIPS: LLVMLinux: Silence unicode warnings when preprocessing assembly.

2015-02-05 Thread Måns Rullgård
o macro > arguments. And TBH I find banning any macro arguments starting with `u' > rather silly. Agreed. > I'm leaning towards considering having -Wunicode disabled for all > assembly sources, or maybe even for the whole Linux compilation, the > right solution. It's not like we h

Re: [PATCH 5/5] MIPS: LLVMLinux: Silence unicode warnings when preprocessing assembly.

2015-02-05 Thread Måns Rullgård
this. Personally, I doubt there's much cause for concern here. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] gpio: max732x: add set_multiple function

2015-01-30 Thread Måns Rullgård
he interrupt line connected, so I can't really help with that. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] video: fbdev: fix sys_copyarea

2015-01-30 Thread Måns Rullgård
Thanks, queued for 3.20. > > This makes me wonder, though, if the sys and cfb versions could be > somehow combined... I would have done it by #including a common template with different macro definitions for the memory access operations. -- Måns Rullgård m...@mansr.com -- To unsub

Re: [PATCH v2] video: fbdev: fix sys_copyarea

2015-01-30 Thread Måns Rullgård
it by #including a common template with different macro definitions for the memory access operations. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] gpio: max732x: add set_multiple function

2015-01-30 Thread Måns Rullgård
connected, so I can't really help with that. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE_TABLE()

2015-01-29 Thread Måns Rullgård
multiple identical definitions even though the C spec does not. Obviously all but one should go away. No need to mention llvm, IMO. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE_TABLE()

2015-01-29 Thread Måns Rullgård
but one should go away. No need to mention llvm, IMO. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH] Mark inline functions as __maybe_unused

2015-01-28 Thread Måns Rullgård
taken to warning about unused inline functions, that's a regression that needs to be addressed in clang, not the kernel. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH] Mark inline functions as __maybe_unused

2015-01-28 Thread Måns Rullgård
. If clang has taken to warning about unused inline functions, that's a regression that needs to be addressed in clang, not the kernel. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] video: fbdev: fix sys_copyarea

2015-01-21 Thread Måns Rullgård
uffer: fix cfb_copyarea") > - 5b789da8 ("framebuffer: fix screen corruption when copying") > > This patch incorporates the fixes into sys_copyarea() as well. Scratch that, this patch is broken. Correct patch coming soon. -- Måns Rullgård m...@mansr.com -- To unsubscribe f

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Måns Rullgård
e); >>> >>> Which can be written now as: >>> pr_info("Frobbing node %pO\n", node); >> >> Still disliking use of %p0. >> > > Choices are limited. And it’s pO not p0. O as in OF. Makes sense. -- Måns Rullgård m...@mansr.

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-21 Thread Måns Rullgård
disliking use of %p0. Choices are limited. And it’s pO not p0. O as in OF. Makes sense. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] video: fbdev: fix sys_copyarea

2015-01-21 Thread Måns Rullgård
cfb_copyarea) - 5b789da8 (framebuffer: fix screen corruption when copying) This patch incorporates the fixes into sys_copyarea() as well. Scratch that, this patch is broken. Correct patch coming soon. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Måns Rullgård
me' is usually > not what you want to print to identify the node in question. ‘name’ is > usually not unique. Name and address without the full path is usually a good compromise between uniqueness (it is usually unique for memory-mapped things) and verbosity. -- Måns Rullgård m...@mansr.c

Re: [PATCH] of: Custom printk format specifier for device node

2015-01-20 Thread Måns Rullgård
unique for memory-mapped things) and verbosity. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Måns Rullgård
from bad to worse. Using filter functions > isn't that great in the first place. And using them to pass data from > the consumer to the DMA provider is just a horrible abuse of the API. It seems to me the only sane way to use the dmaengine API is in conjunction with DT. -- Måns Rullg

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Måns Rullgård
in the first place. And using them to pass data from the consumer to the DMA provider is just a horrible abuse of the API. It seems to me the only sane way to use the dmaengine API is in conjunction with DT. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe

Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips)

2014-12-19 Thread Måns Rullgård
Joe Perches writes: > On Fri, 2014-12-19 at 01:43 +0000, Måns Rullgård wrote: >> What exactly are you proposing to remove? > > Optionally compile out > kernel/printk/printk.c:early_printk() > even if CONFIG_EARLY_PRINTK is enabled. > >> I see no unused code rela

Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips)

2014-12-19 Thread Måns Rullgård
Joe Perches j...@perches.com writes: On Fri, 2014-12-19 at 01:43 +, Måns Rullgård wrote: What exactly are you proposing to remove? Optionally compile out kernel/printk/printk.c:early_printk() even if CONFIG_EARLY_PRINTK is enabled. I see no unused code related to early printk (in any

Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips)

2014-12-18 Thread Måns Rullgård
ve working functionality. > > Unused. What exactly are you proposing to remove? I see no unused code related to early printk (in any variant) under arch/mips. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips)

2014-12-18 Thread Måns Rullgård
. Is early_printk really used by these architectures? Should it be removed? Sure, if you have a good reason to remove working functionality. Unused. What exactly are you proposing to remove? I see no unused code related to early printk (in any variant) under arch/mips. -- Måns Rullgård m

Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips)

2014-12-17 Thread Måns Rullgård
rly in the boot sequence and has very few dependencies, which makes > it useful for board bringup. EARLY_PRINTK on MIPS is enabled just after prom_init(), well before OF_EARLYCON is usable. I'd prefer if it stayed that way. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: s

Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips)

2014-12-17 Thread Måns Rullgård
dependencies, which makes it useful for board bringup. EARLY_PRINTK on MIPS is enabled just after prom_init(), well before OF_EARLYCON is usable. I'd prefer if it stayed that way. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] Documentation: memory-barriers: Fix typo in the first example

2014-12-02 Thread Måns Rullgård
understand it. Not sure which is scarier. Those are probably the Evil Vendor Tree developers who apparently think "this is hard, best put volatile and barriers _everywhere_ and hope for the best." -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsub

Re: [PATCH] Documentation: memory-barriers: Fix typo in the first example

2014-12-02 Thread Måns Rullgård
apparently think this is hard, best put volatile and barriers _everywhere_ and hope for the best. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2] n_tty: Fix read_buf race condition, increment read_head after pushing data

2014-11-12 Thread Måns Rullgård
Christian Riesch writes: > On Tue, Nov 11, 2014 at 2:04 PM, Måns Rullgård wrote: >> Christian Riesch writes: > [...]>> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c >>> index 2e900a9..b09f326 100644 >>> --- a/drivers/tty/n_tty.c >>> +

Re: [PATCH v2] n_tty: Fix read_buf race condition, increment read_head after pushing data

2014-11-12 Thread Måns Rullgård
Christian Riesch christian.rie...@omicron.at writes: On Tue, Nov 11, 2014 at 2:04 PM, Måns Rullgård m...@mansr.com wrote: Christian Riesch christian.rie...@omicron.at writes: [...] diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c index 2e900a9..b09f326 100644 --- a/drivers/tty/n_tty.c

Re: [PATCH v2] n_tty: Fix read_buf race condition, increment read_head after pushing data

2014-11-11 Thread Måns Rullgård
ar c, struct n_tty_data *ldata) > { > - *read_buf_addr(ldata, ldata->read_head++) = c; > + *read_buf_addr(ldata, ldata->read_head) = c; > + /* increment read_head _after_ placing the character in the buffer */ > + ldata->read_head++; > } Is that

Re: [PATCH v2] n_tty: Fix read_buf race condition, increment read_head after pushing data

2014-11-11 Thread Måns Rullgård
(ldata, ldata-read_head) = c; + /* increment read_head _after_ placing the character in the buffer */ + ldata-read_head++; } Is that comment really necessary? -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-10 Thread Måns Rullgård
Christian Riesch writes: > On Thu, Nov 6, 2014 at 9:56 PM, Greg Kroah-Hartman > wrote: >> On Thu, Nov 06, 2014 at 08:49:01PM +, Måns Rullgård wrote: >>> Greg Kroah-Hartman writes: >>> >>> > On Thu, Nov 06, 2014 at 12:39:59PM +0100, Christian Riesc

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-10 Thread Måns Rullgård
Christian Riesch christian.rie...@omicron.at writes: On Thu, Nov 6, 2014 at 9:56 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Nov 06, 2014 at 08:49:01PM +, Måns Rullgård wrote: Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Thu, Nov 06, 2014 at 12:39:59PM

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Måns Rullgård
Greg Kroah-Hartman writes: > On Thu, Nov 06, 2014 at 10:12:54PM +0000, Måns Rullgård wrote: >> Greg Kroah-Hartman writes: >> >> > On Thu, Nov 06, 2014 at 09:38:59PM +, Måns Rullgård wrote: >> >> Greg Kroah-Hartman writes: >> >> >&g

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Måns Rullgård
Greg Kroah-Hartman writes: > On Thu, Nov 06, 2014 at 09:38:59PM +0000, Måns Rullgård wrote: >> Greg Kroah-Hartman writes: >> >> > On Thu, Nov 06, 2014 at 09:01:36PM +, Måns Rullgård wrote: >> >> Greg Kroah-Hartman writes: >> >> >&g

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Måns Rullgård
Greg Kroah-Hartman writes: > On Thu, Nov 06, 2014 at 09:01:36PM +0000, Måns Rullgård wrote: >> Greg Kroah-Hartman writes: >> >> > On Thu, Nov 06, 2014 at 08:49:01PM +, Måns Rullgård wrote: >> >> Greg Kroah-Hartman writes: >> >> >> &g

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Måns Rullgård
Greg Kroah-Hartman writes: > On Thu, Nov 06, 2014 at 08:49:01PM +0000, Måns Rullgård wrote: >> Greg Kroah-Hartman writes: >> >> > On Thu, Nov 06, 2014 at 12:39:59PM +0100, Christian Riesch wrote: >> >> The current implementation of put_tty_queue() causes a r

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Måns Rullgård
ere is a sequence point before a function call, after the arguments have been evaluated. Thus all side-effects, such as the post-increment, must be complete before the function is called, just like in the example. There is no "re-arranging" here. The code is simply wrong. -- Måns Rullgård m..

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Måns Rullgård
-increment, must be complete before the function is called, just like in the example. There is no re-arranging here. The code is simply wrong. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Måns Rullgård
Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Thu, Nov 06, 2014 at 08:49:01PM +, Måns Rullgård wrote: Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Thu, Nov 06, 2014 at 12:39:59PM +0100, Christian Riesch wrote: The current implementation of put_tty_queue() causes

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Måns Rullgård
Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Thu, Nov 06, 2014 at 09:01:36PM +, Måns Rullgård wrote: Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Thu, Nov 06, 2014 at 08:49:01PM +, Måns Rullgård wrote: Greg Kroah-Hartman gre...@linuxfoundation.org writes

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Måns Rullgård
Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Thu, Nov 06, 2014 at 09:38:59PM +, Måns Rullgård wrote: Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Thu, Nov 06, 2014 at 09:01:36PM +, Måns Rullgård wrote: Greg Kroah-Hartman gre...@linuxfoundation.org writes

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Måns Rullgård
Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Thu, Nov 06, 2014 at 10:12:54PM +, Måns Rullgård wrote: Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Thu, Nov 06, 2014 at 09:38:59PM +, Måns Rullgård wrote: Greg Kroah-Hartman gre...@linuxfoundation.org writes

Re: [PATCH v2 2/3] ARM: vfp: Fix VFPv3 hwcap detection on CPUID based cpus

2014-10-27 Thread Måns Rullgård
r lazy argument.) - It would be specific to Linux, so software can't rely on it anyway. (This is an even lazier argument.) -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH v2 2/3] ARM: vfp: Fix VFPv3 hwcap detection on CPUID based cpus

2014-10-27 Thread Måns Rullgård
argument.) - It would be specific to Linux, so software can't rely on it anyway. (This is an even lazier argument.) -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: OT: Open letter to the Linux World

2014-08-13 Thread Måns Rullgård
Martin Steigerwald writes: > Am Mittwoch, 13. August 2014, 10:27:56 schrieb Peter Zijlstra: >> On Tue, Aug 12, 2014 at 11:07:05PM +0100, Måns Rullgård wrote: >> > Steven Rostedt writes: >> > > Nice rant, I sympathize with you (just complaining about this

Re: OT: Open letter to the Linux World

2014-08-13 Thread Måns Rullgård
Peter Zijlstra writes: > On Wed, Aug 13, 2014 at 10:24:58AM +0100, Måns Rullgård wrote: >> Beware, even Gentoo will pull in systemd, if in a dormant state, unless >> you are very careful. > > Right so I've not tried yet (busy see), but I meant to remove all the > *Kit

Re: OT: Open letter to the Linux World

2014-08-13 Thread Måns Rullgård
Peter Zijlstra writes: > On Tue, Aug 12, 2014 at 11:07:05PM +0100, Måns Rullgård wrote: >> Steven Rostedt writes: >> >> > Nice rant, I sympathize with you (just complaining about this on G+). >> >> Made my day. >> >> > I'm just waiting f

Re: OT: Open letter to the Linux World

2014-08-13 Thread Måns Rullgård
Peter Zijlstra pet...@infradead.org writes: On Tue, Aug 12, 2014 at 11:07:05PM +0100, Måns Rullgård wrote: Steven Rostedt rost...@goodmis.org writes: Nice rant, I sympathize with you (just complaining about this on G+). Made my day. I'm just waiting for Linus to get pissed enough

Re: OT: Open letter to the Linux World

2014-08-13 Thread Måns Rullgård
Peter Zijlstra pet...@infradead.org writes: On Wed, Aug 13, 2014 at 10:24:58AM +0100, Måns Rullgård wrote: Beware, even Gentoo will pull in systemd, if in a dormant state, unless you are very careful. Right so I've not tried yet (busy see), but I meant to remove all the *Kit and other

Re: OT: Open letter to the Linux World

2014-08-13 Thread Måns Rullgård
Martin Steigerwald mar...@lichtvoll.de writes: Am Mittwoch, 13. August 2014, 10:27:56 schrieb Peter Zijlstra: On Tue, Aug 12, 2014 at 11:07:05PM +0100, Måns Rullgård wrote: Steven Rostedt rost...@goodmis.org writes: Nice rant, I sympathize with you (just complaining about this on G

Re: OT: Open letter to the Linux World

2014-08-12 Thread Måns Rullgård
t most of the heavy-weight kernel developers don't seem to care at all about what goes on in userspace. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: OT: Open letter to the Linux World

2014-08-12 Thread Måns Rullgård
of the heavy-weight kernel developers don't seem to care at all about what goes on in userspace. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 3.15 33/37] Fix gcc-4.9.0 miscompilation of load_balance() in scheduler

2014-08-06 Thread Måns Rullgård
g-code bug. Are there any that with reasonable confidence do not? -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3.15 33/37] Fix gcc-4.9.0 miscompilation of load_balance() in scheduler

2014-08-06 Thread Måns Rullgård
you guys can be so cavalier about a compiler bug that has already resulted in actual real problems. You bring up I have no problem with a -fno-var-tracking-assignments workaround for compilers that have the PR61801 wrong-code bug. Are there any that with reasonable confidence do not? -- Måns

Re: [PATCH 1/2] alpha: Remove "strange" OSF/1 fork semantics

2014-07-30 Thread Måns Rullgård
Richard Henderson writes: > On 07/30/2014 12:04 PM, Måns Rullgård wrote: >> Richard Henderson writes: >> >>> The assignment to regs->r20 kills the original tls_val input >>> to the clone syscall, which means that clone can no longer be >>> restart

Re: [PATCH 1/2] alpha: Remove "strange" OSF/1 fork semantics

2014-07-30 Thread Måns Rullgård
regs->r20 = 0; > stack = ((struct switch_stack *) regs) - 1; > *childstack = *stack; > childstack->r26 = (unsigned long) ret_from_fork; > -- > 1.9.3 > -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 1/2] alpha: Remove strange OSF/1 fork semantics

2014-07-30 Thread Måns Rullgård
; *childstack = *stack; childstack-r26 = (unsigned long) ret_from_fork; -- 1.9.3 -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/2] alpha: Remove strange OSF/1 fork semantics

2014-07-30 Thread Måns Rullgård
Richard Henderson r...@twiddle.net writes: On 07/30/2014 12:04 PM, Måns Rullgård wrote: Richard Henderson r...@twiddle.net writes: The assignment to regs-r20 kills the original tls_val input to the clone syscall, which means that clone can no longer be restarted with the original inputs

Re: of: Make OF_DYNAMIC user selectable

2014-07-27 Thread Måns Rullgård
one as well? You say that like user-selectable options are somehow evil. The kernel is not Gnome. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: of: Make OF_DYNAMIC user selectable

2014-07-27 Thread Måns Rullgård
this one as well? You say that like user-selectable options are somehow evil. The kernel is not Gnome. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Måns Rullgård
Nick Krause writes: > On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote: >> Nick Krause writes: >> >>> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: >>>> Steven Rostedt writes: >>>> >>>>> On Thu, 24 Jul 2014 10:

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Måns Rullgård
Nick Krause writes: > On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: >> Steven Rostedt writes: >> >>> On Thu, 24 Jul 2014 10:47:25 -0400 >>> Steven Rostedt wrote: >>> >>>> The three parameters are the number of elements, the size o

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Måns Rullgård
get the flags part correct. >> >> Now lets look at what you did. For the size you had: > > That should have read "For the count you had:" > > Oh well, you get my point anyway. I have some doubts about the last bit. -- Måns Rullgård m...@mansr.com -- To unsubs

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Måns Rullgård
did get the flags part correct. Now lets look at what you did. For the size you had: That should have read For the count you had: Oh well, you get my point anyway. I have some doubts about the last bit. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Måns Rullgård
Nick Krause xerofo...@gmail.com writes: On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård m...@mansr.com wrote: Steven Rostedt rost...@goodmis.org writes: On Thu, 24 Jul 2014 10:47:25 -0400 Steven Rostedt rost...@goodmis.org wrote: The three parameters are the number of elements, the size

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Måns Rullgård
Nick Krause xerofo...@gmail.com writes: On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård m...@mansr.com wrote: Nick Krause xerofo...@gmail.com writes: On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård m...@mansr.com wrote: Steven Rostedt rost...@goodmis.org writes: On Thu, 24 Jul 2014 10:47

Re: [PATCH 6/6] alpha: Join lines 90 and 91

2014-07-15 Thread Måns Rullgård
addr 0x%lx" " > [0x%lx:0x%lx]\n", > vaddr, kaddr, kstart, kend); > #endif If you're doing this, you should merge the strings too. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH 6/6] alpha: Join lines 90 and 91

2014-07-15 Thread Måns Rullgård
); #endif If you're doing this, you should merge the strings too. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

<    2   3   4   5   6   7   8   9   >