[Patch-V2 1/3] cxgb4: Add Chelsio LLD support Chelsio Crypto ULD

2016-07-18 Thread Yeshaswi M R Gowda
the crypto requests to the Chelsio's hardware and for receiving the responses from the hardware. This patch enables the services mentioned for the Chelsio's crypto driver. Signed-off-by: Yeshaswi M R Gowda --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 18 +- drivers/ne

[Patch-V2 2/3] chcr: Support for Chelsio's Crypto Hardware

2016-07-18 Thread Yeshaswi M R Gowda
m the userspace applications and/or from within the kernel space using the kernel's crypto API. The above mentioned crypto features have been tested using kernel's tests mentioned in testmgr.h. They also have been tested from user space using libkcapi and Openssl. Signed-off-by: Yeshaswi M R G

[Patch-V2 0/3] crypto/chcr: Add Chelsio Crypto Driver

2016-07-18 Thread Yeshaswi M R Gowda
ix in Kconfig. 7. If the request has the MAY_BACKLOG bit set and hardware queue is full the request is queued up else -EBUSY is returned to throttle the user. The queue when executed and processed returns -EINPROGRESS in completion. Yeshaswi M R Gowda (3): cxgb4: Add Chelsio LLD support Ch

[Patch-V2 3/3] crypto: Added Chelsio Menu to the Kconfig file

2016-07-18 Thread Yeshaswi M R Gowda
Adds the config entry for the Chelsio Crypto Driver, Makefile changes for the same. Signed-off-by: Yeshaswi M R Gowda --- drivers/crypto/Kconfig |2 ++ drivers/crypto/Makefile |1 + 2 files changed, 3 insertions(+) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index

[PATCH 2/3] chcr: Support for Chelsio's Crypto Hardware

2016-07-11 Thread Yeshaswi M R Gowda
m the userspace applications and/or from within the kernel space using the kernel's crypto API. The above mentioned crypto features have been tested using kernel's tests mentioned in testmgr.h. They also have been tested from user space using libkcapi and Openssl. Signed-off-by: Yeshaswi M R G

[PATCH 0/3] crypto/chcr: Add Chelsio Crypto Driver

2016-07-11 Thread Yeshaswi M R Gowda
config and drivers/crypto/Makefile to enable the Chelsio Crypto driver. We have included all the maintainers of respective drivers. Kindly review the changes and provide feedback on the same. Yeshaswi M R Gowda (3): cxgb4: Add Chelsio LLD support Chelsio Crypto ULD chcr: Support for Chelsio's

[PATCH 3/3] crypto: Added Chelsio Menu to the Kconfig file

2016-07-11 Thread Yeshaswi M R Gowda
Adds the config entry for the Chelsio Crypto Driver, Makefile changes for the same. Signed-off-by: Yeshaswi M R Gowda --- drivers/crypto/Kconfig |2 ++ drivers/crypto/Makefile |1 + 2 files changed, 3 insertions(+) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index

[PATCH 1/3] cxgb4: Add Chelsio LLD support Chelsio Crypto ULD

2016-07-11 Thread Yeshaswi M R Gowda
the crypto requests to the Chelsio's hardware and for receiving the responses from the hardware. This patch enables the services mentioned for the Chelsio's crypto driver. Signed-off-by: Yeshaswi M R Gowda --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 22 +- drivers/net/ethern

[no subject]

2016-06-30 Thread Brown, Jaime M
did you get my mail..?

Re: [regression] linux318, linux41 - kernel stack is corrupted

2016-04-22 Thread Sebastian M. Bobrecki
W dniu 22.04.2016 o 09:55, Greg Kroah-Hartman pisze: On Fri, Apr 22, 2016 at 09:47:04AM +0200, Sebastian M. Bobrecki wrote: Hi, I just hit the same with 4.1.22 on Gentoo. 4.1.21 are working fine. On 22.04.2016 at 08:46, Greg Kroah-Hartman wrote: ... You are going to have to be a bit more

Re: [regression] linux318, linux41 - kernel stack is corrupted

2016-04-22 Thread Sebastian M. Bobrecki
isect' to find the offending patch? Greg have you seen screenshots linked by Philip? -- Sebastian M. Bobrecki

For Your Consideration!

2016-04-11 Thread John M
Hello, I need you to assist me claim and invest the sum of $50 Million(Fifty Million US Dollars) in your Country.You will get 30% share out of the total fund for your assistance.More details when i hear back from you. Kind regards, John

[PATCH 1/5] drm: Add new DCS commands in the enum list

2016-03-28 Thread Deepak M
Adding new DCS commands which are specified in the DCS 1.3 spec related to CABC. v2: Sorted the Macro`s by value (Andrzej) Cc: Andrzej Hajda Cc: Thierry Reding Cc: David Airlie Cc: Ville Syrjälä Cc: Daniel Vetter Suggested-by: Jani Nikula Signed-off-by: Deepak M --- include/video

Re: userns, netns, and quick physical memory consumption by unprivileged user

2016-03-11 Thread Yuriy M. Kaminskiy
nged nothing with underlying problem). > > So, how about something like this: > > $ cat << EOF >> eatphysmem > #!/bin/bash -xe > fd=6 > d="`mktemp -d /tmp/eatmemX`" > cd "$d" > rule="iptables -A INPUT -m conntrack --ctstate EST

RE: [PATCH] qlogicpti: Return correct error code

2016-02-29 Thread Seymour, Shane M
Reviewed-by: Shane Seymour

RE: [PATCH] snic: correctly check for array overrun on overly long version number

2016-02-29 Thread Seymour, Shane M
Reviewed-by: Shane Seymour

[PATCH 0/2] staging: lustre: Correct two minor issues found by sparse

2016-02-28 Thread M. Vefa Bicakci
eturn variables") which points to the tip of the staging-next and staging-testing branches as of now. M. Vefa Bicakci (2): staging: lustre: Use const static file_operations struct staging: lustre: Use __user for a pointer to a user space address drivers/staging/lustre/lustre/libcf

[PATCH 2/2] staging: lustre: Use __user for a pointer to a user space address

2016-02-28 Thread M. Vefa Bicakci
third argument to a helper function (libcfs_ioctl_popdata) which also has a __user annotation for its corresponding argument. Signed-off-by: M. Vefa Bicakci --- drivers/staging/lustre/lustre/libcfs/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre

[PATCH 1/2] staging: lustre: Use const static file_operations struct

2016-02-28 Thread M. Vefa Bicakci
This commit corrects the following sparse warning regarding a file_operations structure being non-static and constifies the structure in question as well. warning: symbol 'lprocfs_stats_seq_fops' was not declared. Should it be static? Signed-off-by: M. Vefa Bicakci --- drive

RE: [PATCH] ipr: fix out-of-bounds null overwrite

2016-01-05 Thread Seymour, Shane M
> len = snprintf(fname, 99, "%s", buf); > - fname[len-1] = '\0'; Since it appears that's the only time len is actually used in that function can you please remove the variable len completely as part of the patch? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

RE: [PATCH 2/2] pci: Update VPD size with correct length

2015-12-17 Thread Seymour, Shane M
Tested with a HP AE311-60001 PCIe card. It used to repeat the same VPD every 4k for 32k now only the 154 bytes are returned and lspci - reports that the data up to and including the end and that the check sum is good: ... Capabilities: [74] Vital Product Data Product N

RE: [PATCH 1/2] pci: Update VPD definitions

2015-12-17 Thread Seymour, Shane M
> The 'end' tag is actually 0x0f, it's the representation as a > small resource data type tag that's 0x78 (ie shifted by 3). > This patch also adds helper functions to extract the resource > data type tags for both large and small resource data types. > > Cc: Alexander Duyck > Cc: Bjorn Helgaas >

RE: [PATCHv2] pci: Update VPD size with correct length

2015-12-16 Thread Seymour, Shane M
> The only 'error' cases I've encountered so far is a read of all zeroes (and a > halting the machine once you've read beyond a certain point) or a read of > 0xff throughout the entire area. So that approach would work for both of them. I should add that I'd tested the previous patch and this patc

RE: [PATCH v5 1/2] block: invalidate the page cache when issuing BLKZEROOUT.

2015-12-14 Thread Seymour, Shane M
Thank you for taking the issues I raised about converting unsigned to signed into account. Reviewed-by: Shane Seymour

RE: [PATCH v4] block: create ioctl to discard-or-zeroout a range of blocks

2015-11-16 Thread Seymour, Shane M
> v4: Check the start/len arguments for overflows prior to feeding the page > cache bogus numbers (that it'll ignore anyway). > Signed-off-by: Darrick J. Wong Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to m

RE: [PATCH] block: create ioctl to discard-or-zeroout a range of blocks

2015-11-12 Thread Seymour, Shane M
> I don't have a device large enough to test for signedness errors, since > passing > huge values for start and len never make it past the i_size_read check. If you have someone trying to bypass your sanity checks then if start=18446744073709551104 and len=1024 the result of adding them togethe

RE: [PATCH] block: create ioctl to discard-or-zeroout a range of blocks

2015-11-11 Thread Seymour, Shane M
> which would make the other checks I suggested to ensure that neither start > or end were more than (uint64_t)LLONG_MAX unnecessary. My apologies I was wrong about what I said above - after thinking about it for longer you still need to make sure that at least len is not greater than (uint64_t)

RE: [PATCH] block: create ioctl to discard-or-zeroout a range of blocks

2015-11-11 Thread Seymour, Shane M
> I don't have a device large enough to test for signedness errors, since > passing > huge values for start and len never make it past the i_size_read check. > However, I do see that I forgot to check the padding values, so I'll update > that. Then do you want to at least consider converting end

RE: [PATCH] block: create ioctl to discard-or-zeroout a range of blocks

2015-11-10 Thread Seymour, Shane M
A quick question about this part of the patch: > + uint64_t end = start + len - 1; > + if (end >= i_size_read(bdev->bd_inode)) return -EINVAL; > + /* Invalidate the page cache, including dirty pages */ > + mapping = bdev->bd_inode->i_mapping; > + truncate_ino

[PATCH] usb: dwc2: Fix NULL qh in dwc2_queue_transaction

2015-09-22 Thread Alexandru M Stan
When a usb device disconnects in a certain way, dwc2_queue_transaction still gets called after dwc2_hcd_cleanup_channels. dwc2_hcd_cleanup_channels does "channel->qh = NULL;" but dwc2_queue_transaction still wants to dereference qh. This adds a check for a null qh. Signed-off-by

[PATCH 0/1] usb: dwc2: Fix NULL qh in dwc2_queue_transaction

2015-09-22 Thread Alexandru M Stan
consistent with other checks in there). I also hope this opens up discussions on this issue. Alexandru M Stan (1): usb: dwc2: Fix NULL qh in dwc2_queue_transaction drivers/usb/dwc2/hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.6.0.rc0.131.gf624c3d -- To unsubscrib

Re: RT Scheduler - BUG_ON (idx >= MAX_RT_PRIO)

2015-09-07 Thread Sujit K M
cheduler (sched_rt.c) on 3.1.10 kernel. > [101640.492840] kernel BUG at kernel/sched_rt.c:1126! > > This turns out to be > 1126 BUG_ON(idx >= MAX_RT_PRIO); The reason for the stack trace is given below. http://www.spinics.net/lists/newbies/msg08889.html -- -- Sujit K M b

Re: RT Scheduler - BUG_ON (idx >= MAX_RT_PRIO)

2015-09-07 Thread Sujit K M
On Mon, Sep 7, 2015 at 12:28 PM, Chinmay V S wrote: > Thanks for your quick response Mike. > >> Try without the proprietary modules. You may also want to audit futex >> fixes if you can't use a maintained stable tree. 3.2 has a bunch that >> 3.1 does not. > > I see that futex.c has 17 patches in

[PATCH v2 1/2] ARM: dts: rockchip: pull up cts lines on rk3288

2015-09-02 Thread Alexandru M Stan
this patch merely restores them. This is similar to what we're already doing with the RX pin, so it should be safe. At worst it might be a slightly higher power usage (through ~50 kohms) when the cts is low. Suggested-by: Neil Hendin Signed-off-by: Alexandru M Stan --- Changes in v2: None

[PATCH v2 2/2] ARM: dts: rockchip: Remove specific cts pullup from veyron

2015-09-02 Thread Alexandru M Stan
With the previous patch ("rk3288: pull up cts lines") this is redundant, I sent that patch for the same reason this existed here, so the lines don't wiggle randomly when disconnected. Signed-off-by: Alexandru M Stan --- Changes in v2: - Restrict changes only to cts pin, leave

[PATCH v2 0/2] ARM: dts: rockchip: pull up cts lines

2015-09-02 Thread Alexandru M Stan
- CC people with the firefly board - New patch removing redundant pullup code from veyron - cover letter Alexandru M Stan (2): ARM: dts: rockchip: pull up cts lines on rk3288 ARM: dts: rockchip: Remove specific cts pullup from veyron arch/arm/boot/dts/rk3288-veyron.dtsi | 12 arch

[PATCH] ARM: dts: rk3288: pull up cts lines

2015-09-02 Thread Alexandru M Stan
this patch merely restores them. Suggested-by: Neil Hendin Signed-off-by: Alexandru M Stan --- arch/arm/boot/dts/rk3288.dtsi | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 906e938..a059367

NVRAM autoload for BRCM 43340 chipset

2015-08-09 Thread Marcin M.
I reported the bug as here: https://bugzilla.kernel.org/show_bug.cgi?id=102531 I thought - maybe I could help fixing this, this doesn't seem as difficult as writing a driver from scratch. Anyway, I'm completely new to this stuff - could you aid me where I should start looking? The firmware is all

Re: [PATCH RT 0/7] Linux 3.18.18-rt16-rc1

2015-08-07 Thread Wolfgang M. Reimer
Hi all, only after additionally installing my "3.18.17-rt14 locktorture: Do NOT include rwlock.h" patch I could build the kernel with CONFIG_PREEMPT_RT_FULL=y. So far kernel 3.18.18-rt16-rc1 runs fine on my lenovo notebook as well as on a server with (an already 5 year old) ASUS Z8NA-D6(C) mother

[PATCH] Staging: rtl8188eu/core: fixed code indentation warning as reported by checkpatch.pl

2015-08-03 Thread Bareja, Mayank (M.)
from: Mayank Bareja fixed code indentation warning as detected with checkpatch.pl. Replaced spaces with tabs. Signed-off-by: Mayank Bareja --- drivers/staging/rtl8188eu/core/rtw_debug.c|4 +-- drivers/staging/rtl8188eu/core/rtw_efuse.c|2 +- drivers/staging/rtl8188eu/core/rtw_m

[PATCH] Staging: rtl8188eu/hal: Fixed code indentation warning detected with checkpatch.pl

2015-07-27 Thread Bareja, Mayank (M.)
>From : Mayank Bareja fixed code indentation warning as reported by checkpatch.pl. Replaced Spaces with Tabs. Signed-off-by: Mayank Bareja --- drivers/staging/rtl8188eu/hal/bb_cfg.c |6 +++--- drivers/staging/rtl8188eu/hal/rf.c |2 +- 2 files changed, 4 insertions(+), 4 deletions(-

linux-next: manual merge of the vfs tree with the tree

2015-06-04 Thread m...@ellerman.id.au
Hi Al, Today's linux-next merge of the vfs tree got a conflict in fs/namei.c between commit 890458a43dbd ("path: New helpers path_get_pin/path_put_unpin for path pin") from the nfsd tree and commit 894bc8c4662b ("namei: remove restrictions on nesting depth") from the vfs tree. I fixed it up (see

You have been pick for a personal donation from me. Email ( leon.hirt...@mail.com ) for more info.‏

2015-05-29 Thread Fernandez, Mercedes M.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [tpmdd-devel] [PATCH 1/3] vTPM: fixed the limit checking

2015-05-12 Thread Joy M. Latten
a56a13..e77d8c1 100644 > > --- a/drivers/char/tpm/tpm_eventlog.c > > +++ b/drivers/char/tpm/tpm_eventlog.c > > @@ -116,11 +116,8 @@ static void *tpm_bios_measurements_next(struct > > seq_file *m, void *v, > > > > event = v; > > > > - if (event-

Re: [PATCH 3/3] vTPM: support little endian guests

2015-05-11 Thread Joy M. Latten
Hi Ashley, On Fri, 2015-05-08 at 17:31 -0500, Ashley Lai wrote: > > The event log in ppc64 arch is always in big endian format. PowerPC > > supports both little endian and big endian guests. This patch converts > > the event log entries to guest format. > > I'm a little confused here. If this pat

Re: [PATCH 0/2] block: loop: fix stacked loop and performance regression

2015-05-05 Thread Justin M. Forbes
> drivers/block/loop.c | 30 ++ > drivers/block/loop.h | 1 + > 2 files changed, 15 insertions(+), 16 deletions(-) > > > Thanks, > Ming Lei > Tested with Fedora 22 ISOs, these still solve the problem for us. Tested-by: Justin M. For

Re: loop block-mq conversion scalability issues

2015-04-27 Thread Justin M. Forbes
On Sun, 2015-04-26 at 23:27 +0800, Ming Lei wrote: > Hi Justin, > > On Fri, 24 Apr 2015 16:46:02 -0500 > "Justin M. Forbes" wrote: > > > On Fri, 2015-04-24 at 10:59 +0800, Ming Lei wrote: > > > Hi Justin, > > > > > > Thanks for t

Re: loop block-mq conversion scalability issues

2015-04-24 Thread Justin M. Forbes
On Fri, 2015-04-24 at 10:59 +0800, Ming Lei wrote: > Hi Justin, > > Thanks for the report. > > On Thu, 23 Apr 2015 16:04:10 -0500 > "Justin M. Forbes" wrote: > > > The block-mq conversion for loop in 4.0 kernels is showing us an > > interesting scal

loop block-mq conversion scalability issues

2015-04-23 Thread Justin M. Forbes
The block-mq conversion for loop in 4.0 kernels is showing us an interesting scalability problem with live CDs (ro, squashfs). It was noticed when testing the Fedora beta that the more CPUs a liveCD image was given, the slower it would boot. A 4 core qemu instance or bare metal instance took more

[PATCH v5 07/15] staging: rtl8723au: Remove unneeded curly braces

2015-03-28 Thread M. Vefa Bicakci
Correct a number of checkpatch.pl warnings in rtl8723au's rtw_security.c related to the existence of unnecessary curly braces around single statement blocks: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8

[PATCH v5 01/15] staging: rtl8723au: Reformat whitespace to increase readability

2015-03-28 Thread M. Vefa Bicakci
Adjust the whitespace in the signature, local variable declaration and initialization parts of a number of functions to increase readability in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- v2: Make sure that the arcfour_encrypt function's argument list is split

[PATCH v5 13/15] staging: rtl8723au: Rework two byte array comparisons

2015-03-28 Thread M. Vefa Bicakci
s for suggesting the use of 32-bit integer comparisons instead of byte array comparisons. Signed-off-by: M. Vefa Bicakci --- v2: Correct code style issues and compare 32-bit integers instead of byte arrays. Update the commit message to better reflect the nature of the changes. --- drivers/st

[PATCH v5 11/15] staging: rtl8723au: Adjust whitespace in and around comments

2015-03-28 Thread M. Vefa Bicakci
As the subject indicates, adjust whitespace in and around comments in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 113 +- 1 file changed, 57 insertions(+), 56 deletions(-) diff --git a/drivers/st

[PATCH v5 02/15] staging: rtl8723au: Fix "before/around/after" whitespace issues

2015-03-28 Thread M. Vefa Bicakci
Correct a number of "space(s) required before/around/after" checkpatch.pl issues in a number of functions in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- v5: Correct even more whitespace issues. v2: Correct one more whitespace issue ("length-4") i

[PATCH v5 09/15] staging: rtl8723au: that open brace should be on the previous line

2015-03-28 Thread M. Vefa Bicakci
Correct two instances of the checkpatch.pl error indicating that the opening curly braces should not be on new lines: ERROR: that open brace { should be on the previous line Signed-off-by: M. Vefa Bicakci --- v3: Make sure that all edited lines are at most 80 characters wide

[PATCH v5 15/15] staging: rtl8723au: Remove unneeded comments

2015-03-28 Thread M. Vefa Bicakci
This commit removes a number of unneeded comments. Two of the aforementioned comments were most likely meant to aid with version control, whereas the remaining two comments relate to (now unused) local variable names. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v5 10/15] staging: rtl8723au: No spaces at the start of a line

2015-03-28 Thread M. Vefa Bicakci
line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 140 +- 1 file changed, 70 insertions(+), 70 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index 2d50777

[PATCH v5 14/15] staging: rtl8723au: Use __func__ in trace logs

2015-03-28 Thread M. Vefa Bicakci
r the suggestion to use __func__. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 41 ++- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_secur

[PATCH v5 04/15] staging: rtl8723au: Fix the indentation of two lines

2015-03-28 Thread M. Vefa Bicakci
Correct the indentation of two lines in rtw_tkip_encrypt23a function in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au

[PATCH v5 08/15] staging: rtl8723au: trailing statements should be on next line

2015-03-28 Thread M. Vefa Bicakci
Correct a number of checkpatch.pl errors in rtl8723au's rtw_security.c related to trailing statements: ERROR: trailing statements should be on next line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 25 + 1 file change

[PATCH v5 03/15] staging: rtl8723au: else should follow close brace

2015-03-28 Thread M. Vefa Bicakci
Correct checkpatch.pl errors in rtl8723au's rtw_security.c indicating that an else statement should follow the closing brace of the previous if/else if code block: ERROR: else should follow close brace '}' Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v5 12/15] staging: rtl8723au: suspect code indent for conditional statements

2015-03-28 Thread M. Vefa Bicakci
Correct a number of indentation-with-spaces-and-tabs issues in rtl8723au's rtw_security.c, according to checkpatch.pl: WARNING: suspect code indent for conditional statements Signed-off-by: M. Vefa Bicakci --- v3: Make sure that all edited lines are at most 80 characters

[PATCH v5 00/15] checkpatch clean-up of rtl8723au's rtw_security.c

2015-03-28 Thread M. Vefa Bicakci
ssages for the changes since v1. In summary, the following commits have been updated: - Reformat whitespace to increase readability - Fix "before/around/after" whitespace issues - Rework two byte array comparisons M. Vefa Bicakci (15): staging: rtl8723au: Reformat whi

[PATCH v5 05/15] staging: rtl8723au: Reorganize a few functions to remove indentation

2015-03-28 Thread M. Vefa Bicakci
with _FAIL, as expected by the calling code. This lets us remove two levels of indentation from the functions in question, making them more readable. Signed-off-by: M. Vefa Bicakci --- v5: Move the "start to encrypt each fragment" and "start to decrypt recvframe" c

[PATCH v5 06/15] staging: rtl8723au: else is not generally useful after a return

2015-03-28 Thread M. Vefa Bicakci
d-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 42 ++- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index df7261c045fe..b85e5de

Re: [PATCH v4 00/15] checkpatch clean-up of rtl8723au's rtw_security.c

2015-03-28 Thread M. Vefa Bicakci
On Sat, March 28, 2015 12:52:54 Joe Perches wrote: > On Sat, 2015-03-28 at 08:52 -0400, M. Vefa Bicakci wrote: > > These commits address a number of checkpatch.pl warnings and errors > > in rtl8723au's rtw_security.c. > > Hello. > > This is one of those patchse

[PATCH v4 03/15] staging: rtl8723au: else should follow close brace

2015-03-28 Thread M. Vefa Bicakci
Correct checkpatch.pl errors in rtl8723au's rtw_security.c indicating that an else statement should follow the closing brace of the previous if/else if code block: ERROR: else should follow close brace '}' Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v4 08/15] staging: rtl8723au: trailing statements should be on next line

2015-03-28 Thread M. Vefa Bicakci
Correct a number of checkpatch.pl errors in rtl8723au's rtw_security.c related to trailing statements: ERROR: trailing statements should be on next line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 25 + 1 file change

[PATCH v4 06/15] staging: rtl8723au: else is not generally useful after a return

2015-03-28 Thread M. Vefa Bicakci
d-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 42 ++- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index f7b1d45981..f7571

[PATCH v4 09/15] staging: rtl8723au: that open brace should be on the previous line

2015-03-28 Thread M. Vefa Bicakci
Correct two instances of the checkpatch.pl error indicating that the opening curly braces should not be on new lines: ERROR: that open brace { should be on the previous line Signed-off-by: M. Vefa Bicakci --- v3: Make sure that all edited lines are at most 80 characters wide

[PATCH v4 05/15] staging: rtl8723au: Reorganize a few functions to remove indentation

2015-03-28 Thread M. Vefa Bicakci
with _FAIL, as expected by the calling code. This lets us remove two levels of indentation from the functions in question, making them more readable. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 178 +- 1 file changed, 88 insertions(+

[PATCH v4 13/15] staging: rtl8723au: Rework two byte array comparisons

2015-03-28 Thread M. Vefa Bicakci
s for suggesting the use of 32-bit integer comparisons instead of byte array comparisons. Signed-off-by: M. Vefa Bicakci --- v2: Correct code style issues and compare 32-bit integers instead of byte arrays. Update the commit message to better reflect the nature of the changes. --- drivers/st

[PATCH v4 07/15] staging: rtl8723au: Remove unneeded curly braces

2015-03-28 Thread M. Vefa Bicakci
Correct a number of checkpatch.pl warnings in rtl8723au's rtw_security.c related to the existence of unnecessary curly braces around single statement blocks: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8

[PATCH v4 02/15] staging: rtl8723au: Fix "before/around/after" whitespace issues

2015-03-28 Thread M. Vefa Bicakci
Correct a number of "space(s) required before/around/after" checkpatch.pl issues in a number of functions in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- v2: Correct one more whitespace issue ("length-4") in rtw_tkip_decrypt23a. --- drive

[PATCH v4 04/15] staging: rtl8723au: Fix the indentation of two lines

2015-03-28 Thread M. Vefa Bicakci
Correct the indentation of two lines in rtw_tkip_encrypt23a function in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au

[PATCH v4 14/15] staging: rtl8723au: Use __func__ in trace logs

2015-03-28 Thread M. Vefa Bicakci
r the suggestion to use __func__. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 49 --- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_secur

[PATCH v4 11/15] staging: rtl8723au: Adjust whitespace in and around comments

2015-03-28 Thread M. Vefa Bicakci
As the subject indicates, adjust whitespace in and around comments in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 114 +- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/drivers/st

[PATCH v4 12/15] staging: rtl8723au: suspect code indent for conditional statements

2015-03-28 Thread M. Vefa Bicakci
Correct a number of indentation-with-spaces-and-tabs issues in rtl8723au's rtw_security.c, according to checkpatch.pl: WARNING: suspect code indent for conditional statements Signed-off-by: M. Vefa Bicakci --- v3: Make sure that all edited lines are at most 80 characters

[PATCH v4 15/15] staging: rtl8723au: Remove unneeded comments

2015-03-28 Thread M. Vefa Bicakci
This commit removes a number of unneeded comments. Two of the aforementioned comments were most likely meant to aid with version control, whereas the remaining two comments relate to (now unused) local variable names. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v4 10/15] staging: rtl8723au: No spaces at the start of a line

2015-03-28 Thread M. Vefa Bicakci
line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 140 +- 1 file changed, 70 insertions(+), 70 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index 0557a

[PATCH v4 01/15] staging: rtl8723au: Reformat whitespace to increase readability

2015-03-28 Thread M. Vefa Bicakci
Adjust the whitespace in the signature, local variable declaration and initialization parts of a number of functions to increase readability in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- v2: Make sure that the arcfour_encrypt function's argument list is split

[PATCH v4 00/15] checkpatch clean-up of rtl8723au's rtw_security.c

2015-03-28 Thread M. Vefa Bicakci
v1. In summary, the following commits have been updated: - Reformat whitespace to increase readability - Fix "before/around/after" whitespace issues - Rework two byte array comparisons M. Vefa Bicakci (15): staging: rtl8723au: Reformat whitespace to increase readability staging:

Re: [PATCH v3 01/15] staging: rtl8723au: Reformat whitespace to increase readability

2015-03-28 Thread M. Vefa Bicakci
On 26/03/15 08:18 AM, Greg KH wrote: > On Thu, Mar 19, 2015 at 12:39:04AM -0400, M. Vefa Bicakci wrote: >> Adjust the whitespace in the signature, local variable declaration and >> initialization parts of a number of functions to increase readability >> in rtl8723au'

[PATCH v3 10/15] staging: rtl8723au: No spaces at the start of a line

2015-03-18 Thread M. Vefa Bicakci
line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 140 +- 1 file changed, 70 insertions(+), 70 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index 0557a

[PATCH v3 00/15] checkpatch clean-up of rtl8723au's rtw_security.c

2015-03-18 Thread M. Vefa Bicakci
d: - Reformat whitespace to increase readability - Fix "before/around/after" whitespace issues - Rework two byte array comparisons M. Vefa Bicakci (15): staging: rtl8723au: Reformat whitespace to increase readability staging: rtl8723au: Fix "before/around/after" whit

[PATCH v3 04/15] staging: rtl8723au: Fix the indentation of two lines

2015-03-18 Thread M. Vefa Bicakci
Correct the indentation of two lines in rtw_tkip_encrypt23a function in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au

[PATCH v3 05/15] staging: rtl8723au: Reorganize a few functions to remove indentation

2015-03-18 Thread M. Vefa Bicakci
with _FAIL, as expected by the calling code. This lets us remove two levels of indentation from the functions in question, making them more readable. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 178 +- 1 file changed, 88 insertions(+

[PATCH v3 06/15] staging: rtl8723au: else is not generally useful after a return

2015-03-18 Thread M. Vefa Bicakci
d-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 42 ++- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index f7b1d45981..f7571

[PATCH v3 15/15] staging: rtl8723au: Remove unneeded comments

2015-03-18 Thread M. Vefa Bicakci
This commit removes a number of unneeded comments. Two of the aforementioned comments were most likely meant to aid with version control, whereas the remaining two comments relate to (now unused) local variable names. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v3 02/15] staging: rtl8723au: Fix "before/around/after" whitespace issues

2015-03-18 Thread M. Vefa Bicakci
Correct a number of "space(s) required before/around/after" checkpatch.pl issues in a number of functions in rtl8723au's rtw_security.c. v2: Correct one more whitespace issue ("length-4") in rtw_tkip_decrypt23a. Signed-off-by: M. Vefa Bicakci --- drive

[PATCH v3 11/15] staging: rtl8723au: Adjust whitespace in and around comments

2015-03-18 Thread M. Vefa Bicakci
As the subject indicates, adjust whitespace in and around comments in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 114 +- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/drivers/st

[PATCH v3 12/15] staging: rtl8723au: suspect code indent for conditional statements

2015-03-18 Thread M. Vefa Bicakci
Correct a number of indentation-with-spaces-and-tabs issues in rtl8723au's rtw_security.c, according to checkpatch.pl: WARNING: suspect code indent for conditional statements v3: Make sure that all edited lines are at most 80 characters wide. Signed-off-by: M. Vefa Bicakci --- dr

[PATCH v3 13/15] staging: rtl8723au: Rework two byte array comparisons

2015-03-18 Thread M. Vefa Bicakci
s for suggesting the use of 32-bit integer comparisons instead of byte array comparisons. v2: Correct code style issues and compare 32-bit integers instead of byte arrays. Update the commit message to better reflect the nature of the changes. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8

[PATCH v3 08/15] staging: rtl8723au: trailing statements should be on next line

2015-03-18 Thread M. Vefa Bicakci
Correct a number of checkpatch.pl errors in rtl8723au's rtw_security.c related to trailing statements: ERROR: trailing statements should be on next line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 25 + 1 file change

[PATCH v3 09/15] staging: rtl8723au: that open brace should be on the previous line

2015-03-18 Thread M. Vefa Bicakci
Correct two instances of the checkpatch.pl error indicating that the opening curly braces should not be on new lines: ERROR: that open brace { should be on the previous line v3: Make sure that all edited lines are at most 80 characters wide. Signed-off-by: M. Vefa Bicakci --- drivers

[PATCH v3 14/15] staging: rtl8723au: Use __func__ in trace logs

2015-03-18 Thread M. Vefa Bicakci
r the suggestion to use __func__. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 49 --- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_secur

[PATCH v3 03/15] staging: rtl8723au: else should follow close brace

2015-03-18 Thread M. Vefa Bicakci
Correct checkpatch.pl errors in rtl8723au's rtw_security.c indicating that an else statement should follow the closing brace of the previous if/else if code block: ERROR: else should follow close brace '}' Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v3 07/15] staging: rtl8723au: Remove unneeded curly braces

2015-03-18 Thread M. Vefa Bicakci
Correct a number of checkpatch.pl warnings in rtl8723au's rtw_security.c related to the existence of unnecessary curly braces around single statement blocks: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8

[PATCH v3 01/15] staging: rtl8723au: Reformat whitespace to increase readability

2015-03-18 Thread M. Vefa Bicakci
Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 79 +-- 1 file changed, 38 insertions(+), 41 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index 045a24c81b..088533c

Re: [PATCH v2 00/16] checkpatch clean-up of rtl8723au's rtw_security.c

2015-03-18 Thread M. Vefa Bicakci
On 2015-03-16 12:01 PM, Jes Sorensen wrote: > "M. Vefa Bicakci" writes: >> [snip] >> >> I hope this clarifies my set-up. Is there something I am doing incorrectly? >> If there is anything I can assist with, please let me know. >> >> Thank you, &g

<    2   3   4   5   6   7   8   9   10   11   >