Re: [PATCH] serial: 8250: add option to disable registration of legacy ISA ports

2021-02-18 Thread Maarten Brock
On 2021-01-31 14:18, Måns Rullgård wrote: What userspace visable change will be caused by this? There won't be /dev/ttyS devices for ports that don't exist. Oh yes, please! That would mean I can create ttyS2 and upward while keeping ttyPS0 and ttyPS1 (which invaded the serial alias namespac

Re: [PATCH v2 0/7] tty: add flag to suppress ready signalling on open

2020-12-11 Thread Maarten Brock
On 2020-12-10 19:59, Mychaela Falconia wrote: Maarten Brock wrote: I agree. And an application not configuring the required handshakes, but still relying on them is an equal bug. This comment can be interpreted in at least two different ways. Are you referring to: 1) Mainstream existing

Re: [PATCH v2 0/7] tty: add flag to suppress ready signalling on open

2020-12-10 Thread Maarten Brock
On 2020-12-10 11:50, Greg Kroah-Hartman wrote: On Thu, Dec 10, 2020 at 11:41:24AM +0100, Maarten Brock wrote: Hello Mychaela, On 2020-12-09 23:49, Mychaela Falconia wrote: > Greg K-H wrote: > > > I think we need more review for the rest of the series. This does > > change th

Re: [PATCH v2 0/7] tty: add flag to suppress ready signalling on open

2020-12-10 Thread Maarten Brock
Hello Mychaela, On 2020-12-09 23:49, Mychaela Falconia wrote: Greg K-H wrote: I think we need more review for the rest of the series. This does change the way serial ports work in a non-traditional way (i.e. using sysfs instead of terminal settings). But the problem is that the current stat

Re: [PATCH 22/36] tty: serial: xilinx_uartps: Supply description for missing member 'cts_override'

2020-11-16 Thread Maarten Brock
On 2020-11-04 20:35, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/tty/serial/xilinx_uartps.c:205: warning: Function parameter or member 'cts_override' not described in 'cdns_uart' Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Michal Simek Cc: linux-ser...@vger.kerne

Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-18 Thread Maarten Brock
On 2020-05-18 18:35, Andy Shevchenko wrote: On Mon, May 18, 2020 at 06:13:16PM +0200, Maarten Brock wrote: On 2020-05-18 17:22, Lukas Wunner wrote: > On Mon, May 18, 2020 at 06:12:41PM +0300, Andy Shevchenko wrote: > > On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote: &

Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO

2020-05-18 Thread Maarten Brock
On 2020-05-18 17:22, Lukas Wunner wrote: On Mon, May 18, 2020 at 06:12:41PM +0300, Andy Shevchenko wrote: On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > The RE signal is used to control the duplex mode of transmissions, > aka receiving data while send

Re: [PATCH v2 4/7] serial: 8250: Handle implementations not having TEMT interrupt using em485

2020-05-05 Thread Maarten Brock
On 2020-05-02 15:49, Lukas Wunner wrote: On Thu, Mar 26, 2020 at 12:14:19AM +0100, Heiko Stuebner wrote: Some 8250 ports have a TEMT interrupt but it's not a part of the 8250 standard, instead only available on some implementations. The current em485 implementation does not work on ports withou

Re: [PATCH v2 0/4] serial: uartps: Driver updates

2018-12-20 Thread Maarten Brock
On 2018-12-20 07:52, Michal Simek wrote: Hi, On 19. 12. 18 19:40, Maarten Brock wrote: Hello Michal, On 2018-12-18 13:18, Michal Simek wrote: Hi, I am sending 4 patches in series to fix some issues we found. Patches were sent separately but I have been asked to send them in serial that&#

Re: [PATCH v2 0/4] serial: uartps: Driver updates

2018-12-19 Thread Maarten Brock
Hello Michal, On 2018-12-18 13:18, Michal Simek wrote: Hi, I am sending 4 patches in series to fix some issues we found. Patches were sent separately but I have been asked to send them in serial that's why I am also adding cover letter to explain this v2 version. Thanks, Michal I'm wondering

Re: [RFC PATCH 0/3] serial: uartps: Add run time support for more IPs than hardcoded 2

2018-05-05 Thread Maarten Brock
On 2018-04-26 16:08, Michal Simek wrote: Hi, this series is trying to address discussion I had with Alan in past https://patchwork.kernel.org/patch/9738445/. It is moving uart_register_driver() to probe function like it is done in pl011 driver. And also introducing new function for alias comp

Re: [PATCH 1/1] xilinx ps uart: Adding a kernel parameter for the number of xilinx ps uarts

2017-05-25 Thread Maarten Brock
On 2017-05-24 18:09, Michal Simek wrote: On 24.5.2017 15:31, Alan Cox wrote: I am not saying that config option is perfect solution. It is at least aligned with 5 others serial drivers in the tree. And the fact people keep doing hacks jutifies continuing to make a mess. Especialy as in this

Re: [PATCH] Tty: serial - Fix possible NULL derefrence.

2017-02-18 Thread Maarten Brock
Hello Greg, Does that also mean that this isn't possible in the sc16is7xx.c driver in sc16is7xx_spi_probe() line 1358 and sc16is7xx_i2c_probe() line 1419 ? If so, should these checks be removed? Kind regards, Maarten On 2017-01-30 20:37, Greg Kroah-Hartman wrote: On Fri, Jan 27, 2017 at 04:

Re: [PATCH 2/2] sc16is7xx: add reading CTS

2016-07-28 Thread Maarten Brock
the device using indirect access through an I2C or SPI driver with separate interrupts from the UART. There is also more info on the linux-serial mailing list. Kind regards, Maarten Brock - Original Message - From: Pascal JEAN [mailto:epsilo...@gmail.com] To: Greg KH [

Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface

2016-05-06 Thread Maarten Brock
- Original Message - From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] To: Maarten Brock [mailto:m.br...@vanmierlo.com] Cc: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com], Bryan O'Donoghue [mailto:pure.lo...@nexus-software.ie], Peter Hurley [mail

Re: [PATCH v3 03/11] dmaengine: dw: set polarity of handshake interface

2016-05-06 Thread Maarten Brock
- Original Message - From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] To: Bryan O'Donoghue [mailto:pure.lo...@nexus-software.ie], Peter Hurley [mailto:pe...@hurleysoftware.com], linux-ser...@vger.kernel.org, Vinod Koul [mailto:vinod.k...@intel.com], linux-kernel@vger.kerne

Re: [PATCH] serial-uartlite: un-constify uartlite_be/uartlite_le

2016-04-19 Thread Maarten Brock
- Original Message - From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] To: Maarten Brock [mailto:m.br...@vanmierlo.com] Cc: Arnd Bergmann [mailto:a...@arndb.de], Peter Korsgaard [mailto:jac...@sunsite.dk], Jiri Slaby [mailto:jsl...@suse.com], Rich Felker [mailto:dal

Re: [PATCH] serial-uartlite: fix build warning

2016-03-19 Thread Maarten Brock
- Original Message - From: Geert Uytterhoeven [mailto:ge...@linux-m68k.org] To: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] Cc: Peter Korsgaard [mailto:jac...@sunsite.dk], Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org], Jiri Slaby [mailto:jsl...@suse.com], linux-kernel@vge

Re: [PATCH] serial-uartlite: fix build warning

2016-03-10 Thread Maarten Brock
I've created a version 2 of this patch immediately which fixes the warning, but somehow this stays ignored. Please apply my second patch! Maarten > We were getting build warnings about: > drivers/tty/serial/uartlite.c: In function ‘ulite_request_port’: > drivers/tty/serial/uartlite.c:348:21:

Re: [PATCH] serial-uartlite: un-constify uartlite_be/uartlite_le

2016-03-10 Thread Maarten Brock
I've created a version 2 of this patch immediately which fixes the warning, but somehow this stays ignored. Please apply my second patch! Maarten > The patch to make uartlite_be/uartlite_le const was well-intended but > caused a new build warning: > > tty/serial/uartlite.c: In function 'ulite_re