[PATCH 3/6] dma-buf: use reservation objects

2014-02-24 Thread Maarten Lankhorst
This allows reservation objects to be used in dma-buf. it's required for implementing polling support on the fences that belong to a dma-buf. Signed-off-by: Maarten Lankhorst Acked-by: Mauro Carvalho Chehab #drivers/media/v4l2-core/ Acked-by: Thomas Hellstrom #drivers/gpu/drm/ttm --- dr

[PATCH 1/6] fence: dma-buf cross-device synchronization (v17)

2014-02-24 Thread Maarten Lankhorst
r discussion w/ danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problematic. v5: [ Maarten Lankhorst ] Updated for dma-bikeshed-fence and dma-buf-manager. v6: [ Maarten Lankhorst ] I remov

[PATCH 2/6] seqno-fence: Hardware dma-buf implementation of fencing (v5)

2014-02-24 Thread Maarten Lankhorst
nce.h v4: Add spinlock pointer to seqno_fence_init v5: Add condition member to allow wait for != 0. Fix small style errors pointed out by checkpatch. Signed-off-by: Maarten Lankhorst Reviewed-by: Rob Clark #v4 --- Documentation/DocBook/device-drivers.tmpl |1 drivers

[PATCH 0/6] dma-buf synchronization patches (updated)

2014-02-24 Thread Maarten Lankhorst
a comment removed) - add poll support to dma-buf (added comment) --- Maarten Lankhorst (6): fence: dma-buf cross-device synchronization (v17) seqno-fence: Hardware dma-buf implementation of fencing (v5) dma-buf: use reservation objects android: convert sync to fence api, v5

Re: [PATCH 4/6] android: convert sync to fence api, v4

2014-02-24 Thread Maarten Lankhorst
op 19-02-14 14:56, Thomas Hellstrom schreef: >+static void fence_check_cb_func(struct fence *f, struct fence_cb *cb) >+{ >+ struct sync_fence_cb *check = container_of(cb, struct sync_fence_cb, cb); >+ struct sync_fence *fence = check->fence; >+ >+ // TODO: Add a fence->status member and che

Re: [x86] 339a3922f6: +4.3% aim7 jobs-per-min

2014-02-20 Thread Maarten Lankhorst
op 20-02-14 14:06, Fengguang Wu schreef: Hi Maarten, We are glad to find that your commit 339a3922f68dcb7d93001f07b7e914d5cf6c066d ("decrease useless padding") increased aim disk_src performance by 4.3%: 74833276be6802b 339a3922f68dcb7d93001f07b --- -

Re: [PATCH 2/6] seqno-fence: Hardware dma-buf implementation of fencing (v4)

2014-02-19 Thread Maarten Lankhorst
op 17-02-14 19:41, Christian König schreef: Am 17.02.2014 19:24, schrieb Rob Clark: On Mon, Feb 17, 2014 at 12:36 PM, Christian König wrote: Am 17.02.2014 18:27, schrieb Rob Clark: On Mon, Feb 17, 2014 at 11:56 AM, Christian König wrote: Am 17.02.2014 16:56, schrieb Maarten Lankhorst

Re: [PATCH] nouveau, ACPI: fix regression caused by b072e53

2014-02-19 Thread Maarten Lankhorst
using common acpi_check_dsm() interface. Signed-off-by: Jiang Liu --- Hi Maarten, Thanks for bisecting. Could you please help to verify whether this patch fixes the regression? Tested-by: Maarten Lankhorst I was wrong about the operator precedence, seems correct after all. :-) -- To

[PATCH 1/6] fence: dma-buf cross-device synchronization (v17)

2014-02-17 Thread Maarten Lankhorst
r discussion w/ danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problematic. v5: [ Maarten Lankhorst ] Updated for dma-bikeshed-fence and dma-buf-manager. v6: [ Maarten Lankhorst ] I remov

[PATCH 6/6] dma-buf: add poll support, v2

2014-02-17 Thread Maarten Lankhorst
Thanks to Fengguang Wu for spotting a missing static cast. v2: - Kill unused variable need_shared. Signed-off-by: Maarten Lankhorst --- drivers/base/dma-buf.c | 101 +++ include/linux/dma-buf.h | 12 ++ 2 files changed, 113 insertions

[PATCH 5/6] reservation: add support for fences to enable cross-device synchronisation

2014-02-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- include/linux/reservation.h | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/include/linux/reservation.h b/include/linux/reservation.h index 813dae960ebd..92c4851b5a39 100644 --- a/include/linux/reservation.h +++ b

[PATCH 4/6] android: convert sync to fence api, v4

2014-02-17 Thread Maarten Lankhorst
t all fences have fired. v3: - Merge Colin Cross' bugfixes, and the android fence merge optimization. v4: - Merge with the upstream fixes. Signed-off-by: Maarten Lankhorst --- drivers/staging/android/Kconfig |1 drivers/staging/android/Makefile |2 drivers/staging/android

[PATCH 3/6] dma-buf: use reservation objects

2014-02-17 Thread Maarten Lankhorst
This allows reservation objects to be used in dma-buf. it's required for implementing polling support on the fences that belong to a dma-buf. Signed-off-by: Maarten Lankhorst Acked-by: Mauro Carvalho Chehab #drivers/media/v4l2-core/ --- drivers/base/dma-buf.c |

[PATCH 2/6] seqno-fence: Hardware dma-buf implementation of fencing (v4)

2014-02-17 Thread Maarten Lankhorst
oved into dma-fence.c since not much was left of the file. Lots of documentation added. v3: Use fence_ops instead of custom callbacks. Moved to own file to avoid circular dependency between dma-buf.h and fence.h v4: Add spinlock pointer to seqno_fence_init Signed-off-by: Maarten Lankhorst ---

[PATCH 0/6] dma-buf synchronization patches

2014-02-17 Thread Maarten Lankhorst
had to fix some fallout from the rebase, hopefully everything's clean now, and ready for -next. --- Maarten Lankhorst (6): fence: dma-buf cross-device synchronization (v17) seqno-fence: Hardware dma-buf implementation of fencing (v4) dma-buf: use reservation objects a

Re: [PATCH 1/7] sched: allow try_to_wake_up to be used internally outside of core.c

2014-01-14 Thread Maarten Lankhorst
op 13-01-14 19:50, Colin Cross schreef: > On Mon, Jan 13, 2014 at 4:31 AM, Maarten Lankhorst > wrote: >> The kernel fence implementation doesn't use event queues, but needs >> to perform the same wake up. The symbol is not exported, since the >> fence implementa

[PATCH 5/7] android: convert sync to fence api, v3

2014-01-13 Thread Maarten Lankhorst
t all fences have fired. v3: - Merge Colin Cross' bugfixes, and the android fence merge optimization. Signed-off-by: Maarten Lankhorst --- drivers/staging/android/Kconfig |1 drivers/staging/android/Makefile |2 drivers/staging/android/sw_sync.c|4 drivers/stagi

[PATCH 7/7] dma-buf: add poll support

2014-01-13 Thread Maarten Lankhorst
Thanks to Fengguang Wu for spotting a missing static cast. Signed-off-by: Maarten Lankhorst --- drivers/base/dma-buf.c | 102 +++ include/linux/dma-buf.h | 12 ++ 2 files changed, 114 insertions(+) diff --git a/drivers/base/dma-buf.c b

[PATCH 4/7] dma-buf: use reservation objects

2014-01-13 Thread Maarten Lankhorst
This allows reservation objects to be used in dma-buf. it's required for implementing polling support on the fences that belong to a dma-buf. Signed-off-by: Maarten Lankhorst --- drivers/base/dma-buf.c | 22 -- drivers/gpu/drm/drm_pr

[PATCH 6/7] reservation: add support for fences to enable cross-device synchronisation

2014-01-13 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- include/linux/reservation.h | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/include/linux/reservation.h b/include/linux/reservation.h index 813dae960ebd..92c4851b5a39 100644 --- a/include/linux/reservation.h +++ b

[PATCH 2/7] fence: dma-buf cross-device synchronization (v16)

2014-01-13 Thread Maarten Lankhorst
danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problematic. v5: [ Maarten Lankhorst ] Updated for dma-bikeshed-fence and dma-buf-manager. v6: [ Maarten Lankhorst ] I removed dma_fence_cance

[PATCH 0/7] dma-buf synchronization patches

2014-01-13 Thread Maarten Lankhorst
The following series implements fence and converts dma-buf and android sync to use it. Patch 6 and 7 add support for polling to dma-buf, blocking until all fences are signaled. --- Maarten Lankhorst (7): sched: allow try_to_wake_up to be used internally outside of core.c fence: dma

[PATCH 1/7] sched: allow try_to_wake_up to be used internally outside of core.c

2014-01-13 Thread Maarten Lankhorst
The kernel fence implementation doesn't use event queues, but needs to perform the same wake up. The symbol is not exported, since the fence implementation is not built as a module. Signed-off-by: Maarten Lankhorst --- include/linux/wait.h |1 + kernel/sched/core.c |2 +- 2

[PATCH 3/7] seqno-fence: Hardware dma-buf implementation of fencing (v4)

2014-01-13 Thread Maarten Lankhorst
oved into dma-fence.c since not much was left of the file. Lots of documentation added. v3: Use fence_ops instead of custom callbacks. Moved to own file to avoid circular dependency between dma-buf.h and fence.h v4: Add spinlock pointer to seqno_fence_init Signed-off-by: Maarten Lankhorst ---

Re: [PATCH 15/85] drivers: gpu: Mark function as static in ctxnvd7.c

2014-01-06 Thread Maarten Lankhorst
; nvd7_grctx_generate_main(struct nvc0_graph_priv *priv, struct nvc0_grctx > *info) > { > struct nvc0_grctx_oclass *oclass = (void *)nv_engine(priv)->cclass; Acked-by: Maarten Lankhorst Building with -Wmissing-prototypes? Good luck fixing radeon! it's a mess. :( -- To unsubscribe from this

Re: [RFC 0/8] Move locking primitives into kernel/locking/

2013-11-05 Thread Maarten Lankhorst
op 05-11-13 14:18, Steven Rostedt schreef: > On Tue, 05 Nov 2013 13:10:44 +0100 > Peter Zijlstra wrote: > >> Hi all, >> >> During Kernel Summit Dave mentioned that there wasn't a clear maintainer for >> locking bits. >> >> To remedy this Ingo suggested gathering all the various locking primitives

Re: [GIT PULL] locking fix

2013-10-27 Thread Maarten Lankhorst
op 27-10-13 20:51, Linus Torvalds schreef: > On Sun, Oct 27, 2013 at 12:37 PM, Maarten Lankhorst > wrote: >> I would love for a compiler to become that smart though, but I do not think >> it's likely. > Dammit, even if that is true, then write the conditional *correct

Re: [GIT PULL] locking fix

2013-10-27 Thread Maarten Lankhorst
op 27-10-13 20:23, Linus Torvalds schreef: > On Sun, Oct 27, 2013 at 12:00 PM, Maarten Lankhorst > wrote: >> op 27-10-13 18:28, Linus Torvalds schreef: >>> That expression is largely equivalent to >>> "__builtin_constant_p(ww_ctx)" (because iff ww_ctx is c

Re: [GIT PULL] locking fix

2013-10-27 Thread Maarten Lankhorst
op 27-10-13 18:28, Linus Torvalds schreef: > On Sat, Oct 26, 2013 at 5:19 AM, Ingo Molnar wrote: >> This tree fixes a boot crash in CONFIG_DEBUG_MUTEXES=y kernels, on >> kernels built with GCC 3.x. (There are still such distros.) > Btw, it's really not just gcc 3.x. That code was (a) incomprehensi

Re: [PATCH for 3.12] mutex: Avoid gcc version dependent__builtin_constant_p() usage.

2013-10-18 Thread Maarten Lankhorst
op 18-10-13 15:13, Ingo Molnar schreef: > * Tetsuo Handa wrote: > >> Peter Zijlstra wrote: >>> On Thu, Oct 17, 2013 at 12:54:21PM +0200, Maarten Lankhorst wrote: >>>> op 17-10-13 12:52, Peter Zijlstra schreef: >>>>> On Thu, Oct 17, 2013 at 07:

Re: [PATCH for 3.12] mutex: Avoid gcc version dependent __builtin_constant_p() usage.

2013-10-17 Thread Maarten Lankhorst
op 17-10-13 12:52, Peter Zijlstra schreef: > On Thu, Oct 17, 2013 at 07:45:29PM +0900, Tetsuo Handa wrote: >> Commit 040a0a37 "mutex: Add support for wound/wait style locks" used >> "!__builtin_constant_p(p == NULL)" but gcc 3.x cannot handle such expression >> correctly, leading to boot failure wh

Re: [PATCH] x86 efi: efi reverve boot service fix

2013-10-16 Thread Maarten Lankhorst
heck boot service region with kernel text region by: >>> start+size >= __pa_symbol(_text) >>> The end of the above region should be start + size - 1 instead. Acked-by: Maarten Lankhorst >>> I see this problem in ovmf + Fedora 19 grub boot: >>> text s

[RFC PATCH v2] drm/radeon: fixup locking inversion between, mmap_sem and reservations

2013-10-09 Thread Maarten Lankhorst
hristian König wrote: >>>>> Am 08.10.2013 16:33, schrieb Jerome Glisse: >>>>>> On Tue, Oct 08, 2013 at 04:14:40PM +0200, Maarten Lankhorst wrote: >>>>>>> Allocate and copy all kernel memory before doing reservations. This >>>>>&g

Re: [RFC PATCH] drm/radeon: fixup locking inversion between mmap_sem and reservations

2013-10-09 Thread Maarten Lankhorst
e Glisse: >>>>> On Tue, Oct 08, 2013 at 04:14:40PM +0200, Maarten Lankhorst wrote: >>>>>> Allocate and copy all kernel memory before doing reservations. This >>>>>> prevents a locking >>>>>> inversion between mmap_sem and reservat

Re: [RFC PATCH] drm/radeon: fixup locking inversion between mmap_sem and reservations

2013-10-08 Thread Maarten Lankhorst
op 08-10-13 16:33, Jerome Glisse schreef: > On Tue, Oct 08, 2013 at 04:14:40PM +0200, Maarten Lankhorst wrote: >> Allocate and copy all kernel memory before doing reservations. This prevents >> a locking >> inversion between mmap_sem and reservation_class, and allows us to dr

[RFC PATCH] drm/radeon: fixup locking inversion between mmap_sem and reservations

2013-10-08 Thread Maarten Lankhorst
Allocate and copy all kernel memory before doing reservations. This prevents a locking inversion between mmap_sem and reservation_class, and allows us to drop the trylocking in ttm_bo_vm_fault without upsetting lockdep. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/radeon

Re: [RFC PATCH] drm/nouveau: fix nested locking in mmap handler

2013-09-24 Thread Maarten Lankhorst
Op 24-09-13 12:33, Thomas Hellstrom schreef: > On 09/24/2013 12:11 PM, Maarten Lankhorst wrote: >> Op 24-09-13 11:36, Daniel Vetter schreef: >>> On Tue, Sep 24, 2013 at 11:03:37AM +0200, Thomas Hellstrom wrote: >>>> On 09/24/2013 09:34 AM, Maarten Lankhorst wrote: &

Re: [RFC PATCH] drm/nouveau: fix nested locking in mmap handler

2013-09-24 Thread Maarten Lankhorst
Op 24-09-13 11:36, Daniel Vetter schreef: > On Tue, Sep 24, 2013 at 11:03:37AM +0200, Thomas Hellstrom wrote: >> On 09/24/2013 09:34 AM, Maarten Lankhorst wrote: >>> Op 24-09-13 09:22, Thomas Hellstrom schreef: >>>> On 09/23/2013 05:33 PM, Maarten Lankhorst wrote: &

Re: [RFC PATCH] drm/nouveau: fix nested locking in mmap handler

2013-09-24 Thread Maarten Lankhorst
Op 24-09-13 11:03, Thomas Hellstrom schreef: > On 09/24/2013 09:34 AM, Maarten Lankhorst wrote: >> Op 24-09-13 09:22, Thomas Hellstrom schreef: >>> On 09/23/2013 05:33 PM, Maarten Lankhorst wrote: >>>> Hey, >>>> >>>> Op 13-09-13 11:00, Peter

Re: [RFC PATCH] drm/nouveau: fix nested locking in mmap handler

2013-09-24 Thread Maarten Lankhorst
Op 24-09-13 09:22, Thomas Hellstrom schreef: > On 09/23/2013 05:33 PM, Maarten Lankhorst wrote: >> Hey, >> >> Op 13-09-13 11:00, Peter Zijlstra schreef: >>> On Fri, Sep 13, 2013 at 10:41:54AM +0200, Daniel Vetter wrote: >>>> On Fri, Sep 13, 2013 at 10:29

[RFC PATCH] drm/nouveau: fix nested locking in mmap handler

2013-09-23 Thread Maarten Lankhorst
Hey, Op 13-09-13 11:00, Peter Zijlstra schreef: > On Fri, Sep 13, 2013 at 10:41:54AM +0200, Daniel Vetter wrote: >> On Fri, Sep 13, 2013 at 10:29 AM, Peter Zijlstra >> wrote: >>> On Fri, Sep 13, 2013 at 09:46:03AM +0200, Thomas Hellstrom wrote: >> if (!bo_tryreserve()) { >> up_read m

Re: [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-13 Thread Maarten Lankhorst
Op 13-09-13 10:23, Thomas Hellstrom schreef: > On 09/13/2013 09:51 AM, Maarten Lankhorst wrote: >> Op 13-09-13 09:46, Thomas Hellstrom schreef: >>> On 09/13/2013 09:16 AM, Maarten Lankhorst wrote: >>>> Op 13-09-13 08:44, Thomas Hellstrom schreef: >>>>&

Re: [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-13 Thread Maarten Lankhorst
Op 13-09-13 09:46, Thomas Hellstrom schreef: > On 09/13/2013 09:16 AM, Maarten Lankhorst wrote: >> Op 13-09-13 08:44, Thomas Hellstrom schreef: >>> On 09/12/2013 11:50 PM, Maarten Lankhorst wrote: >>>> Op 12-09-13 18:44, Thomas Hellstrom schreef: >>>>&

Re: [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-13 Thread Maarten Lankhorst
Op 13-09-13 08:44, Thomas Hellstrom schreef: > On 09/12/2013 11:50 PM, Maarten Lankhorst wrote: >> Op 12-09-13 18:44, Thomas Hellstrom schreef: >>> On 09/12/2013 05:45 PM, Maarten Lankhorst wrote: >>>> Op 12-09-13 17:36, Daniel Vetter schreef: >>>>> On

Re: [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-12 Thread Maarten Lankhorst
Op 12-09-13 18:44, Thomas Hellstrom schreef: > On 09/12/2013 05:45 PM, Maarten Lankhorst wrote: >> Op 12-09-13 17:36, Daniel Vetter schreef: >>> On Thu, Sep 12, 2013 at 5:06 PM, Peter Zijlstra >>> wrote: >>>> So I'm poking around the preemption code

Re: [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-12 Thread Maarten Lankhorst
Op 12-09-13 17:36, Daniel Vetter schreef: > On Thu, Sep 12, 2013 at 5:06 PM, Peter Zijlstra wrote: >> So I'm poking around the preemption code and stumbled upon: >> >> drivers/gpu/drm/i915/i915_gem.c:set_need_resched(); >> drivers/gpu/drm/ttm/ttm_bo_vm.c:set

Re: [BUG] completely bonkers use of set_need_resched + VM_FAULT_NOPAGE

2013-09-12 Thread Maarten Lankhorst
Op 12-09-13 17:06, Peter Zijlstra schreef: > Hi Dave, > > So I'm poking around the preemption code and stumbled upon: > > drivers/gpu/drm/i915/i915_gem.c:set_need_resched(); > drivers/gpu/drm/ttm/ttm_bo_vm.c:set_need_resched(); > drivers/gpu/drm/ttm/ttm_bo_vm

Re: [3.11-rc1] CONFIG_DEBUG_MUTEXES=y using gcc 3.x makes unbootablekernel.

2013-09-09 Thread Maarten Lankhorst
Op 09-09-13 13:56, Tetsuo Handa schreef: > Maarten Lankhorst wrote: >> Almost correct. I meant passing it as parameter to __mutex_lock_common. Your >> version will still cause an extra pointless null check in the ww_mutex_lock >> case. > Ah, I s

Re: [3.11-rc1] CONFIG_DEBUG_MUTEXES=y using gcc 3.x makes unbootablekernel.

2013-09-08 Thread Maarten Lankhorst
Op 08-09-13 13:53, Tetsuo Handa schreef: > Hello. > > Maarten Lankhorst wrote: >> if it's broken for your compiler, please add a bool use_ww_ctx or something >> to __mutex_lock_common that's set directly instead, the __builtin_constant_p >> trick >> mi

Re: [3.11-rc1] CONFIG_DEBUG_MUTEXES=y using gcc 3.x makes unbootable kernel.

2013-09-08 Thread Maarten Lankhorst
Op 08-09-13 09:24, Tetsuo Handa schreef: > Hello. > > Ilia Mirkin wrote: >>> Commit 040a0a37 "mutex: Add support for wound/wait style locks" used >>> "!__builtin_constant_p(p == NULL)" which I guess the author meant that >>> "__builtin_constant_p(p) && p", but gcc 3.x cannot handle such expression

Re: [RFC PATCH] drm/radeon: rework to new fence interface

2013-08-20 Thread Maarten Lankhorst
Op 20-08-13 11:51, Christian König schreef: > Am 20.08.2013 11:36, schrieb Maarten Lankhorst: > [SNIP] > >>>>>> [SNIP] >>>>>> +/** >>>>>> + * radeon_fence_enable_signaling - enable signalling on fence >>>>>> + * @fenc

Re: [RFC PATCH] drm/radeon: rework to new fence interface

2013-08-20 Thread Maarten Lankhorst
Op 20-08-13 10:37, Christian König schreef: > Am 19.08.2013 21:37, schrieb Maarten Lankhorst: >> Op 19-08-13 14:35, Christian König schreef: >>> Am 19.08.2013 12:17, schrieb Maarten Lankhorst: >>>> [SNIP] >>>> @@ -190,25 +225,24 @@ void radeon_fence_pro

Re: [RFC PATCH] drm/radeon: rework to new fence interface

2013-08-19 Thread Maarten Lankhorst
Op 19-08-13 14:35, Christian König schreef: > Am 19.08.2013 12:17, schrieb Maarten Lankhorst: >> [SNIP] >> @@ -190,25 +225,24 @@ void radeon_fence_process(struct radeon_device *rdev, >> int ring) >> } >> } while (atomic64_xchg(&rdev-

[RFC PATCH] drm/radeon: rework to new fence interface

2013-08-19 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index 9f19259..971284e 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -64,6 +64,7 @@ #include #include #include +#include #include

[RFC PATCH] drm/nouveau: rework to new fence interface

2013-08-19 Thread Maarten Lankhorst
nouveau was a bit tricky, it has no support for interrupts on --- diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index be31499..78714e4 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fence.c +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c @@ -35,88 +35

Re: [RFC PATCH] fence: dma-buf cross-device synchronization (v12)

2013-08-15 Thread Maarten Lankhorst
Op 15-08-13 15:14, Rob Clark schreef: > On Thu, Aug 15, 2013 at 7:16 AM, Maarten Lankhorst > wrote: >> Op 12-08-13 17:43, Rob Clark schreef: >>> On Mon, Jul 29, 2013 at 10:05 AM, Maarten Lankhorst >>> wrote: >>>> + > [snip] >>>> +/** >&

Re: [PATCH] fence: dma-buf cross-device synchronization (v13)

2013-08-15 Thread Maarten Lankhorst
Op 15-08-13 14:45, Marcin Ślusarz schreef: > 2013/8/15 Maarten Lankhorst : >> A fence can be attached to a buffer which is being filled or consumed >> by hw, to allow userspace to pass the buffer without waiting to another >> device. For example, userspace can call page_flip

[PATCH] fence: dma-buf cross-device synchronization (v14)

2013-08-15 Thread Maarten Lankhorst
n the fence is passed). v3: Fix locking fail in attach_fence() and get_fence() v4: Remove tie-in w/ dma-buf.. after discussion w/ danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problem

[PATCH] fence: dma-buf cross-device synchronization (v13)

2013-08-15 Thread Maarten Lankhorst
n the fence is passed). v3: Fix locking fail in attach_fence() and get_fence() v4: Remove tie-in w/ dma-buf.. after discussion w/ danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problem

Re: [RFC PATCH] fence: dma-buf cross-device synchronization (v12)

2013-08-15 Thread Maarten Lankhorst
Op 12-08-13 17:43, Rob Clark schreef: > On Mon, Jul 29, 2013 at 10:05 AM, Maarten Lankhorst > wrote: >> A fence can be attached to a buffer which is being filled or consumed >> by hw, to allow userspace to pass the buffer without waiting to another >> device. For exa

[PATCH] udev: fail firmware loading immediately if no search path is defined

2013-08-07 Thread Maarten Lankhorst
om Gundersen wrote: >>>>> On Tue, Aug 6, 2013 at 10:20 AM, Maarten Lankhorst >>>>> wrote: >>>>>> Op 05-08-13 18:29, Andy Lutomirski schreef: >>>>>>> The systemd commit below can delay firmware loading by multiple >>>>>

Re: [PATCH] mutex: fix deadlock injection

2013-08-06 Thread Maarten Lankhorst
Op 07-08-13 02:05, Dave Airlie schreef: > On Tue, Jul 30, 2013 at 6:41 PM, Peter Zijlstra wrote: >> On Tue, Jul 30, 2013 at 10:13:41AM +0200, Maarten Lankhorst wrote: >>> The check needs to be for > 1, because ctx->acquired is already incremented. >>> This wil

Re: [PATCH] Change CONFIG_FW_LOADER_USER_HELPER to default n and don't select it

2013-08-06 Thread Maarten Lankhorst
Op 05-08-13 18:29, Andy Lutomirski schreef: > The systemd commit below can delay firmware loading by multiple > minutes if CONFIG_FW_LOADER_USER_HELPER=y. Unfortunately no one > noticed that the systemd-udev change would break new kernels as well > as old kernels. > > Since the kernel apparently c

[tip:core/urgent] mutex: Fix w/w mutex deadlock injection

2013-07-31 Thread tip-bot for Maarten Lankhorst
Commit-ID: 85f4896123d0299128f2c95cc40f3b8b01d4b0f6 Gitweb: http://git.kernel.org/tip/85f4896123d0299128f2c95cc40f3b8b01d4b0f6 Author: Maarten Lankhorst AuthorDate: Tue, 30 Jul 2013 10:13:41 +0200 Committer: Ingo Molnar CommitDate: Tue, 30 Jul 2013 22:16:40 +0200 mutex: Fix w/w mutex

Re: nouveau: check client.base.vm before dereferencing it.

2013-07-30 Thread Maarten Lankhorst
Op 31-07-13 00:55, Dave Jones schreef: > On Thu, Jul 25, 2013 at 12:22:03PM -0400, Dave Jones wrote: > > This recently started happening (since the last DRM merge, 3.10 was fine). > > > > [ 17.751970] Oops: [#1] PREEMPT SMP DEBUG_PAGEALLOC > > [ 17.753911] CPU: 3 PID: 292 Comm: system

[PATCH] mutex: fix deadlock injection

2013-07-30 Thread Maarten Lankhorst
be able to return -EDEADLK did. Cc: Alex Deucher Signed-off-by: Maarten Lankhorst --- diff --git a/kernel/mutex.c b/kernel/mutex.c index ff05f4b..a52ee7bb 100644 --- a/kernel/mutex.c +++ b/kernel/mutex.c @@ -686,7 +686,7 @@ __ww_mutex_lock(struct ww_mutex *lock, struct ww_acquire_ctx *ctx)

[RFC PATCH] fence: dma-buf cross-device synchronization (v12)

2013-07-29 Thread Maarten Lankhorst
n the fence is passed). v3: Fix locking fail in attach_fence() and get_fence() v4: Remove tie-in w/ dma-buf.. after discussion w/ danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problem

[tip:core/locking] mutex: Move ww_mutex definitions to ww_mutex.h

2013-07-12 Thread tip-bot for Maarten Lankhorst
Commit-ID: 1b375dc30710180c4b88cc59caba6e3481ec5c8b Gitweb: http://git.kernel.org/tip/1b375dc30710180c4b88cc59caba6e3481ec5c8b Author: Maarten Lankhorst AuthorDate: Fri, 5 Jul 2013 09:29:32 +0200 Committer: Ingo Molnar CommitDate: Fri, 12 Jul 2013 12:07:46 +0200 mutex: Move ww_mutex

[PATCH] alx: fix lockdep annotation

2013-07-11 Thread Maarten Lankhorst
Move spin_lock_init to be called before the spinlocks are used, preventing a lockdep splat. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c index 418de8b..d30085c 100644 --- a/drivers/net/ethernet/atheros/alx

[REGRESSION] "UEFI: Don't pass boot services regions to SetVirtualAddressMap()" breaks macbook efi boot

2013-07-10 Thread Maarten Lankhorst
Hey, It seems that in the merge window my macbook pro stopped working at some point. I looked for suspicious efi related commits, and found that reverting commit 1acba98f810a14b1255e34bc620594f83de37e36 worked, letting my macbook pro boot succesfully. Is there anything I can do to help diagnose

inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage with hcd_urb_list_lock

2013-07-06 Thread Maarten Lankhorst
I didn't even know I still had lockdep on. The following lockdep splat happened when I plugged in a usb bluetooth dongle, using the pre-rc1 3.11 kernel at HEAD b2c311075db = [ INFO: inconsistent lock state ] 3.10.0+ #106 Not tainted ---

[PATCH] mutex: move ww_mutex definitions to ww_mutex.h

2013-07-05 Thread Maarten Lankhorst
Op 05-07-13 08:23, Ingo Molnar schreef: > * Maarten Lankhorst wrote: > >> Hey, >> >> Op 03-07-13 02:54, Linus Torvalds schreef: >>> On Mon, Jul 1, 2013 at 1:22 AM, Ingo Molnar wrote: >>>> Please pull the latest core-mutexes-for-linus git tree from: &g

Re: [GIT PULL] core/mutexes changes for v3.11: W/W mutex support

2013-07-02 Thread Maarten Lankhorst
Hey, Op 03-07-13 02:54, Linus Torvalds schreef: > On Mon, Jul 1, 2013 at 1:22 AM, Ingo Molnar wrote: >> Please pull the latest core-mutexes-for-linus git tree from: >> >>git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git >> core-mutexes-for-linus >> >>HEAD: 166989e366ffa66108b2f37

Re: [PATCH v2] mutex: do not unnecessarily deal with waiters

2013-06-29 Thread Maarten Lankhorst
s, for small amounts of users (10-100), were the short and > compute workloads had a +19.36% and +%15.76% in jobs per minute. > > Also change some break statements to 'goto slowpath', which IMO makes a > little more intuitive to read. Nice turquoise bikeshed you built there. ;-) Ack

Re: [PATCH] mutex: do not unnecessarily deal with waiters

2013-06-27 Thread Maarten Lankhorst
Op 28-06-13 03:32, Davidlohr Bueso schreef: > On Thu, 2013-06-27 at 11:00 +0200, Ingo Molnar wrote: > [...] >> So I tried this out yesterday, but it interacted with the Wait/Wound >> patches in tip:core/mutexes. >> >> Maarten Lankhorst pointed out that if this

[tip:core/mutexes] locking-selftests: Handle unexpected failures more strictly

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 166989e366ffa66108b2f37b870e66b85b2185ad Gitweb: http://git.kernel.org/tip/166989e366ffa66108b2f37b870e66b85b2185ad Author: Maarten Lankhorst AuthorDate: Thu, 20 Jun 2013 13:31:51 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:59 +0200 locking-selftests

[tip:core/mutexes] mutex: Add more w/ w tests to test EDEADLK path handling

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: f3cf139efa4bc0fe4f032af6ca3e49e38a5d9ae5 Gitweb: http://git.kernel.org/tip/f3cf139efa4bc0fe4f032af6ca3e49e38a5d9ae5 Author: Maarten Lankhorst AuthorDate: Thu, 20 Jun 2013 13:31:42 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:58 +0200 mutex: Add more w/w

[tip:core/mutexes] mutex: Add support for wound/wait style locks

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 040a0a37100563754bb1fee6ff6427420bcfa609 Gitweb: http://git.kernel.org/tip/040a0a37100563754bb1fee6ff6427420bcfa609 Author: Maarten Lankhorst AuthorDate: Mon, 24 Jun 2013 10:30:04 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:56 +0200 mutex: Add support

[tip:core/mutexes] mutex: Add more tests to lib/ locking-selftest.c

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 2fe3d4b149ccebbb384062fbbe6634439f2bf120 Gitweb: http://git.kernel.org/tip/2fe3d4b149ccebbb384062fbbe6634439f2bf120 Author: Maarten Lankhorst AuthorDate: Thu, 20 Jun 2013 13:31:30 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:57 +0200 mutex: Add more tests

[tip:core/mutexes] mutex: Add w/w tests to lib/locking-selftest.c

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 1de994452f44005e4b1f5c6c77eae4a26f86d484 Gitweb: http://git.kernel.org/tip/1de994452f44005e4b1f5c6c77eae4a26f86d484 Author: Maarten Lankhorst AuthorDate: Thu, 20 Jun 2013 13:31:24 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:57 +0200 mutex: Add w/w tests

[tip:core/mutexes] arch: Make __mutex_fastpath_lock_retval return whether fastpath succeeded or not

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: a41b56efa70e060f650aeb54740aaf52044a1ead Gitweb: http://git.kernel.org/tip/a41b56efa70e060f650aeb54740aaf52044a1ead Author: Maarten Lankhorst AuthorDate: Thu, 20 Jun 2013 13:31:05 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:55 +0200 arch: Make

[PATCH v6 2/7] mutex: add support for wound/wait style locks

2013-06-24 Thread Maarten Lankhorst
Op 20-06-13 14:23, Ingo Molnar schreef: > * Maarten Lankhorst wrote: > >> Well they've helped me with some of the changes and contributed some >> code and/or fixes, but if acked-by is preferred I'll use that.. > Such contributions can be credited in the changel

Re: [PATCH v5 2/7] mutex: add support for wound/wait style locks, v5

2013-06-20 Thread Maarten Lankhorst
Op 20-06-13 13:55, Ingo Molnar schreef: > * Maarten Lankhorst wrote: > >> Changes since RFC patch v1: >> - Updated to use atomic_long instead of atomic, since the reservation_id >> was a long. >> - added mutex_reserve_lock_slow and mutex_reserv

[PATCH v5 4/7] mutex: Add ww tests to lib/locking-selftest.c. v5

2013-06-20 Thread Maarten Lankhorst
locking after ww_acquire_done has been called. - Added a test for unbalance for ctx->acquired dropping below zero. - Added a test for unlocked ww_mutex with ctx != NULL. Signed-off-by: Maarten Lankhorst --- lib/locking-selftest.c | 400 ++-- 1 f

[PATCH v5 7/7] locking-selftests: handle unexpected failures more strictly

2013-06-20 Thread Maarten Lankhorst
When CONFIG_PROVE_LOCKING is not enabled, more tests are expected to pass unexpectedly, but there no tests that should start to fail that pass with CONFIG_PROVE_LOCKING enabled. Signed-off-by: Maarten Lankhorst --- lib/locking-selftest.c |8 +--- 1 file changed, 5 insertions(+), 3

[PATCH v5 2/7] mutex: add support for wound/wait style locks, v5

2013-06-20 Thread Maarten Lankhorst
*, normal functions can be used. Inline versions still exist for extra debugging. - Cleanup unneeded memory barriers, add comment to the remaining smp_mb(). Signed-off-by: Maarten Lankhorst Signed-off-by: Daniel Vetter Signed-off-by: Rob Clark --- Documentation/ww-mutex-design.txt | 343

[PATCH v5 6/7] mutex: add more ww tests to test EDEADLK path handling

2013-06-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- lib/locking-selftest.c | 264 +++- 1 file changed, 261 insertions(+), 3 deletions(-) diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c index 37faefd..d554f3f 100644 --- a/lib/locking-selftest.c +++ b

[PATCH v5 3/7] mutex: w/w mutex slowpath debugging

2013-06-20 Thread Maarten Lankhorst
.debug definition to work correctly. (mlankhorst) v6: Do not inject -EDEADLK when ctx->acquired == 0, because the _slow paths are merged now. (mlankhorst) Cc: Steven Rostedt Signed-off-by: Daniel Vetter Signed-off-by: Maarten Lankhorst --- include/linux/mutex.h |8

[PATCH v5 5/7] mutex: add more tests to lib/locking-selftest.c

2013-06-20 Thread Maarten Lankhorst
None of the ww_mutex codepaths should be taken in the 'normal' mutex calls. The easiest way to verify this is by using the normal mutex calls, and making sure o.ctx is unmodified. Signed-off-by: Maarten Lankhorst --- lib/locking-selftes

[PATCH v5 0/7] add mutex wait/wound/style style locks

2013-06-20 Thread Maarten Lankhorst
Vetter (1): mutex: w/w mutex slowpath debugging Maarten Lankhorst (6): arch: make __mutex_fastpath_lock_retval return whether fastpath succeeded or not. mutex: add support for wound/wait style locks, v5 mutex: Add ww tests to lib/locking-selftest.c. v5 mutex: add more

[PATCH v5 1/7] arch: make __mutex_fastpath_lock_retval return whether fastpath succeeded or not.

2013-06-20 Thread Maarten Lankhorst
was previously used. Changes since v1, pointed out by Francesco Lavra: - fix a small comment issue in mutex_32.h - fix the __mutex_fastpath_lock_retval macro for mutex-null.h Signed-off-by: Maarten Lankhorst --- arch/ia64/include/asm/mutex.h| 10 -- arch/powerpc/include/asm/mutex.h

Re: [PATCH v4 0/4] add mutex wait/wound/style style locks

2013-06-12 Thread Maarten Lankhorst
Op 28-05-13 16:48, Maarten Lankhorst schreef: > Version 4 already? > > Small api changes since v3: > - Remove ww_mutex_unlock_single and ww_mutex_lock_single. > - Rename ww_mutex_trylock_single to ww_mutex_trylock. > - Remove separate implementations of ww_mutex_lock_slow*, no

Re: [inconsistent HARDIRQ usage] &dev->mode_config.idr_mutex at drm_mode_object_find()

2013-06-10 Thread Maarten Lankhorst
Op 10-06-13 03:55, Fengguang Wu schreef: > Maarten, > > Sorry for the delay! > > On Sun, Jun 09, 2013 at 08:58:44AM +0200, Maarten Lankhorst wrote: >> Hey, >> >> Op 06-06-13 09:28, Fengguang Wu schreef: >>> Hi Maarten, >>> >>> Than

Re: [vt_console_print/cirrus_dirty_update] WARNING: at kernel/mutex.c:858 mutex_trylock()

2013-06-09 Thread Maarten Lankhorst
Hey, Op 06-06-13 09:28, Fengguang Wu schreef: > Hi Maarten, > > Thanks for the patch! I'll queue it for the tests. > > I haven't heard back from you yet, did it fix all lockdep issues you were having? If so I'll get it queued. ~Maarten -- To unsubscribe from this list: send the line "unsubscrib

Re: [RFC][PATCH 1/2] dma-buf: add importer private data to attachment

2013-06-07 Thread Maarten Lankhorst
Op 07-06-13 04:32, 김승우 schreef: > Hello Maarten, > > On 2013년 06월 05일 22:23, Maarten Lankhorst wrote: >> Op 31-05-13 10:54, Seung-Woo Kim schreef: >>> dma-buf attachment has only exporter private data, but importer private data >>> can be useful for importer esp

Re: [vt_console_print/cirrus_dirty_update] WARNING: at kernel/mutex.c:858 mutex_trylock()

2013-06-06 Thread Maarten Lankhorst
Hey, Op 06-06-13 03:35, Fengguang Wu schreef: > Greetings, > > I got the below dmesg and the first bad commit is > > commit 3d71c6ed43d838e593538176a9a59debe228cfb0 > Author: Maarten Lankhorst > Date: Tue Apr 2 12:33:01 2013 +0200 > > drm/ttm: con

Re: [RFC][PATCH 1/2] dma-buf: add importer private data to attachment

2013-06-05 Thread Maarten Lankhorst
Op 31-05-13 10:54, Seung-Woo Kim schreef: > dma-buf attachment has only exporter private data, but importer private data > can be useful for importer especially to re-import the same dma-buf. > To use importer private data in attachment of the device, the function to > search attachment in the atta

Re: [PATCH v4 2/4] mutex: add support for wound/wait style locks, v5

2013-05-30 Thread Maarten Lankhorst
Op 29-05-13 12:33, Inki Dae schreef: > Hi, > > Just minor comments > > +Usage >> +- >> + >> +Three different ways to acquire locks within the same w/w class. Common >> +definitions for methods #1 and #2: >> + >> +static DEFINE_WW_CLASS(ww_class); >> + >> +struct obj { >> + struct ww_mutex

Re: [PATCH v4 3/4] mutex: Add ww tests to lib/locking-selftest.c. v4

2013-05-28 Thread Maarten Lankhorst
Op 28-05-13 21:18, Daniel Vetter schreef: > On Tue, May 28, 2013 at 04:48:45PM +0200, Maarten Lankhorst wrote: >> This stresses the lockdep code in some ways specifically useful to >> ww_mutexes. It adds checks for most of the common locking errors. >> >> Changes s

[PATCH v4 2/4] mutex: add support for wound/wait style locks, v5

2013-05-28 Thread Maarten Lankhorst
*, normal functions can be used. Inline versions still exist for extra debugging. - Cleanup unneeded memory barriers, add comment to the remaining smp_mb(). Signed-off-by: Maarten Lankhorst Signed-off-by: Daniel Vetter Signed-off-by: Rob Clark --- Documentation/ww-mutex-design.txt | 344

<    1   2   3   4   5   6   >