Re: [RFC PATCH] fence: dma-buf cross-device synchronization (v12)

2013-08-15 Thread Maarten Lankhorst
Op 15-08-13 15:14, Rob Clark schreef: > On Thu, Aug 15, 2013 at 7:16 AM, Maarten Lankhorst > wrote: >> Op 12-08-13 17:43, Rob Clark schreef: >>> On Mon, Jul 29, 2013 at 10:05 AM, Maarten Lankhorst >>> wrote: >>>> + > [snip] >>>> +/** >&

Re: [PATCH] fence: dma-buf cross-device synchronization (v13)

2013-08-15 Thread Maarten Lankhorst
Op 15-08-13 14:45, Marcin Ślusarz schreef: > 2013/8/15 Maarten Lankhorst : >> A fence can be attached to a buffer which is being filled or consumed >> by hw, to allow userspace to pass the buffer without waiting to another >> device. For example, userspace can call page_

[PATCH] fence: dma-buf cross-device synchronization (v14)

2013-08-15 Thread Maarten Lankhorst
v3: Fix locking fail in attach_fence() and get_fence() v4: Remove tie-in w/ dma-buf.. after discussion w/ danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problematic. v5: [ Maarten Lankhorst ] Upd

[PATCH] fence: dma-buf cross-device synchronization (v13)

2013-08-15 Thread Maarten Lankhorst
v3: Fix locking fail in attach_fence() and get_fence() v4: Remove tie-in w/ dma-buf.. after discussion w/ danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problematic. v5: [ Maarten Lankhorst ] Upd

Re: [RFC PATCH] fence: dma-buf cross-device synchronization (v12)

2013-08-15 Thread Maarten Lankhorst
Op 12-08-13 17:43, Rob Clark schreef: > On Mon, Jul 29, 2013 at 10:05 AM, Maarten Lankhorst > wrote: >> A fence can be attached to a buffer which is being filled or consumed >> by hw, to allow userspace to pass the buffer without waiting to another >> device. For exa

Re: [RFC PATCH] fence: dma-buf cross-device synchronization (v12)

2013-08-15 Thread Maarten Lankhorst
Op 12-08-13 17:43, Rob Clark schreef: On Mon, Jul 29, 2013 at 10:05 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: A fence can be attached to a buffer which is being filled or consumed by hw, to allow userspace to pass the buffer without waiting to another device. For example

[PATCH] fence: dma-buf cross-device synchronization (v13)

2013-08-15 Thread Maarten Lankhorst
in attach_fence() and get_fence() v4: Remove tie-in w/ dma-buf.. after discussion w/ danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problematic. v5: [ Maarten Lankhorst ] Updated for dma-bikeshed-fence

[PATCH] fence: dma-buf cross-device synchronization (v14)

2013-08-15 Thread Maarten Lankhorst
in attach_fence() and get_fence() v4: Remove tie-in w/ dma-buf.. after discussion w/ danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problematic. v5: [ Maarten Lankhorst ] Updated for dma-bikeshed-fence

Re: [PATCH] fence: dma-buf cross-device synchronization (v13)

2013-08-15 Thread Maarten Lankhorst
Op 15-08-13 14:45, Marcin Ślusarz schreef: 2013/8/15 Maarten Lankhorst maarten.lankho...@canonical.com: A fence can be attached to a buffer which is being filled or consumed by hw, to allow userspace to pass the buffer without waiting to another device. For example, userspace can call

Re: [RFC PATCH] fence: dma-buf cross-device synchronization (v12)

2013-08-15 Thread Maarten Lankhorst
Op 15-08-13 15:14, Rob Clark schreef: On Thu, Aug 15, 2013 at 7:16 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 12-08-13 17:43, Rob Clark schreef: On Mon, Jul 29, 2013 at 10:05 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: + [snip

[PATCH] udev: fail firmware loading immediately if no search path is defined

2013-08-07 Thread Maarten Lankhorst
om Gundersen wrote: >>>>> On Tue, Aug 6, 2013 at 10:20 AM, Maarten Lankhorst >>>>> wrote: >>>>>> Op 05-08-13 18:29, Andy Lutomirski schreef: >>>>>>> The systemd commit below can delay firmware loading by multiple >>>>>

Re: [PATCH] mutex: fix deadlock injection

2013-08-07 Thread Maarten Lankhorst
Op 07-08-13 02:05, Dave Airlie schreef: > On Tue, Jul 30, 2013 at 6:41 PM, Peter Zijlstra wrote: >> On Tue, Jul 30, 2013 at 10:13:41AM +0200, Maarten Lankhorst wrote: >>> The check needs to be for > 1, because ctx->acquired is already incremented. >>> This wil

Re: [PATCH] mutex: fix deadlock injection

2013-08-07 Thread Maarten Lankhorst
Op 07-08-13 02:05, Dave Airlie schreef: On Tue, Jul 30, 2013 at 6:41 PM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Jul 30, 2013 at 10:13:41AM +0200, Maarten Lankhorst wrote: The check needs to be for 1, because ctx-acquired is already incremented. This will prevent ww_mutex_lock_slow

[PATCH] udev: fail firmware loading immediately if no search path is defined

2013-08-07 Thread Maarten Lankhorst
...@jklm.no wrote: On Tue, Aug 6, 2013 at 10:20 AM, Maarten Lankhorst m.b.lankho...@gmail.com wrote: Op 05-08-13 18:29, Andy Lutomirski schreef: The systemd commit below can delay firmware loading by multiple minutes if CONFIG_FW_LOADER_USER_HELPER=y. Unfortunately no one noticed

Re: [PATCH] Change CONFIG_FW_LOADER_USER_HELPER to default n and don't select it

2013-08-06 Thread Maarten Lankhorst
Op 05-08-13 18:29, Andy Lutomirski schreef: > The systemd commit below can delay firmware loading by multiple > minutes if CONFIG_FW_LOADER_USER_HELPER=y. Unfortunately no one > noticed that the systemd-udev change would break new kernels as well > as old kernels. > > Since the kernel apparently

Re: [PATCH] Change CONFIG_FW_LOADER_USER_HELPER to default n and don't select it

2013-08-06 Thread Maarten Lankhorst
Op 05-08-13 18:29, Andy Lutomirski schreef: The systemd commit below can delay firmware loading by multiple minutes if CONFIG_FW_LOADER_USER_HELPER=y. Unfortunately no one noticed that the systemd-udev change would break new kernels as well as old kernels. Since the kernel apparently can't

[tip:core/urgent] mutex: Fix w/w mutex deadlock injection

2013-07-31 Thread tip-bot for Maarten Lankhorst
Commit-ID: 85f4896123d0299128f2c95cc40f3b8b01d4b0f6 Gitweb: http://git.kernel.org/tip/85f4896123d0299128f2c95cc40f3b8b01d4b0f6 Author: Maarten Lankhorst AuthorDate: Tue, 30 Jul 2013 10:13:41 +0200 Committer: Ingo Molnar CommitDate: Tue, 30 Jul 2013 22:16:40 +0200 mutex: Fix w/w mutex

Re: nouveau: check client.base.vm before dereferencing it.

2013-07-31 Thread Maarten Lankhorst
Op 31-07-13 00:55, Dave Jones schreef: > On Thu, Jul 25, 2013 at 12:22:03PM -0400, Dave Jones wrote: > > This recently started happening (since the last DRM merge, 3.10 was fine). > > > > [ 17.751970] Oops: [#1] PREEMPT SMP DEBUG_PAGEALLOC > > [ 17.753911] CPU: 3 PID: 292 Comm:

Re: nouveau: check client.base.vm before dereferencing it.

2013-07-31 Thread Maarten Lankhorst
Op 31-07-13 00:55, Dave Jones schreef: On Thu, Jul 25, 2013 at 12:22:03PM -0400, Dave Jones wrote: This recently started happening (since the last DRM merge, 3.10 was fine). [ 17.751970] Oops: [#1] PREEMPT SMP DEBUG_PAGEALLOC [ 17.753911] CPU: 3 PID: 292 Comm: systemd-udevd

[tip:core/urgent] mutex: Fix w/w mutex deadlock injection

2013-07-31 Thread tip-bot for Maarten Lankhorst
Commit-ID: 85f4896123d0299128f2c95cc40f3b8b01d4b0f6 Gitweb: http://git.kernel.org/tip/85f4896123d0299128f2c95cc40f3b8b01d4b0f6 Author: Maarten Lankhorst maarten.lankho...@canonical.com AuthorDate: Tue, 30 Jul 2013 10:13:41 +0200 Committer: Ingo Molnar mi...@kernel.org CommitDate: Tue, 30

[PATCH] mutex: fix deadlock injection

2013-07-30 Thread Maarten Lankhorst
e able to return -EDEADLK did. Cc: Alex Deucher Signed-off-by: Maarten Lankhorst --- diff --git a/kernel/mutex.c b/kernel/mutex.c index ff05f4b..a52ee7bb 100644 --- a/kernel/mutex.c +++ b/kernel/mutex.c @@ -686,7 +686,7 @@ __ww_mutex_lock(struct ww_mutex *lock, struct ww_acquire_ctx *ctx) might

[PATCH] mutex: fix deadlock injection

2013-07-30 Thread Maarten Lankhorst
to return -EDEADLK did. Cc: Alex Deucher alexander.deuc...@amd.com Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- diff --git a/kernel/mutex.c b/kernel/mutex.c index ff05f4b..a52ee7bb 100644 --- a/kernel/mutex.c +++ b/kernel/mutex.c @@ -686,7 +686,7 @@ __ww_mutex_lock(struct ww_mutex

[RFC PATCH] fence: dma-buf cross-device synchronization (v12)

2013-07-29 Thread Maarten Lankhorst
v3: Fix locking fail in attach_fence() and get_fence() v4: Remove tie-in w/ dma-buf.. after discussion w/ danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problematic. v5: [ Maarten Lankhorst ] Upd

[RFC PATCH] fence: dma-buf cross-device synchronization (v12)

2013-07-29 Thread Maarten Lankhorst
in attach_fence() and get_fence() v4: Remove tie-in w/ dma-buf.. after discussion w/ danvet and mlankorst we decided that we need to be able to attach one fence to N dma-buf's, so using the list_head in dma-fence struct would be problematic. v5: [ Maarten Lankhorst ] Updated for dma-bikeshed-fence

[tip:core/locking] mutex: Move ww_mutex definitions to ww_mutex.h

2013-07-12 Thread tip-bot for Maarten Lankhorst
Commit-ID: 1b375dc30710180c4b88cc59caba6e3481ec5c8b Gitweb: http://git.kernel.org/tip/1b375dc30710180c4b88cc59caba6e3481ec5c8b Author: Maarten Lankhorst AuthorDate: Fri, 5 Jul 2013 09:29:32 +0200 Committer: Ingo Molnar CommitDate: Fri, 12 Jul 2013 12:07:46 +0200 mutex: Move ww_mutex

[tip:core/locking] mutex: Move ww_mutex definitions to ww_mutex.h

2013-07-12 Thread tip-bot for Maarten Lankhorst
Commit-ID: 1b375dc30710180c4b88cc59caba6e3481ec5c8b Gitweb: http://git.kernel.org/tip/1b375dc30710180c4b88cc59caba6e3481ec5c8b Author: Maarten Lankhorst maarten.lankho...@canonical.com AuthorDate: Fri, 5 Jul 2013 09:29:32 +0200 Committer: Ingo Molnar mi...@kernel.org CommitDate: Fri, 12

[PATCH] alx: fix lockdep annotation

2013-07-11 Thread Maarten Lankhorst
Move spin_lock_init to be called before the spinlocks are used, preventing a lockdep splat. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c index 418de8b..d30085c 100644 --- a/drivers/net/ethernet/atheros/alx

[PATCH] alx: fix lockdep annotation

2013-07-11 Thread Maarten Lankhorst
Move spin_lock_init to be called before the spinlocks are used, preventing a lockdep splat. Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- diff --git a/drivers/net/ethernet/atheros/alx/main.c b/drivers/net/ethernet/atheros/alx/main.c index 418de8b..d30085c 100644

[REGRESSION] "UEFI: Don't pass boot services regions to SetVirtualAddressMap()" breaks macbook efi boot

2013-07-10 Thread Maarten Lankhorst
Hey, It seems that in the merge window my macbook pro stopped working at some point. I looked for suspicious efi related commits, and found that reverting commit 1acba98f810a14b1255e34bc620594f83de37e36 worked, letting my macbook pro boot succesfully. Is there anything I can do to help

[REGRESSION] UEFI: Don't pass boot services regions to SetVirtualAddressMap() breaks macbook efi boot

2013-07-10 Thread Maarten Lankhorst
Hey, It seems that in the merge window my macbook pro stopped working at some point. I looked for suspicious efi related commits, and found that reverting commit 1acba98f810a14b1255e34bc620594f83de37e36 worked, letting my macbook pro boot succesfully. Is there anything I can do to help

inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage with hcd_urb_list_lock

2013-07-06 Thread Maarten Lankhorst
I didn't even know I still had lockdep on. The following lockdep splat happened when I plugged in a usb bluetooth dongle, using the pre-rc1 3.11 kernel at HEAD b2c311075db = [ INFO: inconsistent lock state ] 3.10.0+ #106 Not tainted

inconsistent {IN-HARDIRQ-W} - {HARDIRQ-ON-W} usage with hcd_urb_list_lock

2013-07-06 Thread Maarten Lankhorst
I didn't even know I still had lockdep on. The following lockdep splat happened when I plugged in a usb bluetooth dongle, using the pre-rc1 3.11 kernel at HEAD b2c311075db = [ INFO: inconsistent lock state ] 3.10.0+ #106 Not tainted

[PATCH] mutex: move ww_mutex definitions to ww_mutex.h

2013-07-05 Thread Maarten Lankhorst
Op 05-07-13 08:23, Ingo Molnar schreef: > * Maarten Lankhorst wrote: > >> Hey, >> >> Op 03-07-13 02:54, Linus Torvalds schreef: >>> On Mon, Jul 1, 2013 at 1:22 AM, Ingo Molnar wrote: >>>> Please pull the latest core-mutexes-for-linus git tree from: &g

[PATCH] mutex: move ww_mutex definitions to ww_mutex.h

2013-07-05 Thread Maarten Lankhorst
Op 05-07-13 08:23, Ingo Molnar schreef: * Maarten Lankhorst maarten.lankho...@canonical.com wrote: Hey, Op 03-07-13 02:54, Linus Torvalds schreef: On Mon, Jul 1, 2013 at 1:22 AM, Ingo Molnar mi...@kernel.org wrote: Please pull the latest core-mutexes-for-linus git tree from: git

Re: [GIT PULL] core/mutexes changes for v3.11: W/W mutex support

2013-07-03 Thread Maarten Lankhorst
Hey, Op 03-07-13 02:54, Linus Torvalds schreef: > On Mon, Jul 1, 2013 at 1:22 AM, Ingo Molnar wrote: >> Please pull the latest core-mutexes-for-linus git tree from: >> >>git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git >> core-mutexes-for-linus >> >>HEAD:

Re: [GIT PULL] core/mutexes changes for v3.11: W/W mutex support

2013-07-03 Thread Maarten Lankhorst
Hey, Op 03-07-13 02:54, Linus Torvalds schreef: On Mon, Jul 1, 2013 at 1:22 AM, Ingo Molnar mi...@kernel.org wrote: Please pull the latest core-mutexes-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-mutexes-for-linus HEAD:

Re: [PATCH v2] mutex: do not unnecessarily deal with waiters

2013-06-29 Thread Maarten Lankhorst
r small amounts of users (10-100), were the short and > compute workloads had a +19.36% and +%15.76% in jobs per minute. > > Also change some break statements to 'goto slowpath', which IMO makes a > little more intuitive to read. Nice turquoise bikeshed you built there. ;-) Acked-by: Maarten

Re: [PATCH v2] mutex: do not unnecessarily deal with waiters

2013-06-29 Thread Maarten Lankhorst
workloads had a +19.36% and +%15.76% in jobs per minute. Also change some break statements to 'goto slowpath', which IMO makes a little more intuitive to read. Nice turquoise bikeshed you built there. ;-) Acked-by: Maarten Lankhorst maarten.lankho...@canonical.com Signed-off-by: Davidlohr Bueso

Re: [PATCH] mutex: do not unnecessarily deal with waiters

2013-06-27 Thread Maarten Lankhorst
Op 28-06-13 03:32, Davidlohr Bueso schreef: > On Thu, 2013-06-27 at 11:00 +0200, Ingo Molnar wrote: > [...] >> So I tried this out yesterday, but it interacted with the Wait/Wound >> patches in tip:core/mutexes. >> >> Maarten Lankhorst pointed out that i

Re: [PATCH] mutex: do not unnecessarily deal with waiters

2013-06-27 Thread Maarten Lankhorst
Op 28-06-13 03:32, Davidlohr Bueso schreef: On Thu, 2013-06-27 at 11:00 +0200, Ingo Molnar wrote: [...] So I tried this out yesterday, but it interacted with the Wait/Wound patches in tip:core/mutexes. Maarten Lankhorst pointed out that if this patch is applied on top of the WW patches

[tip:core/mutexes] locking-selftests: Handle unexpected failures more strictly

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 166989e366ffa66108b2f37b870e66b85b2185ad Gitweb: http://git.kernel.org/tip/166989e366ffa66108b2f37b870e66b85b2185ad Author: Maarten Lankhorst AuthorDate: Thu, 20 Jun 2013 13:31:51 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:59 +0200 locking-selftests

[tip:core/mutexes] mutex: Add more w/ w tests to test EDEADLK path handling

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: f3cf139efa4bc0fe4f032af6ca3e49e38a5d9ae5 Gitweb: http://git.kernel.org/tip/f3cf139efa4bc0fe4f032af6ca3e49e38a5d9ae5 Author: Maarten Lankhorst AuthorDate: Thu, 20 Jun 2013 13:31:42 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:58 +0200 mutex: Add more w/w

[tip:core/mutexes] mutex: Add support for wound/wait style locks

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 040a0a37100563754bb1fee6ff6427420bcfa609 Gitweb: http://git.kernel.org/tip/040a0a37100563754bb1fee6ff6427420bcfa609 Author: Maarten Lankhorst AuthorDate: Mon, 24 Jun 2013 10:30:04 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:56 +0200 mutex: Add support

[tip:core/mutexes] mutex: Add more tests to lib/ locking-selftest.c

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 2fe3d4b149ccebbb384062fbbe6634439f2bf120 Gitweb: http://git.kernel.org/tip/2fe3d4b149ccebbb384062fbbe6634439f2bf120 Author: Maarten Lankhorst AuthorDate: Thu, 20 Jun 2013 13:31:30 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:57 +0200 mutex: Add more tests

[tip:core/mutexes] mutex: Add w/w tests to lib/locking-selftest.c

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 1de994452f44005e4b1f5c6c77eae4a26f86d484 Gitweb: http://git.kernel.org/tip/1de994452f44005e4b1f5c6c77eae4a26f86d484 Author: Maarten Lankhorst AuthorDate: Thu, 20 Jun 2013 13:31:24 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:57 +0200 mutex: Add w/w tests

[tip:core/mutexes] arch: Make __mutex_fastpath_lock_retval return whether fastpath succeeded or not

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: a41b56efa70e060f650aeb54740aaf52044a1ead Gitweb: http://git.kernel.org/tip/a41b56efa70e060f650aeb54740aaf52044a1ead Author: Maarten Lankhorst AuthorDate: Thu, 20 Jun 2013 13:31:05 +0200 Committer: Ingo Molnar CommitDate: Wed, 26 Jun 2013 12:10:55 +0200 arch: Make

[tip:core/mutexes] mutex: Add more tests to lib/ locking-selftest.c

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 2fe3d4b149ccebbb384062fbbe6634439f2bf120 Gitweb: http://git.kernel.org/tip/2fe3d4b149ccebbb384062fbbe6634439f2bf120 Author: Maarten Lankhorst maarten.lankho...@canonical.com AuthorDate: Thu, 20 Jun 2013 13:31:30 +0200 Committer: Ingo Molnar mi...@kernel.org CommitDate: Wed, 26

[tip:core/mutexes] mutex: Add w/w tests to lib/locking-selftest.c

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 1de994452f44005e4b1f5c6c77eae4a26f86d484 Gitweb: http://git.kernel.org/tip/1de994452f44005e4b1f5c6c77eae4a26f86d484 Author: Maarten Lankhorst maarten.lankho...@canonical.com AuthorDate: Thu, 20 Jun 2013 13:31:24 +0200 Committer: Ingo Molnar mi...@kernel.org CommitDate: Wed, 26

[tip:core/mutexes] arch: Make __mutex_fastpath_lock_retval return whether fastpath succeeded or not

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: a41b56efa70e060f650aeb54740aaf52044a1ead Gitweb: http://git.kernel.org/tip/a41b56efa70e060f650aeb54740aaf52044a1ead Author: Maarten Lankhorst maarten.lankho...@canonical.com AuthorDate: Thu, 20 Jun 2013 13:31:05 +0200 Committer: Ingo Molnar mi...@kernel.org CommitDate: Wed, 26

[tip:core/mutexes] mutex: Add support for wound/wait style locks

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 040a0a37100563754bb1fee6ff6427420bcfa609 Gitweb: http://git.kernel.org/tip/040a0a37100563754bb1fee6ff6427420bcfa609 Author: Maarten Lankhorst maarten.lankho...@canonical.com AuthorDate: Mon, 24 Jun 2013 10:30:04 +0200 Committer: Ingo Molnar mi...@kernel.org CommitDate: Wed, 26

[tip:core/mutexes] mutex: Add more w/ w tests to test EDEADLK path handling

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: f3cf139efa4bc0fe4f032af6ca3e49e38a5d9ae5 Gitweb: http://git.kernel.org/tip/f3cf139efa4bc0fe4f032af6ca3e49e38a5d9ae5 Author: Maarten Lankhorst maarten.lankho...@canonical.com AuthorDate: Thu, 20 Jun 2013 13:31:42 +0200 Committer: Ingo Molnar mi...@kernel.org CommitDate: Wed, 26

[tip:core/mutexes] locking-selftests: Handle unexpected failures more strictly

2013-06-26 Thread tip-bot for Maarten Lankhorst
Commit-ID: 166989e366ffa66108b2f37b870e66b85b2185ad Gitweb: http://git.kernel.org/tip/166989e366ffa66108b2f37b870e66b85b2185ad Author: Maarten Lankhorst maarten.lankho...@canonical.com AuthorDate: Thu, 20 Jun 2013 13:31:51 +0200 Committer: Ingo Molnar mi...@kernel.org CommitDate: Wed, 26

[PATCH v6 2/7] mutex: add support for wound/wait style locks

2013-06-24 Thread Maarten Lankhorst
Op 20-06-13 14:23, Ingo Molnar schreef: > * Maarten Lankhorst wrote: > >> Well they've helped me with some of the changes and contributed some >> code and/or fixes, but if acked-by is preferred I'll use that.. > Such contributions can be credited in the changelog, and/or

[PATCH v6 2/7] mutex: add support for wound/wait style locks

2013-06-24 Thread Maarten Lankhorst
Op 20-06-13 14:23, Ingo Molnar schreef: * Maarten Lankhorst maarten.lankho...@canonical.com wrote: Well they've helped me with some of the changes and contributed some code and/or fixes, but if acked-by is preferred I'll use that.. Such contributions can be credited in the changelog

Re: [PATCH v5 2/7] mutex: add support for wound/wait style locks, v5

2013-06-20 Thread Maarten Lankhorst
Op 20-06-13 13:55, Ingo Molnar schreef: > * Maarten Lankhorst wrote: > >> Changes since RFC patch v1: >> - Updated to use atomic_long instead of atomic, since the reservation_id >> was a long. >> - added mutex_reserve_lock_slow and mutex_reserv

[PATCH v5 4/7] mutex: Add ww tests to lib/locking-selftest.c. v5

2013-06-20 Thread Maarten Lankhorst
for locking after ww_acquire_done has been called. - Added a test for unbalance for ctx->acquired dropping below zero. - Added a test for unlocked ww_mutex with ctx != NULL. Signed-off-by: Maarten Lankhorst --- lib/locking-selftest.c | 400 ++-- 1 f

[PATCH v5 7/7] locking-selftests: handle unexpected failures more strictly

2013-06-20 Thread Maarten Lankhorst
When CONFIG_PROVE_LOCKING is not enabled, more tests are expected to pass unexpectedly, but there no tests that should start to fail that pass with CONFIG_PROVE_LOCKING enabled. Signed-off-by: Maarten Lankhorst --- lib/locking-selftest.c |8 +--- 1 file changed, 5 insertions(+), 3

[PATCH v5 2/7] mutex: add support for wound/wait style locks, v5

2013-06-20 Thread Maarten Lankhorst
*, normal functions can be used. Inline versions still exist for extra debugging. - Cleanup unneeded memory barriers, add comment to the remaining smp_mb(). Signed-off-by: Maarten Lankhorst Signed-off-by: Daniel Vetter Signed-off-by: Rob Clark --- Documentation/ww-mutex-design.txt | 343

[PATCH v5 6/7] mutex: add more ww tests to test EDEADLK path handling

2013-06-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- lib/locking-selftest.c | 264 +++- 1 file changed, 261 insertions(+), 3 deletions(-) diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c index 37faefd..d554f3f 100644 --- a/lib/locking-selftest.c +++ b

[PATCH v5 3/7] mutex: w/w mutex slowpath debugging

2013-06-20 Thread Maarten Lankhorst
correctly. (mlankhorst) v6: Do not inject -EDEADLK when ctx->acquired == 0, because the _slow paths are merged now. (mlankhorst) Cc: Steven Rostedt Signed-off-by: Daniel Vetter Signed-off-by: Maarten Lankhorst --- include/linux/mutex.h |8 kernel/mutex.c|

[PATCH v5 5/7] mutex: add more tests to lib/locking-selftest.c

2013-06-20 Thread Maarten Lankhorst
None of the ww_mutex codepaths should be taken in the 'normal' mutex calls. The easiest way to verify this is by using the normal mutex calls, and making sure o.ctx is unmodified. Signed-off-by: Maarten Lankhorst --- lib/locking-selftest.c | 62

[PATCH v5 0/7] add mutex wait/wound/style style locks

2013-06-20 Thread Maarten Lankhorst
Vetter (1): mutex: w/w mutex slowpath debugging Maarten Lankhorst (6): arch: make __mutex_fastpath_lock_retval return whether fastpath succeeded or not. mutex: add support for wound/wait style locks, v5 mutex: Add ww tests to lib/locking-selftest.c. v5 mutex: add more

[PATCH v5 1/7] arch: make __mutex_fastpath_lock_retval return whether fastpath succeeded or not.

2013-06-20 Thread Maarten Lankhorst
was previously used. Changes since v1, pointed out by Francesco Lavra: - fix a small comment issue in mutex_32.h - fix the __mutex_fastpath_lock_retval macro for mutex-null.h Signed-off-by: Maarten Lankhorst --- arch/ia64/include/asm/mutex.h| 10 -- arch/powerpc/include/asm/mutex.h

[PATCH v5 0/7] add mutex wait/wound/style style locks

2013-06-20 Thread Maarten Lankhorst
Vetter (1): mutex: w/w mutex slowpath debugging Maarten Lankhorst (6): arch: make __mutex_fastpath_lock_retval return whether fastpath succeeded or not. mutex: add support for wound/wait style locks, v5 mutex: Add ww tests to lib/locking-selftest.c. v5 mutex: add more

[PATCH v5 1/7] arch: make __mutex_fastpath_lock_retval return whether fastpath succeeded or not.

2013-06-20 Thread Maarten Lankhorst
was previously used. Changes since v1, pointed out by Francesco Lavra: - fix a small comment issue in mutex_32.h - fix the __mutex_fastpath_lock_retval macro for mutex-null.h Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- arch/ia64/include/asm/mutex.h| 10

[PATCH v5 7/7] locking-selftests: handle unexpected failures more strictly

2013-06-20 Thread Maarten Lankhorst
When CONFIG_PROVE_LOCKING is not enabled, more tests are expected to pass unexpectedly, but there no tests that should start to fail that pass with CONFIG_PROVE_LOCKING enabled. Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- lib/locking-selftest.c |8 +--- 1 file

[PATCH v5 2/7] mutex: add support for wound/wait style locks, v5

2013-06-20 Thread Maarten Lankhorst
*, normal functions can be used. Inline versions still exist for extra debugging. - Cleanup unneeded memory barriers, add comment to the remaining smp_mb(). Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Rob

[PATCH v5 6/7] mutex: add more ww tests to test EDEADLK path handling

2013-06-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- lib/locking-selftest.c | 264 +++- 1 file changed, 261 insertions(+), 3 deletions(-) diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c index 37faefd..d554f3f 100644

[PATCH v5 3/7] mutex: w/w mutex slowpath debugging

2013-06-20 Thread Maarten Lankhorst
definition to work correctly. (mlankhorst) v6: Do not inject -EDEADLK when ctx-acquired == 0, because the _slow paths are merged now. (mlankhorst) Cc: Steven Rostedt rost...@goodmis.org Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Maarten Lankhorst maarten.lankho

[PATCH v5 5/7] mutex: add more tests to lib/locking-selftest.c

2013-06-20 Thread Maarten Lankhorst
None of the ww_mutex codepaths should be taken in the 'normal' mutex calls. The easiest way to verify this is by using the normal mutex calls, and making sure o.ctx is unmodified. Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- lib/locking-selftest.c | 62

[PATCH v5 4/7] mutex: Add ww tests to lib/locking-selftest.c. v5

2013-06-20 Thread Maarten Lankhorst
for locking after ww_acquire_done has been called. - Added a test for unbalance for ctx-acquired dropping below zero. - Added a test for unlocked ww_mutex with ctx != NULL. Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- lib/locking-selftest.c | 400

Re: [PATCH v5 2/7] mutex: add support for wound/wait style locks, v5

2013-06-20 Thread Maarten Lankhorst
Op 20-06-13 13:55, Ingo Molnar schreef: * Maarten Lankhorst maarten.lankho...@canonical.com wrote: Changes since RFC patch v1: - Updated to use atomic_long instead of atomic, since the reservation_id was a long. - added mutex_reserve_lock_slow and mutex_reserve_lock_intr_slow - removed

Re: [PATCH v4 0/4] add mutex wait/wound/style style locks

2013-06-12 Thread Maarten Lankhorst
Op 28-05-13 16:48, Maarten Lankhorst schreef: > Version 4 already? > > Small api changes since v3: > - Remove ww_mutex_unlock_single and ww_mutex_lock_single. > - Rename ww_mutex_trylock_single to ww_mutex_trylock. > - Remove separate implementations of ww_mutex_lock_slow*, no

Re: [PATCH v4 0/4] add mutex wait/wound/style style locks

2013-06-12 Thread Maarten Lankhorst
Op 28-05-13 16:48, Maarten Lankhorst schreef: Version 4 already? Small api changes since v3: - Remove ww_mutex_unlock_single and ww_mutex_lock_single. - Rename ww_mutex_trylock_single to ww_mutex_trylock. - Remove separate implementations of ww_mutex_lock_slow*, normal functions can

Re: [inconsistent HARDIRQ usage] >mode_config.idr_mutex at drm_mode_object_find()

2013-06-10 Thread Maarten Lankhorst
Op 10-06-13 03:55, Fengguang Wu schreef: > Maarten, > > Sorry for the delay! > > On Sun, Jun 09, 2013 at 08:58:44AM +0200, Maarten Lankhorst wrote: >> Hey, >> >> Op 06-06-13 09:28, Fengguang Wu schreef: >>> Hi Maarten, >>> >>> Than

Re: [inconsistent HARDIRQ usage] dev-mode_config.idr_mutex at drm_mode_object_find()

2013-06-10 Thread Maarten Lankhorst
Op 10-06-13 03:55, Fengguang Wu schreef: Maarten, Sorry for the delay! On Sun, Jun 09, 2013 at 08:58:44AM +0200, Maarten Lankhorst wrote: Hey, Op 06-06-13 09:28, Fengguang Wu schreef: Hi Maarten, Thanks for the patch! I'll queue it for the tests. snip I haven't heard back from you

Re: [vt_console_print/cirrus_dirty_update] WARNING: at kernel/mutex.c:858 mutex_trylock()

2013-06-09 Thread Maarten Lankhorst
Hey, Op 06-06-13 09:28, Fengguang Wu schreef: > Hi Maarten, > > Thanks for the patch! I'll queue it for the tests. > > I haven't heard back from you yet, did it fix all lockdep issues you were having? If so I'll get it queued. ~Maarten -- To unsubscribe from this list: send the line

Re: [vt_console_print/cirrus_dirty_update] WARNING: at kernel/mutex.c:858 mutex_trylock()

2013-06-09 Thread Maarten Lankhorst
Hey, Op 06-06-13 09:28, Fengguang Wu schreef: Hi Maarten, Thanks for the patch! I'll queue it for the tests. snip I haven't heard back from you yet, did it fix all lockdep issues you were having? If so I'll get it queued. ~Maarten -- To unsubscribe from this list: send the line unsubscribe

Re: [RFC][PATCH 1/2] dma-buf: add importer private data to attachment

2013-06-07 Thread Maarten Lankhorst
Op 07-06-13 04:32, 김승우 schreef: > Hello Maarten, > > On 2013년 06월 05일 22:23, Maarten Lankhorst wrote: >> Op 31-05-13 10:54, Seung-Woo Kim schreef: >>> dma-buf attachment has only exporter private data, but importer private data >>> can be useful for importer esp

Re: [RFC][PATCH 1/2] dma-buf: add importer private data to attachment

2013-06-07 Thread Maarten Lankhorst
Op 07-06-13 04:32, 김승우 schreef: Hello Maarten, On 2013년 06월 05일 22:23, Maarten Lankhorst wrote: Op 31-05-13 10:54, Seung-Woo Kim schreef: dma-buf attachment has only exporter private data, but importer private data can be useful for importer especially to re-import the same dma-buf. To use

Re: [vt_console_print/cirrus_dirty_update] WARNING: at kernel/mutex.c:858 mutex_trylock()

2013-06-06 Thread Maarten Lankhorst
Hey, Op 06-06-13 03:35, Fengguang Wu schreef: > Greetings, > > I got the below dmesg and the first bad commit is > > commit 3d71c6ed43d838e593538176a9a59debe228cfb0 > Author: Maarten Lankhorst > Date: Tue Apr 2 12:33:01 2013 +0200 > > drm/ttm: con

Re: [vt_console_print/cirrus_dirty_update] WARNING: at kernel/mutex.c:858 mutex_trylock()

2013-06-06 Thread Maarten Lankhorst
Hey, Op 06-06-13 03:35, Fengguang Wu schreef: Greetings, I got the below dmesg and the first bad commit is commit 3d71c6ed43d838e593538176a9a59debe228cfb0 Author: Maarten Lankhorst maarten.lankho...@canonical.com Date: Tue Apr 2 12:33:01 2013 +0200 drm/ttm: convert

Re: [RFC][PATCH 1/2] dma-buf: add importer private data to attachment

2013-06-05 Thread Maarten Lankhorst
Op 31-05-13 10:54, Seung-Woo Kim schreef: > dma-buf attachment has only exporter private data, but importer private data > can be useful for importer especially to re-import the same dma-buf. > To use importer private data in attachment of the device, the function to > search attachment in the

Re: [RFC][PATCH 1/2] dma-buf: add importer private data to attachment

2013-06-05 Thread Maarten Lankhorst
Op 31-05-13 10:54, Seung-Woo Kim schreef: dma-buf attachment has only exporter private data, but importer private data can be useful for importer especially to re-import the same dma-buf. To use importer private data in attachment of the device, the function to search attachment in the

Re: [PATCH v4 2/4] mutex: add support for wound/wait style locks, v5

2013-05-30 Thread Maarten Lankhorst
Op 29-05-13 12:33, Inki Dae schreef: > Hi, > > Just minor comments > > +Usage >> +- >> + >> +Three different ways to acquire locks within the same w/w class. Common >> +definitions for methods #1 and #2: >> + >> +static DEFINE_WW_CLASS(ww_class); >> + >> +struct obj { >> + struct

Re: [PATCH v4 2/4] mutex: add support for wound/wait style locks, v5

2013-05-30 Thread Maarten Lankhorst
Op 29-05-13 12:33, Inki Dae schreef: Hi, Just minor comments +Usage +- + +Three different ways to acquire locks within the same w/w class. Common +definitions for methods #1 and #2: + +static DEFINE_WW_CLASS(ww_class); + +struct obj { + struct ww_mutex lock; + /* obj

Re: [PATCH v4 3/4] mutex: Add ww tests to lib/locking-selftest.c. v4

2013-05-28 Thread Maarten Lankhorst
Op 28-05-13 21:18, Daniel Vetter schreef: > On Tue, May 28, 2013 at 04:48:45PM +0200, Maarten Lankhorst wrote: >> This stresses the lockdep code in some ways specifically useful to >> ww_mutexes. It adds checks for most of the common locking errors. >> >> Change

[PATCH v4 2/4] mutex: add support for wound/wait style locks, v5

2013-05-28 Thread Maarten Lankhorst
*, normal functions can be used. Inline versions still exist for extra debugging. - Cleanup unneeded memory barriers, add comment to the remaining smp_mb(). Signed-off-by: Maarten Lankhorst Signed-off-by: Daniel Vetter Signed-off-by: Rob Clark --- Documentation/ww-mutex-design.txt | 344

[PATCH v4 4/4] mutex: w/w mutex slowpath debugging

2013-05-28 Thread Maarten Lankhorst
correctly. (mlankhorst) v6: Do not inject -EDEADLK when ctx->acquired == 0, because the _slow paths are merged now. (mlankhorst) Cc: Steven Rostedt Signed-off-by: Daniel Vetter Signed-off-by: Maarten Lankhorst --- include/linux/mutex.h |8 kernel/mutex.c |

[PATCH v4 3/4] mutex: Add ww tests to lib/locking-selftest.c. v4

2013-05-28 Thread Maarten Lankhorst
. - Use macros for most of the code. Changes since v3: - Rework tests for the api changes. Signed-off-by: Maarten Lankhorst --- lib/locking-selftest.c | 405 ++-- 1 file changed, 386 insertions(+), 19 deletions(-) diff --git a/lib/locking-selftest.c

[PATCH v4 1/4] arch: make __mutex_fastpath_lock_retval return whether fastpath succeeded or not.

2013-05-28 Thread Maarten Lankhorst
was previously used. Changes since v1, pointed out by Francesco Lavra: - fix a small comment issue in mutex_32.h - fix the __mutex_fastpath_lock_retval macro for mutex-null.h Signed-off-by: Maarten Lankhorst --- arch/ia64/include/asm/mutex.h| 10 -- arch/powerpc/include/asm/mutex.h

[PATCH v4 0/4] add mutex wait/wound/style style locks

2013-05-28 Thread Maarten Lankhorst
debugging, and to annotate. - Cleanup unneeded memory barriers, add comment to the remaining smp_mb(). Thanks to Daniel Vetter, Rob Clark and Peter Zijlstra for their feedback. --- Daniel Vetter (1): mutex: w/w mutex slowpath debugging Maarten Lankhorst (3): arch: make

[PATCH v4 0/4] add mutex wait/wound/style style locks

2013-05-28 Thread Maarten Lankhorst
debugging, and to annotate. - Cleanup unneeded memory barriers, add comment to the remaining smp_mb(). Thanks to Daniel Vetter, Rob Clark and Peter Zijlstra for their feedback. --- Daniel Vetter (1): mutex: w/w mutex slowpath debugging Maarten Lankhorst (3): arch: make

[PATCH v4 1/4] arch: make __mutex_fastpath_lock_retval return whether fastpath succeeded or not.

2013-05-28 Thread Maarten Lankhorst
was previously used. Changes since v1, pointed out by Francesco Lavra: - fix a small comment issue in mutex_32.h - fix the __mutex_fastpath_lock_retval macro for mutex-null.h Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- arch/ia64/include/asm/mutex.h| 10

[PATCH v4 3/4] mutex: Add ww tests to lib/locking-selftest.c. v4

2013-05-28 Thread Maarten Lankhorst
. - Use macros for most of the code. Changes since v3: - Rework tests for the api changes. Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- lib/locking-selftest.c | 405 ++-- 1 file changed, 386 insertions(+), 19 deletions(-) diff

[PATCH v4 4/4] mutex: w/w mutex slowpath debugging

2013-05-28 Thread Maarten Lankhorst
definition to work correctly. (mlankhorst) v6: Do not inject -EDEADLK when ctx-acquired == 0, because the _slow paths are merged now. (mlankhorst) Cc: Steven Rostedt rost...@goodmis.org Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Maarten Lankhorst maarten.lankho

[PATCH v4 2/4] mutex: add support for wound/wait style locks, v5

2013-05-28 Thread Maarten Lankhorst
*, normal functions can be used. Inline versions still exist for extra debugging. - Cleanup unneeded memory barriers, add comment to the remaining smp_mb(). Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Rob

Re: [PATCH v4 3/4] mutex: Add ww tests to lib/locking-selftest.c. v4

2013-05-28 Thread Maarten Lankhorst
Op 28-05-13 21:18, Daniel Vetter schreef: On Tue, May 28, 2013 at 04:48:45PM +0200, Maarten Lankhorst wrote: This stresses the lockdep code in some ways specifically useful to ww_mutexes. It adds checks for most of the common locking errors. Changes since v1: - Add tests to verify

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Maarten Lankhorst
Op 27-05-13 13:15, Peter Zijlstra schreef: > On Mon, May 27, 2013 at 12:52:00PM +0200, Maarten Lankhorst wrote: >> The reason ttm needed it was because there was another lock that interacted >> with the ctx lock in a weird way. The ww lock it was using was inverted with >>

Re: [PATCH v3 2/3] mutex: add support for wound/wait style locks, v3

2013-05-27 Thread Maarten Lankhorst
Op 27-05-13 12:24, Peter Zijlstra schreef: > On Mon, May 27, 2013 at 12:01:50PM +0200, Maarten Lankhorst wrote: >>> Again, early.. monday.. would a trylock, even if successful still need >>> the ctx? >> No ctx for trylock is supported. You can still do a trylock

<    3   4   5   6   7   8   9   10   11   >