RE: [PATCH 1/2] platform/chrome: cros_ec_typec: Skip port partner check in configure_mux()

Hi Prashant, > -Original Message- > From: Prashant Malani > Sent: Friday, February 05, 2021 12:07 PM > To: Mani, Rajmohan > Cc: Benson Leung ; Enric Balletbo i Serra > ; Guenter Roeck ; > Linux Kernel Mailing List ; Heikki Krogerus > > Subject: Re:

RE: [PATCH 0/2] Add support for Type-C mux events without port partners

Hi Benson, > Subject: Re: [PATCH 0/2] Add support for Type-C mux events without port > partners > > Hi Rajmohan, > > On Fri, 5 Feb 2021 11:51:11 -0800, Rajmohan Mani wrote: > > There are cases, where support for Type-C mux events is needed, that > > does not have port partners. > > Enabling

RE: [PATCH v2 1/3] platform/x86: Add Intel Input Output Manager (IOM) driver

Hi Greg, > Subject: Re: [PATCH v2 1/3] platform/x86: Add Intel Input Output Manager > (IOM) driver > > On Fri, Aug 28, 2020 at 03:20:22PM +, Mani, Rajmohan wrote: > > Hi Greg, > > > > > Subject: Re: [PATCH v2 1/3] platform/x86: Add Intel Input Output

RE: [PATCH v2 1/3] platform/x86: Add Intel Input Output Manager (IOM) driver

> Subject: Re: [PATCH v2 1/3] platform/x86: Add Intel Input Output Manager > (IOM) driver > > On Fri, Aug 28, 2020 at 12:03:35PM +0200, Greg Kroah-Hartman wrote: > > Handle the situation today, if, in the future, someone else > > needs/wants this, _then_ work on splitting it out into separate > >

RE: [PATCH v2 1/3] platform/x86: Add Intel Input Output Manager (IOM) driver

Hi Greg, > Subject: Re: [PATCH v2 1/3] platform/x86: Add Intel Input Output Manager > (IOM) driver > > Hi Greg, > > On Fri, Aug 28, 2020 at 09:43:59AM +0200, Greg Kroah-Hartman wrote: > > I still find this crazy that a whole separate driver is created just > > to read a single 32bit value. > >

RE: [PATCH v2 1/3] platform/x86: Add Intel Input Output Manager (IOM) driver

Hi Prashant, ... > > > > + > > > > + reg = iom->regbar + IOM_PORT_STATUS_OFFSET + IOM_REG_LEN * > > > port; > > > > + > > > > + *status = ioread32(reg); > > > > > > Perhaps just inline reg within the parentheses? > > > > Kept this way to increase readability. Let me know if you feel

RE: [PATCH v2 1/3] platform/x86: Add Intel Input Output Manager (IOM) driver

Hi Prashant, Thanks for the quick review. > Subject: Re: [PATCH v2 1/3] platform/x86: Add Intel Input Output Manager > (IOM) driver > > Hi Rajmohan, > > On Fri, Aug 21, 2020 at 09:05:06PM -0700, Rajmohan Mani wrote: > > Input Output Manager (IOM) is part of the Tiger Lake SoC that > >

RE: [PATCH 1/2] platform/x86: Add Intel Input Output Manager (IOM) driver

Hi Greg, > Subject: Re: [PATCH 1/2] platform/x86: Add Intel Input Output Manager (IOM) > driver ... > > > > +struct intel_iom { > > > > + struct device *dev; > > > > + void __iomem *regbar; > > > > +}; > > > > + > > > > +static struct intel_iom iom_dev; > > > > > > Why just one?

RE: [PATCH 2/2] usb: typec: intel_pmc_mux: Check the port status before connect

Hi Greg, > -Original Message- > From: Greg Kroah-Hartman > Sent: Thursday, July 16, 2020 12:05 AM > To: Mani, Rajmohan > Cc: Darren Hart ; Andy Shevchenko > ; Mika Westerberg > ; Dmitry Torokhov > ; Lee Jones ; Ayman > Bagabas ; Masahiro Yamada > ; J

RE: [PATCH 1/2] platform/x86: Add Intel Input Output Manager (IOM) driver

Hi Greg, Thanks for the reviews. > -Original Message- > From: Greg Kroah-Hartman > Sent: Thursday, July 16, 2020 12:10 AM > To: Mani, Rajmohan > Cc: Darren Hart ; Andy Shevchenko > ; Mika Westerberg > ; Dmitry Torokhov > ; Lee Jones ; Ayman > Bagabas ; Masahi

RE: [RFC PATCH 19/22] thunderbolt: Add support for Time Management Unit

Hi Mika, > -Original Message- > From: Mika Westerberg [mailto:mika.westerb...@linux.intel.com] > Sent: Tuesday, October 01, 2019 4:38 AM > To: linux-...@vger.kernel.org > Cc: Andreas Noever ; Jamet, Michael > ; Mika Westerberg > ; Yehezkel Bernat > ; Mani, Rajmo

RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

Hi Sakari, [snip] > > > > > fail_stop_pipeline: > > > > > @@ -543,6 +546,8 @@ static void ipu3_vb2_stop_streaming(struct > > > > vb2_queue *vq) > > > > > dev_err(>pci_dev->dev, > > > > > "failed to stop subdev streaming\n"); > > > > > > > > > > +

RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

Hi Sakari, > Subject: Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream > on/off operations > > Hi Raj, > > On Wed, Jan 30, 2019 at 05:17:15PM +0000, Mani, Rajmohan wrote: > > Hi Sakari, > > > > > -Original Message- >

RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

Hi Sakari, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Wednesday, January 30, 2019 12:59 AM > To: Mani, Rajmohan > Cc: Mauro Carvalho Chehab ; Greg Kroah-Hartman > ; linux-me...@vger.kernel.org; > de...@driverdev.osu

RE: [PATCH v2 0/2] Add a property in at24.c

Hi Bartosz, > -Original Message- > From: Yeh, Andy > Sent: Tuesday, June 26, 2018 9:21 AM > To: Andy Shevchenko ; Bartosz > Golaszewski > Cc: Chiang, AlanX ; linux-i2c i...@vger.kernel.org>; Sakari Ailus ; Mani, > Rajmohan ; Andy Shevchenko > ; Rob Herr

RE: [PATCH v2 0/2] Add a property in at24.c

Hi Bartosz, > -Original Message- > From: Yeh, Andy > Sent: Tuesday, June 26, 2018 9:21 AM > To: Andy Shevchenko ; Bartosz > Golaszewski > Cc: Chiang, AlanX ; linux-i2c i...@vger.kernel.org>; Sakari Ailus ; Mani, > Rajmohan ; Andy Shevchenko > ; Rob Herr

RE: [PATCH v6 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Rafael, > -Original Message- > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] > Sent: Tuesday, October 03, 2017 4:44 AM > To: Sakari Ailus <sakari.ai...@iki.fi> > Cc: Mani, Rajmohan <rajmohan.m...@intel.com>; linux- > ker...@vger.kernel.org; lin

RE: [PATCH v6 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Rafael, > -Original Message- > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] > Sent: Tuesday, October 03, 2017 4:44 AM > To: Sakari Ailus > Cc: Mani, Rajmohan ; linux- > ker...@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a...@vger.kernel.org; Lee

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

Hi Rafael, Andy, Just pinging to see if there are updates on ACPI / PMIC opregion patch... Thanks Raj > -Original Message- > From: Mani, Rajmohan > Sent: Thursday, September 07, 2017 5:46 PM > To: 'Rafael J. Wysocki' <raf...@kernel.org> > Cc: 'Rafael J. Wysocki

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

Hi Rafael, Andy, Just pinging to see if there are updates on ACPI / PMIC opregion patch... Thanks Raj > -Original Message- > From: Mani, Rajmohan > Sent: Thursday, September 07, 2017 5:46 PM > To: 'Rafael J. Wysocki' > Cc: 'Rafael J. Wysocki' ; 'Andy Shevchenko' &g

RE: [PATCH v6 3/3] eeprom: at24: enable runtime pm support

.org; linux- > ker...@vger.kernel.org; Mani, Rajmohan <rajmohan.m...@intel.com>; > Mohandass, Divagar <divagar.mohand...@intel.com> > Subject: [PATCH v6 3/3] eeprom: at24: enable runtime pm support > > Currently the device is kept in D0, there is an opportunity to save power by > enabl

RE: [PATCH v6 3/3] eeprom: at24: enable runtime pm support

.org; linux- > ker...@vger.kernel.org; Mani, Rajmohan ; > Mohandass, Divagar > Subject: [PATCH v6 3/3] eeprom: at24: enable runtime pm support > > Currently the device is kept in D0, there is an opportunity to save power by > enabling runtime pm. > > Device can be daisy chained from P

RE: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device property "size"

.org; linux- > ker...@vger.kernel.org; Mani, Rajmohan <rajmohan.m...@intel.com>; > Mohandass, Divagar <divagar.mohand...@intel.com> > Subject: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device > property "size" > > Obtain the size of the EEPROM chip fr

RE: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device property "size"

.org; linux- > ker...@vger.kernel.org; Mani, Rajmohan ; > Mohandass, Divagar > Subject: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device > property "size" > > Obtain the size of the EEPROM chip from DT if the "size" property is specified > for the device. &

RE: [PATCH v6 1/3] dt-bindings: add eeprom "size" property

.org; linux- > ker...@vger.kernel.org; Mani, Rajmohan <rajmohan.m...@intel.com>; > Mohandass, Divagar <divagar.mohand...@intel.com> > Subject: [PATCH v6 1/3] dt-bindings: add eeprom "size" property > > This adds eeprom "size" as optional property for i2c eep

RE: [PATCH v6 1/3] dt-bindings: add eeprom "size" property

.org; linux- > ker...@vger.kernel.org; Mani, Rajmohan ; > Mohandass, Divagar > Subject: [PATCH v6 1/3] dt-bindings: add eeprom "size" property > > This adds eeprom "size" as optional property for i2c eeproms. > The "size" property allows explicitly specifying the

RE: [PATCH v6 0/3] enable eeprom "size" property and runtime pm

vicet...@vger.kernel.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; Mani, Rajmohan <rajmohan.m...@intel.com> > Subject: Re: [PATCH v6 0/3] enable eeprom "size" property and runtime pm > > Hi Divagar, > > On Mon, Sep 04, 2017 at 03:58:45PM +0530, Divaga

RE: [PATCH v6 0/3] enable eeprom "size" property and runtime pm

.kernel.org; linux- > ker...@vger.kernel.org; Mani, Rajmohan > Subject: Re: [PATCH v6 0/3] enable eeprom "size" property and runtime pm > > Hi Divagar, > > On Mon, Sep 04, 2017 at 03:58:45PM +0530, Divagar Mohandass wrote: > > This series adds support for eeprom

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

Hi Rafael, > Subject: RE: [PATCH v5 0/3] TPS68470 PMIC drivers > > Hi Rafael, > > > >> > >> > This is the patch series for TPS68470 PMIC that works as a > > >> > >> > camera > > PMIC. > > >> > >> > > > >> > >> > The patch series provide the following 3 drivers, to help > > >> > >> > configure

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

Hi Rafael, > Subject: RE: [PATCH v5 0/3] TPS68470 PMIC drivers > > Hi Rafael, > > > >> > >> > This is the patch series for TPS68470 PMIC that works as a > > >> > >> > camera > > PMIC. > > >> > >> > > > >> > >> > The patch series provide the following 3 drivers, to help > > >> > >> > configure

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

Hi Rafael, > >> > >> > This is the patch series for TPS68470 PMIC that works as a camera > PMIC. > >> > >> > > >> > >> > The patch series provide the following 3 drivers, to help > >> > >> > configure the > >> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, > >> to be able to

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

Hi Rafael, > >> > >> > This is the patch series for TPS68470 PMIC that works as a camera > PMIC. > >> > >> > > >> > >> > The patch series provide the following 3 drivers, to help > >> > >> > configure the > >> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, > >> to be able to

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

Hi Andy, > > >> > This is the patch series for TPS68470 PMIC that works as a camera PMIC. > > >> > > > >> > The patch series provide the following 3 drivers, to help configure the > voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be > able to use the camera sensors

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

Hi Andy, > > >> > This is the patch series for TPS68470 PMIC that works as a camera PMIC. > > >> > > > >> > The patch series provide the following 3 drivers, to help configure the > voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be > able to use the camera sensors

RE: [PATCH v6 2/3] gpio: Add support for TPS68470 GPIOs

Hi Linus, > -Original Message- > From: Linus Walleij [mailto:linus.wall...@linaro.org] > Sent: Monday, August 14, 2017 6:39 AM > To: Mani, Rajmohan <rajmohan.m...@intel.com> > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; ACPI Devel

RE: [PATCH v6 2/3] gpio: Add support for TPS68470 GPIOs

Hi Linus, > -Original Message- > From: Linus Walleij [mailto:linus.wall...@linaro.org] > Sent: Monday, August 14, 2017 6:39 AM > To: Mani, Rajmohan > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; ACPI Devel > Maling List ; Lee Jones ; > Alexand

RE: [PATCH v6 0/3] TPS68470 PMIC drivers

these patches depend on the MFD patch (MFD_TPS68470 config option) to compile. Thanks Raj > -Original Message- > From: Mani, Rajmohan > Sent: Friday, July 28, 2017 5:30 PM > To: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a...@vger.kernel.org > Cc:

RE: [PATCH v6 0/3] TPS68470 PMIC drivers

these patches depend on the MFD patch (MFD_TPS68470 config option) to compile. Thanks Raj > -Original Message- > From: Mani, Rajmohan > Sent: Friday, July 28, 2017 5:30 PM > To: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a...@vger.kernel.org > Cc: Lee Jon

RE: [PATCH v6 1/3] mfd: Add new mfd device TPS68470

Thanks Lee. Sorry for the noise, as some keystrokes sent out the empty response earlier. Raj > -Original Message- > From: Mani, Rajmohan > Sent: Tuesday, August 08, 2017 11:58 AM > To: 'Lee Jones' <lee.jo...@linaro.org> > Cc: linux-kernel@vger.kernel.org; linux

RE: [PATCH v6 1/3] mfd: Add new mfd device TPS68470

Thanks Lee. Sorry for the noise, as some keystrokes sent out the empty response earlier. Raj > -Original Message- > From: Mani, Rajmohan > Sent: Tuesday, August 08, 2017 11:58 AM > To: 'Lee Jones' > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.ke

RE: [PATCH v6 1/3] mfd: Add new mfd device TPS68470

> -Original Message- > From: Lee Jones [mailto:lee.jo...@linaro.org] > Sent: Tuesday, August 08, 2017 12:40 AM > To: Mani, Rajmohan <rajmohan.m...@intel.com> > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a...@vger.kernel.org; L

RE: [PATCH v6 1/3] mfd: Add new mfd device TPS68470

> -Original Message- > From: Lee Jones [mailto:lee.jo...@linaro.org] > Sent: Tuesday, August 08, 2017 12:40 AM > To: Mani, Rajmohan > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a...@vger.kernel.org; Linus Walleij ; Alexandre > Courbo

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Lee, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Tue, 25 Jul 2017, Mani, Rajmohan wrote: > > > Hi Lee, > > > > > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > > > > > On Fri, 21 Jul 2017,

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Lee, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Tue, 25 Jul 2017, Mani, Rajmohan wrote: > > > Hi Lee, > > > > > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > > > > > On Fri, 21 Jul 2017,

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Andy, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Fri, Jul 28, 2017 at 3:30 AM, Mani, Rajmohan > <rajmohan.m...@intel.com> wrote: > >> On Wed, Jul 26, 2017 at 11:23 AM, Lee Jones <lee.jo...@linaro.org> > wrote: > >>

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Andy, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Fri, Jul 28, 2017 at 3:30 AM, Mani, Rajmohan > wrote: > >> On Wed, Jul 26, 2017 at 11:23 AM, Lee Jones > wrote: > >> > On Tue, 25 Jul 2017, Andy Shevchenko wrote: > >> &

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Lee, Andy, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Wed, Jul 26, 2017 at 11:23 AM, Lee Jones wrote: > > On Tue, 25 Jul 2017, Andy Shevchenko wrote: > >> On Tue, Jul 25, 2017 at 12:10 PM, Lee Jones wrote: > > >> I

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Lee, Andy, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Wed, Jul 26, 2017 at 11:23 AM, Lee Jones wrote: > > On Tue, 25 Jul 2017, Andy Shevchenko wrote: > >> On Tue, Jul 25, 2017 at 12:10 PM, Lee Jones wrote: > > >> I briefly checked few ->read() and ->write()

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Lee, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Fri, 21 Jul 2017, Mani, Rajmohan wrote: > > > On Wed, 19 Jul 2017, Rajmohan Mani wrote: > > > > > > > The TPS68470 device is an advanced power management unit that > > >

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Lee, > Subject: Re: [PATCH v4 1/3] mfd: Add new mfd device TPS68470 > > On Fri, 21 Jul 2017, Mani, Rajmohan wrote: > > > On Wed, 19 Jul 2017, Rajmohan Mani wrote: > > > > > > > The TPS68470 device is an advanced power management unit that > > >

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Lee, > > > + * This program is free software; you can redistribute it and/or > > > + * modify it under the terms of the GNU General Public License as > > > + * published by the Free Software Foundation version 2. > > > + * > > > + * This program is distributed "as is" WITHOUT ANY WARRANTY of

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Lee, > > > + * This program is free software; you can redistribute it and/or > > > + * modify it under the terms of the GNU General Public License as > > > + * published by the Free Software Foundation version 2. > > > + * > > > + * This program is distributed "as is" WITHOUT ANY WARRANTY of

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Lee, Thanks for the reviews. > -Original Message- > From: Lee Jones [mailto:lee.jo...@linaro.org] > Sent: Thursday, July 20, 2017 2:03 AM > To: Mani, Rajmohan <rajmohan.m...@intel.com> > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a..

RE: [PATCH v4 1/3] mfd: Add new mfd device TPS68470

Hi Lee, Thanks for the reviews. > -Original Message- > From: Lee Jones [mailto:lee.jo...@linaro.org] > Sent: Thursday, July 20, 2017 2:03 AM > To: Mani, Rajmohan > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a...@vger.kernel.org; Linus W

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Hi Lee, > > On Fri, 09 Jun 2017, Mani, Rajmohan wrote: > > > > > Hi Andy, > > > > > > > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote: > > > > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani > > > > <rajmoh

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Hi Lee, > > On Fri, 09 Jun 2017, Mani, Rajmohan wrote: > > > > > Hi Andy, > > > > > > > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote: > > > > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani > > > > wrote:

RE: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs

Hi Andy and all, Thanks for your patience. > > > > Main points (some I already told in an answer to Sakari's mail): > > 1. Consider 2 GPIO chips over 1. > > I am looking into this. > For the second GPIO chip, the call to acpi_attach_data() fails with AE_ALREADY_EXISTS, as below with 4.12 rc3

RE: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs

Hi Andy and all, Thanks for your patience. > > > > Main points (some I already told in an answer to Sakari's mail): > > 1. Consider 2 GPIO chips over 1. > > I am looking into this. > For the second GPIO chip, the call to acpi_attach_data() fails with AE_ALREADY_EXISTS, as below with 4.12 rc3

RE: [PATCH v3 2/3] gpio: Add support for TPS68470 GPIOs

Hi Linus, Thanks for your comments. > On Mon, Jun 12, 2017 at 11:26 AM, Rajmohan Mani > wrote: > > > This patch adds support for TPS68470 GPIOs. > > There are 7 GPIOs and a few sensor related GPIOs. > > These GPIOs can be requested and configured as appropriate. > > >

RE: [PATCH v3 2/3] gpio: Add support for TPS68470 GPIOs

Hi Linus, Thanks for your comments. > On Mon, Jun 12, 2017 at 11:26 AM, Rajmohan Mani > wrote: > > > This patch adds support for TPS68470 GPIOs. > > There are 7 GPIOs and a few sensor related GPIOs. > > These GPIOs can be requested and configured as appropriate. > > > > Signed-off-by: Rajmohan

RE: [PATCH v3 1/3] mfd: Add new mfd device TPS68470

Hi Andy, > On Mon, Jun 12, 2017 at 12:26 PM, Rajmohan Mani > wrote: > > The TPS68470 device is an advanced power management unit that powers a > > Compact Camera Module (CCM), generates clocks for image sensors, > > drives a dual LED for Flash and incorporates two LED

RE: [PATCH v3 1/3] mfd: Add new mfd device TPS68470

Hi Andy, > On Mon, Jun 12, 2017 at 12:26 PM, Rajmohan Mani > wrote: > > The TPS68470 device is an advanced power management unit that powers a > > Compact Camera Module (CCM), generates clocks for image sensors, > > drives a dual LED for Flash and incorporates two LED drivers for > > general

RE: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs

Hi Sakari, > Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs > > Hi Rajmohan and Andy, > > On Sun, Jun 11, 2017 at 03:49:18AM +, Mani, Rajmohan wrote: > > Hi Andy, > > > > Thanks for the reviews and patience. > > > > > >

RE: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs

Hi Sakari, > Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs > > Hi Rajmohan and Andy, > > On Sun, Jun 11, 2017 at 03:49:18AM +, Mani, Rajmohan wrote: > > Hi Andy, > > > > Thanks for the reviews and patience. > > > > > >

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Hi Lee, > Subject: Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 > > On Fri, 09 Jun 2017, Mani, Rajmohan wrote: > > > Hi Andy, > > > > > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote: > > > > On Tue, Jun 6, 2017 at 2:55 PM,

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Hi Lee, > Subject: Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 > > On Fri, 09 Jun 2017, Mani, Rajmohan wrote: > > > Hi Andy, > > > > > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote: > > > > On Tue, Jun 6

RE: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs

Hi Andy, Sakari, > Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs > > On Sun, Jun 11, 2017 at 7:50 PM, Sakari Ailus wrote: > > On Sun, Jun 11, 2017 at 04:40:16PM +0300, Andy Shevchenko wrote: > >> On Sun, Jun 11, 2017 at 2:30 PM, Sakari Ailus

RE: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs

Hi Andy, Sakari, > Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs > > On Sun, Jun 11, 2017 at 7:50 PM, Sakari Ailus wrote: > > On Sun, Jun 11, 2017 at 04:40:16PM +0300, Andy Shevchenko wrote: > >> On Sun, Jun 11, 2017 at 2:30 PM, Sakari Ailus wrote: > > >> > Again, I'm not

RE: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs

Hi Andy, > Subject: Re: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs > > On Sun, Jun 11, 2017 at 9:09 AM, Rajmohan Mani > wrote: > > This patch adds support for TPS68470 GPIOs. > > There are 7 GPIOs and a few sensor related GPIOs. > > These GPIOs can be requested

RE: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs

Hi Andy, > Subject: Re: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs > > On Sun, Jun 11, 2017 at 9:09 AM, Rajmohan Mani > wrote: > > This patch adds support for TPS68470 GPIOs. > > There are 7 GPIOs and a few sensor related GPIOs. > > These GPIOs can be requested and configured as

RE: [PATCH v2 1/3] mfd: Add new mfd device TPS68470

Hi Andy, Thanks for the reviews. > Subject: Re: [PATCH v2 1/3] mfd: Add new mfd device TPS68470 > > On Sun, Jun 11, 2017 at 9:09 AM, Rajmohan Mani > wrote: > > The TPS68470 device is an advanced power management unit that powers a > > Compact Camera Module (CCM),

RE: [PATCH v2 1/3] mfd: Add new mfd device TPS68470

Hi Andy, Thanks for the reviews. > Subject: Re: [PATCH v2 1/3] mfd: Add new mfd device TPS68470 > > On Sun, Jun 11, 2017 at 9:09 AM, Rajmohan Mani > wrote: > > The TPS68470 device is an advanced power management unit that powers a > > Compact Camera Module (CCM), generates clocks for image

RE: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs

Hi Linus, > Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs > > +static inline struct tps68470_gpio_data *to_gpio_data(struct > > +gpio_chip *gpiochp) { > > + return container_of(gpiochp, struct tps68470_gpio_data, gc); } > > Please use the data pointe inside gpio_chip. >

RE: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs

Hi Linus, > Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs > > +static inline struct tps68470_gpio_data *to_gpio_data(struct > > +gpio_chip *gpiochp) { > > + return container_of(gpiochp, struct tps68470_gpio_data, gc); } > > Please use the data pointe inside gpio_chip. >

RE: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs

Hi Linus, Thanks for the reviews. > -Original Message- > From: Linus Walleij [mailto:linus.wall...@linaro.org] > Sent: Friday, June 09, 2017 4:15 AM > To: Mani, Rajmohan <rajmohan.m...@intel.com> > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; ACP

RE: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs

Hi Linus, Thanks for the reviews. > -Original Message- > From: Linus Walleij [mailto:linus.wall...@linaro.org] > Sent: Friday, June 09, 2017 4:15 AM > To: Mani, Rajmohan > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; ACPI Devel > Maling List ; Lee J

RE: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs

Hi Andy, Thanks for the reviews and patience. > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani > wrote: > > This patch adds support for TPS68470 GPIOs. > > There are 7 GPIOs and a few sensor related GPIOs. > > These GPIOs can be requested and configured as

RE: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs

Hi Andy, Thanks for the reviews and patience. > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani > wrote: > > This patch adds support for TPS68470 GPIOs. > > There are 7 GPIOs and a few sensor related GPIOs. > > These GPIOs can be requested and configured as appropriate. > > Besides my below

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Sakari, Andy, > Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation > region driver > > On Wed, Jun 07, 2017 at 11:40:27PM +0300, Andy Shevchenko wrote: > > On Wed, Jun 7, 2017 at 11:10 PM, Sakari Ailus wrote: > > > On Wed, Jun 07, 2017 at 04:40:13PM

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Sakari, Andy, > Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation > region driver > > On Wed, Jun 07, 2017 at 11:40:27PM +0300, Andy Shevchenko wrote: > > On Wed, Jun 7, 2017 at 11:10 PM, Sakari Ailus wrote: > > > On Wed, Jun 07, 2017 at 04:40:13PM +0300, Andy

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Andy, Thanks for the reviews and patience. > Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation > region driver > > On Wed, Jun 7, 2017 at 3:07 PM, Sakari Ailus wrote: > > >> +static int ti_tps68470_pmic_get_power(struct regmap *regmap, int reg, >

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Andy, Thanks for the reviews and patience. > Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation > region driver > > On Wed, Jun 7, 2017 at 3:07 PM, Sakari Ailus wrote: > > >> +static int ti_tps68470_pmic_get_power(struct regmap *regmap, int reg, > >> +

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Sakari, Andy, > Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation > region driver > > On Wed, Jun 07, 2017 at 04:37:12PM +0300, Andy Shevchenko wrote: > > >> +static acpi_status ti_pmic_common_handler(u32 function, > > > +

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Sakari, Andy, > Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation > region driver > > On Wed, Jun 07, 2017 at 04:37:12PM +0300, Andy Shevchenko wrote: > > >> +static acpi_status ti_pmic_common_handler(u32 function, > > > +

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Sakari, Thanks for the reviews. > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Wednesday, June 07, 2017 5:08 AM > To: Mani, Rajmohan <rajmohan.m...@intel.com> > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- &

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Sakari, Thanks for the reviews. > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Wednesday, June 07, 2017 5:08 AM > To: Mani, Rajmohan > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a...@vger.kernel.org;

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Hans, > > > > As PMICs are typically linked to the kernel (vs. being modules), > > there's no issue with the module name. I would suppose few if any > > PMICs will be compiled as modules in general. > > Good point about the OpRegion driver usually being built-in, in my experience > it > MUST

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Hans, > > > > As PMICs are typically linked to the kernel (vs. being modules), > > there's no issue with the module name. I would suppose few if any > > PMICs will be compiled as modules in general. > > Good point about the OpRegion driver usually being built-in, in my experience > it > MUST

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Sakari, Andy, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Wednesday, June 07, 2017 2:13 PM > To: Andy Shevchenko <andy.shevche...@gmail.com> > Cc: Mani, Rajmohan <rajmohan.m...@intel.com>; Hans de Goede > <h

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Sakari, Andy, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Wednesday, June 07, 2017 2:13 PM > To: Andy Shevchenko > Cc: Mani, Rajmohan ; Hans de Goede > ; linux-kernel@vger.kernel.org; linux- > g...@vger.kernel.org; linux-a...

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Hans, > -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: Tuesday, June 06, 2017 8:22 AM > To: Andy Shevchenko <andy.shevche...@gmail.com>; Mani, Rajmohan > <rajmohan.m...@intel.com> > Cc: linux-kernel@vger.kernel.org; lin

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Hans, > -Original Message- > From: Hans de Goede [mailto:hdego...@redhat.com] > Sent: Tuesday, June 06, 2017 8:22 AM > To: Andy Shevchenko ; Mani, Rajmohan > > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a...@vger.kernel.org; Lee

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Andy, Thanks for the reviews and patience. > -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Tuesday, June 06, 2017 7:24 AM > To: Mani, Rajmohan <rajmohan.m...@intel.com>; Hans de Goede > <hdego...@redhat.com> > Cc

RE: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

Hi Andy, Thanks for the reviews and patience. > -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Tuesday, June 06, 2017 7:24 AM > To: Mani, Rajmohan ; Hans de Goede > > Cc: linux-kernel@vger.kernel.org; linux-g...@vger

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Hi Andy, > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote: > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani > wrote: > > > The TPS68470 device is an advanced power management unit that powers > > > a Compact Camera Module (CCM), generates clocks for

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Hi Andy, > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote: > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani > wrote: > > > The TPS68470 device is an advanced power management unit that powers > > > a Compact Camera Module (CCM), generates clocks for image sensors, > > > drives

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Hi Andy, Thanks for the reviews and patience. > -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Tuesday, June 06, 2017 6:00 AM > To: Mani, Rajmohan <rajmohan.m...@intel.com> > Cc: linux-kernel@vger.kernel.org; linux-g...@v

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Hi Andy, Thanks for the reviews and patience. > -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Tuesday, June 06, 2017 6:00 AM > To: Mani, Rajmohan > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a...@vg

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Hi Heikki, Thanks for the reviews and patience. > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: Tuesday, June 06, 2017 5:49 AM > To: Mani, Rajmohan <rajmohan.m...@intel.com> > Cc: linux-kernel@vger.kernel.org; linux

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Hi Heikki, Thanks for the reviews and patience. > -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: Tuesday, June 06, 2017 5:49 AM > To: Mani, Rajmohan > Cc: linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; linux- > a.

  1   2   >