Re: Is reading from /proc/self/smaps thread-safe?

2016-08-02 Thread Marcin Ślusarz
2016-07-31 8:22 GMT+02:00 Mateusz Guzik : > On Tue, Jul 26, 2016 at 02:44:48PM +0200, Marcin Ślusarz wrote: >> Hey >> >> I have a simple program that mmaps 8MB of anonymous memory, spawns 16 >> threads, reads /proc/self/smaps in each thread and looks up whether >&g

Is reading from /proc/self/smaps thread-safe?

2016-07-26 Thread Marcin Ślusarz
Hey I have a simple program that mmaps 8MB of anonymous memory, spawns 16 threads, reads /proc/self/smaps in each thread and looks up whether mapped address can be found in smaps. From time to time it's not there. Is this supposed to work reliably? My guess is that libc functions allocate memory

[tip:perf/core] perf tools: handle spaces in file names obtained from /proc/pid/maps

2016-02-09 Thread tip-bot for Marcin Ślusarz
Commit-ID: 89fee59b504f86925894fcc9ba79d5c933842f93 Gitweb: http://git.kernel.org/tip/89fee59b504f86925894fcc9ba79d5c933842f93 Author: Marcin Ślusarz AuthorDate: Tue, 19 Jan 2016 20:03:03 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 5 Feb 2016 09:39:56 -0300 perf tools

Re: [PATCH v2] perf tools: handle spaces in file names obtained from /proc/pid/maps

2016-02-04 Thread Marcin Ślusarz
On Tue, Jan 19, 2016 at 08:03:03PM +0100, Marcin Ślusarz wrote: > Steam frequently puts game binaries in folders with spaces. > > Note: "(deleted)" markers are now treated as part of the file name. > > It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c &

[PATCH] perf tools: handle spaces in file names obtained from /proc/pid/maps

2015-12-31 Thread Marcin Ślusarz
Steam frequently puts game binaries in folders with spaces. Note: "(deleted)" markers are now treated as part of the file name. It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c ("perf tools: Use sscanf for parsing /proc/pid/maps"). Signed-off-by: Marcin Ś

Re: cpu_hotplug vs oom_notify_list: possible circular locking dependency detected

2015-07-19 Thread Marcin Ślusarz
cely even in the face of concurrent CPU-hotplug operations. > > > > > > > > Furthermore, in recent kernels, invoking get_online_cpus() from an > > > > OOM > > > > notifier can result in deadlock. This commit therefore removes the > > > >

cpu_hotplug vs oom_notify_list: possible circular locking dependency detected

2015-07-12 Thread Marcin Ślusarz
[28954.363492] == [28954.363492] [ INFO: possible circular locking dependency detected ] [28954.363494] 4.1.2 #56 Not tainted [28954.363494] --- [28954.363495] pm-suspend/16647 is trying to acqui

Re: [PATCH] fence: dma-buf cross-device synchronization (v13)

2013-08-15 Thread Marcin Ślusarz
2013/8/15 Maarten Lankhorst : > A fence can be attached to a buffer which is being filled or consumed > by hw, to allow userspace to pass the buffer without waiting to another > device. For example, userspace can call page_flip ioctl to display the > next frame of graphics after kicking the GPU bu

Re: [PATCH] logo: move declarations of logos to linux_logo.h

2007-12-13 Thread Marcin Ślusarz
On Thu, Dec 13, 2007 at 02:31:11AM -0800, Andrew Morton wrote: > On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Ślusarz <[EMAIL PROTECTED]> wrote: > > > logo: move declarations of logos to linux_logo.h > > > > there was a mismatch between externs in logo.c and code gener

Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' symbol

2007-12-12 Thread Marcin Ślusarz
On Tue, Dec 11, 2007 at 09:50:32PM -0500, Dave Jones wrote: > On Tue, Dec 11, 2007 at 04:57:00PM -0800, Andrew Morton wrote: > > > > --- a/drivers/video/console/fbcon.c > > > +++ b/drivers/video/console/fbcon.c > > > @@ -2795,7 +2795,7 @@ static int fbcon_scrolldelta(struct vc_data *vc, > int l

[PATCH] logo: move declarations of logos to linux_logo.h

2007-12-09 Thread Marcin Ślusarz
logo: move declarations of logos to linux_logo.h there was a mismatch between externs in logo.c and code generated by pnmtologo (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation) Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- drivers/video/logo/logo.c

[PATCH] fbcon: fix sparse warning about shadowing 'rotate' symbol

2007-12-09 Thread Marcin Ślusarz
fbcon: fix sparse warning about shadowing 'rotate' symbol Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- drivers/video/console/fbcon.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/console/fbcon.c b/drivers/video/conso

[PATCH] fbcon: fix sparse warning about shadowing 'p' symbol

2007-12-09 Thread Marcin Ślusarz
fbcon: fix sparse warning about shadowing 'p' symbol Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- drivers/video/console/fbcon.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon

[PATCH] vgacon: fix sparse warning about shadowing 'i' symbol

2007-12-09 Thread Marcin Ślusarz
vgacon: fix sparse warning about shadowing 'i' symbol Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- drivers/video/console/vgacon.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon

[PATCH] ehci-hcd: fix sparse warning about shadowing 'status' symbol

2007-12-09 Thread Marcin Ślusarz
ehci-hcd: fix sparse warning about shadowing 'status' symbol Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- drivers/usb/host/ehci-hcd.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd

[PATCH] usb/storage/initializers.c: fix signedness difference

2007-12-09 Thread Marcin Ślusarz
usb/storage/initializers.c: fix signedness difference Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- drivers/usb/storage/initializers.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/usb/storage/initializers.c b/drivers/usb/storage/initializers.c

[PATCH] usbdevfs_urb: __user annotation

2007-12-09 Thread Marcin Ślusarz
usbdevfs_urb: __user annotation Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- include/linux/usbdevice_fs.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/usbdevice_fs.h b/include/linux/usbdevice_fs.h index 8ca5a7f..17cb108 100644 --- a/i

[PATCH] asm-*/compat.h: fix typo in comment

2007-12-08 Thread Marcin Ślusarz
asm-*/compat.h: fix typo in comment Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- include/asm-ia64/compat.h|2 +- include/asm-mips/compat.h|2 +- include/asm-parisc/compat.h |2 +- include/asm-powerpc/compat.h |2 +- include/asm-s390/compat.h

[PATCH] sound/core/seq: move declarations of globally visible variables to proper headers

2007-12-08 Thread Marcin Ślusarz
sound/core/seq: move declarations of globally visible variables to proper headers Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- sound/core/seq/seq_clientmgr.c |2 -- sound/core/seq/seq_clientmgr.h |2 ++ sound/core/seq/seq_timer.c |7 --- sound/core/seq/seq_t

[PATCH] sound/core/memory.c: include sound/core.h

2007-12-08 Thread Marcin Ślusarz
sound/core/memory.c: include sound/core.h copy_to_user_fromio and copy_from_user_toio are declared in sound/core.h but sound/core/memory.c doesn't include it - fix it depends on: "[PATCH] sound/core.h: include sound/driver.h" Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED

[PATCH] sound/core.h: include sound/driver.h

2007-12-08 Thread Marcin Ślusarz
sound/core.h: include sound/driver.h include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h) Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- include/sound/core.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff -

[PATCH] info_oss: move prototype of snd_card_info_read_oss to info.h

2007-12-08 Thread Marcin Ślusarz
info_oss: move prototype of snd_card_info_read_oss to info.h Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- include/sound/info.h |2 ++ sound/core/info_oss.c |2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/sound/info.h b/include/sound/info.h

[PATCH] rawmidi: let sparse know what is going on _for real_

2007-12-08 Thread Marcin Ślusarz
rawmidi: let sparse know what is going on _for real_ snd_rawmidi_kernel_read1/write1 weren't annotated but used copy_to_user/copy_from_user when one of parameters (kernel) was equal to 0 remove it and add properly annotated parameter Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]>

[PATCH] pcm_lib: fix sparse warning about different signedness

2007-12-08 Thread Marcin Ślusarz
pcm_lib: fix sparse warning about different signedness Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- sound/core/pcm_lib.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index 653fb5c..f2c3cf3 100644 --- a/soun

[PATCH] pcm_lib: fix sparse warning about shadowing 'n' symbol

2007-12-08 Thread Marcin Ślusarz
pcm_lib: fix sparse warning about shadowing 'n' symbol Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- sound/core/pcm_lib.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index 806f1fb..653f

[PATCH] via82xx: minor optimization in snd_via82xx_free

2007-12-08 Thread Marcin Ślusarz
via82xx: minor optimization in snd_via82xx_free don't check X, when we just checked !X before goto Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- sound/pci/via82xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/pci/via82xx.c b/sound/pci/via8

[PATCH] pcm_native: fix sparse warning about shadowing 'state' symbol

2007-12-08 Thread Marcin Ślusarz
pcm_native: fix sparse warning about shadowing 'state' symbol Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- sound/core/pcm_native.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index

[PATCH] via82xx: fix some coding style issues

2007-12-06 Thread Marcin Ślusarz
fix trivial coding style issues found by checkpatch.pl: - assignments in if conditions - trailing whitespaces - lines longer then 80 characters (only a couple of them) - spaces instead of tabs - spaces after ! - C99 comments - other tiny changes Signed-off-by: Marcin Ślusarz <[EMAIL PROTEC

usbserial.ko/option.ko on 2.6.23: Unable to handle kernel paging request && inconsistent lock state

2007-10-29 Thread Marcin Ślusarz
Hi While fighting with Option Globesurfer ICON USB modem I got oops and lockdep warning: (on rmmod option usbserial, not reproducible) usbcore: deregistering interface driver option drivers/usb/serial/usb-serial.c: USB Serial deregistering driver GSM modem (1-port) option1 ttyUSB3: GSM modem (1-p

Re: [patch 0/3] [patch 0/3] genirq: Suppress resend of level interrupts

2007-08-14 Thread Marcin Ślusarz
2007/8/12, Thomas Gleixner <[EMAIL PROTECTED]>: > The delayed irq disable functionality introduced a bug due to > retriggering level type interrupts in case of the delayed disable. The > resulting problem was discussed and debugged here: > http://marc.info/?l=linux-kernel&m=118202978609968&w=2 > >

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-13 Thread Marcin Ślusarz
2007/8/10, Ingo Molnar <[EMAIL PROTECTED]>: > Index: linux/arch/i386/kernel/io_apic.c > === > --- linux.orig/arch/i386/kernel/io_apic.c > +++ linux/arch/i386/kernel/io_apic.c > @@ -735,7 +735,8 @@ void fastcall send_IPI_self(int vector

Re: [patch (testing)] Re: 2.6.20->2.6.21 - networking dies after random time

2007-08-10 Thread Marcin Ślusarz
2007/8/10, Jarek Poplawski <[EMAIL PROTECTED]>: > (..) > I think, there is this one possible for your testing yet?: > Subject: [patch] genirq: temporary fix for level-triggered IRQ resend > Date: Wed, 8 Aug 2007 13:00:37 +0200 I think I already tested this patch, but this thread is sooo big and I c

Re: 2.6.20->2.6.21 - networking dies after random time

2007-08-08 Thread Marcin Ślusarz
2007/8/7, Jarek Poplawski <[EMAIL PROTECTED]>: > And here is one more patch to test the same idea (chip->retrigger()). > Let's try i386 way! (I hope I will not be arrested for this...) > (Should be tested without any previous patches.) > > Jarek P. > > PS: as above > > --- > > diff -Nurp 2.6.22.1-/

Re: 2.6.20->2.6.21 - networking dies after random time

2007-08-08 Thread Marcin Ślusarz
2007/8/7, Jarek Poplawski <[EMAIL PROTECTED]>: > So, the let's try this idea yet: modified Ingo's "x86: activate > HARDIRQS_SW_RESEND" patch. > (Don't forget about make oldconfig before make.) > For testing only. > > Cheers, > Jarek P. > > PS: alas there was not even time for "compile checking"...

Re: 2.6.20->2.6.21 - networking dies after random time

2007-08-07 Thread Marcin Ślusarz
2007/8/6, Ingo Molnar <[EMAIL PROTECTED]>: > (..) > please try Jarek's second patch too - there was a missing unmask. > > Ingo > > --> > Subject: genirq: fix simple and fasteoi irq handlers > From: Jarek Poplawski <[EMAIL PROTECTED]> > > After the "genirq: do not mask interrupts

Re: [patch (take 2)] genirq: fix simple and fasteoi irq handlers

2007-08-06 Thread Marcin Ślusarz
2007/8/6, Ingo Molnar <[EMAIL PROTECTED]>: > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > Subject: genirq: fix simple and fasteoi irq handlers > > > > After the "genirq: do not mask interrupts by default" patch interrupts > > should be disabled not immediately upon request, but after they >

Re: [patch] genirq: fix simple and fasteoi irq handlers

2007-08-06 Thread Marcin Ślusarz
2007/8/3, Jarek Poplawski <[EMAIL PROTECTED]>: > Hi, > > I can't guarantee this is all needed to fix this bug, but I think > this patch is necessary here. > > Regards, > Jarek P. > > > > Subject: genirq: fix simple and fasteoi irq handlers > > After the "genirq: do not mask interrupts b

Re: 2.6.20->2.6.21 - networking dies after random time

2007-08-06 Thread Marcin Ślusarz
2007/7/31, Jarek Poplawski <[EMAIL PROTECTED]>: > Marcin, > > I see you're quite busy, but if after testing this next Ingo's patch > you are alive yet, maybe you could try one more "idea"? No patch this > time, but if you could try this after adding boot option "noirqdebug" > (I'd like to be sure i

Re: 2.6.20->2.6.21 - networking dies after random time

2007-08-06 Thread Marcin Ślusarz
2007/8/1, Ingo Molnar <[EMAIL PROTECTED]>: > ok, it wasnt supposed to be _that_ easy i guess :-) Can you please > (re-)confirm that the workaround below indeed fixes the hung card > problem? (after producing a single WARN_ON message into the syslog) yes, with this patch everything works fine end o

Re: [patch] genirq: fix simple and fasteoi irq handlers

2007-08-03 Thread Marcin Ślusarz
2007/8/3, Jarek Poplawski <[EMAIL PROTECTED]>: > On Fri, Aug 03, 2007 at 10:04:08AM +0200, Ingo Molnar wrote: > > > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > > > I can't guarantee this is all needed to fix this bug, but I think this > > > patch is necessary here. > > > > hmmm ... very in

Re: 2.6.20->2.6.21 - networking dies after random time

2007-08-01 Thread Marcin Ślusarz
2007/7/30, Ingo Molnar <[EMAIL PROTECTED]>: > (..) > does the patch below fix those timeouts? It tests the theory whether any > POST latency could expose this problem. > > Ingo > > Index: linux/drivers/net/lib8390.c > === > ---

Re: 2.6.20->2.6.21 - networking dies after random time

2007-07-30 Thread Marcin Ślusarz
2007/7/26, Ingo Molnar <[EMAIL PROTECTED]>: > (..) > yeah - i meant to cover both arches but forgot about x86_64 - updated > patch attached below. > > Ingo > > -> > Subject: x86: activate HARDIRQS_SW_RESEND > From: Ingo Molnar <[EMAIL PROTECTED]> > > activate the software-tr

Re: 2.6.20->2.6.21 - networking dies after random time

2007-07-26 Thread Marcin Ślusarz
2007/7/25, Thomas Gleixner <[EMAIL PROTECTED]>: (...) I've tested Jarek's patch, 2 Ingo's patches (2nd and 3rd) and Thomas' patch (one patch at time of course) - all of them fixed the problem, but the last one flooded my logs with "Skip resend for irq 17". All tests were done on 2.6.21.3. I wa

Re: 2.6.20->2.6.21 - networking dies after random time

2007-07-22 Thread Marcin Ślusarz
Ok, I've bisected this problem and found that this patch broke my NIC: 76d2160147f43f982dfe881404cfde9fd0a9da21 is first bad commit commit 76d2160147f43f982dfe881404cfde9fd0a9da21 Author: Ingo Molnar <[EMAIL PROTECTED]> Date: Fri Feb 16 01:28:24 2007 -0800 [PATCH] genirq: do not mask interr

Re: 2.6.20->2.6.21 - networking dies after random time

2007-06-22 Thread Marcin Ślusarz
2007/6/19, Jarek Poplawski <[EMAIL PROTECTED]>: On Mon, Jun 18, 2007 at 08:10:00AM -0700, Stephen Hemminger wrote: > On Mon, 18 Jun 2007 13:08:49 +0200 > Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > On 16-06-2007 23:35, Marcin .lusarz wrote: > > > hi > > > after upgrading kernel from 2.6.20 t

bttv on 2.6.21.3: possible circular locking dependency detected

2007-06-07 Thread Marcin Ślusarz
[ 170.012538] [ 170.012540] === [ 170.012545] [ INFO: possible circular locking dependency detected ] [ 170.012547] 2.6.21.3 #1 [ 170.012549] --- [ 170.012551] tvtime/6727 is trying to acq