Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Marco Felsch
On 23-09-12, Iuliana Prodan wrote: > On 9/12/2023 2:30 PM, Marco Felsch wrote: > > Hi Iuliana, > > > > On 23-09-12, Iuliana Prodan (OSS) wrote: > > > From: Iuliana Prodan > > > > > > Add the reserve-memory nodes used by DSP when the rpmsg > &g

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Marco Felsch
Hi Iuliana, On 23-09-12, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan > > Add the reserve-memory nodes used by DSP when the rpmsg > feature is enabled. > These can be later used in a dsp node, like: > dsp: dsp@3b6e8000 { > compatible = "fsl,imx8mp-dsp"; > reg = <0x3b6e8000 0x88

Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2

2021-03-19 Thread Marco Felsch
Hi Alistair, the patch looks quite good only a few notes inline. PS: It would be cool to have a log to previous patch versions. On 21-03-15 22:27, Alistair Francis wrote: ... > +&crypto { > + status = "disabled"; > +}; Why do you disable the crypto subsystem? > +&dma_apbh { > + statu

Re: [PATCH v2 0/4] enable flexspi support on imx8mp

2021-03-09 Thread Marco Felsch
Hi Heiko, On 21-03-09 06:31, Heiko Schocher wrote: > > This series enables support for the SPI NOR on the > imx8mp based phyboard-pollux-rdk board. > > Patches new in v2: > "spi: fspi: enable fspi driver for on imx8mp" > which adds own compatible entry for imx8mp > > and seperate in own patch t

Re: [PATCH v2 1/1] arm64: dts: imx8mm-nitrogen-r2: add ecspi2 support

2021-03-09 Thread Marco Felsch
+++ > 1 file changed, 20 insertions(+) Reviewed-by: Marco Felsch Regards, Marco

Re: [PATCH 1/1] arm64: dts: imx8mm-nitrogen-r2: add espi2 support

2021-03-08 Thread Marco Felsch
Hi Adrien, On 21-03-08 13:39, Adrien Grassein wrote: > Add the description for espi support. > > Signed-off-by: Adrien Grassein > Reviewed-by: Krzysztof Kozlowski > --- > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 22 +++ > 1 file changed, 22 insertions(+) > > diff --git

Re: [PATCH 2/2] arm64: imx8mp: imx8mp-phycore-som enable spi nor

2021-03-08 Thread Marco Felsch
On 21-03-08 08:52, Teresa Remmet wrote: > Hello Marco, > > Am Montag, den 08.03.2021, 09:40 +0100 schrieb Marco Felsch: > > On 21-03-08 07:40, Heiko Schocher wrote: > > > enable the mt25qu256aba spi nor on the imx8mp-phycore-som. > > > &g

Re: [PATCH 2/2] arm64: imx8mp: imx8mp-phycore-som enable spi nor

2021-03-08 Thread Marco Felsch
On 21-03-08 07:40, Heiko Schocher wrote: > enable the mt25qu256aba spi nor on the imx8mp-phycore-som. > > Signed-off-by: Heiko Schocher > --- > > .../dts/freescale/imx8mp-phycore-som.dtsi | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/free

Re: [PATCH 1/2] arm64: dts: imx8mp: add flexspi node

2021-03-08 Thread Marco Felsch
Hi Heiko, On 21-03-08 07:40, Heiko Schocher wrote: > add node for the flexspi modul on imx8mp. > > Signed-off-by: Heiko Schocher > > --- > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8

Re: [PATCH 2/2] arm64: imx8mp: imx8mp-phycore-som enable spi nor

2021-03-08 Thread Marco Felsch
Hi Teresa, Heiko, On 21-03-08 07:46, Teresa Remmet wrote: > Hello Heiko, > > first thanks for the patch :). > > Am Montag, den 08.03.2021, 07:40 +0100 schrieb Heiko Schocher: > > enable the mt25qu256aba spi nor on the imx8mp-phycore-som. > > > > Signed-off-by: Heiko Schocher > > --- > > > >

Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-05 Thread Marco Felsch
On 21-02-04 19:15, Oliver Graute wrote: > On 02/02/21, Marco Felsch wrote: > > Hi Oliver, > > > > On 21-02-02 18:35, Oliver Graute wrote: > > > Add support for the Solomon Goldentek Display Model: GKTW70SDAD1SD > > > to panel-simple. > > > >

Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-02 Thread Marco Felsch
Signed-off-by: Oliver Graute > Cc: Marco Felsch > Cc: Fabio Estevam > --- > > v3: > > - added flags > - added delay Thanks, did you test the changes? I just picked it from the datasheet. Regards, Marco

Re: [PATCH v2] drm/panel: simple: add SGD GKTW70SDAD1SD

2021-02-01 Thread Marco Felsch
CAP-GLD-RGB.pdf > > Signed-off-by: Oliver Graute > Cc: Marco Felsch > Cc: Fabio Estevam > --- > > v2: > > - changed bpc to 6 > - set max value of pixelclock > - increased hfront_porch and hback_porch > - dropped connector-type > > adding of bus_f

Re: [PATCH v5 2/3] arm64: dts: imx: Add i.mx8mm nitrogen8mm basic dts support

2021-01-28 Thread Marco Felsch
Hi Adrien, thanks for the patch. I've made only a few comments inline. On 21-01-18 12:15, Adrien Grassein wrote: > Tested with a basic Build Root configuration booting from sdcard. > > Signed-off-by: Adrien Grassein > Reviewed-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/freescale/Make

Re: [PATCH v2 0/6] Add Wacom I2C support to rM2

2021-01-22 Thread Marco Felsch
Hi Alistair, thanks for the patches. Before getting into the series please check all your commit subjects. Also please check that you do only one logical change per patch: e.g. adding DT-Support means: Add the dt-table and not more. I looking forward to your v2 :) Regards, Marco On 21-01-20 2

Re: [PATCH v2 3/6] touchscreen/wacom_i2c: Add support for distance and tilt x/y

2021-01-22 Thread Marco Felsch
Hi, thanks for the patch. Please align all your patch-subjects belonging to the driver to: "Input: wacom_i2c - ..." On 21-01-20 22:56, Alistair Francis wrote: > This is based on the out of tree rM2 driver. > > Signed-off-by: Alistair Francis > --- > drivers/input/touchscreen/wacom_i2c.c | 25 +

Re: [PATCH v2 2/6] input/touchscreen: Add device tree support to wacom_i2c

2021-01-22 Thread Marco Felsch
On 21-01-20 22:56, Alistair Francis wrote: > Allow the wacom-i2c device to be exposed via device tree. You did a lot more than exposing. > Signed-off-by: Alistair Francis > --- > .../input/touchscreen/wacom,wacom-i2c.yaml | 4 > drivers/input/touchscreen/wacom_i2c.c| 16

Re: [PATCH v2 1/6] devicetree/bindings: Initial commit of wacom, wacom-i2c

2021-01-22 Thread Marco Felsch
Hi, thnaks for the patch. On 21-01-20 22:56, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > .../input/touchscreen/wacom,wacom-i2c.yaml| 44 +++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + This should be splitted into two patches. Regards, Ma

Re: [PATCH v2 6/6] arch/arm: reMarkable2: Enable wacom_i2c

2021-01-22 Thread Marco Felsch
Hi, thanks for the patch. On 21-01-20 22:56, Alistair Francis wrote: > Enable the wacom_i2c touchscreen for the reMarkable2. > > Signed-off-by: Alistair Francis > --- > arch/arm/boot/dts/imx7d-remarkable2.dts | 41 + > arch/arm/configs/imx_v6_v7_defconfig| 1 + Tho

[PATCH] net: phy: smsc: fix clk error handling

2021-01-11 Thread Marco Felsch
fclk in support") Suggested-by: Jakub Kicinski Signed-off-by: Marco Felsch --- drivers/net/phy/smsc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 0fc39ac5ca88..10722fed666d 100644 --- a/drivers/net/phy/smsc.c +

Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes

2020-12-10 Thread Marco Felsch
>reg_offset_x = EV_REGISTER_OFFSET_X; > reg_addr->reg_offset_y = EV_REGISTER_OFFSET_Y; > reg_addr->reg_num_x = NO_REGISTER; > reg_addr->reg_num_y = NO_REGISTER; > - reg_addr->reg_report_rate = NO_REGISTER; > break; Nit: Unrelated change. However the patch looks good, thanks. Acked-by: Marco Felsch Regards, Marco

Re: [PATCH net] net: phy: smsc: add missed clk_disable_unprepare in smsc_phy_probe()

2020-11-16 Thread Marco Felsch
On 20-11-14 11:45, Florian Fainelli wrote: > > > On 11/14/2020 11:26 AM, Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 19:23:59 +0800 Zhang Changzhong wrote: > >> Add the missing clk_disable_unprepare() before return from > >> smsc_phy_probe() in the error handling case. > >> > >> Fixes: bedd8d78

Re: [PATCH v2 2/2] ARM: dts: imx7-mba7: add default SPI-NOR flash partition layout

2020-11-02 Thread Marco Felsch
Hi Matthias, On 20-10-30 11:26, Matthias Schiffer wrote: > Add the partition layout also used by the bootloader. > > Signed-off-by: Matthias Schiffer > --- > arch/arm/boot/dts/imx7-mba7.dtsi | 32 > 1 file changed, 32 insertions(+) > > v2: no changes > > > di

Re: [PATCH v2 1/2] ARM: dts: imx7-tqma7: add SPI-NOR flash

2020-11-02 Thread Marco Felsch
Hi Matthias, On 20-10-30 11:26, Matthias Schiffer wrote: > The SPI-NOR flash on the SoM was missing from the device tree. > > Signed-off-by: Matthias Schiffer > --- > arch/arm/boot/dts/imx7-tqma7.dtsi | 30 ++ > 1 file changed, 30 insertions(+) > > v2: change node n

Re: [PATCH v1 3/3] ARM: dts: add Van der Laan LANMCU board

2020-10-15 Thread Marco Felsch
On 20-10-15 11:02, Oleksij Rempel wrote: > Hi Marco, > > thank you for review! > > On Wed, Oct 14, 2020 at 12:05:01PM +0200, Marco Felsch wrote: > > Hi Oleksij, > > > > pls can you send a patch adding this board to: > > Documentation/devicetree/binding

Re: [PATCH v1 3/3] ARM: dts: add Van der Laan LANMCU board

2020-10-14 Thread Marco Felsch
Hi Oleksij, pls can you send a patch adding this board to: Documentation/devicetree/bindings/arm/fsl.yaml infront of this patch? On 20-10-14 10:53, Oleksij Rempel wrote: > Van der Laan LANMCU is a module for the food storage rooms to control > proper gas composition. > > Co-Developed-by: Robin

Re: PHY reset question

2020-10-07 Thread Marco Felsch
On 20-10-07 11:20, Marek Vasut wrote: > On 10/7/20 11:06 AM, Marco Felsch wrote: ... > > You're right, just wanted to provide you a link :) > > Can you CC me on the next version of those patches ? I seems the LAN8710 > is causing grief to many. No need to since this se

Re: PHY reset question

2020-10-07 Thread Marco Felsch
On 20-10-07 10:23, Marek Vasut wrote: > On 10/7/20 10:14 AM, Marco Felsch wrote: > > Hi Marek, > > Hi, > > [...] > > > On 20-10-06 14:11, Florian Fainelli wrote: > >> On 10/6/2020 1:24 PM, Marek Vasut wrote: > > > > ... > > > >&

Re: PHY reset question

2020-10-07 Thread Marco Felsch
Hi Marek, On 20-10-06 14:11, Florian Fainelli wrote: > On 10/6/2020 1:24 PM, Marek Vasut wrote: ... > > If this happens on MX6 with FEC, can you please try these two patches? > > > > https://patchwork.ozlabs.org/project/netdev/patch/20201006135253.97395-1-ma...@denx.de/ > > > > https://patchwo

Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

2020-10-02 Thread Marco Felsch
Hi, sorry for jumping in. On 20-10-02 10:20, Krzysztof Kozlowski wrote: > On Fri, Oct 02, 2020 at 09:41:28AM +0200, Ahmad Fatoum wrote: > > Hello, > > > > On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: > > >> The existing binding doesn't cover these boards then and needs to be > > >> extended,

[PATCH 2/3] mtd: spi-nor: sst: add missing write_enable

2020-09-11 Thread Marco Felsch
SPINOR_OP_AAI_WP sequence. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/20005044C.pdf; "4.3.2 WRITE ENABLE LATCH (WEL)" Signed-off-by: Marco Felsch --- drivers/mtd/spi-nor/sst.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi

[PATCH 1/3] mtd: spi-nor: sst: fix write support for SST_WRITE marked devices

2020-09-11 Thread Marco Felsch
g and return 0 to fix both issues. Fixes: df5c21002cf4 ("mtd: spi-nor: use spi-mem dirmap API") Signed-off-by: Marco Felsch --- drivers/mtd/spi-nor/core.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/cor

[PATCH 0/3] MTD: SST SPI-NOR fixes

2020-09-11 Thread Marco Felsch
test even start addresses. My dut was an public available imx6q-sabrelite (rev.D). Other testers are welcome :) Regards, Marco Marco Felsch (3): mtd: spi-nor: sst: fix write support for SST_WRITE marked devices mtd: spi-nor: sst: add missing write_enable mtd: spi-nor: sst: move sst_write_s

[PATCH 3/3] mtd: spi-nor: sst: move sst_write_second to local driver

2020-09-11 Thread Marco Felsch
Don't mess the spi-nor core with details only relating to this specific device. Handle the addr_width locally and drop the sst related stuff from the spi-nor core to clean it up. Signed-off-by: Marco Felsch --- drivers/mtd/spi-nor/core.c | 3 --- drivers/mtd/spi-nor/sst.c

Re: [PATCH v13 00/12] add ecspi ERR009165 for i.mx6/7 soc family

2020-09-11 Thread Marco Felsch
On 20-09-01 00:03, Robin Gong wrote: > There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO > transfer to be send twice in DMA mode. Please get more information from: > https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding > new sdma ram script which works in XCH mo

Re: [PATCH v2 3/3] ARM: dts: add Plymovent M2M board

2020-09-10 Thread Marco Felsch
On 20-09-11 07:09, Oleksij Rempel wrote: > Plymovent M2M is a control interface produced for the Plymovent filter > systems. > > Signed-off-by: David Jander > Signed-off-by: Oleksij Rempel > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx6dl-plym2m.dts | 394 +

Re: [PATCH v1 1/2] regulator: pca9450: add enable_val for all bucks

2020-08-31 Thread Marco Felsch
Hi Robin, On 20-09-01 00:48, Robin Gong wrote: > BuckX enable mode > 00b = OFF > 01b = ON by PMIC_ON_REQ = H > 10b = ON by PMIC_ON_REQ = H && PMIC_STBY_REQ = L > 11b = Always ON > > For such enable mode, enable_value should be clearly set in requlator desc, > 00/11 is not enough, correct it now f

Re: [PATCH 2/2] ASoC: fsl: imx-es8328: add missing put_device() call in imx_es8328_probe()

2020-08-27 Thread Marco Felsch
On 20-08-25 20:05, Yu Kuai wrote: > if of_find_device_by_node() succeed, imx_es8328_probe() doesn't have > a corresponding put_device(). Why do we need the ssi_pdev reference here at all? Regards, Marco

Re: [PATCH v7 2/4] SFH: PCIe driver to add support of AMD sensor fusion hub

2020-08-11 Thread Marco Felsch
Hi Sandeep, On 20-08-10 21:30, Sandeep Singh wrote: > From: Sandeep Singh > > AMD SFH uses HID over PCIe bus.SFH fw is part of MP2 processor > (MP2 which is an ARM® Cortex-M4 core based co-processor to x86) and > it runs on MP2 where in driver resides on X86. This part of module > will communica

Re: [PATCH] Input: ili210x: Fix potential memory leaks

2020-08-05 Thread Marco Felsch
Hi Adam, On 20-08-04 13:30, Adam Ford wrote: > This driver requests, memory twice and requests a threaded irq, but > it doesn't free any of them if something fails. Free'ing is done automatically because the driver uses devres (identified by devm_ prepfix) functions. Regards, Marco

Re: [PATCH v5 3/4] ARM: dts: sun8i-a83t-tbs-a711: Add support for the vibrator motor

2020-07-30 Thread Marco Felsch
Hi Ondrej, On 20-07-30 15:24, Ondrej Jirman wrote: > The board has a vibrator motor. Hook it to the input subsystem. > > According to the PMIC specification, LDO needs to be enabled (value 0b11) > to achieve the specified max driving current of 150mA. We can't drive > the motor with just GPIO mod

Re: [PATCH v3 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events

2020-07-30 Thread Marco Felsch
Hi Dmitry, On 20-07-29 23:06, Dmitry Torokhov wrote: > Hi Marco, > > On Wed, Jul 29, 2020 at 09:55:13AM +0200, Marco Felsch wrote: > > Hi, > > > > On 20-07-23 10:43, Horia Geantă wrote: > > > From: André Draszik > > > > > > The snv

Re: [PATCH v3 2/3] Input: snvs_pwrkey - enable snvs clock as needed

2020-07-30 Thread Marco Felsch
Hi Dmitry, On 20-07-29 23:04, Dmitry Torokhov wrote: > On Wed, Jul 29, 2020 at 09:33:23AM +0200, Marco Felsch wrote: > > Hi, > > > > On 20-07-23 10:43, Horia Geantă wrote: > > > From: André Draszik > > > > > > At the moment, enabling this drive

Re: [PATCH] media: i2c: tvp5150: Fix horizontal crop stop boundry

2020-07-29 Thread Marco Felsch
Hi, On 20-06-25 13:05, Hans Verkuil wrote: > On 17/09/2019 09:14, Robin van der Gracht wrote: > > The value for AVID stop is relative to the width of the active video area, > > not the maximum register value. Zero means equal and a negative value means > > we're cropping on the right side. > > Wh

Re: [PATCH v2] arm: dts: imx7: add QSPI

2020-07-29 Thread Marco Felsch
Added Rob and Frank. Maybe they can explain us this behaviour. On 20-07-29 09:58, Marco Felsch wrote: > Hi Matthias, > > On 20-07-29 09:14, Matthias Schiffer wrote: > > On Wed, 2020-07-29 at 09:11 +0200, Matthias Schiffer wrote: > > > In preparation for an update of the

Re: [PATCH v2] arm: dts: imx7: add QSPI

2020-07-29 Thread Marco Felsch
tch-by: Han Xu > > Signed-off-by: Matthias Schiffer > > --- > > > > v2: > > - renamed node and label > > - reordered properties > > (as suggested by Marco Felsch) > > Ugh, I neglected to check for compile warnings after adjusting the node > name. Th

Re: [PATCH v3 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events

2020-07-29 Thread Marco Felsch
Hi, On 20-07-23 10:43, Horia Geantă wrote: > From: André Draszik > > The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc. > > This driver here should only return IRQ_HANDLED if the status register > indicates that the event we're handling in the irq handler was genuinely > in

Re: [PATCH v3 2/3] Input: snvs_pwrkey - enable snvs clock as needed

2020-07-29 Thread Marco Felsch
Hi, On 20-07-23 10:43, Horia Geantă wrote: > From: André Draszik > > At the moment, enabling this driver without the SNVS RTC driver > being active will hang the kernel as soon as the power button > is pressed. > > The reason is that in that case the SNVS isn't enabled, and > any attempt to rea

Re: [PATCH v5 0/4] SFH: Add Support for AMD Sensor Fusion Hub

2020-07-28 Thread Marco Felsch
Hi Richard, On 20-07-28 17:05, Richard Neumann wrote: > Hi, > > Am Dienstag, den 28.07.2020, 16:58 +0200 schrieb Marco Felsch: > > Hi, > > > > On 20-05-29 17:21, Andy Shevchenko wrote: > > > On Fri, May 29, 2020 at 4:42 PM Sandeep Singh < > >

Re: [PATCH v5 0/4] SFH: Add Support for AMD Sensor Fusion Hub

2020-07-28 Thread Marco Felsch
Hi, On 20-05-29 17:21, Andy Shevchenko wrote: > On Fri, May 29, 2020 at 4:42 PM Sandeep Singh wrote: > > > > From: Sandeep Singh > > > > AMD SFH(Sensor Fusion Hub) is HID based driver.SFH FW > > is part of MP2 processor (MP2 which is an ARM® Cortex-M4 > > core based co-processor to x86) and it r

Re: (EXT) Re: [PATCH] arm: dts: imx7: add QSPI

2020-07-28 Thread Marco Felsch
On 20-07-28 16:05, Matthias Schiffer wrote: > On Tue, 2020-07-28 at 15:51 +0200, Marco Felsch wrote: > > Hi Matthias, > > > > thanks for the patch. > > > > On 20-07-28 13:28, Matthias Schiffer wrote: > > > In preparation for an update of the TQ-Systems

Re: [PATCH] arm: dts: imx7: add QSPI

2020-07-28 Thread Marco Felsch
Hi Matthias, thanks for the patch. On 20-07-28 13:28, Matthias Schiffer wrote: > In preparation for an update of the TQ-Systems TQMa7x/MBa7x DTS, add the > QSPI controller to imx7s.dtsi. > > Based-on-patch-by: Han Xu > Signed-off-by: Matthias Schiffer > --- > arch/arm/boot/dts/imx7s.dtsi | 13

Re: [PATCH] hwrng: imx-rngc - setup default RNG quality

2020-07-28 Thread Marco Felsch
>From 9f047eee5e4ce8353c9b764a47e7f584b2013347 Mon Sep 17 00:00:00 2001 From: Marco Felsch Date: Thu, 7 May 2020 12:01:28 +0200 Subject: [PATCH] hwrng: imx-rngc - add quality to use it as kernel entropy pool The RM describes the RNGB as follow: 8<-

Re: [PATCH] mfd: rn5t618: Make restart handler atomic safe

2020-07-20 Thread Marco Felsch
Hi Andreas, On 20-07-18 17:47, Andreas Kemnade wrote: > The restart handler is executed during the shutdown phase which is > atomic/irq-less. The i2c framework supports atomic transfers since > commit 63b96983a5dd ("i2c: core: introduce callbacks for atomic > transfers") to address this use case.

Re: [PATCH] Replace HTTP links with HTTPS ones: input drivers

2020-07-05 Thread Marco Felsch
-off-by: Alexander A. Klimov for the "edt-ft5x06": Reviewed-by: Marco Felsch > --- > Continuing my work started at 93431e0607e5. > > If there are any URLs to be removed completely or at least not HTTPSified: > Just clearly say so and I'll *undo my change*.

Re: [PATCH v2 5/5] hwrng: imx-rngc: enable driver for i.MX6

2020-07-02 Thread Marco Felsch
On 20-06-21 17:56, Horia Geantă wrote: > i.MX6 SL, SLL, ULL, ULZ SoCs have an RNGB block. > > Since imx-rngc driver supports also rngb, > let's enable it for these SoCs too. > > Signed-off-by: Horia Geantă > --- Reviewed-by: Marco Felsch

Re: [PATCH v2 4/5] ARM: dts: imx6ull: add rng

2020-07-02 Thread Marco Felsch
On 20-06-21 17:56, Horia Geantă wrote: > Add node for the RNGB block. > > Signed-off-by: Horia Geantă > --- Reviewed-by: Marco Felsch

Re: [PATCH v3] driver core: Break infinite loop when deferred probe can't be satisfied

2020-06-09 Thread Marco Felsch
On 20-06-09 11:27, Andrzej Hajda wrote: > > On 09.06.2020 08:45, Marco Felsch wrote: > > On 20-06-08 13:11, Andrzej Hajda wrote: > >> On 08.06.2020 11:17, Marco Felsch wrote: > >>> On 20-03-26 18:31, Andy Shevchenko wrote: > >>>> On Thu, Mar

Re: [PATCH v3] driver core: Break infinite loop when deferred probe can't be satisfied

2020-06-08 Thread Marco Felsch
On 20-06-08 13:11, Andrzej Hajda wrote: > > On 08.06.2020 11:17, Marco Felsch wrote: > > On 20-03-26 18:31, Andy Shevchenko wrote: > >> On Thu, Mar 26, 2020 at 03:01:22PM +, Grant Likely wrote: > >>> On 25/03/2020 12:51, Andy Shevchenko wrote: > >>&

Re: [PATCH v3] driver core: Break infinite loop when deferred probe can't be satisfied

2020-06-08 Thread Marco Felsch
On 20-06-08 14:13, Andy Shevchenko wrote: > On Mon, Jun 8, 2020 at 12:20 PM Marco Felsch wrote: > > On 20-03-26 18:31, Andy Shevchenko wrote: > > > On Thu, Mar 26, 2020 at 03:01:22PM +, Grant Likely wrote: > > > > On 25/03/2020 12:51, Andy Shevchenko wrote: >

Re: [PATCH v3] driver core: Break infinite loop when deferred probe can't be satisfied

2020-06-08 Thread Marco Felsch
On 20-03-26 18:31, Andy Shevchenko wrote: > On Thu, Mar 26, 2020 at 03:01:22PM +, Grant Likely wrote: > > On 25/03/2020 12:51, Andy Shevchenko wrote: > > > On Tue, Mar 24, 2020 at 08:29:01PM -0700, Saravana Kannan wrote: > > > > On Tue, Mar 24, 2020 at 5:38 AM Andy Shevchenko > > > > wrote: >

Re: [PATCH] media: tvp5150: Add missed media_entity_cleanup()

2020-06-08 Thread Marco Felsch
Hi, thanks for covering that. Appart of the fact that this function does nothing: Reviewed-by: Marco Felsch On 20-06-06 22:39, Chuhong Yuan wrote: > This driver does not call media_entity_cleanup() in the error handler > of tvp5150_registered() and tvp5150_remove(), while it has

Re: [PATCH 2/2] MAINTAINERS: Add Purism Librem 5 section to the list

2020-05-27 Thread Marco Felsch
On 20-05-14 17:57, Martin Kepplinger wrote: > Add development information for the devicetree files for hardware > by Purism SPC. > > Signed-off-by: Martin Kepplinger > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0abba1aff1

Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone

2020-05-27 Thread Marco Felsch
Hi Martin, On 20-05-14 17:57, Martin Kepplinger wrote: > From: "Angus Ainslie (Purism)" > > Add a devicetree description for the Librem 5 phone. The early batches > that have been sold are supported as well as the mass-produced device > available later this year, see https://puri.sm/products/lib

Re: [PATCH v8 2/3] drivers: input: keyboard: Add mtk keypad driver

2020-05-15 Thread Marco Felsch
Hi, On 20-05-15 14:20, Fengping Yu wrote: > From: "fengping.yu" > > This adds matrix keypad support for Mediatek SoCs. > > Signed-off-by: fengping.yu > --- > drivers/input/keyboard/Kconfig | 9 ++ > drivers/input/keyboard/Makefile | 1 + > drivers/input/keyboard/mtk-kpd.c | 231 +++

Re: [PATCH v7 1/3] dt-bindings: Add keypad devicetree documentation

2020-05-14 Thread Marco Felsch
Hi, On 20-05-14 14:17, Fengping Yu wrote: > From: "fengping.yu" > > Add Mediatek matrix keypad dt-binding doc as yaml schema. > > Signed-off-by: fengping.yu > --- > .../devicetree/bindings/input/mtk-kpd.yaml| 102 ++ > 1 file changed, 102 insertions(+) > create mode 10064

Re: [PATCH v7 2/3] drivers: input: keyboard: Add mtk keypad driver

2020-05-14 Thread Marco Felsch
Hi, I like the evolution of this patch =) On 20-05-14 14:17, Fengping Yu wrote: > From: "fengping.yu" > > This adds matrix keypad support for Mediatek SoCs. > > Signed-off-by: fengping.yu > --- > drivers/input/keyboard/Kconfig | 8 ++ > drivers/input/keyboard/Makefile | 1 + > drivers

Re: [PATCH v7 3/3] configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=y

2020-05-14 Thread Marco Felsch
Hi, On 20-05-14 14:17, Fengping Yu wrote: > From: "fengping.yu" > > Add Mediatek matrix keypad support in defconfig. > > Signed-off-by: fengping.yu > --- > arch/arm64/configs/defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/config

Re: [PATCH v6] Add mtk matrix keypad driver for keypad on MTK SoC

2020-05-09 Thread Marco Felsch
Hi Yu, sorry if this is not your first name.. Something went wrong with you v6 since you are sending diffs to files that are not present in input-master/next. Regards, Marco On 20-05-09 10:04, Fengping Yu wrote: > Change since v5: > - remove unnecessary include files > - remove redundant comme

Re: [PATCH v7 2/3] media: ov8856: Add devicetree support

2020-05-07 Thread Marco Felsch
Hi Ben, On 20-05-07 08:06, Kao, Ben wrote: > Hi Robert, > > On 20-05-05 12:01, Robert Foss wrote: > > Add match table, enable ov8856_probe() to support both ACPI and DT modes. > > > > ACPI and DT modes are primarily distinguished from by checking for ACPI mode > > and by having resource like be

Re: [PATCH v10 1/3] media: dt-bindings: ov8856: Document YAML bindings

2020-05-06 Thread Marco Felsch
On 20-05-06 13:29, Robert Foss wrote: > Hey Dongchun, > > Thanks for having a look at this series. > > > > +examples: > > > + - | > > > +#include > > > + > > > +i2c { > > > +#address-cells = <1>; > > > +#size-cells = <0>; > > > + > > > +ov8856: camera@10 { > > >

Re: [PATCH v7 3/3] media: ov8856: Implement sensor module revision identification

2020-05-05 Thread Marco Felsch
Hi Robert, On 20-05-05 12:01, Robert Foss wrote: > Query the sensor for its module revision, and compare it > to known revisions. > > Currently 2A and 1B revision indentification is supported. > > Signed-off-by: Robert Foss > --- > > - Changes since v3: > * Actually add module revision 2A >

Re: [PATCH v7 2/3] media: ov8856: Add devicetree support

2020-05-05 Thread Marco Felsch
Hi Robert, On 20-05-05 12:01, Robert Foss wrote: > Add match table, enable ov8856_probe() to support > both ACPI and DT modes. > > ACPI and DT modes are primarily distinguished from > by checking for ACPI mode and by having resource like > be NULL. > > Signed-off-by: Robert Foss > --- > > - Ch

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-05-03 Thread Marco Felsch
Hi Robert, On 20-04-30 18:11, Robert Foss wrote: > Hey Marco, > > On Thu, 30 Apr 2020 at 14:07, Marco Felsch wrote: > > > > On 20-04-30 13:20, Sakari Ailus wrote: > > > On Thu, Apr 30, 2020 at 12:11:57PM +0200, Marco Felsch wrote: > > > > On 20-04-

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Marco Felsch
On 20-04-30 13:20, Sakari Ailus wrote: > On Thu, Apr 30, 2020 at 12:11:57PM +0200, Marco Felsch wrote: > > On 20-04-30 12:59, Sakari Ailus wrote: > > > Hi Marco, > > > > > > On Thu, Apr 30, 2020 at 11:53:32AM +0200, Marco Felsch wrote: > > > > Hi Sa

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Marco Felsch
On 20-04-30 12:59, Sakari Ailus wrote: > Hi Marco, > > On Thu, Apr 30, 2020 at 11:53:32AM +0200, Marco Felsch wrote: > > Hi Sakari, > > > > On 20-04-30 12:45, Sakari Ailus wrote: > > > Hi Marco, > > > > > > On Thu, Apr 30, 2020 at 11:35:24

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Marco Felsch
Hi Sakari, On 20-04-30 12:45, Sakari Ailus wrote: > Hi Marco, > > On Thu, Apr 30, 2020 at 11:35:24AM +0200, Marco Felsch wrote: > > Hi Robert, > > > > thnakf for the patch but pls keep in mind to do one thing per patch. > > IMHO this patch do a lot

Re: [PATCH v6 2/3] media: ov8856: Add devicetree support

2020-04-30 Thread Marco Felsch
Hi Robert, thnakf for the patch but pls keep in mind to do one thing per patch. IMHO this patch do a lot more. Anyway below are my comment :) On 20-04-29 18:24, Robert Foss wrote: > Add match table, enable ov8856_probe() to support > both ACPI and DT modes. You are also adding the support for re

Re: [PATCH v8 v5 1/3] media: dt-bindings: ov8856: Document YAML bindings

2020-04-28 Thread Marco Felsch
Hi Robert, On 20-04-28 20:07, Robert Foss wrote: > From: Dongchun Zhu > > This patch adds documentation of device tree in YAML schema for the > OV8856 CMOS image sensor. > > Signed-off-by: Dongchun Zhu > Signed-off-by: Robert Foss > --- > > - Changes since v7: > * Marco: Make 'port' proper

Re: [PATCH v7 1/3] media: dt-bindings: ov8856: Document YAML bindings

2020-04-28 Thread Marco Felsch
On 20-04-28 09:55, Maxime Ripard wrote: > On Mon, Apr 27, 2020 at 05:13:42PM +0200, Robert Foss wrote: > > On Wed, 15 Apr 2020 at 18:21, Marco Felsch wrote: > > > > > > On 20-04-15 11:07, Rob Herring wrote: > > > > On Wed, Apr 08, 2020 at 01:08:14PM +

Re: [PATCH 2/5] dt-bindings: mfd: da9062: add regulator voltage selection documentation

2019-10-22 Thread Marco Felsch
Hi Linus, Bartosz, can you have a look on this discussion? I wanna prepare a new version and this is still open. Regards, Marco On 19-10-02 15:45, Marco Felsch wrote: > On 19-09-30 09:53, Adam Thomson wrote: > > On 26 September 2019 15:39, Marco Felsch wrote: > > > >

Re: [PATCH 00/10] Add support for more Kontron i.MX6UL/ULL SoMs and boards

2019-10-21 Thread Marco Felsch
Hi Frieder, On 19-10-17 08:24, Schrempf Frieder wrote: > Hi Marco, > > On 17.10.19 10:14, Marco Felsch wrote: > > Hi Frieder, > > > > On 19-10-16 15:06, Schrempf Frieder wrote: > >> From: Frieder Schrempf > >> > >> In order to su

Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

2019-10-21 Thread Marco Felsch
64/boot/dts/freescale/imx8mm-evk.dts > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > > @@ -80,6 +80,7 @@ > > > pinctrl-0 = <&pinctrl_fec1>; > > > phy-mode = "rgmii-id"; > > > phy-handle = <ðphy0>; > >

Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1

2019-10-21 Thread Marco Felsch
Hi, On 19-10-21 09:21, Peng Fan wrote: > From: Peng Fan > > We should not rely on U-Boot to configure the phy reset. > So introduce phy-reset-gpios property to let Linux handle phy reset > itself. > > Signed-off-by: Peng Fan > --- > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 + > 1 file

Re: [PATCH] ARM: dt: add lsm9ds1 iio imu/magn support to gw553x

2019-10-21 Thread Marco Felsch
Hi Robert, same here, don't name it 'ARM: dt: ...' instead name it 'ARM: dts: imx: ventana: ..' or 'ARM: dts: imx: imx6qdl-gw553x: ..'. On 19-10-18 16:21, Robert Jones wrote: > Add one node for the accel/gyro i2c device and another for the separate > magnetometer device in the lsm9ds1. > > Signe

Re: [PATCH] ARM: dt: add fxos8700 on gateworks boards

2019-10-21 Thread Marco Felsch
Hi Robert, please don't use 'ARM: dt: ..' instead you should name it 'ARM: dts: imx6qdl-gw5x:'. On 19-10-18 16:20, Robert Jones wrote: > Add fxos8700 iio imu entries for Gateworks SBCs. > > Signed-off-by: Robert Jones > --- > arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 5 + > arch/arm/boot/dts

Re: [PATCH 00/22] Stop using input_polled_dev in polling drivers

2019-10-21 Thread Marco Felsch
vers found in drivers/input to the new scheme. > > > > For all I have been Cc'ed > Acked-by: Andy Shevchenko Same for me Acked-by: Marco Felsch > > > > Dmitry Torokhov (21): > > Input: raspberrypi-ts - switch to using polled mode of input devices > &

Re: [PATCH 00/10] Add support for more Kontron i.MX6UL/ULL SoMs and boards

2019-10-17 Thread Marco Felsch
Hi Frieder, On 19-10-16 15:06, Schrempf Frieder wrote: > From: Frieder Schrempf > > In order to support more of the i.MX6UL/ULL-based SoMs and boards by > Kontron Electronics GmbH, we restructure the devicetrees to share common > parts and add new devicetrees for the missing boards. > > Current

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

2019-10-17 Thread Marco Felsch
Hi Rui, On 19-10-16 14:43, Rui Miguel Silva wrote: > Hi Marco, > On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: > > Hi Chuhong, > > > > On 19-10-15 21:59, Chuhong Yuan wrote: > >> devm_regulator_get may return an error but mipi_csis_phy_init misses > >

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

2019-10-16 Thread Marco Felsch
Hi Chuhong, On 19-10-15 21:59, Chuhong Yuan wrote: > devm_regulator_get may return an error but mipi_csis_phy_init misses > a check for it. > This may lead to problems when regulator_set_voltage uses the unchecked > pointer. > This patch adds a check for devm_regulator_get to avoid potential risk.

Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file

2019-10-11 Thread Marco Felsch
On 19-10-11 18:19, Andreas Kemnade wrote: > On Fri, 11 Oct 2019 17:22:14 +0200 > Marco Felsch wrote: > > > On 19-10-11 17:05, Andreas Kemnade wrote: > > > On Fri, 11 Oct 2019 09:29:27 -0500 > > > Rob Herring wrote: > > > > > > > On Fri, O

Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file

2019-10-11 Thread Marco Felsch
On 19-10-11 17:05, Andreas Kemnade wrote: > On Fri, 11 Oct 2019 09:29:27 -0500 > Rob Herring wrote: > > > On Fri, Oct 11, 2019 at 09:41:48AM +0200, Andreas Kemnade wrote: > > > On Fri, 11 Oct 2019 08:56:09 +0200 > > > Marco Felsch wrote: > > > > &

Re: [PATCH v3 2/3] ARM: dts: add Netronix E60K02 board common file

2019-10-10 Thread Marco Felsch
Hi Andreas, On 19-10-10 21:23, Andreas Kemnade wrote: > The Netronix board E60K02 can be found some several Ebook-Readers, > at least the Kobo Clara HD and the Tolino Shine 3. The board > is equipped with different SoCs requiring different pinmuxes. > > For now the following peripherals are inclu

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
ine MISC_FUNC_GET_CONTROL 2U /* Index for misc_get_control() RPC call */ > #define MISC_FUNC_SET_MAX_DMA_GROUP 4U /* Index for misc_set_max_dma_group() > RPC call */ Ahh, okay get it. Thanks for the explanation. > > > > > + saved_func = ((struct imx_sc_rpc_msg

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
Hi Anson, On 19-10-07 09:15, Anson Huang wrote: > The SCU firmware does NOT always have return value stored in message > header's function element even the API has response data, those special > APIs are defined as void function in SCU firmware, so they should be > treated as return success always

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
On 19-10-09 08:28, Anson Huang wrote: > Hi, Marco > > > On 19-10-08 00:48, Anson Huang wrote: > > > Hi, Marco > > > > > > > On 19-10-07 09:15, Anson Huang wrote: > > > > > The SCU firmware does NOT always have return value stored in > > > > > message header's function element even the API has resp

Re: [PATCH V2] firmware: imx: Skip return value check for some special SCU firmware APIs

2019-10-09 Thread Marco Felsch
Hi Anson, On 19-10-08 00:48, Anson Huang wrote: > Hi, Marco > > > On 19-10-07 09:15, Anson Huang wrote: > > > The SCU firmware does NOT always have return value stored in message > > > header's function element even the API has response data, those > > > special APIs are defined as void function

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-08 Thread Marco Felsch
On 19-10-08 17:23, Mark Brown wrote: > On Tue, Oct 08, 2019 at 06:16:40PM +0200, Marco Felsch wrote: > > On 19-10-08 16:42, Mark Brown wrote: > > > > If this is a GPIO regulator then the Linux APIs mean you can't read the > > > status back so it's one of th

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-08 Thread Marco Felsch
On 19-10-08 16:42, Mark Brown wrote: > On Tue, Oct 08, 2019 at 04:56:05PM +0200, Marco Felsch wrote: > > On 19-10-08 13:51, Mark Brown wrote: > > > > No, we shouldn't do anything when the regulator probes - we'll only > > > disable unused regulators when

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

2019-10-08 Thread Marco Felsch
On 19-10-08 13:51, Mark Brown wrote: > On Tue, Oct 08, 2019 at 08:03:11AM +0200, Marco Felsch wrote: > > On 19-10-07 19:29, Mark Brown wrote: > > > On Mon, Oct 07, 2019 at 11:34:29AM +0200, Marco Felsch wrote: > > > > > Sorry that won't fix my problem.

  1   2   >