On Mon, 19 Apr 2021 16:43:36 -0400
Sasha Levin wrote:
> This first appeared with commit e5c02cf54154 ("i2c: mv64xxx: Add runtime
> PM support").
I forgot to add Fixes: tag to this commit. But the bug first appeared with
commit
e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support")
which is in
On Mon, 12 Apr 2021 18:38:29 +0200
Pali Rohár wrote:
> On Monday 12 April 2021 18:12:35 Andrew Lunn wrote:
> > On Mon, Apr 12, 2021 at 05:52:39PM +0200, Pali Rohár wrote:
> > > On Monday 12 April 2021 17:32:33 Andrew Lunn wrote:
> > > > > Anyway, now I'm looking at phy/marvell.c driver again
On Mon, 12 Apr 2021 15:16:59 +0300
Ivan Bornyakov wrote:
> Some SFP modules uses RX_LOS for link indication. In such cases link
> will be always up, even without cable connected. RX_LOS changes will
> trigger link_up()/link_down() upstream operations. Thus, check that SFP
> link is operational
> + /* Some internal PHYs don't have a model number. */
> + if (reg == MII_PHYSID2 && !(val & 0x3f0) &&
> + chip->info->family < ARRAY_SIZE(family_prod_id_table)) {
> + prod_id = family_prod_id_table[chip->info->family];
> + if (prod_id)
> +
On Mon, 29 Mar 2021 17:00:12 +0200
Gregory CLEMENT wrote:
> Pali Rohár writes:
>
> > Variable cur_frequency in armada37xx_cpufreq_driver_init() is unused.
> >
> > Signed-off-by: Pali Rohár
>
> Acked-by: Gregory CLEMENT
Gregory, THX for the acks.
Will you be merging these patches or
On Sat, 27 Mar 2021 14:29:59 +0100
Pali Rohár wrote:
> I can change this to 'if (!ret)' if needed, no problem.
>
> I use 'if (!val)' mostly for boolean and pointer variables. If
> variable can contain more integer values then I lot of times I use
> '=='.
Comparing integer varibales with
Change my e-mail address to ka...@kernel.org, and fix my name in
non-code parts (add diacritical mark).
Signed-off-by: Marek Behún
---
Documentation/ABI/testing/debugfs-moxtet | 4 ++--
Documentation/ABI/testing/debugfs-turris-mox-rwtm | 2 +-
Documentation/ABI/testing
Add all the files maintained by Turris team, not only for MOX, but also
for Omnia. Change website.
Signed-off-by: Marek Behún
---
MAINTAINERS | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8d23b0ec0c90..2cf388c89196 100644
On Fri, 12 Mar 2021 10:12:06 +0100
Gregory CLEMENT wrote:
> Hello Pali,
>
> > Hello Gregory!
> >
> > Patches are the for almost two months and more people have tested them.
> > They are marked with Fixed/CC-stable tags, they should go also into
> > stable trees as they are fixing CPU scaling
On Wed, 17 Feb 2021 17:22:17 +0100
Andrew Lunn wrote:
> On Wed, Feb 17, 2021 at 03:30:38PM +, Rui Salvaterra wrote:
> > Hardware buffer management has never worked on the Turris Omnia, as the
> > required MBus window hadn't been reserved. Fix thusly.
>
> Hi Rui
>
> I don't know all the
Rui, in the future make the subject prefix
[PATCH mvebu-dt]
or
[PATCH mvebu/dt]
so that Gregory knows its for him and for which branch.
Marek
gt;
> Signed-off-by: Rui Salvaterra
Reviewed-by: Marek Behún
/o\ How did I manage to miss this?
Please wait a few minutes I am just going to do a fast compile and test.
Marek
On Wed, 10 Feb 2021 11:08:59 -0800
nnet wrote:
> => md d0012604 1; md d0012604 1; md d0012604 1
> d0012604: 2b417501 .uA+
> d0012604: 945b [...
> d0012604:
So this means that in OTP you
On Tue, 09 Feb 2021 17:51:53 -0800
nnet wrote:
> On Tue, Feb 9, 2021, at 5:31 PM, nnet wrote:
> > On Tue, Feb 9, 2021, at 3:26 PM, Marek Behún wrote:
> > > On Tue, 09 Feb 2021 15:16:45 -0800
> > > nnet wrote:
> > >
> > > > I've two of
On Tue, 09 Feb 2021 15:16:45 -0800
nnet wrote:
> I've two of these and I've just swapped them (and re-pasted the heat sinks).
>
> The second one ran under load for awhile and now has frozen as well.
>
> Under a moderate load `wget -O /dev/null ` @X00Mbits they are fine.
>
> Under a 1 min
The Signed-off-by line should be last in the commit message, not first.
First line (which becomes e-mail subject) should describe what the
commit does (in a short one liner) and where it does it.
So for your patch it could be something like
bpf: support pointer to mem register spilling in
Qingfang,
what modes does the LED support? Does it support blinking on rx/tx?
What about link status?
I'd like to know because I am still working on patches which add
ethernet PHY/switch LEDs, with transparent offloading of netdev trigger.
Marek
On Mon, 11 Jan 2021 13:44:26 +0800
DENG Qingfang
On Mon, 11 Jan 2021 12:39:09 +0100
Pali Rohár wrote:
> SFP GPON module Ubiquiti U-Fiber Instant has in its EEPROM stored nonsense
> information. It claims that support all transceiver types including 10G
> Ethernet which is not truth. So clear all claimed modes and set only one
> mode which
Hi Pali,
I have rewritten the commit message a little:
The workaround for VSOL V2801F brand based GPON SFP modules added in
commit 0d035bed2a4a ("net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490
v2.0 workaround") works only for IDs added explicitly to the list.
Since there are rebranded modules
On Thu, 7 Jan 2021 19:45:49 +
Russell King - ARM Linux admin wrote:
> I think you're not reading the code very well. It checks for bytes at
> offset 1..blocksize-1, blocksize+1..2*blocksize-1, etc are zero. It
> does _not_ check that byte 0 or the byte at N*blocksize is zero - these
> bytes
On Wed, 6 Jan 2021 10:45:30 +1000
Pavana Sharma wrote:
> Thanks Marek for catching this.
>
> I will have a closer look and update the patchset.
I also sent a reply patch with subject
"patch fixing mv88e6393x SERDES IRQ for Pavana's series"
it contains the changes necessary to your series.
On Fri, 11 Dec 2020 22:51:01 +1000
Pavana Sharma wrote:
> +int mv88e6393x_serdes_irq_enable(struct mv88e6xxx_chip *chip, int port,
> + int lane, bool enable)
> +{
> + u8 cmode = chip->ports[port].cmode;
> + int err = 0;
> +
> + switch (cmode) {
> +
On Wed, 30 Dec 2020 18:06:52 +0100
Pali Rohár wrote:
> if (!sfp->type->module_supported() &&
> (memcmp(id.base.vendor_name, "UBNT", 16) ||
>memcmp(id.base.vendor_pn, "UF-INSTANT ", 16)))
I would rather add a quirk member (bitfield) to the sfp
On Sun, 15 Nov 2020 03:26:01 +0100
Andreas Färber wrote:
> Hi Russell,
>
> On 15.11.20 02:02, Russell King - ARM Linux admin wrote:
> > On Sun, Nov 15, 2020 at 01:41:51AM +0100, Andreas Färber wrote:
> >> Commit 1a642ca7f38992b086101fe204a1ae3c90ed8016 (net: ethernet: mvneta:
> >> Add
On Sun, 15 Nov 2020 01:41:51 +0100
Andreas Färber wrote:
> - if (pp->comphy || state->interface == PHY_INTERFACE_MODE_2500BASEX) {
> + if (pp->comphy || state->interface == PHY_INTERFACE_MODE_2500BASEX
> +|| state->interface == PHY_INTERFACE_MODE_NA) {
>
Also, this is how A3720 WTMI code and ATF determines XTAL clock rate.
No reason for kernel to do it differently.
Reviewed-by: Marek Behún
On Fri, 6 Nov 2020 11:00:39 +0100
Pali Rohár wrote:
> From: Terry Zhou
>
> There is an error in the current code that the XTAL MODE
> pin w
On Mon, 19 Oct 2020 10:35:12 +0200
Udo van den Heuvel wrote:
> People,
>
> At https://www.kernel.org/doc/html/latest/leds/leds-class.html we can
> read that the LEDS code supposedly optimizes away when certain
> conditions are met.
> Especially the Realtek HDA driver *unconditionally* (as found
Reviewed-by: Marek Behún
"couldn't register LED %s\n",
> led->ldev.name);
> + }
> }
> return 0;
> }
Reviewed-by: Marek Behún
.probe = lm36274_probe,
> .driver = {
> .name = "lm36274-leds",
> + .of_match_table = of_lm36274_leds_match,
> },
> };
> module_platform_driver(lm36274_driver)
Reviewed-by: Marek Behún
The leds-regulator driver only supports the old platform data binding
and no in-tree code uses it. It also seems that no OpenWRT board uses
it.
Remove this driver.
Signed-off-by: Marek Behún
---
drivers/leds/Kconfig | 7 --
drivers/leds/Makefile | 1 -
drivers/leds/leds
This driver can be compiled on other platforms with small change if
COMPILE_TEST=y.
Signed-off-by: Marek Behún
Cc: Pavel Machek
Cc: Dan Murphy
Cc: Rod Whitby
---
drivers/leds/Kconfig| 2 +-
drivers/leds/leds-fsg.c | 6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git
The devm_led_classdev_register_ext is given init_data with fwnode set,
so the LED core sets .of_node of the new LED classdev correctly.
Do not rewrite this value to parent of_node.
Signed-off-by: Marek Behún
Cc: Daniel Mack
---
drivers/leds/leds-lt3593.c | 1 -
1 file changed, 1 deletion
Fix OF node leaks by calling of_node_put in
for_each_available_child_of_node when the cycle breaks or returns.
Signed-off-by: Marek Behún
Cc: Nikita Travkin
Cc: Milo Kim
Cc: Dan Murphy
---
drivers/leds/leds-aw2013.c| 4 +++-
drivers/leds/leds-lp55xx-common.c | 8 ++--
drivers
, the code composed
name for the LED in the form
"max77650::"
For backwards compatibility we therefore set
init_data->default_label = ":";
so that the LED will not get a different name if `label` property is not
present.
Signed-off-by: Marek Behún
Cc: Bartosz Golaszewski
.
Signed-off-by: Marek Behún
Cc: Andrew Lunn
Cc: Andrey Utkin
Cc: Baolin Wang
Cc: Baolin Wang
Cc: Benjamin Herrenschmidt
Cc: Christian Mauderer
Cc: Chunyan Zhang
Cc: Dan Murphy
Cc: David Rivshin
Cc: Haojian Zhuang
Cc: H. Nikolaus Schaller
Cc: Michael Ellerman
Cc: Milo Kim
Cc: NeilBrown
Cc
Only a cosmetic change: use reverse christmas tree variables
declaration.
Signed-off-by: Marek Behún
Cc: Álvaro Fernández Rojas
Cc: Kevin Cernekee
Cc: Jaedon Shin
---
drivers/leds/leds-bcm6328.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers
The dev_of_node function should be preferred.
Signed-off-by: Marek Behún
Cc: Orson Zhai
Cc: Baolin Wang
Cc: Chunyan Zhang
Cc: Sean Wang
Cc: Matthias Brugger
Cc: Riku Voipio
---
drivers/leds/leds-88pm860x.c | 4 ++--
drivers/leds/leds-aat1290.c | 2 +-
drivers/leds/leds-an30259a.c
By using struct led_init_data when registering we do not need to parse
`label` DT property. Moreover `label` is deprecated and if it is not
present but `color` and `function` are, LED core will compose a name
from these properties instead.
Signed-off-by: Marek Behún
Cc: Álvaro Fernández Rojas
Only a cosmetic change: use reverse christmas tree variables
declaration.
Signed-off-by: Marek Behún
Cc: Álvaro Fernández Rojas
Cc: Kevin Cernekee
Cc: Jaedon Shin
---
drivers/leds/leds-bcm6358.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/leds
Rename this variable so that it is easier to read and easier to write in
80 columns.
Signed-off-by: Marek Behún
Cc: Dan Murphy
---
drivers/leds/leds-lm36274.c | 73 ++---
1 file changed, 35 insertions(+), 38 deletions(-)
diff --git a/drivers/leds/leds-lm36274.c
Use helper variable dev instead of always writing >dev.
Signed-off-by: Marek Behún
Cc: Sean Wang
Cc: John Crispin
Cc: Ryder Lee
---
drivers/leds/leds-mt6323.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds-mt632
Change
.of_match_table = xxx,
to
.of_match_table = of_match_ptr(xxx),
in various drivers.
This should be standard even for drivers that depend on OF.
Signed-off-by: Marek Behún
Cc: Sakari Ailus
Cc: Bartosz Golaszewski
Cc: Sean Wang
Cc: Matthias Brugger
Cc: Michael Ellerman
Cc: Benjamin
By using struct led_init_data when registering we do not need to parse
`label` DT property. Moreover `label` is deprecated and if it is not
present but `color` and `function` are, LED core will compose a name
from these properties instead.
Signed-off-by: Marek Behún
Cc: H. Nikolaus Schaller
Cc
Use helper variable dev instead of always writing >dev, or
>client->dev, or even >priv->client->dev.
With one more line moved reverse christmas tree is also achieved.
Signed-off-by: Marek Behún
Cc: Dan Murphy
---
drivers/leds/leds-lm3697.c | 75 ++--
These two drivers do not provide remove method and use devres for
allocation of other resources, yet they use led_classdev_register
instead of the devres variant, devm_led_classdev_register.
Fix this.
Signed-off-by: Marek Behún
Cc: Álvaro Fernández Rojas
Cc: Kevin Cernekee
Cc: Jaedon Shin
not need to set
the of_node member of the newly created LED classdev.
Signed-off-by: Marek Behún
Cc: Sean Wang
Cc: John Crispin
Cc: Ryder Lee
---
drivers/leds/leds-mt6323.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds
By using struct led_init_data when registering we do not need to parse
`label` DT property. Moreover `label` is deprecated and if it is not
present but `color` and `function` are, LED core will compose a name
from these properties instead.
Signed-off-by: Marek Behún
Cc: H. Nikolaus Schaller
Cc
By using devres version of LED registering function we can remove the
.remove method from this driver.
Signed-off-by: Marek Behún
Cc: Dan Murphy
---
drivers/leds/leds-lm36274.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/leds/leds-lm36274.c b
These settings are not parsed from DT and therefore semantically should
not be set in function with a name lm36274_parse_dt.
Signed-off-by: Marek Behún
Cc: Dan Murphy
---
drivers/leds/leds-lm36274.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers
Use helper variable dev instead of always writing >dev.
Signed-off-by: Marek Behún
Cc: Linus Walleij
Cc: Bjorn Andersson
---
drivers/leds/leds-pm8058.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/leds/leds-pm8058.c b/drivers/leds/l
Refactor the code so that LEDs are registered while device tree is being
parsed.
Signed-off-by: Marek Behún
Cc: H. Nikolaus Schaller
Cc: Grant Feng
---
drivers/leds/leds-is31fl319x.c | 174 ++---
1 file changed, 76 insertions(+), 98 deletions(-)
diff --git
We can return the last ret value.
Signed-off-by: Marek Behún
Cc: Linus Walleij
Cc: Bjorn Andersson
---
drivers/leds/leds-pm8058.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/leds-pm8058.c b/drivers/leds/leds-pm8058.c
index 70b4d06488fec
By using devres version of LED registering function we can remove the
.remove method from this driver. The probe method also gets simpler.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/leds-ns2.c
Only a cosmetic change: use reverse christmas tree variables
declaration.
Signed-off-by: Marek Behún
Cc: Bartosz Golaszewski
---
drivers/leds/leds-max77650.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-max77650.c b/drivers/leds/leds-max77650.c
index
Since .remove method is not needed now that we use devres, there is no
need to remember the number of LEDs in struct ns2_led_priv. Alloc simple
array of ns2_led_data structs.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus
Only a cosmetic change: use reverse christmas tree variables
declaration.
Signed-off-by: Marek Behún
Cc: H. Nikolaus Schaller
Cc: Grant Feng
---
drivers/leds/leds-is31fl319x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-is31fl319x.c b/drivers
Return directly instead of setting result and breaking.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/leds-ns2.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers
Do not use device_for_each_child_node. Since this driver works only with
once child node present, use device_get_next_child_node instead.
This also saves one level of indentation.
Signed-off-by: Marek Behún
Cc: Dan Murphy
---
drivers/leds/leds-lm36274.c | 50
No need to use variable found, we can determine whether the mode was
found by comparing iterator variable to its limit.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/leds-ns2.c | 7 ++-
1 file
Rename variable led_dat to led in various functions.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/leds-ns2.c | 103 ++--
1 file changed, 47 insertions(+), 56
This drivers leaks GPIO descriptors on driver removal. Use devres API
function devm_gpiod_get_from_of_node instead of gpiod_get_from_of_node
to avoid this.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers
Since this value is only used in device probe, don't store it in private
structure. Simply parse the value and set it.
Signed-off-by: Marek Behún
Cc: H. Nikolaus Schaller
Cc: Grant Feng
---
drivers/leds/leds-is31fl319x.c | 24
1 file changed, 16 insertions(+), 8
Move parsing of DT properties of one LED into separate function. This
saves indentation level and is nicer to read.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/leds-ns2.c | 120
Use helper variable dev instead of always writing >dev.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/leds-ns2.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --
Only a cosmetic change: use reverse christmas tree variables
declaration.
Signed-off-by: Marek Behún
Cc: Linus Walleij
Cc: Bjorn Andersson
---
drivers/leds/leds-pm8058.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/leds-pm8058.c b/drivers/leds/leds
Reorder #includes alphabetically.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/leds-ns2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-ns2.c b
By using struct led_init_data when registering we do not need to parse
`label` DT property. Moreover `label` is deprecated and if it is not
present but `color` and `function` are, LED core will compose a name
from these properties instead.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon
Register each LED immediately after parsing OF properties. This
simplifies the driver.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/leds-ns2.c | 143 +++-
1
Rename structures:
ns2_led -> ns2_led_of_one
ns2_led_data -> ns2_led.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/leds-ns2.c | 34 +-
1 file chang
By using struct led_init_data when registering we do not need to parse
`label` DT property. Moreover `label` is deprecated and if it is not
present but `color` and `function` are, LED core will compose a name
from these properties instead.
Signed-off-by: Marek Behún
Cc: Linus Walleij
Cc: Bjorn
evice tree, change the code to work with device
tree only. As Linus Walleij wrote, the device tree should be the
preferred way forward anyway.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/leds-
: "Uwe Kleine-König"
Cc: Vasant Hegde
Cc: Vincent Donnefort
Cc: Xiaotong Lu
Marek Behún (50):
leds: various: compile if COMPILE_TEST=y
leds: ip30: compile if COMPILE_TEST=y
leds: fsg: compile if COMPILE_TEST=y
leds: various: use device_get_match_data
leds: various: guard of_m
This driver can be compiled on other platforms with small change if
COMPILE_TEST=y.
Signed-off-by: Marek Behún
Cc: Pavel Machek
Cc: Dan Murphy
Cc: Thomas Bogendoerfer
---
drivers/leds/Kconfig | 2 +-
drivers/leds/leds-ip30.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff
-by: Marek Behún
---
drivers/leds/led-class.c | 5 +
drivers/leds/leds-an30259a.c | 3 ---
drivers/leds/leds-aw2013.c | 3 ---
drivers/leds/leds-bcm6328.c | 4
drivers/leds/leds-bcm6358.c | 4
drivers/leds/leds-cr0014114.c| 3 ---
drivers/leds/leds-el15203000
, the code composed
name for the LED in the form
"parent_name::"
For backwards compatibility we therefore set
init_data->default_label = ":";
so that the LED will not get a different name if `label` property is not
present, nor are `color` and `function`.
Signed-off-by: Mare
Since the shutdown gpio descriptor is only accessed in device probe
method there is no need to store it in the private structure.
Signed-off-by: Marek Behún
Cc: H. Nikolaus Schaller
Cc: Grant Feng
---
drivers/leds/leds-is31fl319x.c | 31 +++
1 file changed, 15
Only a cosmetic change: use reverse christmas tree variables
declaration.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/leds-ns2.c | 16 ++--
1 file changed, 10 insertions(+), 6
, the code composed
name for the LED in the form
"parent_name::"
For backwards compatibility we therefore set
init_data->default_label = ":";
so that the LED will not get a different name if `label` property is not
present.
Signed-off-by: Marek Behún
Cc: Dan Murphy
---
dri
Simply use device_get_match_data instead of matching against the match
table again.
Signed-off-by: Marek Behún
Cc: H. Nikolaus Schaller
Cc: David Rivshin
Cc: Sebastian Reichel
Cc: Christian Mauderer
Cc: Andrew Lunn
---
drivers/leds/leds-cpcap.c | 7 +--
drivers/leds/leds
Parse `led-max-current` property of child nodes and compute aggregated
value in a separate function. The controller cannot set this value
separately for every LED, so there is no need to store this value for
every LED.
Signed-off-by: Marek Behún
Cc: H. Nikolaus Schaller
---
drivers/leds/leds
These drivers can be compiled without modification when COMPILE_TEST=y:
cobalt-qube, cobalt-raq, netxbig, ns2 and s3c24xx
Signed-off-by: Marek Behún
Cc: Pavel Machek
Cc: Dan Murphy
---
drivers/leds/Kconfig | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Build this driver on another platforms if COMPILE_TEST=y. Another
drivers may depend on this, for example leds-asic3.
Signed-off-by: Marek Behún
Cc: Lee Jones
Cc: Pavel Machek
Cc: Phil Blundell
Cc: Samuel Ortiz
---
drivers/mfd/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
MPILE_TEST is enabled.
Signed-off-by: Marek Behún
Cc: Simon Guinot
Cc: Simon Guinot
Cc: Vincent Donnefort
Cc: Thomas Petazzoni
Cc: Linus Walleij
---
drivers/leds/Kconfig| 2 +-
drivers/leds/leds-ns2.c | 361
2 files changed, 112 insertions(+), 251
By using struct led_init_data when registering we do not need to parse
`label` DT property nor `linux,default-trigger` property.
Signed-off-by: Marek Behún
Cc: Sean Wang
Cc: John Crispin
Cc: Ryder Lee
---
drivers/leds/leds-mt6323.c | 13 ++---
1 file changed, 6 insertions(+), 7
";
so that the LED will not get a different name if `label` property is not
present.
Signed-off-by: Marek Behún
Cc: Dan Murphy
---
drivers/leds/leds-lm36274.c | 100 ++--
1 file changed, 49 insertions(+), 51 deletions(-)
diff --git a/drivers/leds/leds-lm36274.c b/dr
By using struct led_init_data when registering we do not need to parse
`label` DT property nor `linux,default-trigger` property.
Signed-off-by: Marek Behún
Cc: Linus Walleij
Cc: Bjorn Andersson
---
drivers/leds/leds-pm8058.c | 38 +++---
1 file changed, 19
By using struct led_init_data when registering we do not need to parse
`label` DT property nor `linux,default-trigger` property.
Signed-off-by: Marek Behún
Cc: Álvaro Fernández Rojas
Cc: Kevin Cernekee
Cc: Jaedon Shin
---
drivers/leds/leds-bcm6328.c | 10 --
drivers/leds/leds-bcm6358
By using struct led_init_data when registering we do not need to parse
`label` DT property nor `linux,default-trigger` property.
This driver needed bigger refactor because it first parsed DT for all
LEDs and only after that started registering them.
Signed-off-by: Marek Behún
Cc: H. Nikolaus
: Thomas Petazzoni
Cc: Vincent Donnefort
Marek Behún (10):
leds: parse linux,default-trigger DT property in LED core
leds: bcm6328, bcm6358: use struct led_init_data when registering
leds: lm3697: use struct led_init_data when registering
leds: max77650: use struct led_init_data when
By using struct led_init_data when registering we do not need to parse
`label` DT property nor `linux,default-trigger` property.
This driver needed small refactoring for this to work nicely.
Signed-off-by: Marek Behún
Cc: H. Nikolaus Schaller
Cc: David Rivshin
---
drivers/leds/leds
refore set
init_data->default_label = ":";
so that the LED will not get a different name if `label` property is not
present.
Signed-off-by: Marek Behún
Cc: Dan Murphy
---
drivers/leds/leds-lm3697.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --
refore set
init_data->default_label = ":";
so that the LED will not get a different name if `label` property is not
present.
Signed-off-by: Marek Behún
Cc: Bartosz Golaszewski
---
drivers/leds/leds-max77650.c | 24
1 file changed, 8 insertions(+), 16 deletions(-
registering function.
Signed-off-by: Marek Behún
---
drivers/leds/led-class.c | 5 +
drivers/leds/leds-an30259a.c | 3 ---
drivers/leds/leds-aw2013.c | 3 ---
drivers/leds/leds-cr0014114.c| 3 ---
drivers/leds/leds-el15203000.c | 3 ---
drivers/leds/leds-gpio.c
s
not yet implemented:
led {
color = ;
function = LED_FUNCTION_LINK, LED_FUNCTION_ACTIVITY;
trigger-sources = <>;
};
Marek
Marek Behún (2):
leds: trigger: add trigger sources validating method and helper
functions
leds: trigger: netdev: parse `trigger-sources` from device
t;xyz";
#trigger-source-cells = <0>;
};
led {
color = ;
function = LED_FUNCTION_LINK;
trigger-sources = <>;
};
Signed-off-by: Marek Behún
Cc: Rob Herring
Cc: devicet...@vger.kernel.org
---
drivers/leds/trigger/ledtrig-netdev.c | 80 ++
` refers to a
device compatible with the trigger. For this two new helper functions,
of_led_count_trigger_sources and of_led_get_trigger_source, are
implemented.
Signed-off-by: Marek Behún
Cc: Rob Herring
Cc: devicet...@vger.kernel.org
---
drivers/leds/led-triggers.c | 68
have the `function`
property. Multiple modes can be achieved by string array, but this is
not yet implemented:
led {
color = ;
function = LED_FUNCTION_LINK, LED_FUNCTION_ACTIVITY;
trigger-sources = <>;
};
Marek
Marek Behún (2):
leds: trigger: add DT `trigger-source` validat
` refers to a
device compatible with the trigger.
Signed-off-by: Marek Behún
Cc: Rob Herring
Cc: devicet...@vger.kernel.org
---
drivers/leds/led-triggers.c | 26 ++
include/linux/leds.h| 6 ++
2 files changed, 24 insertions(+), 8 deletions(-)
diff --git a/drivers
1 - 100 of 197 matches
Mail list logo
