Re: [PATCH v2] remoteproc: xlnx: add sram support

2024-07-22 Thread Mathieu Poirier
Good morning, On Mon, Jul 15, 2024 at 06:39:54PM -0700, Tanmay Shah wrote: > AMD-Xilinx zynqmp platform contains on-chip sram memory (OCM). > R5 cores can access OCM and access is faster than DDR memory but slower > than TCM memories available. Sram region can have optional multiple >

Re: [PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for i.MX8M

2024-07-16 Thread Mathieu Poirier
On Tue, Jul 16, 2024 at 06:49:39PM +0300, Iuliana Prodan wrote: > Hi Mathieu, > > On 7/16/2024 6:16 PM, Mathieu Poirier wrote: > > Good morning, > > > > On Fri, Jul 12, 2024 at 04:34:54PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > >

Re: [PATCH 6/6] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-07-16 Thread Mathieu Poirier
On Fri, Jul 12, 2024 at 04:34:59PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The i.MX7ULP Cortex-A7 is under control of Cortex-M4. The i.MX7ULP Linux > poweroff and restart rely on rpmsg driver to send a message to Cortex-M4 > firmware. Then Cortex-A7 could poweroff or restart by

Re: [PATCH 5/6] remoteproc: imx_rproc: allow tx_block to be set

2024-07-16 Thread Mathieu Poirier
On Fri, Jul 12, 2024 at 04:34:58PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Current tx_block is set to true, but there is case that no need to wait > response. Linux just needs to send data to remote processor, so let's > allow tx_block could be set to false. Ok, maybe - but this patch

Re: [PATCH 4/6] remoteproc: imx_rproc: merge TCML/U

2024-07-16 Thread Mathieu Poirier
On Fri, Jul 12, 2024 at 04:34:57PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Merge contiguous TCML/U regions into one to avoid load elf files which > has large sections failure. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 18 ++ > 1 file

Re: [PATCH 3/6] remoteproc: imx_rproc: initialize workqueue earlier

2024-07-16 Thread Mathieu Poirier
On Fri, Jul 12, 2024 at 04:34:56PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Initialize workqueue before requesting mailbox channel, otherwise if > mailbox interrupt comes before workqueue ready, the imx_rproc_rx_callback > will trigger issue. > > Reviewed-by: Richard Zhu All reviews

Re: [PATCH 1/6] remoteproc: imx_rproc: correct ddr alias for i.MX8M

2024-07-16 Thread Mathieu Poirier
Good morning, On Fri, Jul 12, 2024 at 04:34:54PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The DDR Alias address should be 0x4000 according to RM, so correct > it. > > Fixes: 4ab8f9607aad ("remoteproc: imx_rproc: support i.MX8MQ/M") This commit was merged more than 3 years ago...

Re: [PATCH RFC 1/1] remoteproc: mediatek: Support reserved CMA regions

2024-07-11 Thread Mathieu Poirier
On Wed, 10 Jul 2024 at 02:42, Shun-yi Wang wrote: > > From: "shun-yi.wang" > > In order to reserve specific Contiguous Memory Allocator (CMA) regions > for hardware use. When the name of the reserved region contains "cma", > then a corresponding CMA heap is added. > > Signed-off-by: shun-yi.wang

Re: [PATCH 1/1] remoteproc: mediatek: Support multiple reserved memory regions

2024-07-10 Thread Mathieu Poirier
On Wed, Jul 03, 2024 at 07:53:08PM +0800, Shun-yi Wang wrote: > From: "shun-yi.wang" > > SCP supports multiple reserved memory regions, intended for > specific hardwards. > > Signed-off-by: shun-yi.wang > --- > drivers/remoteproc/mtk_scp.c | 25 + > 1 file changed, 17

Re: [PATCH 0/1] Support multiple reserved memory regions

2024-07-10 Thread Mathieu Poirier
Good morning, On Wed, Jul 03, 2024 at 07:53:07PM +0800, Shun-yi Wang wrote: > From: "shun-yi.wang" > > Besides the reserved memory region for SCP, there are additional > reserved memory regions for specific hardware use. > Currently, only a single memory region is supported. > Modifications

Re: [PATCH v2 2/2] virtio: fix vq # for balloon

2024-07-10 Thread Mathieu Poirier
1 ("virtio-balloon: add support for providing free page > reports to host") > Cc: "Alexander Duyck" > Signed-off-by: Michael S. Tsirkin > --- > arch/um/drivers/virtio_uml.c | 4 ++-- > drivers/remoteproc/remoteproc_virtio.c | 4 ++-- Reviewed-b

Re: [PATCH] remoteproc: mediatek: Increase MT8188/MT8195 SCP core0 DRAM size

2024-07-08 Thread Mathieu Poirier
On Wed, Jul 03, 2024 at 11:05:59AM +0200, AngeloGioacchino Del Regno wrote: > Il 03/07/24 05:44, Jason Chen ha scritto: > > The current DRAM size is insufficient for the HEVC feature, which > > requires more memory for proper functionality. This change ensures the > > feature has the necessary

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-08 Thread Mathieu Poirier
On Fri, Jul 05, 2024 at 09:33:55AM +0200, Arnaud POULIQUEN wrote: > > > On 7/4/24 17:32, Mathieu Poirier wrote: > > On Thu, Jul 04, 2024 at 10:05:24AM +0200, Arnaud POULIQUEN wrote: > >> > >> > >> On 7/3/24 17:14, Mathieu Poirier wrote: > >>

Re: [PATCH v6] remoteproc: xlnx: add attach detach support

2024-07-04 Thread Mathieu Poirier
On Thu, Jun 27, 2024 at 10:29:38AM -0700, Tanmay Shah wrote: > It is possible that remote processor is already running before > linux boot or remoteproc platform driver probe. Implement required > remoteproc framework ops to provide resource table address and > connect or disconnect with remote

Re: [PATCH v2] remoteproc: k3-dsp: Fix log levels where appropriate

2024-07-04 Thread Mathieu Poirier
On Wed, Jun 26, 2024 at 12:14:38PM -0700, Garrett Giordano wrote: > Driver was logging information as errors. Changed dev_err to dev_dbg > where appropriate. > > Signed-off-by: Garrett Giordano > --- > -v2 > - Change from dev_info to dev_dbg > - Drop k3-r5 PATCH > --- >

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-04 Thread Mathieu Poirier
On Thu, Jul 04, 2024 at 10:05:24AM +0200, Arnaud POULIQUEN wrote: > > > On 7/3/24 17:14, Mathieu Poirier wrote: > > On Wed, Jul 03, 2024 at 09:19:44AM +0200, Arnaud POULIQUEN wrote: > >> Hello Mathieu > >> > >> On 7/2/24 18:44, Mathieu Poirier wrote: &

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-03 Thread Mathieu Poirier
On Fri, Jun 21, 2024 at 04:37:56PM +0200, Arnaud Pouliquen wrote: > Add a remoteproc TEE (Trusted Execution Environment) driver > that will be probed by the TEE bus. If the associated Trusted > application is supported on secure part this driver offers a client > interface to load a firmware by

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-03 Thread Mathieu Poirier
On Wed, Jul 03, 2024 at 09:19:44AM +0200, Arnaud POULIQUEN wrote: > Hello Mathieu > > On 7/2/24 18:44, Mathieu Poirier wrote: > > Good morning, > > > > On Fri, Jun 21, 2024 at 04:37:56PM +0200, Arnaud Pouliquen wrote: > >> Add a remoteproc TEE (T

Re: [PATCH v8 5/5] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-07-02 Thread Mathieu Poirier
On Fri, Jun 21, 2024 at 04:37:59PM +0200, Arnaud Pouliquen wrote: > The new TEE remoteproc device is used to manage remote firmware in a Device or driver? > secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is > introduced to delegate the loading of the firmware to the trusted >

Re: [PATCH v8 2/5] remoteproc: Add TEE support

2024-07-02 Thread Mathieu Poirier
Good morning, On Fri, Jun 21, 2024 at 04:37:56PM +0200, Arnaud Pouliquen wrote: > Add a remoteproc TEE (Trusted Execution Environment) driver > that will be probed by the TEE bus. If the associated Trusted > application is supported on secure part this driver offers a client > interface to load a

Re: [PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection

2024-07-01 Thread Mathieu Poirier
On Mon, Jul 01, 2024 at 04:13:00AM -0500, Hari Nagalla wrote: > On 6/28/24 14:58, Mathieu Poirier wrote: > > > This could lead in an incorrect IPC-only mode detection if reset line is > > > asserted (so reset_control_status() return > 0) and c_state != 0 and > > >

Re: [PATCH 3/4] remoteproc: k3-r5: k3_r5_rproc_stop: code reorder

2024-07-01 Thread Mathieu Poirier
On Mon, Jul 01, 2024 at 10:03:22AM +0200, Richard GENOUD wrote: > Le 28/06/2024 à 23:18, Mathieu Poirier a écrit : > > On Fri, Jun 21, 2024 at 05:00:57PM +0200, Richard Genoud wrote: > > > In the next commit, a RP_MBOX_SHUTDOWN message will be sent in > > > k3_r5_rpro

Re: [PATCH 0/4] remoteproc: k3-r5: Introduce suspend to ram support

2024-06-28 Thread Mathieu Poirier
On Fri, 21 Jun 2024 at 09:01, Richard Genoud wrote: > > This series enables the suspend to ram with R5F remote processors on TI K3 > platform. > > The 1st patch is actually a fix, independent from the others > > The 2nd patch introduces the suspend/resume handlers. > On suspend, the running

Re: [PATCH 4/4] remoteproc: k3-r5: support for graceful stop of remote cores

2024-06-28 Thread Mathieu Poirier
On Fri, Jun 21, 2024 at 05:00:58PM +0200, Richard Genoud wrote: > Introduce software IPC handshake between the K3-R5 remote proc driver > and the R5 MCU to gracefully stop/reset the remote core. > > Upon a stop request, K3-R5 remote proc driver sends a RP_MBOX_SHUTDOWN > mailbox message to the

Re: [PATCH 3/4] remoteproc: k3-r5: k3_r5_rproc_stop: code reorder

2024-06-28 Thread Mathieu Poirier
On Fri, Jun 21, 2024 at 05:00:57PM +0200, Richard Genoud wrote: > In the next commit, a RP_MBOX_SHUTDOWN message will be sent in > k3_r5_rproc_stop() to the remote proc (in lockstep on not) > Thus, the sanity check "do not allow core 0 to stop before core 1" > should be moved at the beginning of

Re: [PATCH 2/4] remoteproc: k3-r5: Introduce PM suspend/resume handlers

2024-06-28 Thread Mathieu Poirier
On Fri, Jun 21, 2024 at 05:00:56PM +0200, Richard Genoud wrote: > This patch adds the support for system suspend/resume to the ti_k3_R5 > remoteproc driver. > > In order to save maximum power, the approach here is to shutdown > completely the cores that were started by the kernel (i.e. those in >

Re: [PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection

2024-06-28 Thread Mathieu Poirier
Nishanth, Vignesh, Hari and Andrew - please have a look at this patch. Thanks, Mathieu On Fri, 28 Jun 2024 at 13:53, Mathieu Poirier wrote: > > Good day, > > On Fri, Jun 21, 2024 at 05:00:55PM +0200, Richard Genoud wrote: > > ret variable was used to test rese

Re: [PATCH 1/4] remoteproc: k3-r5: Fix IPC-only mode detection

2024-06-28 Thread Mathieu Poirier
Good day, On Fri, Jun 21, 2024 at 05:00:55PM +0200, Richard Genoud wrote: > ret variable was used to test reset status, get from > reset_control_status() call. But this variable was overwritten by > ti_sci_proc_get_status() a few lines bellow. > And as ti_sci_proc_get_status() returns 0 or a

Re: [PATCH] remoteproc: mediatek: Don't attempt to remap l1tcm memory if missing

2024-06-28 Thread Mathieu Poirier
On Thu, Jun 27, 2024 at 05:20:55PM -0400, Nícolas F. R. A. Prado wrote: > The current code doesn't check whether platform_get_resource_byname() > succeeded to get the l1tcm memory, which is optional, before attempting > to map it. This results in the following error message when it is > missing: >

Re: [PATCH v7 1/5] remoteproc: core: Introduce rproc_pa_to_va helper

2024-06-20 Thread Mathieu Poirier
On Tue, Jun 11, 2024 at 09:39:00AM +0200, Arnaud Pouliquen wrote: > When a resource table is loaded by an external entity such as U-boot or > OP-TEE, we do not necessary get the device address(da) but the physical s/necessary/necessarily > address(pa). > This helper performs similar translation

Re: [PATCH v7 2/5] remoteproc: Add TEE support

2024-06-20 Thread Mathieu Poirier
On Wed, Jun 19, 2024 at 06:33:05PM +0200, Arnaud POULIQUEN wrote: > Hi, > > On 6/19/24 17:41, Mathieu Poirier wrote: > > Hi, > > > > On Tue, Jun 11, 2024 at 09:39:01AM +0200, Arnaud Pouliquen wrote: > >> Add a remoteproc TEE (Trusted Execution Environm

Re: [PATCH v7 2/5] remoteproc: Add TEE support

2024-06-20 Thread Mathieu Poirier
On Tue, Jun 11, 2024 at 09:39:01AM +0200, Arnaud Pouliquen wrote: > Add a remoteproc TEE (Trusted Execution Environment) driver > that will be probed by the TEE bus. If the associated Trusted > application is supported on secure part this driver offers a client > interface to load a firmware in

Re: [PATCH v7 2/5] remoteproc: Add TEE support

2024-06-19 Thread Mathieu Poirier
Hi, On Tue, Jun 11, 2024 at 09:39:01AM +0200, Arnaud Pouliquen wrote: > Add a remoteproc TEE (Trusted Execution Environment) driver > that will be probed by the TEE bus. If the associated Trusted > application is supported on secure part this driver offers a client > interface to load a firmware

Re: [PATCH v10 2/8] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2024-06-18 Thread Mathieu Poirier
Good morning, On Mon, Jun 10, 2024 at 01:06:09PM -0500, Andrew Davis wrote: > From: Martyn Welch > > The AM62x and AM64x SoCs of the TI K3 family has a Cortex M4F core in > the MCU domain. This core is typically used for safety applications in a > stand alone mode. However, some application

Re: [PATCH v5] remoteproc: xlnx: add attach detach support

2024-06-18 Thread Mathieu Poirier
On Tue, Jun 18, 2024 at 11:45:28AM -0500, Tanmay Shah wrote: > > > On 6/17/24 10:40 AM, Mathieu Poirier wrote: > > Good day, > > > > On Mon, Jun 10, 2024 at 08:42:27AM -0700, Tanmay Shah wrote: > >> It is possible that remote processor is already running

Re: [PATCH v5] remoteproc: xlnx: add attach detach support

2024-06-17 Thread Mathieu Poirier
Good day, On Mon, Jun 10, 2024 at 08:42:27AM -0700, Tanmay Shah wrote: > It is possible that remote processor is already running before > linux boot or remoteproc platform driver probe. Implement required > remoteproc framework ops to provide resource table address and > connect or disconnect

Re: [PATCH] remoteproc: imx_rproc: Fix refcount mistake in imx_rproc_addr_init

2024-06-17 Thread Mathieu Poirier
On Wed, Jun 12, 2024 at 04:17:14PM +0300, Aleksandr Mishin wrote: > In imx_rproc_addr_init() strcmp() is performed over the node after the > of_node_put() is performed over it. > Fix this error by moving of_node_put() calls. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. >

Re: [PATCH v3 1/1] dt-bindings: remoteproc: imx_rproc: add minItems for power-domain

2024-06-17 Thread Mathieu Poirier
On Mon, Jun 10, 2024 at 11:17:21AM -0400, Frank Li wrote: > "fsl,imx8qxp-cm4" and "fsl,imx8qm-cm4" need minimum 2 power domains. Other > platform doesn't require 'power-domain'. > > Signed-off-by: Frank Li > --- > > Notes: > Change from v2 to v3 > - only imx8qxp and imx8qm need

Re: [PATCH 5/6] remoteproc: da8xx: Use devm action to release reserved memory

2024-06-11 Thread Mathieu Poirier
Hi Andrew, On Mon, Jun 10, 2024 at 10:17:20AM -0500, Andrew Davis wrote: > This helps prevent mistakes like freeing out of order in cleanup functions > and forgetting to free on error paths. > > Signed-off-by: Andrew Davis > --- > drivers/remoteproc/da8xx_remoteproc.c | 29

Re: [lvc-project] [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue while remapping optional addresses in imx_rproc_addr_init()

2024-06-11 Thread Mathieu Poirier
On Mon, Jun 10, 2024 at 08:36:19PM +0300, Fedor Pchelkin wrote: > On Mon, 10. Jun 10:47, Mathieu Poirier wrote: > > On Thu, Jun 06, 2024 at 10:52:04AM +0300, Aleksandr Mishin wrote: > > > In imx_rproc_addr_init() "nph = of_count_phandle_with_args()" just cou

Re: [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs

2024-06-10 Thread Mathieu Poirier
On Tue, Jun 04, 2024 at 12:14:50PM -0500, Hari Nagalla wrote: > The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It > does not have an addressable l1dram . So, remove this optional sram > property from the bindings to fix device tree build warnings. > > Signed-off-by: Hari

Re: [PATCH] rpmsg: char: add missing MODULE_DESCRIPTION() macro

2024-06-10 Thread Mathieu Poirier
On Tue, Jun 04, 2024 at 06:53:44PM -0700, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/rpmsg/rpmsg_char.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson > --- >

Re: [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue while remapping optional addresses in imx_rproc_addr_init()

2024-06-10 Thread Mathieu Poirier
On Thu, Jun 06, 2024 at 10:52:04AM +0300, Aleksandr Mishin wrote: > In imx_rproc_addr_init() "nph = of_count_phandle_with_args()" just counts > number of phandles. But phandles may be empty. So of_parse_phandle() in > the parsing loop (0 < a < nph) may return NULL which is later dereferenced. >

Re: [PATCH] remoteproc: mediatek: Increase MT8188 SCP core0 DRAM size

2024-06-10 Thread Mathieu Poirier
On Thu, Jun 06, 2024 at 01:00:11PM +0200, AngeloGioacchino Del Regno wrote: > Il 06/06/24 11:06, jason-ch chen ha scritto: > > From: Jason Chen > > > > Increase MT8188 SCP core0 DRAM size for HEVC driver. This is telling me _what_ gets done rather than _why_ it gets done. > > > > so the

Re: [PATCH v4] drivers: remoteproc: xlnx: add attach detach support

2024-06-06 Thread Mathieu Poirier
On Wed, Jun 05, 2024 at 12:45:17PM -0500, Tanmay Shah wrote: > > > On 6/4/24 10:34 AM, Mathieu Poirier wrote: > > Hi Mathieu, > > Thanks for reviews. > Please find my comments below. > > > Hi Tanmay, > > > > On Mon, Jun 03, 2024 at 01:34:38PM

Re: [PATCH v4] drivers: remoteproc: xlnx: add attach detach support

2024-06-06 Thread Mathieu Poirier
On Wed, 5 Jun 2024 at 11:47, Tanmay Shah wrote: > > > > On 6/4/24 3:23 PM, Bjorn Andersson wrote: > > On Mon, Jun 03, 2024 at 01:34:38PM -0700, Tanmay Shah wrote: > >> It is possible that remote processor is already running before > >> linux boot or remoteproc platform driver probe. Implement

Re: [PATCH v4] drivers: remoteproc: xlnx: add attach detach support

2024-06-04 Thread Mathieu Poirier
Hi Tanmay, On Mon, Jun 03, 2024 at 01:34:38PM -0700, Tanmay Shah wrote: > It is possible that remote processor is already running before > linux boot or remoteproc platform driver probe. Implement required > remoteproc framework ops to provide resource table address and > connect or disconnect

Re: [PATCH v5 5/7] remoteproc: core: support of the tee interface

2024-06-03 Thread Mathieu Poirier
On Mon, 3 Jun 2024 at 02:22, Arnaud POULIQUEN wrote: > > Hello Mathieu, > > On 5/31/24 19:28, Mathieu Poirier wrote: > > On Thu, May 30, 2024 at 09:42:26AM +0200, Arnaud POULIQUEN wrote: > >> Hello Mathieu, > >> > >> On 5/29/24 22:35, Mathieu Poiri

Re: [PATCH v5 5/7] remoteproc: core: support of the tee interface

2024-05-31 Thread Mathieu Poirier
On Thu, May 30, 2024 at 09:42:26AM +0200, Arnaud POULIQUEN wrote: > Hello Mathieu, > > On 5/29/24 22:35, Mathieu Poirier wrote: > > On Wed, May 29, 2024 at 09:13:26AM +0200, Arnaud POULIQUEN wrote: > >> Hello Mathieu, > >> > >> On 5/28/24 23:30, Mathieu

Re: [PATCH v5 5/7] remoteproc: core: support of the tee interface

2024-05-30 Thread Mathieu Poirier
On Thu, May 30, 2024 at 09:42:26AM +0200, Arnaud POULIQUEN wrote: > Hello Mathieu, > > On 5/29/24 22:35, Mathieu Poirier wrote: > > On Wed, May 29, 2024 at 09:13:26AM +0200, Arnaud POULIQUEN wrote: > >> Hello Mathieu, > >> > >> On 5/28/24 23:30, Mathieu

Re: [PATCH v5 5/7] remoteproc: core: support of the tee interface

2024-05-29 Thread Mathieu Poirier
On Wed, May 29, 2024 at 09:13:26AM +0200, Arnaud POULIQUEN wrote: > Hello Mathieu, > > On 5/28/24 23:30, Mathieu Poirier wrote: > > On Tue, May 21, 2024 at 10:09:59AM +0200, Arnaud Pouliquen wrote: > >> 1) on start: > >> - Using the TEE loader, the resource tabl

Re: [PATCH v5 5/7] remoteproc: core: support of the tee interface

2024-05-28 Thread Mathieu Poirier
On Tue, May 21, 2024 at 10:09:59AM +0200, Arnaud Pouliquen wrote: > 1) on start: > - Using the TEE loader, the resource table is loaded by an external entity. > In such case the resource table address is not find from the firmware but > provided by the TEE remoteproc framework. > Use the

Re: [PATCH v5 4/7] remoteproc: core introduce rproc_set_rsc_table_on_start function

2024-05-28 Thread Mathieu Poirier
move rproc_reset_rsc_table_on_stop() to be close to the > rproc_set_rsc_table_on_start() function This patch is really hard to read due to all 3 operations happening at the same time. Please split in 3 smaller patches. > > Suggested-by: Mathieu Poirier > Signed-off-by: Arnaud Pouliquen

Re: [PATCH v5 2/7] dt-bindings: remoteproc: Add compatibility for TEE support

2024-05-28 Thread Mathieu Poirier
On Tue, May 21, 2024 at 10:09:56AM +0200, Arnaud Pouliquen wrote: > The "st,stm32mp1-m4-tee" compatible is utilized in a system configuration > where the Cortex-M4 firmware is loaded by the Trusted execution Environment > (TEE). > For instance, this compatible is used in both the Linux and OP-TEE

Re: [PATCH] remoteproc: stm32_rproc: Fix mailbox interrupts queuing

2024-05-28 Thread Mathieu Poirier
On Tue, May 21, 2024 at 06:23:16PM +0200, Gwenael Treuveur wrote: > Manage interrupt coming from coprocessor also when state is > ATTACHED. > > Fixes: 35bdafda40cc ("remoteproc: stm32_rproc: Add mutex protection for > workqueue") > Signed-off-by: Gwenael Treuveur > Acked-by: Arnaud Pouliquen

Re: [PATCH v2 1/2] drivers: remoteproc: xlnx: add attach detach support

2024-05-23 Thread Mathieu Poirier
On Wed, May 22, 2024 at 09:36:26AM -0500, Tanmay Shah wrote: > > > On 5/21/24 12:56 PM, Mathieu Poirier wrote: > > Hi Tanmay, > > > > On Fri, May 10, 2024 at 05:51:25PM -0700, Tanmay Shah wrote: > >> It is possible that remote processor is already running

Re: [PATCH v2 1/2] drivers: remoteproc: xlnx: add attach detach support

2024-05-21 Thread Mathieu Poirier
Hi Tanmay, On Fri, May 10, 2024 at 05:51:25PM -0700, Tanmay Shah wrote: > It is possible that remote processor is already running before > linux boot or remoteproc platform driver probe. Implement required > remoteproc framework ops to provide resource table address and > connect or disconnect

Re: [PATCH] rpmsg: char: fix rpmsg_eptdev structure documentation

2024-05-21 Thread Mathieu Poirier
On Fri, May 17, 2024 at 06:56:54PM +0200, Arnaud Pouliquen wrote: > Add missing @ tags for some rpmsg_eptdev structure parameters. > > This fixes warning messages on build: > drivers/rpmsg/rpmsg_char.c:75: warning: Function parameter or struct member > 'remote_flow_restricted' not described in

Re: [PATCH] remoteproc: mediatek: Zero out only remaining bytes of IPI buffer

2024-05-21 Thread Mathieu Poirier
On Mon, May 20, 2024 at 01:27:24PM +0200, AngeloGioacchino Del Regno wrote: > In scp_ipi_handler(), instead of zeroing out the entire shared > buffer, which may be as large as 600 bytes, overwrite it with the > received data, then zero out only the remaining bytes. > > Signed-off-by:

Re: [PATCH v3 2/2] remoteproc: k3-r5: Do not allow core1 to power up before core0 via sysfs

2024-05-20 Thread Mathieu Poirier
On Sat, 18 May 2024 at 04:44, Christophe JAILLET wrote: > > Le 30/04/2024 à 12:53, Beleswar Padhi a écrit : > > PSC controller has a limitation that it can only power-up the second > > core when the first core is in ON state. Power-state for core0 should be > > equal to or higher than core1. > >

Re: [PATCH v9 2/5] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2024-05-10 Thread Mathieu Poirier
On Thu, May 09, 2024 at 10:54:51AM -0500, Andrew Davis wrote: > On 5/9/24 10:22 AM, Mathieu Poirier wrote: > > On Wed, 8 May 2024 at 09:36, Andrew Davis wrote: > > > > > > On 5/6/24 3:46 PM, Mathieu Poirier wrote: > > > > Good day, > > > &

Re: [PATCH v9 2/5] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2024-05-09 Thread Mathieu Poirier
On Wed, 8 May 2024 at 10:54, Andrew Davis wrote: > > On 5/7/24 3:36 PM, Mathieu Poirier wrote: > > On Fri, Apr 26, 2024 at 02:18:08PM -0500, Andrew Davis wrote: > >> From: Martyn Welch > >> > >> The AM62x and AM64x SoCs of the TI K3 family has a Cortex M4F

Re: [PATCH v9 2/5] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2024-05-09 Thread Mathieu Poirier
On Wed, 8 May 2024 at 09:36, Andrew Davis wrote: > > On 5/6/24 3:46 PM, Mathieu Poirier wrote: > > Good day, > > > > I have started reviewing this patchset. Comments will be scattered over > > multiple days and as such, I will explicitly inform you when am

Re: [PATCH v9 2/5] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2024-05-07 Thread Mathieu Poirier
On Fri, Apr 26, 2024 at 02:18:08PM -0500, Andrew Davis wrote: > From: Martyn Welch > > The AM62x and AM64x SoCs of the TI K3 family has a Cortex M4F core in > the MCU domain. This core is typically used for safety applications in a > stand alone mode. However, some application (non safety

Re: [PATCH v9 2/5] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem

2024-05-06 Thread Mathieu Poirier
Good day, I have started reviewing this patchset. Comments will be scattered over multiple days and as such, I will explicitly inform you when am done with the review. On Fri, Apr 26, 2024 at 02:18:08PM -0500, Andrew Davis wrote: > From: Martyn Welch > > The AM62x and AM64x SoCs of the TI K3

Re: [PATCH] remoteproc: k3-r5: Jump to error handling labels in start/stop errors

2024-05-06 Thread Mathieu Poirier
On Mon, May 06, 2024 at 07:48:49PM +0530, Beleswar Padhi wrote: > In case of errors during core start operation from sysfs, the driver > directly returns with the -EPERM error code. Fix this to ensure that > mailbox channels are freed on error before returning by jumping to the > 'put_mbox' error

Re: [PATCH v3 0/2] remoteproc: k3-r5: Wait for core0 power-up before powering up core1

2024-04-30 Thread Mathieu Poirier
On Tue, Apr 30, 2024 at 04:23:05PM +0530, Beleswar Padhi wrote: > PSC controller has a limitation that it can only power-up the second core > when the first core is in ON state. Power-state for core0 should be equal > to or higher than core1, else the kernel is seen hanging during rproc > loading.

Re: [PATCH v4 0/4] Support MT8188 SCP core 1

2024-04-30 Thread Mathieu Poirier
On Tue, Apr 30, 2024 at 09:15:30AM +0800, Olivia Wen wrote: > Change in v4: > Updating the description of PATCH v4 4/4. > > Olivia Wen (4): > dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP > remoteproc: mediatek: Support MT8188 SCP core 1 > remoteproc: mediatek: Support

Re: [PATCH v2 1/2] remoteproc: k3-r5: Wait for core0 power-up before powering up core1

2024-04-26 Thread Mathieu Poirier
Good day, On Wed, Apr 24, 2024 at 06:35:03PM +0530, Beleswar Padhi wrote: > From: Apurva Nandan > > PSC controller has a limitation that it can only power-up the second core > when the first core is in ON state. Power-state for core0 should be equal > to or higher than core1, else the kernel is

Re: [PATCH v3 4/4] media: mediatek: imgsys: Support image processing

2024-04-24 Thread Mathieu Poirier
On Wed, Apr 24, 2024 at 12:04:54PM +0200, AngeloGioacchino Del Regno wrote: > Il 24/04/24 12:02, AngeloGioacchino Del Regno ha scritto: > > Il 24/04/24 05:03, Olivia Wen ha scritto: > > > Integrate the imgsys core architecture driver for image processing on > > > the MT8188 platform. > > > > > >

Re: [PATCH] drivers: remoteproc: xlnx: fix uninitialize variable use

2024-04-23 Thread Mathieu Poirier
On Tue, Apr 23, 2024 at 10:02:11AM -0700, Tanmay Shah wrote: > Fix following warning for clang compiler with W=1 option: > initialize the variable 'ret' to silence this warning > 907 | int ret, i; > |^ > | = 0 > > Fixes: a6b974b40f94

Re: [PATCH] drivers: remoteproc: xlnx: Add Versal and Versal-NET support

2024-04-22 Thread Mathieu Poirier
On Thu, Apr 18, 2024 at 03:01:25PM -0700, Tanmay Shah wrote: > AMD-Xilinx Versal platform is successor of ZynqMP platform. > Real-time Processing Unit R5 cluster IP on Versal is same as > of ZynqMP Platform. Power-domains ids for Versal platform is > different than ZynqMP. > > AMD-Xilinx

Re: [PATCH v2 2/2] remoteproc: mediatek: Support MT8188 SCP core 1

2024-04-22 Thread Mathieu Poirier
Hi Olivia, On Fri, Apr 19, 2024 at 04:42:11PM +0800, Olivia Wen wrote: > From: "olivia.wen" > > There are three primary modifications. > > 1. The struct mtk_scp_of_data usage on MT8188 > MT8192 functions are unsuitable for the dual-core MT8188 SCP, > which has two RISC-V cores similar to

Re: [PATCH v15 0/4] add zynqmp TCM bindings

2024-04-16 Thread Mathieu Poirier
On Fri, Apr 12, 2024 at 11:37:04AM -0700, Tanmay Shah wrote: > Tightly-Coupled Memories(TCMs) are low-latency memory that provides > predictable instruction execution and predictable data load/store > timing. Each Cortex-R5F processor contains exclusive two 64 KB memory > banks on the ATCM and

Re: [PATCH v15 3/4] dts: zynqmp: add properties for TCM in remoteproc

2024-04-16 Thread Mathieu Poirier
gt; > Signed-off-by: Tanmay Shah > --- > .../boot/dts/xilinx/zynqmp-zcu102-rev1.0.dts | 8 +++ > arch/arm64/boot/dts/xilinx/zynqmp.dtsi| 67 +-- > 2 files changed, 70 insertions(+), 5 deletions(-) > Reviewed-by: Mathieu Poirier > diff --git a/arch/ar

Re: [PATCH v14 4/4] remoteproc: zynqmp: parse TCM from device tree

2024-04-11 Thread Mathieu Poirier
On Wed, Apr 10, 2024 at 05:36:30PM -0500, Tanmay Shah wrote: > > > On 4/10/24 11:59 AM, Mathieu Poirier wrote: > > On Mon, Apr 08, 2024 at 01:53:14PM -0700, Tanmay Shah wrote: > >> ZynqMP TCM information was fixed in driver. Now ZynqMP TCM information > >> is av

Re: [PATCH v14 4/4] remoteproc: zynqmp: parse TCM from device tree

2024-04-10 Thread Mathieu Poirier
On Mon, Apr 08, 2024 at 01:53:14PM -0700, Tanmay Shah wrote: > ZynqMP TCM information was fixed in driver. Now ZynqMP TCM information > is available in device-tree. Parse TCM information in driver > as per new bindings. > > Signed-off-by: Tanmay Shah > --- > > Changes in v14: > - Add Versal

Re: [PATCH 2/2] remoteproc: mediatek: Don't parse extraneous subnodes for multi-core

2024-04-02 Thread Mathieu Poirier
On Tue, 2 Apr 2024 at 03:56, AngeloGioacchino Del Regno wrote: > > Il 28/03/24 15:38, Mathieu Poirier ha scritto: > > On Wed, Mar 27, 2024 at 01:49:58PM +0100, AngeloGioacchino Del Regno wrote: > >> Il 21/03/24 16:27, Mathieu Poirier ha scritto: > >>> On Thu,

Re: [PATCH 1/3] remoteproc: k3-dsp: Fix usage of omap_mbox_message and mbox_msg_t

2024-04-01 Thread Mathieu Poirier
On Thu, Mar 28, 2024 at 11:26:24AM -0500, Andrew Davis wrote: > On 3/28/24 10:28 AM, Mathieu Poirier wrote: > > Hi Andrew, > > > > On Mon, Mar 25, 2024 at 11:58:06AM -0500, Andrew Davis wrote: > > > The type of message sent using omap-mailbox is always u32. The

Re: [PATCH v4 1/4] remoteproc: Add TEE support

2024-04-01 Thread Mathieu Poirier
On Fri, Mar 29, 2024 at 09:58:11AM +0100, Arnaud POULIQUEN wrote: > Hello Mathieu, > > On 3/27/24 18:07, Mathieu Poirier wrote: > > On Tue, Mar 26, 2024 at 08:18:23PM +0100, Arnaud POULIQUEN wrote: > >> Hello Mathieu, > >> > >> On 3/25/24 17:46, Mathieu

Re: [PATCH v4 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-04-01 Thread Mathieu Poirier
On Fri, Mar 29, 2024 at 11:57:43AM +0100, Arnaud POULIQUEN wrote: > > > On 3/27/24 18:14, Mathieu Poirier wrote: > > On Tue, Mar 26, 2024 at 08:31:33PM +0100, Arnaud POULIQUEN wrote: > >> > >> > >> On 3/25/24 17:51, Mathieu Poirier wrote: > >>

Re: [PATCH 1/3] remoteproc: k3-dsp: Fix usage of omap_mbox_message and mbox_msg_t

2024-03-28 Thread Mathieu Poirier
Hi Andrew, On Mon, Mar 25, 2024 at 11:58:06AM -0500, Andrew Davis wrote: > The type of message sent using omap-mailbox is always u32. The definition > of mbox_msg_t is uintptr_t which is wrong as that type changes based on > the architecture (32bit vs 64bit). Use u32 unconditionally and remove >

Re: [PATCH 2/2] remoteproc: mediatek: Don't parse extraneous subnodes for multi-core

2024-03-28 Thread Mathieu Poirier
On Wed, Mar 27, 2024 at 01:49:58PM +0100, AngeloGioacchino Del Regno wrote: > Il 21/03/24 16:27, Mathieu Poirier ha scritto: > > On Thu, Mar 21, 2024 at 09:46:14AM +0100, AngeloGioacchino Del Regno wrote: > > > When probing multi-core SCP, this driver is parsing all sub-node

Re: [PATCH v4 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-03-27 Thread Mathieu Poirier
On Tue, Mar 26, 2024 at 08:31:33PM +0100, Arnaud POULIQUEN wrote: > > > On 3/25/24 17:51, Mathieu Poirier wrote: > > On Fri, Mar 08, 2024 at 03:47:08PM +0100, Arnaud Pouliquen wrote: > >> The new TEE remoteproc device is used to manage remote firmware in a > >>

Re: [PATCH v4 1/4] remoteproc: Add TEE support

2024-03-27 Thread Mathieu Poirier
On Tue, Mar 26, 2024 at 08:18:23PM +0100, Arnaud POULIQUEN wrote: > Hello Mathieu, > > On 3/25/24 17:46, Mathieu Poirier wrote: > > On Fri, Mar 08, 2024 at 03:47:05PM +0100, Arnaud Pouliquen wrote: > >> Add a remoteproc TEE (Trusted Execution Environment) driver

Re: [PATCH 1/3] remoteproc: Add Arm remoteproc driver

2024-03-26 Thread Mathieu Poirier
On Mon, 25 Mar 2024 at 11:13, Abdellatif El Khlifi wrote: > > Hi Mathieu, > > > > > > > > > > This is an initial patchset for allowing to turn on and off > > > > > > > > > the remote processor. > > > > > > > > > The FW is already loaded before the Corstone-1000 SoC is > > > > > > > > > powered

Re: [PATCH v4 3/4] remoteproc: stm32: Create sub-functions to request shutdown and release

2024-03-25 Thread Mathieu Poirier
On Fri, Mar 08, 2024 at 03:47:07PM +0100, Arnaud Pouliquen wrote: > To prepare for the support of TEE remoteproc, create sub-functions > that can be used in both cases, with and without TEE support. > > Signed-off-by: Arnaud Pouliquen > --- > drivers/remoteproc/stm32_rproc.c | 84

Re: [PATCH v4 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-03-25 Thread Mathieu Poirier
On Fri, Mar 08, 2024 at 03:47:08PM +0100, Arnaud Pouliquen wrote: > The new TEE remoteproc device is used to manage remote firmware in a > secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is > introduced to delegate the loading of the firmware to the trusted > execution context. In

Re: [PATCH v4 1/4] remoteproc: Add TEE support

2024-03-25 Thread Mathieu Poirier
On Fri, Mar 08, 2024 at 03:47:05PM +0100, Arnaud Pouliquen wrote: > Add a remoteproc TEE (Trusted Execution Environment) driver > that will be probed by the TEE bus. If the associated Trusted > application is supported on secure part this device offers a client Device or driver? I thought I

Re: [PATCH 2/2] remoteproc: mediatek: Don't parse extraneous subnodes for multi-core

2024-03-21 Thread Mathieu Poirier
On Thu, Mar 21, 2024 at 09:46:14AM +0100, AngeloGioacchino Del Regno wrote: > When probing multi-core SCP, this driver is parsing all sub-nodes of > the scp-cluster node, but one of those could be not an actual SCP core > and that would make the entire SCP cluster to fail probing for no good >

Re: [PATCH 1/2] remoteproc: mediatek: Make sure IPI buffer fits in L2TCM

2024-03-21 Thread Mathieu Poirier
Good day, On Thu, Mar 21, 2024 at 09:46:13AM +0100, AngeloGioacchino Del Regno wrote: > The IPI buffer location is read from the firmware that we load to the > System Companion Processor, and it's not granted that both the SRAM > (L2TCM) size that is defined in the devicetree node is large enough

Re: [PATCH 1/3] remoteproc: Add Arm remoteproc driver

2024-03-14 Thread Mathieu Poirier
On Thu, 14 Mar 2024 at 08:59, Sudeep Holla wrote: > > On Thu, Mar 14, 2024 at 08:52:59AM -0600, Mathieu Poirier wrote: > > On Wed, Mar 13, 2024 at 05:17:56PM +, Abdellatif El Khlifi wrote: > > > Hi Mathieu, > > > > > > On Wed, Mar 13, 2024 at

Re: [PATCH 1/3] remoteproc: Add Arm remoteproc driver

2024-03-14 Thread Mathieu Poirier
On Wed, Mar 13, 2024 at 05:17:56PM +, Abdellatif El Khlifi wrote: > Hi Mathieu, > > On Wed, Mar 13, 2024 at 10:25:32AM -0600, Mathieu Poirier wrote: > > On Tue, Mar 12, 2024 at 05:32:52PM +, Abdellatif El Khlifi wrote: > > > Hi Mathieu, > > > > &g

Re: [PATCH 1/3] remoteproc: Add Arm remoteproc driver

2024-03-13 Thread Mathieu Poirier
On Tue, Mar 12, 2024 at 05:32:52PM +, Abdellatif El Khlifi wrote: > Hi Mathieu, > > On Tue, Mar 12, 2024 at 10:29:52AM -0600, Mathieu Poirier wrote: > > > This is an initial patchset for allowing to turn on and off the remote > > > processor. > >

Re: [PATCH 1/3] remoteproc: Add Arm remoteproc driver

2024-03-12 Thread Mathieu Poirier
On Mon, 11 Mar 2024 at 05:44, Abdellatif El Khlifi wrote: > > Hi Mathieu, > > On Fri, Mar 08, 2024 at 09:44:26AM -0700, Mathieu Poirier wrote: > > On Thu, 7 Mar 2024 at 12:40, Abdellatif El Khlifi > > wrote: > > > > > > Hi Mathieu, > > > > &g

Re: [PATCH] remoteproc: make rproc_class constant

2024-03-11 Thread Mathieu Poirier
Hi Ricardo, On Tue, Mar 05, 2024 at 04:40:23PM -0300, Ricardo B. Marliere wrote: > Since commit 43a7206b0963 ("driver core: class: make class_register() take > a const *"), the driver core allows for struct class to be in read-only > memory, so move the rproc_class structure to be declared at

Re: [PATCH 1/3] remoteproc: Add Arm remoteproc driver

2024-03-08 Thread Mathieu Poirier
On Thu, 7 Mar 2024 at 12:40, Abdellatif El Khlifi wrote: > > Hi Mathieu, > > > > + do { > > > + state_reg = readl(priv->reset_cfg.state_reg); > > > + *rst_ack = EXTSYS_RST_ST_RST_ACK(state_reg); > > > + > > > + if (*rst_ack == EXTSYS_RST_ACK_RESERVED) { > > > +

Re: [PATCH 1/3] remoteproc: Add Arm remoteproc driver

2024-03-04 Thread Mathieu Poirier
Good day Abdellatif, On Fri, Mar 01, 2024 at 04:42:25PM +, abdellatif.elkhl...@arm.com wrote: > From: Abdellatif El Khlifi > > introduce remoteproc support for Arm remote processors > > The supported remote processors are those that come with a reset > control register and a reset status

Re: [PATCH v3 1/7] remoteproc: Add TEE support

2024-02-29 Thread Mathieu Poirier
Good morning, On Wed, Feb 28, 2024 at 09:20:28AM +0100, Arnaud POULIQUEN wrote: > Hello Mathieu, > > > On 2/23/24 19:27, Mathieu Poirier wrote: > > On Wed, Feb 14, 2024 at 06:21:21PM +0100, Arnaud Pouliquen wrote: > >> From: Arnaud Pouliquen > >> > >

Re: [PATCH v11 1/4] remoteproc: zynqmp: fix lockstep mode memory region

2024-02-28 Thread Mathieu Poirier
On Wed, 28 Feb 2024 at 12:24, Tanmay Shah wrote: > > > On 2/28/24 11:08 AM, Mathieu Poirier wrote: > > On Mon, Feb 19, 2024 at 09:44:34AM -0800, Tanmay Shah wrote: > > > In lockstep mode, r5 core0 uses TCM of R5 core1. Following is lockstep > > > mode memory

  1   2   3   4   5   6   7   8   9   10   >