Re: [PATCH] coresight: Remove unnecessary THIS_MODULE of funnel and replicator driver

2020-11-03 Thread Mathieu Poirier
On Tue, Nov 03, 2020 at 09:21:48PM +0800, Qi Liu wrote: > As THIS_MODULE has been set in platform_driver_register(), so remove it > from static funnel driver and static replicator driver to avoid set it > twice. > > Signed-off-by: Qi Liu > --- > drivers/hwtracing/coresight/coresight-funnel.c

Re: [PATCH v3 06/26] coresight: etm4x: Handle access to TRCSSPCICRn

2020-11-02 Thread Mathieu Poirier
Hi Suzuki, On Wed, Oct 28, 2020 at 10:09:25PM +, Suzuki K Poulose wrote: > TRCSSPCICR is present only if all of the following are true: > TRCIDR4.NUMSSCC > n. > TRCIDR4.NUMPC > 0b . > TRCSSCSR.PC == 0b1 > > Signed-off-by: Suzuki K Poulose > --- >

Re: [PATCH AUTOSEL 5.9 075/147] coresight: Make sysfs functional on topologies with per core sink

2020-11-02 Thread Mathieu Poirier
he given source, > > instead of bus based search. > > With sink selection using sysfs depecrated for perf interface, > > provision for reset is removed as well in this API. > > > > Signed-off-by: Linu Cherian > > [Fixed indentation problem and removed obsolete comment] >

Re: [PATCH] coresight: funnel: Remove unnecessary .owner of static funnel driver

2020-11-02 Thread Mathieu Poirier
Hi Liu, On Sat, Oct 31, 2020 at 06:12:30PM +0800, Qi Liu wrote: > As driver.owner has been set in platform_driver_register(), it is > unnecessary to set it in static funnel driver, so remove it from > struct static_funnel_driver. > > Signed-off-by: Qi Liu > --- >

Re: [PATCHv2 2/4] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf()

2020-10-30 Thread Mathieu Poirier
On Fri, Oct 30, 2020 at 01:29:56PM +0530, Sai Prakash Ranjan wrote: > Hello guys, > > On 2020-10-24 02:07, Mathieu Poirier wrote: > > On Fri, Oct 23, 2020 at 03:44:16PM +0200, Peter Zijlstra wrote: > > > On Fri, Oct 23, 2020 at 02:29:54PM +0100, Suzuki Poulose wrote: >

Re: [PATCH v2 31/39] docs: ABI: cleanup several ABI documents

2020-10-30 Thread Mathieu Poirier
-papr-pmem > Signed-off-by: Mauro Carvalho Chehab > --- > .../testing/sysfs-bus-coresight-devices-etb10 | 5 +- For the CoreSight part: Reviewed-by: Mathieu Poirier

Re: [PATCH 1/2] coresight: cti: Initialize dynamic sysfs attributes

2020-10-30 Thread Mathieu Poirier
On Thu, Oct 29, 2020 at 08:10:11PM +0100, Greg KH wrote: > On Thu, Oct 29, 2020 at 10:45:58AM -0600, Mathieu Poirier wrote: > > From: Suzuki K Poulose > > > > With LOCKDEP enabled, CTI driver triggers the following splat due > > to uninitialized lock class for dyna

Re: [PATCH v19 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-29 Thread Mathieu Poirier
On Mon, Oct 19, 2020 at 03:40:07PM -0700, Ben Levinsky wrote: > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this > remotproc driver, we can boot the R5 sub-system in different 2 > configurations - > * split > * lock-step > > The Xilinx R5 Remoteproc Driver boots the

Re: [PATCH v19 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings

2020-10-29 Thread Mathieu Poirier
On Mon, Oct 19, 2020 at 03:40:06PM -0700, Ben Levinsky wrote: > Add binding for ZynqMP R5 OpenAMP. > > Represent the RPU domain resources in one device node. Each RPU > processor is a subnode of the top RPU domain node. > > Signed-off-by: Jason Wu > Signed-off-by: Wendy Liang > Signed-off-by:

Re: [PATCH v19 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-10-29 Thread Mathieu Poirier
Hi Ben, On Mon, Oct 19, 2020 at 03:40:07PM -0700, Ben Levinsky wrote: > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this > remotproc driver, we can boot the R5 sub-system in different 2 > configurations - > * split > * lock-step > > The Xilinx R5 Remoteproc Driver

Re: [PATCH -next] coresight: core: Remove unneeded semicolon

2020-10-29 Thread Mathieu Poirier
Hi Wei, On Thu, Oct 29, 2020 at 10:25:48AM +0800, Zou Wei wrote: > Fixes coccicheck warning: > > ./drivers/hwtracing/coresight/coresight-core.c:421:4-5: Unneeded semicolon > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- > drivers/hwtracing/coresight/coresight-core.c | 2 +- > 1

[PATCH 2/2] coresight: Fix uninitialised pointer bug in etm_setup_aux()

2020-10-29 Thread Mathieu Poirier
Mike Leach Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c index c2c9b127d074..bdc34ca449f

[PATCH 1/2] coresight: cti: Initialize dynamic sysfs attributes

2020-10-29 Thread Mathieu Poirier
y: Leo Yan Tested-by: Leo Yan Cc: Mike Leach Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-cti-sysfs.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c

[PATCH 0/2] coresight: Fixes for v5.10-rc2

2020-10-29 Thread Mathieu Poirier
Hi Greg, Please consider those when collecting fixes for this cycle. Thanks, Mathieu Mike Leach (1): coresight: Fix uninitialised pointer bug in etm_setup_aux() Suzuki K Poulose (1): coresight: cti: Initialize dynamic sysfs attributes drivers/hwtracing/coresight/coresight-cti-sysfs.c | 7

Re: [PATCH] coresight: Fix uninitialised pointer bug in etm_setup_aux()

2020-10-29 Thread Mathieu Poirier
On Wed, Oct 28, 2020 at 05:43:01PM +, Mike Leach wrote: > Commit [bb1860efc817] changed the sink handling code introducing an > uninitialised pointer bug. This results in the default sink selection > failing. > > Prior to commit: > > static void etm_setup_aux(...) > > > struct

[PATCH v4 0/8] rpmsg: Make RPMSG name service modular

2020-10-27 Thread Mathieu Poirier
creation internal API rpmsg: virtio: Add rpmsg channel device ops rpmsg: Turn name service into a stand alone driver Mathieu Poirier (4): rpmsg: Introduce __rpmsg{16|32|64} types rpmsg: virtio: Move from virtio to rpmsg byte conversion rpmsg: Move structure rpmsg_ns_msg to header file

[PATCH v4 6/8] rpmsg: virtio: Add rpmsg channel device ops

2020-10-27 Thread Mathieu Poirier
From: Arnaud Pouliquen Implement the create and release of the RPMsg channel for the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg/virtio_rpmsg_bus.c | 22 ++ 1 file changed, 22

[PATCH v4 8/8] rpmsg: Turn name service into a stand alone driver

2020-10-27 Thread Mathieu Poirier
From: Arnaud Pouliquen Make the RPMSG name service announcement a stand alone driver so that it can be reused by other subsystems. It is also the first step in making the functionatlity transport independent, i.e that is not tied to virtIO. Co-developed-by: Mathieu Poirier Signed-off

[PATCH v4 1/8] rpmsg: Introduce __rpmsg{16|32|64} types

2020-10-27 Thread Mathieu Poirier
Introduce __rpmsg{16|32|64} types along with byte order conversion functions based on an rpmsg_device operation as a foundation to make RPMSG modular and transport agnostic. Suggested-by: Guennadi Liakhovetski Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- include/linux

[PATCH v4 4/8] rpmsg: virtio: Rename rpmsg_create_channel

2020-10-27 Thread Mathieu Poirier
From: Arnaud Pouliquen Rename the internal function as it is internal, and as the name will be used in rpmsg_core. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg/virtio_rpmsg_bus.c | 6 +++--- 1 file changed, 3 insertions

[PATCH v4 7/8] rpmsg: Make rpmsg_{register|unregister}_device() public

2020-10-27 Thread Mathieu Poirier
Make function rpmsg_register_device() and rpmsg_unregister_device() functions public so that they can be used by other clients. While doing so get rid of two obsolete function, i.e register_rpmsg_device() and unregister_rpmsg_device(), to prevent confusion. Signed-off-by: Mathieu Poirier

[PATCH v4 5/8] rpmsg: core: Add channel creation internal API

2020-10-27 Thread Mathieu Poirier
From: Arnaud Pouliquen Add the channel creation API as a first step to be able to define the name service announcement as a rpmsg driver independent from the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg

[PATCH v4 2/8] rpmsg: virtio: Move from virtio to rpmsg byte conversion

2020-10-27 Thread Mathieu Poirier
Use rpmsg byte conversion functions in order for the RPMSG headers and generic functions to be used by external entities. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 53 +--- 1 file changed, 28 insertions

[PATCH v4 3/8] rpmsg: Move structure rpmsg_ns_msg to header file

2020-10-27 Thread Mathieu Poirier
Move structure rpmsg_ns_msg to its own header file so that it can be used by other entities. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 32 +--- include/linux/rpmsg_ns.h | 42

Re: [PATCH 1/2] hwtracing: coresight: add missing MODULE_LICENSE()

2020-10-27 Thread Mathieu Poirier
coresight-core.c > b/drivers/hwtracing/coresight/coresight-core.c > index 6994c1309b2b..7936fca8436c 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -1692,3 +1692,4 @@ module_exit(coresight_exit); > MODULE_A

Re: [PATCHv2 2/4] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf()

2020-10-23 Thread Mathieu Poirier
On Fri, Oct 23, 2020 at 03:44:16PM +0200, Peter Zijlstra wrote: > On Fri, Oct 23, 2020 at 02:29:54PM +0100, Suzuki Poulose wrote: > > On 10/23/20 2:16 PM, Peter Zijlstra wrote: > > > On Fri, Oct 23, 2020 at 01:56:47PM +0100, Suzuki Poulose wrote: > > > > > That way another session could use the

Re: [PATCH 07/13] remoteproc: Introduce function rproc_detach()

2020-10-22 Thread Mathieu Poirier
sor without stopping its > > operation. > > > > Signed-off-by: Mathieu Poirier > > --- > > drivers/remoteproc/remoteproc_core.c | 65 > > +++- > > include/linux/remoteproc.h | 1 + > > 2 files changed, 65 insertions(+),

Re: [PATCH 05/13] remoteproc: Add new detach() remoteproc operation

2020-10-22 Thread Mathieu Poirier
eproc core is going away but the remote processor is kept operating. > > This could be the case when the system is rebooted or when the platform > > driver is removed. > > > > Signed-off-by: Mathieu Poirier > > --- > > include/linux/remoteproc.h | 2 ++ > > 1

Re: [PATCHv2 2/4] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf()

2020-10-22 Thread Mathieu Poirier
Hi Peter, On Thu, Oct 22, 2020 at 04:32:36PM +0100, Suzuki Poulose wrote: > On 10/22/20 4:06 PM, Peter Zijlstra wrote: > > On Thu, Oct 22, 2020 at 02:30:21PM +0100, Suzuki Poulose wrote: > > > On 10/22/20 12:32 PM, Peter Zijlstra wrote: > > > > On Thu, Oct 22, 2020 at 04:27:52PM +0530, Sai

Re: [PATCH v4] remoteproc/mediatek: Add support for mt8192 SCP

2020-10-21 Thread Mathieu Poirier
Hi Shih, On Wed, 14 Oct 2020 at 23:35, Pi-Hsun Shih wrote: > > Add support for mt8192 SCP. > This is a very thin changelog. I wouldn't be surprised if you get asked to beef it up. > Signed-off-by: Pi-Hsun Shih > Reviewed-by: Tzung-Bi Shih > > --- > > Change since v3: > * Remove unnecessary

[PATCH v3 6/8] rpmsg: virtio: Add rpmsg channel device ops

2020-10-19 Thread Mathieu Poirier
From: Arnaud Pouliquen Implement the create and release of the RPMsg channel for the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg/virtio_rpmsg_bus.c | 22 ++ 1 file changed, 22

[PATCH v3 8/8] rpmsg: Turn name service into a stand alone driver

2020-10-19 Thread Mathieu Poirier
From: Arnaud Pouliquen Make the RPMSG name service announcement a stand alone driver so that it can be reused by other subsystems. It is also the first step in making the functionatlity transport independent, i.e that is not tied to virtIO. Co-developed-by: Mathieu Poirier Signed-off

[PATCH v3 5/8] rpmsg: core: Add channel creation internal API

2020-10-19 Thread Mathieu Poirier
From: Arnaud Pouliquen Add the channel creation API as a first step to be able to define the name service announcement as a rpmsg driver independent from the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg

[PATCH v3 7/8] rpmsg: Make rpmsg_{register|unregister}_device() public

2020-10-19 Thread Mathieu Poirier
Make function rpmsg_register_device() and rpmsg_unregister_device() functions public so that they can be used by other clients. While doing so get rid of two obsolete function, i.e register_rpmsg_device() and unregister_rpmsg_device(), to prevent confusion. Signed-off-by: Mathieu Poirier

[PATCH v3 4/8] rpmsg: virtio: Rename rpmsg_create_channel

2020-10-19 Thread Mathieu Poirier
From: Arnaud Pouliquen Rename the internal function as it is internal, and as the name will be used in rpmsg_core. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg/virtio_rpmsg_bus.c | 6 +++--- 1 file changed, 3 insertions

[PATCH v3 2/8] rpmsg: virtio: Move from virtio to rpmsg byte conversion

2020-10-19 Thread Mathieu Poirier
Use rpmsg byte conversion functions in order for the RPMSG headers and generic functions to be used by external entities. Signed-off-by: Mathieu Poirier --- drivers/rpmsg/virtio_rpmsg_bus.c | 53 +--- 1 file changed, 28 insertions(+), 25 deletions(-) diff --git

[PATCH v3 0/8] rpmsg: Make RPMSG name service modular

2020-10-19 Thread Mathieu Poirier
creation internal API rpmsg: virtio: Add rpmsg channel device ops rpmsg: Turn name service into a stand alone driver Mathieu Poirier (4): rpmsg: Introduce __rpmsg{16|32|64} types rpmsg: virtio: Move from virtio to rpmsg byte conversion rpmsg: Move structure rpmsg_ns_msg to header file

[PATCH v3 1/8] rpmsg: Introduce __rpmsg{16|32|64} types

2020-10-19 Thread Mathieu Poirier
Introduce __rpmsg{16|32|64} types along with byte order conversion functions based on an rpmsg_device operation as a foundation to make RPMSG modular and transport agnostic. Suggested-by: Guennadi Liakhovetski Signed-off-by: Mathieu Poirier --- include/linux/rpmsg.h| 51

[PATCH v3 3/8] rpmsg: Move structure rpmsg_ns_msg to header file

2020-10-19 Thread Mathieu Poirier
Move structure rpmsg_ns_msg to its own header file so that it can be used by other entities. Signed-off-by: Mathieu Poirier --- drivers/rpmsg/virtio_rpmsg_bus.c | 32 +--- include/linux/rpmsg_ns.h | 42 2 files changed, 43 insertions

Re: [PATCH V2 7/7] remoteproc: imx_proc: enable virtio/mailbox

2020-10-19 Thread Mathieu Poirier
On Sun, Sep 27, 2020 at 02:41:31PM +0800, Peng Fan wrote: > Use virtio/mailbox to build connection between Remote Proccessors > and Linux. Add delayed work to handle incoming messages. > > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 112

Re: [PATCH V2 6/7] remoteproc: imx_rproc: support i.MX8MQ/M

2020-10-19 Thread Mathieu Poirier
IMX7D_M4_RST_MASK, > @@ -517,6 +555,8 @@ static int imx_rproc_remove(struct platform_device *pdev) > static const struct of_device_id imx_rproc_of_match[] = { > { .compatible = "fsl,imx7d-cm4", .data = _rproc_cfg_imx7d }, > { .compatible

Re: [PATCH V2 5/7] remoteproc: imx_rproc: add i.MX specific parse fw hook

2020-10-19 Thread Mathieu Poirier
->name, "vdevbuffer")) { > + index ++; How many vdevs is there in your scenario? Since most of this code is taken from stm32 anyway I would suggest to use "vdev0buffer" and get rid of the "index ++". It adds needless comple

Re: [PATCH V2 4/7] remoteproc: imx_rproc: use devm_ioremap

2020-10-19 Thread Mathieu Poirier
On Sun, Sep 27, 2020 at 02:41:28PM +0800, Peng Fan wrote: > We might need to map an region multiple times, becaue the region might > be shared between remote processors, such i.MX8QM with dual M4 cores. > So use devm_ioremap, not devm_ioremap_resource. > > Reviewed-by: Oleksij Rempel >

Re: [PATCH V2 1/7] remoteproc: elf: support platform specific memory hook

2020-10-19 Thread Mathieu Poirier
6 +392,8 @@ struct rproc_ops { > int (*load)(struct rproc *rproc, const struct firmware *fw); > int (*sanity_check)(struct rproc *rproc, const struct firmware *fw); > u64 (*get_boot_addr)(struct rproc *rproc, const struct firmware *fw); > + void (*elf_memcpy)(struct

Re: [PATCH] coresight: etm4x: Skip setting LPOVERRIDE bit for qcom,skip-power-up

2020-10-16 Thread Mathieu Poirier
On Fri, Oct 16, 2020 at 03:40:25PM +0530, Sai Prakash Ranjan wrote: > There is a bug on the systems supporting to skip power up > (qcom,skip-power-up) where setting LPOVERRIDE bit(low-power > state override behaviour) will result in CPU hangs/lockups > even on the implementations which supports

Re: [PATCH v2 4/9] rpmsg: Move rpmsg_hr and rpmsg_ns_msg to header file

2020-10-15 Thread Mathieu Poirier
On Thu, Oct 15, 2020 at 10:33:25AM +0200, Arnaud POULIQUEN wrote: > Hi Mathieu, > > On 10/14/20 1:25 AM, Mathieu Poirier wrote: > > Move structures rpmsg_hdr and rpmsg_ns_msg to their own header file > > so that they can be used by other entities. > > > &g

Re: [PATCH v2 3/9] rpmsg: virtio: Move from virtio to rpmsg byte conversion

2020-10-15 Thread Mathieu Poirier
On Wed, Oct 14, 2020 at 07:04:32PM +0200, Arnaud POULIQUEN wrote: > > > On 10/14/20 1:25 AM, Mathieu Poirier wrote: > > Use rpmsg byte conversion functions in order for the RPMSG > > headers and generic functions to be used by external entities. > > > &g

Re: [PATCH v2 2/9] rpmsg: Introduce __rpmsg{16|32|64} types

2020-10-15 Thread Mathieu Poirier
Good day, On Wed, Oct 14, 2020 at 06:31:49PM +0200, Arnaud POULIQUEN wrote: > Hi Mathieu, > > On 10/14/20 1:25 AM, Mathieu Poirier wrote: > > Introduce __rpmsg{16|32|64} types along with byte order conversion > > functions based on an rpmsg_device operation as a foundat

Re: [RFC PATCH 1/4] Add a RPMSG driver for the APU in the mt8183

2020-10-15 Thread Mathieu Poirier
On Wed, Oct 14, 2020 at 04:55:34PM -0600, Mathieu Poirier wrote: > Hi Alexandre, > > On Wed, Sep 30, 2020 at 01:53:47PM +0200, Alexandre Bailon wrote: > > This adds a driver to communicate with the APU available > > in the mt8183. The driver is generic and could

Re: [PATCH] coresight: etm4x: Add config to exclude kernel mode tracing

2020-10-15 Thread Mathieu Poirier
On Thu, Oct 15, 2020 at 06:15:22PM +0530, Sai Prakash Ranjan wrote: > On production systems with ETMs enabled, it is preferred to > exclude kernel mode(NS EL1) tracing for security concerns and > support only userspace(NS EL0) tracing. So provide an option > via kconfig to exclude kernel mode

Re: [RFC PATCH 1/4] Add a RPMSG driver for the APU in the mt8183

2020-10-14 Thread Mathieu Poirier
Hi Alexandre, On Wed, Sep 30, 2020 at 01:53:47PM +0200, Alexandre Bailon wrote: > This adds a driver to communicate with the APU available > in the mt8183. The driver is generic and could be used for other APU. > It mostly provides a userspace interface to send messages and > and share big

Re: [PATCH v2 4/4] ARM: dts: stm32: update stm32mp151 for remote proc synchronization support

2020-10-14 Thread Mathieu Poirier
gt; st,syscfg-pdds = <_mcu 0x0 0x1>; > + st,syscfg-rsc-tbl = < 0x144 0x>; > + st,syscfg-m4-state = < 0x148 0x>; Tested-by: Mathieu Poirier > status = "disabled"; > }; > }; > -- > 2.17.1 >

[PATCH v2 1/9] rpmsg: Move rpmsg_endpoint_ops to rpmsg.h

2020-10-14 Thread Mathieu Poirier
Move structure rpmsg_endpoint_ops to header rpmsg.h so that it can be used by other entities. Signed-off-by: Mathieu Poirier --- drivers/rpmsg/rpmsg_internal.h | 19 --- include/linux/rpmsg.h | 24 +--- 2 files changed, 21 insertions(+), 22 deletions

[PATCH v2 0/9] rpmsg: Make RPMSG name service modular

2020-10-14 Thread Mathieu Poirier
ver Mathieu Poirier (5): rpmsg: Move rpmsg_endpoint_ops to rpmsg.h rpmsg: Introduce __rpmsg{16|32|64} types rpmsg: virtio: Move from virtio to rpmsg byte conversion rpmsg: Move rpmsg_hr and rpmsg_ns_msg to header file rpmsg: Make rpmsg_{register|unregister}_device() public drivers/rp

[PATCH v2 8/9] rpmsg: Make rpmsg_{register|unregister}_device() public

2020-10-14 Thread Mathieu Poirier
Make function rpmsg_register_device() and rpmsg_unregister_device() functions public so that they can be used by other clients. While doing so get rid of two obsolete function, i.e register_rpmsg_device() and unregister_rpmsg_device(), to prevent confusion. Signed-off-by: Mathieu Poirier

[PATCH v2 6/9] rpmsg: core: Add channel creation internal API

2020-10-14 Thread Mathieu Poirier
From: Arnaud Pouliquen Add the channel creation API as a first step to be able to define the name service announcement as a rpmsg driver independent from the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier --- drivers/rpmsg/rpmsg_core.c | 44

[PATCH v2 9/9] rpmsg: Turn name service into a stand alone driver

2020-10-14 Thread Mathieu Poirier
From: Arnaud Pouliquen Make the RPMSG name service announcement a stand alone driver so that it can be reused by other subsystems. It is also the first step in making the functionatlity transport independent, i.e that is not tied to virtIO. Co-developed-by: Mathieu Poirier Signed-off

[PATCH v2 4/9] rpmsg: Move rpmsg_hr and rpmsg_ns_msg to header file

2020-10-14 Thread Mathieu Poirier
Move structures rpmsg_hdr and rpmsg_ns_msg to their own header file so that they can be used by other entities. Signed-off-by: Mathieu Poirier --- drivers/rpmsg/virtio_rpmsg_bus.c | 58 ++ include/linux/rpmsg_ns.h | 62

[PATCH v2 7/9] rpmsg: virtio: Add rpmsg channel device ops

2020-10-14 Thread Mathieu Poirier
From: Arnaud Pouliquen Implement the create and release of the RPMsg channel for the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier --- drivers/rpmsg/virtio_rpmsg_bus.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/rpmsg

[PATCH v2 2/9] rpmsg: Introduce __rpmsg{16|32|64} types

2020-10-14 Thread Mathieu Poirier
Introduce __rpmsg{16|32|64} types along with byte order conversion functions based on an rpmsg_device operation as a foundation to make RPMSG modular and transport agnostic. Suggested-by: Guennadi Liakhovetski Signed-off-by: Mathieu Poirier --- include/linux/rpmsg.h| 51

[PATCH v2 3/9] rpmsg: virtio: Move from virtio to rpmsg byte conversion

2020-10-14 Thread Mathieu Poirier
Use rpmsg byte conversion functions in order for the RPMSG headers and generic functions to be used by external entities. Signed-off-by: Mathieu Poirier --- drivers/rpmsg/virtio_rpmsg_bus.c | 60 +++- 1 file changed, 35 insertions(+), 25 deletions(-) diff --git

[PATCH v2 5/9] rpmsg: virtio: Rename rpmsg_create_channel

2020-10-14 Thread Mathieu Poirier
From: Arnaud Pouliquen Rename the internal function as it is internal, and as the name will be used in rpmsg_core. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier --- drivers/rpmsg/virtio_rpmsg_bus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH V2 0/7] remoteproc: imx_rproc: support iMX8MQ/M

2020-10-08 Thread Mathieu Poirier
On Wed, 7 Oct 2020 at 18:52, Peng Fan wrote: > > Mathieu, Oleksij > > > Subject: [PATCH V2 0/7] remoteproc: imx_rproc: support iMX8MQ/M > > Do you have time to give a look at this patchset? I will review your patchset after you have reviewed mine[1]. [1].

Re: [PATCH 10/10] rpmsg: ns: Make Name service module transport agnostic

2020-10-07 Thread Mathieu Poirier
On Wed, Sep 30, 2020 at 09:13:27AM +0200, Guennadi Liakhovetski wrote: > On Mon, Sep 21, 2020 at 06:10:00PM -0600, Mathieu Poirier wrote: > > Make name service module transport agnostic by using the rpmsg > > device specific byte conversion routine. > > > > Sig

Re: [PATCH 05/10] rpmsg: virtio: Move virtio RPMSG structures to private header

2020-10-07 Thread Mathieu Poirier
Hi Guennadi, Apologies for the late reply, I've been away. On Wed, Sep 30, 2020 at 09:03:45AM +0200, Guennadi Liakhovetski wrote: > On Mon, Sep 21, 2020 at 06:09:55PM -0600, Mathieu Poirier wrote: > > Move structure virtiproc_info and virtio_rpmsg_channel to rpmsg_internal.h > > s

Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'

2020-10-06 Thread Mathieu Poirier
source of review issues. > > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/arm/coresight-cti.yaml | 2 ++ For CoreSight: Acked-by: Mathieu Poirier > Documentation/devicetree/bindings/arm/stm32/st,mlahb.yaml| 2 ++ > Documentation/devicetree/bindi

Re: [PATCH v2 3/4] remoteproc: mtk_vpu_rproc: Add support of JTAG

2020-09-29 Thread Mathieu Poirier
On Thu, Sep 10, 2020 at 03:01:47PM +0200, Alexandre Bailon wrote: > The DSP could be debugged using JTAG. > The support of JTAG could enabled at build time and it could be enabled > using debugfs. > > Signed-off-by: Alexandre Bailon > --- > drivers/remoteproc/Kconfig | 9 +++ >

Re: [PATCH v2 2/4] remoteproc: Add a remoteproc driver for the MT8183's APU

2020-09-29 Thread Mathieu Poirier
Hi Alexandre, On Thu, Sep 10, 2020 at 03:01:46PM +0200, Alexandre Bailon wrote: > This adds a driver to control the APU present in the MT8183. > This loads the firmware and start the DSP. > > Signed-off-by: Alexandre Bailon > --- > drivers/remoteproc/Kconfig | 10 ++ >

Re: [PATCH v2 1/4] dt bindings: remoteproc: Add bindings for MT8183 APU

2020-09-29 Thread Mathieu Poirier
On Thu, Sep 10, 2020 at 03:01:45PM +0200, Alexandre Bailon wrote: > This adds dt bindings for the APU present in the MT8183. > > Signed-off-by: Alexandre Bailon > --- > .../bindings/remoteproc/mtk,apu.yaml | 107 ++ > 1 file changed, 107 insertions(+) > create mode

Re: [PATCH 00/10] rpmsg: Make RPMSG name service modular

2020-09-28 Thread Mathieu Poirier
Hey Guennadi, On Mon, Sep 28, 2020 at 11:49:42AM +0200, Guennadi Liakhovetski wrote: > (re-sending, mailing list delivery attempts last Friday failed) > I got your email on Friday but had to tend to other things. > Hi Mathieu, > > On Thu, Sep 24, 2020 at 12:18:53PM -0600,

[PATCH 12/25] coresight: tpiu: Allow tpiu to be built as a module

2020-09-28 Thread Mathieu Poirier
From: Kim Phillips Allow to build coresight-tpiu as a module, for ease of development. - Kconfig becomes a tristate, to allow =m - add a tpiu_remove function, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc

[PATCH 14/25] coresight: funnel: Allow funnel driver to be built as module

2020-09-28 Thread Mathieu Poirier
From: Kim Phillips Allow to build coresight-funnel as module, for ease of development. - combine static and dynamic funnel init into single module_init/exit call - add funnel_remove functions, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier Cc: Leo

[PATCH 13/25] coresight: tmc: Allow tmc to be built as a module

2020-09-28 Thread Mathieu Poirier
a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc: Randy Dunlap Cc: Suzuki K Poulose Cc: Greg Kroah-Hartman Cc: Russell King Signed-off-by: Kim Phillips Signed-off-by: Tingwei Zhang Tested-by: Mike Leach Reviewed-by: Suzuki K Poulose Signed-off

[PATCH 15/25] coresight: replicator: Allow replicator driver to be built as module

2020-09-28 Thread Mathieu Poirier
for autoloading on boot Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc: Randy Dunlap Cc: Suzuki K Poulose Cc: Greg Kroah-Hartman Cc: Russell King Signed-off-by: Kim Phillips Co-developed-by: Mian Yousaf Kaukab Signed-off-by: Mian Yousaf Kaukab Signed-off-by: Tingwei Zhang

[PATCH 06/25] coresight: Add try_get_module() in coresight_grab_device()

2020-09-28 Thread Mathieu Poirier
. Suggested-by: Suzuki K Poulose Signed-off-by: Tingwei Zhang Tested-by: Mike Leach Reviewed-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight.c | 60 ++--- 1 file changed, 53 insertions(+), 7 deletions(-) diff --git a/drivers/hwtracing

[PATCH 23/25] coresight: catu: Allow catu drivers to be built as modules

2020-09-28 Thread Mathieu Poirier
-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/Kconfig | 5 - drivers/hwtracing/coresight/coresight-catu.c | 15 +++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing

[PATCH 25/25] coresight: etm4x: Fix save and restore of TRCVMIDCCTLR1 register

2020-09-28 Thread Mathieu Poirier
ash Ranjan Reviewed-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresigh

[PATCH 22/25] coresight: tmc-etr: Add function to register catu ops

2020-09-28 Thread Mathieu Poirier
Reviewed-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-catu.c | 22 +-- drivers/hwtracing/coresight/coresight-catu.h | 2 -- .../hwtracing/coresight/coresight-tmc-etr.c | 15 +++-- drivers/hwtracing/coresight/coresight

[PATCH 17/25] coresight: cti: Fix remove sysfs link error

2020-09-28 Thread Mathieu Poirier
. This patch corrects the link removal code. Fixes: 73274abb6557 ("coresight: cti: Add in sysfs links to other coresight devices") Reported-by: Tingwei Zhang Signed-off-by: Mike Leach Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-cti.c | 9 ++--- 1 fi

[PATCH 16/25] coresight: cti: Add function to register cti associate ops

2020-09-28 Thread Mathieu Poirier
From: Tingwei Zhang Add static cti_assoc_ops to coresight core driver. Let cti driver register the add_assoc and remove_assoc call back. Avoid coresight core driver to depend on cti driver. Signed-off-by: Tingwei Zhang Tested-by: Mike Leach Signed-off-by: Mathieu Poirier --- drivers

[PATCH 04/25] coresight: Add coresight prefix to barrier_pkt

2020-09-28 Thread Mathieu Poirier
From: Tingwei Zhang Add coresight prefix to make it specific. It will be a export symbol. Signed-off-by: Mian Yousaf Kaukab Signed-off-by: Tingwei Zhang Reviewed-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etb10.c | 2 +- drivers

[PATCH 08/25] coresight: etm: perf: Fix warning caused by etm_setup_aux failure

2020-09-28 Thread Mathieu Poirier
xes: f5200aa9831f38 ("coresight: perf: Refactor function free_event_data()") Signed-off-by: Tingwei Zhang Reviewed-by: Mike Leach Reviewed-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etm-perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[PATCH 21/25] coresight: cti: Allow cti to be built as a module

2020-09-28 Thread Mathieu Poirier
a MODULE_DEVICE_TABLE for autoloading on boot - move cti_remove_conn_xrefs to cti_remove since all sysfs links have gone when system calls device_release. Signed-off-by: Tingwei Zhang Tested-by: Mike Leach Reviewed-by Mike Leach Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/Kconfig

[PATCH 20/25] coresight: cti: Increase reference count when enabling cti

2020-09-28 Thread Mathieu Poirier
-by: Mike Leach Signed-off-by: Tingwei Zhang Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c index

[PATCH 18/25] coresight: cti: Fix bug clearing sysfs links on callback

2020-09-28 Thread Mathieu Poirier
is called too late in the unload process resulting in a crash. This fixes both the issues. Fixes: 177af8285b59 ("coresight: cti: Enable CTI associated with devices") Reported-by: Tingwei Zhang Signed-off-by: Mike Leach Signed-off-by: Tingwei Zhang Acked-by: Suzuki K Poulose Signed-off-b

[PATCH 24/25] coresight: core: Allow the coresight core driver to be built as a module

2020-09-28 Thread Mathieu Poirier
/unregister function calls to the core init/exit functions. - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc: Randy Dunlap Cc: Suzuki K Poulose Cc: Greg Kroah-Hartman Cc: Russell King Signed-off-by: Kim Phillips Signed-off

[PATCH 19/25] coresight: cti: Don't disable ect device if it's not enabled

2020-09-28 Thread Mathieu Poirier
is established after coresight device is enabled. Signed-off-by: Mike Leach Signed-off-by: Tingwei Zhang Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight.c | 11 --- include/linux/coresight.h | 1 + 2 files changed, 9 insertions(+), 3 deletions

[PATCH 11/25] coresight: etb: Allow etb to be built as a module

2020-09-28 Thread Mathieu Poirier
From: Kim Phillips Allow to build coresight-etb10 as a module, for ease of development. - Kconfig becomes a tristate, to allow =m - add an etb_remove function, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc

[PATCH 07/25] coresight: stm: Allow to build coresight-stm as a module

2020-09-28 Thread Mathieu Poirier
From: Tingwei Zhang - Kconfig becomes a tristate, to allow =m - add a stm_remove function, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc: Randy Dunlap Cc: Suzuki K Poulose Cc: Greg Kroah-Hartman Cc: Russell

[PATCH 03/25] coresight: Use IS_ENABLED for CONFIGs that may be modules

2020-09-28 Thread Mathieu Poirier
From: Kim Phillips Checking for ifdef CONFIG_x fails if CONFIG_x=m. Use IS_ENABLED that is true for both built-ins and modules, instead. Required when building coresight components as modules. Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc: Randy Dunlap Cc: Suzuki K Poulose Cc

[PATCH 09/25] coresight: etm3x: Allow etm3x to be built as a module

2020-09-28 Thread Mathieu Poirier
a MODULE_DEVICE_TABLE for autoloading on boot - delay advertising the per-cpu etmdrvdata - protect etmdrvdata[] by modifying it on relevant CPU Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc: Randy Dunlap Cc: Suzuki K Poulose Cc: Greg Kroah-Hartman Cc: Russell King Signed-off-by: Kim Phillips

[PATCH 10/25] coresight: etm4x: Allow etm4x to be built as a module

2020-09-28 Thread Mathieu Poirier
a MODULE_DEVICE_TABLE for autoloading on boot - delay advertising the per-cpu etmdrvdata - protect etmdrvdata[] by modifying it on relevant CPU Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc: Randy Dunlap Cc: Suzuki K Poulose Cc: Greg Kroah-Hartman Cc: Russell King Signed-off-by: Kim Phillips

[PATCH 02/25] coresight: cpu_debug: Define MODULE_DEVICE_TABLE

2020-09-28 Thread Mathieu Poirier
From: Tingwei Zhang Define a MODULE_DEVICE_TABLE for cpu_debug so module can be auto loaded on boot. Signed-off-by: Tingwei Zhang Reviewed-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-cpu-debug.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH 05/25] coresight: Export global symbols

2020-09-28 Thread Mathieu Poirier
From: Mian Yousaf Kaukab Export symbols used among coresight modules. Signed-off-by: Mian Yousaf Kaukab Signed-off-by: Tingwei Zhang Tested-by: Mike Leach Reviewed-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etm-perf.c | 1 + drivers

[PATCH 01/25] coresight: cpu_debug: Add module name in Kconfig

2020-09-28 Thread Mathieu Poirier
From: Tingwei Zhang Provide name of cpu_debug module in Kconfig help section. Signed-off-by: Tingwei Zhang Tested-by: Mike Leach Reviewed-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 00/25] coresight: Next v5.9-rc7

2020-09-28 Thread Mathieu Poirier
Good day, This is the second part we were hoping for, i.e CoreSight modularisation, and a fix for a copy/paste error in the context save/restore process. Please consider for the next merge window. Applies on top of your "char-misc-next" branch. Thanks, Mathieu Kim Phillips (8): coresight:

Re: [PATCHv2 2/2] coresight: etm4x: Fix save and restore of TRCVMIDCCTLR1 register

2020-09-28 Thread Mathieu Poirier
On Mon, Sep 28, 2020 at 05:07:09PM +0530, Sai Prakash Ranjan wrote: > In commit f188b5e76aae ("coresight: etm4x: Save/restore state > across CPU low power states"), mistakenly TRCVMIDCCTLR1 register > value was saved in trcvmidcctlr0 state variable which is used to > store TRCVMIDCCTLR0 register

Re: [PATCH 00/10] rpmsg: Make RPMSG name service modular

2020-09-24 Thread Mathieu Poirier
directly to me > or something similar has happened. > Ok > On Tue, Sep 22, 2020 at 01:12:41PM -0600, Mathieu Poirier wrote: > > Good day Guennadi, > > > > On Tue, 22 Sep 2020 at 02:09, Guennadi Liakhovetski > > wrote: > > > > > > Hi Mat

Re: [PATCH v2 0/4] Add support of mt8183 APU

2020-09-23 Thread Mathieu Poirier
Hi Alexander, Things have been quite busy over the last 3 weeks, preventing me from giving your work the attention it deserves. It is on my radar and will get to it in the next two weeks. Thanks, Mathieu On Thu, Sep 10, 2020 at 03:01:44PM +0200, Alexandre Bailon wrote: > Some Mediatek's SoC

Re: [PATCH v11 09/24] coresight: etm3x: allow etm3x to be built as a module

2020-09-22 Thread Mathieu Poirier
On Tue, Sep 15, 2020 at 12:09:18PM -0600, Mathieu Poirier wrote: > On Tue, Sep 15, 2020 at 06:41:01PM +0800, Tingwei Zhang wrote: > > From: Kim Phillips > > > > Allow to build coresight-etm3x as a module, for ease of development. > > > > - Kconfig becomes a t

<    3   4   5   6   7   8   9   10   11   12   >