Re: [PATCH net-next] tuntap: Fallback to automq on TUNSETSTEERINGEBPF prog negative return

2019-09-22 Thread Matt Cover
On Sun, Sep 22, 2019 at 3:46 PM Matt Cover wrote: > > On Sun, Sep 22, 2019 at 3:30 PM Matt Cover wrote: > > > > On Sun, Sep 22, 2019 at 1:36 PM Michael S. Tsirkin wrote: > > > > > > On Sun, Sep 22, 2019 at 10:43:19AM -0700, Matt Cover wrote: > > >

Re: [PATCH net-next] tuntap: Fallback to automq on TUNSETSTEERINGEBPF prog negative return

2019-09-22 Thread Matt Cover
On Sun, Sep 22, 2019 at 3:30 PM Matt Cover wrote: > > On Sun, Sep 22, 2019 at 1:36 PM Michael S. Tsirkin wrote: > > > > On Sun, Sep 22, 2019 at 10:43:19AM -0700, Matt Cover wrote: > > > On Sun, Sep 22, 2019 at 5:37 AM Michael S. Tsirkin > > > wrote: > &

Re: [PATCH net-next] tuntap: Fallback to automq on TUNSETSTEERINGEBPF prog negative return

2019-09-22 Thread Matt Cover
On Sun, Sep 22, 2019 at 1:36 PM Michael S. Tsirkin wrote: > > On Sun, Sep 22, 2019 at 10:43:19AM -0700, Matt Cover wrote: > > On Sun, Sep 22, 2019 at 5:37 AM Michael S. Tsirkin wrote: > > > > > > On Fri, Sep 20, 2019 at 11:58:43AM -0700, Matthew Cover wrote: > &

Re: [PATCH net-next] tuntap: Fallback to automq on TUNSETSTEERINGEBPF prog negative return

2019-09-22 Thread Matt Cover
On Sun, Sep 22, 2019 at 5:37 AM Michael S. Tsirkin wrote: > > On Fri, Sep 20, 2019 at 11:58:43AM -0700, Matthew Cover wrote: > > Treat a negative return from a TUNSETSTEERINGEBPF bpf prog as a signal > > to fallback to tun_automq_select_queue() for tx queue selection. > > > > Compilation of this

Re: [PATCH net-next] tuntap: Fallback to automq on TUNSETSTEERINGEBPF prog negative return

2019-09-20 Thread Matt Cover
On Fri, Sep 20, 2019 at 11:59 AM Matthew Cover wrote: > > Treat a negative return from a TUNSETSTEERINGEBPF bpf prog as a signal > to fallback to tun_automq_select_queue() for tx queue selection. > > Compilation of this exact patch was tested. > > For functional testing 3 additional printk()s

Re: [RFC {net,iproute2}-next 0/2] Introduce an eBPF hookpoint for tx queue selection in the XPS (Transmit Packet Steering) code.

2019-09-19 Thread Matt Cover
On Thu, Sep 19, 2019 at 7:45 PM Matt Cover wrote: > > On Thu, Sep 19, 2019 at 6:42 PM Jason Wang wrote: > > > > > > On 2019/9/20 上午8:05, Matt Cover wrote: > > > On Thu, Sep 19, 2019 at 3:45 PM Matthew Cover > > > wrote: > > >> W

Re: [RFC {net,iproute2}-next 0/2] Introduce an eBPF hookpoint for tx queue selection in the XPS (Transmit Packet Steering) code.

2019-09-19 Thread Matt Cover
On Thu, Sep 19, 2019 at 6:42 PM Jason Wang wrote: > > > On 2019/9/20 上午8:05, Matt Cover wrote: > > On Thu, Sep 19, 2019 at 3:45 PM Matthew Cover wrote: > >> WORK IN PROGRESS: > >>* bpf program loading works! > >>* txq steering via bpf progra

Re: [RFC {net,iproute2}-next 0/2] Introduce an eBPF hookpoint for tx queue selection in the XPS (Transmit Packet Steering) code.

2019-09-19 Thread Matt Cover
On Thu, Sep 19, 2019 at 3:45 PM Matthew Cover wrote: > > WORK IN PROGRESS: > * bpf program loading works! > * txq steering via bpf program return code works! > * bpf program unloading not working. > * bpf program attached query not working. > > This patch set provides a bpf hookpoint with

Re: [PATCH 1/3] KVM: Fix coalesced mmio ring buffer out-of-bounds access

2019-09-17 Thread Matt Delco
On Tue, Sep 17, 2019 at 7:59 AM Jim Mattson wrote: > On Tue, Sep 17, 2019 at 1:16 AM Wanpeng Li wrote: > > From: Wanpeng Li > > > > Reported by syzkaller: > > > > #PF: supervisor write access in kernel mode > > #PF: error_code(0x0002) - not-present page > > PGD 403c01067

Re: [PATCH 00/13] Modernize Loongson64 Machine

2019-09-12 Thread Matt Turner
On Tue, Aug 27, 2019 at 1:53 AM Jiaxun Yang wrote: > Loongson have a long history of contributing their code to mainline kernel. > However, it seems like recent years, they are focusing on maintain a kernel > by themselves > rather than contribute there code to the community. Do you know more

[PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed

2019-09-05 Thread Matt Lupfer
LUNs when events are missed to check if they are still present. If not, remove them. Signed-off-by: Matt Lupfer --- drivers/scsi/virtio_scsi.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index

Re: [PATCH 2/2] ipc: fix sparc64 ipc() wrapper

2019-09-05 Thread Matt Turner
On Thu, Sep 5, 2019 at 8:23 AM Arnd Bergmann wrote: > > Matt bisected a sparc64 specific issue with semctl, shmctl and msgctl > to a commit from my y2038 series in linux-5.1, as I missed the custom > sys_ipc() wrapper that sparc64 uses in place of the generic version that

Re: [PATCH] scsi: virtio_scsi: unplug LUNs when events missed

2019-09-04 Thread Matt Lupfer
On Wed, Sep 04, 2019 at 05:14:33AM -0400, Michael S. Tsirkin wrote: > On Tue, Sep 03, 2019 at 05:04:20PM +0000, Matt Lupfer wrote: >> The event handler calls scsi_scan_host() when events are missed, which >> will hotplug new LUNs. However, this function won't remove any &g

[PATCH] scsi: virtio_scsi: unplug LUNs when events missed

2019-09-03 Thread Matt Lupfer
LUNs when events are missed to check if they are still present. If not, remove them. Signed-off-by: Matt Lupfer --- drivers/scsi/virtio_scsi.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index

[tip: sched/core] sched/topology: Improve load balancing on AMD EPYC systems

2019-09-03 Thread tip-bot2 for Matt Fleming
The following commit has been merged into the sched/core branch of tip: Commit-ID: a55c7454a8c887b226a01d7eed088ccb5374d81e Gitweb: https://git.kernel.org/tip/a55c7454a8c887b226a01d7eed088ccb5374d81e Author:Matt Fleming AuthorDate:Thu, 08 Aug 2019 20:53:01 +01:00

[tip: sched/core] arch, ia64: Make NUMA select SMP

2019-09-03 Thread tip-bot2 for Matt Fleming
The following commit has been merged into the sched/core branch of tip: Commit-ID: a2cbfd46559e809c8165773b7fe8afa058b35414 Gitweb: https://git.kernel.org/tip/a2cbfd46559e809c8165773b7fe8afa058b35414 Author:Matt Fleming AuthorDate:Thu, 08 Aug 2019 20:53:00 +01:00

[PATCH v4 2/2] sched/topology: Improve load balancing on AMD EPYC

2019-08-08 Thread Matt Fleming
e balancer kicks in after a few seconds and forcibly moves some threads to node 4. Override node_reclaim_distance for AMD Zen. Signed-off-by: Matt Fleming Signed-off-by: Peter Zijlstra (Intel) Acked-by: Mel Gorman Cc: suravee.suthikulpa...@amd.com Cc: Borislav Petkov Cc: thomas.lenda...@amd.com

[PATCH 1/2] ia64: Make NUMA select SMP

2019-08-08 Thread Matt Fleming
-off-by: Matt Fleming Cc: Tony Luck Cc: Rik van Riel Cc: Peter Zijlstra --- arch/ia64/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig index 7468d8e50467..997baba02b70 100644 --- a/arch/ia64/Kconfig +++ b/arch/ia64/Kconfig @@ -389,6 +389,7

[PATCH v4 0/2] sched: Improve load balancing on AMD EPYC

2019-08-08 Thread Matt Fleming
' page_alloc.c:(.text+0x7931): undefined reference to `node_reclaim_distance' Matt Fleming (2): ia64: Make NUMA select SMP sched/topology: Improve load balancing on AMD EPYC arch/ia64/Kconfig | 1 + arch/x86/kernel/cpu/amd.c | 5 + include/linux/topology.h | 14

[PATCH 1/4] phy: marvell: phy-mvebu-cp110-comphy: implement RXAUI support

2019-08-01 Thread Matt Pelland
Marvell's cp110 phy supports RXAUI on lanes 2, 3, 4, and 5 when connected to port zero. When used in this mode, lanes operate in pairs of two (2 and 3, 4 and 5). Signed-off-by: Matt Pelland --- drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 127 ++- 1 file changed, 120

[PATCH 2/4] phy: marvell: phy-mvebu-cp110-comphy: rename instances of DLT

2019-08-01 Thread Matt Pelland
The documentation for Marvell's cp110 phy refers to these registers/register regions as DTL control, DTL frequency loop enable, etc. This patch aligns the relevant code for these accordingly. Signed-off-by: Matt Pelland --- drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 22

[PATCH] phy: marvell: phy-mvebu-cp110-comphy: Implement RXAUI Support

2019-08-01 Thread Matt Pelland
This patch set introduces support for configuring Marvell's cp110 comphy for RXAUI operation. I can post the other half of these patches (for mvpp2) here if need be but I'm preparing to submit them to netdev shortly. I've tested this on a Marvell Armada 7040 based platform with no issues.

RE: [PATCH] staging:kpc2000:Fix dubious x | !y sparse warning

2019-08-01 Thread Matt Sickler
>-Original Message- >From: devel On Behalf Of Greg >KH >Sent: Thursday, August 01, 2019 11:35 AM >To: Harsh Jain >Cc: de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org >Subject: Re: [PATCH] staging:kpc2000:Fix dubious x | !y sparse warning > >On Thu, Aug 01, 2019 at 12:06:06AM

[PATCH v4 7/8] recordmcount: Remove redundant cleanup() calls

2019-07-31 Thread Matt Helsley
d from two parts of do_func() and calls cleanup(). In theory we move them into do_func(), however these in turn prove redundant so another simplification step removes them as well. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 13 - scripts/recordmcount.h | 2 -- 2 files c

[PATCH v4 8/8] recordmcount: Clarify what cleanup() does

2019-07-31 Thread Matt Helsley
they're related. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 151 ++--- 1 file changed, 81 insertions(+), 70 deletions(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index 5677fcc88a72..612268eabef4 100644 --- a/scripts

[PATCH v4 5/8] recordmcount: Kernel style function signature formatting

2019-07-31 Thread Matt Helsley
The uwrite() and ulseek() functions are formatted inconsistently with the rest of the file and the kernel overall. While we're making other changes here let's fix this. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 21 +++-- scripts/recordmcount.h | 13

[PATCH v4 4/8] recordmcount: Rewrite error/success handling

2019-07-31 Thread Matt Helsley
-- there we use pointer comparison rather than string comparison to differentiate between previously-processed object files and returning the name of a text section. Signed-off-by: Matt Helsley -- v3.5 -- Moved already_has_mcount into recordmcount.c to avoid unnecessary multiple

[PATCH v4 6/8] recordmcount: Kernel style formatting

2019-07-31 Thread Matt Helsley
Fix up the whitespace irregularity in the ELF switch blocks. Swapping the initial value of gpfx allows us to simplify all but one of the one-line switch cases even further. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 47 ++ 1 file changed

[PATCH v4 3/8] recordmcount: Remove unused fd from uwrite() and ulseek()

2019-07-31 Thread Matt Helsley
(). Worse, they obscure the fact that at the time uwrite() and ulseek() are called fd_map is not a valid file descriptor. Remove the unused file descriptor parameters that make it look like fd_map is still valid. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 16 scripts

[PATCH v4 2/8] recordmcount: Remove uread()

2019-07-31 Thread Matt Helsley
only caller, mmap_file(), is doing the relevant allocations and associated initializations. Therefore it's clearer to use a plain read() call to initialize the data in mmap_file() and remove uread(). Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 18 +- 1 file changed, 5

[PATCH v4 1/8] recordmcount: Remove redundant strcmp

2019-07-31 Thread Matt Helsley
The strcmp is unnecessary since .text is already accepted as a prefix in the strncmp(). Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index 8387a9bc064a..ebe98c39f3cd

[PATCH v4 0/8] recordmcount cleanups

2019-07-31 Thread Matt Helsley
to follow inverted christmas tree style. Matt Helsley (8): recordmcount: Remove redundant strcmp recordmcount: Remove uread() recordmcount: Remove unused fd from uwrite() and ulseek() recordmcount: Rewrite error/success handling recordmcount: Kernel style function signature

Re: [PATCH v3 10/13] objtool: Make recordmcount into an objtool subcmd

2019-07-29 Thread Matt Helsley
> On Jul 28, 2019, at 10:48 AM, Josh Poimboeuf wrote: > > On Wed, Jul 24, 2019 at 02:05:04PM -0700, Matt Helsley wrote: >> diff --git a/scripts/Makefile.build b/scripts/Makefile.build >> index 08b70ee9614a..43707491317c 100644 >> --- a/scripts/Makefile.build >

Re: [PATCH v3 09/13] objtool: Prepare to merge recordmcount

2019-07-29 Thread Matt Helsley
> On Jul 28, 2019, at 10:48 AM, Josh Poimboeuf wrote: > > On Wed, Jul 24, 2019 at 02:05:03PM -0700, Matt Helsley wrote: >> Move recordmcount into the objtool directory. We keep this step separate >> so changes which turn recordmcount into a subcommand of objtool

Re: [PATCH v3] sched/topology: Improve load balancing on AMD EPYC

2019-07-29 Thread Matt Fleming
ith the active load balancer kicking in after a few seconds, but I suspect that is related to the use of group capacity elsewhere in the load balancer code (like update_sg_lb_stats()). -- Matt Fleming SUSE Performance Team

Re: [PATCH v3 04/13] recordmcount: Rewrite error/success handling

2019-07-26 Thread Matt Helsley
> On Jul 26, 2019, at 11:43 AM, Steven Rostedt wrote: > > On Fri, 26 Jul 2019 18:37:11 +0000 > Matt Helsley wrote: > >>>> diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h >>>> index c1e1b04b4871..909a3e4775c2 100644 >>>&

Re: [PATCH v3 04/13] recordmcount: Rewrite error/success handling

2019-07-26 Thread Matt Helsley
> On Jul 26, 2019, at 10:45 AM, Steven Rostedt wrote: > > On Wed, 24 Jul 2019 14:04:58 -0700 > Matt Helsley wrote: > > > Hi Matt, > > As I'm applying these for real, I'm taking a deeper look at the > patches. This one I have some questions about. > &g

[PATCH v3 00/13] Cleanup recordmcount and begin objtool conversion

2019-07-24 Thread Matt Helsley
got any faster or slower. Matt Helsley (13): recordmcount: Remove redundant strcmp recordmcount: Remove uread() recordmcount: Remove unused fd from uwrite() and ulseek() recordmcount: Rewrite error/success handling recordmcount: Kernel style function signature formatting reco

[PATCH v3 05/13] recordmcount: Kernel style function signature formatting

2019-07-24 Thread Matt Helsley
The uwrite() and ulseek() functions are formatted inconsistently with the rest of the file and the kernel overall. While we're making other changes here let's fix this. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 21 +++-- scripts/recordmcount.h | 13

[PATCH v3 11/13] objtool: recordmcount: Start using objtool's elf wrapper

2019-07-24 Thread Matt Helsley
-- the libelf/objtool way and the old recordmcount wrapper way which avoids these extra data structures by using indices, offsets, and pointers into the mmapped ELF file. Subsequent patches will convert from the old recordmcount accessors to the libelf/objtool accessors. Signed-off-by: Matt Helsley

[PATCH v3 13/13] objtool: recordmcount: Convert do_func() relhdrs

2019-07-24 Thread Matt Helsley
to change the ELF file -- it only changes the way we walk the ELF sections and touch pages for memory mapping made by the old recordmcount code. Signed-off-by: Matt Helsley --- tools/objtool/recordmcount.h | 70 ++-- 1 file changed, 36 insertions(+), 34 deletions

[PATCH v3 08/13] recordmcount: Clarify what cleanup() does

2019-07-24 Thread Matt Helsley
they're related. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 151 ++--- 1 file changed, 81 insertions(+), 70 deletions(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index 111419c282d3..9f4af109277e 100644 --- a/scripts

[PATCH v3 10/13] objtool: Make recordmcount into an objtool subcmd

2019-07-24 Thread Matt Helsley
recordmcount to be more easily readable and remove recordmcount's crude accessor wrapping code. Signed-off-by: Matt Helsley --- Makefile | 6 +-- scripts/Makefile.build | 22 +-- tools/objtool/Build| 3 +- tools/objtool/Makefile | 12

[PATCH v3 06/13] recordmcount: Kernel style formatting

2019-07-24 Thread Matt Helsley
Fix up the whitespace irregularity in the ELF switch blocks. Swapping the initial value of gpfx allows us to simplify all but one of the one-line switch cases even further. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 47 ++ 1 file changed

[PATCH v3 12/13] objtool: recordmcount: Search for __mcount_loc before walking the sections

2019-07-24 Thread Matt Helsley
string pointer trick. Signed-off-by: Matt Helsley --- tools/objtool/recordmcount.c | 2 -- tools/objtool/recordmcount.h | 22 +++--- 2 files changed, 3 insertions(+), 21 deletions(-) diff --git a/tools/objtool/recordmcount.c b/tools/objtool/recordmcount.c index 28b5c5e4beae

[PATCH v3 07/13] recordmcount: Remove redundant cleanup() calls

2019-07-24 Thread Matt Helsley
d from two parts of do_func() and calls cleanup(). In theory we move them into do_func(), however these in turn prove redundant so another simplification step removes them as well. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 13 - scripts/recordmcount.h | 2 -- 2 files c

[PATCH v3 09/13] objtool: Prepare to merge recordmcount

2019-07-24 Thread Matt Helsley
Move recordmcount into the objtool directory. We keep this step separate so changes which turn recordmcount into a subcommand of objtool don't get obscured. Signed-off-by: Matt Helsley --- scripts/.gitignore | 1 - scripts/Makefile | 1

[PATCH v3 03/13] recordmcount: Remove unused fd from uwrite() and ulseek()

2019-07-24 Thread Matt Helsley
(). Worse, they obscure the fact that at the time uwrite() and ulseek() are called fd_map is not a valid file descriptor. Remove the unused file descriptor parameters that make it look like fd_map is still valid. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 16 scripts

[PATCH v3 04/13] recordmcount: Rewrite error/success handling

2019-07-24 Thread Matt Helsley
-- there we use pointer comparison rather than string comparison to differentiate between previously-processed object files and returning the name of a text section. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 160 + scripts/recordmcount.h | 134

[PATCH v3 01/13] recordmcount: Remove redundant strcmp

2019-07-24 Thread Matt Helsley
The strcmp is unnecessary since .text is already accepted as a prefix in the strncmp(). Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index 8387a9bc064a..ebe98c39f3cd

[PATCH v3 02/13] recordmcount: Remove uread()

2019-07-24 Thread Matt Helsley
only caller, mmap_file(), is doing the relevant allocations and associated initializations. Therefore it's clearer to use a plain read() call to initialize the data in mmap_file() and remove uread(). Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 18 +- 1 file changed, 5

Re: [PATCH v2 00/13] Cleanup recordmcount and begin objtool conversion

2019-07-24 Thread Matt Helsley
’d add: I rebased yesterday and noticed a few minor changes are needed to resolve conflicts with mainline. I will send a v3 out today with these changes: renaming elf_open to elf_read some kernel build changes (in Makefile.build) Also, I’ve finished removing all of the old rec

[tip:x86/urgent] x86/entry/32: Pass cr2 to do_async_page_fault()

2019-07-24 Thread tip-bot for Matt Mullins
Commit-ID: b8f70953c1251d8b16276995816a95639f598e70 Gitweb: https://git.kernel.org/tip/b8f70953c1251d8b16276995816a95639f598e70 Author: Matt Mullins AuthorDate: Tue, 23 Jul 2019 21:20:58 -0700 Committer: Thomas Gleixner CommitDate: Wed, 24 Jul 2019 12:17:39 +0200 x86/entry/32: Pass

[PATCH] x86/entry/32: pass cr2 to do_async_page_fault

2019-07-23 Thread Matt Mullins
page_fault and async_page_fault. For a 32-bit KVM guest, this fixes: [1.148669][T1] Run /sbin/init as init process [1.153328][T1] Starting init: /sbin/init exists but couldn't execute it (error -14) Fixes: a0d14b8909de ("x86/mm, tracing: Fix CR2 corruption") Signed-

[PATCH v3] sched/topology: Improve load balancing on AMD EPYC

2019-07-23 Thread Matt Fleming
e balancer kicks in after a few seconds and forcibly moves some threads to node 4. Override node_reclaim_distance for AMD Zen. Signed-off-by: Matt Fleming Cc: "Suthikulpanit, Suravee" Cc: Mel Gorman Cc: "Lendacky, Thomas" Cc: Borislav Petkov --- arch/x86/kernel/cpu

RE: [PATCH v3] staging: kpc2000: Convert put_page to put_user_page*()

2019-07-19 Thread Matt Sickler
>From: Bharath Vedartham >Changes since v2 >- Added back PageResevered check as suggested by John Hubbard. > >The PageReserved check needs a closer look and is not worth messing >around with for now. > >Matt, Could you give any suggestions for testing this patch?

RE: [PATCH] staging: kpc2000: Convert put_page() to put_user_page*()

2019-07-15 Thread Matt Sickler
It looks like Outlook is going to absolutely trash this email. Hopefully it comes through okay. >> There have been issues with get_user_pages and filesystem writeback. >> The issues are better described in [1]. >> >> The solution being proposed wants to keep track of gup_pinned pages >which

Re: [PATCH] sched/topology: Improve load balancing on AMD EPYC

2019-06-28 Thread Matt Fleming
On Wed, 26 Jun, at 09:18:01PM, Suthikulpanit, Suravee wrote: > > We use 16 to designate 1-hop latency (for different node within the same > socket). > For across-socket access, since the latency is greater, we set the latency to > 32 > (twice the latency of 1-hop) not aware of the

Re: [PATCH] drm/bridge: adv7511: Attach to DSI host at probe time

2019-06-25 Thread Matt Redfearn
Hi, Any feedback on this patch? Thanks, Matt On 24/04/2019 14:22, Matthew Redfearn wrote: > In contrast to all of the DSI panel drivers in drivers/gpu/drm/panel > which attach to the DSI host via mipi_dsi_attach() at probe time, the > ADV7533 bridge device does not. Instead

Re: [PATCH] sched/topology: Improve load balancing on AMD EPYC

2019-06-19 Thread Matt Fleming
On Tue, 18 Jun, at 02:33:18PM, Peter Zijlstra wrote: > On Tue, Jun 18, 2019 at 11:43:19AM +0100, Matt Fleming wrote: > > This works for me under all my tests. Thoughts? > > > > --->8--- > > > > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/ker

Re: [PATCH] sched/topology: Improve load balancing on AMD EPYC

2019-06-18 Thread Matt Fleming
On Tue, 11 Jun, at 05:22:21PM, Lendacky, Thomas wrote: > On 6/10/19 4:26 PM, Matt Fleming wrote: > > On Wed, 05 Jun, at 08:00:35PM, Peter Zijlstra wrote: > >> > >> And then we had two magic values :/ > >> > >> Should we not 'fix' RECLAIM_DISTANCE for

Re: [PATCH] bpf: hide do_bpf_send_signal when unused

2019-06-17 Thread Matt Mullins
On Mon, 2019-06-17 at 19:09 -0400, Steven Rostedt wrote: > On Mon, 17 Jun 2019 08:26:29 -0700 > Alexei Starovoitov wrote: > > > On Mon, Jun 17, 2019 at 5:59 AM Arnd Bergmann wrote: > > > > > > When CONFIG_MODULES is disabled, this function is never called: > > > > > >

Re: [PATCH bpf v2] bpf: fix nested bpf tracepoints with per-cpu data

2019-06-14 Thread Matt Mullins
On Fri, 2019-06-14 at 16:50 +0200, Daniel Borkmann wrote: > On 06/14/2019 02:51 AM, Matt Mullins wrote: > > On Fri, 2019-06-14 at 00:47 +0200, Daniel Borkmann wrote: > > > On 06/12/2019 07:00 AM, Andrii Nakryiko wrote: > > > > On Tue, Jun 11, 2019

Re: [PATCH bpf v2] bpf: fix nested bpf tracepoints with per-cpu data

2019-06-13 Thread Matt Mullins
On Fri, 2019-06-14 at 00:47 +0200, Daniel Borkmann wrote: > On 06/12/2019 07:00 AM, Andrii Nakryiko wrote: > > On Tue, Jun 11, 2019 at 8:48 PM Matt Mullins wrote: > > > > > > BPF_PROG_TYPE_RAW_TRACEPOINTs can be executed nested on the same CPU, as > > > t

[tip:x86/urgent] x86/kgdb: Return 0 from kgdb_arch_set_breakpoint()

2019-06-12 Thread tip-bot for Matt Mullins
Commit-ID: 71ab8323cc357c68985a2d6fc6cfc22b1dbbc1c3 Gitweb: https://git.kernel.org/tip/71ab8323cc357c68985a2d6fc6cfc22b1dbbc1c3 Author: Matt Mullins AuthorDate: Fri, 31 May 2019 12:47:54 -0700 Committer: Borislav Petkov CommitDate: Wed, 12 Jun 2019 18:52:44 +0200 x86/kgdb: Return 0

[PATCH v2 03/13] recordmcount: Remove unused fd from uwrite() and ulseek()

2019-06-11 Thread Matt Helsley
(). Worse, they obscure the fact that at the time uwrite() and ulseek() are called fd_map is not a valid file descriptor. Remove the unused file descriptor parameters that make it look like fd_map is still valid. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 16 scripts

[PATCH v2 08/13] recordmcount: Clarify what cleanup() does

2019-06-11 Thread Matt Helsley
they're related. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 151 ++--- 1 file changed, 81 insertions(+), 70 deletions(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index 111419c282d3..9f4af109277e 100644 --- a/scripts

[PATCH v2 00/13] Cleanup recordmcount and begin objtool conversion

2019-06-11 Thread Matt Helsley
quot;idle" GUI tasks running. This is why I took the median rather than the mean. Though I haven't run the statistics, my sense is the numbers don't support concluding that things really got any faster or slower. I'm working on a separate, follow-on RFC set which implements th

[PATCH v2 11/13] objtool: recordmcount: Start using objtool's elf wrapper

2019-06-11 Thread Matt Helsley
-- the libelf/objtool way and the old recordmcount wrapper way which avoids these extra data structures by using indices, offsets, and pointers into the mmapped ELF file. Subsequent patches will convert from the old recordmcount accessors to the libelf/objtool accessors. Signed-off-by: Matt Helsley

[PATCH v2 02/13] recordmcount: Remove uread()

2019-06-11 Thread Matt Helsley
only caller, mmap_file(), is doing the relevant allocations and associated initializations. Therefore it's clearer to use a plain read() call to initialize the data in mmap_file() and remove uread(). Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 18 +- 1 file changed, 5

[PATCH v2 06/13] recordmcount: Kernel style formatting

2019-06-11 Thread Matt Helsley
Fix up the whitespace irregularity in the ELF switch blocks. Swapping the initial value of gpfx allows us to simplify all but one of the one-line switch cases even further. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 47 ++ 1 file changed

[PATCH v2 04/13] recordmcount: Rewrite error/success handling

2019-06-11 Thread Matt Helsley
-- there we use pointer comparison rather than string comparison to differentiate between previously-processed object files and returning the name of a text section. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 160 + scripts/recordmcount.h | 134

[PATCH v2 05/13] recordmcount: Kernel style function signature formatting

2019-06-11 Thread Matt Helsley
The uwrite() and ulseek() functions are formatted inconsistently with the rest of the file and the kernel overall. While we're making other changes here let's fix this. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 21 +++-- scripts/recordmcount.h | 13

[PATCH v2 01/13] recordmcount: Remove redundant strcmp

2019-06-11 Thread Matt Helsley
The strcmp is unnecessary since .text is already accepted as a prefix in the strncmp(). Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index 8387a9bc064a..ebe98c39f3cd

[PATCH v2 13/13] objtool: recordmcount: Convert do_func() relhdrs

2019-06-11 Thread Matt Helsley
to change the ELF file -- it only changes the way we walk the ELF sections and touch pages for memory mapping made by the old recordmcount code. Signed-off-by: Matt Helsley --- tools/objtool/recordmcount.h | 70 ++-- 1 file changed, 36 insertions(+), 34 deletions

[PATCH v2 07/13] recordmcount: Remove redundant cleanup() calls

2019-06-11 Thread Matt Helsley
d from two parts of do_func() and calls cleanup(). In theory we move them into do_func(), however these in turn prove redundant so another simplification step removes them as well. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 13 - scripts/recordmcount.h | 2 -- 2 files c

[PATCH v2 09/13] objtool: Prepare to merge recordmcount

2019-06-11 Thread Matt Helsley
Move recordmcount into the objtool directory. We keep this step separate so changes which turn recordmcount into a subcommand of objtool don't get obscured. Signed-off-by: Matt Helsley --- scripts/.gitignore | 1 - scripts/Makefile | 1

[PATCH v2 10/13] objtool: Make recordmcount into an objtool subcmd

2019-06-11 Thread Matt Helsley
recordmcount to be more easily readable and remove recordmcount's crude accessor wrapping code. Signed-off-by: Matt Helsley --- Makefile | 6 +-- scripts/Makefile.build | 24 ++-- tools/objtool/Build| 3 +- tools/objtool/Makefile | 12

[PATCH v2 12/13] objtool: recordmcount: Search for __mcount_loc before walking the sections

2019-06-11 Thread Matt Helsley
string pointer trick. Signed-off-by: Matt Helsley --- tools/objtool/recordmcount.c | 2 -- tools/objtool/recordmcount.h | 22 +++--- 2 files changed, 3 insertions(+), 21 deletions(-) diff --git a/tools/objtool/recordmcount.c b/tools/objtool/recordmcount.c index 61050b78d5a0

[PATCH bpf v2] bpf: fix nested bpf tracepoints with per-cpu data

2019-06-11 Thread Matt Mullins
in nmi context (at most one of which may be a kprobe or perf event). Fixes: 20b9d7ac4852 ("bpf: avoid excessive stack usage for perf_sample_data") Signed-off-by: Matt Mullins --- v1->v2: * reverse-Christmas-tree-ize the declarations in bpf_perf_event_output * instantiate err

RE: [PATCH v2] staging: kpc2000: kpc_i2c: remove the macros inb_p and outb_p

2019-06-11 Thread Matt Sickler
>-Original Message- >From: devel On Behalf Of >Geordan Neukum > >This inb() call looks like a bug. We perform a 64-bit operation when >talking to this hardware register everywhere else in this driver. Anyone >have more insight into the hardware with which this driver interacts >such that

Re: [PATCH] sched/topology: Improve load balancing on AMD EPYC

2019-06-10 Thread Matt Fleming
On Wed, 05 Jun, at 08:00:35PM, Peter Zijlstra wrote: > > And then we had two magic values :/ > > Should we not 'fix' RECLAIM_DISTANCE for EPYC or something? Because > surely, if we want to load-balance agressively over 30, then so too > should we do node_reclaim() I'm thikning. Yeah we can fix

Re: [PATCH bpf] bpf: fix nested bpf tracepoints with per-cpu data

2019-06-06 Thread Matt Mullins
On Thu, 2019-06-06 at 15:13 -0700, Jakub Kicinski wrote: > On Thu, 6 Jun 2019 11:54:27 -0700, Matt Mullins wrote: > > BPF_PROG_TYPE_RAW_TRACEPOINTs can be executed nested on the same CPU, as > > they do not increment bpf_prog_active while executing. > > > > This enab

[PATCH bpf] bpf: fix nested bpf tracepoints with per-cpu data

2019-06-06 Thread Matt Mullins
BPF_PROG_TYPE_RAW_TRACEPOINTs can be executed nested on the same CPU, as they do not increment bpf_prog_active while executing. This enables three levels of nesting, to support - a kprobe or raw tp or perf event, - another one of the above that irq context happens to call, and - another one

RE: [PATCH] staging: kpc2000: kpc_dma: fix symbol 'kpc_dma_add_device' was not declared.

2019-06-05 Thread Matt Sickler
>This was reported by sparse: >drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:39:7: warning: symbol >'kpc_dma_add_device >' was not declared. Should it be static? > >Signed-off-by: Valerio Genovese >--- > drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h | 1 + > 1 file changed, 1 insertion(+) >

[PATCH] sched/topology: Improve load balancing on AMD EPYC

2019-06-05 Thread Matt Fleming
e balancer kicks in after a few seconds and forcibly moves some threads to node 4. Update the code in sd_init() to account for modern node distances, and maintaining backward-compatible behaviour by respecting RECLAIM_DISTANCE for distances more than 2 hops. Signed-off-by: Matt Fleming Cc: &quo

Re: [PATCH bpf v2] bpf: preallocate a perf_sample_data per event fd

2019-06-03 Thread Matt Mullins
On Tue, 2019-06-04 at 02:43 +0200, Daniel Borkmann wrote: > On 06/04/2019 01:54 AM, Alexei Starovoitov wrote: > > On Mon, Jun 3, 2019 at 4:48 PM Daniel Borkmann wrote: > > > On 06/04/2019 01:27 AM, Alexei Starovoitov wrote: > > > > On Mon, Jun 3, 2019

Re: [PATCH bpf v2] bpf: preallocate a perf_sample_data per event fd

2019-06-03 Thread Matt Mullins
On Mon, 2019-06-03 at 15:22 +0200, Daniel Borkmann wrote: > On 06/03/2019 03:08 PM, Daniel Borkmann wrote: > > On 06/01/2019 12:37 AM, Matt Mullins wrote: > > > It is possible that a BPF program can be called while another BPF > > > program is executing bpf_perf_e

[PATCH bpf v2] bpf: preallocate a perf_sample_data per event fd

2019-05-31 Thread Matt Mullins
t and fail a bpf_perf_event_output if that element is concurrently being used. Fixes: 20b9d7ac4852 ("bpf: avoid excessive stack usage for perf_sample_data") Signed-off-by: Matt Mullins --- v1->v2: keep a pointer to the struct perf_sample_data rather than directly embedd

[PATCH] x86/kgdb: return 0 from kgdb_arch_set_breakpoint

2019-05-31 Thread Matt Mullins
. Cannot access memory at address 0x81288910 Command aborted. Fixes: 86a22057127d ("x86/kgdb: Avoid redundant comparison of patched code") Signed-off-by: Matt Mullins --- arch/x86/kernel/kgdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/

Re: [PATCH bpf] bpf: preallocate a perf_sample_data per event fd

2019-05-30 Thread Matt Mullins
On Thu, 2019-05-30 at 23:28 +, Song Liu wrote: > > On May 30, 2019, at 3:55 PM, Matt Mullins wrote: > > > > It is possible that a BPF program can be called while another BPF > > program is executing bpf_perf_event_output. This has been observed with > > I/O co

Re: [RFC][PATCH 00/13] Cleanup recordmcount and begin objtool conversion

2019-05-30 Thread Matt Helsley
d their arguments came afterwards? I'm thinking it'd go somewhat like this: objtool foo.o [bar.o] -- check [check opts] + \ orc generate [orc opts] + \ mcount record [mcount opts] Then objtool would iterate over the object file(s) to open, hand off the ELF data structures into each successive pass, and finally write any accumulated changes back. Cheers, -Matt

RE: [PATCH 1/4] staging: kpc2000: add spaces around operators in core.c

2019-05-30 Thread Matt Sickler
>From: devel On Behalf Of >Greg KH >On Fri, May 24, 2019 at 01:07:59PM +0200, Simon Sandström wrote: >> --- a/drivers/staging/kpc2000/kpc2000/core.c >> +++ b/drivers/staging/kpc2000/kpc2000/core.c >> @@ -276,18 +276,18 @@ static ssize_t kp2000_cdev_read(struct file *filp, > >This whole function

[PATCH bpf] bpf: preallocate a perf_sample_data per event fd

2019-05-30 Thread Matt Mullins
t and fail a bpf_perf_event_output if that element is concurrently being used. Fixes: 20b9d7ac4852 ("bpf: avoid excessive stack usage for perf_sample_data") Signed-off-by: Matt Mullins --- It felt a bit overkill, but I had to split bpf_event_entry into its own header file to break a

[RFC][PATCH 05/13] recordmcount: Kernel style function signature formatting

2019-05-22 Thread Matt Helsley
The uwrite() and ulseek() functions are formatted inconsistently with the rest of the file and the kernel overall. While we're making other changes here let's fix this. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 21 +++-- scripts/recordmcount.h | 13

[RFC][PATCH 01/13] recordmcount: Remove redundant strcmp

2019-05-22 Thread Matt Helsley
The strcmp is unnecessary since .text is already accepted as a prefix in the strncmp(). Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index a50a2aa963ad..7f835059e7c2

[RFC][PATCH 02/13] recordmcount: Remove uread()

2019-05-22 Thread Matt Helsley
only caller, mmap_file(), is doing the relevant allocations and associated initializations. Therefore it's clearer to use a plain read() call to initialize the data in mmap_file() and remove uread(). Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 18 +- 1 file changed, 5

[RFC][PATCH 09/13] objtool: Prepare to merge recordmcount

2019-05-22 Thread Matt Helsley
Move recordmcount into the objtool directory. We keep this step separate so changes which turn recordmcount into a subcommand of objtool don't get obscured. Signed-off-by: Matt Helsley --- scripts/.gitignore | 1 - scripts/Makefile | 1

[RFC][PATCH 08/13] recordmcount: Clarify what cleanup() does

2019-05-22 Thread Matt Helsley
they're related. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 151 ++--- 1 file changed, 81 insertions(+), 70 deletions(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index 1c8b38c0d7fe..697c567c2517 100644 --- a/scripts

[RFC][PATCH 04/13] recordmcount: Rewrite error/success handling

2019-05-22 Thread Matt Helsley
-- there we use pointer comparison rather than string comparison to differentiate between previously-processed object files and returning the name of a text section. Signed-off-by: Matt Helsley --- scripts/recordmcount.c | 160 + scripts/recordmcount.h | 134

<    1   2   3   4   5   6   7   8   9   10   >