[PATCH 1/2] tools/power turbostat: Correct SNB_C1/C3_AUTO_UNDEMOTE defines

2018-02-13 Thread Matt Turner
According to the Intel Software Developers' Manual, Vol. 4, Order No. 335592, these macros have been reversed since they were added. Fixes: 889facbee3e6 ("tools/power turbostat: v3.0: monitor Watts and Temperature") Signed-off-by: Matt Turner --- tools/power/x86/turbostat/

Re: [PATCH v2 15/15] MIPS: memblock: Deactivate bootmem allocator

2018-02-13 Thread Matt Redfearn
MIPS. It makes conflicts easier to manage. Thanks, Matt select HAVE_MEMBLOCK select HAVE_MEMBLOCK_NODE_MAP select HAVE_MOD_ARCH_SPECIFIC

Re: [PATCH v2 14/15] MIPS: memblock: Discard bootmem from SGI IP27 code

2018-02-13 Thread Matt Redfearn
P27, but the change looks sensible to me. Reviewed-by: Matt Redfearn Signed-off-by: Serge Semin --- arch/mips/sgi-ip27/ip27-memory.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/mips/sgi-ip27/ip27-memory.c b/arch/mips/sgi-ip27/ip27-memory.c index 59133d0a

Re: [PATCH v2 13/15] MIPS: memblock: Discard bootmem from Loongson3 code

2018-02-13 Thread Matt Redfearn
kernel/addrspace_offset memory regions. I don't have a NUMA Loongson to test with, but on a non-NUMA Loongson3 machine, tested as a part of the whole series, this works and looks good to me. Reviewed-by: Matt Redfearn Thanks, Matt Signed-off-by: Serge Semin --- arch/mips/loong

Re: [PATCH v2 12/15] MIPS: memblock: Print out kernel virtual mem layout

2018-02-13 Thread Matt Redfearn
and memblock. It would be better to have a short sequence of patches to make that transition, with patches to lead up to that or clean up afterwards at the beginning and end of the series. It will just make any future bisection easier. Thanks, Matt Signed-off-by: Serge Semin --- arch

Re: [PATCH v2 09/15] MIPS: memblock: Simplify DMA contiguous reservation

2018-02-13 Thread Matt Redfearn
Hi Serge, On 02/02/18 03:54, Serge Semin wrote: CMA reserves it areas in the memblock allocator. Since we aren't using bootmem anymore, the reservations copying should be discarded. Signed-off-by: Serge Semin Looks good to me Reviewed-by: Matt Redfearn Thanks, Matt --- arch

Re: [PATCH v2 11/15] MIPS: memblock: Perform early low memory test

2018-02-13 Thread Matt Redfearn
sting at this point in the boot sequence should be safe since all critical areas are now reserved and a minimum of allocations have been done." Otherwise, looks good to me. Reviewed-by: Matt Redfearn Thanks, Matt Signed-off-by: Serge Semin --- arch/mips/kernel/setup.c | 2 ++ 1 fi

Re: [PATCH v2 10/15] MIPS: memblock: Allow memblock regions resize

2018-02-13 Thread Matt Redfearn
Hi Serge, On 02/02/18 03:54, Serge Semin wrote: When all the main reservations are done the memblock regions can be dynamically resized. Additionally it would be useful to have memblock regions dumped on debug at this point. Signed-off-by: Serge Semin Looks good to me. Reviewed-by: Matt

Re: [PATCH v2 08/15] MIPS: memblock: Mark present sparsemem sections

2018-02-13 Thread Matt Redfearn
memory_present without CONFIG_SPARSEMEM, is it really conditional on SPARSEMEM? Thanks, Matt sparse_init(); plat_swiotlb_setup();

Re: [PATCH v2 07/15] MIPS: memblock: Reserve kdump/crash regions in memblock

2018-02-13 Thread Matt Redfearn
Hi Serge, On 02/02/18 03:54, Serge Semin wrote: Kdump/crashkernel memory regions should be reserved in the memblock allocator so they wouldn't be occupied by any further allocations. Signed-off-by: Serge Semin This looks good to me Reviewed-by: Matt Redfearn Thanks, Matt ---

Re: [PATCH v2 06/15] MIPS: memblock: Add reserved memory regions to memblock

2018-02-13 Thread Matt Redfearn
boot_mem_map.map[i].size, - BOOTMEM_DEFAULT); - continue; - } I think this change maybe belongs in "MIPS: memblock: Discard bootmem initialization"? Thanks, Matt + /* +* Reserve requested me

Re: [PATCH v2 05/15] MIPS: KASLR: Drop relocatable fixup from reservation_init

2018-02-13 Thread Matt Redfearn
Hi Serge, On 02/02/18 03:54, Serge Semin wrote: From: Matt Redfearn A recent change ("MIPS: memblock: Discard bootmem initialization") removed the reservation of all memory below the kernel's _end symbol in bootmem. This makes the call to free_bootmem unnecessary, since the m

Re: [PATCH v2 04/15] MIPS: memblock: Discard bootmem initialization

2018-02-13 Thread Matt Redfearn
ic void __init bootmem_init(void) memory_present(0, start, end); } - /* -* Reserve the bootmap memory. -*/ - reserve_bootmem(PFN_PHYS(mapstart), bootmap_size, BOOTMEM_DEFAULT); - #ifdef CONFIG_RELOCATABLE /* * The kernel reserves all memory below its _end symbol as bootmem, Thanks, Matt

Re: [PATCH v2 03/15] MIPS: memblock: Reserve initrd memory in memblock

2018-02-13 Thread Matt Redfearn
On 02/02/18 03:54, Serge Semin wrote: There is no reserve_bootmem() method in the nobootmem interface, so we need to replace it with memblock-specific one. Signed-off-by: Serge Semin Looks good to me :-) Reviewed-by: Matt Redfearn Thanks, Matt --- arch/mips/kernel/setup.c | 2

Re: [PATCH v2 02/15] MIPS: memblock: Surely map BSS kernel memory section

2018-02-13 Thread Matt Redfearn
On 02/02/18 03:54, Serge Semin wrote: The current MIPS code makes sure the kernel code/data/init sections are in the maps, but BSS should also be there. Signed-off-by: Serge Semin Looks good to me :-) Reviewed-by: Matt Redfearn Thanks, Matt --- arch/mips/kernel/setup.c | 3 +++ 1

Re: [PATCH v2 01/15] MIPS: memblock: Add RESERVED_NOMAP memory flag

2018-02-13 Thread Matt Redfearn
case BOOT_MEM_RESERVED: default: res->name = "reserved"; + break; This is an unrelated change. With those 2 removed, I think this looks fine. Reviewed-by: Matt Redfearn Thanks, Matt } request_resource(&iomem_resource, res);

Re: [PATCH] lib: Rename compiler intrinsic selects to GENERIC_LIB_*

2018-02-09 Thread Matt Redfearn
Hi Andy, On 09/02/18 13:45, Andy Shevchenko wrote: On Fri, Feb 9, 2018 at 3:22 PM, Matt Redfearn wrote: When these are included into arch Kconfig files, maintaining alphabetical ordering of the selects means these get split up. To allow for keeping things tidier and alphabetical, rename the

[PATCH] lib: Rename compiler intrinsic selects to GENERIC_LIB_*

2018-02-09 Thread Matt Redfearn
When these are included into arch Kconfig files, maintaining alphabetical ordering of the selects means these get split up. To allow for keeping things tidier and alphabetical, rename the selects to GENERIC_LIB_* Signed-off-by: Matt Redfearn --- arch/riscv/Kconfig | 6 +++--- lib/Kconfig

Re: [PATCH 1/2] dt-bindings: Documentation for qcom,llcc

2018-02-08 Thread Matt Sealey
years of FDT on Arm? Notwithstanding the complete waste of rodata in the kernel image for matching (& increased time to compare), why wouldn't you consider why "bank-offset" for your node be any different than a common property for any other node? And if you need to describe register offsets... why aren't you able to use the reg property? Ta, Matt

Re: [PATCH RFC v2] sched: Minimize the idle cpu selection race window.

2018-02-07 Thread Matt Fleming
On Tue, 05 Dec, at 01:09:07PM, Atish Patra wrote: > Currently, multiple tasks can wakeup on same cpu from > select_idle_sibiling() path in case they wakeup simulatenously > and last ran on the same llc. This happens because an idle cpu > is not updated until idle task is scheduled out. Any task wak

Re: [PATCH] irqchip: mips-gic: Avoid spuriously handling masked interrupts

2018-02-07 Thread Matt Redfearn
Hi Marc, On 07/02/18 10:41, Marc Zyngier wrote: On 07/02/18 09:44, Matt Redfearn wrote: Hi Marc, On 07/02/18 09:41, Marc Zyngier wrote: On 05/02/18 16:45, Matt Redfearn wrote: Commit 7778c4b27cbe ("irqchip: mips-gic: Use pcpu_masks to avoid reading GIC_SH_MASK*") removed the r

Re: [PATCH] irqchip: mips-gic: Avoid spuriously handling masked interrupts

2018-02-07 Thread Matt Redfearn
Hi Marc, On 07/02/18 09:41, Marc Zyngier wrote: On 05/02/18 16:45, Matt Redfearn wrote: Commit 7778c4b27cbe ("irqchip: mips-gic: Use pcpu_masks to avoid reading GIC_SH_MASK*") removed the read of the hardware mask register when handling shared interrupts, instead using the drive

[PATCH] irqchip: mips-gic: Avoid spuriously handling masked interrupts

2018-02-05 Thread Matt Redfearn
c0 Where IRQ 13 is the UART interrupt. To fix this, just remove the write to pcpu_masks in gic_shared_irq_domain_map. The existing write in gic_unmask_irq is the correct place for what is now the effective unmasking. Fixes: 7778c4b27cbe ("irqchip: mips-gic: Use pcpu_masks to avoid reading G

[PULL] alpha.git

2018-02-02 Thread Matt Turner
Hi Linus, Please pull my alpha git tree. It contains a few small fixes and clean ups. Thanks, Matt The following changes since commit 8cbab92dff778e516064c13113ca15d4869ec883: Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma (2018-01-16 16:47:40 -

Re: [PATCH v3 2/2] MIPS: use generic GCC library routines from lib/

2018-01-31 Thread Matt Redfearn
in favour of similar routines from lib/. Signed-off-by: Antony Pavlov Cc: Palmer Dabbelt Cc: Matt Redfearn Cc: James Hogan Cc: Ralf Baechle Cc: linux-m...@linux-mips.org Cc: linux-kernel@vger.kernel.org --- arch/mips/Kconfig | 5 + arch/mips/lib/Makefile | 2 +- arch/mips/lib

Re: [PATCH v2 2/2] MIPS: use generic GCC library routines from lib/

2018-01-31 Thread Matt Redfearn
in favour of similar routines from lib/. Signed-off-by: Antony Pavlov Cc: Palmer Dabbelt Cc: Matt Redfearn Cc: James Hogan Cc: Ralf Baechle Cc: linux-m...@linux-mips.org Cc: linux-kernel@vger.kernel.org --- arch/mips/Kconfig | 5 + arch/mips/lib/Makefile | 2 +- arch/mips/lib

Re: [PATCH v2 1/2] Add notrace to lib/ucmpdi2.c

2018-01-31 Thread Matt Redfearn
Hi On 30/01/18 22:42, Antony Pavlov wrote: From: Palmer Dabbelt As part of the MIPS conversion to use the generic GCC library routines, Matt Redfearn discovered that I'd missed a notrace on __ucmpdi2(). This patch rectifies the problem. CC: Matt Redfearn CC: Antony Pavlov Signed-o

[PATCH] MIPS: TXx9: use IS_BUILTIN() for CONFIG_LEDS_CLASS

2018-01-29 Thread Matt Redfearn
33b44073734 ("MIPS: TXX9: use IS_ENABLED() macro") Signed-off-by: Matt Redfearn --- arch/mips/txx9/rbtx4939/setup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/txx9/rbtx4939/setup.c b/arch/mips/txx9/rbtx4939/setup.c index 8b937300fb7f..fd26fadc8617

Re: [PATCH V4 0/3] Use mm_struct and switch_mm() instead of manually

2018-01-26 Thread Matt Fleming
i_switch_mm() to do this. This improves readability and maintainability. > Also, instead of maintaining a separate struct "efi_scratch" to store/restore > efi_pgd, we can use mm_struct to do this. FWIW this series looks OK to me. Reviewed-by: Matt Fleming

Re: [PATCH 02/14] MIPS: memblock: Surely map BSS kernel memory section

2018-01-24 Thread Matt Redfearn
Hi Serge, On 23/01/18 19:27, Serge Semin wrote: Hello Matt, On Tue, Jan 23, 2018 at 11:03:27AM +, Matt Redfearn wrote: Hi Serge, On 22/01/18 21:47, Serge Semin wrote: Hello Matt, On Mon, Jan 22, 2018 at 04:35:26PM +, Matt Redfearn wrote: Hi Serge, On 17/01/18 22:23, Serge

Re: [PATCH 11/14] MIPS: memblock: Print out kernel virtual mem layout

2018-01-24 Thread Matt Redfearn
Hi Serge, On 23/01/18 19:10, Serge Semin wrote: Hello Matt, On Tue, Jan 23, 2018 at 03:35:14PM +, Matt Redfearn wrote: Hi Serge, On 19/01/18 14:27, Serge Semin wrote: On Fri, Jan 19, 2018 at 07:59:43AM +, Matt Redfearn wrote: Hello Matt, Hi Serge, On 18/01/18 20:18, Serge

Re: [PULL] alpha.git

2018-01-23 Thread Matt Turner
On Tue, Jan 23, 2018 at 2:23 AM, Mikulas Patocka wrote: > > > On Sat, 20 Jan 2018, Matt Turner wrote: > >> Hi Linus, >> >> Please pull my alpha git tree. It contains a build fix and a regression fix. >> >> Hopefully still in time for 4.15 :) >> &g

Re: [PATCH 11/14] MIPS: memblock: Print out kernel virtual mem layout

2018-01-23 Thread Matt Redfearn
Hi Serge, On 19/01/18 14:27, Serge Semin wrote: On Fri, Jan 19, 2018 at 07:59:43AM +, Matt Redfearn wrote: Hello Matt, Hi Serge, On 18/01/18 20:18, Serge Semin wrote: On Thu, Jan 18, 2018 at 12:03:03PM -0800, Florian Fainelli wrote: On 01/17/2018 02:23 PM, Serge Semin wrote: It

Re: [PATCH 00/14] MIPS: memblock: Switch arch code to NO_BOOTMEM

2018-01-23 Thread Matt Redfearn
Hi Mathieu, On 23/01/18 11:29, Mathieu Malaterre wrote: Hi Matt, On Mon, Jan 22, 2018 at 5:36 PM, Matt Redfearn wrote: Hi Serge, On 17/01/18 22:22, Serge Semin wrote: Even though it's common to see the architecture code using both bootmem and memblock early memory allocators, it&

Re: [PATCH v2] MIPS: fix incorrect mem=X@Y handling

2018-01-23 Thread Matt Redfearn
s factory default command line args of "mem=256M@0x0 mem=768M@0x3000" are passed. Though those arguments appear redundant since without them both memory regions are detected through device tree instead, and there is no problem. Tested-by: Matt Redfearn --- v2: Use updated email a

Re: [PATCH 02/14] MIPS: memblock: Surely map BSS kernel memory section

2018-01-23 Thread Matt Redfearn
Hi Serge, On 22/01/18 21:47, Serge Semin wrote: Hello Matt, On Mon, Jan 22, 2018 at 04:35:26PM +, Matt Redfearn wrote: Hi Serge, On 17/01/18 22:23, Serge Semin wrote: The current MIPS code makes sure the kernel code/data/init sections are in the maps, but BSS should also be there

Re: [PATCH 00/14] MIPS: memblock: Switch arch code to NO_BOOTMEM

2018-01-22 Thread Matt Redfearn
ards/generic code had been discarded. Here are the list of folks, who agreed to perform some tests of the patchset: Alexander Sverdlin - Octeon2 Matt Redfearn - Loongson3, etc I have applied and tested these patches on various platforms that we have available here, and the kernel appears to boot a

Re: [PATCH 02/14] MIPS: memblock: Surely map BSS kernel memory section

2018-01-22 Thread Matt Redfearn
below _end. Reviewed-by: Matt Redfearn Thanks, Matt Signed-off-by: Serge Semin --- arch/mips/kernel/setup.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c index 76e9e2075..0d21c9e04 100644 --- a/arch/mips/kernel/setup.c +++ b/arch

[PULL] alpha.git

2018-01-20 Thread Matt Turner
Hi Linus, Please pull my alpha git tree. It contains a build fix and a regression fix. Hopefully still in time for 4.15 :) Thanks, Matt The following changes since commit 8cbab92dff778e516064c13113ca15d4869ec883: Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kerne

Re: [PATCH 11/14] MIPS: memblock: Print out kernel virtual mem layout

2018-01-19 Thread Matt Redfearn
ation, so you could use CONFIG_RELOCATABLE. The existing KASLR stuff additionally hides this kind of information behind CONFIG_DEBUG_KERNEL, so that only people actively debugging the kernel see it: http://elixir.free-electrons.com/linux/v4.15-rc8/source/arch/mips/kernel/setup.c#L604 Thanks,

Re: [PATCH] MIPS: use generic GCC library routines from lib/

2018-01-17 Thread Matt Redfearn
b; > - w.s.low = ((unsigned int) uu.s.low >> b) | carries; > - } > - > - return w.ll; > -} > - > -EXPORT_SYMBOL(__lshrdi3); > diff --git a/arch/mips/lib/ucmpdi2.c b/arch/mips/lib/ucmpdi2.c > deleted file mode 100644 > index c31c78ca4175..

Re: [PATCH] bcma: Prevent build of PCI host features in module

2018-01-15 Thread Matt Redfearn
Hi Kalle, On 15/01/18 10:07, Kalle Valo wrote: Matt Redfearn writes: Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in a build error due to use of symbols not exported from vmlinux: ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefi

[PATCH] ssb: Prevent build of PCI host features in module

2018-01-12 Thread Matt Redfearn
ake[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 To prevent this, don't allow the host mode feature to be built if CONFIG_SSB=m Signed-off-by: Matt Redfearn --- drivers/ssb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ssb/Kconfig b/drivers/ssb/K

[PATCH] bcma: Prevent build of PCI host features in module

2018-01-12 Thread Matt Redfearn
ake[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1 To prevent this, don't allow the host mode feature to be built if CONFIG_BCMA=m Signed-off-by: Matt Redfearn --- drivers/bcma/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bcma/Kconfig b/d

[PATCH 4/6] irqchip/mips-gic: Always attempt to enable EIC mode

2018-01-05 Thread Matt Redfearn
CPU flags to reflect that VEIC mode is now active. Signed-off-by: Matt Redfearn --- drivers/irqchip/irq-mips-gic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c index ef92a4d2038e..ee391f42e97d 100644 --- a/drivers/irqchip

[PATCH 6/6] irqchip/mips-gic: Separate local interrupt handling.

2018-01-05 Thread Matt Redfearn
__gic_irq_dispatch to __gic_irq_dispatch_local, which is only called for local interrupt sources now so no longer needs to handle shared interrupts. Signed-off-by: Matt Redfearn --- drivers/irqchip/irq-mips-gic.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH 5/6] irqchip/mips-gic: Use separate vector for shared interrupts in EIC mode

2018-01-05 Thread Matt Redfearn
introduces additional latency into the interrupt paths which is easy to remove in EIC mode by making use of an additional vector for shared interrupt sources. Signed-off-by: Matt Redfearn --- drivers/irqchip/irq-mips-gic.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff

[PATCH 3/6] MIPS: Generic: Support GIC in EIC mode

2018-01-05 Thread Matt Redfearn
hould panic. Support for alternative EICs being present is needed here for the generic kernel to support them. Suggested-by: Paul Burton Signed-off-by: Matt Redfearn --- arch/mips/generic/irq.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/mips/ge

[PATCH 1/6] MIPS: Move ehb() to barrier.h

2018-01-05 Thread Matt Redfearn
The current location of ehb() in mipsmtregs.h does not make sense, since it is not strictly related to multi-threading, and may be used in code which does not include mipsmtregs.h Signed-off-by: Matt Redfearn --- arch/mips/include/asm/barrier.h| 13 + arch/mips/include/asm

[PATCH 0/6] irqchip/mips-gic: Enable & use VEIC mode if available

2018-01-05 Thread Matt Redfearn
tested on Boston, Malta & SEAD3 MIPS platforms implementing a GIC with and without EIC mode supported in hardware. Matt Redfearn (6): MIPS: Move ehb() to barrier.h MIPS: CPS: Introduce mips_gic_enable_eic MIPS: Generic: Support GIC in EIC mode irqchip/mips-gic: Always attempt to en

[PATCH 2/6] MIPS: CPS: Introduce mips_gic_enable_eic

2018-01-05 Thread Matt Redfearn
CPU flags to reflect that VEIC mode is now active. Signed-off-by: Matt Redfearn --- arch/mips/include/asm/mips-gic.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/mips/include/asm/mips-gic.h b/arch/mips/include/asm/mips-gic.h index 558059a8f218..b8345b117224

[tip:efi/core] MAINTAINERS: Remove Matt Fleming as EFI co-maintainer

2018-01-03 Thread tip-bot for Matt Fleming
Commit-ID: 81b60dbff04980a45b348c5b5eeca2713d4594ca Gitweb: https://git.kernel.org/tip/81b60dbff04980a45b348c5b5eeca2713d4594ca Author: Matt Fleming AuthorDate: Wed, 3 Jan 2018 09:44:17 + Committer: Ingo Molnar CommitDate: Wed, 3 Jan 2018 14:03:18 +0100 MAINTAINERS: Remove Matt

Re: [PATCH] MAINTAINERS: Remove Matt Fleming as EFI co-maintainer

2018-01-03 Thread Matt Fleming
On Wed, 03 Jan, at 10:13:55AM, Ard Biesheuvel wrote: > On 3 January 2018 at 09:44, Matt Fleming wrote: > > Instate Ard Biesheuvel as the sole EFI maintainer and leave other folks > > as maintainers for the EFI test driver and efivarfs file system. > > > > Signed-off-b

[PATCH] include/uapi/linux/swab: Fix potentially missing __always_inline

2018-01-03 Thread Matt Redfearn
n it's indirect inclusion. compiler.h is then included indirectly, via stddef.h. Fixes: 283d75737837 ("uapi/linux/stddef.h: Provide __always_inline to userspace headers") Signed-off-by: Matt Redfearn --- include/uapi/linux/swab.h | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH] MAINTAINERS: Remove Matt Fleming as EFI co-maintainer

2018-01-03 Thread Matt Fleming
Instate Ard Biesheuvel as the sole EFI maintainer and leave other folks as maintainers for the EFI test driver and efivarfs file system. Signed-off-by: Matt Fleming --- MAINTAINERS | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) Ard, if you want to add yourself as co-maintainer of

[PATCH 2/2] MIPS: Watch: Avoid duplication of bits in mips_read_watch_registers

2018-01-02 Thread Matt Redfearn
Currently the bits to be masked when watchhi is read is defined inline for each register. To avoid this, define the bits once and mask each register with that value. Signed-off-by: Matt Redfearn --- arch/mips/kernel/watch.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions

[PATCH 1/2] MIPS: Watch: Avoid duplication of bits in mips_install_watch_registers.

2018-01-02 Thread Matt Redfearn
Currently the bits to be set in the watchhi register in addition to that requested by the user is defined inline for each register. To avoid this, define the bits once and or that in for each register. Signed-off-by: Matt Redfearn --- arch/mips/kernel/watch.c | 17 +++-- 1 file

Re: [RFC PATCH 01/60] hyper_dmabuf: initial working version of hyper_dmabuf drv

2017-12-26 Thread Matt Roper
GEM ioctls or whatever) wouldn't be directly transferrable to the global compositor. For graphics use cases like this, we could probably hide a lot of the details by modifying/replacing the EGL implementation that handles the details of buffer allocation. However if we have applications that

Re: [PATCH 1/3] MIPS: c-r4k: instruction_hazard should immediately follow cache op

2017-12-21 Thread Matt Redfearn
Hi James, On 21/12/17 15:30, James Hogan wrote: On Thu, Dec 21, 2017 at 03:19:35PM +, Matt Redfearn wrote: Hi James, On 21/12/17 15:14, James Hogan wrote: On Thu, Dec 21, 2017 at 11:16:02AM +, Matt Redfearn wrote: During ftrace initialisation, placeholder instructions in the

Re: [PATCH 1/3] MIPS: c-r4k: instruction_hazard should immediately follow cache op

2017-12-21 Thread Matt Redfearn
Hi James, On 21/12/17 15:14, James Hogan wrote: On Thu, Dec 21, 2017 at 11:16:02AM +, Matt Redfearn wrote: During ftrace initialisation, placeholder instructions in the prologue of every kernel function not marked "notrace" are replaced with nops. After the instructions are writt

[PATCH 3/3] MIPS: Add barrier between icache flush and execution hazard barrier

2017-12-21 Thread Matt Redfearn
instruction_hazard to ensure that the pipeline is stalled until the icache operation is completed and the core will fetch the new instructions. Suggested-by: Leonid Yegoshin Signed-off-by: Matt Redfearn Cc: Paul Burton Cc: James Hogan Cc: stable # v4.9+ --- arch/mips/mm/c-r4k.c | 2 ++ 1 file changed, 2

[PATCH 2/3] MIPS: Add barrier between dcache & icache flushes

2017-12-21 Thread Matt Redfearn
Burton Signed-off-by: Matt Redfearn Cc: James Hogan Cc: stable # v4.9+ --- arch/mips/mm/c-r4k.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c index ce7a54223504..b7186d47184b 100644 --- a/arch/mips/mm/c-r4k.c +++ b/arch/mips/mm/c-r4k.c @@

[PATCH 1/3] MIPS: c-r4k: instruction_hazard should immediately follow cache op

2017-12-21 Thread Matt Redfearn
ion_hazard() within __local_r4k_flush_icache_range. The one at the end of __r4k_flush_icache_range is too late, since all of the functions in the call path of preempt_enable have already been executed, so remove it. This fixes the crashes during ftrace initialisation on Ci40. Signed-off-by: Matt Re

[PATCH] clocksource/drivers/mips-gic-timer: Add pr_fmt and reword pr_* messages

2017-12-20 Thread Matt Redfearn
Several messages from the MIPS GIC driver include the text "GIC", "GIC timer", etc, but the format is not standard. Add a pr_fmt of "mips-gic-timer: " and reword the messages now that they will be prefixed with the driver name. Signed-off-by: Matt Redfearn ---

Re: [PATCH V2] x86/efi: fix kernel param add_efi_memmap regression

2017-12-18 Thread Matt Fleming
On Sat, 16 Dec, at 12:19:53PM, Dave Young wrote: > 'add_efi_memmap' is an early param, but do_add_efi_memmap() has no > chance to run because the code path is before parse_early_param(). > I believe it worked when the param was introduced but probably later > some other changes caused the wrong ord

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-18 Thread Matt Fleming
On Sat, 16 Dec, at 03:06:32PM, Ingo Molnar wrote: > > * Matt Fleming wrote: > > > > x86_init.oem.arch_setup(); > > > @@ -962,6 +959,8 @@ void __init setup_arch(char **cmdline_p) > > > > > > parse_early_para

Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all

2017-12-15 Thread Matt Fleming
On Sat, 09 Dec, at 04:52:52PM, Vincent Legoll wrote: > No need to get into the submenu to disable all related > config entries. > > This makes it easier to disable all EFI config options > without entering the submenu. It will also enable one > to see that en/dis-abled state from the outside menu.

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-15 Thread Matt Fleming
On Thu, 14 Dec, at 06:41:19PM, Dave Young wrote: > On 11/30/17 at 01:23pm, Dave Young wrote: > > 'add_efi_memmap' is an early param, but do_add_efi_memmap() has no > > chance to run because the code path is before parse_early_param(). > > I believe it worked when the param was introduced but probab

Re: [PATCH] efi: Use PTR_ERR_OR_ZERO()

2017-12-15 Thread Matt Fleming
On Tue, 28 Nov, at 10:39:37PM, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by:

[PATCH 2/2] MIPS: pm-cps: Warn if JTAG presence will block power gating

2017-12-15 Thread Matt Redfearn
powered down and will block a full power down of the cluster. We use a ratelimited pr_warn since this path will also be hit by cpu idle if it attempts to put cores into the powered down state. Signed-off-by: Matt Redfearn --- arch/mips/kernel/pm-cps.c | 13 + 1 file changed, 13 insertions

[PATCH 1/2] MIPS: SMP-CPS: Remove duplicate assignment of core in play_dead

2017-12-15 Thread Matt Redfearn
uplicate. Signed-off-by: Matt Redfearn --- arch/mips/kernel/smp-cps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/mips/kernel/smp-cps.c b/arch/mips/kernel/smp-cps.c index ecc1a853f48d..03f1026ad148 100644 --- a/arch/mips/kernel/smp-cps.c +++ b/arch/mips/kernel/smp-cps.c @@ -439,8

Re: NFS corruption, fixed by echo 1 > /proc/sys/vm/drop_caches -- next debugging steps?

2017-12-09 Thread Matt Turner
On Fri, Dec 8, 2017 at 1:16 PM, Eric Dumazet wrote: > On Fri, 2017-12-08 at 12:26 -0800, Matt Turner wrote: >> >> Thanks for the quick reply! >> >> I tried the patch on top of master, but unfortunately the corruption >> still occurs. > > You might try replac

Re: NFS corruption, fixed by echo 1 > /proc/sys/vm/drop_caches -- next debugging steps?

2017-12-08 Thread Matt Turner
On Fri, Dec 8, 2017 at 5:52 AM, Eric Dumazet wrote: > On Fri, 2017-12-08 at 05:42 -0800, Eric Dumazet wrote: >> On Thu, Dec 7, 2017 at 11:54 PM, Matt Turner >> wrote: >> > On Thu, Dec 7, 2017 at 11:00 PM, Matt Turner >> > wrote: >> > > On Sun, Mar 1

Re: NFS corruption, fixed by echo 1 > /proc/sys/vm/drop_caches -- next debugging steps?

2017-12-07 Thread Matt Turner
On Thu, Dec 7, 2017 at 11:00 PM, Matt Turner wrote: > On Sun, Mar 12, 2017 at 6:43 PM, Matt Turner wrote: >> On a Broadcom BCM91250a MIPS system I can reliably trigger NFS >> corruption on the first file read. >> >> To demonstrate, I downloaded five identical copies

Re: NFS corruption, fixed by echo 1 > /proc/sys/vm/drop_caches -- next debugging steps?

2017-12-07 Thread Matt Turner
On Sun, Mar 12, 2017 at 6:43 PM, Matt Turner wrote: > On a Broadcom BCM91250a MIPS system I can reliably trigger NFS > corruption on the first file read. > > To demonstrate, I downloaded five identical copies of the gcc-5.4.0 > source tarball. On the NFS server, they hash to

Re: [GIT PULL] hash addresses printed with %p

2017-12-02 Thread Matt Fleming
(Cc'ing Dave since this is used for kexec on EFI) On Fri, 01 Dec, at 09:54:43AM, Ard Biesheuvel wrote: > On 1 December 2017 at 09:48, Greg Kroah-Hartman > wrote: > > On Thu, Nov 30, 2017 at 05:18:42PM +, Ard Biesheuvel wrote: > >> On 30 November 2017 at 17:10, Greg Kroah-Hartman > >> wrote:

[PATCH v2] MIPS: Add custom serial.h with BASE_BAUD override for generic kernel

2017-11-28 Thread Matt Redfearn
his commit, combined with "serial: 8250_early: Only set divisor if valid clk & baud" prevents the earlycon code setting a bad divisor and restores earlycon output. Fixes: 31cb9a8575ca ("earlycon: initialise baud field of earlycon device structure") Cc: stable # 4.14 Signed-off-b

Re: [PATCH 2/2] MIPS: Add custom serial.h with BASE_BAUD override for generic kernel

2017-11-28 Thread Matt Redfearn
On 28/11/17 14:35, Greg Kroah-Hartman wrote: On Wed, Nov 22, 2017 at 09:57:29AM +, Matt Redfearn wrote: Add a custom serial.h header for MIPS, allowing platforms to override the asm-generic version if required. The generic platform uses this header to set BASE_BAUD to 0. The generic

[PATCH 1/2] serial: 8250_early: Only set divisor if valid clk & baud

2017-11-22 Thread Matt Redfearn
ture where previously it was left as 0. All boards supported by the MIPS generic kernel started outputting garbage from the boot console due to an incorrect divisor being set. Fixes: 31cb9a8575ca ("earlycon: initialise baud field of earlycon device structure") Cc: stable # 4.14 Signed-o

[PATCH 2/2] MIPS: Add custom serial.h with BASE_BAUD override for generic kernel

2017-11-22 Thread Matt Redfearn
his commit, combined with "serial: 8250_early: Only set divisor if valid clk & baud" prevents the earlycon code setting a bad divisor and restores earlycon output. Fixes: 31cb9a8575ca ("earlycon: initialise baud field of earlycon device structure") Cc: stable # 4.14 Signed-off-b

Re: [PATCH v2] serial: 8250_pci: Add Amazon PCI serial device ID

2017-11-18 Thread Matt Wilson
On Mon, Nov 13, 2017 at 11:31:31AM -0800, Matt Wilson wrote: > From: Matt Wilson > > This device will be used in future Amazon EC2 instances as the primary > serial port (i.e., data sent to this port will be available via the > GetConsoleOuput [1] EC2 API). Ping? --msw

Re: [PATCH] MIPS: Fix exception entry when CONFIG_EVA enabled

2017-11-15 Thread Matt Redfearn
move into the branch delay slot for some reason. Any ideas? Thanks, Matt

[PATCH] MIPS: BCM47XX Avoid compile error with MIPS allnoconfig

2017-11-14 Thread Matt Redfearn
both, but not neither. Signed-off-by: Matt Redfearn --- arch/mips/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index 350a990fc719..659e0079487f 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -259,6 +259,7 @@ config BCM47XX

[PATCH 2/2] MIPS: RB532: Avoid undefined mac_pton without GENERIC_NET_UTILS

2017-11-14 Thread Matt Redfearn
latform to force inclusion of GENERIC_NET_UTILS which is selected by CONFIG_NET, just exclude the setup of the MAC address if CONFIG_NET is not selected in the kernel config. Signed-off-by: Matt Redfearn --- arch/mips/rb532/devices.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/

[PATCH 1/2] MIPS: RB532: Avoid undefined early_serial_setup() without SERIAL_8250_CONSOLE

2017-11-14 Thread Matt Redfearn
han adding dependencies to the platform to force inclusion of SERIAL_8250_CONSOLE together with it's dependencies like TTY, HAS_IOMEM, etc, just exclude arch/mips/rb532/serial.c from the build when it's dependency is not selected in the kernel config. Reported-by: Ralf Baechle Signed-off-by: Matt

Re: [PATCH] MIPS: ath25: Avoid undefined early_serial_setup() without SERIAL_8250_CONSOLE

2017-11-14 Thread Matt Redfearn
On 14/11/17 14:05, Ralf Baechle wrote: On Tue, Nov 14, 2017 at 01:29:17PM +, Matt Redfearn wrote: Currently MIPS allnoconfig with CONFIG_ATH25=y fails to link due to missing support for early_serial_setup(): LD vmlinux arch/mips/ath25/devices.o: In function ath25_serial_setup

[PATCH] MIPS: ath25: Avoid undefined early_serial_setup() without SERIAL_8250_CONSOLE

2017-11-14 Thread Matt Redfearn
dependencies to the platform to force inclusion of SERIAL_8250_CONSOLE together with it's dependencies like TTY, HAS_IOMEM, etc, just make ath25_serial_setup() a no-op when the dependency is not selected in the kernel config. Signed-off-by: Matt Redfearn --- arch/mips/ath25/devices.c | 2 +

[PATCH] watchdog: indydog: Add dependency on SGI_HAS_INDYDOG

2017-11-14 Thread Matt Redfearn
g/indydog.o:indydog.c:(.text+0xa8): more undefined references to `sgimc' follow make: *** [Makefile:1005: vmlinux] Error 1 Fix this by ensuring that CONFIG_INDIDOG can only be selected when the necessary dependent platform symbols are built in. Fixes: da2a68b3eb47 ("watchdog: Enable CO

[PATCH v2] serial: 8250_pci: Add Amazon PCI serial device ID

2017-11-13 Thread Matt Wilson
From: Matt Wilson This device will be used in future Amazon EC2 instances as the primary serial port (i.e., data sent to this port will be available via the GetConsoleOuput [1] EC2 API). [1] http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_GetConsoleOutput.html Cc: sta

[PATCH] serial: 8250_pci: Add Amazon PCI serial device ID

2017-11-12 Thread Matt Wilson
From: Matt Wilson Cc: sta...@vger.kernel.org Signed-off-by: Matt Wilson --- drivers/tty/serial/8250/8250_pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index 0c101a7..d4e7be8 100644 --- a/drivers/tty/serial

[PATCH 2/2] irqchip: mips-gic: Print warning if inherited GIC base is used

2017-11-09 Thread Matt Redfearn
Amit Kama Signed-off-by: Matt Redfearn Reviewed-by: Paul Burton --- drivers/irqchip/irq-mips-gic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c index 9b768899f07b..ef92a4d2038e 100644 --- a/drivers/irqchip/irq-mips-gic.c

[PATCH 1/2] irqchip/mips-gic: Add pr_fmt and reword pr_* messages

2017-11-09 Thread Matt Redfearn
Several messages from the MIPS GIC driver include the text "GIC", but the format is not standard. Add a pr_fmt of "irq-mips-gic: " and reword the messages now that they will be prefixed with the driver name. Signed-off-by: Matt Redfearn Reviewed-by: Paul Burton --- driv

Re: [PATCH AUTOSEL for-4.4 39/39] MIPS: Use Makefile.postlink to insert relocations into vmlinux

2017-11-09 Thread Matt Redfearn
On 08/11/17 20:50, Levin, Alexander (Sasha Levin) wrote: From: Matt Redfearn [ Upstream commit 44079d3509aee89c58f3e4fd929fa53ab2299019 ] When relocatable support for MIPS was merged, there was no support for an architecture to add a postlink step for vmlinux. This meant that only invoking

[RFC PATCH] earlycon: Search for uartclk provided by DT

2017-11-07 Thread Matt Redfearn
to allow earlycon to correctly configure the uartclk and hence drivers can calculate the right divisor, restoring console output. Fixes: 31cb9a8575ca ("earlycon: initialise baud field of earlycon device structure") Signed-off-by: Matt Redfearn --- I haven't handled the property yet,

Re: [GIT PULL 1/2] bcm2835-dt-fixes-2017-10-06

2017-11-02 Thread Matt Hart
On 1 November 2017 at 17:44, Stefan Wahren wrote: > Hi Matt, > >> Matt Hart hat am 1. November 2017 um 14:06 geschrieben: >> >> >> On 1 November 2017 at 12:05, Stefan Wahren wrote: >> > Hi Matt, hi Peter, >> > >> > Am 01.11.2017 um 10:3

[PATCH] MIPS: CPS: Fix use of current_cpu_data in preemptible code

2017-11-01 Thread Matt Redfearn
u_cluster(¤t_cpu_data) will always be 0, even if this task being preempted and continues running on a different CPU. Regardless, the BUG should not be triggered, so fix this by switching to raw_current_cpu_data. When multicluster support lands upstream this check will need removing or changing

Re: [GIT PULL 1/2] bcm2835-dt-fixes-2017-10-06

2017-11-01 Thread Matt Hart
On 1 November 2017 at 12:05, Stefan Wahren wrote: > Hi Matt, hi Peter, > > Am 01.11.2017 um 10:37 schrieb Peter Robinson: >> On Tue, Oct 31, 2017 at 5:00 PM, Matt Hart wrote: >>> On 6 October 2017 at 23:14, Florian Fainelli wrote: >>>> On 10/06/2017 03:05 PM,

Re: [PATCH v4 13/13] openrisc: add tick timer multi-core sync logic

2017-11-01 Thread Matt Redfearn
On 01/11/17 00:34, Stafford Horne wrote: On Wed, Nov 01, 2017 at 08:17:59AM +0900, Stafford Horne wrote: On Tue, Oct 31, 2017 at 02:06:21PM +, Matt Redfearn wrote: Hi, On 29/10/17 23:11, Stafford Horne wrote: In case timers are not in sync when cpus start (i.e. hot plug / offset

Re: [GIT PULL 1/2] bcm2835-dt-fixes-2017-10-06

2017-10-31 Thread Matt Hart
On 6 October 2017 at 23:14, Florian Fainelli wrote: > > On 10/06/2017 03:05 PM, Eric Anholt wrote: > > Hi Florian. Here's a patch that's gone through a couple of revisions > > on the list, that seriously fixes up the default serial behavior -- > > previously, without the right config.txt/cmdline

Re: [PATCH v4 13/13] openrisc: add tick timer multi-core sync logic

2017-10-31 Thread Matt Redfearn
u, true); after counters are synchronized. Thanks, Matt local_irq_enable(); preempt_disable(); diff --git a/arch/openrisc/kernel/sync-timer.c b/arch/openrisc/kernel/sync-timer.c new file mode 100644 index ..ed8d835caca1 --- /dev/null +++ b/arch/openrisc/kernel/sync-timer.c @

<    1   2   3   4   5   6   7   8   9   10   >