On Mon, Feb 22, 2021 at 12:45:23PM -0800, Stephen Boyd wrote:
> Quoting Matthias Kaehlcke (2021-02-22 12:38:46)
> > On Mon, Feb 22, 2021 at 12:20:04PM -0800, Stephen Boyd wrote:
> > > Quoting Matthias Kaehlcke (2021-02-19 18:10:59)
> > > > Lazor rev3 and older
On Tue, Feb 23, 2021 at 02:12:30PM +0300, Dmitry Baryshkov wrote:
> Hi,
>
> On Sat, 20 Feb 2021 at 05:13, Matthias Kaehlcke wrote:
> >
> > Lazor rev3 and older are stuffed with a 47k NTC as thermistor for
> > the charger temperature which currently isn't suppor
ping
I noticed this was never picked up, can it be landed or are there any
concerns with this patch?
On Tue, Sep 15, 2020 at 06:50:32PM -0500, Bjorn Andersson wrote:
> On Tue 15 Sep 14:31 CDT 2020, Matthias Kaehlcke wrote:
>
> > The dwc3-qcom currently enables wakeup interrupts unc
On Mon, Feb 22, 2021 at 03:20:53PM -0800, Doug Anderson wrote:
> Hi,
>
> On Fri, Feb 19, 2021 at 6:11 PM Matthias Kaehlcke wrote:
> >
> > Lazor rev3 and older are stuffed with a 47k NTC thermistor for the
> > charger temperature which currently isn't supported
On Mon, Feb 22, 2021 at 12:20:04PM -0800, Stephen Boyd wrote:
> Quoting Matthias Kaehlcke (2021-02-19 18:10:59)
> > Lazor rev3 and older are stuffed with a 47k NTC as thermistor for
> > the charger temperature which currently isn't supported by the
> > PM6150 ADC driver.
On Fri, Feb 19, 2021 at 09:05:32AM -0600, Rob Herring wrote:
> On Wed, Feb 17, 2021 at 7:33 PM Matthias Kaehlcke wrote:
> >
> > Hi Rob,
> >
> > thanks for your review!
> >
> > On Wed, Feb 17, 2021 at 03:04:41PM -0600, Rob Herring wrote:
> > > On
alues.
Signed-off-by: Matthias Kaehlcke
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 07c8b2c926c0..fa996387715b 100644
Lazor rev3 and older are stuffed with a 47k NTC as thermistor for
the charger temperature which currently isn't supported by the
PM6150 ADC driver. Delete the charger thermal zone and ADC channel
to avoid the use of bogus temperature values.
Signed-off-by: Matthias Kaehlcke
---
arch/arm64
Lazor rev3 and older are stuffed with a 47k NTC thermistor for the
charger temperature which currently isn't supported by the PM6150 ADC
driver. A supported thermistor is used in rev4 and later revisions.
Add rev4 .dts files to be able to account for this.
Signed-off-by: Matthias Kae
Hi Rob,
thanks for your review!
On Wed, Feb 17, 2021 at 03:04:41PM -0600, Rob Herring wrote:
> On Wed, Feb 10, 2021 at 09:10:36AM -0800, Matthias Kaehlcke wrote:
> > Discrete onboard USB hubs (an example for such a hub is the Realtek
> > RTS5411) need to be powered and may require
Hi Stephen,
On Thu, Feb 11, 2021 at 11:14:39AM -0800, Stephen Boyd wrote:
> Quoting Matthias Kaehlcke (2021-02-10 14:20:18)
> >
> > On Wed, Feb 10, 2021 at 10:06:45PM +0100, Krzysztof Kozlowski wrote:
> > >
> > > This looks hackish... what if later we have somet
On Thu, Feb 11, 2021 at 10:45:48AM -0800, Matthias Kaehlcke wrote:
> Hi Greg,
>
> On Thu, Feb 11, 2021 at 07:58:23AM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Feb 10, 2021 at 09:10:38AM -0800, Matthias Kaehlcke wrote:
> > > Check during probe() if a hub supporte
Hi Greg,
On Thu, Feb 11, 2021 at 07:58:23AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 10, 2021 at 09:10:38AM -0800, Matthias Kaehlcke wrote:
> > Check during probe() if a hub supported by the onboard_usb_hub
> > driver is connected to the controller. If such a hub is found
Hi Greg,
On Thu, Feb 11, 2021 at 08:03:01AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 10, 2021 at 09:10:37AM -0800, Matthias Kaehlcke wrote:
> > +static int onboard_hub_add_usbdev(struct onboard_hub *hub, struct
> > usb_device *udev)
> > +{
> > + struct ud
Hi Krzysztof,
On Wed, Feb 10, 2021 at 10:04:51PM +0100, Krzysztof Kozlowski wrote:
> On Wed, Feb 10, 2021 at 09:10:35AM -0800, Matthias Kaehlcke wrote:
> > This series adds the onboard_usb_hub_driver, the corresponding
> > device tree bindings and creation of onboard_usb_hub plat
Hi Krzysztof,
On Wed, Feb 10, 2021 at 10:06:45PM +0100, Krzysztof Kozlowski wrote:
> On Wed, Feb 10, 2021 at 09:10:38AM -0800, Matthias Kaehlcke wrote:
> > Check during probe() if a hub supported by the onboard_usb_hub
> > driver is connected to the controller. If such a hub is f
). Further the
platform device is only created when CONFIG_USB_ONBOARD_HUB=y/m.
Signed-off-by: Matthias Kaehlcke
---
Changes in v5:
- patch added to the series
drivers/usb/host/xhci-plat.c | 16
include/linux/usb/hcd.h | 2 ++
2 files changed, 18 insertions(+)
diff --git a
Add nodes for the onboard USB hub on trogdor devices. Remove the
'always-on' and 'boot-on' properties from the hub regulator, since
the regulator is now managed by the onboard_usb_hub driver.
Signed-off-by: Matthias Kaehlcke
---
Changes in v5:
- patch added to the series
evice is
needed. The relationship could be established through a phandle
in the node of the USB device(s).
Co-developed-by: Ravi Chandra Sadineni
Signed-off-by: Ravi Chandra Sadineni
Signed-off-by: Matthias Kaehlcke
---
Changes in v5:
- the platform device is now instantiated from the same DT node
d to leave the hub powered when a wakeup capable USB device
is connected when suspending, and power it off otherwise.
(no changes since v1)
Matthias Kaehlcke (4):
dt-bindings: usb: Add binding for discrete onboard USB hubs
USB: misc: Add onboard_usb_hub driver
usb: host: xhci-plat: Creat
Discrete onboard USB hubs (an example for such a hub is the Realtek
RTS5411) need to be powered and may require initialization of other
resources (like GPIOs or clocks) to work properly. This adds a device
tree binding for these hubs.
Signed-off-by: Matthias Kaehlcke
---
Changes in v5
labels for CPU zones are added for now.
Signed-off-by: Matthias Kaehlcke
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 22
On Wed, Oct 28, 2020 at 02:08:01AM +0530, Sandeep Maheswaram wrote:
> Configure interrupts based on hs_phy_mode to avoid triggering of
> interrupts during system suspend and suspends successfully.
> Set genpd active wakeup flag for usb gdsc if wakeup capable devices
> are connected so that wake up
> + dwc->hs_phy_mode |= PHY_MODE_USB_HOST_LS;
> +
> + if (DEV_SUPERSPEED(reg))
> + ss_phy_mode |= PHY_MODE_USB_HOST_SS;
> + }
> + }
> + phy_set_mode(dwc->usb2_generic_phy, dwc->hs_phy_mode);
> + phy_set_mode(dwc->usb3_generic_phy, ss_phy_mode);
> +}
> +
> +int xhci_dwc3_suspend_quirk(struct usb_hcd *hcd)
> +{
> + dwc3_set_phy_mode(hcd);
> + return 0;
> +}
> +
> void dwc3_host_exit(struct dwc3 *dwc)
> {
> platform_device_unregister(dwc->xhci);
Other than the nit:
Reviewed-by: Matthias Kaehlcke
On Sat, Nov 28, 2020 at 08:01:31AM +0530, mgau...@codeaurora.org wrote:
> Hi,
>
>
> On 2020-10-28 02:07, Sandeep Maheswaram wrote:
> > Avoiding phy powerdown in host mode so that it can be woken up by
> > devices.
> > Added hs_phy_mode flag to check connection status and set phy mode
> > and conf
e earlier revisions also allocated the GPIO to the
purpose of controlling the power switch, so there is no need to limit
the pinctrl config to newer revisions. Remove the platform-wide
'always/boot-on' properties from 'pp3300_l7c' and add them to the
boards that use this supply. A
t values these can be changed in dedicated patches.
Fixes: 22337b91022d ("arm64: dts: qcom: sc7180: Changed polling mode in
Thermal-zones node")
Signed-off-by: Matthias Kaehlcke
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 50 ++--
1 file changed, 25 insertions(+), 2
e earlier revisions also allocated the GPIO to the
purpose of controlling the power switch, so there is no need to limit
the pinctrl config to newer revisions. Remove the platform-wide
'always/boot-on' properties from 'pp3300_l7c' and add them to the
boards that use this supply. A
ev1 .dts files.
Signed-off-by: Matthias Kaehlcke
---
Changes in v3:
- rev3 switched the regulator, not rev2
- also handle rev2 in rev1 files
- fixed include in -r3-kb.dts
Changes in v2:
- patch added to the series
arch/arm64/boot/dts/qcom/Makefile | 3 +++
.../dts/qcom/sc7180-t
On Thu, Nov 05, 2020 at 05:05:38PM -0800, Doug Anderson wrote:
> Hi,
>
> On Thu, Nov 5, 2020 at 4:37 PM Matthias Kaehlcke wrote:
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
> > b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts
> > index
On Thu, Nov 05, 2020 at 04:55:40PM -0800, Doug Anderson wrote:
> Hi,
>
> On Thu, Nov 5, 2020 at 4:37 PM Matthias Kaehlcke wrote:
> >
> > One important delta with respect to rev1 is a switch of the power
> > supply for the onboard USB hub from 'pp3300_l7c' t
00_hub', since it affects the entire trogdor platform. Here we
only add the .dts files for lazor rev2 and replace the generic
compatible entries in the rev1 .dts files.
Signed-off-by: Matthias Kaehlcke
---
Changes in v2:
- patch added to the series
arch/arm64/boot/dts/qcom/Makefile
e earlier revisions also allocated the GPIO to the
purpose of controlling the power switch, so there is no need to limit
the pinctrl config to newer revisions. Remove the platform-wide
'always-on' property from 'pp3300_l7c' and add it to the boards that
use this supply. Also
On Thu, Nov 05, 2020 at 07:57:42AM -0800, Doug Anderson wrote:
> Hi,
>
> On Wed, Nov 4, 2020 at 5:55 PM Matthias Kaehlcke wrote:
> >
> > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > > > b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
&
Hi Doug,
On Wed, Nov 04, 2020 at 04:29:50PM -0800, Doug Anderson wrote:
> Hi,
>
> On Tue, Nov 3, 2020 at 10:38 AM Matthias Kaehlcke wrote:
> >
> > The trogdor design has two options for supplying the pp3300_hub power rail,
> > it can be supplied by pp3300_l7c or pp3
. Make this path the default and keep trogdor rev1,
lazor rev0 and rev1 on pp3300_l7c.
Signed-off-by: Matthias Kaehlcke
---
.../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 4 +++
.../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 4 +++
.../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 4 +++
arch
From: Antony Wang
Trogdor has a thermistor to monitor the temperature of the charger IC.
Add the ADC (monitor) nodes and a thermal zone for this thermistor.
Signed-off-by: Antony Wang
[ mka: tweaked commit message ]
Signed-off-by: Matthias Kaehlcke
---
arch/arm64/boot/dts/qcom/sc7180
Hi,
On Thu, Oct 15, 2020 at 12:07:01AM +0530, man...@codeaurora.org wrote:
> On 2020-10-14 18:59, Akhil P Oommen wrote:
> > On 10/9/2020 10:27 PM, Matthias Kaehlcke wrote:
> > > On Fri, Oct 09, 2020 at 08:05:10AM -0700, Doug Anderson wrote:
> > > > Hi,
> > &g
On Thu, Oct 08, 2020 at 10:09:27AM -0400, Alan Stern wrote:
> On Wed, Oct 07, 2020 at 02:42:26PM -0700, Matthias Kaehlcke wrote:
> > On Wed, Oct 07, 2020 at 04:17:32PM -0400, Alan Stern wrote:
> > > The peering relation goes both ways, so it should be included in the
> > &
On Fri, Oct 09, 2020 at 08:05:10AM -0700, Doug Anderson wrote:
> Hi,
>
> On Thu, Oct 8, 2020 at 10:10 AM Akhil P Oommen wrote:
> >
> > Add cooling-cells property and the cooling maps for the gpu tzones
> > to support GPU cooling.
> >
> > Signed-off-by: Akhil P Oommen
> > ---
> > arch/arm64/boot
On Wed, Oct 07, 2020 at 04:17:32PM -0400, Alan Stern wrote:
> On Wed, Oct 07, 2020 at 12:42:29PM -0700, Matthias Kaehlcke wrote:
> > On Wed, Oct 07, 2020 at 03:25:42PM -0400, Alan Stern wrote:
> > > On Wed, Oct 07, 2020 at 10:28:47AM -0700, Matthias Kaehlcke wrote:
> > >
On Wed, Oct 07, 2020 at 03:25:42PM -0400, Alan Stern wrote:
> On Wed, Oct 07, 2020 at 10:28:47AM -0700, Matthias Kaehlcke wrote:
> > On Wed, Oct 07, 2020 at 12:38:38PM -0400, Alan Stern wrote:
> > > On Wed, Oct 07, 2020 at 09:03:36AM -0700, Matthias Kaehlcke wrote:
> > >
On Wed, Oct 07, 2020 at 12:38:38PM -0400, Alan Stern wrote:
> On Wed, Oct 07, 2020 at 09:03:36AM -0700, Matthias Kaehlcke wrote:
> > On Tue, Oct 06, 2020 at 09:00:23PM -0400, Alan Stern wrote:
> > > On Tue, Oct 06, 2020 at 12:25:36PM -0700, Matthias Kaehlcke wrote:
> > >
On Tue, Oct 06, 2020 at 09:00:23PM -0400, Alan Stern wrote:
> On Tue, Oct 06, 2020 at 12:25:36PM -0700, Matthias Kaehlcke wrote:
> > On Tue, Oct 06, 2020 at 01:15:24PM -0400, Alan Stern wrote:
> > > You don't need a platform device or a new driver to do this. The co
On Tue, Oct 06, 2020 at 01:15:24PM -0400, Alan Stern wrote:
> On Tue, Oct 06, 2020 at 09:59:57AM -0700, Matthias Kaehlcke wrote:
> > On Tue, Oct 06, 2020 at 10:18:20AM -0400, Alan Stern wrote:
> > > On Mon, Oct 05, 2020 at 05:45:10PM -0700, Matthias Kaehlcke wrote:
> > &g
On Tue, Oct 06, 2020 at 10:18:20AM -0400, Alan Stern wrote:
> On Mon, Oct 05, 2020 at 05:45:10PM -0700, Matthias Kaehlcke wrote:
> > I did some prototyping, it seems a binding like this would work for
> > case a) or b):
> >
> > &usb_1_dw
On Fri, Oct 02, 2020 at 04:09:30PM -0700, Doug Anderson wrote:
> Hi,
>
> On Fri, Oct 2, 2020 at 3:28 PM Rob Herring wrote:
> >
> > On Fri, Oct 2, 2020 at 12:08 PM Doug Anderson wrote:
> > >
> > > Hi,
> > >
> > > On Wed, Sep 30, 2020 at 1:20 PM Rob Herring wrote:
> > > >
> > > > > > > Datasheets
On Mon, Oct 05, 2020 at 02:59:04PM -0500, Rob Herring wrote:
> On Mon, Oct 5, 2020 at 2:36 PM Alan Stern wrote:
> >
> > On Mon, Oct 05, 2020 at 12:18:12PM -0700, Matthias Kaehlcke wrote:
> > > On Mon, Oct 05, 2020 at 12:15:27PM -0400, Alan Stern wrote:
> > > &g
On Mon, Oct 05, 2020 at 12:15:27PM -0400, Alan Stern wrote:
> On Mon, Oct 05, 2020 at 09:06:55AM -0700, Matthias Kaehlcke wrote:
> > On Sat, Oct 03, 2020 at 08:41:42AM -0400, Alan Stern wrote:
> > > The decision to enable the power regulator at system startup would be
> >
On Sat, Oct 03, 2020 at 08:41:42AM -0400, Alan Stern wrote:
> On Fri, Oct 02, 2020 at 05:58:22PM -0500, Rob Herring wrote:
> > On Fri, Oct 2, 2020 at 1:36 PM Alan Stern wrote:
> > > Regardless of how the situation is represented in DT, there remains the
> > > issue of where (i.e., in which driver
On Thu, Oct 01, 2020 at 09:21:53PM -0400, Alan Stern wrote:
> On Thu, Oct 01, 2020 at 02:54:12PM -0700, Matthias Kaehlcke wrote:
> > Hi,
> >
> > thanks for providing more insights on the USB hardware!
>
> Sure.
>
> > On Wed, Sep 30, 2020 at 09:24:13PM -0400
Hi,
thanks for providing more insights on the USB hardware!
On Wed, Sep 30, 2020 at 09:24:13PM -0400, Alan Stern wrote:
> On Wed, Sep 30, 2020 at 03:20:28PM -0500, Rob Herring wrote:
> > On Wed, Sep 30, 2020 at 10:28 AM Doug Anderson
> > wrote:
>
> > > > There aren't 2 (or 3) devices here. The
On Wed, Sep 30, 2020 at 02:19:32PM -0500, Rob Herring wrote:
> On Wed, Sep 30, 2020 at 1:00 PM Doug Anderson wrote:
> >
> > Hi,
> >
> > > On Wed, Sep 30, 2020 at 7:44 AM Rob Herring wrote:
> > > >
> > > > We already have hubs in DT. See [1][2][3][4]. What's new here?
> >
> > After I sent my respo
Hi Alan,
On Tue, Sep 29, 2020 at 09:32:29PM -0400, Alan Stern wrote:
> On Tue, Sep 29, 2020 at 03:09:12PM -0700, Matthias Kaehlcke wrote:
> > Hi Rob,
> >
> > On Tue, Sep 29, 2020 at 03:17:01PM -0500, Rob Herring wrote:
> > > As I said in prior version, this separate
Hi Rob,
On Tue, Sep 29, 2020 at 03:17:01PM -0500, Rob Herring wrote:
> On Mon, Sep 28, 2020 at 10:13:54AM -0700, Matthias Kaehlcke wrote:
> > Discrete onboard USB hubs (an example for such a hub is the Realtek
> > RTS5411) need to be powered and may require initialization of othe
r the IDP and trogdor, not SC7180 in
general.
Besides that:
Reviewed-by: Matthias Kaehlcke
On Tue, Sep 29, 2020 at 04:17:30PM +0530, Sandeep Maheswaram wrote:
> Configure interrupts based on hs_phy_flag to avoid triggering of
> interrupts during system suspend and suspends successfully.
> Set genpd active wakeup flag for usb gdsc if wakeup capable devices
> are connected so that wake up
On Tue, Sep 29, 2020 at 04:17:29PM +0530, Sandeep Maheswaram wrote:
> Adding suspend quirk function for dwc3 host which will be called
> during xhci suspend.
> Setting hs_phy_flags, ss_phy_flags and phy mode during host suspend.
>
> Signed-off-by: Sandeep Maheswaram
> ---
> drivers/usb/dwc3/host
On Tue, Sep 29, 2020 at 04:17:28PM +0530, Sandeep Maheswaram wrote:
> Avoiding phy powerdown in host mode so that it can be wake up by devices.
> Added hs_phy_flags and ss_phy_flags to check connection status and
> set phy mode and configure interrupts.
>
> Signed-off-by: Sandeep Maheswaram
> ---
On Tue, Sep 29, 2020 at 12:00:36PM -0400, Alan Stern wrote:
> On Mon, Sep 28, 2020 at 06:43:55PM -0700, Matthias Kaehlcke wrote:
> > > Have you tried manually unbinding and rebinding the two drivers a few
> > > times to make sure they will still work?
> >
> >
On Mon, Sep 28, 2020 at 03:13:26PM -0700, Doug Anderson wrote:
> Hi,
>
> On Mon, Sep 28, 2020 at 10:14 AM Matthias Kaehlcke wrote:
> >
> > +examples:
> > + - |
> > +usb_hub: usb-hub {
> > +compatible = "realtek,rts5411", "onboard
Hi Doug,
On Mon, Sep 28, 2020 at 03:03:20PM -0700, Doug Anderson wrote:
> Hi,
>
> On Mon, Sep 28, 2020 at 10:14 AM Matthias Kaehlcke wrote:
> >
> > +static ssize_t power_off_in_suspend_show(struct device *dev, struct
> > device_attribute *attr,
> > +
On Mon, Sep 28, 2020 at 02:47:59PM -0400, Alan Stern wrote:
> On Mon, Sep 28, 2020 at 10:13:55AM -0700, Matthias Kaehlcke wrote:
> > The main issue this driver addresses is that a USB hub needs to be
> > powered before it can be discovered. For discrete onboard hubs (an
> > e
2.0 and another for USB 3.x).
Co-developed-by: Ravi Chandra Sadineni
Signed-off-by: Ravi Chandra Sadineni
Signed-off-by: Matthias Kaehlcke
---
Changes in v4:
- updated Kconfig documentation
- changed the loop in onboard_hub_remove() to release the hub lock
before unbinding the USB device an
Discrete onboard USB hubs (an example for such a hub is the Realtek
RTS5411) need to be powered and may require initialization of other
resources (like GPIOs or clocks) to work properly. This adds a device
tree binding for these hubs.
Signed-off-by: Matthias Kaehlcke
---
(no changes since v3
Hi Alan,
On Thu, Sep 24, 2020 at 11:27:58AM -0400, Alan Stern wrote:
> On Wed, Sep 23, 2020 at 06:10:12PM -0700, Matthias Kaehlcke wrote:
> > The main issue this driver addresses is that a USB hub needs to be
> > powered before it can be discovered. For discrete onboard hubs (an
Discrete onboard USB hubs (an example for such a hub is the Realtek
RTS5411) need to be powered and may require initialization of other
resources (like GPIOs or clocks) to work properly. This adds a device
tree binding for these hubs.
Signed-off-by: Matthias Kaehlcke
---
Changes in v3
2.0 and another for USB 3.x).
Co-developed-by: Ravi Chandra Sadineni
Signed-off-by: Ravi Chandra Sadineni
Signed-off-by: Matthias Kaehlcke
---
Changes in v3:
- updated the commit message
- updated description in Kconfig
- remove include of 'core/usb.h'
- use &
On Mon, Sep 21, 2020 at 06:18:37PM -0700, Matthias Kaehlcke wrote:
> On Sun, Sep 20, 2020 at 04:17:20PM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Sep 17, 2020 at 11:46:22AM -0700, Matthias Kaehlcke wrote:
> > >
> > > ...
> > >
> > > +static int __ini
Hi Rob,
On Fri, Sep 18, 2020 at 10:05:21AM -0600, Rob Herring wrote:
> +Florian
>
> On Tue, Sep 15, 2020 at 6:00 PM Matthias Kaehlcke wrote:
> >
> > Hi Rob,
> >
> > On Tue, Sep 15, 2020 at 08:21:45AM -0600, Rob Herring wrote:
> > > On Mon, Sep 14, 2
On Mon, Sep 21, 2020 at 09:08:12PM -0400, Alan Stern wrote:
> On Mon, Sep 21, 2020 at 05:41:58PM -0700, Matthias Kaehlcke wrote:
> > > > + put_device(hub->dev);
> > >
> > > Is there a matching get_device somewhere (like in _find_onboard_hub)?
> >
Hi Greg,
thanks for the review!
On Sun, Sep 20, 2020 at 04:17:20PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Sep 17, 2020 at 11:46:22AM -0700, Matthias Kaehlcke wrote:
> > The main issue this driver addresses is that a USB hub needs to be
> > powered before it can be discover
Hi Peter,
On Fri, Sep 18, 2020 at 01:30:20AM +, Peter Chen wrote:
> On 20-09-17 11:46:22, Matthias Kaehlcke wrote:
> > The main issue this driver addresses is that a USB hub needs to be
> > powered before it can be discovered. For onboard hubs this is often
> > solved
Hi Alan,
thanks for taking time to review!
On Thu, Sep 17, 2020 at 03:54:16PM -0400, Alan Stern wrote:
> On Thu, Sep 17, 2020 at 11:46:22AM -0700, Matthias Kaehlcke wrote:
> > The main issue this driver addresses is that a USB hub needs to be
> > powered before it can be discover
Onboard USB hubs need to be powered and may require initiaization of
other resources (like GPIOs or clocks) to work properly. This adds
a device tree binding for these hubs.
Signed-off-by: Matthias Kaehlcke
---
Changes in v2:
- removed 'wakeup-source' and 'power-off-in-susp
Sadineni
Signed-off-by: Ravi Chandra Sadineni
Signed-off-by: Matthias Kaehlcke
---
Changes in v2:
- check wakeup enabled state of the USB controller instead of
using 'wakeup-source' property
- use sysfs attribute instead of DT property to determine if
the hub should be powered of
On Thu, Sep 17, 2020 at 01:24:30AM +, Peter Chen wrote:
> > > >
> > >
> > > You may need both (glue & xhci), it depends on system design, and
> > > usually, these two kinds of wakeup setting isn't conflict.
> >
> > Ok, thanks. So if I understand correctly the onboard hub driver should
> > che
On Thu, Sep 17, 2020 at 12:27:29AM +, Peter Chen wrote:
> On 20-09-16 12:16:07, Matthias Kaehlcke wrote:
> > Hi Peter,
> >
> > On Wed, Sep 16, 2020 at 08:19:07AM +, Peter Chen wrote:
> > > On 20-09-15 16:03:45, Matthias Kaehlcke wrote:
> > > >
On Tue, Sep 15, 2020 at 10:14:21PM -0400, Alan Stern wrote:
> On Tue, Sep 15, 2020 at 04:03:45PM -0700, Matthias Kaehlcke wrote:
> > Hi Peter,
> >
> > On Tue, Sep 15, 2020 at 07:05:38AM +, Peter Chen wrote:
>
> > > Whether or not it is a wakeup_source
Hi Peter,
On Wed, Sep 16, 2020 at 08:19:07AM +, Peter Chen wrote:
> On 20-09-15 16:03:45, Matthias Kaehlcke wrote:
> > Hi Peter,
> >
> > On Tue, Sep 15, 2020 at 07:05:38AM +, Peter Chen wrote:
> > >
> > > > > > + hub->cfg.power
Hi Venkata,
I agree with Marcel that the version magic is confusing ...
On Tue, Sep 15, 2020 at 09:13:25PM +0530, Venkata Lakshmi Narayana Gubba wrote:
> This change will allow to use different NVM file based
> on WCN3991 BT SoC ID.Need to use different NVM file based on
> fab location for WCN399
Hi Rob,
On Tue, Sep 15, 2020 at 08:21:45AM -0600, Rob Herring wrote:
> On Mon, Sep 14, 2020 at 11:27:48AM -0700, Matthias Kaehlcke wrote:
> > Onboard USB hubs need to be powered and may require initiaization of
> > other resources (like GPIOs or clocks) to work properly. This ad
Hi Peter,
On Tue, Sep 15, 2020 at 07:05:38AM +, Peter Chen wrote:
>
> > > > + hub->cfg.power_off_in_suspend =
> > of_property_read_bool(dev->of_node, "power-off-in-suspend");
> > > > + hub->cfg.wakeup_source = of_property_read_bool(dev->of_node,
> > > > +"wakeup-source");
> > >
: Add Qualcomm DWC3 glue driver")
Signed-off-by: Matthias Kaehlcke
---
drivers/usb/dwc3/dwc3-qcom.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
index e1e78e9824b1..56d14c09506d 100644
--- a/drivers/usb
;t be adjusted. Only add frequencies
with an OPP entry.
Fixes: 55538fbc79e9 ("cpufreq: qcom: Read voltage LUT and populate OPP")
Signed-off-by: Matthias Kaehlcke
---
drivers/cpufreq/qcom-cpufreq-hw.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/
Hi Peter,
thanks for your comments!
On Tue, Sep 15, 2020 at 02:55:06AM +, Peter Chen wrote:
> On 20-09-14 11:27:49, Matthias Kaehlcke wrote:
> > The main issue this driver addresses is that a USB hub needs to be
> > powered before it can be discovered. For onboard hub
Hi Alan,
thanks for your feedback!
On Mon, Sep 14, 2020 at 04:14:03PM -0400, Alan Stern wrote:
> On Mon, Sep 14, 2020 at 11:27:49AM -0700, Matthias Kaehlcke wrote:
> > The main issue this driver addresses is that a USB hub needs to be
> > powered before it can be discovered. F
at 11:27:49AM -0700, Matthias Kaehlcke wrote:
> diff --git a/drivers/usb/misc/onboard_usb_hub.c
> b/drivers/usb/misc/onboard_usb_hub.c
> new file mode 100644
> index ..e5a816d0b124
> --- /dev/null
> +++ b/drivers/usb/misc/onboard_usb_hub.c
>
> +static i
avi Chandra Sadineni
Signed-off-by: Ravi Chandra Sadineni
Signed-off-by: Matthias Kaehlcke
---
This is an evolution of '[RFC] USB: misc: Add usb_hub_pwr driver'
(https://lore.kernel.org/patchwork/patch/1299239/).
Changes in v1:
- renamed the driver to 'onboard_usb_hub'
- singl
Hi Peter,
sorry for the delayed reply, I got distracted by other things and ran into
issues with my mail setup.
On Thu, Sep 03, 2020 at 01:46:18AM +, Peter Chen wrote:
> On 20-09-02 10:45:36, Matthias Kaehlcke wrote:
> > >
> > > Hi Matthias,
> > >
> >
Onboard USB hubs need to be powered and may require initiaization of
other resources (like GPIOs or clocks) to work properly. This adds
a device tree binding for these hubs.
Signed-off-by: Matthias Kaehlcke
---
.../bindings/usb/onboard_usb_hub.yaml | 70 +++
1 file
in sleep state, UART RTS/RFR is pulled high
> during suspend and BT SoC not able to send wakeup bytes.
>
> Signed-off-by: satya priya
Reviewed-by: Matthias Kaehlcke
Tested-by: Matthias Kaehlcke
in sleep state, UART RTS/RFR is pulled high
> during suspend and BT SoC not able to send wakeup bytes.
>
> Signed-off-by: satya priya
Reviewed-by: Matthias Kaehlcke
El Thu, Sep 10, 2020 at 06:23:56PM +0530 satya priya ha dit:
> Add a suitable sleep configuration for uart3 to support Bluetooth wakeup.
>
> If QUP function is selected in sleep state, UART RTS/RFR is pulled high
> during suspend and BT SoC not able to send wakeup bytes. So, configure
> GPIO mode
On Thu, Sep 03, 2020 at 08:34:55PM +0530, satya priya wrote:
> Add the necessary pinctrl and interrupts to make UART wakeup capable.
>
> If QUP function is selected in sleep state, UART RTS/RFR is pulled high
> during suspend and BT SoC not able to send wakeup bytes. So, configure
> GPIO mode in s
On Thu, Sep 03, 2020 at 08:34:58PM +0530, satya priya wrote:
> As a part of system suspend uart_port_suspend is called from the
> Serial driver, which calls set_mctrl passing mctrl as NULL. This
nit: s/NULL/0/
> makes RFR high(NOT_READY) during suspend.
>
> Due to this BT SoC is not able to send
ata when the TX pin of the Bluetooth module is
> + * in tri-state (module powered off or not driving the
> + * signal yet).
> + */
> + pins = "gpio41";
> + bias-pull-up;
> + };
> +};
> +
> &qup_uart8_default {
> pinconf-tx {
> pins = "gpio44";
Reviewed-by: Matthias Kaehlcke
> drive-strength = <2>;
> bias-disable;
> - output-high;
> };
>
> pinconf-rx {
> /*
> - * Configure a pull-up on 41 (RX). This is needed to avoid
> + * Configure a pull-up on RX. This is needed to avoid
>* garbage data when the TX pin of the Bluetooth module is
>* in tri-state (module powered off or not driving the
>* signal yet).
Reviewed-by: Matthias Kaehlcke
On Thu, Sep 03, 2020 at 08:34:55PM +0530, satya priya wrote:
> Add the necessary pinctrl and interrupts to make UART wakeup capable.
>
> If QUP function is selected in sleep state, UART RTS/RFR is pulled high
> during suspend and BT SoC not able to send wakeup bytes. So, configure
> GPIO mode in s
Hi Rajendra,
On Thu, Sep 03, 2020 at 11:00:52AM +0530, Rajendra Nayak wrote:
>
> On 9/3/2020 10:14 AM, Rajendra Nayak wrote:
> >
> > On 9/2/2020 9:02 PM, Doug Anderson wrote:
> > > Hi,
> > >
> > > On Tue, Sep 1, 2020 at 10:36 PM Rajendra Nayak
> > > wrote:
> > > >
> > > >
> > > > > * In ter
101 - 200 of 1167 matches
Mail list logo
