[PATCH v4 19/78] drm/vc4: crtc: Disable color management for HVS5

2020-07-08 Thread Maxime Ripard
The HVS5 uses different color matrices. Disable color management support for now. Reviewed-by: Eric Anholt Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 17 +++-- drivers/gpu/drm/vc4/vc4_hvs.c | 2 +- 2 files changed, 12 insertions(+), 7 deletions(-) diff

[PATCH v4 09/78] drm/vc4: crtc: Move the cob allocation outside of bind

2020-07-08 Thread Maxime Ripard
. Reviewed-by: Eric Anholt Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 35 +-- drivers/gpu/drm/vc4/vc4_drv.h | 2 +-- 2 files changed, 17 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4

[PATCH v4 13/78] drm/vc4: kms: Convert to for_each_new_crtc_state

2020-07-08 Thread Maxime Ripard
The vc4 atomic commit loop has an handrolled loop that is basically identical to for_each_new_crtc_state, let's convert it to that helper. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_kms.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v4 04/78] drm/vc4: plane: Change LBM alignment constraint on LBM

2020-07-08 Thread Maxime Ripard
From: Dave Stevenson The HVS5 needs an alignment of 64bytes for its LBM memory, so let's reflect it. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_plane.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4

[PATCH v4 16/78] drm/vc4: crtc: Add function to compute FIFO level bits

2020-07-08 Thread Maxime Ripard
The longer FIFOs in vc5 pixelvalves means that the FIFO full level doesn't fit in the original register field and that we also have a secondary field. In order to prepare for this, let's move the registers fill part to a helper function. Reviewed-by: Eric Anholt Signed-off-by: Maxime Ripard

[PATCH] drm/vc4: hdmi: Add a name to the codec DAI component

2020-07-08 Thread Maxime Ripard
Since the components for a given device in ASoC are identified by their name, it makes sense to add one even though it's not strictly necessary. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b

Re: [PATCH] thermal: sun8i: Be loud when probe fails

2020-07-08 Thread Maxime Ripard
On Wed, Jul 08, 2020 at 03:44:41PM +0200, Ondřej Jirman wrote: > On Wed, Jul 08, 2020 at 03:36:54PM +0200, Maxime Ripard wrote: > > On Wed, Jul 08, 2020 at 03:29:24PM +0200, Ondřej Jirman wrote: > > > Hello Maxime, > > > > > > On Wed, Jul 08, 2020 at 0

Re: [PATCH] thermal: sun8i: Be loud when probe fails

2020-07-08 Thread Maxime Ripard
On Wed, Jul 08, 2020 at 03:29:24PM +0200, Ondřej Jirman wrote: > Hello Maxime, > > On Wed, Jul 08, 2020 at 02:25:42PM +0200, Maxime Ripard wrote: > > Hi, > > > > On Wed, Jul 08, 2020 at 12:55:27PM +0200, Ondrej Jirman wrote: > > > I noticed several mobile L

Re: [PATCH] thermal: sun8i: Be loud when probe fails

2020-07-08 Thread Maxime Ripard
On Wed, Jul 08, 2020 at 12:55:27PM +0200, Ondrej Jirman wrote: > @@ -523,10 +547,17 @@ static int sun8i_ths_probe(struct platform_device *pdev) > ret = devm_request_threaded_irq(dev, irq, NULL, > sun8i_irq_thread, >

Re: [PATCH] thermal: sun8i: Be loud when probe fails

2020-07-08 Thread Maxime Ripard
Hi, On Wed, Jul 08, 2020 at 12:55:27PM +0200, Ondrej Jirman wrote: > I noticed several mobile Linux distributions failing to enable the > thermal regulation correctly, because the kernel is silent > when thermal driver fails to probe. Add enough error reporting > to debug issues and warn users in

Re: [PATCH v3 02/10] ASoC: sunxi: sun4i-i2s: fix kernel-doc

2020-07-08 Thread Maxime Ripard
On Tue, Jul 07, 2020 at 02:16:07PM -0500, Pierre-Louis Bossart wrote: > Fix W=1 warnings - missing fields in description > > Signed-off-by: Pierre-Louis Bossart Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 03/10] ASoC: sunxi: sun4i-spdif: fix kernel-doc

2020-07-08 Thread Maxime Ripard
On Tue, Jul 07, 2020 at 02:16:08PM -0500, Pierre-Louis Bossart wrote: > Fix W=1 warning - typo in field description > > Signed-off-by: Pierre-Louis Bossart Acked-by: Maxime Ripard Thanks! Maxime

Re: PHY reset handling during DT parsing

2020-07-07 Thread Maxime Ripard
Hi Andrew, On Tue, Jul 07, 2020 at 04:19:18PM +0200, Andrew Lunn wrote: > On Mon, Jul 06, 2020 at 08:13:31PM +0200, Maxime Ripard wrote: > > I came across an issue today on an Allwinner board, but I believe it's a > > core issue. > > > > That board is using the stmac

[PATCH] drm/vc4: dsi: Only register our component once a DSI device is attached

2020-07-07 Thread Maxime Ripard
-by: Andrzej Hajda Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dsi.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index eaf276978ee7..19aab4e7e209 100644 --- a/drivers/gpu/drm/vc4

Re: [PATCH v4 0/9] drm/vc4: Turn the TXP into a CRTC

2020-07-07 Thread Maxime Ripard
On Mon, Jul 06, 2020 at 05:51:29PM -0700, Eric Anholt wrote: > On Tue, Jun 30, 2020 at 1:25 AM Maxime Ripard wrote: > > > > Hi Eric, > > > > On Thu, Jun 11, 2020 at 03:36:45PM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > This is

[PATCH] ASoC: core: Remove only the registered component in devm functions

2020-07-07 Thread Maxime Ripard
. Signed-off-by: Maxime Ripard --- This was observed on a RaspberryPi that uses the vc4_hdmi driver (drivers/gpu/drm/vc4/vc4_hdmi.c). This driver will register a dmaengine PCM and two components. If the MIPI-DSI controller is enabled, it will create an EPROBE_DEFER across the entire display pipeline

PHY reset handling during DT parsing

2020-07-06 Thread Maxime Ripard
Hi, I came across an issue today on an Allwinner board, but I believe it's a core issue. That board is using the stmac driver together with a phy that happens to have a reset GPIO, except that that GPIO will never be claimed, and the PHY will thus never work. You can find an example of such a

Re: [PATCH 3/3] arm64: allwinner: a64: enable Bluetooth On Pinebook

2020-07-06 Thread Maxime Ripard
Hi, On Sun, Jul 05, 2020 at 12:51:10PM -0700, Vasily Khoruzhick wrote: > Pinebook has an RTL8723CS WiFi + BT chip, BT is connected to UART1 > and uses PL5 as device wake GPIO, PL6 as host wake GPIO the I2C > controlling signals are connected to R_I2C bus. > > Enable it in the device tree. > >

Re: [PATCH 13/16] arm64: dts: allwinner: a64: Add HDMI audio

2020-07-05 Thread Maxime Ripard
On Sat, Jul 04, 2020 at 01:38:59PM +0200, Clément Péron wrote: > From: Marcus Cooper > > Add a simple-soundcard to link audio between HDMI and I2S. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Marcus Cooper > Signed-off-by: Clément Péron > --- >

Re: [PATCH 08/16] arm64: dts: allwinner: h6: Add HDMI audio node

2020-07-05 Thread Maxime Ripard
Hi, On Sat, Jul 04, 2020 at 01:38:54PM +0200, Clément Péron wrote: > From: Jernej Skrabec > > Add a simple-soundcard to link audio between HDMI and I2S. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Marcus Cooper > Signed-off-by: Clément Péron > --- >

Re: [PATCH 07/16] ASoC: sun4i-i2s: Fix sun8i volatile regs

2020-07-05 Thread Maxime Ripard
off-by: Clément Péron Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH 06/16] ASoC: sun4i-i2s: Adjust regmap settings

2020-07-05 Thread Maxime Ripard
On Sat, Jul 04, 2020 at 01:38:52PM +0200, Clément Péron wrote: > From: Marcus Cooper > > Bypass the regmap cache when flushing or reading the i2s FIFOs. > > Signed-off-by: Marcus Cooper > Signed-off-by: Clément Péron Acked-by: Maxime Ripard Thanks Maxime signature.as

Re: [PATCH 05/16] ASoc: sun4i-i2s: Add 20 and 24 bit support

2020-07-05 Thread Maxime Ripard
On Sat, Jul 04, 2020 at 01:38:51PM +0200, Clément Péron wrote: > From: Marcus Cooper > > Extend the functionality of the driver to include support of 20 and > 24 bits per sample. > > Signed-off-by: Marcus Cooper > Signed-off-by: Clément Péron Acked-by: Maxime Ri

Re: [PATCH 04/16] ASoC: sun4i-i2s: Set sign extend sample

2020-07-05 Thread Maxime Ripard
On Sat, Jul 04, 2020 at 01:38:50PM +0200, Clément Péron wrote: > From: Marcus Cooper > > On the newer SoCs such as the H3 and A64 this is set by default > to transfer a 0 after each sample in each slot. However the A10 > and A20 SoCs that this driver was developed on had a default > setting

Re: [PATCH 01/16] ASoC: sun4i-i2s: Add support for H6 I2S

2020-07-05 Thread Maxime Ripard
Hi, On Sat, Jul 04, 2020 at 01:38:47PM +0200, Clément Péron wrote: > From: Jernej Skrabec > > H6 I2S is very similar to that in H3, except it supports up to 16 > channels. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Marcus Cooper > Signed-off-by: Clément Péron > --- >

Re: [PATCH 2/3] arm64: dts: allwinner: Add support for PinePhone revision 1.2

2020-07-05 Thread Maxime Ripard
Hi, On Fri, Jul 03, 2020 at 09:48:41PM +0200, Ondrej Jirman wrote: > Revision 1.2 should be the final production version of the PinePhone. > It has most of the known HW quirks fixed. > > Interrupt to the magnetometer is routed correctly, in this revision. > > The bulk of the changes are in how

Re: [PATCH v2 13/14] [DO NOT MERGE] arm64: dts: allwinner: h6: Add GPU OPP table

2020-07-04 Thread Maxime Ripard
Hi, On Sat, Jul 04, 2020 at 12:25:34PM +0200, Clément Péron wrote: > Add an Operating Performance Points table for the GPU to > enable Dynamic Voltage & Frequency Scaling on the H6. > > The voltage range is set with minival voltage set to the target > and the maximal voltage set to 1.2V. This

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-07-03 Thread Maxime Ripard
Hi, On Tue, Jun 30, 2020 at 04:26:20PM +0800, Jian-Hong Pan wrote: > Maxime Ripard 於 2020年6月29日 週一 下午10:21寫道: > > > > Hi! > > > > On Fri, Jun 05, 2020 at 04:44:51PM +0800, Jian-Hong Pan wrote: > > > Maxime Ripard 於 2020年6月2日 週二 下午7:04寫道: > > > >

Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

2020-07-03 Thread Maxime Ripard
Hi, On Thu, Jul 02, 2020 at 10:14:32AM +0200, Ondrej Jirman wrote: > Pinephone has a Goodix GT917S capacitive touchscreen controller on > I2C0 bus. Add support for it. > > Signed-off-by: Ondrej Jirman > Acked-by: Linus Walleij > --- > .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19

[PATCH] ASoC: core: Remove only the registered component in devm functions

2020-07-03 Thread Maxime Ripard
. Signed-off-by: Maxime Ripard --- This was observed on a RaspberryPi that uses the vc4_hdmi driver (drivers/gpu/drm/vc4/vc4_hdmi.c). This driver will register a dmaengine PCM and two components. If the MIPI-DSI controller is enabled, it will create an EPROBE_DEFER across the entire display pipeline

Re: [PATCH v7 12/13] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone

2020-07-02 Thread Maxime Ripard
On Wed, Jul 01, 2020 at 06:29:27PM +0200, Ondrej Jirman wrote: > From: Icenowy Zheng > > PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for > display. > > Backlight levels curve was optimized by Martijn Braam using a > lux meter. > > Add its device nodes. > > Signed-off-by:

Re: [PATCH v2] dt-bindings: display: Convert connectors to DT schema

2020-07-01 Thread Maxime Ripard
On Tue, Jun 30, 2020 at 02:02:16PM -0600, Rob Herring wrote: > Convert the analog TV, DVI, HDMI, and VGA connector bindings to DT schema > format. > > Cc: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Maxime Ripard > Signed-off-by: Rob Herring Reviewed-by: Maxime Ri

Re: [PATCH v4 0/9] drm/vc4: Turn the TXP into a CRTC

2020-06-30 Thread Maxime Ripard
Hi Eric, On Thu, Jun 11, 2020 at 03:36:45PM +0200, Maxime Ripard wrote: > Hi, > > This is another part of the rpi4 HDMI series that got promoted to a > series of its own to try to reduce the main one. > > This rework is needed since the bcm2711 used in the rpi4 has a more

Re: linux-next: build warning after merge of the clk tree

2020-06-30 Thread Maxime Ripard
Hi, On Tue, Jun 30, 2020 at 09:53:41AM +1000, Stephen Rothwell wrote: > After merging the clk tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/clk/bcm/clk-bcm2711-dvp.o > > Introduced by commit > >

Re: [PATCH] drm: sun4i: hdmi: Remove extra HPD polling

2020-06-30 Thread Maxime Ripard
Hi, On Mon, Jun 29, 2020 at 02:00:32PM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > The HPD sense mechanism in Allwinner's old HDMI encoder hardware is more > or less an input-only GPIO. Other GPIO-based HPD implementations > directly return the current state, instead of polling for a

Re: [PATCH] phy: allwinner: phy-sun6i-mipi-dphy: Constify structs

2020-06-30 Thread Maxime Ripard
t;44071944 646415190f > drivers/phy/allwinner/phy-sun6i-mipi-dphy.o > > After: >textdata bss dec hex filename >48351496 64639518fb > drivers/phy/allwinner/phy-sun6i-mipi-dphy.o > > Signed-off-by: Rikard Falkeborn

Re: [PATCH v2 08/11] thermal: sun8i: Add A100's THS controller support

2020-06-29 Thread Maxime Ripard
On Mon, Jun 22, 2020 at 10:59:04AM +0800, Frank Lee wrote: > This patch add thermal sensor controller support for A100, > which is similar to the previous ones. > > Signed-off-by: Frank Lee > Signed-off-by: Yangtao Li This SoB is weird. If Yangtao Li is the author, then they should be

Re: [PATCH v2 06/11] nvmem: sunxi-sid: add support for A100's SID controller

2020-06-29 Thread Maxime Ripard
On Mon, Jun 22, 2020 at 10:59:02AM +0800, Frank Lee wrote: > Add support for A100's SID controller. > > Signed-off-by: Frank Lee > --- > drivers/nvmem/sunxi_sid.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c > index

Re: [PATCH] iommu: SUN50I_IOMMU should depend on HAS_DMA

2020-06-29 Thread Maxime Ripard
e selected, unless HAS_DMA=y. > > Hence fix this by making SUN50I_IOMMU depend on HAS_DMA. > > Fixes: 4100b8c229b32835 ("iommu: Add Allwinner H6 IOMMU driver") > Signed-off-by: Geert Uytterhoeven Acked-by: Maxime Ripard Thanks! Maxime signature.asc Description: PGP signature

Re: [PATCH v2 03/11] dt-bindings: pinctrl: sunxi: Add A100 pinctrl bindings

2020-06-29 Thread Maxime Ripard
Hi, On Mon, Jun 22, 2020 at 10:58:59AM +0800, Frank Lee wrote: > Add device tree binding Documentation details for A100 pinctrl driver, > whic has an r pin controller and a pin controller with more irq lines. > > Signed-off-by: Frank Lee > --- > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml

Re: [PATCH v2 02/11] clk: sunxi-ng: add support for the Allwinner A100 CCU

2020-06-29 Thread Maxime Ripard
On Mon, Jun 22, 2020 at 10:58:58AM +0800, Frank Lee wrote: > +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a100-r.h > @@ -0,0 +1,21 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2020 Frank Lee > + */ > + > +#ifndef _CCU_SUN50IW10_R_H > +#define _CCU_SUN50IW10_R_H > + > +#include

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

2020-06-29 Thread Maxime Ripard
Hi! On Fri, Jun 05, 2020 at 04:44:51PM +0800, Jian-Hong Pan wrote: > Maxime Ripard 於 2020年6月2日 週二 下午7:04寫道: > > > > Hi, > > > > On Mon, Jun 01, 2020 at 03:58:26PM +0800, Jian-Hong Pan wrote: > > > Maxime Ripard 於 2020年5月28日 週四 下午3:30寫道: > > > > &

Re: [PATCH v2 09/11] arm64: allwinner: A100: add the basical Allwinner A100 DTSI file

2020-06-29 Thread Maxime Ripard
Hi, On Mon, Jun 22, 2020 at 10:59:05AM +0800, Frank Lee wrote: > Allwinner A100 is a new SoC with Cortex-A53 cores, this commit adds > the basical DTSI file of it, including the clock, i2c, pins, sid, ths, > and UART support. > > Signed-off-by: Frank Lee > --- >

Re: [PATCH v2 1/9] irqchip/sun6i-r: Use a stacked irqchip driver

2020-06-26 Thread Maxime Ripard
Hi Samuel, On Mon, Jun 15, 2020 at 12:29:50AM -0500, Samuel Holland wrote: > On 6/8/20 3:48 AM, Maxime Ripard wrote: > > On Sun, May 24, 2020 at 11:12:54PM -0500, Samuel Holland wrote: > >> The R_INTC in the A31 and newer sun8i/sun50i SoCs is more similar to the > >&g

Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init

2020-06-23 Thread Maxime Ripard
On Tue, Jun 23, 2020 at 05:00:32PM +0200, Markus Elfring wrote: > >>> Fix this by … > >> > >> Please replace the beginning of this sentence with the tag “Fixes”. > >>

Re: [PATCH] crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init

2020-06-23 Thread Maxime Ripard
On Mon, Jun 22, 2020 at 07:50:08PM +0200, Markus Elfring wrote: > > Fix this by … > > Please replace the beginning of this sentence with the tag “Fixes”. >

Re: [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks

2020-06-19 Thread Maxime Ripard
Hi Stephen, On Fri, Jun 19, 2020 at 02:37:37AM -0700, Stephen Boyd wrote: > Quoting Maxime Ripard (2020-06-15 01:40:40) > > Hi, > > > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen > > to split away the two discussions between the firmw

Re: [PATCH v3 033/105] drm/vc4: crtc: Assign output to channel automatically

2020-06-16 Thread Maxime Ripard
Hi Eric, On Wed, May 27, 2020 at 10:23:23AM -0700, Eric Anholt wrote: > On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > static int > > vc4_atomic_check(struct drm_device *dev, struct drm_atomic_state *state) > > { > > - int ret; > > +

Re: [PATCH v4 3/3] ARM: dts: bcm2711: Add HDMI DVP

2020-06-16 Thread Maxime Ripard
On Tue, Jun 16, 2020 at 02:56:55PM +0200, Philipp Zabel wrote: > Hi Maxime, > > On Tue, 2020-06-16 at 14:16 +0200, Maxime Ripard wrote: > > Hi Nicolas, > > > > On Mon, Jun 15, 2020 at 06:26:19PM +0200, Nicolas Saenz Julienne wrote: > > > On Thu, 2020-06-11

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-16 Thread Maxime Ripard
On Sun, Jun 14, 2020 at 06:16:56PM +0200, Stefan Wahren wrote: > Am 11.06.20 um 15:34 schrieb Maxime Ripard: > > Hi Stefan, > > > > On Sat, Jun 06, 2020 at 10:06:12AM +0200, Stefan Wahren wrote: > >> Hi Maxime, > >> > >> Am 05.06.20

Re: [PATCH v4 3/3] ARM: dts: bcm2711: Add HDMI DVP

2020-06-16 Thread Maxime Ripard
Hi Nicolas, On Mon, Jun 15, 2020 at 06:26:19PM +0200, Nicolas Saenz Julienne wrote: > On Thu, 2020-06-11 at 11:23 +0200, Maxime Ripard wrote: > > Now that we have a driver for the DVP, let's add its DT node. > > > > Signed-off-by: Maxime Ripard > > --- > > I

Re: [PATCH v2 2/2] ARM: dts: orange-pi-zero-plus2: add leds configuration

2020-06-16 Thread Maxime Ripard
On Mon, Jun 15, 2020 at 03:02:25PM +0200, Diego Rondini wrote: > Add pwr and status leds configuration and turn on pwr led by default for > Orange > Pi Zero Plus 2 (both H3 and H5 variants). > > Signed-off-by: Diego Rondini Applied both ,thanks! Maxime signature.asc Description: PGP

[PATCH v5 07/27] clk: bcm: rpi: Remove global pllb_arm clock pointer

2020-06-15 Thread Maxime Ripard
Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 5f0d4875e145

[PATCH v5 02/27] dt-bindings: clock: Add a binding for the RPi Firmware clocks

2020-06-15 Thread Maxime Ripard
Reviewed-by: Stephen Boyd Reviewed-by: Rob Herring Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 24 1 file changed, 24 insertions(+) diff --git a/Documentation/devicetree

[PATCH v5 01/27] dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML

2020-06-15 Thread Maxime Ripard
From: Florian Fainelli Convert the Raspberry Pi BCM2835 firmware binding document to YAML. Verified with dt_binding_check and dtbs_check. Signed-off-by: Florian Fainelli Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/arm/bcm/raspberrypi

[PATCH v5 05/27] clk: bcm: rpi: Statically init clk_init_data

2020-06-15 Thread Maxime Ripard
Instead of declaring the clk_init_data and then calling memset on it, just initialise properly. Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard

[PATCH v5 04/27] clk: bcm: rpi: Allow the driver to be probed by DT

2020-06-15 Thread Maxime Ripard
Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index

[PATCH v5 15/27] clk: bcm: rpi: Pass the clocks data to the firmware function

2020-06-15 Thread Maxime Ripard
Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 97ac04604b0a

[PATCH v5 17/27] clk: bcm: rpi: Split pllb clock hooks

2020-06-15 Thread Maxime Ripard
Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b

[PATCH v5 20/27] clk: bcm: rpi: Add an enum for the firmware clocks

2020-06-15 Thread Maxime Ripard
Julienne Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 5f4e2d49432f

[PATCH v5 22/27] clk: bcm: rpi: Give firmware clocks a name

2020-06-15 Thread Maxime Ripard
We've registered the firmware clocks using their ID as name, but it's much more convenient to register them using their proper name. Since the firmware doesn't provide it, we have to duplicate it. Acked-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard

[PATCH v5 16/27] clk: bcm: rpi: Rename is_prepared function

2020-06-15 Thread Maxime Ripard
-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c

[PATCH v5 21/27] clk: bcm: rpi: Discover the firmware clocks

2020-06-15 Thread Maxime Ripard
through the device tree for consumers to use them. Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 153

[PATCH v5 10/27] clk: bcm: rpi: Switch to clk_hw_register_clkdev

2020-06-15 Thread Maxime Ripard
Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 5a06c4991c7f..23f06618a356 100644 --- a/drivers/clk/bcm/clk

[PATCH v5 11/27] clk: bcm: rpi: Make sure the clkdev lookup is removed

2020-06-15 Thread Maxime Ripard
-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index

[PATCH v5 19/27] clk: bcm: rpi: Add DT provider for the clocks

2020-06-15 Thread Maxime Ripard
For the upcoming registration of the clocks provided by the firmware, make sure it's exposed to the device tree providers. Cc: Michael Turquette Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime

[PATCH v5 25/27] clk: bcm2835: Allow custom CCF flags for the PLLs

2020-06-15 Thread Maxime Ripard
While some clock types allow for each clock to specify its own custom flags, the PLLs can't. We will need this for the PLLB, so let's add it. Acked-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-bcm2835.c | 3 ++- 1 file

[PATCH v5 12/27] clk: bcm: rpi: Use CCF boundaries instead of rolling our own

2020-06-15 Thread Maxime Ripard
Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index a20492fade6a..e135ad28d38d 100644 --- a/drivers/clk/bcm/clk

[PATCH v5 23/27] Revert "clk: bcm2835: remove pllb"

2020-06-15 Thread Maxime Ripard
-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-bcm2835.c | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index

[PATCH v5 26/27] clk: bcm2835: Don't cache the PLLB rate

2020-06-15 Thread Maxime Ripard
The PLLB rate will be changed through the firmware clocks drivers and will change behind this drivers' back, so we don't want to cache the rate. Acked-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-bcm2835.c | 5 +++-- 1 file

[PATCH v5 24/27] ARM: dts: bcm2711: Add firmware clocks node

2020-06-15 Thread Maxime Ripard
Now that we have a clock driver for the clocks exposed by the firmware, let's add the device tree nodes for it. Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH v5 06/27] clk: bcm: rpi: Use clk_hw_register for pllb_arm

2020-06-15 Thread Maxime Ripard
: Michael Turquette Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git

[PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks

2020-06-15 Thread Maxime Ripard
the min/max rate retrieval to all the firmware clocks - Added proper name for the firmware clocks - Removed the PLLB setup from the firmware clocks and moved it back to the MMIO driver Florian Fainelli (1): dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML Maxime Ripard (26

[PATCH v5 27/27] clk: bcm: rpi: Remove the quirks for the CPU clock

2020-06-15 Thread Maxime Ripard
The CPU clock has had so far a bunch of quirks to expose the clock tree properly, but since we reverted to exposing them through the MMIO driver, we can remove that code from the firmware driver. Acked-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard

[PATCH v5 03/27] firmware: rpi: Only create clocks device if we don't have a node for it

2020-06-15 Thread Maxime Ripard
-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/firmware/raspberrypi.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c index ef8098856a47..b25901a77c09 100644 --- a/drivers/firmware/raspberrypi.c

[PATCH v5 18/27] clk: bcm: rpi: Make the PLLB registration function return a clk_hw

2020-06-15 Thread Maxime Ripard
we'll want that for the future clocks, let's return a clk_hw pointer instead of the return code. Cc: Michael Turquette Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk

[PATCH v5 09/27] clk: bcm: rpi: Remove pllb_arm_lookup global pointer

2020-06-15 Thread Maxime Ripard
-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk

[PATCH v5 13/27] clk: bcm: rpi: Create a data structure for the clocks

2020-06-15 Thread Maxime Ripard
quette Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-)

[PATCH v5 08/27] clk: bcm: rpi: Make sure pllb_arm is removed

2020-06-15 Thread Maxime Ripard
: Stephen Boyd Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/clk/bcm/clk

[PATCH v5 14/27] clk: bcm: rpi: Add clock id to data

2020-06-15 Thread Maxime Ripard
: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Tested-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/clk/bcm/clk

Re: [PATCH 2/2] ARM: dts: orange-pi-zero-plus2: add leds configuration

2020-06-15 Thread Maxime Ripard
On Thu, May 28, 2020 at 10:47:12PM +0200, Diego Rondini wrote: > Add pwr and status leds configuration and turn on pwr led by default for > Orange > Pi Zero Plus 2 (both H3 and H5 variants). > > Signed-off-by: Diego Rondini > --- > .../boot/dts/sun8i-h3-orangepi-zero-plus2.dts| 16

Re: [PATCH 1/2] ARM: dts: orange-pi-zero-plus2: enable USB OTG port

2020-06-15 Thread Maxime Ripard
Hi Diego, On Thu, May 28, 2020 at 10:47:11PM +0200, Diego Rondini wrote: > Enable support for USB OTG port on Orange Pi Zero Plus 2 (both H3 and H5 > variants). As, according to the board schematics, the USB OTG port cannot > provide power to external devices, we set dr_mode to peripheral. > >

Re: [PATCH v3 032/105] drm/vc4: crtc: Enable and disable the PV in atomic_enable / disable

2020-06-12 Thread Maxime Ripard
Hi Eric, On Tue, Jun 02, 2020 at 12:31:37PM -0700, Eric Anholt wrote: > On Tue, Jun 2, 2020 at 8:02 AM Dave Stevenson > wrote: > > > > Hi Maxime and Eric > > > > On Tue, 2 Jun 2020 at 15:12, Maxime Ripard wrote: > > > > > > Hi Eric > >

Re: [PATCH v4 2/3] clk: bcm: Add BCM2711 DVP driver

2020-06-11 Thread Maxime Ripard
Hi Stefan, On Thu, Jun 11, 2020 at 05:50:30PM +0200, Stefan Wahren wrote: > > diff --git a/drivers/clk/bcm/clk-bcm2711-dvp.c > > b/drivers/clk/bcm/clk-bcm2711-dvp.c > > new file mode 100644 > > index ..84dbc886e303 > > --- /dev/null > > +++ b/drivers/clk/bcm/clk-bcm2711-dvp.c > > @@

[PATCH v4 0/9] drm/vc4: Turn the TXP into a CRTC

2020-06-11 Thread Maxime Ripard
HDMI series - Change the bind order of the HVS to avoid a compatible check - Added Eric's tags - Rebased on top of drm-misc-next Maxime Ripard (9): drm/vc4: Reorder the bind order of the devices drm/vc4: crtc: Move HVS setup code to the HVS driver drm/vc4: crtc: Make state functions

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-11 Thread Maxime Ripard
Hi Stefan, On Sat, Jun 06, 2020 at 10:06:12AM +0200, Stefan Wahren wrote: > Hi Maxime, > > Am 05.06.20 um 16:35 schrieb Maxime Ripard: > > Hi Stefan, > > > > On Wed, Jun 03, 2020 at 07:32:30PM +0200, Stefan Wahren wrote: > >> Am 02.06.20 um 17:54 schrieb Maxim

[PATCH v4 5/9] drm/vc4: crtc: Only access the PixelValve registers if we have to

2020-06-11 Thread Maxime Ripard
The CRTC hooks are called both for the TXP and the pixelvalve, yet some will read / write the registers as if the device was a pixelvalve, which won't really work. Let's make sure we only access those registers if we are running on a PixelValve. Reviewed-by: Eric Anholt Signed-off-by: Maxime

[PATCH v4 2/9] drm/vc4: crtc: Move HVS setup code to the HVS driver

2020-06-11 Thread Maxime Ripard
the HVS setup code into helpers so that we can also reuse them from the TXP driver. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 256 +-- drivers/gpu/drm/vc4/vc4_drv.h | 5 +- drivers/gpu/drm/vc4/vc4_hvs.c | 291

[PATCH v4 1/9] drm/vc4: Reorder the bind order of the devices

2020-06-11 Thread Maxime Ripard
We'll need the HVS to be bound before the HVS for the upcoming reworks, but it needs to happen before the PV are bound so that the code to set the possible_crtcs field works properly on the TXP. Move it right between the two devices. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4

[PATCH v4 8/9] drm/vc4: txp: Turn the TXP into a CRTC of its own

2020-06-11 Thread Maxime Ripard
directly. Now that we have a clear separation between the three parts, we can represent the TXP as a CRTC of its own, leveraging the common CRTC and HVS code, but leaving aside the pixelvalve setup. Reviewed-by: Eric Anholt Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 19

[PATCH v4 7/9] drm/vc4: crtc: Move the txp_armed function to the TXP

2020-06-11 Thread Maxime Ripard
The TXP driver is the only place where we need to set the txp_armed flag, so let's move the function in the TXP driver. Reviewed-by: Eric Anholt Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 7 --- drivers/gpu/drm/vc4/vc4_drv.h | 1 - drivers/gpu/drm/vc4/vc4_txp.c

[PATCH v4 3/9] drm/vc4: crtc: Make state functions public

2020-06-11 Thread Maxime Ripard
We'll need the CRTC state related functions to be exported so that we can reuse them for the TXP. Reviewed-by: Eric Anholt Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 21 ++--- drivers/gpu/drm/vc4/vc4_drv.h | 10 ++ 2 files changed, 20 insertions

[PATCH v4 9/9] drm/vc4: crtc: Remove the feed_txp tests

2020-06-11 Thread Maxime Ripard
Now that the code in vc4_crtc accessing registers is only meant for the pixelvalve, it doesn't make sense anymore to test whether we're accessing the TXP or not and we can safely remove those checks. Reviewed-by: Eric Anholt Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 29

[PATCH v4 6/9] drm/vc4: crtc: Move the CRTC initialisation to a separate function

2020-06-11 Thread Maxime Ripard
The upcoming patches to turn the TXP into a full-blown CRTC will have the same CRTC initialisation code, so let's move it into a separate, public, function so that we can reuse it later on. Reviewed-by: Eric Anholt Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 87

[PATCH v4 4/9] drm/vc4: crtc: Split CRTC data in two

2020-06-11 Thread Maxime Ripard
part into the TXP later on. Reviewed-by: Eric Anholt Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 29 ++--- drivers/gpu/drm/vc4/vc4_drv.h | 19 +++ 2 files changed, 37 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/vc4

[PATCH v4 2/3] clk: bcm: Add BCM2711 DVP driver

2020-06-11 Thread Maxime Ripard
...@vger.kernel.org Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/Kconfig | 11 +++- drivers/clk/bcm/Makefile | 1 +- drivers/clk/bcm/clk-bcm2711-dvp.c | 120 +++- 3 files changed, 132 insertions(+) create mode 100644 drivers/clk

[PATCH v4 0/3] clk: bcm: Add BCM2711 DVP driver

2020-06-11 Thread Maxime Ripard
: - Switch to devm_platform_get_and_ioremap_resource and devm_reset_controller_register - Actually use the Kconfig symbol in the Makefile Maxime Ripard (3): dt-bindings: clock: Add BCM2711 DVP binding clk: bcm: Add BCM2711 DVP driver ARM: dts: bcm2711: Add HDMI DVP Documentation/devicetree

[PATCH v4 1/3] dt-bindings: clock: Add BCM2711 DVP binding

2020-06-11 Thread Maxime Ripard
The BCM2711 has a unit controlling the HDMI0 and HDMI1 clock and reset signals. Let's add a binding for it. Cc: Philipp Zabel Cc: Rob Herring Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/clock/brcm,bcm2711-dvp.yaml

[PATCH v4 3/3] ARM: dts: bcm2711: Add HDMI DVP

2020-06-11 Thread Maxime Ripard
Now that we have a driver for the DVP, let's add its DT node. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/bcm2711.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi index a91cf68e3c4c..00bcaed1be32

[PATCH v4 04/27] clk: bcm: rpi: Allow the driver to be probed by DT

2020-06-11 Thread Maxime Ripard
Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 1654fd0eedc9..8610355bda47 100644

<    4   5   6   7   8   9   10   11   12   13   >