[PATCH v4 08/27] clk: bcm: rpi: Make sure pllb_arm is removed

: Stephen Boyd Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk

[PATCH v4 24/27] ARM: dts: bcm2711: Add firmware clocks node

Now that we have a clock driver for the clocks exposed by the firmware, let's add the device tree nodes for it. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot

[PATCH v4 05/27] clk: bcm: rpi: Statically init clk_init_data

Instead of declaring the clk_init_data and then calling memset on it, just initialise properly. Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-...@vger.kernel.org Reviewed-by: Stephen Boyd Acked-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c

[PATCH v4 25/27] clk: bcm2835: Allow custom CCF flags for the PLLs

While some clock types allow for each clock to specify its own custom flags, the PLLs can't. We will need this for the PLLB, so let's add it. Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-bcm2835.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk

[PATCH v4 11/27] clk: bcm: rpi: Make sure the clkdev lookup is removed

-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 23f06618a356..a20492fade6a 100644

[PATCH v4 18/27] clk: bcm: rpi: Make the PLLB registration function return a clk_hw

we'll want that for the future clocks, let's return a clk_hw pointer instead of the return code. Cc: Michael Turquette Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 46

[PATCH v4 13/27] clk: bcm: rpi: Create a data structure for the clocks

quette Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/clk/bcm/clk-raspbe

[PATCH v4 06/27] clk: bcm: rpi: Use clk_hw_register for pllb_arm

: Michael Turquette Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c

[PATCH v4 26/27] clk: bcm2835: Don't cache the PLLB rate

The PLLB rate will be changed through the firmware clocks drivers and will change behind this drivers' back, so we don't want to cache the rate. Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-bcm2835.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk

[PATCH v4 09/27] clk: bcm: rpi: Remove pllb_arm_lookup global pointer

-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index d62605861028

[PATCH v4 10/27] clk: bcm: rpi: Switch to clk_hw_register_clkdev

Since we don't care about retrieving the clk_lookup structure pointer returned by clkdev_hw_create, we can just use the clk_hw_register_clkdev function. Cc: Michael Turquette Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard

[PATCH v4 20/27] clk: bcm: rpi: Add an enum for the firmware clocks

Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 5f4e2d49432f..eebd16040f8a 100644 --- a/drivers

[PATCH v4 22/27] clk: bcm: rpi: Give firmware clocks a name

We've registered the firmware clocks using their ID as name, but it's much more convenient to register them using their proper name. Since the firmware doesn't provide it, we have to duplicate it. Acked-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk

[PATCH v4 19/27] clk: bcm: rpi: Add DT provider for the clocks

For the upcoming registration of the clocks provided by the firmware, make sure it's exposed to the device tree providers. Cc: Michael Turquette Cc: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk

[PATCH v4 23/27] Revert "clk: bcm2835: remove pllb"

-by: Maxime Ripard --- drivers/clk/bcm/clk-bcm2835.c | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index 6bb7efa12037..32f5c13be9d1 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b

[PATCH v4 14/27] clk: bcm: rpi: Add clock id to data

: linux-...@vger.kernel.org Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk

[PATCH v4 21/27] clk: bcm: rpi: Discover the firmware clocks

through the device tree for consumers to use them. Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-...@vger.kernel.org Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 153 --- 1 file changed, 141 insertions(+), 12

[PATCH v4 12/27] clk: bcm: rpi: Use CCF boundaries instead of rolling our own

The raspberrypi firmware clock driver has a min_rate / max_rate clamping by storing the info it needs in a private structure. However, the CCF already provides such a facility, so we can switch to it to remove the boilerplate. Reviewed-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard

[PATCH v4 03/27] firmware: rpi: Only create clocks device if we don't have a node for it

-by: Maxime Ripard --- drivers/firmware/raspberrypi.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c index ef8098856a47..b25901a77c09 100644 --- a/drivers/firmware/raspberrypi.c +++ b/drivers/firmware/raspberrypi.c

[PATCH v4 15/27] clk: bcm: rpi: Pass the clocks data to the firmware function

Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 97ac04604b0a..3fce49a65a79 100644 --- a/drivers

[PATCH v4 27/27] clk: bcm: rpi: Remove the quirks for the CPU clock

The CPU clock has had so far a bunch of quirks to expose the clock tree properly, but since we reverted to exposing them through the MMIO driver, we can remove that code from the firmware driver. Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 164

[PATCH v4 17/27] clk: bcm: rpi: Split pllb clock hooks

Acked-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c

[PATCH v4 16/27] clk: bcm: rpi: Rename is_prepared function

-by: Nicolas Saenz Julienne Reviewed-by: Stephen Boyd Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 3fce49a65a79..58ac1b104429

[PATCH v4 01/27] dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML

From: Florian Fainelli Convert the Raspberry Pi BCM2835 firmware binding document to YAML. Verified with dt_binding_check and dtbs_check. Signed-off-by: Florian Fainelli Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.txt | 14

[PATCH v4 02/27] dt-bindings: clock: Add a binding for the RPi Firmware clocks

Reviewed-by: Stephen Boyd Reviewed-by: Rob Herring Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml | 24 1 file changed, 24 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835

[PATCH v4 07/27] clk: bcm: rpi: Remove global pllb_arm clock pointer

-by: Nicolas Saenz Julienne Signed-off-by: Maxime Ripard --- drivers/clk/bcm/clk-raspberrypi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c index 5f0d4875e145..b21dd6ddc4fe 100644 --- a/drivers/clk

[PATCH v4 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks

- Removed the PLLB setup from the firmware clocks and moved it back to the MMIO driver Florian Fainelli (1): dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML Maxime Ripard (26): dt-bindings: clock: Add a binding for the RPi Firmware clocks firmware: rpi: Only create

Re: [PATCH v3 066/105] drm/vc4: txp: Turn the TXP into a CRTC of its own

on. > > Due to the sheer volume, it's likely to miss various points - large or > small (like below). Yeah, I know, I wasn't really happy about it either :/ I already removed some parts of it to reduce it, but I'll try to be more aggressive. > On Thu, 28 May 2020 at 08:47, Maxime Ripar

Re: [PATCH] drm/sun4i: hdmi ddc clk: Fix size of m divider

On Thu, Jun 04, 2020 at 01:19:32PM +0800, Chen-Yu Tsai wrote: > On Wed, Apr 22, 2020 at 5:23 PM Maxime Ripard wrote: > > > > Hi, > > > > On Wed, Apr 15, 2020 at 07:52:28PM +0200, Jernej Škrabec wrote: > > > Dne sreda, 15. april 2020 ob 12:42:14 CEST je Maxi

Re: [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq()

On Mon, Jun 08, 2020 at 08:54:51PM +0800, Frank Lee wrote: > On Fri, Jun 5, 2020 at 11:18 PM Maxime Ripard wrote: > > > > Hi, > > > > On Fri, Jun 05, 2020 at 08:55:44PM +0800, Frank Lee wrote: > > > From: Yangtao Li > > > > > >

Re: [PATCH v2 2/9] irqchip/sun6i-r: Add wakeup support

r, so the firmware's wakeup logic > is as simple as waiting for an interrupt to arrive. > > Signed-off-by: Samuel Holland Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v2 1/9] irqchip/sun6i-r: Use a stacked irqchip driver

RQ 0 pending" output and the GIC NMI input. > > This commit mostly reverts commit 173bda53b340 ("irqchip/sunxi-nmi: > Support sun6i-a31-r-intc compatible"). > > Signed-off-by: Samuel Holland As usual, thanks for that commit log (and the experiments you did to write it in the first place). Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v3 004/105] clk: bcm: Add BCM2711 DVP driver

Hi Nicolas, On Thu, Jun 04, 2020 at 07:26:07PM +0200, Nicolas Saenz Julienne wrote: > On Wed, 2020-05-27 at 17:47 +0200, Maxime Ripard wrote: > > The HDMI block has a block that controls clocks and reset signals to the > > HDMI0 and HDMI1 controllers. > > Why not having

Re: [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq()

Hi, On Fri, Jun 05, 2020 at 08:55:44PM +0800, Frank Lee wrote: > From: Yangtao Li > > Using %px to show the actual address in sunxi_mmc_irq() > to help us to debug issue. > > Signed-off-by: Yangtao Li > Signed-off-by: Frank Lee I'm fairly sure this hash is on purpose, and both the commit

Re: 回复：[PATCH 2/4] pinctrl: sunxi: add support for the Allwinner A100 pin controller

Hi Frank, On Wed, Jun 03, 2020 at 05:44:36PM +0800, 李扬韬 wrote: > >> + SUNXI_PIN(SUNXI_PINCTRL_PIN(F, 0), > >> + SUNXI_FUNCTION(0x0, "gpio_in"), > >> + SUNXI_FUNCTION(0x1, "gpio_out"), > >> + SUNXI_FUNCTION(0x2, "mmc0"), /* D1 */ > >> + SUNXI_FUNCTION(0x3, "jtag"), /* MS1 */ > >> +

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

Hi Stefan, On Wed, Jun 03, 2020 at 07:32:30PM +0200, Stefan Wahren wrote: > Am 02.06.20 um 17:54 schrieb Maxime Ripard: > > On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: > >> On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: > >>> the vc4_hdmi dri

Re: [PATCH v3 12/25] clk: bcm: rpi: Use CCF boundaries instead of rolling our own

Hi Nicolas, On Thu, Jun 04, 2020 at 08:02:22PM +0200, Nicolas Saenz Julienne wrote: > On Wed, 2020-05-27 at 17:45 +0200, Maxime Ripard wrote: > > The raspberrypi firmware clock driver has a min_rate / max_rate clamping by > > storing the info it needs in a private structure. &

Re: [PATCH v3 032/105] drm/vc4: crtc: Enable and disable the PV in atomic_enable / disable

Hi Stefan, On Tue, Jun 02, 2020 at 10:03:13PM +0200, Stefan Wahren wrote: > Am 02.06.20 um 21:31 schrieb Eric Anholt: > > On Tue, Jun 2, 2020 at 8:02 AM Dave Stevenson > > wrote: > >> Hi Maxime and Eric > >> > >> On Tue, 2 Jun 2020 at 15:12, Maxime Ripar

Re: [PATCH v3 055/105] drm/vc4: hvs: Introduce a function to get the assigned FIFO

Hi Eric, On Wed, May 27, 2020 at 12:40:02PM -0700, Eric Anholt wrote: > On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > > > At boot time, if we detect that a pixelvalve has been enabled, we need to > > be able to retrieve the HVS channel it has been assig

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: > On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: > > > > the vc4_hdmi driver has some custom structures to hold the data it needs to > > associate with the drm_encoder and drm_connector structures. > >

Re: [PATCH v3 104/105] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings

Hi Rob, On Fri, May 29, 2020 at 12:18:33PM -0600, Rob Herring wrote: > On Wed, May 27, 2020 at 05:49:14PM +0200, Maxime Ripard wrote: > > The HDMI controllers found in the BCM2711 SoC need some adjustments to the > > bindings, especially since the registers have been shuffled

Re: [PATCH v3 006/105] dt-bindings: display: Convert VC4 bindings to schemas

Hi Rob, On Wed, May 27, 2020 at 01:12:11PM -0600, Rob Herring wrote: > On Wed, May 27, 2020 at 05:47:36PM +0200, Maxime Ripard wrote: > > The BCM283x SoCs have a display pipeline composed of several controllers > > with device tree bindings that are supported by Linux. > >

Re: [PATCH v3 032/105] drm/vc4: crtc: Enable and disable the PV in atomic_enable / disable

Hi Eric On Wed, May 27, 2020 at 09:54:44AM -0700, Eric Anholt wrote: > On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > > > The VIDEN bit in the pixelvalve currently being used to enable or disable > > the pixelvalve seems to not be enough in some situations, w

Re: [PATCH v3 015/105] drm/vc4: hvs: Boost the core clock during modeset

Hi Eric, On Wed, May 27, 2020 at 09:33:44AM -0700, Eric Anholt wrote: > On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > > > In order to prevent timeouts and stalls in the pipeline, the core clock > > needs to be maxed at 500MHz during a modeset on the BCM2711.

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

Hi, On Mon, Jun 01, 2020 at 03:58:26PM +0800, Jian-Hong Pan wrote: > Maxime Ripard 於 2020年5月28日 週四 下午3:30寫道： > > > > Hi Daniel, > > > > On Wed, May 27, 2020 at 05:15:12PM +0800, Daniel Drake wrote: > > > On Wed, May 27, 2020 at 5:13 PM Maxime Ripard wrote:

Re: [PATCH] arm: allwinner: a20: Add Drejo DS167 initial support

Hi, Please make sure that all the proper recipients are in Cc. The linux-arm-kernel ML especially is missing, get_maintainers will give you the list. Also, the prefix of your commit log is supposed to be ARM: dts: sunxi: ... On Sun, May 31, 2020 at 02:05:38PM +0300, stul...@gmail.com wrote: >

Re: [PATCH v3 02/25] dt-bindings: clock: Add a binding for the RPi Firmware clocks

Hi Stephen, Thanks for your review :) On Fri, May 29, 2020 at 02:17:16PM -0700, Stephen Boyd wrote: > > + "#clock-cells": > > +const: 1 > > +description: > > > Just curious if this is the same as the | syntax? I haven't seen this > used before. It differs on how it keeps

Re: [PATCH] watchdog: sunxi_wdt: fix improper error exit code

On Fri, May 29, 2020 at 05:45:14PM +0800, Frank Lee wrote: > From: Martin Wu > > sunxi_wdt_probe() should return -ENOMEM when devm_kzalloc() fails. > > Signed-off-by: Martin Wu > Signed-off-by: Frank Lee Acked-by: Maxime Ripard Thanks! Maxime signature.asc Description: PGP signature

Re: [PATCH v2 00/91] drm/vc4: Support BCM2711 Display Pipelin

Hi Daniel, On Wed, May 27, 2020 at 05:15:12PM +0800, Daniel Drake wrote: > On Wed, May 27, 2020 at 5:13 PM Maxime Ripard wrote: > > I'm about to send a v3 today or tomorrow, I can Cc you (and Jian-Hong) if > > you > > want. > > That would be great, although given t

[PATCH v3 010/105] dt-bindings: display: vc4: Document BCM2711 VC5

The BCM2711 comes with a new VideoCore. Add a compatible for it. Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/brcm,bcm2835-vc4.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH v3 018/105] drm/vc4: plane: Move additional planes creation to driver

is preserved though. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 4 drivers/gpu/drm/vc4/vc4_drv.c | 7 +++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 29c72c322c6b..2131164779dd 100644

[PATCH v3 011/105] drm/vc4: drv: Add include guards

vc4_drv.h doesn't have any include guards which prevents it from being included twice. Let's add them. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h index

[PATCH v3 005/105] ARM: dts: bcm2711: Add HDMI DVP

Now that we have a driver for the DVP, let's add its DT node. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/bcm2711.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi index a91cf68e3c4c..00bcaed1be32

[PATCH v3 008/105] dt-bindings: display: vc4: dsi: Add missing clock properties

While the device tree and the driver expected a clock-names and a clock-cells properties, it wasn't explicitly documented in the previous binding. Make sure it is now. Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings

[PATCH v3 007/105] dt-bindings: display: vc4: dpi: Add missing clock-names property

While the device tree and the driver expected a clock-names property, it wasn't explicitly documented in the previous binding. Make sure it is now. Cc: devicet...@vger.kernel.org Reviewed-by: Rob Herring Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/brcm,bcm2835

[PATCH v3 020/105] drm/vc4: plane: Create overlays for any CRTC

of the various planes is changed again, and we will now have all the primary planes, then all the overlay planes and finally the cursor planes. This shouldn't cause any issue since the ordering between primary, overlay and cursor planes is preserved. Signed-off-by: Maxime Ripard --- drivers/gpu

[PATCH v3 024/105] drm/vc4: crtc: Move crtc state to common header

We'll need to access the crtc_state from outside of vc4_crtc.c, so let's move it to vc4_drv.h Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 21 - drivers/gpu/drm/vc4/vc4_drv.h | 21 + 2 files changed, 21 insertions(+), 21 deletions

[PATCH v3 006/105] dt-bindings: display: Convert VC4 bindings to schemas

conversion though, and some bindings were incomplete so it results in example validation warnings that are going to be addressed in the following patches. Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt

[PATCH v3 014/105] drm/vc4: Add support for the BCM2711 HVS5

-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 24 +++- drivers/gpu/drm/vc4/vc4_drv.h | 4 +- drivers/gpu/drm/vc4/vc4_hvs.c | 16 ++- drivers/gpu/drm/vc4/vc4_plane.c | 194 - drivers/gpu/drm/vc4/vc4_regs.h | 67 +++- 5 files changed, 246

[PATCH v3 022/105] drm/vc4: crtc: Rename SoC data structures

Since we're going to introduce pixelvalve data structures for other SoCs than the BCM2835, let's rename the structures defined in the code to make it obvious which SoC we're targeting. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 12 ++-- 1 file changed, 6

[PATCH v3 031/105] drm/vc4: crtc: Use local chan variable

The vc4_crtc_handle_page_flip already has a local variable holding the value of vc4_crtc->channel, so let's use it instead. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.

[PATCH v3 044/105] drm/vc4: crtc: Move the HVS gamma LUT setup to our init function

Since most of the HVS channel is setup in the init function, let's move the gamma setup there too. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hvs.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b

[PATCH v3 050/105] drm/vc4: encoder: Add finer-grained encoder callbacks

In the BCM2711, the setup of the HVS, pixelvalve and HDMI controller requires very precise ordering and timing that the regular atomic callbacks don't provide. Let's add new callbacks on top of the regular ones to be able to split the configuration as needed. Signed-off-by: Maxime Ripard

[PATCH v3 046/105] drm/vc4: hvs: Remove mode_set_nofb

Now that the only thing that remains in the mode_set_nofb callback for the HVS is the TXP muxing, and since that part is already covered by the FIFO channel allocation / muxing, the whole function is basically redundant and we can just remove it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm

[PATCH v3 034/105] drm/vc4: crtc: Add FIFO depth to vc4_crtc_data

Not all pixelvalve FIFOs in vc5 have the same depth, so we need to add that to our vc4_crtc_data structure to be able to compute the fill level properly later on. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 19 --- drivers/gpu/drm/vc4/vc4_drv.h | 3 +++ 2

[PATCH v3 026/105] drm/vc4: crtc: Use a shared interrupt

Some pixelvalves in vc5 use the same interrupt line so let's register our interrupt handler as a shared one. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm

[PATCH v3 032/105] drm/vc4: crtc: Enable and disable the PV in atomic_enable / disable

if the pixelvalve is disabled though. In order to overcome this, we can configure the pixelvalve during mode_set_no_fb, but only enable it in atomic_enable and flush the FIFO there, and in atomic_disable disable the pixelvalve again. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c

[PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

by vc4_hdmi and update the code accordingly. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 87 --- drivers/gpu/drm/vc4/vc4_hdmi.h | 64 +- 2 files changed, 72 insertions(+), 79 deletions(-) diff --git a/drivers/gpu/drm/vc4

[PATCH v3 067/105] drm/vc4: crtc: Remove the feed_txp tests

Now that the code in vc4_crtc accessing registers is only meant for the pixelvalve, it doesn't make sense anymore to test whether we're accessing the TXP or not and we can safely remove those checks. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 31

[PATCH v3 051/105] drm/vc4: crtc: Add a delay after disabling the PixelValve output

In order to avoid pixels getting stuck in the (unflushable) FIFO between the HVS and the PV, we need to add some delay after disabling the PV output and before disabling the HDMI controller. 20ms seems to be good enough so let's use that. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4

[PATCH v3 043/105] drm/vc4: crtc: Move HVS init and close to a function

In order to make further refactoring easier, let's move the HVS channel setup / teardown to their own function. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hvs.c | 106 +++ 1 file changed, 59 insertions(+), 47 deletions(-) diff --git a/drivers/gpu

[PATCH v3 069/105] drm/vc4: hdmi: Move structure to header

We will need to share the vc4_hdmi and related structures with multiple files, so let's create a header for it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 76 +--- drivers/gpu/drm/vc4/vc4_hdmi.h | 86 +++- 2

[PATCH v3 045/105] drm/vc4: hvs: Make sure our channel is reset

In order to clear our intermediate FIFOs that might end up with a stale pixel, let's make sure our FIFO channel is reset everytime our channel is setup. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hvs.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/vc4

[PATCH v3 073/105] drm/vc4: hdmi: Move accessors to vc4_hdmi

the vc4_hdmi structure so that we can eventually get rid of that single global pointer. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 24 +--- drivers/gpu/drm/vc4/vc4_hdmi.h | 8 2 files changed, 13 insertions(+), 19 deletions(-) diff --git a/drivers/gpu

[PATCH v3 042/105] drm/vc4: crtc: Move PV dump to config_pv

Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 93161b98e22a..0a67b27cec9b 100644 --- a/drivers/gpu/drm/vc4

[PATCH v3 072/105] drm/vc4: hdmi: Rename hdmi to vc4_hdmi

The driver isn't consistent with the name given to the vc4_hdmi structure pointer in its functions. Make sure to use a consistent name. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 281 +- 1 file changed, 141 insertions(+), 140 deletions

[PATCH v3 060/105] drm/vc4: crtc: Make state functions public

We'll need the CRTC state related functions to be exported so that we can reuse them for the TXP. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 21 ++--- drivers/gpu/drm/vc4/vc4_drv.h | 10 ++ 2 files changed, 20 insertions(+), 11 deletions(-) diff

[PATCH v3 063/105] drm/vc4: crtc: Move the CRTC initialisation to a separate function

The upcoming patches to turn the TXP into a full-blown CRTC will have the same CRTC initialisation code, so let's move it into a separate, public, function so that we can reuse it later on. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 89

[PATCH v3 099/105] drm/vc4: hdmi: Always recenter the HDMI FIFO

In order to avoid a pixel getting stuck in an unflushable FIFO, we need to recenter the FIFO every time we're doing a modeset and not only if we're connected to an HDMI monitor. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 46 +++ 1 file

[PATCH v3 095/105] drm/vc4: hdmi: Set the b-frame marker to the match ALSA's default.

From: Dave Stevenson ALSA's iec958 plugin by default sets the block start preamble to 8, whilst this driver was programming the hardware to expect 0xF. Amend the hardware config to match ALSA. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 3

[PATCH v3 090/105] drm/vc4: hdmi: Rename drm_encoder pointer in mode_valid

The mode_valid hook on the encoder uses a pointer to a drm_encoder called crtc, which is pretty confusing. Let's rename it to encoder to make it clear what it is. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 081/105] drm/vc4: hdmi: Add reset callback

The BCM2711 and BCM283x HDMI controllers use a slightly different reset sequence, so let's add a callback to reset the controller. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 31 ++- drivers/gpu/drm/vc4/vc4_hdmi.h | 3 +++ 2 files changed, 21

[PATCH v3 078/105] drm/vc4: hdmi: Remove vc4_hdmi_connector

The vc4_hdmi_connector was only used to switch between drm_connector to drm_encoder. However, we can now use vc4_hdmi to do the switch, so that structure is redundant. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 19 --- drivers/gpu/drm/vc4/vc4_hdmi.h | 23

[PATCH v3 076/105] drm/vc4: hdmi: Pass vc4_hdmi to CEC code

Our CEC code also retrieves the associated vc4_hdmi by setting the vc4_dev pointer as its private data, and then dereferences its vc4_hdmi pointer. In order to eventually get rid of that pointer, we can simply pass the vc4_hdmi pointer directly. Signed-off-by: Maxime Ripard --- drivers/gpu/drm

[PATCH v3 082/105] drm/vc4: hdmi: Add PHY init and disable function

The HDMI PHY in the BCM2711 HDMI controller is significantly more complicated to setup than in the older BCM283x SoCs. Let's add hooks to enable and disable the PHY. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/Makefile | 1 + drivers/gpu/drm/vc4/vc4_hdmi.c | 14

[PATCH v3 097/105] drm/vc4: hdmi: Deal with multiple ALSA cards

-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 3 ++- drivers/gpu/drm/vc4/vc4_hdmi.h | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 7f98c1bbda73..5ad983ce87d1 100644 --- a/drivers/gpu/drm/vc4

[PATCH v3 088/105] drm/vc4: hdmi: Add CEC support flag

Similarly to the audio support, CEC support is not there yet for the BCM2711, so let's skip entirely the CEC initialization through a variant flag. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 4 drivers/gpu/drm/vc4/vc4_hdmi.h | 3 +++ 2 files changed, 7 insertions

[PATCH v3 091/105] drm/vc4: hdmi: Adjust HSM clock rate depending on pixel rate

a clock that can provide it, but we still have to take care of a 4k panel plugged on a BCM283x SoCs that wouldn't be able to use those modes, so let's define the limit in the variant. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 79 --- drivers/gpu

[PATCH v3 054/105] drm/vc4: hvs: Make the stop_channel function public

-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.h | 1 + drivers/gpu/drm/vc4/vc4_hvs.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h index ba24bad86905..d51b695732e0 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.h

[PATCH v3 102/105] drm/vc4: hdmi: Switch to blank pixels when disabled

In order to avoid pixels getting stuck in an unflushable FIFO, we need when we disable the HDMI controller to switch away from getting our pixels from the pixelvalve and instead use blank pixels, and switch back to the pixelvalve when we enable the HDMI controller. Signed-off-by: Maxime Ripard

[PATCH v3 075/105] drm/vc4: hdmi: Add container_of macros for encoders and connectors

. That will also give us some trouble when having multiple controllers, but now that we have our encoder and connector structures that are part of vc4_hdmi, we can simply call container_of on the DRM connector or encoder and retrieve the vc4_hdmi structure directly. Signed-off-by: Maxime Ripard

[PATCH v3 086/105] drm/vc4: hdmi: Deal with multiple debugfs files

. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 5 - drivers/gpu/drm/vc4/vc4_hdmi.h | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 7542447eb314..8a63ac3dd86b 100644 --- a/drivers/gpu

[PATCH v3 098/105] drm/vc4: hdmi: Remove register dumps in enable

. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 5ad983ce87d1..4b23d589377a 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4

[PATCH v3 087/105] drm/vc4: hdmi: Move CEC init to its own function

The CEC init code was put directly into the bind function, which was quite inconsistent with how the audio support was done, and would prevent us from further changes to skip that initialisation entirely. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 108

[PATCH v3 104/105] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings

The HDMI controllers found in the BCM2711 SoC need some adjustments to the bindings, especially since the registers have been shuffled around in more register ranges. Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/brcm

[PATCH v3 105/105] ARM: dts: bcm2711: Enable the display pipeline

Now that all the drivers have been adjusted for it, let's bring in the necessary device tree changes. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 46 +++- arch/arm/boot/dts/bcm2711.dtsi| 115 ++- 2 files changed, 160

[PATCH v3 103/105] drm/vc4: hdmi: Support the BCM2711 HDMI controllers

Now that the driver is ready for it, let's bring in the HDMI controllers variants for the BCM2711. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 278 +- drivers/gpu/drm/vc4/vc4_hdmi.h | 36 ++- drivers/gpu/drm/vc4/vc4_hdmi_phy.c | 480

[PATCH v3 096/105] drm/vc4: hdmi: Add audio-related callbacks

From: Dave Stevenson The audio configuration has changed for the BCM2711, with notably a different parent clock and a different channel configuration. Make that modular to be able to support the BCM2711. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4

[PATCH v3 093/105] drm/vc4: hdmi: Use reg-names to retrieve the HDMI audio registers

as a fallback. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index c069bf8e6d7c..ebe9dd25c65a 100644 --- a/drivers

[PATCH v3 100/105] drm/vc4: hdmi: Implement finer-grained hooks

constraints, so we need to roll our own callbacks so that we can provide those guarantees. Since those callbacks have been implemented and called in the CRTC code, we can just implement them in the HDMI driver now. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 43

<    5   6   7   8   9   10   11   12   13   14   >