Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_board()

On Thu, Nov 19, 2020 at 9:53 PM Jakub Kicinski wrote: > > On Thu, 19 Nov 2020 10:53:23 -0800 Edwin Peer wrote: > > > Fix to return a negative error code from the error handling > > > case instead of 0, as done elsewhere in this function. > > > > > > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom

Re: [PATCH net] net: b44: fix error return code in b44_init_one()

ted-by: Hulk Robot > Signed-off-by: Zhang Changzhong Reviewed-by: Michael Chan Thanks. smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command

On Mon, Sep 14, 2020 at 2:31 PM Jakub Kicinski wrote: > > On Mon, 14 Sep 2020 13:28:29 +0200 Jiri Pirko wrote: > > >> Instead, why don't you block in reload_up() until the reset is complete? > > > > > >Though user initiate "devlink dev reload" event on a single interface, > > >all driver entities

Re: [PATCH v2] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

On Fri, Jul 24, 2020 at 5:19 PM David Christensen wrote: > In the working case, tg3_init_hw() returns successfully, resulting in > every instance of napi_disable() being followed by an instance of > napi_enable(). > > In the failing case, tg3_hw_init() returns an error. (This is not > surprising

Re: [PATCH][next] tg3: Avoid the use of one-element array

nux/issues/79 > [2] https://github.com/KSPP/linux/issues/86 > > Tested-by: kernel test robot > Link: > https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/tg3-20200718.md > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Michael Chan

Re: [PATCH v2] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

ock. > > Add check for pcierr_recovery which skips code already executed for the > "Frozen" state. > > Signed-off-by: David Christensen Reviewed-by: Michael Chan Thanks.

Re: [PATCH] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

On Mon, Jun 15, 2020 at 3:21 PM David Christensen wrote: > > On 6/15/20 1:45 PM, Michael Chan wrote: > > On Mon, Jun 15, 2020 at 12:01 PM David Christensen > > wrote: > >> > >> The driver function tg3_io_error_detected() calls napi_disable twice, > >

Re: [PATCH] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

On Mon, Jun 15, 2020 at 12:01 PM David Christensen wrote: > > The driver function tg3_io_error_detected() calls napi_disable twice, > without an intervening napi_enable, when the number of EEH errors exceeds > eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock. > > The

Re: [PATCH v3 6/8] bnxt_en: use new taint_firmware_crashed()

covery > sometimes requires a driver unload / reload and in the worst cases > a reboot. > > Using a taint flag allows us to annotate when this happens clearly. > > Cc: Michael Chan > Cc: Luis Chamberlain > Acked-by: Rafael Aquini > Signed-off-by: Vasundhara Volam > Signed

Re: [PATCH] cnic: remove redundant assignment to variable ret

On Fri, May 8, 2020 at 3:40 PM Colin King wrote: > > From: Colin Ian King > > The variable ret is being assigned with a value that is never read, > the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Reviewed-by: Michael Chan

Re: [PATCH] net: tg3: tidy up loop, remove need to compute off with a multiply

On Fri, May 8, 2020 at 7:31 PM Joe Perches wrote: > > On Fri, 2020-05-08 at 18:48 -0700, Jakub Kicinski wrote: > > On Sat, 9 May 2020 00:31:03 +0100 Colin Ian King wrote: > > > > My preference would be for > > > > > > > > { > > > > int i; > > > > u32 off = 0; > > > > > > > > for (i = 0; i <

Re: [PATCH] net: tg3: tidy up loop, remove need to compute off with a multiply

On Fri, May 8, 2020 at 3:53 PM Colin King wrote: > > From: Colin Ian King > > Currently the value for 'off' is computed using a multiplication and > a couple of statements later off is being incremented by len and > this value is never read. Clean up the code by removing the > multiplication

Re: [PATCH 2/2] cnic: Use refcount_t for refcount

On Wed, Jul 31, 2019 at 7:22 PM Chuhong Yuan wrote: > > Michael Chan 于2019年8月1日周四 上午1:58写道： > > > > On Wed, Jul 31, 2019 at 5:22 AM Chuhong Yuan wrote: > > > > > static void cnic_ctx_wr(struct cnic_dev *dev, u32 cid_addr, u32 off, u32 > &g

Re: [PATCH 2/2] cnic: Use refcount_t for refcount

On Wed, Jul 31, 2019 at 5:22 AM Chuhong Yuan wrote: > static void cnic_ctx_wr(struct cnic_dev *dev, u32 cid_addr, u32 off, u32 val) > @@ -494,7 +494,7 @@ int cnic_register_driver(int ulp_type, struct > cnic_ulp_ops *ulp_ops) > } > read_unlock(_dev_lock); > > -

Re: [PATCH 1/2] bnxt_en: Use refcount_t for refcount

On Wed, Jul 31, 2019 at 9:06 AM Willem de Bruijn wrote: > > On Wed, Jul 31, 2019 at 8:22 AM Chuhong Yuan wrote: > > > > refcount_t is better for reference counters since its > > implementation can prevent overflows. > > So convert atomic_t ref counters to refcount_t. > > > > Signed-off-by:

Re: [PATCH net-next] bnxt: remove printing of hwrm message

irmware. The issue is this message means nothing to > anyone except Broadcom. Remove the message to not confuse users as this > message is really not very informative. > > Signed-off-by: Jonathan Toppins > --- > > Notes: > v2: > include changes recommended by Michael Chan > Acked-by: Michael Chan

Re: [PATCH 4.4 51/79] bnxt_en: Fix for system hang if request_irq fails

On Tue, Sep 11, 2018 at 1:14 PM, Ben Hutchings wrote: > On Thu, 2018-08-23 at 09:53 +0200, Greg Kroah-Hartman wrote: >> 4.4-stable review patch. If anyone has any objections, please let me know. >> >> -- >> >> From: Vikas Gupta >> >> [ Upstream commit

Re: [PATCH 4.4 51/79] bnxt_en: Fix for system hang if request_irq fails

On Tue, Sep 11, 2018 at 1:14 PM, Ben Hutchings wrote: > On Thu, 2018-08-23 at 09:53 +0200, Greg Kroah-Hartman wrote: >> 4.4-stable review patch. If anyone has any objections, please let me know. >> >> -- >> >> From: Vikas Gupta >> >> [ Upstream commit

Re: [PATCH net-next] bnxt_en: Fix logic of forward the VF MAC address to PF in bnxt_vf_validate_set_mac

On Tue, Jul 24, 2018 at 9:01 AM, Vasundhara Volam wrote: > On Tue, Jul 24, 2018 at 1:01 PM, Michael Chan > wrote: >> >> On Mon, Jul 23, 2018 at 10:24 PM, YueHaibing wrote: >> > Based on the comments,req->l2addr must match the VF MAC address >> > if fir

Re: [PATCH net-next] bnxt_en: Fix logic of forward the VF MAC address to PF in bnxt_vf_validate_set_mac

On Tue, Jul 24, 2018 at 9:01 AM, Vasundhara Volam wrote: > On Tue, Jul 24, 2018 at 1:01 PM, Michael Chan > wrote: >> >> On Mon, Jul 23, 2018 at 10:24 PM, YueHaibing wrote: >> > Based on the comments,req->l2addr must match the VF MAC address >> > if fir

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

On Wed, May 2, 2018 at 5:30 PM, Zumeng Chen <zumeng.c...@gmail.com> wrote: > On 2018年05月03日 01:32, Michael Chan wrote: >> >> On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen <zumeng.c...@gmail.com> wrote: >>> >>> On 2018年05月02日 13:12, Michael Chan wrote: >

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

On Wed, May 2, 2018 at 5:30 PM, Zumeng Chen wrote: > On 2018年05月03日 01:32, Michael Chan wrote: >> >> On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote: >>> >>> On 2018年05月02日 13:12, Michael Chan wrote: >>>> >>>> On Tue, May 1, 2018 a

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen <zumeng.c...@gmail.com> wrote: > On 2018年05月02日 13:12, Michael Chan wrote: >> >> On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen <zumeng.c...@gmail.com> wrote: >> >>> diff --git a/drivers/net/ethernet/broadcom/tg3.h

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote: > On 2018年05月02日 13:12, Michael Chan wrote: >> >> On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote: >> >>> diff --git a/drivers/net/ethernet/broadcom/tg3.h >>> b/drivers/net/ethernet/broadcom/

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote: > diff --git a/drivers/net/ethernet/broadcom/tg3.h > b/drivers/net/ethernet/broadcom/tg3.h > index 3b5e98e..c61d83c 100644 > --- a/drivers/net/ethernet/broadcom/tg3.h > +++ b/drivers/net/ethernet/broadcom/tg3.h > @@

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote: > diff --git a/drivers/net/ethernet/broadcom/tg3.h > b/drivers/net/ethernet/broadcom/tg3.h > index 3b5e98e..c61d83c 100644 > --- a/drivers/net/ethernet/broadcom/tg3.h > +++ b/drivers/net/ethernet/broadcom/tg3.h > @@ -3102,6 +3102,7 @@ enum

Re: [PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

On Fri, Apr 27, 2018 at 8:15 PM, Zumeng Chen wrote: > diff --git a/drivers/net/ethernet/broadcom/tg3.h > b/drivers/net/ethernet/broadcom/tg3.h > index 3b5e98e..6727d93 100644 > --- a/drivers/net/ethernet/broadcom/tg3.h > +++ b/drivers/net/ethernet/broadcom/tg3.h > @@

Re: [PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

On Fri, Apr 27, 2018 at 8:15 PM, Zumeng Chen wrote: > diff --git a/drivers/net/ethernet/broadcom/tg3.h > b/drivers/net/ethernet/broadcom/tg3.h > index 3b5e98e..6727d93 100644 > --- a/drivers/net/ethernet/broadcom/tg3.h > +++ b/drivers/net/ethernet/broadcom/tg3.h > @@ -3352,6 +3352,7 @@ struct

Re: [PATCH v7 6/7] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

ove outside of scope. This line in the patch description is not needed anymore. Other than that, Acked-by: Michael Chan <michael.c...@broadcom.com> Thanks. > > Signed-off-by: Sinan Kaya <ok...@codeaurora.org>

Re: [PATCH v7 6/7] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

in the patch description is not needed anymore. Other than that, Acked-by: Michael Chan Thanks. > > Signed-off-by: Sinan Kaya

Re: [PATCH v6 6/6] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

On Fri, Mar 23, 2018 at 3:23 PM, Sinan Kaya wrote: > Code includes wmb() followed by writel(). writel() already has a barrier on > some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing the > register write. > > Create a new

Re: [PATCH v6 6/6] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

On Fri, Mar 23, 2018 at 3:23 PM, Sinan Kaya wrote: > Code includes wmb() followed by writel(). writel() already has a barrier on > some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing the > register write. > > Create a new wrapper function with

Re: [PATCH net] tg3: prevent scheduling while atomic splat

leep_range(). The wait time is potentially up to 20 msec which is quite long. Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH net] tg3: prevent scheduling while atomic splat

if the udelay should be 20 > instead of 10, due to any timing changes introduced by the offending > patch. Thanks. 10 us is correct. As a future improvement, we might want to see if we can release the spinlock and go back to usleep_range(). The wait time is potentially up to 20 msec which is quite long. Acked-by: Michael Chan

Re: [PATCH] bnxt_en: don't update cpr->rx_bytes with uninitialized length len

a8788f25625 ("bnxt_en: add support for software dynamic interrupt > moderation") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks. Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH] bnxt_en: don't update cpr->rx_bytes with uninitialized length len

upt > moderation") > > Signed-off-by: Colin Ian King Thanks. Acked-by: Michael Chan

Re: [PATCH][next] bnxt_en: ensure len is ininitialized to zero

On Fri, Jan 12, 2018 at 9:46 AM, Colin King wrote: > From: Colin Ian King > > In the case where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP the > exit return path is via label next_rx_no_prod and cpr->rx_bytes > is being updated by an

Re: [PATCH][next] bnxt_en: ensure len is ininitialized to zero

On Fri, Jan 12, 2018 at 9:46 AM, Colin King wrote: > From: Colin Ian King > > In the case where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP the > exit return path is via label next_rx_no_prod and cpr->rx_bytes > is being updated by an uninitialized value from len. Fix this by > initializing len to

Re: [PATCH] bnxt_en: Fix sources of spurious netpoll warnings

s > 0. Fix this by only bumping rx_pkts if we were actually > given a non-zero budget. > > Signed-off-by: Calvin Owens <calvinow...@fb.com> Thanks. Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH] bnxt_en: Fix sources of spurious netpoll warnings

_workq_function+0x3c/0x90 [edac_core] >[] process_one_work+0x19b/0x480 >[] worker_thread+0x6a/0x520 >[] kthread+0xe4/0x100 >[] ret_from_fork+0x22/0x40 > > This happens because we increment rx_pkts on -ENOMEM and -EIO, resulting > in rx_pkts > 0. Fix this by on

Re: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends

On Thu, Dec 7, 2017 at 1:39 AM, Thomas Bogendoerfer <tbogendoer...@suse.de> wrote: > On Thu, 7 Dec 2017 01:24:43 -0800 > Michael Chan <michael.c...@broadcom.com> wrote: > >> On Thu, Dec 7, 2017 at 1:14 AM, Thomas Bogendoerfer >> <tbogendoer...@suse.de> wro

Re: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends

On Thu, Dec 7, 2017 at 1:39 AM, Thomas Bogendoerfer wrote: > On Thu, 7 Dec 2017 01:24:43 -0800 > Michael Chan wrote: > >> On Thu, Dec 7, 2017 at 1:14 AM, Thomas Bogendoerfer >> wrote: >> > well, it will print the forced rate, if there is one configured and -1 &g

Re: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends

On Thu, Dec 7, 2017 at 1:14 AM, Thomas Bogendoerfer <tbogendoer...@suse.de> wrote: > On Wed, 6 Dec 2017 11:27:31 -0800 > Michael Chan <michael.c...@broadcom.com> wrote: > >> On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer >> <tbogendoer...@suse.de>

Re: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends

On Thu, Dec 7, 2017 at 1:14 AM, Thomas Bogendoerfer wrote: > On Wed, 6 Dec 2017 11:27:31 -0800 > Michael Chan wrote: > >> On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer >> wrote: >> > bnxt driver spams logfiles with >> > >> > [ 541.

Re: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends

On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer wrote: > bnxt driver spams logfiles with > > [ 541.003065] bnxt_en :5d:00.1 eth5: Link speed -1 no longer supported > > if a direct attached cable (DAC) is plugged into the bnxt card and is > unplugged on the other

Re: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends

On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer wrote: > bnxt driver spams logfiles with > > [ 541.003065] bnxt_en :5d:00.1 eth5: Link speed -1 no longer supported > > if a direct attached cable (DAC) is plugged into the bnxt card and is > unplugged on the other side. This patch removes

Re: [PATCH 2/2] bnxt_en: Add ETH_RESET_AP support

On Thu, Nov 30, 2017 at 11:36 AM, Scott Branden <scott.bran...@broadcom.com> wrote: > Add ETH_RESET_AP support handling to reset the internal > Application Processor(s) of the SmartNIC card. > > Signed-off-by: Scott Branden <scott.bran...@broadcom.com> Acked-by:

Re: [PATCH 2/2] bnxt_en: Add ETH_RESET_AP support

On Thu, Nov 30, 2017 at 11:36 AM, Scott Branden wrote: > Add ETH_RESET_AP support handling to reset the internal > Application Processor(s) of the SmartNIC card. > > Signed-off-by: Scott Branden Acked-by: Michael Chan

Re: [PATCH] bnxt_en: Fix an error handling path in 'bnxt_get_module_eeprom()'

On Tue, Nov 28, 2017 at 7:56 AM, David Miller wrote: > From: Christophe JAILLET > Date: Tue, 21 Nov 2017 20:46:49 +0100 > >> Error code returned by 'bnxt_read_sfp_module_eeprom_info()' is handled a >> few lines above when reading the A0 portion

Re: [PATCH] bnxt_en: Fix an error handling path in 'bnxt_get_module_eeprom()'

On Tue, Nov 28, 2017 at 7:56 AM, David Miller wrote: > From: Christophe JAILLET > Date: Tue, 21 Nov 2017 20:46:49 +0100 > >> Error code returned by 'bnxt_read_sfp_module_eeprom_info()' is handled a >> few lines above when reading the A0 portion of the EEPROM. >> The same should be done when

Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef

On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote: > There is no reason to wrap the data structures inside the ifdef. What's so bad about wrapping unused data structures inside #ifdef? These structures are only used if CONFIG_BNXT_FLOWER_OFFLOAD is defined.

Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef

On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote: > There is no reason to wrap the data structures inside the ifdef. What's so bad about wrapping unused data structures inside #ifdef? These structures are only used if CONFIG_BNXT_FLOWER_OFFLOAD is defined.

Re: [PATCH net-next 1/2] bnxt_en: don't consider building bnxt_tc.o if option not enabled

> > Signed-off-by: Jonathan Toppins <jtopp...@redhat.com> Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH net-next 1/2] bnxt_en: don't consider building bnxt_tc.o if option not enabled

Toppins Acked-by: Michael Chan

Re: [PATCH net-next v2] tg3: Be drop monitor friendly

gs() is doing ring cleanup. Use dev_consume_skb_any() for > these 3 locations to be SKB drop monitor friendly. > > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Acked-by: Michael Chan <michael.c...@broadcom.com> > --- > Changes in v2: > > - also included tg3_tso_bug() as indicated by Michael >

Re: [PATCH net-next v2] tg3: Be drop monitor friendly

cleanup. Use dev_consume_skb_any() for > these 3 locations to be SKB drop monitor friendly. > > Signed-off-by: Florian Fainelli Acked-by: Michael Chan > --- > Changes in v2: > > - also included tg3_tso_bug() as indicated by Michael >

Re: [PATCH net 1/7] b44: Initialize 64-bit stats seqcount

4 bit stats") > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Acked-by: Michael Chan <michael.c...@broadcom.com> Thanks.

Re: [PATCH net 1/7] b44: Initialize 64-bit stats seqcount

ned-off-by: Florian Fainelli Acked-by: Michael Chan Thanks.

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

On Tue, Jul 25, 2017 at 8:29 AM, Arnd Bergmann wrote: > The sriov_lock is used to serialize the sriov code with the vfr code. > However, when SRIOV is disabled, the lock is not there at all, leading > to a build error: > > drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c: In function

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

On Tue, Jul 25, 2017 at 8:29 AM, Arnd Bergmann wrote: > The sriov_lock is used to serialize the sriov code with the vfr code. > However, when SRIOV is disabled, the lock is not there at all, leading > to a build error: > > drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c: In function >

Re: [PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions

> > Signed-off-by: Benjamin Gaignard <benjamin.gaign...@linaro.org> > CC: Michael Chan <michael.c...@broadcom.com> > CC: net...@vger.kernel.org > CC: linux-kernel@vger.kernel.org Acked-by: Michael Chan <michael.c...@broadcom.com> Thanks.

Re: [PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions

Gaignard > CC: Michael Chan > CC: net...@vger.kernel.org > CC: linux-kernel@vger.kernel.org Acked-by: Michael Chan Thanks.

Re: [PATCH] net: ethernet: broadcom: bnxt: remove dead code

On Mon, May 15, 2017 at 3:28 PM, Gustavo A. R. Silva wrote: > Local variable _sh_ is assigned to a constant value and it is never updated > again. Remove this variable and the dead code it guards. > > Addresses-Coverity-ID: 1350916 > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH] net: ethernet: broadcom: bnxt: remove dead code

On Mon, May 15, 2017 at 3:28 PM, Gustavo A. R. Silva wrote: > Local variable _sh_ is assigned to a constant value and it is never updated > again. Remove this variable and the dead code it guards. > > Addresses-Coverity-ID: 1350916 > Signed-off-by: Gustavo A. R. Silva > --- >

Re: [PATCH 1/1] netdev: broadcom: propagate error code

> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188661 > > Signed-off-by: Pan Bian <bianpan2...@163.com> Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH 1/1] netdev: broadcom: propagate error code

rg/show_bug.cgi?id=188661 > > Signed-off-by: Pan Bian Acked-by: Michael Chan

Re: [PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage

void it look up > into the newly created io-page table at probe stage. > > Suggested-by: Michael Chan <michael.c...@broadcom.com> > Signed-off-by: Baoquan He <b...@redhat.com> Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH v2 2/2] bnx2: Wait for in-flight DMA to complete at probe stage

y created io-page table at probe stage. > > Suggested-by: Michael Chan > Signed-off-by: Baoquan He Acked-by: Michael Chan

Re: [PATCH 0/2] bnx2: Hard reset bnx2 chip at probe stage

On Fri, Nov 11, 2016 at 6:02 AM, Baoquan He wrote: > On 11/11/16 at 09:46pm, Baoquan He wrote: >> Hi bnx2 experts, >> >> In commit 3e1be7a ("bnx2: Reset device during driver initialization"), >> firmware requesting code was moved from open stage to probe stage. >> The reason is

Re: [PATCH 0/2] bnx2: Hard reset bnx2 chip at probe stage

On Fri, Nov 11, 2016 at 6:02 AM, Baoquan He wrote: > On 11/11/16 at 09:46pm, Baoquan He wrote: >> Hi bnx2 experts, >> >> In commit 3e1be7a ("bnx2: Reset device during driver initialization"), >> firmware requesting code was moved from open stage to probe stage. >> The reason is in kdump kernel

Re: [PATCH] net: tg3: use new api ethtool_{get|set}_link_ksettings

On Sun, Sep 25, 2016 at 2:31 PM, Philippe Reynes <trem...@gmail.com> wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes <trem...@gmail.com> Looks good to me. Thanks

Re: [PATCH] net: tg3: use new api ethtool_{get|set}_link_ksettings

On Sun, Sep 25, 2016 at 2:31 PM, Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Looks good to me. Thanks. Acked-by: Michael Chan

Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state

STATE_CLOSING or 0. > > Reported-by: coverity (CID 1339583) > Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.") > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Thanks Florian. Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state

orted-by: coverity (CID 1339583) > Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.") > Signed-off-by: Florian Fainelli Thanks Florian. Acked-by: Michael Chan

Re: [PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable()

On Fri, Jul 15, 2016 at 11:20 PM, David Miller wrote: > From: Florian Fainelli > Date: Fri, 15 Jul 2016 16:42:01 -0700 > >> @@ -4599,7 +4599,9 @@ static void bnxt_tx_enable(struct bnxt *bp) >> for (i = 0; i < bp->tx_nr_rings; i++) { >>

Re: [PATCH net] bnxt_en: Fix potential race condition in bnxt_tx_enable()

On Fri, Jul 15, 2016 at 11:20 PM, David Miller wrote: > From: Florian Fainelli > Date: Fri, 15 Jul 2016 16:42:01 -0700 > >> @@ -4599,7 +4599,9 @@ static void bnxt_tx_enable(struct bnxt *bp) >> for (i = 0; i < bp->tx_nr_rings; i++) { >> txr = >tx_ring[i]; >> txq

Re: [PATCH] bnxt_en: initialize rc to zero to avoid returning garbage

returned by initializing rc to 0. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks. Acked-by: Michael Chan <michael.c...@broadcom.com>

Re: [PATCH] bnxt_en: initialize rc to zero to avoid returning garbage

lin Ian King Thanks. Acked-by: Michael Chan

Re: [PATCH] bnxt_en: add VXLAN dependency

fined reference to > `vxlan_get_rx_port' > > This adds a Kconfig dependency that ensures that either VXLAN is > disabled (which the driver handles correctly), or we depend on > VXLAN itself and disallow built-in compilation when VXLAN is > a module. > > Signed-off-by: Arnd Be

Re: [PATCH] bnxt_en: add VXLAN dependency

Bergmann <a...@arndb.de> Thanks. Acked-by: Michael Chan <mc...@broadcom.com> > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") > > diff --git a/drivers/net/ethernet/broadcom/Kconfig > b/drivers/net/ethernet/broadcom/Kconfig > index 67a7d520d9f

Re: [PATCH] tg3:Add error handling to the function tg3_test_loopback

On Thu, 2015-07-16 at 12:18 -0700, Michael Chan wrote: > On Thu, 2015-07-16 at 14:51 -0400, Nicholas Krause wrote: > > This adds proper error handling for if the calls to the function > > tg3_phy_lpbk_set fail by returning -EIO by assigning the return > > valu

Re: [PATCH] tg3:Add error handling to the function tg3_test_loopback

o label done as no other work can be handled > internally in the function tg3_test_loopback. > > Signed-off-by: Nicholas Krause Acked-by: Michael Chan > --- > drivers/net/ethernet/broadcom/tg3.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff -

Re: [PATCH] tg3:Add error handling to the function tg3_test_loopback

On Thu, 2015-07-16 at 12:18 -0700, Michael Chan wrote: On Thu, 2015-07-16 at 14:51 -0400, Nicholas Krause wrote: This adds proper error handling for if the calls to the function tg3_phy_lpbk_set fail by returning -EIO by assigning the return value to the variable err and if it equals

Re: [PATCH] tg3:Add error handling to the function tg3_test_loopback

as no other work can be handled internally in the function tg3_test_loopback. Signed-off-by: Nicholas Krause xerofo...@gmail.com Acked-by: Michael Chan mc...@broadcom.com --- drivers/net/ethernet/broadcom/tg3.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

Re: [3.19-rc3] tg3: BUG: sleeping function called from invalid context

On Tue, 2015-01-13 at 07:47 -0500, Peter Hurley wrote: > > tp->lock is held in this code path. If synchronize_irq() sleeps in > > wait_event(desc->wait_for_threads, ...), we'll get the warning. > > > > The synchronize_irq() call is to wait for any tg3 irq handler to finish > > so that it is

Re: [3.19-rc3] tg3: BUG: sleeping function called from invalid context

On Tue, 2015-01-13 at 07:47 -0500, Peter Hurley wrote: tp-lock is held in this code path. If synchronize_irq() sleeps in wait_event(desc-wait_for_threads, ...), we'll get the warning. The synchronize_irq() call is to wait for any tg3 irq handler to finish so that it is guaranteed that

Re: [3.19-rc3] tg3: BUG: sleeping function called from invalid context

On Mon, 2015-01-12 at 19:59 -0500, Peter Hurley wrote: > [ 17.203009] BUG: sleeping function called from invalid context at > /home/peter/src/kernels/mainline/kernel/irq/manage.c:104 > [ 17.203067] in_atomic(): 1, irqs_disabled(): 0, pid: 1106, name: ip > [ 17.203092] 2 locks held by

Re: [3.19-rc3] tg3: BUG: sleeping function called from invalid context

On Mon, 2015-01-12 at 19:59 -0500, Peter Hurley wrote: [ 17.203009] BUG: sleeping function called from invalid context at /home/peter/src/kernels/mainline/kernel/irq/manage.c:104 [ 17.203067] in_atomic(): 1, irqs_disabled(): 0, pid: 1106, name: ip [ 17.203092] 2 locks held by ip/1106:

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

On Tue, 2014-09-09 at 23:16 +, Anish Bhatt wrote: > > It would be really good if SCSI_NETLINK depended on NET instead of selected > > NET. > > We shouldn't have kconfig symbols that use 'select' on entire subsystems. > > As a test, I was able to fix this by this approach : change

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

On Tue, 2014-09-09 at 20:24 +, Anish Bhatt wrote: > This is caused by c99d667e8527 ("cnic : Cleanup CONFIG_IPV6 & VLAN check") > > So I'm not really sure what the fix for this is. CNIC will properly only > support > [m] or [n] when IPV6 is compiled as a module, but if you set

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

On Tue, 2014-09-09 at 20:24 +, Anish Bhatt wrote: This is caused by c99d667e8527 (cnic : Cleanup CONFIG_IPV6 VLAN check) So I'm not really sure what the fix for this is. CNIC will properly only support [m] or [n] when IPV6 is compiled as a module, but if you set SCSI_BNX2X_FCOE or

RE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c

On Tue, 2014-09-09 at 23:16 +, Anish Bhatt wrote: It would be really good if SCSI_NETLINK depended on NET instead of selected NET. We shouldn't have kconfig symbols that use 'select' on entire subsystems. As a test, I was able to fix this by this approach : change SCSI_NETLINK to

Re: [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold

On Thu, 2014-08-21 at 16:06 -0700, Benjamin Poirier wrote: > On 2014/08/21 15:32, Michael Chan wrote: > > On Thu, 2014-08-21 at 15:04 -0700, Benjamin Poirier wrote: > > > On 2014/08/19 15:00, Michael Chan wrote: > > > > On Tue, 2014-08-19 at 11:52 -0700, Benjamin

Re: [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold

On Thu, 2014-08-21 at 15:04 -0700, Benjamin Poirier wrote: > On 2014/08/19 15:00, Michael Chan wrote: > > On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: > > > diff --git a/drivers/net/ethernet/broadcom/tg3.c > > > b/drivers/net/ethernet/broadcom/tg3.c &

Re: [PATCH 2/3] tg3: Fix tx_pending checks for tg3_tso_bug

On Wed, 2014-08-20 at 18:23 -0700, Benjamin Poirier wrote: > On 2014/08/19 16:10, Michael Chan wrote: > > On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: > > > @@ -7838,11 +7838,14 @@ static int tg3_tso_bug(struct tg3 *tp, struct >

Re: [PATCH 2/3] tg3: Fix tx_pending checks for tg3_tso_bug

On Wed, 2014-08-20 at 18:23 -0700, Benjamin Poirier wrote: On 2014/08/19 16:10, Michael Chan wrote: On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: @@ -7838,11 +7838,14 @@ static int tg3_tso_bug(struct tg3 *tp, struct tg3_napi *tnapi, struct

Re: [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold

On Thu, 2014-08-21 at 15:04 -0700, Benjamin Poirier wrote: On 2014/08/19 15:00, Michael Chan wrote: On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 3ac5d23..b11c0fd 100644

Re: [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold

On Thu, 2014-08-21 at 16:06 -0700, Benjamin Poirier wrote: On 2014/08/21 15:32, Michael Chan wrote: On Thu, 2014-08-21 at 15:04 -0700, Benjamin Poirier wrote: On 2014/08/19 15:00, Michael Chan wrote: On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: diff --git a/drivers

Re: [PATCH 2/3] tg3: Fix tx_pending checks for tg3_tso_bug

On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: > @@ -7838,11 +7838,14 @@ static int tg3_tso_bug(struct tg3 *tp, struct > tg3_napi *tnapi, >struct netdev_queue *txq, struct sk_buff *skb) > { > struct sk_buff *segs, *nskb; > - u32 frag_cnt_est =

Re: [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold

On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote: > diff --git a/drivers/net/ethernet/broadcom/tg3.c > b/drivers/net/ethernet/broadcom/tg3.c > index 3ac5d23..b11c0fd 100644 > --- a/drivers/net/ethernet/broadcom/tg3.c > +++ b/drivers/net/ethernet/broadcom/tg3.c > @@ -202,7 +202,8 @@

  1   2   3   >