On Thu, Mar 15, 2018 at 11:46 PM, Kees Cook wrote:
> On Thu, Mar 15, 2018 at 3:23 PM, Linus Torvalds
> wrote:
>> On Thu, Mar 15, 2018 at 3:16 PM, Kees Cook wrote:
>>>
>>> size_t __error_not_const_arg(void) \
>>> __compiletime_error("const_max() used with non-compile-time constant arg");
>>> #def
On Wed, Mar 14, 2018 at 5:56 PM, Linus Torvalds
wrote:
> On Tue, Mar 13, 2018 at 11:46 AM, Miguel Ojeda
> wrote:
>>
>> This is my first pull request, so if there is anything wrong, please let
>> me know!
>
> The commits in there looks fine, but I have to admit to no
On Sun, Mar 11, 2018 at 12:12 AM, Kees Cook wrote:
>
> The problem is that it's not a "constant expression", so the compiler
> frontend still yells about it under -Wvla. I would characterize this
> mainly as a fix for "accidental VLA" or "misdetected VLA" or something
> like that. AIUI, there real
On Wed, Mar 14, 2018 at 1:18 AM, Miguel Ojeda
wrote:
>
> Since we seem to agree on having this, I will send a v2 after I try a
> few experiments to try to reduce more the produced diffs, explain
> things better in Documentation/, add more comments in the config file
> and send
On Tue, Mar 13, 2018 at 11:29 PM, Joe Perches wrote:
> On Tue, 2018-03-13 at 22:52 +0100, Miguel Ojeda wrote:
>> On Tue, Mar 13, 2018 at 10:00 PM, Andrew Morton
>> wrote:
>> > On Tue, 13 Mar 2018 00:39:52 +0100 Miguel Ojeda
>> > wrote:
>> >
On Tue, Mar 13, 2018 at 10:00 PM, Andrew Morton
wrote:
> On Tue, 13 Mar 2018 00:39:52 +0100 Miguel Ojeda
> wrote:
>
>> --- a/Documentation/process/4.Coding.rst
>> +++ b/Documentation/process/4.Coding.rst
>> @@ -58,6 +58,12 @@ can never be transgressed. If there
used GitHub
as well for the same reason.
Cheers,
Miguel Ojeda
The following changes since commit 0c8efd610b58cb23cefdfa12015799079aef94ae:
Linux 4.16-rc5 (2018-03-11 17:25:09 -0700)
are available in the git repository at:
https://github.com/ojeda/linux.git tags/auxdisplay-for-linus-v4.16
On Tue, Mar 13, 2018 at 4:41 PM, Martin Sebor wrote:
> Martin Sebor also asked me about this, he's the one that worked on
> the gcc code that introduced the warning. Sorry for not replying
> earlier.
>
Maybe you can pass this to him? (maybe open a bug in gcc's bugzilla?)
t;>> wrote:
>>> > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
>>> > wrote:
>>> > > Cc: Willy Tarreau
>>> > > Cc: Geert Uytterhoeven
>>> > > Cc: Linus Walleij
>>> > > Cc: Robin van der Gracht
>>> > > Cc: Paul Burton
>>> > > Signed-off-by: Miguel Ojeda
>>> > > ---
Pinging Paul Burton in a couple of emails more...
Cheers,
Miguel
Commit 7005b58458e4beecaf5efacb872c456bc7d3541a ("Staging: add lcd-panel
driver") introduced the panel driver, which is now in
drivers/auxdisplay.
Cc: Willy Tarreau
Cc: Jonathan Corbet
Signed-off-by: Miguel Ojeda
---
Documentation/{misc-devices => auxdisplay}/lcd-panel-cgram.tx
Walleij
Cc: Randy Dunlap
Signed-off-by: Miguel Ojeda
---
drivers/auxdisplay/arm-charlcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c
index b3176ee92b90..dde180995582 100644
--- a/drivers/auxdisplay/arm-charlcd.c
+++ b
ngFormat.html
https://clang.llvm.org/docs/ClangFormatStyleOptions.html
Cc: Randy Dunlap
Cc: Andy Whitcroft
Cc: Joe Perches
Cc: Jonathan Corbet
Cc: Andrew Morton
Signed-off-by: Miguel Ojeda
---
.clang-format | 107
On Sat, Mar 10, 2018 at 6:51 PM, Linus Torvalds
wrote:
>
> So in *historical* context - when a compiler didn't do variable length
> arrays at all - the original semantics of C "constant expressions"
> actually make a ton of sense.
>
> You can basically think of a constant expression as something t
On Sat, Mar 10, 2018 at 5:30 PM, Linus Torvalds
wrote:
> On Sat, Mar 10, 2018 at 7:33 AM, Kees Cook wrote:
>>
>> Alright, I'm giving up on fixing max(). I'll go back to STACK_MAX() or
>> some other name for the simple macro. Bleh.
>
> Oh, and I'm starting to see the real problem.
>
> It's not tha
On Sat, Mar 10, 2018 at 7:10 AM, Miguel Ojeda
wrote:
> On Sat, Mar 10, 2018 at 4:11 AM, Randy Dunlap wrote:
>> On 03/09/2018 04:07 PM, Andrew Morton wrote:
>>> On Fri, 9 Mar 2018 12:05:36 -0800 Kees Cook wrote:
>>>
>>>> When max() is used in stack arra
On Sat, Mar 10, 2018 at 4:11 AM, Randy Dunlap wrote:
> On 03/09/2018 04:07 PM, Andrew Morton wrote:
>> On Fri, 9 Mar 2018 12:05:36 -0800 Kees Cook wrote:
>>
>>> When max() is used in stack array size calculations from literal values
>>> (e.g. "char foo[max(sizeof(struct1), sizeof(struct2))]", the
On Thu, Mar 8, 2018 at 5:22 AM, Prakhya, Sai Praneeth
wrote:
>> > +struct workqueue_struct *efi_rts_wq;
>> > +
>> > static bool disable_runtime;
>> > static int __init setup_noefi(char *arg) { @@ -329,6 +331,19 @@
>> > static int __init efisubsys_init(void)
>> > return 0;
>> >
>
On Mon, Mar 5, 2018 at 8:05 PM, Martin Sebor wrote:
> On 03/02/2018 10:36 AM, Miguel Ojeda wrote:
>>
>> On Thu, Mar 1, 2018 at 10:57 AM, Arnd Bergmann wrote:
>>>
>>> On Mon, Feb 19, 2018 at 1:01 AM, Miguel Ojeda
>>> wrote:
>>>>
>>>
On Tue, Mar 6, 2018 at 12:23 AM, Sai Praneeth Prakhya
wrote:
> From: Sai Praneeth
>
> When a process requests the kernel to execute any efi_runtime_service(),
> the requested efi_runtime_service (represented as an identifier) and its
> arguments are packed into a struct named efi_runtime_work and
On Thu, Mar 1, 2018 at 10:57 AM, Arnd Bergmann wrote:
> On Mon, Feb 19, 2018 at 1:01 AM, Miguel Ojeda
> wrote:
>> On Mon, Feb 19, 2018 at 12:20 AM, David Rientjes wrote:
>>> On Sat, 17 Feb 2018, Miguel Ojeda wrote:
>>>
>>>> From the GCC manual:
ers menu in
> nconfig and menuconfig by moving the PANEL drivers to a sub-menu.
>
> Signed-off-by: Randy Dunlap
> Cc: Miguel Ojeda Sandonis
> Acked-by: Geert Uytterhoeven
> Reviewed-by: Andy Shevchenko
Picking it up.
Cheers,
Miguel
> ---
> drivers/auxdisplay/Kconf
24e ("auxdisplay: charlcd: Extract character LCD core from
>> misc/panel")
>>
>> Cc: sta...@vger.kernel.org # v4.12
>> Cc: Geert Uytterhoeven
>> Cc: Andy Shevchenko
>
> Reviewed-by: Andy Shevchenko
>
>> Cc: Miguel Ojeda Sandonis
>> Sig
On Wed, Feb 28, 2018 at 12:23 AM, Robert Abel wrote:
> On 27 Feb 2018 23:09, Miguel Ojeda wrote:> @@ -469,24 +543,11 @@ static
> inline int handle_lcd_special_code(struct charlcd *lcd)
>> }
>> case 'x': /* gotoxy : LxXXX[yYYY]; */
>> c
Uytterhoeven
Cc: Andy Shevchenko
Cc: Robert Abel
Signed-off-by: Miguel Ojeda
---
Disregard v2, this is much more clear. I am too tired :)
This one and v2 are the loop versions, v1 is the kstrto*() version.
I also added some more comments on top of the v2.
drivers/auxdisplay/charlcd.c | 95
Uytterhoeven
Cc: Andy Shevchenko
Cc: Robert Abel
Signed-off-by: Miguel Ojeda
---
drivers/auxdisplay/charlcd.c | 101 +++
1 file changed, 83 insertions(+), 18 deletions(-)
diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c
index
On Tue, Feb 27, 2018 at 9:52 PM, Andy Shevchenko
wrote:
> On Tue, Feb 27, 2018 at 9:32 PM, Miguel Ojeda
> wrote:
>> The current version is not parsing multiple x/y commands as the code
>> originally intended. On top of that, kstrtoul() expects
>> NULL-terminated strings.
On Tue, Feb 27, 2018 at 9:13 PM, Willy Tarreau wrote:
> On Tue, Feb 27, 2018 at 08:32:21PM +0100, Miguel Ojeda wrote:
>> The current version is not parsing multiple x/y commands as the code
>> originally intended. On top of that, kstrtoul() expects
>> NULL-terminated strin
.
Cc: Willy Tarreau
Cc: Geert Uytterhoeven
Cc: Andy Shevchenko
Cc: Robert Abel
Signed-off-by: Miguel Ojeda
---
Only the parsing functions are tested, please try on real HW.
drivers/auxdisplay/charlcd.c | 97
1 file changed, 79 insertions(+), 18
On Tue, Feb 27, 2018 at 6:19 AM, Willy Tarreau wrote:
> On Mon, Feb 26, 2018 at 11:43:36PM +0100, Robert Abel wrote:
>> On 26 Feb 2018 17:49, Miguel Ojeda wrote:
>> > On a general note, the code seems a bit convoluted for what it does,
>> > specially without the co
On Tue, Feb 27, 2018 at 12:40 PM, Andy Shevchenko
wrote:
> On Mon, 2018-02-26 at 23:31 +0100, Miguel Ojeda wrote:
>> On Mon, Feb 26, 2018 at 6:55 PM, Andy Shevchenko
>> wrote:
>> > There were discussions in the past about use cases for
>> > simple_strto() func
On Mon, Feb 26, 2018 at 11:38 PM, Robert Abel wrote:
> Hi Andy, Hi Miguel,
>
> On 26 Feb 2018 12:44, Andy Shevchenko wrote:
>> Can we avoid yoda style of programming?
> On 26 Feb 2018 17:49, Miguel Ojeda wrote:
>> Please do not change the style of the code w.r.t to the re
On Mon, Feb 26, 2018 at 6:55 PM, Andy Shevchenko
wrote:
> There were discussions in the past about use cases for
> simple_strto() functions and in some rare cases they have a benefit
> on kstrto() ones.
>
> Update a comment to reduce confusing about special use cases.
>
>
On Mon, Feb 26, 2018 at 6:09 PM, Andy Shevchenko
wrote:
> On Mon, Feb 26, 2018 at 6:54 PM, Miguel Ojeda
> wrote:
>> On Mon, Feb 26, 2018 at 12:44 PM, Andy Shevchenko
>> wrote:
>>> On Mon, Feb 26, 2018 at 1:54 AM, Robert Abel wrote:
>
>>>&
On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote:
> A user has no way of unshifting the display programmatically once shifted.
> Users cannot rely on ^[[H (home) to result in their message being seen either.
> Use the actual HOME command 0x02 instead of only returning to x0/y0.
> Users can stil
On Mon, Feb 26, 2018 at 5:49 PM, Miguel Ojeda
wrote:
> On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote:
>> NUL-terminate each individual number to be parsed.
>> To do this, the next command character and a pointer to its argument
>> are found and stored. The comm
On Mon, Feb 26, 2018 at 12:44 PM, Andy Shevchenko
wrote:
> On Mon, Feb 26, 2018 at 1:54 AM, Robert Abel wrote:
>> NUL-terminate each individual number to be parsed.
>> To do this, the next command character and a pointer to its argument
>> are found and stored. The command character is then overw
On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote:
> NUL-terminate each individual number to be parsed.
> To do this, the next command character and a pointer to its argument
> are found and stored. The command character is then overwritten by NUL
> before kstr* functions are called on the buffe
On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote:
> Signed-off-by: Robert Abel
> ---
> drivers/auxdisplay/charlcd.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c
> index e3b2fd15c5a3..a3d364e6c
On Mon, Feb 26, 2018 at 9:34 AM, Geert Uytterhoeven
wrote:
> On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote:
>> Signed-off-by: Robert Abel
>
> Reviewed-by: Geert Uytterhoeven
Good catch Robert! Picking it up for 4.17.
Cheers,
Miguel
>
> Gr{oetje,eeting}s,
>
> Gee
On Sun, Feb 25, 2018 at 7:13 PM, Randy Dunlap wrote:
> On 02/25/2018 04:46 AM, Miguel Ojeda wrote:
>> There was a missing first line and a missing member,
>> which gave a warning under W=1:
>>
>> CC drivers/auxdisplay/arm-charlcd.o
>> drivers/aux
Walleij
Signed-off-by: Miguel Ojeda
---
Please let me know if anyone does not want this in 4.17.
drivers/auxdisplay/arm-charlcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c
index b3176ee92b90..27cf08a05e93 100644
On Sun, Feb 25, 2018 at 1:25 PM, Miguel Ojeda
wrote:
> On Sat, Feb 24, 2018 at 4:08 PM, Daniel Axtens wrote:
>> Miguel Ojeda writes:
>>
>>> Hi Daniel,
>>>
>>> On Sun, Nov 26, 2017 at 3:53 AM, Daniel Axtens wrote:
>>>> This
On Sat, Feb 24, 2018 at 4:08 PM, Daniel Axtens wrote:
> Miguel Ojeda writes:
>
>> Hi Daniel,
>>
>> On Sun, Nov 26, 2017 at 3:53 AM, Daniel Axtens wrote:
>>> This matches the header at the top of the file and squashes:
>>>
>>> WARNING: modpost:
On Sat, Feb 24, 2018 at 11:10 PM, Sai Praneeth Prakhya
wrote:
> From: Sai Praneeth
>
> When a process requests the kernel to execute any efi_runtime_service(),
> the requested efi_runtime_service (represented as an identifier) and its
> arguments are packed into a struct named efi_runtime_work an
On Wed, Jan 17, 2018 at 6:59 PM, Enric Balletbo i Serra
wrote:
> From: Sameer Nanda
>
> This driver gets various bits of information about what is connected to
> USB PD ports from the EC and converts that into power_supply properties.
>
> Signed-off-by: Sameer Nanda
> Signed-off-by: Enric Ballet
On Thu, Feb 22, 2018 at 2:29 AM, Jae Hyun Yoo
wrote:
> On 2/21/2018 4:37 PM, Andrew Lunn wrote:
>>>
>>> But even with this change, it still needs to use delayed creation
>>> because BMC side kernel doesn't know how many DIMMs are populated on
>>> a remote server before the remote server completes
On Wed, Feb 21, 2018 at 5:56 AM, Asutosh Das wrote:
> From: Vijay Viswanath
>
> UFS driver can receive a request during memory reclaim by kswapd.
> So when ufs driver puts the ungate work in queue, and if there are no
> idle workers, kthreadd is invoked to create a new kworker. Since
> kswapd tas
Hi Gustavo,
On Sat, Jul 8, 2017 at 2:56 AM, Gustavo A. R. Silva
wrote:
> These structures are only used to copy into other structures,
> so declare them as const.
>
> This issue was detected using Coccinelle and the following semantic patch:
>
> @r disable optional_qualifier@
> identifier i;
> po
Hi Gustavo,
On Thu, Oct 12, 2017 at 11:35 PM, Gustavo A. R. Silva
wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> In this particular case, notice that I replaced the "no break here,
> fall through" comments with "fall thr
Hi Daniel,
On Sun, Nov 26, 2017 at 3:53 AM, Daniel Axtens wrote:
> This matches the header at the top of the file and squashes:
>
> WARNING: modpost: missing MODULE_LICENSE() in
> drivers/auxdisplay/img-ascii-lcd.o
> see include/linux/module.h for more information
>
> Signed-off-by: Daniel Axten
Hi Shannon,
On Wed, Jan 31, 2018 at 10:31 AM, Shannon Booth
wrote:
> This patch fixes the compilation warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in
> drivers/auxdisplay/img-ascii-lcd.o
>
> Signed-off-by: Shannon Booth
> ---
> drivers/auxdisplay/img-ascii-lcd.c | 2 ++
> 1 file cha
Hi Geert,
On Mon, Feb 19, 2018 at 7:40 PM, Geert Uytterhoeven
wrote:
> Hi Miguel,
>
> On Mon, Feb 19, 2018 at 5:09 PM, Miguel Ojeda
> wrote:
>> The warnings are:
>>
>> drivers/auxdisplay/img-ascii-lcd.c: warning: 'err' may be used
>> uninitializ
to disappear starting with gcc >= 4.9
Cc: Geert Uytterhoeven
Cc: Paul Burton
Signed-off-by: Miguel Ojeda
---
I will queue it up for 4.17.
drivers/auxdisplay/img-ascii-lcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/auxdisplay/img-ascii-lcd.c
b/driver
'arg' description in 'img_ascii_lcd_scroll'
Cc: Paul Burton
Signed-off-by: Miguel Ojeda
---
I saw this while fixing the ones reported by the build service.
I will queue it up for 4.17.
drivers/auxdisplay/img-ascii-lcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
Compiling with W=1 with gcc 7.2.0 gives 3 warnings like:
drivers/auxdisplay/panel.c: In function ‘panel_process_inputs’:
drivers/auxdisplay/panel.c:1374:17: warning: this statement may fall
through [-Wimplicit-fallthrough=]
Cc: Willy Tarreau
Cc: Geert Uytterhoeven
Signed-off-by: Miguel
On Mon, Feb 19, 2018 at 12:20 AM, David Rientjes wrote:
> On Sat, 17 Feb 2018, Miguel Ojeda wrote:
>
>> From the GCC manual:
>>
>> The nonstring variable attribute specifies that an object or member
>> declaration with type array of char or pointer to char is intende
On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne
wrote:
> Miguel,
>
> On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
> wrote:
>> Cc: Willy Tarreau
>> Cc: Geert Uytterhoeven
>> Cc: Linus Walleij
>> Cc: Robin van der Gracht
>> Cc: P
Cc: Willy Tarreau
Cc: Geert Uytterhoeven
Cc: Linus Walleij
Cc: Robin van der Gracht
Cc: Paul Burton
Signed-off-by: Miguel Ojeda
---
Please let me know if you agree for your files and I will queue it up.
Thanks!
drivers/auxdisplay/arm-charlcd.c| 2 +-
drivers/auxdisplay
to the LKML regarding these
warnings. When they are false positives, we can use __nonstring to let
gcc know a NUL character is not required; like in this case:
https://lkml.org/lkml/2018/1/16/135
Signed-off-by: Miguel Ojeda
Cc: Ingo Molnar
Cc: Josh Poimboeuf
Cc: Kees Cook
Cc: Andrew Morton
On Mon, Feb 12, 2018 at 6:11 PM, Willy Tarreau wrote:
> On Mon, Feb 12, 2018 at 01:53:57PM +0100, Miguel Ojeda wrote:
>> > diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
>> > index ea7869c..d288900 100644
>> > --- a/drivers/auxdisplay/panel.c
On Sat, Feb 10, 2018 at 10:41 AM, Miguel Ojeda
wrote:
> On Sat, Feb 10, 2018 at 10:20 AM, Willy Tarreau wrote:
>> Hi Miguel,
>>
>> On Sat, Feb 10, 2018 at 09:58:44AM +0100, Miguel Ojeda wrote:
>>> On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel wrote:
>>
On Thu, Feb 8, 2018 at 4:58 PM, Miguel Ojeda
wrote:
> On Thu, Jan 18, 2018 at 9:13 PM, Corentin Labbe
> wrote:
>> img-ascii-lcd select un-existing SYSCON kconfig name.
>> This patch fix this error by using the correct MFD_SYSCON kconfig name.
>>
>
> CC'ing P
On Sun, Feb 11, 2018 at 5:40 PM, Miguel Ojeda
wrote:
> On Sat, Feb 10, 2018 at 3:14 PM, Ulf Magnusson wrote:
>> Commit 3f5f0a4475e1 ("MIPS: generic: Convert SEAD-3 to a generic board")
>> removed the MIPS_SEAD3 symbol and moved the setting of IMG_ASCII_LCD to
>> th
On Mon, Jan 29, 2018 at 7:50 AM, Willy Tarreau wrote:
> Hi,
>
> On Fri, Jan 26, 2018 at 11:19:15PM +0800, Jia-Ju Bai wrote:
>> The function long_sleep() calls mdelay() when in an interrupt handler.
>> But only charlcd_clear_display() and charlcd_init_display calls
>> long_sleep(), and my tool find
On Tue, Jan 16, 2018 at 10:38 AM, Xiongfeng Wang
wrote:
> From: Xiongfeng Wang
>
> gcc-8 reports
>
> drivers/auxdisplay/panel.c: In function 'panel_attach':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 12 equals destination size [-Wstringop-truncation]
>
> We n
On Mon, Jan 29, 2018 at 7:50 AM, Willy Tarreau wrote:
> Hi,
>
> On Fri, Jan 26, 2018 at 11:19:15PM +0800, Jia-Ju Bai wrote:
>> The function long_sleep() calls mdelay() when in an interrupt handler.
>> But only charlcd_clear_display() and charlcd_init_display calls
>> long_sleep(), and my tool find
was referenced in the commit message.
>
> - Mention that IMG_ASCII_LCD is now set via the board-sead-3.config defconfig
>file.
>
> - Clarify that Kconfig is involved. The previous commit title was
>"auxdisplay: img-ascii-lcd: Remove MIPS_SEAD3 reference".
>
T
On Sat, Feb 10, 2018 at 10:31 PM, Joe Perches wrote:
> On Sat, 2018-02-10 at 09:32 -0800, Randy Dunlap wrote:
>> On 02/10/2018 01:56 AM, Miguel Ojeda wrote:
>> > Cc: Randy Dunlap
>> > Signed-off-by: Miguel Ojeda
>>
>> Acked-by: Randy Dunlap
>>
&
Cc: Randy Dunlap
Signed-off-by: Miguel Ojeda
---
MAINTAINERS | 8
1 file changed, 8 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e6c26cb47d02..01e302f7967e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2484,8 +2484,6 @@ F:kernel/audit*
AUXILIARY DISPLAY
wouldn't bother with this kind of change, but since the
other switch cases all use escape sequences, this improves
consistency, so agreed.
Trivial. Compile-tested.
Signed-off-by: Miguel Ojeda
> /* quickly clear the display */
> charlcd_clear_fast(lcd);
> break;
> --
> 2.11.0
>
On Sat, Feb 10, 2018 at 10:20 AM, Willy Tarreau wrote:
> Hi Miguel,
>
> On Sat, Feb 10, 2018 at 09:58:44AM +0100, Miguel Ojeda wrote:
>> On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel wrote:
>> > The graphics command expects 16 hexadecimal literals, but would allow
>&g
write_char(struct charlcd *lcd, char
> c)
> case LCD_ESCAPE_CHAR:
> /* start of an escape sequence */
> priv->esc_seq.len = 0;
> - priv->esc_seq.buf[priv->esc_seq.len] = 0;
> +
On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel wrote:
> The graphics command expects 16 hexadecimal literals, but would allow
> characters in range [0-9a-zA-Z] instead of [0-9a-fA-F].
>
> Signed-off-by: Robert Abel
> ---
> drivers/auxdisplay/charlcd.c | 4 ++--
> 1 file changed, 2 insertions(+),
he addition of the driver
in 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple ASCII
LCD displays").
Acked-by: Miguel Ojeda
Thanks,
Miguel
> Signed-off-by: Corentin Labbe
> ---
> drivers/auxdisplay/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletio
On Mon, Feb 5, 2018 at 2:21 AM, Ulf Magnusson wrote:
> The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove SEAD-3
> driver").
Commit 64601cb1343f did not remove the MIPS_SEAD3 symbol, it seemed to
a few months before, in 3f5f0a4475e1 ("MIPS: generic: Convert SEAD-3
to a generi
Hi Adrian,
Please review the style to match the kernel's (and the rest of the
code in the file). See an example below and
https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst
(I have no idea regarding the functional changes on this patch, I just
noticed the email c
On Jan 30, 2008 6:48 AM, Dave Young <[EMAIL PROTECTED]> wrote:
>
> On Jan 25, 2008 9:27 AM, Dave Young <[EMAIL PROTECTED]> wrote:
> >
> > On Jan 25, 2008 12:32 AM, Miguel Ojeda <[EMAIL PROTECTED]> wrote:
> > >
> > > On Jan 24, 2008 2:44 AM, Da
s SCSI scanning" is
enabled.
Should not be -at least- a way to disable it?
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at ht
On Jan 24, 2008 2:44 AM, Dave Young <[EMAIL PROTECTED]> wrote:
>
> On Wed, Jan 23, 2008 at 02:06:43PM -0800, Andrew Morton wrote:
> > > On Mon, 21 Jan 2008 18:53:18 +0100 "Miguel Ojeda" <[EMAIL PROTECTED]>
> > > wrote:
> > > Booting 2.
On 10/6/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> On Sat, 6 Oct 2007 01:01:10 +0200
> "Miguel Ojeda" <[EMAIL PROTECTED]> wrote:
>
> > On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote:
> > > On Friday 05 October 2007 2:01:08 am Miguel Oj
On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote:
> On Friday 05 October 2007 2:01:08 am Miguel Ojeda wrote:
> >
> > I think we all are trying to give ideas to improve the current logging API.
> >
> > If something works, it's great; but it doesn'
d about what people are trying to accomplish here...
>
I think we all are trying to give ideas to improve the current logging API.
If something works, it's great; but it doesn't mean that it can't be
improved, right?
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
On 9/28/07, Vegard Nossum <[EMAIL PROTECTED]> wrote:
> On 9/28/07, Miguel Ojeda <[EMAIL PROTECTED]> wrote:
> > On 9/28/07, Vegard Nossum <[EMAIL PROTECTED]> wrote:
> > > reason we can't use KBUILD_MODNAME is that this is defined on the
> > > com
, it is possible that the original KPRINT_DRIVER
> symbol can cause an "unused variable"-warning. I guess this is fixable
> with the gcc "unused" variable attribute.
Yep, then, in a year or two, we will be able to delete such attribute.
Will there be a team to change ma
st got blank, it means you didn't add a
necessary module for your computer. Your best bet is to read "Linux
Kernel in a Nutshell", by Greg KH: http://www.kroah.com/lkn/
Specially, Chapter 7: Customizing a Kernel.
Then, if your screen still gets black and you think it is
On 9/25/07, Vegard Nossum <[EMAIL PROTECTED]> wrote:
> On 9/23/07, Miguel Ojeda <[EMAIL PROTECTED]> wrote:
> > Nice. I would suggest having some kind of standard way to show the
> > information on the screen/dmesg. I mean, instead of having plain lines
> >
from 1 choice
US6R usbcore: new interface driver hiddev
which I think its much more clear... Wanna know about registered
networking-related devices? Then grep using "^NT.R":
NT6R eth0: Broadcom 4400 10/100BaseT Ethernet 00:1f:a2:0c:4a:72
NT6R ieee80211_crypt: algorithm 'TKIP
or obsolete in 2.6 linux.
>
> And I have noticed even if I commented _syscall0 macro, I do not get
> any errors so no body is using it , then why _syscall0 is in kernel
> header files and what is the substitute of _syscall0.
Well, if you look at
http://lxr.linux.no/ident?i=_syscall0
it seem
MACK is useful for sensitivity, integrity, and a variety
+ of other madatory security schemes.
+ If you are unsure how to answer this question, answer N.
+
change:
+ of other madatory security schemes.
to:
+ of other mandatory security schemes.
--
On 8/17/07, Joe Perches <[EMAIL PROTECTED]> wrote:
> On Fri, 2007-08-17 at 06:37 +0200, Miguel Ojeda wrote:
> > On 8/16/07, Joe Perches <[EMAIL PROTECTED]> wrote:
> > > On Thu, 2007-08-16 at 11:16 +0200, Miguel Ojeda wrote:
> > > > I think you coul
On 8/16/07, Joe Perches <[EMAIL PROTECTED]> wrote:
> On Thu, 2007-08-16 at 11:16 +0200, Miguel Ojeda wrote:
> > I think you could add also:
> > +F: Documentation/auxdisplay/cfag12864bfb
>
> This is what I have now:
>
> CFAG12864BFB LCD FRAMEBUFFER DRIVER
&g
On 8/16/07, Joe Perches <[EMAIL PROTECTED]> wrote:
> On Thu, 2007-08-16 at 11:16 +0200, Miguel Ojeda wrote:
> > I think you could add also:
> > +F: Documentation/auxdisplay/cfag12864bfb
>
> This is what I have now:
>
> CFAG12864BFB LCD FRAMEBUFFER DRIVER
&g
>
Although for now drivers/auxdisplay/ only supports 2*ks0108-controlled
LCDs like cfag12864b or similar,
> +F: include/linux/cfag12864b.h
it is not really just about cfag12864b (although it could be OK to
point to some header file at all).
Thank you for the patch.
--
Miguel Ojeda
http:/
AINTAINERS
> @@ -1160,6 +1160,8 @@ M:[EMAIL PROTECTED]
> L: linux-kernel@vger.kernel.org
> W: http://auxdisplay.googlepages.com/
> S: Maintained
> +F: drivers/auxdisplay/cfag12864b.c
> +F: include/linux/cfag12864b.h
>
> CFAG12864BFB LCD FRAMEBUFFER DRIVER
> P: Johannes Berg
>
I think you could add also:
+F: Documentation/auxdisplay/cfag12864bfb
as you did at the ks0108 driver entry.
Thank you for the patch.
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this list: send the line "unsubscribe linux-ke
; LAPB module
> L: [EMAIL PROTECTED]
>
Thank you for the patch.
Signed-off-by: Miguel Ojeda <[EMAIL PROTECTED]>
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
ple.c
> + - cfag12864b LCD userspace example program.
> +ks0108
> + - documentation for the ks0108 LCD controller driver.
>
>
>
Thank you for the patch.
Signed-off-by: Miguel Ojeda <[EMAIL PROTECTED]>
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To uns
at way, the code could be patched, updated and cleaned over the time
(without firing up people), it could be tested without pain, people
would send more bug reports and every work would be centralized.
Reiser4 would get much more attention.
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
. It seems the problem is ACPI, however, should not
it be noted in some way? Maybe at Documentation/smp.txt, maybe at the
help section at CONFIG_SMP, maybe a "depends on ..."
Or maybe CONFIG_SMP should enable some bits of the ACPI code needed to
detect such additional cores.
--
Miguel Ojed
On 4/22/07, oliver pinter <[EMAIL PROTECTED]> wrote:
I have CC the kernel
Did you?
and the result is:
your'e config : failed smp
your'e config + power managment : ok
Interesting, can anyone tell me why does not SMP work without Power
Managment? Should it be that way?
601 - 700 of 734 matches
Mail list logo
