Re: [PATCH V2 2/3] efi: Introduce efi_rts_workqueue and some infrastructure to invoke all efi_runtime_services()

On Thu, Mar 8, 2018 at 5:22 AM, Prakhya, Sai Praneeth wrote: >> > +struct workqueue_struct *efi_rts_wq; >> > + >> > static bool disable_runtime; >> > static int __init setup_noefi(char *arg) { @@ -329,6 +331,19 @@ >> > static int __init efisubsys_init(void) >> > return 0; >> >

Re: [PATCH] Support the nonstring variable attribute (gcc >= 8)

On Mon, Mar 5, 2018 at 8:05 PM, Martin Sebor <mse...@gmail.com> wrote: > On 03/02/2018 10:36 AM, Miguel Ojeda wrote: >> >> On Thu, Mar 1, 2018 at 10:57 AM, Arnd Bergmann <a...@arndb.de> wrote: >>> >>> On Mon, Feb 19, 2018 at 1:01 AM, Miguel Ojed

Re: [PATCH] Support the nonstring variable attribute (gcc >= 8)

On Mon, Mar 5, 2018 at 8:05 PM, Martin Sebor wrote: > On 03/02/2018 10:36 AM, Miguel Ojeda wrote: >> >> On Thu, Mar 1, 2018 at 10:57 AM, Arnd Bergmann wrote: >>> >>> On Mon, Feb 19, 2018 at 1:01 AM, Miguel Ojeda >>> wrote: >>>> >>>

Re: [PATCH V2 2/3] efi: Introduce efi_rts_workqueue and some infrastructure to invoke all efi_runtime_services()

On Tue, Mar 6, 2018 at 12:23 AM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > When a process requests the kernel to execute any efi_runtime_service(), > the requested efi_runtime_service (represented as an identifier) and

Re: [PATCH V2 2/3] efi: Introduce efi_rts_workqueue and some infrastructure to invoke all efi_runtime_services()

On Tue, Mar 6, 2018 at 12:23 AM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > When a process requests the kernel to execute any efi_runtime_service(), > the requested efi_runtime_service (represented as an identifier) and its > arguments are packed into a struct named efi_runtime_work

Re: [PATCH] Support the nonstring variable attribute (gcc >= 8)

On Thu, Mar 1, 2018 at 10:57 AM, Arnd Bergmann <a...@arndb.de> wrote: > On Mon, Feb 19, 2018 at 1:01 AM, Miguel Ojeda > <miguel.ojeda.sando...@gmail.com> wrote: >> On Mon, Feb 19, 2018 at 12:20 AM, David Rientjes <rient...@google.com> wrote: >>>

Re: [PATCH] Support the nonstring variable attribute (gcc >= 8)

On Thu, Mar 1, 2018 at 10:57 AM, Arnd Bergmann wrote: > On Mon, Feb 19, 2018 at 1:01 AM, Miguel Ojeda > wrote: >> On Mon, Feb 19, 2018 at 12:20 AM, David Rientjes wrote: >>> On Sat, 17 Feb 2018, Miguel Ojeda wrote: >>> >>>> From the GCC manual:

Re: [PATCH 2/2] auxdisplay: make PANEL a menuconfig

m "Device Drivers". It also unclutters the Device Drivers menu in > nconfig and menuconfig by moving the PANEL drivers to a sub-menu. > > Signed-off-by: Randy Dunlap <rdun...@infradead.org> > Cc: Miguel Ojeda Sandonis <miguel.ojeda.sando...@gmail.com> > Acked-by: Geert Uy

Re: [PATCH 2/2] auxdisplay: make PANEL a menuconfig

Drivers menu in > nconfig and menuconfig by moving the PANEL drivers to a sub-menu. > > Signed-off-by: Randy Dunlap > Cc: Miguel Ojeda Sandonis > Acked-by: Geert Uytterhoeven > Reviewed-by: Andy Shevchenko Picking it up. Cheers, Miguel > --- > drivers/auxdisplay/Kconf

Re: [PATCH 1/2] auxdisplay: fix broken menu

ndif block. >> Geert says that it should be there. >> >> Fixes: 39f8ea46724e ("auxdisplay: charlcd: Extract character LCD core from >> misc/panel") >> >> Cc: sta...@vger.kernel.org # v4.12 >> Cc: Geert Uytterhoeven <ge...@linux-m68k.org> >

Re: [PATCH 1/2] auxdisplay: fix broken menu

24e ("auxdisplay: charlcd: Extract character LCD core from >> misc/panel") >> >> Cc: sta...@vger.kernel.org # v4.12 >> Cc: Geert Uytterhoeven >> Cc: Andy Shevchenko > > Reviewed-by: Andy Shevchenko > >> Cc: Miguel Ojeda Sandonis >> Sig

Re: [PATCH RFC v3] auxdisplay: charlcd: Fix and clean up handling of x/y commands

On Wed, Feb 28, 2018 at 12:23 AM, Robert Abel <ra...@robertabel.eu> wrote: > On 27 Feb 2018 23:09, Miguel Ojeda wrote:> @@ -469,24 +543,11 @@ static > inline int handle_lcd_special_code(struct charlcd *lcd) >> } >> case 'x': /* gotoxy : LxXXX

Re: [PATCH RFC v3] auxdisplay: charlcd: Fix and clean up handling of x/y commands

On Wed, Feb 28, 2018 at 12:23 AM, Robert Abel wrote: > On 27 Feb 2018 23:09, Miguel Ojeda wrote:> @@ -469,24 +543,11 @@ static > inline int handle_lcd_special_code(struct charlcd *lcd) >> } >> case 'x': /* gotoxy : LxXXX[yYYY]; */ >> case 'y':

[PATCH RFC v3] auxdisplay: charlcd: Fix and clean up handling of x/y commands

.eu> Cc: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Robert Abel <ra...@robertabel.eu> Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com> --- Disregard v2, this is much more clear. I am too tired :) This one an

[PATCH RFC v3] auxdisplay: charlcd: Fix and clean up handling of x/y commands

Uytterhoeven Cc: Andy Shevchenko Cc: Robert Abel Signed-off-by: Miguel Ojeda --- Disregard v2, this is much more clear. I am too tired :) This one and v2 are the loop versions, v1 is the kstrto*() version. I also added some more comments on top of the v2. drivers/auxdisplay/charlcd.c | 95

[PATCH RFC v2] auxdisplay: charlcd: Fix and clean up handling of x/y commands

.eu> Cc: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Robert Abel <ra...@robertabel.eu> Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com> --- drivers/auxdisplay/charlcd.c | 101 +

[PATCH RFC v2] auxdisplay: charlcd: Fix and clean up handling of x/y commands

Uytterhoeven Cc: Andy Shevchenko Cc: Robert Abel Signed-off-by: Miguel Ojeda --- drivers/auxdisplay/charlcd.c | 101 +++ 1 file changed, 83 insertions(+), 18 deletions(-) diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c index

Re: [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands

On Tue, Feb 27, 2018 at 9:52 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Tue, Feb 27, 2018 at 9:32 PM, Miguel Ojeda > <miguel.ojeda.sando...@gmail.com> wrote: >> The current version is not parsing multiple x/y commands as the code >> originally inte

Re: [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands

On Tue, Feb 27, 2018 at 9:52 PM, Andy Shevchenko wrote: > On Tue, Feb 27, 2018 at 9:32 PM, Miguel Ojeda > wrote: >> The current version is not parsing multiple x/y commands as the code >> originally intended. On top of that, kstrtoul() expects >> NULL-terminated string

Re: [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands

On Tue, Feb 27, 2018 at 9:13 PM, Willy Tarreau <w...@1wt.eu> wrote: > On Tue, Feb 27, 2018 at 08:32:21PM +0100, Miguel Ojeda wrote: >> The current version is not parsing multiple x/y commands as the code >> originally intended. On top of that, kstrtoul() expects >> NULL-

Re: [PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands

On Tue, Feb 27, 2018 at 9:13 PM, Willy Tarreau wrote: > On Tue, Feb 27, 2018 at 08:32:21PM +0100, Miguel Ojeda wrote: >> The current version is not parsing multiple x/y commands as the code >> originally intended. On top of that, kstrtoul() expects >> NULL-terminated strin

[PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands

. Cc: Willy Tarreau <w...@1wt.eu> Cc: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: Andy Shevchenko <andy.shevche...@gmail.com> Cc: Robert Abel <ra...@robertabel.eu> Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com> --- Only the parsing functions are

[PATCH RFC] auxdisplay: charlcd: Fix and clean up handling of x/y commands

. Cc: Willy Tarreau Cc: Geert Uytterhoeven Cc: Andy Shevchenko Cc: Robert Abel Signed-off-by: Miguel Ojeda --- Only the parsing functions are tested, please try on real HW. drivers/auxdisplay/charlcd.c | 97 1 file changed, 79 insertions(+), 18

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Tue, Feb 27, 2018 at 6:19 AM, Willy Tarreau <w...@1wt.eu> wrote: > On Mon, Feb 26, 2018 at 11:43:36PM +0100, Robert Abel wrote: >> On 26 Feb 2018 17:49, Miguel Ojeda wrote: >> > On a general note, the code seems a bit convoluted for what it does, >> > spec

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Tue, Feb 27, 2018 at 6:19 AM, Willy Tarreau wrote: > On Mon, Feb 26, 2018 at 11:43:36PM +0100, Robert Abel wrote: >> On 26 Feb 2018 17:49, Miguel Ojeda wrote: >> > On a general note, the code seems a bit convoluted for what it does, >> > specially without the co

Re: [PATCH v1] kernel.h: Update comment about simple_strto() functions

On Tue, Feb 27, 2018 at 12:40 PM, Andy Shevchenko <andriy.shevche...@linux.intel.com> wrote: > On Mon, 2018-02-26 at 23:31 +0100, Miguel Ojeda wrote: >> On Mon, Feb 26, 2018 at 6:55 PM, Andy Shevchenko >> <andriy.shevche...@linux.intel.com> wrote: >> > There we

Re: [PATCH v1] kernel.h: Update comment about simple_strto() functions

On Tue, Feb 27, 2018 at 12:40 PM, Andy Shevchenko wrote: > On Mon, 2018-02-26 at 23:31 +0100, Miguel Ojeda wrote: >> On Mon, Feb 26, 2018 at 6:55 PM, Andy Shevchenko >> wrote: >> > There were discussions in the past about use cases for >> > simple_strto()

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Mon, Feb 26, 2018 at 11:38 PM, Robert Abel <ra...@robertabel.eu> wrote: > Hi Andy, Hi Miguel, > > On 26 Feb 2018 12:44, Andy Shevchenko wrote: >> Can we avoid yoda style of programming? > On 26 Feb 2018 17:49, Miguel Ojeda wrote: >> Please do not change the style

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Mon, Feb 26, 2018 at 11:38 PM, Robert Abel wrote: > Hi Andy, Hi Miguel, > > On 26 Feb 2018 12:44, Andy Shevchenko wrote: >> Can we avoid yoda style of programming? > On 26 Feb 2018 17:49, Miguel Ojeda wrote: >> Please do not change the style of the code w.r.t to the re

Re: [PATCH v1] kernel.h: Update comment about simple_strto() functions

ing about special use cases. > > Suggested-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com> I am not sure we should just go back to the old ones, though. Maybe it is better to create a new set of kstrto*_inplace() or some other name, safer than the old ones and following kstrto*()'s in

Re: [PATCH v1] kernel.h: Update comment about simple_strto() functions

On Mon, Feb 26, 2018 at 6:55 PM, Andy Shevchenko wrote: > There were discussions in the past about use cases for > simple_strto() functions and in some rare cases they have a benefit > on kstrto() ones. > > Update a comment to reduce confusing about special use cases. > >

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Mon, Feb 26, 2018 at 6:09 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Mon, Feb 26, 2018 at 6:54 PM, Miguel Ojeda > <miguel.ojeda.sando...@gmail.com> wrote: >> On Mon, Feb 26, 2018 at 12:44 PM, Andy Shevchenko >> <andy.shevche...@gmail.com> wro

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Mon, Feb 26, 2018 at 6:09 PM, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 6:54 PM, Miguel Ojeda > wrote: >> On Mon, Feb 26, 2018 at 12:44 PM, Andy Shevchenko >> wrote: >>> On Mon, Feb 26, 2018 at 1:54 AM, Robert Abel wrote: > >>>&

Re: [PATCH 4/4] auxdisplay: charlcd: make home command unshift display

On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote: > A user has no way of unshifting the display programmatically once shifted. > Users cannot rely on ^[[H (home) to result in their message being seen either. > Use the actual HOME command 0x02 instead of only returning to

Re: [PATCH 4/4] auxdisplay: charlcd: make home command unshift display

On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote: > A user has no way of unshifting the display programmatically once shifted. > Users cannot rely on ^[[H (home) to result in their message being seen either. > Use the actual HOME command 0x02 instead of only returning to x0/y0. > Users can

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Mon, Feb 26, 2018 at 5:49 PM, Miguel Ojeda <miguel.ojeda.sando...@gmail.com> wrote: > On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel <ra...@robertabel.eu> wrote: >> NUL-terminate each individual number to be parsed. >> To do this, the next command character an

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Mon, Feb 26, 2018 at 5:49 PM, Miguel Ojeda wrote: > On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote: >> NUL-terminate each individual number to be parsed. >> To do this, the next command character and a pointer to its argument >> are found and stored.

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Mon, Feb 26, 2018 at 12:44 PM, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 1:54 AM, Robert Abel wrote: >> NUL-terminate each individual number to be parsed. >> To do this, the next command character and a pointer to its argument >> are

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Mon, Feb 26, 2018 at 12:44 PM, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 1:54 AM, Robert Abel wrote: >> NUL-terminate each individual number to be parsed. >> To do this, the next command character and a pointer to its argument >> are found and stored. The command character is then

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote: > NUL-terminate each individual number to be parsed. > To do this, the next command character and a pointer to its argument > are found and stored. The command character is then overwritten by NUL > before kstr* functions

Re: [PATCH 3/4] auxdisplay: charlcd: fix x/y address commands

On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote: > NUL-terminate each individual number to be parsed. > To do this, the next command character and a pointer to its argument > are found and stored. The command character is then overwritten by NUL > before kstr* functions are called on the

Re: [PATCH 2/4] auxdisplay: charlcd: name x/y address struct

On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote: > Signed-off-by: Robert Abel > --- > drivers/auxdisplay/charlcd.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/auxdisplay/charlcd.c

Re: [PATCH 2/4] auxdisplay: charlcd: name x/y address struct

On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote: > Signed-off-by: Robert Abel > --- > drivers/auxdisplay/charlcd.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c > index

Re: [PATCH 1/4] auxdisplay: charlcd: fix two-line command ^[[LN not marked as processed

On Mon, Feb 26, 2018 at 9:34 AM, Geert Uytterhoeven wrote: > On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote: >> Signed-off-by: Robert Abel > > Reviewed-by: Geert Uytterhoeven Good catch Robert! Picking

Re: [PATCH 1/4] auxdisplay: charlcd: fix two-line command ^[[LN not marked as processed

On Mon, Feb 26, 2018 at 9:34 AM, Geert Uytterhoeven wrote: > On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel wrote: >> Signed-off-by: Robert Abel > > Reviewed-by: Geert Uytterhoeven Good catch Robert! Picking it up for 4.17. Cheers, Miguel > > Gr{oetje,eeting}s, > >

Re: [PATCH] auxdisplay: arm-charlcd: Fix struct charlcd doc line

On Sun, Feb 25, 2018 at 7:13 PM, Randy Dunlap <rdun...@infradead.org> wrote: > On 02/25/2018 04:46 AM, Miguel Ojeda wrote: >> There was a missing first line and a missing member, >> which gave a warning under W=1: >> >> CC drivers/auxdisplay/arm-char

Re: [PATCH] auxdisplay: arm-charlcd: Fix struct charlcd doc line

On Sun, Feb 25, 2018 at 7:13 PM, Randy Dunlap wrote: > On 02/25/2018 04:46 AM, Miguel Ojeda wrote: >> There was a missing first line and a missing member, >> which gave a warning under W=1: >> >> CC drivers/auxdisplay/arm-charlcd.o >> drivers/aux

[PATCH] auxdisplay: arm-charlcd: Fix struct charlcd doc line

Walleij <tr...@df.lth.se> Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com> --- Please let me know if anyone does not want this in 4.17. drivers/auxdisplay/arm-charlcd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/au

[PATCH] auxdisplay: arm-charlcd: Fix struct charlcd doc line

Walleij Signed-off-by: Miguel Ojeda --- Please let me know if anyone does not want this in 4.17. drivers/auxdisplay/arm-charlcd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c index b3176ee92b90..27cf08a05e93 100644

Re: [PATCH] auxdisplay: img-ascii-lcd: add MODULE_LICENSE("GPL")

On Sun, Feb 25, 2018 at 1:25 PM, Miguel Ojeda <miguel.ojeda.sando...@gmail.com> wrote: > On Sat, Feb 24, 2018 at 4:08 PM, Daniel Axtens <d...@axtens.net> wrote: >> Miguel Ojeda <miguel.ojeda.sando...@gmail.com> writes: >> >>> Hi Daniel, >>> &g

Re: [PATCH] auxdisplay: img-ascii-lcd: add MODULE_LICENSE("GPL")

On Sun, Feb 25, 2018 at 1:25 PM, Miguel Ojeda wrote: > On Sat, Feb 24, 2018 at 4:08 PM, Daniel Axtens wrote: >> Miguel Ojeda writes: >> >>> Hi Daniel, >>> >>> On Sun, Nov 26, 2017 at 3:53 AM, Daniel Axtens wrote: >>>> This

Re: [PATCH] auxdisplay: img-ascii-lcd: add MODULE_LICENSE("GPL")

On Sat, Feb 24, 2018 at 4:08 PM, Daniel Axtens <d...@axtens.net> wrote: > Miguel Ojeda <miguel.ojeda.sando...@gmail.com> writes: > >> Hi Daniel, >> >> On Sun, Nov 26, 2017 at 3:53 AM, Daniel Axtens <d...@axtens.net> wrote: >>> This mat

Re: [PATCH] auxdisplay: img-ascii-lcd: add MODULE_LICENSE("GPL")

On Sat, Feb 24, 2018 at 4:08 PM, Daniel Axtens wrote: > Miguel Ojeda writes: > >> Hi Daniel, >> >> On Sun, Nov 26, 2017 at 3:53 AM, Daniel Axtens wrote: >>> This matches the header at the top of the file and squashes: >>> >>> WARNING: modpost:

Re: [PATCH V1 2/3] efi: Introduce efi_rts_workqueue and necessary infrastructure to invoke all efi_runtime_services()

On Sat, Feb 24, 2018 at 11:10 PM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > When a process requests the kernel to execute any efi_runtime_service(), > the requested efi_runtime_service (represented as an identifier) and

Re: [PATCH V1 2/3] efi: Introduce efi_rts_workqueue and necessary infrastructure to invoke all efi_runtime_services()

On Sat, Feb 24, 2018 at 11:10 PM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > When a process requests the kernel to execute any efi_runtime_service(), > the requested efi_runtime_service (represented as an identifier) and its > arguments are packed into a struct named efi_runtime_work

Re: [PATCH 2/3] power: supply: add cros-ec USB PD charger driver.

On Wed, Jan 17, 2018 at 6:59 PM, Enric Balletbo i Serra wrote: > From: Sameer Nanda > > This driver gets various bits of information about what is connected to > USB PD ports from the EC and converts that into power_supply properties. > >

Re: [PATCH 2/3] power: supply: add cros-ec USB PD charger driver.

On Wed, Jan 17, 2018 at 6:59 PM, Enric Balletbo i Serra wrote: > From: Sameer Nanda > > This driver gets various bits of information about what is connected to > USB PD ports from the EC and converts that into power_supply properties. > > Signed-off-by: Sameer Nanda > Signed-off-by: Enric

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

On Thu, Feb 22, 2018 at 2:29 AM, Jae Hyun Yoo wrote: > On 2/21/2018 4:37 PM, Andrew Lunn wrote: >>> >>> But even with this change, it still needs to use delayed creation >>> because BMC side kernel doesn't know how many DIMMs are populated on >>> a remote server

Re: [PATCH v2 7/8] [PATCH 7/8] drivers/hwmon: Add a generic PECI hwmon client driver

On Thu, Feb 22, 2018 at 2:29 AM, Jae Hyun Yoo wrote: > On 2/21/2018 4:37 PM, Andrew Lunn wrote: >>> >>> But even with this change, it still needs to use delayed creation >>> because BMC side kernel doesn't know how many DIMMs are populated on >>> a remote server before the remote server completes

Re: [PATCH 9/9] scsi: ufs: Add clock ungating to a separate workqueue

On Wed, Feb 21, 2018 at 5:56 AM, Asutosh Das wrote: > From: Vijay Viswanath > > UFS driver can receive a request during memory reclaim by kswapd. > So when ufs driver puts the ungate work in queue, and if there are no > idle workers, kthreadd is

Re: [PATCH 9/9] scsi: ufs: Add clock ungating to a separate workqueue

On Wed, Feb 21, 2018 at 5:56 AM, Asutosh Das wrote: > From: Vijay Viswanath > > UFS driver can receive a request during memory reclaim by kswapd. > So when ufs driver puts the ungate work in queue, and if there are no > idle workers, kthreadd is invoked to create a new kworker. Since > kswapd

Re: [PATCH] auxdisplay: ht16k33: constify fb_fix_screeninfo and fb_var_screeninfo structures

Hi Gustavo, On Sat, Jul 8, 2017 at 2:56 AM, Gustavo A. R. Silva wrote: > These structures are only used to copy into other structures, > so declare them as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable

Re: [PATCH] auxdisplay: ht16k33: constify fb_fix_screeninfo and fb_var_screeninfo structures

Hi Gustavo, On Sat, Jul 8, 2017 at 2:56 AM, Gustavo A. R. Silva wrote: > These structures are only used to copy into other structures, > so declare them as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; >

Re: [PATCH] auxdisplay: panel: mark expected switch fall-throughs

Hi Gustavo, On Thu, Oct 12, 2017 at 11:35 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > In this particular case, notice that I replaced the "no break here, > fall

Re: [PATCH] auxdisplay: panel: mark expected switch fall-throughs

Hi Gustavo, On Thu, Oct 12, 2017 at 11:35 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > In this particular case, notice that I replaced the "no break here, > fall through" comments with "fall

Re: [PATCH] auxdisplay: img-ascii-lcd: add MODULE_LICENSE("GPL")

Hi Daniel, On Sun, Nov 26, 2017 at 3:53 AM, Daniel Axtens wrote: > This matches the header at the top of the file and squashes: > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/auxdisplay/img-ascii-lcd.o > see include/linux/module.h for more information > >

Re: [PATCH] auxdisplay: img-ascii-lcd: add MODULE_LICENSE("GPL")

Hi Daniel, On Sun, Nov 26, 2017 at 3:53 AM, Daniel Axtens wrote: > This matches the header at the top of the file and squashes: > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/auxdisplay/img-ascii-lcd.o > see include/linux/module.h for more information > > Signed-off-by: Daniel

Re: [PATCH] staging: auxdisplay: add missing MODULE_LICENSE()

Hi Shannon, On Wed, Jan 31, 2018 at 10:31 AM, Shannon Booth wrote: > This patch fixes the compilation warning: > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/auxdisplay/img-ascii-lcd.o > > Signed-off-by: Shannon Booth > --- >

Re: [PATCH] staging: auxdisplay: add missing MODULE_LICENSE()

Hi Shannon, On Wed, Jan 31, 2018 at 10:31 AM, Shannon Booth wrote: > This patch fixes the compilation warning: > > WARNING: modpost: missing MODULE_LICENSE() in > drivers/auxdisplay/img-ascii-lcd.o > > Signed-off-by: Shannon Booth > --- > drivers/auxdisplay/img-ascii-lcd.c | 2 ++ > 1 file

Re: [PATCH 3/3] auxdisplay: img-ascii-lcd: Silence 2 uninitialized warnings

Hi Geert, On Mon, Feb 19, 2018 at 7:40 PM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Hi Miguel, > > On Mon, Feb 19, 2018 at 5:09 PM, Miguel Ojeda > <miguel.ojeda.sando...@gmail.com> wrote: >> The warnings are: >> >> drivers/auxdisplay/i

Re: [PATCH 3/3] auxdisplay: img-ascii-lcd: Silence 2 uninitialized warnings

Hi Geert, On Mon, Feb 19, 2018 at 7:40 PM, Geert Uytterhoeven wrote: > Hi Miguel, > > On Mon, Feb 19, 2018 at 5:09 PM, Miguel Ojeda > wrote: >> The warnings are: >> >> drivers/auxdisplay/img-ascii-lcd.c: warning: 'err' may be used >> uninitializ

[PATCH 3/3] auxdisplay: img-ascii-lcd: Silence 2 uninitialized warnings

ear starting with gcc >= 4.9 Cc: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: Paul Burton <paul.bur...@mips.com> Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com> --- I will queue it up for 4.17. drivers/auxdisplay/img-ascii-lcd.c | 4 ++-- 1 file changed, 2 in

[PATCH 3/3] auxdisplay: img-ascii-lcd: Silence 2 uninitialized warnings

ear starting with gcc >= 4.9 Cc: Geert Uytterhoeven Cc: Paul Burton Signed-off-by: Miguel Ojeda --- I will queue it up for 4.17. drivers/auxdisplay/img-ascii-lcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdispl

[PATCH 2/3] auxdisplay: img-ascii-lcd: Fix doc comment to silence warnings

in 'img_ascii_lcd_scroll' Cc: Paul Burton <paul.bur...@mips.com> Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com> --- I saw this while fixing the ones reported by the build service. I will queue it up for 4.17. drivers/auxdisplay/img-ascii-lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 2/3] auxdisplay: img-ascii-lcd: Fix doc comment to silence warnings

in 'img_ascii_lcd_scroll' Cc: Paul Burton Signed-off-by: Miguel Ojeda --- I saw this while fixing the ones reported by the build service. I will queue it up for 4.17. drivers/auxdisplay/img-ascii-lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers

[PATCH 1/3] auxdisplay: panel: Change comments to silence fallthrough warnings

en <ge...@linux-m68k.org> Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com> --- I saw this while fixing the ones reported by the build service. I will queue it up for 4.17. drivers/auxdisplay/panel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/

[PATCH 1/3] auxdisplay: panel: Change comments to silence fallthrough warnings

Compiling with W=1 with gcc 7.2.0 gives 3 warnings like: drivers/auxdisplay/panel.c: In function ‘panel_process_inputs’: drivers/auxdisplay/panel.c:1374:17: warning: this statement may fall through [-Wimplicit-fallthrough=] Cc: Willy Tarreau Cc: Geert Uytterhoeven Signed-off-by: Miguel

Re: [PATCH] Support the nonstring variable attribute (gcc >= 8)

On Mon, Feb 19, 2018 at 12:20 AM, David Rientjes <rient...@google.com> wrote: > On Sat, 17 Feb 2018, Miguel Ojeda wrote: > >> From the GCC manual: >> >> The nonstring variable attribute specifies that an object or member >> declaration with type array of

Re: [PATCH] Support the nonstring variable attribute (gcc >= 8)

On Mon, Feb 19, 2018 at 12:20 AM, David Rientjes wrote: > On Sat, 17 Feb 2018, Miguel Ojeda wrote: > >> From the GCC manual: >> >> The nonstring variable attribute specifies that an object or member >> declaration with type array of char or pointer to char is intende

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne <pombreda...@nexb.com> wrote: > Miguel, > > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda > <miguel.ojeda.sando...@gmail.com> wrote: >> Cc: Willy Tarreau <w...@1wt.eu> >> Cc: Geert Uytterhoeven <g

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne wrote: > Miguel, > > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda > wrote: >> Cc: Willy Tarreau >> Cc: Geert Uytterhoeven >> Cc: Linus Walleij >> Cc: Robin van der Gracht >> Cc: P

[PATCH] auxdisplay: Replace licenses with SPDX identifiers

Cc: Willy Tarreau <w...@1wt.eu> Cc: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: Linus Walleij <tr...@df.lth.se> Cc: Robin van der Gracht <ro...@protonic.nl> Cc: Paul Burton <paul.bur...@mips.com> Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com>

[PATCH] auxdisplay: Replace licenses with SPDX identifiers

Cc: Willy Tarreau Cc: Geert Uytterhoeven Cc: Linus Walleij Cc: Robin van der Gracht Cc: Paul Burton Signed-off-by: Miguel Ojeda --- Please let me know if you agree for your files and I will queue it up. Thanks! drivers/auxdisplay/arm-charlcd.c| 2 +- drivers/auxdisplay

[PATCH] Support the nonstring variable attribute (gcc >= 8)

ing to the LKML regarding these warnings. When they are false positives, we can use __nonstring to let gcc know a NUL character is not required; like in this case: https://lkml.org/lkml/2018/1/16/135 Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com> Cc: Ingo Molnar <mi...@kernel.o

[PATCH] Support the nonstring variable attribute (gcc >= 8)

ing to the LKML regarding these warnings. When they are false positives, we can use __nonstring to let gcc know a NUL character is not required; like in this case: https://lkml.org/lkml/2018/1/16/135 Signed-off-by: Miguel Ojeda Cc: Ingo Molnar Cc: Josh Poimboeuf Cc: Kees Cook Cc: Andrew Morton

Re: [PATCH V2] auxdisplay: use correct string length

On Mon, Feb 12, 2018 at 6:11 PM, Willy Tarreau <w...@1wt.eu> wrote: > On Mon, Feb 12, 2018 at 01:53:57PM +0100, Miguel Ojeda wrote: >> > diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c >> > index ea7869c..d288900 100644 >> > --- a/drivers/a

Re: [PATCH V2] auxdisplay: use correct string length

On Mon, Feb 12, 2018 at 6:11 PM, Willy Tarreau wrote: > On Mon, Feb 12, 2018 at 01:53:57PM +0100, Miguel Ojeda wrote: >> > diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c >> > index ea7869c..d288900 100644 >> > --- a/drivers/auxdisplay/panel.c

Re: [PATCH 1/3] auxdisplay: charlcd: fix hex literal ranges for graphics command

On Sat, Feb 10, 2018 at 10:41 AM, Miguel Ojeda <miguel.ojeda.sando...@gmail.com> wrote: > On Sat, Feb 10, 2018 at 10:20 AM, Willy Tarreau <w...@1wt.eu> wrote: >> Hi Miguel, >> >> On Sat, Feb 10, 2018 at 09:58:44AM +0100, Miguel Ojeda wrote: >>> On Sat,

Re: [PATCH 1/3] auxdisplay: charlcd: fix hex literal ranges for graphics command

On Sat, Feb 10, 2018 at 10:41 AM, Miguel Ojeda wrote: > On Sat, Feb 10, 2018 at 10:20 AM, Willy Tarreau wrote: >> Hi Miguel, >> >> On Sat, Feb 10, 2018 at 09:58:44AM +0100, Miguel Ojeda wrote: >>> On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel wrote: >>

Re: [PATCH] auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON

On Thu, Feb 8, 2018 at 4:58 PM, Miguel Ojeda <miguel.ojeda.sando...@gmail.com> wrote: > On Thu, Jan 18, 2018 at 9:13 PM, Corentin Labbe > <clabbe.montj...@gmail.com> wrote: >> img-ascii-lcd select un-existing SYSCON kconfig name. >> This patch fix this error by using

Re: [PATCH] auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON

On Thu, Feb 8, 2018 at 4:58 PM, Miguel Ojeda wrote: > On Thu, Jan 18, 2018 at 9:13 PM, Corentin Labbe > wrote: >> img-ascii-lcd select un-existing SYSCON kconfig name. >> This patch fix this error by using the correct MFD_SYSCON kconfig name. >> > > CC'ing Paul &

Re: [PATCH v2] auxdisplay: img-ascii-lcd: kconfig: Remove MIPS_SEAD3 reference

On Sun, Feb 11, 2018 at 5:40 PM, Miguel Ojeda <miguel.ojeda.sando...@gmail.com> wrote: > On Sat, Feb 10, 2018 at 3:14 PM, Ulf Magnusson <ulfali...@gmail.com> wrote: >> Commit 3f5f0a4475e1 ("MIPS: generic: Convert SEAD-3 to a generic board") >> removed the MI

Re: [PATCH v2] auxdisplay: img-ascii-lcd: kconfig: Remove MIPS_SEAD3 reference

On Sun, Feb 11, 2018 at 5:40 PM, Miguel Ojeda wrote: > On Sat, Feb 10, 2018 at 3:14 PM, Ulf Magnusson wrote: >> Commit 3f5f0a4475e1 ("MIPS: generic: Convert SEAD-3 to a generic board") >> removed the MIPS_SEAD3 symbol and moved the setting of IMG_ASCII_LCD to >> th

Re: [PATCH] auxdisplay: charlcd: delete mdelay in long_sleep

On Mon, Jan 29, 2018 at 7:50 AM, Willy Tarreau wrote: > Hi, > > On Fri, Jan 26, 2018 at 11:19:15PM +0800, Jia-Ju Bai wrote: >> The function long_sleep() calls mdelay() when in an interrupt handler. >> But only charlcd_clear_display() and charlcd_init_display calls >> long_sleep(),

Re: [PATCH] auxdisplay: charlcd: delete mdelay in long_sleep

On Mon, Jan 29, 2018 at 7:50 AM, Willy Tarreau wrote: > Hi, > > On Fri, Jan 26, 2018 at 11:19:15PM +0800, Jia-Ju Bai wrote: >> The function long_sleep() calls mdelay() when in an interrupt handler. >> But only charlcd_clear_display() and charlcd_init_display calls >> long_sleep(), and my tool

Re: [PATCH V2] auxdisplay: use correct string length

On Tue, Jan 16, 2018 at 10:38 AM, Xiongfeng Wang wrote: > From: Xiongfeng Wang > > gcc-8 reports > > drivers/auxdisplay/panel.c: In function 'panel_attach': > ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified > bound 12

Re: [PATCH V2] auxdisplay: use correct string length

On Tue, Jan 16, 2018 at 10:38 AM, Xiongfeng Wang wrote: > From: Xiongfeng Wang > > gcc-8 reports > > drivers/auxdisplay/panel.c: In function 'panel_attach': > ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified > bound 12 equals destination size [-Wstringop-truncation] > > We

Re: [PATCH] auxdisplay: charlcd: delete mdelay in long_sleep

On Mon, Jan 29, 2018 at 7:50 AM, Willy Tarreau wrote: > Hi, > > On Fri, Jan 26, 2018 at 11:19:15PM +0800, Jia-Ju Bai wrote: >> The function long_sleep() calls mdelay() when in an interrupt handler. >> But only charlcd_clear_display() and charlcd_init_display calls >> long_sleep(),

Re: [PATCH] auxdisplay: charlcd: delete mdelay in long_sleep

On Mon, Jan 29, 2018 at 7:50 AM, Willy Tarreau wrote: > Hi, > > On Fri, Jan 26, 2018 at 11:19:15PM +0800, Jia-Ju Bai wrote: >> The function long_sleep() calls mdelay() when in an interrupt handler. >> But only charlcd_clear_display() and charlcd_init_display calls >> long_sleep(), and my tool

Re: [PATCH v2] auxdisplay: img-ascii-lcd: kconfig: Remove MIPS_SEAD3 reference

; --- > Changes in v2: > > - The wrong commit was referenced in the commit message. > > - Mention that IMG_ASCII_LCD is now set via the board-sead-3.config defconfig >file. > > - Clarify that Kconfig is involved. The previous commit title was >"auxdisplay: img-a

<    4   5   6   7   8   9   10   11   >