Re: Geode-GX1 processor in 2.6.21

2007-04-30 Thread Mikael Pettersson
On Mon, 30 Apr 2007 12:51:05 +0200, Juergen Beisert wrote: setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); If this register is 0x00 before, it is still 0x00 after this line. If I change the line into this: ccr2 = getCx86(CX86_CCR2); ccr2 |= 0x88;

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected

2007-04-30 Thread Mikael Pettersson
On Mon, 30 Apr 2007 15:09:58 +0200, Juergen Beisert wrote: Replace NSC/Cyrix specific chipset access macros by inlined functions. With the macros a line like this fails (and does nothing): setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); With inlined functions this line will work as

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected

2007-04-30 Thread Mikael Pettersson
On 30 Apr 2007 17:32:04 +0200, Andi Kleen wrote: From: Juergen Beisert [EMAIL PROTECTED] Replace NSC/Cyrix specific chipset access macros by inlined functions. With the macros a line like this fails (and does nothing): setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); With inlined

Re: [PATCH] [1/1] CPU-i386-Geode: Chipset access macros do not work as expected (2nd try)

2007-04-30 Thread Mikael Pettersson
like this: Clocksource tsc unstable (delta = -472746897 ns) Tested on a Geode GX1 system. This is the second version with some modifications suggested by Mikael Pettersson Signed-off-by: Juergen Beisert [EMAIL PROTECTED] Acked-by: Mikael Pettersson [EMAIL PROTECTED] Index: linux

Re: sky2 regression in 2.6.21: Asus P5B-E Plus ethernet adapter no more supported

2007-04-28 Thread Mikael Pettersson
On Thu, 26 Apr 2007 15:50:50 -0700, Stephen Hemminger wrote: >On Thu, 26 Apr 2007 23:24:18 +0200 >Francois SIMOND <[EMAIL PROTECTED]> wrote: > >> Hello, >> >> Lastest sky2 update between 2.6.21-rc7 and 2.6.21 final disables the support >> of the integrated ethernet adapter build on the Asus

Re: sky2 regression in 2.6.21: Asus P5B-E Plus ethernet adapter no more supported

2007-04-28 Thread Mikael Pettersson
On Thu, 26 Apr 2007 15:50:50 -0700, Stephen Hemminger wrote: On Thu, 26 Apr 2007 23:24:18 +0200 Francois SIMOND [EMAIL PROTECTED] wrote: Hello, Lastest sky2 update between 2.6.21-rc7 and 2.6.21 final disables the support of the integrated ethernet adapter build on the Asus P5B-E Plus

[BUG 2.6.21-rc7] acpi_pm clocksource loses time on x86-64

2007-04-17 Thread Mikael Pettersson
The machine is an old Athlon64 laptop (Targa Visionary 811, OEMd as the Arima W720-K8, also sold as the eMachines m6805) with a VIA K8T800 chipset. ACPI is enabled. Up to kernel 2.6.20, time-keeping worked fine. In the x86-64 kernel, the clock source is listed as "jiffies". With current

[BUG 2.6.21-rc7] acpi_pm clocksource loses time on x86-64

2007-04-17 Thread Mikael Pettersson
The machine is an old Athlon64 laptop (Targa Visionary 811, OEMd as the Arima W720-K8, also sold as the eMachines m6805) with a VIA K8T800 chipset. ACPI is enabled. Up to kernel 2.6.20, time-keeping worked fine. In the x86-64 kernel, the clock source is listed as jiffies. With current

Re: utrace merge

2007-04-04 Thread Mikael Pettersson
On Wed, 4 Apr 2007 12:06:44 +0200, Ingo Molnar wrote: > btw., how about pushing utrace to v2.6.22, is anything big holding that > up? IMO, until regressions in the ptrace userspace API like are eliminated, utrace must not replace

Re: utrace merge

2007-04-04 Thread Mikael Pettersson
On Wed, 4 Apr 2007 12:06:44 +0200, Ingo Molnar wrote: btw., how about pushing utrace to v2.6.22, is anything big holding that up? IMO, until regressions in the ptrace userspace API like https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229112 are eliminated, utrace must not replace ptrace

Re: [PATCH 1/2] MSR: Add support for safe variants

2007-03-26 Thread Mikael Pettersson
On Mon, 26 Mar 2007 13:29:37 +0200, Jean Delvare wrote: > * * * * * Updated patch * * * * * > > From: Rudolf Marek <[EMAIL PROTECTED]> > > Add safe (exception handled) variants of rdmsr_on_cpu and wrmsr_on_cpu. > You should use these when the target MSR may not actually exist, as > doing so

Re: [PATCH 1/2] MSR: Add support for safe variants

2007-03-26 Thread Mikael Pettersson
On Mon, 26 Mar 2007 13:29:37 +0200, Jean Delvare wrote: * * * * * Updated patch * * * * * From: Rudolf Marek [EMAIL PROTECTED] Add safe (exception handled) variants of rdmsr_on_cpu and wrmsr_on_cpu. You should use these when the target MSR may not actually exist, as doing so could trigger

Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning

2007-03-20 Thread Mikael Pettersson
On Tue, 20 Mar 2007 12:29:49 +0100 (CET), Andreas Kleen <[EMAIL PROTECTED]> wrote: > > The floppy driver's sysfs file just provides some auxiliary > > information to user-space, none of which matters for most of > > its users. It is IMO totally inappropriate to fail floppy > > driver init in this

Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning

2007-03-20 Thread Mikael Pettersson
On Mon, 19 Mar 2007 18:42:22 +0100, Jesper Juhl wrote: > --- a/drivers/block/floppy.c > +++ b/drivers/block/floppy.c > @@ -4302,7 +4302,12 @@ static int __init floppy_init(void) > if (err) > goto out_flush_work; > > -

Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning

2007-03-20 Thread Mikael Pettersson
On Mon, 19 Mar 2007 18:42:22 +0100, Jesper Juhl wrote: --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -4302,7 +4302,12 @@ static int __init floppy_init(void) if (err) goto out_flush_work; -

Re: [PATCH][5/5][resend] floppy.c: Fix device_create_file() warning

2007-03-20 Thread Mikael Pettersson
On Tue, 20 Mar 2007 12:29:49 +0100 (CET), Andreas Kleen [EMAIL PROTECTED] wrote: The floppy driver's sysfs file just provides some auxiliary information to user-space, none of which matters for most of its users. It is IMO totally inappropriate to fail floppy driver init in this case.

Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-19 Thread Mikael Pettersson
On Mon, 19 Mar 2007 12:46:16 +, Alan Cox wrote: > > > This duplicates the IDE core LED trigger in the libata core. > > > I plan to use this by allowing PMU LED control on G5 towers. My test > > > platform > > > is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2 (sata_svw) > > >

Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-19 Thread Mikael Pettersson
On Mon, 19 Mar 2007 12:46:16 +, Alan Cox wrote: This duplicates the IDE core LED trigger in the libata core. I plan to use this by allowing PMU LED control on G5 towers. My test platform is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2 (sata_svw) controller. I

Re: [patch 1/4] [TULIP] fix for Lite-On 82c168 PNIC

2007-03-15 Thread Mikael Pettersson
Valerie Henson writes: > From: Guido Classen <[EMAIL PROTECTED]> > > This small patch fixes two issues with the Lite-On 82c168 PNIC adapters. > I've tested it with two cards in different machines both chip rev 17 > > The first is the wrong register address CSR6 for writing the MII register

Re: [patch 1/4] [TULIP] fix for Lite-On 82c168 PNIC

2007-03-15 Thread Mikael Pettersson
Valerie Henson writes: From: Guido Classen [EMAIL PROTECTED] This small patch fixes two issues with the Lite-On 82c168 PNIC adapters. I've tested it with two cards in different machines both chip rev 17 The first is the wrong register address CSR6 for writing the MII register which

[PATCH 2.6.21-rc1] sparc64: fix CONFIG_PCI_MSI=n compile failure

2007-02-26 Thread Mikael Pettersson
e[1]: *** [arch/sparc64/kernel/irq.o] Error 1 make: *** [arch/sparc64/kernel] Error 2 Most other MSI stuff in irq.c is #ifdef CONFIG_PCI_MSI. So do the same for virt_irq_free() to fix this problem. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.21-rc1/arch/sparc64/ker

[PATCH 2.6.21-rc1] sparc64: fix CONFIG_PCI_MSI=n compile failure

2007-02-26 Thread Mikael Pettersson
] Error 1 make: *** [arch/sparc64/kernel] Error 2 Most other MSI stuff in irq.c is #ifdef CONFIG_PCI_MSI. So do the same for virt_irq_free() to fix this problem. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- linux-2.6.21-rc1/arch/sparc64/kernel/irq.c.~1~ 2007-02-26 17:47:54.0

Re: [PATCH 2.6.21-rc1] x86 signal number delivery fixes

2007-02-25 Thread Mikael Pettersson
On Sun, 25 Feb 2007 23:39:48 +0100, Andi Kleen wrote: > On Sunday 25 February 2007 12:47, Mikael Pettersson wrote: > > The invokation of signal handlers on x86 has several bugs > > in its treatment of the signal number parameter: > > > > - the i386 kernel passes the ra

[PATCH 2.6.21-rc1] sata_promise: simplify port setup

2007-02-25 Thread Mikael Pettersson
ion of the PATA-only 20619 redundantly set up scr_addr for the ports. Remove this. Tested on 20619, 20575, and 20775 chips. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- drivers/ata/sata_promise.c | 29 ++--- 1 files changed, 10 insertions(+), 19

[PATCH 2.6.21-rc1] CREDITS: update my email address

2007-02-25 Thread Mikael Pettersson
Update my email address in CREDITS to one that works. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- Should CREDITS have a specific maintainer? diff -rupN linux-2.6.21-rc1/CREDITS linux-2.6.21-rc1.mikpe-email-address/CREDITS --- linux-2.6.21-rc1/CREDITS2007-02-24

[PATCH 2.6.21-rc1] x86 signal number delivery fixes

2007-02-25 Thread Mikael Pettersson
number both on the stack and in EAX Also, the x86-64 kernel's ia32_setup_rt_frame() has duplicated code for setting up -mregparm=3 parameters: it looks like the same patch hunk was merged twice at some point. Fixed by the following patch. Signed-off-by: Mikael Pettersson <[EMAIL PROTEC

[PATCH 2.6.21-rc1] sata_promise: fix 20619 new EH merge error

2007-02-25 Thread Mikael Pettersson
When I merged my 20619 new EH conversion with #libata-upstream I had to manually resolve a conflict, and inadvertently lost pdc_pata_ops' ->post_internal_cmd binding. Corrected by this patch. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- drivers/ata/sata_promise.c |1 +

[PATCH 2.6.21-rc1] sata_promise: fix 20619 new EH merge error

2007-02-25 Thread Mikael Pettersson
When I merged my 20619 new EH conversion with #libata-upstream I had to manually resolve a conflict, and inadvertently lost pdc_pata_ops' -post_internal_cmd binding. Corrected by this patch. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- drivers/ata/sata_promise.c |1 + 1 files

[PATCH 2.6.21-rc1] x86 signal number delivery fixes

2007-02-25 Thread Mikael Pettersson
number both on the stack and in EAX Also, the x86-64 kernel's ia32_setup_rt_frame() has duplicated code for setting up -mregparm=3 parameters: it looks like the same patch hunk was merged twice at some point. Fixed by the following patch. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED

[PATCH 2.6.21-rc1] CREDITS: update my email address

2007-02-25 Thread Mikael Pettersson
Update my email address in CREDITS to one that works. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- Should CREDITS have a specific maintainer? diff -rupN linux-2.6.21-rc1/CREDITS linux-2.6.21-rc1.mikpe-email-address/CREDITS --- linux-2.6.21-rc1/CREDITS2007-02-24 22:32:42.0

[PATCH 2.6.21-rc1] sata_promise: simplify port setup

2007-02-25 Thread Mikael Pettersson
of the PATA-only 20619 redundantly set up scr_addr for the ports. Remove this. Tested on 20619, 20575, and 20775 chips. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- drivers/ata/sata_promise.c | 29 ++--- 1 files changed, 10 insertions(+), 19 deletions(-) diff

Re: [PATCH 2.6.21-rc1] x86 signal number delivery fixes

2007-02-25 Thread Mikael Pettersson
On Sun, 25 Feb 2007 23:39:48 +0100, Andi Kleen wrote: On Sunday 25 February 2007 12:47, Mikael Pettersson wrote: The invokation of signal handlers on x86 has several bugs in its treatment of the signal number parameter: - the i386 kernel passes the raw not the translated signal number

Re: Support for i386 PATs

2007-01-27 Thread Mikael Pettersson
On Sat, 27 Jan 2007 10:20:18 +0100, Thomas Hellström wrote: > Does anybody have a strong opinion against adding support for > i386 Page Attribute Tables? ... > Issues: > 1) The _PAGE_BIT_PAT will be the same as _PAGE_PSE, and _PAGE_PROTNONE. > As I understand it, _PAGE_PROTNONE is not used when

Re: Support for i386 PATs

2007-01-27 Thread Mikael Pettersson
On Sat, 27 Jan 2007 10:20:18 +0100, Thomas Hellström wrote: Does anybody have a strong opinion against adding support for i386 Page Attribute Tables? ... Issues: 1) The _PAGE_BIT_PAT will be the same as _PAGE_PSE, and _PAGE_PROTNONE. As I understand it, _PAGE_PROTNONE is not used when the

Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32

2007-01-16 Thread Mikael Pettersson
On Tue, 16 Jan 2007 08:14:30 +, Giuliano Procida wrote: > [MTRR] fix 32-bit ioctls on x64_32 > > Signed-off-by: Giuliano Procida <[EMAIL PROTECTED]> > > --- > > Fixed incomplete support for 32-bit compatibility ioctls in > 2.6.19.1. They were unhandled in one of three case-statements. >

Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32

2007-01-16 Thread Mikael Pettersson
On Tue, 16 Jan 2007 08:14:30 +, Giuliano Procida wrote: [MTRR] fix 32-bit ioctls on x64_32 Signed-off-by: Giuliano Procida [EMAIL PROTECTED] --- Fixed incomplete support for 32-bit compatibility ioctls in 2.6.19.1. They were unhandled in one of three case-statements. Testing using

[PATCH 2.6.20-rc5] netfilter: xt_state compile failure

2007-01-15 Thread Mikael Pettersson
: warning: control reaches end of non-void function make[2]: *** [net/netfilter/xt_state.o] Error 1 make[1]: *** [net/netfilter] Error 2 make: *** [net] Error 2 A simple fix is to have nf_conntrack_compat.h #include . Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- li

[PATCH 2.6.20-rc5] netfilter: xt_state compile failure

2007-01-15 Thread Mikael Pettersson
-void function make[2]: *** [net/netfilter/xt_state.o] Error 1 make[1]: *** [net/netfilter] Error 2 make: *** [net] Error 2 A simple fix is to have nf_conntrack_compat.h #include linux/socket.h. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- linux-2.6.20-rc5/include/net/netfilter

Re: SATA exceptions with 2.6.20-rc5

2007-01-14 Thread Mikael Pettersson
Björn Steinbrink writes: > Hi, > > with 2.6.20-rc{2,4,5} (no other tested yet) I see SATA exceptions quite > often, with 2.6.19 there are no such exceptions. dmesg and lspci -v > output follows. In the meantime, I'll start bisecting. > > Thanks > Björn > > > Linux version 2.6.20-rc2

Re: SATA exceptions with 2.6.20-rc5

2007-01-14 Thread Mikael Pettersson
Björn Steinbrink writes: Hi, with 2.6.20-rc{2,4,5} (no other tested yet) I see SATA exceptions quite often, with 2.6.19 there are no such exceptions. dmesg and lspci -v output follows. In the meantime, I'll start bisecting. Thanks Björn Linux version 2.6.20-rc2 ([EMAIL

Re: [PATCH] libata: PIIX3 support

2007-01-11 Thread Mikael Pettersson
On Wed, 10 Jan 2007 17:13:38 +, Alan <[EMAIL PROTECTED]> wrote: >This I believe completes the PIIX range of support for libata > >This adds the table entries needed for the PIIX3, both a new PCI >identifier and a new mode list. It also fixes an erroneous access to PCI >configuration 0x48 on

Re: [PATCH] libata: PIIX3 support

2007-01-11 Thread Mikael Pettersson
On Wed, 10 Jan 2007 17:13:38 +, Alan [EMAIL PROTECTED] wrote: This I believe completes the PIIX range of support for libata This adds the table entries needed for the PIIX3, both a new PCI identifier and a new mode list. It also fixes an erroneous access to PCI configuration 0x48 on non UDMA

[PATCH 2.6.20-rc4] MAINTAINERS: maintainer for sata_promise

2007-01-10 Thread Mikael Pettersson
This patch adds myself as maintainer of the sata_promise libata driver. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc4/MAINTAINERS.~1~2007-01-08 20:42:55.0 +0100 +++ linux-2.6.20-rc4/MAINTAINERS2007-01-10 01:04:23.0 +0100 @@ -2622,6 +2

[PATCH 2.6.20-rc4] sata_promise: ATAPI cleanup

2007-01-10 Thread Mikael Pettersson
issue cannot occur in the current driver, but may occur if the driver starts issuing ATAPI non-DMA commands as PDC packets Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc4/drivers/ata/sata_promise.c.~1~ 2007-01-09 18:53:25.0 +0100 +++ linux-2.6.20-rc4/d

[PATCH 2.6.20-rc4] sata_promise: ATAPI cleanup

2007-01-10 Thread Mikael Pettersson
issue cannot occur in the current driver, but may occur if the driver starts issuing ATAPI non-DMA commands as PDC packets Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- linux-2.6.20-rc4/drivers/ata/sata_promise.c.~1~ 2007-01-09 18:53:25.0 +0100 +++ linux-2.6.20-rc4/drivers

[PATCH 2.6.20-rc4] MAINTAINERS: maintainer for sata_promise

2007-01-10 Thread Mikael Pettersson
This patch adds myself as maintainer of the sata_promise libata driver. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- linux-2.6.20-rc4/MAINTAINERS.~1~2007-01-08 20:42:55.0 +0100 +++ linux-2.6.20-rc4/MAINTAINERS2007-01-10 01:04:23.0 +0100 @@ -2622,6 +2622,12

[PATCH 2.6.20-rc4 2/2] sata_promise: ATAPI support

2007-01-09 Thread Mikael Pettersson
al CDB; this procedure was ported from Promise's driver Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- Changes since the previous version: - merge the changes needed to make SATAPI work on older chips - define pdc_old_check_atapi_dma(), move more restrictive SATAPI DMA rules che

[PATCH 2.6.20-rc4 1/2] sata_promise: TX2plus PATA support

2007-01-09 Thread Mikael Pettersson
places the "exceptional" per-port flags array in the driver's private host structure, and uses it in ->port_start() to finalise the port's flags. This patch obsoletes the #promise-sata-pata branch included in the #all branch. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> -

[PATCH 2.6.20-rc4 1/2] sata_promise: TX2plus PATA support

2007-01-09 Thread Mikael Pettersson
the exceptional per-port flags array in the driver's private host structure, and uses it in -port_start() to finalise the port's flags. This patch obsoletes the #promise-sata-pata branch included in the #all branch. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- Changes since the RFC version

[PATCH 2.6.20-rc4 2/2] sata_promise: ATAPI support

2007-01-09 Thread Mikael Pettersson
; this procedure was ported from Promise's driver Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- Changes since the previous version: - merge the changes needed to make SATAPI work on older chips - define pdc_old_check_atapi_dma(), move more restrictive SATAPI DMA rules check for older

Re: [PATCH 2.6.20-rc3] sata_promise: ATAPI support

2007-01-08 Thread Mikael Pettersson
ated. ATAPI on the 2037x' PATA port is enabled by a followup > > patch for the #promise-sata-pata branch. > > > > Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> > > No objections, minor revision requests follow. > > * general comment: please com

Re: [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-08 Thread Mikael Pettersson
On Sun, 07 Jan 2007 20:47:35 -0500, Jeff Garzik wrote: > Mikael Pettersson wrote: > > @@ -789,8 +789,14 @@ static void pdc_exec_command_mmio(struct > > static int pdc_check_atapi_dma(struct ata_queued_cmd *qc) > > { > > u8 *scsicmd = qc->scsicmd->cmnd; >

Re: [PATCH libata #promise-sata-pata] sata_promise: unbreak 20619

2007-01-08 Thread Mikael Pettersson
On Sun, 07 Jan 2007 20:46:13 -0500, Jeff Garzik wrote: > Given that I agree with your RFC, this means I can drop all these > #promise-sata-pata patches, and kill the #promise-sata-pata branch soon, > right? Yes /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH libata #promise-sata-pata] sata_promise: unbreak 20619

2007-01-08 Thread Mikael Pettersson
On Sun, 07 Jan 2007 20:46:13 -0500, Jeff Garzik wrote: Given that I agree with your RFC, this means I can drop all these #promise-sata-pata patches, and kill the #promise-sata-pata branch soon, right? Yes /Mikael - To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-08 Thread Mikael Pettersson
On Sun, 07 Jan 2007 20:47:35 -0500, Jeff Garzik wrote: Mikael Pettersson wrote: @@ -789,8 +789,14 @@ static void pdc_exec_command_mmio(struct static int pdc_check_atapi_dma(struct ata_queued_cmd *qc) { u8 *scsicmd = qc-scsicmd-cmnd; + struct ata_port *ap = qc-ap; + struct

Re: [PATCH 2.6.20-rc3] sata_promise: ATAPI support

2007-01-08 Thread Mikael Pettersson
port is enabled by a followup patch for the #promise-sata-pata branch. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] No objections, minor revision requests follow. * general comment: please combine the 'make first gen SATAPI work' patch with this one. Will do. +static

Re: [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-07 Thread Mikael Pettersson
On Sat, 6 Jan 2007 21:32:03 +0100 (MET), Mikael Pettersson wrote: >This patch adds ATAPI support for the PATA port on Promise 2037x chips. >It depends on the common sata_promise ATAPI support patch. > >First-generation chips don't support ATAPI on their SATA ports, so >th

Re: [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-07 Thread Mikael Pettersson
On Sat, 6 Jan 2007 21:32:03 +0100 (MET), Mikael Pettersson wrote: This patch adds ATAPI support for the PATA port on Promise 2037x chips. It depends on the common sata_promise ATAPI support patch. First-generation chips don't support ATAPI on their SATA ports, so the patch removes

[PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-06 Thread Mikael Pettersson
the _port_flags[] entries for the SATA ports. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc3/drivers/ata/sata_promise.c.~1~ 2007-01-06 17:10:56.0 +0100 +++ linux-2.6.20-rc3/drivers/ata/sata_promise.c 2007-01-06 17:14:23.0 +0100 @@ -187,7 +187,7 @@

[PATCH libata #promise-sata-pata] sata_promise: unbreak 20619

2007-01-06 Thread Mikael Pettersson
and 1 settings as SATA into the TX4 and TX2plus specific initialisation code. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc3/drivers/ata/sata_promise.c.~1~ 2007-01-06 17:05:29.0 +0100 +++ linux-2.6.20-rc3/drivers/ata/sata_promise.c 2007-01-06

[PATCH 2.6.20-rc3] sata_promise: ATAPI support

2007-01-06 Thread Mikael Pettersson
tch for the #promise-sata-pata branch. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc3/drivers/ata/sata_promise.c.~1~ 2007-01-01 13:32:35.0 +0100 +++ linux-2.6.20-rc3/drivers/ata/sata_promise.c 2007-01-06 15:36:43.0 +0100 @@ -39,6 +39,7 @@ #include

[PATCH 2.6.20-rc3] sata_promise: ATAPI support

2007-01-06 Thread Mikael Pettersson
for the #promise-sata-pata branch. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- linux-2.6.20-rc3/drivers/ata/sata_promise.c.~1~ 2007-01-01 13:32:35.0 +0100 +++ linux-2.6.20-rc3/drivers/ata/sata_promise.c 2007-01-06 15:36:43.0 +0100 @@ -39,6 +39,7 @@ #include linux

[PATCH libata #promise-sata-pata] sata_promise: unbreak 20619

2007-01-06 Thread Mikael Pettersson
and 1 settings as SATA into the TX4 and TX2plus specific initialisation code. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- linux-2.6.20-rc3/drivers/ata/sata_promise.c.~1~ 2007-01-06 17:05:29.0 +0100 +++ linux-2.6.20-rc3/drivers/ata/sata_promise.c 2007-01-06 17:10:56.0

[PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-06 Thread Mikael Pettersson
the _port_flags[] entries for the SATA ports. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- linux-2.6.20-rc3/drivers/ata/sata_promise.c.~1~ 2007-01-06 17:10:56.0 +0100 +++ linux-2.6.20-rc3/drivers/ata/sata_promise.c 2007-01-06 17:14:23.0 +0100 @@ -187,7 +187,7 @@ static

Re: [UPDATED PATCH] fix memory corruption from misinterpreted bad_inode_ops return values

2007-01-04 Thread Mikael Pettersson
On Thu, 04 Jan 2007 11:51:10 -0600, Eric Sandeen wrote: >Also - is it ok to alias a function with one signature to a function with >another signature? NO! Specific cases of type mismatches may work on many machines (say different pointer types as long as they aren't accessed), but in general

Re: [UPDATED PATCH] fix memory corruption from misinterpreted bad_inode_ops return values

2007-01-04 Thread Mikael Pettersson
On Thu, 04 Jan 2007 11:51:10 -0600, Eric Sandeen wrote: Also - is it ok to alias a function with one signature to a function with another signature? NO! Specific cases of type mismatches may work on many machines (say different pointer types as long as they aren't accessed), but in general this

Re: kernel + gcc 4.1 = several problems

2007-01-02 Thread Mikael Pettersson
On Tue, 2 Jan 2007 17:43:00 -0800 (PST), Linus Torvalds wrote: > > The suggestions I've had so far which I have not yet tried: > > > > - Select a different x86 CPU in the config. > > - Unfortunately the C3-2 flags seem to simply tell GCC > > to schedule for

Re: kernel + gcc 4.1 = several problems

2007-01-02 Thread Mikael Pettersson
On Tue, 2 Jan 2007 17:43:00 -0800 (PST), Linus Torvalds wrote: The suggestions I've had so far which I have not yet tried: - Select a different x86 CPU in the config. - Unfortunately the C3-2 flags seem to simply tell GCC to schedule for ppro

Re: [PATCH] preliminary sata_promise ATAPI support

2007-01-01 Thread Mikael Pettersson
On Sat, 30 Dec 2006 18:37:18 +0100 (MET), Mikael Pettersson wrote: >This patch against 2.6.20-rc2 adds partial ATAPI support to >the sata_promise driver. This patch is preliminary and for >review only. ... >As to why CD-writing fails with DMA enabled, I suspect that I >either ne

Re: [PATCH] preliminary sata_promise ATAPI support

2007-01-01 Thread Mikael Pettersson
On Sat, 30 Dec 2006 18:37:18 +0100 (MET), Mikael Pettersson wrote: This patch against 2.6.20-rc2 adds partial ATAPI support to the sata_promise driver. This patch is preliminary and for review only. ... As to why CD-writing fails with DMA enabled, I suspect that I either need to blacklist specific

[PATCH] preliminary sata_promise ATAPI support

2006-12-30 Thread Mikael Pettersson
This patch against 2.6.20-rc2 adds partial ATAPI support to the sata_promise driver. This patch is preliminary and for review only. Current Status: - Tested with PATA optical devices on 20378 and 20575 chips. - Mounting and reading CD/DVD discs in DMA mode works fine. - Using cdrecord to write

[PATCH] preliminary sata_promise ATAPI support

2006-12-30 Thread Mikael Pettersson
This patch against 2.6.20-rc2 adds partial ATAPI support to the sata_promise driver. This patch is preliminary and for review only. Current Status: - Tested with PATA optical devices on 20378 and 20575 chips. - Mounting and reading CD/DVD discs in DMA mode works fine. - Using cdrecord to write

[PATCH 2.6.20-rc2] fix mrproper incompleteness

2006-12-24 Thread Mikael Pettersson
, not a variable or a file, so I don't see how including it in MRPROPER_FILES could have any effect. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.20-rc2/Makefile.~1~ 2006-12-24 14:04:26.0 +0100 +++ linux-2.6.20-rc2/Makefile 2006-12-24 15:31:41.0 +0100 @@ -

[PATCH 2.6.20-rc2] fix mrproper incompleteness

2006-12-24 Thread Mikael Pettersson
, not a variable or a file, so I don't see how including it in MRPROPER_FILES could have any effect. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- linux-2.6.20-rc2/Makefile.~1~ 2006-12-24 14:04:26.0 +0100 +++ linux-2.6.20-rc2/Makefile 2006-12-24 15:31:41.0 +0100 @@ -1040,7

Re: SATA300 TX4 + WD2500KS = status=0x50 { DriveReady SeekComplete }

2006-12-19 Thread Mikael Pettersson
(cc: linux-ide added) On Tue, 19 Dec 2006 12:26:07 +0100, Roel Teuwen wrote: > I am seeing the exact same 'problem'. I have 4 WDC WD2500KS-00MJB0 > drives connected to a promise SATA300 TX4. The messages have been > flooding syslog since the drives were installed. Running 2.6.18 or > 2.6.19

Re: SATA300 TX4 + WD2500KS = status=0x50 { DriveReady SeekComplete }

2006-12-19 Thread Mikael Pettersson
(cc: linux-ide added) On Tue, 19 Dec 2006 12:26:07 +0100, Roel Teuwen wrote: I am seeing the exact same 'problem'. I have 4 WDC WD2500KS-00MJB0 drives connected to a promise SATA300 TX4. The messages have been flooding syslog since the drives were installed. Running 2.6.18 or 2.6.19 vanilla

Re: OOPS: deref 0x14 at pdc_port_start+0x82 [Was: 2.6.20-rc1-mm1]

2006-12-15 Thread Mikael Pettersson
On Fri, 15 Dec 2006 11:24:12 -0800, Andrew Morton wrote: >On Fri, 15 Dec 2006 15:45:55 +0059 >Jiri Slaby <[EMAIL PROTECTED]> wrote: > >> Andrew Morton wrote: >> > Temporarily at >> > >> >http://userweb.kernel.org/~akpm/2.6.20-rc1-mm1/ >> > >> > Will appear later at >> > >> > >> >

Re: OOPS: deref 0x14 at pdc_port_start+0x82 [Was: 2.6.20-rc1-mm1]

2006-12-15 Thread Mikael Pettersson
On Fri, 15 Dec 2006 11:24:12 -0800, Andrew Morton wrote: On Fri, 15 Dec 2006 15:45:55 +0059 Jiri Slaby [EMAIL PROTECTED] wrote: Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.20-rc1-mm1/ Will appear later at

[PATCH 2.6.19-git7] sata_promise: new EH conversion, take 2

2006-12-06 Thread Mikael Pettersson
emoves pdc_sata_phy_reset() while #promise-sata-pata modifies it. The correct patch resolution is to remove the function. Tested on 2037x and 2057x chips, with PATA patches on top and disks on both SATA and PATA ports. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.19-git7

Re: [PATCH] make sata_promise PATA ports work

2006-12-06 Thread Mikael Pettersson
On Mon, 4 Dec 2006 12:47:37 -0700, Erik Andersen wrote: >This patch vs 2.6.19, based on the not-actually-working-for-me >code lurking in libata-dev.git#promise-sata-pata, makes the PATA >ports on my promise sata card actually work. Since the plan as >checked into git, is to drive the PATA ports

Re: Change x86 prefix order

2006-12-06 Thread Mikael Pettersson
On Wed, 6 Dec 2006 09:00:30 -0800, H. J. Lu wrote: >On Wed, Dec 06, 2006 at 08:43:17AM -0800, Randy Dunlap wrote: >> On Tue, 5 Dec 2006 23:00:14 -0800 H. J. Lu wrote: >> >> > On x86, the order of prefix SEG_PREFIX, ADDR_PREFIX, DATA_PREFIX and >> > LOCKREP_PREFIX isn't fixed. Currently, gas

[PATCH 2.6.19] sata_promise: cleanups, take 2

2006-12-06 Thread Mikael Pettersson
submission: rebased on libata-dev #upstream, cleaned up hotplug_offset computation based on Tejun's comments, expanded hotplug_offset removal rationale. This patch does not depend on the pending new EH conversion patch. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> --- linux-2.6.19/driv

Re: [PATCH 2.6.19 2/3] sata_promise: new EH conversion

2006-12-06 Thread Mikael Pettersson
On Sun, 03 Dec 2006 22:00:42 +0900, Tejun Heo wrote: >Mikael Pettersson wrote: >> +} >> + >> +static void pdc_error_handler(struct ata_port *ap) >> +{ >> +struct ata_eh_context *ehc = >eh_context; >> +ata_reset_fn_t hardreset; >> + >> +

Re: [PATCH 2.6.19 3/3] sata_promise: cleanups

2006-12-06 Thread Mikael Pettersson
On Sun, 03 Dec 2006 22:05:51 +0900, Tejun Heo wrote: >Mikael Pettersson wrote: >> This patch performs two simple cleanups of sata_promise. >> >> * Remove board_20771 and map device id 0x3577 to board_2057x. >> After the recent corrections for SATAII chips, board_2077

Re: [PATCH 2.6.19 2/3] sata_promise: new EH conversion

2006-12-06 Thread Mikael Pettersson
On Sun, 03 Dec 2006 22:19:35 +0900, Tejun Heo wrote: >Jeff Garzik wrote: >> Tejun Heo wrote: >>> Hello, Mikael. >>> >>> Thanks for doing this. >>> >>> Mikael Pettersson wrote: >>> [--snip--] >>>> +static void pdc_freez

Re: [PATCH 2.6.19 2/3] sata_promise: new EH conversion

2006-12-06 Thread Mikael Pettersson
On Sun, 03 Dec 2006 22:19:35 +0900, Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Hello, Mikael. Thanks for doing this. Mikael Pettersson wrote: [--snip--] +static void pdc_freeze(struct ata_port *ap) +{ +void __iomem *mmio = (void __iomem *) ap-ioaddr.cmd_addr; +u32 tmp

Re: [PATCH 2.6.19 3/3] sata_promise: cleanups

2006-12-06 Thread Mikael Pettersson
On Sun, 03 Dec 2006 22:05:51 +0900, Tejun Heo wrote: Mikael Pettersson wrote: This patch performs two simple cleanups of sata_promise. * Remove board_20771 and map device id 0x3577 to board_2057x. After the recent corrections for SATAII chips, board_20771 and board_2057x were equivalent

Re: [PATCH 2.6.19 2/3] sata_promise: new EH conversion

2006-12-06 Thread Mikael Pettersson
On Sun, 03 Dec 2006 22:00:42 +0900, Tejun Heo wrote: Mikael Pettersson wrote: +} + +static void pdc_error_handler(struct ata_port *ap) +{ +struct ata_eh_context *ehc = ap-eh_context; +ata_reset_fn_t hardreset; + +/* stop DMA, mask IRQ, don't clobber anything else

[PATCH 2.6.19] sata_promise: cleanups, take 2

2006-12-06 Thread Mikael Pettersson
-dev #upstream, cleaned up hotplug_offset computation based on Tejun's comments, expanded hotplug_offset removal rationale. This patch does not depend on the pending new EH conversion patch. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- linux-2.6.19/drivers/ata/sata_promise.c.~1~ 2006-12

Re: [PATCH] make sata_promise PATA ports work

2006-12-06 Thread Mikael Pettersson
On Mon, 4 Dec 2006 12:47:37 -0700, Erik Andersen wrote: This patch vs 2.6.19, based on the not-actually-working-for-me code lurking in libata-dev.git#promise-sata-pata, makes the PATA ports on my promise sata card actually work. Since the plan as checked into git, is to drive the PATA ports as if

[PATCH 2.6.19-git7] sata_promise: new EH conversion, take 2

2006-12-06 Thread Mikael Pettersson
pdc_sata_phy_reset() while #promise-sata-pata modifies it. The correct patch resolution is to remove the function. Tested on 2037x and 2057x chips, with PATA patches on top and disks on both SATA and PATA ports. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] --- linux-2.6.19-git7/drivers/ata

Re: Change x86 prefix order

2006-12-06 Thread Mikael Pettersson
On Wed, 6 Dec 2006 09:00:30 -0800, H. J. Lu wrote: On Wed, Dec 06, 2006 at 08:43:17AM -0800, Randy Dunlap wrote: On Tue, 5 Dec 2006 23:00:14 -0800 H. J. Lu wrote: On x86, the order of prefix SEG_PREFIX, ADDR_PREFIX, DATA_PREFIX and LOCKREP_PREFIX isn't fixed. Currently, gas generates

[PATCH 2.6.19 3/3] sata_promise: cleanups

2006-12-01 Thread Mikael Pettersson
LAG_GEN_II to compute hotplug_offset in pdc_host_init(). This patch depends on the sata_promise SATAII updates patch I sent recently. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> diff -rupN linux-2.6.19.sata_promise-3-new_EH/drivers/ata/sata_promise.c linux-2.6.19.sata_promise-4-clea

[PATCH 2.6.19 2/3] sata_promise: new EH conversion

2006-12-01 Thread Mikael Pettersson
I have no documentation for the PATA-only 20619, I let the driver continue using old-style EH for it (easily changed). This patch is intended to be applied on top of the sata_promise SATAII updates patch I sent recently, but will apply and work even if that patch has not been applied. Signed-off-by:

[PATCH 2.6.19 1/3] sata_promise: PHYMODE4 fixup

2006-12-01 Thread Mikael Pettersson
just like this patch does. This patch depends on the sata_promise SATAII updates patch I sent recently. Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]> diff -rupN linux-2.6.19.sata_promise-1-genII-fixes/drivers/ata/sata_promise.c linux-2.6.19.sata_promise-2-PHYMODE4-fixup/drivers/at

[PATCH 2.6.19 1/3] sata_promise: PHYMODE4 fixup

2006-12-01 Thread Mikael Pettersson
this patch does. This patch depends on the sata_promise SATAII updates patch I sent recently. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] diff -rupN linux-2.6.19.sata_promise-1-genII-fixes/drivers/ata/sata_promise.c linux-2.6.19.sata_promise-2-PHYMODE4-fixup/drivers/ata/sata_promise.c --- linux

[PATCH 2.6.19 2/3] sata_promise: new EH conversion

2006-12-01 Thread Mikael Pettersson
no documentation for the PATA-only 20619, I let the driver continue using old-style EH for it (easily changed). This patch is intended to be applied on top of the sata_promise SATAII updates patch I sent recently, but will apply and work even if that patch has not been applied. Signed-off-by: Mikael Pettersson

[PATCH 2.6.19 3/3] sata_promise: cleanups

2006-12-01 Thread Mikael Pettersson
to compute hotplug_offset in pdc_host_init(). This patch depends on the sata_promise SATAII updates patch I sent recently. Signed-off-by: Mikael Pettersson [EMAIL PROTECTED] diff -rupN linux-2.6.19.sata_promise-3-new_EH/drivers/ata/sata_promise.c linux-2.6.19.sata_promise-4-cleanups/drivers/ata

Re: [PATCH] emit logging when a process receives a fatal signal

2006-11-18 Thread Mikael Pettersson
On Sat, 18 Nov 2006 02:09:46 +0100, Folkert van Heusden wrote: >I found that sometimes processes disappear on some heavily used system >of mine without any logging. So I've written a patch against 2.6.18.2 >which emits logging when a process emits a fatal signal. > >Signed-off-by: Folkert van

Re: [PATCH] emit logging when a process receives a fatal signal

2006-11-18 Thread Mikael Pettersson
On Sat, 18 Nov 2006 02:09:46 +0100, Folkert van Heusden wrote: I found that sometimes processes disappear on some heavily used system of mine without any logging. So I've written a patch against 2.6.18.2 which emits logging when a process emits a fatal signal. Signed-off-by: Folkert van Heusden

<    1   2   3   4   5   6   7   8   9   >