Re: [PATCH 077/141] dm raid: Fix fall-through warnings for Clang

2021-04-20 Thread Mike Snitzer
On Tue, Apr 20 2021 at 4:15pm -0400, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 11/20/20 12:35, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly

Re: [PATCH v8 0/4] block device interposer

2021-04-09 Thread Mike Snitzer
On Fri, Apr 09 2021 at 7:48am -0400, Sergei Shtepa wrote: > I think I'm ready to suggest the next version of block device interposer > (blk_interposer). It allows to redirect bio requests to other block > devices. > > In this series of patches, I reviewed the process of attaching and >

Re: md/dm-mpath: check whether all pgpaths have same uuid in multipath_ctr()

2021-03-25 Thread Mike Snitzer
On Wed, Mar 24 2021 at 9:21pm -0400, Zhiqiang Liu wrote: > > > On 2021/3/22 22:22, Mike Snitzer wrote: > > On Mon, Mar 22 2021 at 4:11am -0400, > > Christoph Hellwig wrote: > > > >> On Sat, Mar 20, 2021 at 03:19:23PM +0800, Zhiqiang Liu wrote: > >

Re: md/dm-mpath: check whether all pgpaths have same uuid in multipath_ctr()

2021-03-22 Thread Mike Snitzer
On Mon, Mar 22 2021 at 4:11am -0400, Christoph Hellwig wrote: > On Sat, Mar 20, 2021 at 03:19:23PM +0800, Zhiqiang Liu wrote: > > From: Zhiqiang Liu > > > > When we make IO stress test on multipath device, there will > > be a metadata err because of wrong path. In the test, we > > concurrent

Re: [PATCH v7 2/3] block: add bdev_interposer

2021-03-17 Thread Mike Snitzer
On Wed, Mar 17 2021 at 2:14pm -0400, Sergei Shtepa wrote: > The 03/17/2021 18:04, Mike Snitzer wrote: > > On Wed, Mar 17 2021 at 8:22am -0400, > > Sergei Shtepa wrote: > > > > > The 03/17/2021 06:03, Ming Lei wrote: > > > > On Tue, Mar 16, 202

Re: [PATCH v7 2/3] block: add bdev_interposer

2021-03-17 Thread Mike Snitzer
On Tue, Mar 16 2021 at 11:03pm -0400, Ming Lei wrote: > On Tue, Mar 16, 2021 at 07:35:44PM +0300, Sergei Shtepa wrote: > > The 03/16/2021 11:09, Ming Lei wrote: > > > On Fri, Mar 12, 2021 at 06:44:54PM +0300, Sergei Shtepa wrote: > > > > bdev_interposer allows to redirect bio requests to another

Re: [PATCH v7 2/3] block: add bdev_interposer

2021-03-17 Thread Mike Snitzer
On Wed, Mar 17 2021 at 8:22am -0400, Sergei Shtepa wrote: > The 03/17/2021 06:03, Ming Lei wrote: > > On Tue, Mar 16, 2021 at 07:35:44PM +0300, Sergei Shtepa wrote: > > > The 03/16/2021 11:09, Ming Lei wrote: > > > > On Fri, Mar 12, 2021 at 06:44:54PM +0300, Sergei Shtepa wrote: > > > > >

Re: [PATCH v7 1/3] block: add blk_mq_is_queue_frozen()

2021-03-12 Thread Mike Snitzer
On Fri, Mar 12 2021 at 10:44am -0500, Sergei Shtepa wrote: > blk_mq_is_queue_frozen() allow to assert that the queue is frozen. > > Signed-off-by: Sergei Shtepa > --- > block/blk-mq.c | 13 + > include/linux/blk-mq.h | 1 + > 2 files changed, 14 insertions(+) > > diff

Re: [PATCH v7 3/3] dm: add DM_INTERPOSED_FLAG

2021-03-12 Thread Mike Snitzer
On Fri, Mar 12 2021 at 10:44am -0500, Sergei Shtepa wrote: > DM_INTERPOSED_FLAG allow to create DM targets on "the fly". > Underlying block device opens without a flag FMODE_EXCL. > DM target receives bio from the original device via > bdev_interposer. > > Signed-off-by: Sergei Shtepa > --- >

Re: dm: remove unneeded variable 'sz'

2021-03-09 Thread Mike Snitzer
On Tue, Mar 09 2021 at 4:32am -0500, Yang Li wrote: > Fix the following coccicheck warning: > ./drivers/md/dm-ps-service-time.c:85:10-12: Unneeded variable: "sz". > Return "0" on line 105 > > Reported-by: Abaci Robot > Signed-off-by: Yang Li This type of change gets proposed regaularly.

Re: [PATCH v5 5/6] dm: add 'noexcl' option for dm-linear

2021-02-15 Thread Mike Snitzer
On Mon, Feb 15 2021 at 5:34am -0500, Sergei Shtepa wrote: > The 02/12/2021 19:06, Mike Snitzer wrote: > > On Fri, Feb 12 2021 at 6:34am -0500, > > Sergei Shtepa wrote: > > > > > The 02/11/2021 20:51, Mike Snitzer wrote: > > > > On Tue, Feb 09 20

Re: [PATCH v5 4/6] dm: new ioctl DM_DEV_REMAP_CMD

2021-02-12 Thread Mike Snitzer
On Tue, Feb 09 2021 at 9:30am -0500, Sergei Shtepa wrote: > New ioctl DM_DEV_REMAP_CMD allow to remap bio requests > from regular block device to dm device. I really dislike the (ab)use of "REMAP" for this. DM is and always has been about remapping IO. Would prefer DM_DEV_INTERPOSE_CMD

Re: [PATCH v5 5/6] dm: add 'noexcl' option for dm-linear

2021-02-12 Thread Mike Snitzer
On Fri, Feb 12 2021 at 6:34am -0500, Sergei Shtepa wrote: > The 02/11/2021 20:51, Mike Snitzer wrote: > > On Tue, Feb 09 2021 at 9:30am -0500, > > Sergei Shtepa wrote: > > > > > The 'noexcl' option allow to open underlying block-device > > > with

Re: [PATCH v4 0/5] add support for inline encryption to device mapper

2021-02-11 Thread Mike Snitzer
On Thu, Feb 11 2021 at 6:01pm -0500, Satya Tangirala wrote: > On Wed, Feb 10, 2021 at 12:59:59PM -0700, Jens Axboe wrote: > > On 2/10/21 12:33 PM, Mike Snitzer wrote: > > > On Mon, Feb 01 2021 at 12:10am -0500, > > > Satya Tangirala wrote: > > > &

Re: [PATCH v5 5/6] dm: add 'noexcl' option for dm-linear

2021-02-11 Thread Mike Snitzer
On Tue, Feb 09 2021 at 9:30am -0500, Sergei Shtepa wrote: > The 'noexcl' option allow to open underlying block-device > without FMODE_EXCL. > > Signed-off-by: Sergei Shtepa > --- > drivers/md/dm-linear.c| 14 +- > drivers/md/dm-table.c | 14 -- >

Re: linux-next: build failure after merge of the device-mapper tree

2021-02-11 Thread Mike Snitzer
On Wed, Feb 10 2021 at 10:36pm -0500, Stephen Rothwell wrote: > Hi all, > > After merging the device-mapper tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > drivers/md/dm-linear.c:234:3: error: 'struct target_type' has no member named > 'report_zones' > 234 |

Re: [PATCH v4 0/5] add support for inline encryption to device mapper

2021-02-10 Thread Mike Snitzer
On Mon, Feb 01 2021 at 12:10am -0500, Satya Tangirala wrote: > This patch series adds support for inline encryption to the device mapper. > > Patch 1 introduces the "passthrough" keyslot manager. > > The regular keyslot manager is designed for inline encryption hardware that > have only a

Re: [PATCH v4 2/6] block: add blk_interposer

2021-02-03 Thread Mike Snitzer
On Wed, Feb 03 2021 at 10:53am -0500, Sergei Shtepa wrote: > blk_interposer allows to intercept bio requests, remap bio to another devices > or add new bios. > > Signed-off-by: Sergei Shtepa > --- > block/bio.c | 2 + > block/blk-core.c | 33 >

Re: [PATCH v4 3/6] block: add blk_mq_is_queue_frozen()

2021-02-03 Thread Mike Snitzer
On Wed, Feb 03 2021 at 10:53am -0500, Sergei Shtepa wrote: > blk_mq_is_queue_frozen() allow to assert that the queue is frozen. > > Signed-off-by: Sergei Shtepa > --- > block/blk-mq.c | 13 + > include/linux/blk-mq.h | 1 + > 2 files changed, 14 insertions(+) > > diff

Re: [PATCH 1/2] dm crypt: replaced #if defined with IS_ENABLED

2021-02-02 Thread Mike Snitzer
On Fri, Jan 22 2021 at 3:43am -0500, Ahmad Fatoum wrote: > IS_ENABLED(CONFIG_ENCRYPTED_KEYS) is true whether the option is built-in > or a module, so use it instead of #if defined checking for each > separately. > > The other #if was to avoid a static function defined, but unused > warning. As

Re: [RFC PATCH 00/37] block: introduce bio_init_fields()

2021-01-19 Thread Mike Snitzer
field to set would create a cascade of churn throughout kernel (and invariably many callers won't need the new field initialized, so you keep passing 0 for more and more fields). Nacked-by: Mike Snitzer

Re: [PATCH v3 5/6] dm: Verify inline encryption capabilities of new table when it is loaded

2021-01-14 Thread Mike Snitzer
On Tue, Dec 29 2020 at 3:55am -0500, Satya Tangirala wrote: > DM only allows the table to be swapped if the new table's inline encryption > capabilities are a superset of the old table's. We only check that this > constraint is true when the table is actually swapped in (in > dm_swap_table()).

Re: [PATCH v3 3/6] dm: add support for passing through inline crypto support

2021-01-14 Thread Mike Snitzer
On Tue, Dec 29 2020 at 3:55am -0500, Satya Tangirala wrote: > Update the device-mapper core to support exposing the inline crypto > support of the underlying device(s) through the device-mapper device. > > This works by creating a "passthrough keyslot manager" for the dm > device, which

Re: [PATCH v3 2/6] block: keyslot-manager: Introduce functions for device mapper support

2021-01-14 Thread Mike Snitzer
On Tue, Dec 29 2020 at 3:55am -0500, Satya Tangirala wrote: > Introduce blk_ksm_update_capabilities() to update the capabilities of > a keyslot manager (ksm) in-place. The pointer to a ksm in a device's > request queue may not be easily replaced, because upper layers like > the filesystem might

Re: dm snap : add sanity checks to snapshot_ctr

2021-01-04 Thread Mike Snitzer
On Fri, Dec 25 2020 at 1:48am -0500, Defang Bo wrote: > Similar to commit<70de2cbd>,there should be a check for argc and argv to > prevent Null pointer dereferencing > when the dm_get_device invoked twice on the same device path with differnt > mode. > > Signed-off-by: Defang Bo > --- >

DM's filesystem lookup in dm_get_dev_t() [was: Re: linux-next: manual merge of the device-mapper tree with Linus' tree]

2020-12-22 Thread Mike Snitzer
[added linux-block and dm-devel, if someone replies to this email to continue "proper discussion" _please_ at least drop sfr and linux-next from Cc] On Tue, Dec 22 2020 at 8:15am -0500, Christoph Hellwig wrote: > Mike, Hannes, > > I think this patch is rather harmful. Why does device mapper

Re: [PATCH v1 0/5] dm: dm-user: New target that proxies BIOs to userspace

2020-12-22 Thread Mike Snitzer
On Tue, Dec 22 2020 at 8:32am -0500, Christoph Hellwig wrote: > On Mon, Dec 14, 2020 at 07:00:57PM -0800, Palmer Dabbelt wrote: > > I haven't gotten a whole lot of feedback, so I'm inclined to at least have > > some > > reasonable performance numbers before bothering with a v2. > > FYI, my

Re: Linux 5.10

2020-12-14 Thread Mike Snitzer
On Mon, Dec 14 2020 at 11:44am -0500, Greg KH wrote: > On Mon, Dec 14, 2020 at 11:02:47AM -0500, Mike Snitzer wrote: > > On Mon, Dec 14 2020 at 12:52am -0500, > > Greg KH wrote: > > > > > On Mon, Dec 14, 2020 at 12:31:47AM -0500, Dave Jones wrote: > > &g

Re: Linux 5.10

2020-12-14 Thread Mike Snitzer
On Mon, Dec 14 2020 at 11:02am -0500, Mike Snitzer wrote: > On Mon, Dec 14 2020 at 12:52am -0500, > Greg KH wrote: > > > On Mon, Dec 14, 2020 at 12:31:47AM -0500, Dave Jones wrote: > > > On Sun, Dec 13, 2020 at 03:03:29PM -0800, Linus Torvalds wrote: > > >

Re: Linux 5.10

2020-12-14 Thread Mike Snitzer
retty much always wish that the last week was even calmer than it > > > was, and that's true here too. There's a fair amount of fixes in here, > > > including a few last-minute reverts for things that didn't get fixed, > > > but nothing makes me go "we need anoth

Re: [PATCH 0/3] block: blk_interposer - Block Layer Interposer

2020-12-11 Thread Mike Snitzer
On Thu, Dec 10 2020 at 11:32am -0500, Mike Snitzer wrote: > On Thu, Dec 10 2020 at 9:58am -0500, > Sergei Shtepa wrote: > > > The 12/09/2020 16:51, Mike Snitzer wrote: > > > On Wed, Dec 09 2020 at 8:01am -0500, > > > Sergei Shtepa wrote: > > &g

Re: [PATCH 0/3] block: blk_interposer - Block Layer Interposer

2020-12-10 Thread Mike Snitzer
On Thu, Dec 10 2020 at 9:58am -0500, Sergei Shtepa wrote: > The 12/09/2020 16:51, Mike Snitzer wrote: > > On Wed, Dec 09 2020 at 8:01am -0500, > > Sergei Shtepa wrote: > > > > > Hi all. > > > > > > I try to suggest the Block Layer Inte

Re: [PATCH 2/3] block: blk_interposer - sample

2020-12-10 Thread Mike Snitzer
On Thu, Dec 10 2020 at 10:54am -0500, Sergei Shtepa wrote: > The 12/09/2020 17:36, Mike Snitzer wrote: > > On Wed, Dec 09 2020 at 8:01am -0500, > > Sergei Shtepa wrote: > > > > > This sample demonstrates how to use blk_interposer. > > > It show how to

Re: Revert "dm raid: remove unnecessary discard limits for raid10"

2020-12-09 Thread Mike Snitzer
t; > [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1907262/ > Cc: Matthew Ruffell > Cc: Xiao Ni > Cc: Mike Snitzer > Signed-off-by: Song Liu > --- > drivers/md/dm-raid.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/md/dm-raid.c

Re: Revert "dm raid: remove unnecessary discard limits for raid10"

2020-12-09 Thread Mike Snitzer
t; > [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1907262/ > Cc: Matthew Ruffell > Cc: Xiao Ni > Cc: Mike Snitzer > Signed-off-by: Song Liu If you're reverting all the MD code that enabled this DM change, then obviously the DM change must be reverted too. But please do _no

Re: [PATCH 2/3] block: blk_interposer - sample

2020-12-09 Thread Mike Snitzer
> + /* > + * And while the queue is stopped, we can do something specific for our > module. > + */ > + pr_info("Block device interposer detached successfully.\n"); > + > +out: > + /* > + * Resume disks queue processing. > + */ > + blk_mq_unquiesce_queue(disk->queue); > + blk_mq_unfreeze_queue(disk->queue); > + > + return ret; > +} This attach and detach code needs to be elevated out of samples so that any future consumer of blk_interposer doesn't reinvent it. It is far too fundamental. The way you've proposed this be merged is very much unacceptable. Nacked-by: Mike Snitzer

Re: [PATCH 0/3] block: blk_interposer - Block Layer Interposer

2020-12-09 Thread Mike Snitzer
On Wed, Dec 09 2020 at 8:01am -0500, Sergei Shtepa wrote: > Hi all. > > I try to suggest the Block Layer Interposer (blk_interposer) again. > It`s allows to intercept bio requests, remap bio to another devices > or add new bios. > > Initially, blk_interposer was designed to be compatible with

Re: md: dm-writeback: add __noreturn to BUG-ging function

2020-11-20 Thread Mike Snitzer
On Wed, Nov 18 2020 at 4:24pm -0500, Mikulas Patocka wrote: > > > On Wed, 18 Nov 2020, Mike Snitzer wrote: > > > On Wed, Nov 18 2020 at 10:49am -0500, > > Mike Snitzer wrote: > > > > > I don't think my suggestion will help.. given it'd still leave

Re: linux-next: Signed-off-by missing for commit in the device-mapper tree

2020-11-18 Thread Mike Snitzer
On Wed, Nov 18 2020 at 3:47pm -0500, Stephen Rothwell wrote: > Hi all, > > Commit > > a1e4865b4dda ("dm writecache: remove BUG() and fail gracefully instead") > > is missing a Signed-off-by from its author. Thanks, because I went in a different direction on the code changes I adjusted

Re: md: dm-writeback: add __noreturn to BUG-ging function

2020-11-18 Thread Mike Snitzer
On Wed, Nov 18 2020 at 10:49am -0500, Mike Snitzer wrote: > I don't think my suggestion will help.. given it'd still leave > persistent_memory_claim() without a return statement. > > Think it worthwhile to just add a dummy 'return 0;' after the BUG(). Decided to go with this

Re: md: dm-writeback: add __noreturn to BUG-ging function

2020-11-18 Thread Mike Snitzer
On Tue, Nov 17 2020 at 11:31am -0500, Mike Snitzer wrote: > On Mon, Nov 16 2020 at 6:00pm -0500, > Randy Dunlap wrote: > > > On 11/15/20 11:30 PM, Christian Borntraeger wrote: > > > > > > > > > On 13.11.20 23:52, Randy Dunlap wrote: > > >

Re: md: dm-writeback: add __noreturn to BUG-ging function

2020-11-17 Thread Mike Snitzer
On Mon, Nov 16 2020 at 6:00pm -0500, Randy Dunlap wrote: > On 11/15/20 11:30 PM, Christian Borntraeger wrote: > > > > > > On 13.11.20 23:52, Randy Dunlap wrote: > >> Building on arch/s390/ flags this as an error, so add the > >> __noreturn attribute modifier to prevent the build error. > >> >

Re: [PATCH AUTOSEL 5.9 089/147] dm: change max_io_len() to use blk_max_size_offset()

2020-10-27 Thread Mike Snitzer
On Mon, Oct 26 2020 at 7:48pm -0400, Sasha Levin wrote: > From: Mike Snitzer > > [ Upstream commit 5091cdec56faeaefa79de4b6cb3c3c55e50d1ac3 ] > > Using blk_max_size_offset() enables DM core's splitting to impose > ti->max_io_len (via q->limits.chunk_sectors) and also

Re: [PATCH v2] dm verity: Add support for signature verification with 2nd keyring

2020-10-23 Thread Mike Snitzer
> >> On 16/10/2020 10:49, Mickaël Salaün wrote: > >>> On 16/10/2020 10:29, Mickaël Salaün wrote: > >>>> > >>>> On 15/10/2020 18:52, Mike Snitzer wrote: > >>>>> Can you please explain why you've decided to make this a Kconfig CON

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-22 Thread Mike Snitzer
On Wed, Oct 21, 2020 at 5:04 AM Sergei Shtepa wrote: > > Hello everyone! Requesting for your comments and suggestions. > > # blk-filter > > Block layer filter allows to intercept BIO requests to a block device. > > Interception is performed at the very beginning of the BIO request > processing,

Re: [PATCH 0/2] block layer filter and block device snapshot module

2020-10-22 Thread Mike Snitzer
On Thu, Oct 22, 2020 at 11:14 AM Darrick J. Wong wrote: > > On Thu, Oct 22, 2020 at 04:52:13PM +0300, Sergei Shtepa wrote: > > The 10/22/2020 13:28, Damien Le Moal wrote: > > > On 2020/10/22 18:43, Sergei Shtepa wrote: > > > > > > > > Maybe, but the problem is that I can't imagine how to

Re: [EXT] Re: [PATCH v2 00/22] add Object Storage Media Pool (mpool)

2020-10-21 Thread Mike Snitzer
Hey Dan, On Fri, Oct 16, 2020 at 6:38 PM Dan Williams wrote: > > On Fri, Oct 16, 2020 at 2:59 PM Nabeel Meeramohideen Mohamed > (nmeeramohide) wrote: > > > (5) Representing an mpool as a /dev/mpool/ device file provides > > a > > convenient mechanism for controlling access to and managing the

Re: [PATCH v2] dm verity: Add support for signature verification with 2nd keyring

2020-10-15 Thread Mike Snitzer
ady use the secondary trusted > keyring. > > Cc: Alasdair Kergon > Cc: Andrew Morton > Cc: Jarkko Sakkinen > Cc: Jaskaran Khurana > Cc: Mike Snitzer > Cc: Milan Broz > Signed-off-by: Mickaël Salaün > --- > > Previous version: > https://lore.kernel.org/l

Re: [PATCH 2/3] dm: add support for passing through inline crypto support

2020-09-24 Thread Mike Snitzer
On Thu, Sep 24 2020 at 11:45am -0400, Eric Biggers wrote: > On Thu, Sep 24, 2020 at 09:46:49AM -0400, Mike Snitzer wrote: > > > > Can you help me better understand the expected consumer of this code? > > > > If you have something _real_ please be explicit. It makes ju

Re: [PATCH 07/13] block: lift setting the readahead size into the block layer

2020-09-24 Thread Mike Snitzer
h Hellwig > Acked-by: Coly Li > Reviewed-by: Johannes Thumshirn Thanks for adding blk_queue_update_readahead() Reviewed-by: Mike Snitzer

Re: [PATCH 2/3] dm: add support for passing through inline crypto support

2020-09-24 Thread Mike Snitzer
On Thu, Sep 24 2020 at 3:38am -0400, Satya Tangirala wrote: > On Wed, Sep 23, 2020 at 09:21:03PM -0400, Mike Snitzer wrote: > > On Wed, Sep 09 2020 at 7:44pm -0400, > > Satya Tangirala wrote: > > > > > From: Eric Biggers > > > > > > U

Re: [PATCH 2/3] dm: add support for passing through inline crypto support

2020-09-24 Thread Mike Snitzer
On Thu, Sep 24 2020 at 3:17am -0400, Satya Tangirala wrote: > On Wed, Sep 23, 2020 at 09:14:39PM -0400, Mike Snitzer wrote: > > On Mon, Sep 21 2020 at 8:32pm -0400, > > Eric Biggers wrote: > > > > > On Wed, Sep 09, 2020 at 11:44:21PM +, Satya Tangirala wro

Re: [PATCH 2/3] dm: add support for passing through inline crypto support

2020-09-24 Thread Mike Snitzer
On Thu, Sep 24 2020 at 3:48am -0400, Satya Tangirala wrote: > On Wed, Sep 23, 2020 at 09:21:03PM -0400, Mike Snitzer wrote: > > On Wed, Sep 09 2020 at 7:44pm -0400, > > Satya Tangirala wrote: > > > > > From: Eric Biggers > > > > > > U

Re: [PATCH 2/3] dm: add support for passing through inline crypto support

2020-09-23 Thread Mike Snitzer
On Wed, Sep 09 2020 at 7:44pm -0400, Satya Tangirala wrote: > From: Eric Biggers > > Update the device-mapper core to support exposing the inline crypto > support of the underlying device(s) through the device-mapper device. > > This works by creating a "passthrough keyslot manager" for the

Re: [PATCH 2/3] dm: add support for passing through inline crypto support

2020-09-23 Thread Mike Snitzer
On Mon, Sep 21 2020 at 8:32pm -0400, Eric Biggers wrote: > On Wed, Sep 09, 2020 at 11:44:21PM +, Satya Tangirala wrote: > > From: Eric Biggers > > > > Update the device-mapper core to support exposing the inline crypto > > support of the underlying device(s) through the device-mapper

Re: [PATCH 6/6] mm: Add memalloc_nowait

2020-09-23 Thread Mike Snitzer
On Thu, Jun 25 2020 at 7:31am -0400, Matthew Wilcox (Oracle) wrote: > Similar to memalloc_noio() and memalloc_nofs(), memalloc_nowait() > guarantees we will not sleep to reclaim memory. Use it to simplify > dm-bufio's allocations. > > Signed-off-by: Matthew Wilcox (Oracle) > --- >

Re: [PATCH 06/14] block: lift setting the readahead size into the block layer

2020-09-10 Thread Mike Snitzer
On Thu, Sep 10 2020 at 5:28am -0400, Christoph Hellwig wrote: > On Wed, Sep 02, 2020 at 12:20:07PM -0400, Mike Snitzer wrote: > > On Wed, Sep 02 2020 at 11:11am -0400, > > Christoph Hellwig wrote: > > > > > On Wed, Aug 26, 2020 at 06:07:38PM -0400, Mike Snitzer

Re: [PATCH 06/14] block: lift setting the readahead size into the block layer

2020-09-02 Thread Mike Snitzer
On Wed, Sep 02 2020 at 11:11am -0400, Christoph Hellwig wrote: > On Wed, Aug 26, 2020 at 06:07:38PM -0400, Mike Snitzer wrote: > > On Sun, Jul 26 2020 at 11:03am -0400, > > Christoph Hellwig wrote: > > > > > Drivers shouldn't really mess with the readahead size,

Re: [PATCH 06/14] block: lift setting the readahead size into the block layer

2020-08-26 Thread Mike Snitzer
On Sun, Jul 26 2020 at 11:03am -0400, Christoph Hellwig wrote: > Drivers shouldn't really mess with the readahead size, as that is a VM > concept. Instead set it based on the optimal I/O size by lifting the > algorithm from the md driver when registering the disk. Also set > bdi->io_pages

Re: drivers/md/dm-mpath.c:524 multipath_clone_and_map() error: double unlocked 'm->lock' (orig line 516)

2020-08-08 Thread Mike Snitzer
On Sat, Aug 08 2020 at 8:10am -0400, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 449dc8c97089a6e09fb2dac4d92b1b7ac0eb7c1e > commit: 374117ad4736c5a4f8012cfe59fc07d9d58191d5 dm mpath: use double checked > locking in

fixing 4.14-stable's broken DM cache writethrough support [was: Re: [(resend) PATCH v3: {linux-4.14.y} ] dm cache: submit writethrough writes in parallel to origin and cache]

2020-08-05 Thread Mike Snitzer
On Wed, Aug 05 2020 at 10:32am -0400, Greg KH wrote: > On Tue, Aug 04, 2020 at 02:20:38PM -0400, Mike Snitzer wrote: > > On Tue, Aug 04 2020 at 8:47am -0400, > > Greg KH wrote: > > > > > On Tue, Aug 04, 2020 at 07:33:05AM -0500, John Donnelly wro

Re: [(resend) PATCH v3: {linux-4.14.y} ] dm cache: submit writethrough writes in parallel to origin and cache

2020-08-04 Thread Mike Snitzer
On Tue, Aug 04 2020 at 8:47am -0400, Greg KH wrote: > On Tue, Aug 04, 2020 at 07:33:05AM -0500, John Donnelly wrote: > > From: Mike Snitzer > > > > Discontinue issuing writethrough write IO in series to the origin and > > then cache. > > > > Use bio_cl

Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-29 Thread Mike Snitzer
On Wed, Jul 29 2020 at 7:55am -0400, Greg KH wrote: > On Wed, Jul 29, 2020 at 01:51:19PM +0200, Greg KH wrote: > > On Mon, Jul 27, 2020 at 11:00:14AM -0400, Mike Snitzer wrote: > > > This mail needs to be saent to sta...@vger.kernel.org (now cc'd). > > > > &

Re: [PATCH 4.19 84/86] dm integrity: fix integrity recalculation that is improperly skipped

2020-07-27 Thread Mike Snitzer
On Mon, Jul 27 2020 at 7:31pm -0400, Sasha Levin wrote: > On Mon, Jul 27, 2020 at 10:56:35PM +0200, Pavel Machek wrote: > >Hi! > > > >>From: Mikulas Patocka > >> > >>commit 5df96f2b9f58a5d2dc1f30fe7de75e197f2c25f2 upstream. > >> > >>Commit adc0daad366b62ca1bce3e2958a40b0b71a8b8b3 ("dm: report

Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-27 Thread Mike Snitzer
On Mon, Jul 27 2020 at 4:17pm -0400, Sasha Levin wrote: > On Mon, Jul 27, 2020 at 02:38:52PM -0500, John Donnelly wrote: > > > > > >>On Jul 27, 2020, at 2:18 PM, Sasha Levin wrote: > >> > >>On Mon, Jul 27, 2020 at 11:00:14AM -0400, Mike Snitzer wrot

Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-27 Thread Mike Snitzer
This mail needs to be saent to sta...@vger.kernel.org (now cc'd). Greg et al: please backport 2df3bae9a6543e90042291707b8db0cbfbae9ee9 Thanks, Mike On Mon, Jul 27 2020 at 9:40am -0400, John Donnelly wrote: > From: Mike Snitzer > > Discontinue issuing writethrough write IO

Re: [PATCH 01/14] dm: use bio_uninit instead of bio_disassociate_blkg

2020-07-08 Thread Mike Snitzer
On Sat, Jun 27 2020 at 3:31am -0400, Christoph Hellwig wrote: > bio_uninit is the proper API to clean up a BIO that has been allocated > on stack or inside a structure that doesn't come from the BIO allocator. > Switch dm to use that instead of bio_disassociate_blkg, which really is > an

Re: [PATCH 10/20] dm: stop using ->queuedata

2020-07-01 Thread Mike Snitzer
On Wed, Jul 01 2020 at 4:59am -0400, Christoph Hellwig wrote: > Instead of setting up the queuedata as well just use one private data > field. > > Signed-off-by: Christoph Hellwig Acked-by: Mike Snitzer

Re: remove dead bdi congestion leftovers

2020-07-01 Thread Mike Snitzer
On Wed, Jul 01 2020 at 5:06am -0400, Christoph Hellwig wrote: > Hi Jens, > > we have a lot of bdi congestion related code that is left around without > any use. This series removes it in preparation of sorting out the bdi > lifetime rules properly. I could do some git archeology to see what

Re: dm writecache: reject asynchronous pmem.

2020-06-30 Thread Mike Snitzer
On Tue, Jun 30 2020 at 10:10am -0400, Michal Suchánek wrote: > On Tue, Jun 30, 2020 at 09:32:01AM -0400, Mikulas Patocka wrote: > > > > > > On Tue, 30 Jun 2020, Michal Suchanek wrote: > > > > > The writecache driver does not handle asynchronous pmem. Reject it when > > > supplied as cache. >

Re: [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Mike Snitzer
On Wed, Jun 24 2020 at 12:54am -0400, Damien Le Moal wrote: > On 2020/06/24 0:23, Mike Snitzer wrote: > > On Tue, Jun 23 2020 at 11:07am -0400, > > Ignat Korchagin wrote: > > > >> Do you think it may be better to break it in two flags: one for read > >>

Re: [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Mike Snitzer
On Fri, Jun 19 2020 at 9:23pm -0400, Herbert Xu wrote: > On Fri, Jun 19, 2020 at 02:39:39PM -0400, Mikulas Patocka wrote: > > > > I'm looking at this and I'd like to know why does the crypto API fail in > > hard-irq context and why does it work in tasklet context. What's the exact > > reason

Re: [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Mike Snitzer
On Tue, Jun 23 2020 at 11:07am -0400, Ignat Korchagin wrote: > Do you think it may be better to break it in two flags: one for read > path and one for write? So, depending on the needs and workflow these > could be enabled independently? If there is a need to split, then sure. But I think

Re: [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-23 Thread Mike Snitzer
On Sun, Jun 21 2020 at 8:45pm -0400, Damien Le Moal wrote: > On 2020/06/20 1:56, Mike Snitzer wrote: > > On Fri, Jun 19 2020 at 12:41pm -0400, > > Ignat Korchagin wrote: > > > >> This is a follow up from the long-forgotten [1], but with some more > >

Re: [RFC PATCH 0/1] dm-crypt excessive overhead

2020-06-19 Thread Mike Snitzer
On Fri, Jun 19 2020 at 12:41pm -0400, Ignat Korchagin wrote: > This is a follow up from the long-forgotten [1], but with some more convincing > evidence. Consider the following script: > > #!/bin/bash -e > > # create 4G ramdisk > sudo modprobe brd rd_nr=1 rd_size=4194304 > > # create a

Re: [PATCH 21/29] docs: device-mapper: add dm-ebs.rst to an index file

2020-06-19 Thread Mike Snitzer
On Mon, Jun 15 2020 at 2:47am -0400, Mauro Carvalho Chehab wrote: > Solves this Sphinx warning: > Documentation/admin-guide/device-mapper/dm-ebs.rst: WARNING: document > isn't included in any toctree > > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: New mode DM-Verity error handling

2020-06-18 Thread Mike Snitzer
On Thu, Jun 18 2020 at 12:50pm -0400, Sami Tolvanen wrote: > On Thu, Jun 18, 2020 at 11:44:45AM -0400, Mike Snitzer wrote: > > I do not accept that panicing the system because of verity failure is > > reasonable. > > > > In fact, even rebooting (via DM_VERITY_MOD

Re: New mode DM-Verity error handling

2020-06-18 Thread Mike Snitzer
On Thu, Jun 18 2020 at 2:56am -0400, JeongHyeon Lee wrote: > Hello, Dear devcice-mapper maintainers. > > I'm JeongHyeon Lee, work in Samsung. I'm chage of DM-Verity feature with > Mr. sunwook eom. > I have a patch or suggestion about DM-Verity error handling. > > Our device (smart phone)

Re: dm writecache: correct uncommitted_block when discarding uncommitted entry

2020-06-17 Thread Mike Snitzer
On Sat, Jun 13 2020 at 8:40am -0400, Mikulas Patocka wrote: > > > On Fri, 12 Jun 2020, Huaisheng Ye wrote: > > > From: Huaisheng Ye > > > > When uncommitted entry has been discarded, correct wc->uncommitted_block > > for getting the exact number. > > > > Signed-off-by: Huaisheng Ye > >

Re: dm ioctl: Use struct_size() helper

2020-06-17 Thread Mike Snitzer
On Tue, Jun 16 2020 at 6:06pm -0400, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this? > > It's been almost a year... and I just noticed there was a problem > with the email addresses back then... > > I just fixed the issue and this patch should now appear on >

Re: [PATCH][next] dm zoned: fix memory leak of newly allocated zone on xa_insert failure

2020-06-03 Thread Mike Snitzer
On Wed, Jun 03 2020 at 12:02pm -0400, Colin King wrote: > From: Colin Ian King > > Currently if an xa_insert fails then there is a memory lead of the > recently allocated zone object. Fix this by kfree'ing zone before > returning on the error return path. > > Addresses-Coverity: ("Resource

Re: next-20200514 - build issue in drivers/md/dm-zoned-target.c

2020-05-18 Thread Mike Snitzer
On Mon, May 18 2020 at 2:25am -0400, Hannes Reinecke wrote: > On 5/16/20 1:19 PM, Valdis Klētnieks wrote: > >Am seeing a build error in next-0514. -0420 built OK. > >building a 'make allmodconfig' on a RPi4 in 32-bit mode. > > > > MODPOST 7575 modules > >ERROR: modpost: "__aeabi_uldivmod"

Re: [PATCH v4 0/2] Historical Service Time Path Selector

2020-05-11 Thread Mike Snitzer
On Mon, May 11 2020 at 1:31pm -0400, Mike Snitzer wrote: > On Mon, May 11 2020 at 1:11pm -0400, > Gabriel Krisman Bertazi wrote: > > > Mike Snitzer writes: > > > > > On Mon, May 11 2020 at 12:39pm -0400, > > > Gabriel Krisman Bertazi wrote: >

Re: [PATCH v4 0/2] Historical Service Time Path Selector

2020-05-11 Thread Mike Snitzer
On Mon, May 11 2020 at 1:11pm -0400, Gabriel Krisman Bertazi wrote: > Mike Snitzer writes: > > > On Mon, May 11 2020 at 12:39pm -0400, > > Gabriel Krisman Bertazi wrote: > > > >> Hi, > >> > >> This fourth version of HST applies the suggesti

Re: [PATCH v4 0/2] Historical Service Time Path Selector

2020-05-11 Thread Mike Snitzer
On Mon, May 11 2020 at 12:39pm -0400, Gabriel Krisman Bertazi wrote: > Hi, > > This fourth version of HST applies the suggestion from Mikulas Patocka > to do the ktime_get_ns inside the mpath map_bio instead of generic > device-mapper code. This means that struct dm_mpath_io gained another >

Re: [PATCH -next] dm mpath: Remove unused variable ret

2020-05-07 Thread Mike Snitzer
On Thu, May 07 2020 at 8:26am -0400, Samuel Zou wrote: > This patch fixes below warning reported by coccicheck: > > drivers/md/dm-historical-service-time.c:240:14-16: Unneeded variable: "sz". > Return "0" on line 261 > > Reported-by: Hulk Robot > Signed-off-by: Samuel Zou Nack. DMEMIT()

Re: [PATCH v2 1/1] blk-mq: Inline request status checkers

2019-09-30 Thread Mike Snitzer
On Mon, Sep 30 2019 at 3:53pm -0400, Bart Van Assche wrote: > On 9/30/19 12:43 PM, Pavel Begunkov (Silence) wrote: > > @@ -282,7 +282,7 @@ static bool bt_tags_iter(struct sbitmap *bitmap, > > unsigned int bitnr, void *data) > > * test and set the bit before assining ->rqs[]. > > */ >

Re: dax: Arrange for dax_supported check to span multiple devices

2019-05-16 Thread Mike Snitzer
e upper-level bdev_dax_supported() requests. > > Fixes: ad428cdb525a ("dax: Check the end of the block-device...") > Cc: > Cc: Jan Kara > Cc: Ira Weiny > Cc: Dave Jiang > Cc: Mike Snitzer > Cc: Keith Busch > Cc: Matthew Wilcox > Cc: Vishal Verma &g

Re: dm ioctl: fix hang in early create error condition

2019-05-15 Thread Mike Snitzer
On Wed, May 15 2019 at 12:12pm -0400, Helen Koike wrote: > Hi, > > On 5/13/19 10:37 PM, Mike Snitzer wrote: > > On Mon, May 13 2019 at 3:25P -0400, > > Helen Koike wrote: > > > >> The dm_early_create() function (which deals with "dm-mod.create

Re: x86 VM Boot hang with latest linux-next

2019-03-04 Thread Mike Snitzer
On Sun, Mar 03 2019 at 12:06pm -0500, Alexander Duyck wrote: > On Sat, Mar 2, 2019 at 7:48 PM Mike Snitzer wrote: > > > > On Sat, Mar 02 2019 at 6:34pm -0500, > > Alexander Duyck wrote: > > > > > So I have been seeing an issue with an intermitt

Re: x86 VM Boot hang with latest linux-next

2019-03-04 Thread Mike Snitzer
On Sun, Mar 03 2019 at 12:06pm -0500, Alexander Duyck wrote: > Thanks. The behavior of it has me wondering if we are looking at > something like an uninitialized data issue or something like that > since as I mentioned I don't see this occur on every boot, just on > most of them. So every now

Re: x86 VM Boot hang with latest linux-next

2019-03-02 Thread Mike Snitzer
t bad commit > commit 1efa3bb79d3de8ca1b7f6770313a1fc0bebe25c7 > Author: Mike Snitzer > Date: Fri Feb 22 11:23:01 2019 -0500 > > dm: must allocate dm_noclone for stacked noclone devices > > Otherwise various lvm2 testsuite tests fail because the lower layers of >

Re: [PATCH 1/3] list_bl: Add hlist_bl_add_before/behind helpers

2019-02-28 Thread Mike Snitzer
On Thu, Feb 28 2019 at 4:32pm -0500, Mike Snitzer wrote: > On Thu, Dec 20 2018 at 1:06pm -0500, > Nikos Tsironis wrote: > > > Add hlist_bl_add_before/behind helpers to add an element before/after an > > existing element in a bl_list. > > > > Signed-off-b

Re: [PATCH 1/3] list_bl: Add hlist_bl_add_before/behind helpers

2019-02-28 Thread Mike Snitzer
On Thu, Dec 20 2018 at 1:06pm -0500, Nikos Tsironis wrote: > Add hlist_bl_add_before/behind helpers to add an element before/after an > existing element in a bl_list. > > Signed-off-by: Nikos Tsironis > Signed-off-by: Ilias Tsitsimpis > --- > include/linux/list_bl.h | 27

Re: [PATCH AUTOSEL 4.20 42/77] dm: fix clone_bio() to trigger blk_recount_segments()

2019-02-27 Thread Mike Snitzer
On Wed, Feb 27 2019 at 12:38pm -0500, Sasha Levin wrote: > On Thu, Feb 14, 2019 at 10:49:09PM -0500, Mike Snitzer wrote: > >On Thu, Feb 14 2019 at 9:08pm -0500, > >Sasha Levin wrote: > > > >>From: Mike Snitzer > >> > >>[ Upstream commit 57c36519

Re: block: be more careful about status in __bio_chain_endio

2019-02-22 Thread Mike Snitzer
On Fri, Feb 22 2019 at 9:02pm -0500, John Dorminy wrote: > I am perhaps not understanding the intricacies here, or not seeing a > barrier protecting it, so forgive me if I'm off base. I think reading > parent->bi_status here is unsafe. > Consider the following sequence of events on two threads.

Re: block: be more careful about status in __bio_chain_endio

2019-02-22 Thread Mike Snitzer
On Fri, Feb 22 2019 at 5:46pm -0500, Jens Axboe wrote: > On 2/22/19 2:10 PM, Mike Snitzer wrote: > > On Thu, Feb 15 2018 at 4:09am -0500, > > NeilBrown wrote: > > > >> > >> If two bios are chained under the one parent (with bio_chain()) > >> it

Re: dm crypt: fix memory leak in dm_crypt_integrity_io_alloc() error path

2019-02-22 Thread Mike Snitzer
On Sat, Feb 16 2019 at 4:00pm -0500, sul...@kerneltoast.com wrote: > From: Sultan Alsawaf > > dm_crypt_integrity_io_alloc() allocates space for an integrity payload but > doesn't free it in the error path, leaking memory. Add a bio_integrity_free() > invocation upon error to fix the memory

Re: block: be more careful about status in __bio_chain_endio

2019-02-22 Thread Mike Snitzer
arent->bi_status) > + if (bio->bi_status) > parent->bi_status = bio->bi_status; > bio_put(bio); > return parent; > -- > 2.14.0.rc0.dirty > Reviewed-by: Mike Snitzer Jens, this one slipped through the crack just over a year ago. It is available in patchwork here: https://patchwork.kernel.org/patch/10220727/

Re: [PATCH v11] dm: add support to directly boot to a mapped device

2019-02-21 Thread Mike Snitzer
On Mon, Feb 18 2019 at 1:18pm -0500, Helen Koike wrote: > Add a dm-mod.create= kernel module parameter. > It allows device-mapper targets to be configured at boot time for use early > in the boot process (as the root device or otherwise). > > Signed-off-by: Will Drewry > Signed-off-by: Kees

  1   2   3   4   5   6   7   8   9   10   >