Re: [PATCH] uapi: fix linux/tls.h userspace compilation error

2017-11-15 Thread Mikko Rapeli
/tcp.h: No such file or > directory > > As to this point uapi/linux/tls.h was totaly unusuable for userspace, > cleanup this header file further by moving other redundant includes > to net/tls.h. > > Fixes: 3c4d7559159b ("tls: kernel TLS support") > Cc: # v4.13+ &

Re: [PATCH v06 35/36] uapi linux/tls.h: don't include in user space

2017-09-18 Thread Mikko Rapeli
On Mon, Sep 04, 2017 at 07:15:11PM +0300, Dmitry V. Levin wrote: > On Wed, Aug 09, 2017 at 02:25:54AM +0300, Dmitry V. Levin wrote: > > On Sun, Aug 06, 2017 at 06:44:26PM +0200, Mikko Rapeli wrote: > > > It is not needed and not part of uapi headers, but causes > > > u

Re: [PATCH v06 05/36] uapi linux/sysctl.h: use __kernel_size_t instead of size_t

2017-08-09 Thread Mikko Rapeli
Hi Dmitry and thanks for the comments. I have only one question: why haven't your patches been applied yet? -Mikko

Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h

2017-08-06 Thread Mikko Rapeli
On Sun, Aug 06, 2017 at 03:09:21PM -0700, James Bottomley wrote: > On Sun, 2017-08-06 at 23:42 +0300, Mikko Rapeli wrote: > > Hi, > > > > On Sun, Aug 06, 2017 at 11:22:53AM -0700, James Bottomley wrote: > > > > > > On Sun, 2017-08-06 at 18:43 +0200, Mik

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

2017-08-06 Thread Mikko Rapeli
On Sun, Aug 06, 2017 at 05:42:13PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 5:33 PM, Mikko Rapeli wrote: > > On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: > >> >> > +#ifdef __KERNEL__ > >> >> > +#include > >&

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

2017-08-06 Thread Mikko Rapeli
On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: > >> > +#ifdef __KERNEL__ > >> > +#include > >> > +#else > >> > +#include > >> > +#endif /* __KERNEL__ */ > >> > >> This will break applications that include manually. > >> I previously sent a patch to use libc-compat to make comp

Re: [PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h

2017-08-06 Thread Mikko Rapeli
Hi, On Sun, Aug 06, 2017 at 11:22:53AM -0700, James Bottomley wrote: > On Sun, 2017-08-06 at 18:43 +0200, Mikko Rapeli wrote: > > Fixes userspace compilation errors like: > > > > scsi/scsi_netlink_fc.h:60:2: error: expected specifier-qualifier-list > > before

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

2017-08-06 Thread Mikko Rapeli
On Sun, Aug 06, 2017 at 04:26:50PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 4:23 PM, Willem de Bruijn > wrote: > > On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: > >> linux/time.h conflicts with user space header time.h. Try to be compatible > >&

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

2017-08-06 Thread Mikko Rapeli
On Sun, Aug 06, 2017 at 04:23:16PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: > > linux/time.h conflicts with user space header time.h. Try to be compatible > > with both. > > > > Fixes userspace compilation error: &g

[PATCH v06 17/36] uapi linux/sctp.h: use __u8, __u16 and __u32 from linux/types.h

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation errors like: linux/sctp.h:652:2: error: unknown type name ‘uint32_t’ Acked-by: Neil Horman Signed-off-by: Mikko Rapeli Cc: Marcelo Ricardo Leitner Cc: Xin Long Cc: Phil Sutter --- include/uapi/linux/sctp.h | 20 ++-- 1 file changed, 10 insertions

[PATCH v06 26/36] uapi xen/privcmd.h: fix compilation in userspace

2017-08-06 Thread Mikko Rapeli
error: unknown type name ‘size_t’ Signed-off-by: Mikko Rapeli Cc: Paul Durrant Cc: David Vrabel Cc: Stefano Stabellini Cc: Russell King --- include/uapi/xen/privcmd.h | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/include/uapi/xen/privcmd.h b/include/ua

[PATCH v06 09/36] uapi asm-generic/sembuf.h: include asm/posix_types.h and asm/ipcbuf.h

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation errors like: error: field ‘msg_perm’ has incomplete type struct ipc64_perm msg_perm; error: unknown type name ‘__kernel_ulong_t’ Signed-off-by: Mikko Rapeli Acked-by: Arnd Bergmann Cc: H.J. Lu Cc: H. Peter Anvin --- include/uapi/asm-generic/sembuf.h | 2 ++ 1

[PATCH v06 36/36] uapi linux/kfd_ioctl.h: use __u32 and __u64 instead of uint32_t and uint64_t

2017-08-06 Thread Mikko Rapeli
Include instead of which on Linux includes and on non-Linux platforms defines __u32 etc types. Fixes user space compilation errors like: linux/kfd_ioctl.h:33:2: error: unknown type name ‘uint32_t’ uint32_t major_version; /* from KFD */ ^~~~ Signed-off-by: Mikko Rapeli Cc: Yair

[PATCH v06 27/36] uapi xen/gntdev.h: include xen/privcmd.h and define grant_ref_t

2017-08-06 Thread Mikko Rapeli
Both are needed to compile in userspace. Fixes these userspace compile errors: xen/gntdev.h:151:4: error: unknown type name ‘grant_ref_t’ grant_ref_t ref; ^ xen/gntdev.h:153:4: error: unknown type name ‘domid_t’ domid_t domid; ^ Signed-off-by: Mikko Rapeli Cc: Boris Ostrovsky

[PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

2017-08-06 Thread Mikko Rapeli
linux/time.h conflicts with user space header time.h. Try to be compatible with both. Fixes userspace compilation error: error: array type has incomplete element type struct timespec ts[3]; Signed-off-by: Mikko Rapeli Cc: Willem de Bruijn Cc: Soheil Hassas Yeganeh Cc: net...@vger.kernel.org

[PATCH v06 13/36] x86 uapi asm/sembuf.h: include linux/types.h and linux/ipc.h

2017-08-06 Thread Mikko Rapeli
Fixes userspace compile errors like: error: field ‘sem_perm’ has incomplete type struct ipc64_perm sem_perm; /* permissions .. see ipc.h */ error: unknown type name ‘__kernel_time_t’ __kernel_time_t sem_otime; /* last semop time */ Signed-off-by: Mikko Rapeli Cc: Al Viro Cc: Arnd Bergmann

[PATCH v06 06/36] uapi asm-generic/ipcbuf.h: include linux/posix_types.h

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation error: error: unknown type name ‘__kernel_key_t’ Signed-off-by: Mikko Rapeli Acked-by: Arnd Bergmann Cc: "H. Peter Anvin" Cc: H.J. Lu --- include/uapi/asm-generic/ipcbuf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/asm-generic/i

[PATCH v06 02/36] uapi scsi/scsi_bsg_fc.h: use __u8, __u32 and __u64 from linux/types.h

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation errors like: scsi/scsi_bsg_fc.h:83:2: error: unknown type name ‘uint8_t’ Signed-off-by: Mikko Rapeli Cc: linux-s...@vger.kernel.org --- include/uapi/scsi/scsi_bsg_fc.h | 54 + 1 file changed, 28 insertions(+), 26 deletions

[PATCH v06 25/36] uapi linux/android/binder.h: use __kernel_pid_t and __kernel_uid_t

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation errors: error: unknown type name ‘pid_t’ pid_t sender_pid error: unknown type name ‘uid_t’ uid_t sender_euid; Signed-off-by: Mikko Rapeli Cc: Greg Kroah-Hartman Cc: Arve Hjønnevåg Cc: Riley Andrews Cc: Todd Kjos Cc: Martijn Coenen Cc: de

[PATCH v06 28/36] uapi xen/evtchn.h: include xen/privcmd.h

2017-08-06 Thread Mikko Rapeli
It has definition of domid_t. Fixes userspace compiler error when xen/privcmd.h is compiled alone: xen/evtchn.h:100:2: error: unknown type name ‘domid_t’ domid_t domid; ^~~ Signed-off-by: Mikko Rapeli Cc: Boris Ostrovsky Cc: Juergen Gross Cc: xen-de...@lists.xenproject.org

[PATCH v06 07/36] uapi asm-generic/msgbuf.h: include asm/ipcbuf.h

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation errors like: error: field ‘msg_perm’ has incomplete type struct ipc64_perm msg_perm Signed-off-by: Mikko Rapeli Acked-by: Arnd Bergmann Cc: H.J. Lu Cc: H. Peter Anvin --- include/uapi/asm-generic/msgbuf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH v06 10/36] uapi asm-generic/signal.h: use __kernel_size_t instead of size_t

2017-08-06 Thread Mikko Rapeli
Fixes userspace compiler error: error: unknown type name ‘size_t’ Signed-off-by: Mikko Rapeli Acked-by: Arnd Bergmann Cc: Al Viro Cc: H. Peter Anvin --- include/uapi/asm-generic/signal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/asm-generic/signal.h b

[PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h

2017-08-06 Thread Mikko Rapeli
struct sockaddr_in _sockaddr_in; ^~~~ rdma/rdma_user_rxe.h:61:23: error: field ‘_sockaddr_in6’ has incomplete type struct sockaddr_in6 _sockaddr_in6; ^ Signed-off-by: Mikko Rapeli Acked-by: Moni Shoua Acked-by: Doug Ledford Cc

[PATCH v06 11/36] uapi asm-generic/ucontext.h: include asm/signal.h and asm/sigcontext.h

2017-08-06 Thread Mikko Rapeli
Fixes userspace compiler errors: error: unknown type name ‘stack_t’ error: field ‘uc_mcontext’ has incomplete type struct sigcontext uc_mcontext; error: unknown type name ‘sigset_t’ Signed-off-by: Mikko Rapeli Cc: H. Peter Anvin Cc: Arnd Bergmann Cc: Al Viro --- include/uapi/asm-generic

[PATCH v06 24/36] uapi linux/coda_psdev.h: move upc_req definition from uapi to kernel side headers

2017-08-06 Thread Mikko Rapeli
_short uc_opcode; /* copied from data to save lookup */ ^ ./linux/coda_psdev.h:19:2: error: unknown type name ‘wait_queue_head_t’ wait_queue_head_t uc_sleep; /* process' wait queue */ ^ Signed-off-by: Mikko Rapeli Cc: c...@cs.cmu.edu Cc: Jan Harkes --- include/linux/c

[PATCH v06 05/36] uapi linux/sysctl.h: use __kernel_size_t instead of size_t

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation error: error: unknown type name ‘size_t’ Signed-off-by: Mikko Rapeli Cc: Arnd Bergmann Cc: David S. Miller --- include/uapi/linux/sysctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux

[PATCH v06 33/36] uapi linux/fsmap.h: use __kernel_size_t instead of size_t

2017-08-06 Thread Mikko Rapeli
Fixes user space compilation error: linux/fsmap.h:71:19: error: unknown type name ‘size_t’ static __inline__ size_t ^~ Signed-off-by: Mikko Rapeli Cc: Darrick J. Wong --- include/uapi/linux/fsmap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v06 35/36] uapi linux/tls.h: don't include in user space

2017-08-06 Thread Mikko Rapeli
It is not needed and not part of uapi headers, but causes user space compilation error: fatal error: net/tcp.h: No such file or directory #include ^ Signed-off-by: Mikko Rapeli Cc: Dave Watson Cc: Ilya Lesokhin Cc: Aviad Yehezkel --- include/uapi/linux/tls.h | 2 ++ 1

[PATCH v06 01/36] Add scripts/headers_compile_test.sh: compile test for exported uapi headers

2017-08-06 Thread Mikko Rapeli
: 73 files failed libc before kernel include test. 790 files passed libc before kernel include test. Since I've been stubborn enough to work with this script and fixes to the test failures for a few years, I added my self to MAINTAINERS. Signed-off-by: Mikko Rapeli Cc: Alexander Stein Cc: Gab

[PATCH v06 20/36] uapi linux/scc.h: include linux/sockios.h

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation error: error: ‘SIOCDEVPRIVATE’ undeclared here (not in a function) SIOCSCCRESERVED = SIOCDEVPRIVATE Signed-off-by: Mikko Rapeli Cc: net...@vger.kernel.org Cc: linux-h...@vger.kernel.org Cc: Joerg Reuter --- include/uapi/linux/scc.h | 1 + 1 file changed, 1

[PATCH v06 14/36] arm uapi asm/signal.h: include for size_t in userspace

2017-08-06 Thread Mikko Rapeli
Arnd Bergmann doubts that __kernel_size_t could be used here so trying to fall back to gcc's . Fixes uapi header compilation error from userspace on ARCH=arm: asm/signal.h:112:2: error: unknown type name ‘size_t’ size_t ss_size; Signed-off-by: Mikko Rapeli Cc: Arnd Bergmann --- arc

[PATCH v06 32/36] uapi drm/armada_drm.h: use __u32 and __u64 instead of uint32_t and uint64_t

2017-08-06 Thread Mikko Rapeli
These are defined in linux/types.h or drm/drm.h. Fixes user space compilation errors like: drm/armada_drm.h:26:2: error: unknown type name ‘uint32_t’ uint32_t handle; ^~~~ Signed-off-by: Mikko Rapeli Cc: Emil Velikov Cc: Gabriel Laskar Cc: Russell King Cc: Rob Clark --- include

[PATCH v06 16/36] uapi linux/dlm_netlink.h: include linux/dlmconstants.h

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation error: error: ‘DLM_RESNAME_MAXLEN’ undeclared here (not in a function) char resource_name[DLM_RESNAME_MAXLEN]; Signed-off-by: Mikko Rapeli Cc: Christine Caulfield Cc: David Teigland Cc: cluster-de...@redhat.com --- include/uapi/linux/dlm_netlink.h | 1 + 1 file

[PATCH v06 12/36] x86 uapi asm/signal.h: use __kernel_size_t instead of size_t

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation error: error: unknown type name ‘size_t’ Signed-off-by: Mikko Rapeli Cc: Al Viro Cc: Arnd Bergmann Cc: H. Peter Anvin --- arch/x86/include/uapi/asm/signal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/uapi/asm/signal.h b

[PATCH v06 22/36] uapi linux/reiserfs_xattr.h: use __kernel_size_t instead of size_t

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation error: error: unknown type name ‘size_t’ size_t length; Signed-off-by: Mikko Rapeli Cc: reiserfs-de...@vger.kernel.org --- include/uapi/linux/reiserfs_xattr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/reiserfs_xattr.h

[PATCH v06 00/36] Userspace compile test and fixes for exported uapi header files

2017-08-06 Thread Mikko Rapeli
ious Linux kernel subsystem maintainers would pick and apply patches from this series to their queues, and comment if there are problems with any of them. Mikko Rapeli (36): Add scripts/headers_compile_test.sh: compile test for exported uapi headers uapi scsi/scsi_bsg_fc.h: use __u8, __u32

[PATCH v06 31/36] uapi linux/patchkey.h: change #error to #warning if file included directly

2017-08-06 Thread Mikko Rapeli
Would be nice to be able to compile all userspace header files also alone. Signed-off-by: Mikko Rapeli Cc: alsa-de...@alsa-project.org Cc: Andrew Veliath Cc: Riccardo Facchetti --- include/uapi/linux/patchkey.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi

[PATCH v06 03/36] uapi scsi/scsi_netlink.h: use __u8, __u16 and __u64 from linux/types.h

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation errors like: scsi/scsi_netlink.h:43:2: error: unknown type name ‘uint8_t’ Signed-off-by: Mikko Rapeli Cc: linux-s...@vger.kernel.org --- include/uapi/scsi/scsi_netlink.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a

[PATCH v06 29/36] uapi linux/elfcore.h: remove non-compiling userspace parts

2017-08-06 Thread Mikko Rapeli
compiles but is generally not usable for things like core dump parsing but luckily userspace users already know this and have their own modified version of the needed definitions and headers. But at least this compiles now. Signed-off-by: Mikko Rapeli Cc: Al Viro Cc: Ingo Molnar Cc: Roland McGrath

[PATCH v06 04/36] uapi scsi/scsi_netlink_fc.h: use __u16, __u32 and __u64 from linux/types.h

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation errors like: scsi/scsi_netlink_fc.h:60:2: error: expected specifier-qualifier-list before ‘uint64_t’ Signed-off-by: Mikko Rapeli Cc: linux-s...@vger.kernel.org --- include/uapi/scsi/scsi_netlink_fc.h | 16 1 file changed, 8 insertions(+), 8

[PATCH v06 08/36] uapi asm-generic/shmbuf.h: include fixes

2017-08-06 Thread Mikko Rapeli
’ Signed-off-by: Mikko Rapeli Acked-by: Arnd Bergmann Cc: H.J. Lu Cc: H. Peter Anvin --- include/uapi/asm-generic/shmbuf.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/uapi/asm-generic/shmbuf.h b/include/uapi/asm-generic/shmbuf.h index 7e9fb2f0853b..ae867ad1e5e4

[PATCH v06 23/36] uapi linux/coda.h: use __kernel_pid_t and add u_short etc definitions for userspace

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation errors about unknown pid_t, u_short etc types. Signed-off-by: Mikko Rapeli Cc: Jan Harkes Cc: codal...@coda.cs.cmu.edu --- include/uapi/linux/coda.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/coda.h b/include

[PATCH v06 34/36] uapi: break dependency loop between and

2017-08-06 Thread Mikko Rapeli
*/ ^~~~ This approach for suggested by Frans Klaver in lkml message . Signed-off-by: Mikko Rapeli Cc: Frans Klaver Cc: David Miller --- include/uapi/linux/hdlc/ioctl.h | 17 + include/uapi/linux/if.h | 23 --- 2 files changed, 25

[PATCH v06 19/36] uapi linux/omapfb.h: use __kernel_size_t instead of size_t

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation error: error: unknown type name ‘size_t’ Signed-off-by: Mikko Rapeli Cc: linux-o...@vger.kernel.org Cc: Tomi Valkeinen Cc: Aaro Koskinen --- include/uapi/linux/omapfb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/omapfb.h

[PATCH v06 21/36] uapi linux/kexec.h: use __kernel_size_t instead of size_t

2017-08-06 Thread Mikko Rapeli
Fixes userspace compilation error: error: unknown type name ‘size_t’ size_t bufsz; Signed-off-by: Mikko Rapeli Cc: ke...@lists.infradead.org Cc: Eric Biederman --- include/uapi/linux/kexec.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/kexec.h b

[PATCH v06 15/36] uapi linux/socket.h: include sys/socket.h in user space

2017-08-06 Thread Mikko Rapeli
_sockaddr; error: invalid application of ‘sizeof’ to incomplete type ‘struct sockaddr’ With this following uapi headers now compile in user space: rdma/rdma_user_rxe.h linux/vm_sockets.h linux/ncp_fs.h linux/nfc.h linux/phonet.h Signed-off-by: Mikko Rapeli Cc: net...@vger.kernel.org Cc: Dmitry V. Levin

Re: [PATCH 3/4] uapi glibc compat: Do not check for __USE_MISC

2017-03-16 Thread Mikko Rapeli
On Thu, Mar 16, 2017 at 07:59:12AM +, David Woodhouse wrote: > On Sun, 2017-03-12 at 23:00 +0100, Hauke Mehrtens wrote: > > __USE_MISC is glibc specific and not available in musl libc. Only do > > this check when glibc is used. This fixes a problem with musl libc. > > ... > > -/* Coordinate wit

Re: [PATCH 4/4] uapi/if_ether.h: prevent redefinition of struct ethhdr

2017-03-13 Thread Mikko Rapeli
> Tested-by: David Heidelberger > Signed-off-by: Jonas Gorski Acked-by: Mikko Rapeli > --- > include/uapi/linux/if_ether.h| 3 +++ > include/uapi/linux/libc-compat.h | 11 +++ > 2 files changed, 14 insertions(+) > > diff --git a/include/uapi/linux/if_ether

Re: [PATCH 3/4] uapi glibc compat: Do not check for __USE_MISC

2017-03-13 Thread Mikko Rapeli
On Sun, Mar 12, 2017 at 11:00:38PM +0100, Hauke Mehrtens wrote: > __USE_MISC is glibc specific and not available in musl libc. Only do > this check when glibc is used. This fixes a problem with musl libc. > Signed-off-by: Hauke Mehrtens Acked-by: Mikko Rapeli > --- > include/

Re: [PATCH 2/4] uapi glibc compat: fix build if libc defines IFF_ECHO

2017-03-13 Thread Mikko Rapeli
_ECHO only when > it is needed. This should also make this work in case glibc will add > these defines. > > Signed-off-by: Hauke Mehrtens Acked-by: Mikko Rapeli > --- > include/uapi/linux/libc-compat.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/

Re: [PATCH 1/4] uapi glibc compat: add libc compat code when not build for kernel

2017-03-13 Thread Mikko Rapeli
ens Accked-by: Mikko Rapeli > --- > include/uapi/linux/libc-compat.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/uapi/linux/libc-compat.h > b/include/uapi/linux/libc-compat.h > index 44b8a6bd5fe1..7c1fead03c50 100644 > --- a/i

Re: [PATCH] uapi glibc compat: fix build if libc defines IFF_ECHO

2017-01-21 Thread Mikko Rapeli
> > Activate __UAPI_DEF_IF_NET_DEVICE_FLAGS_LOWER_UP_DORMANT_ECHO only when > it is needed. This should also make this work in case glibc will add > these defines. > > Signed-off-by: Hauke Mehrtens Looks good. Reviewed-by: Mikko Rapeli > --- > include/uapi/linux/libc-compat.h | 2 ++ > 1 file

Re: [PATCH] uapi glibc compat: fix outer guard of net device flags enum

2016-12-05 Thread Mikko Rapeli
nition with either parts. > > This fixes compilation of userspace programs trying to use > IFF_LOWER_UP, IFF_DORMANT or IFF_ECHO. > > Fixes: 4a91cb61bb99 ("uapi glibc compat: fix compile errors when glibc > net/if.h included before linux/if.h") > Signed-off-by: Jona

Re: [PATCH v05 69/72] uapi rose.h: glibc netrose/rose.h header file compatibility fixes

2016-11-16 Thread Mikko Rapeli
Hi, On Mon, Aug 29, 2016 at 12:34:25PM -0700, David Ranch wrote: > Hello Mikko, > > Somewhat related, the ax25.h file from libax25-devel also has conflicts with > the Glibc's ax.25.h. This creates trouble so if we could get a fix for > that, that would be appreciated as well though it might be a

Re: [PATCH v05 60/72] arch/arm/include/uapi/asm/signal.h: use __kernel_size_t instead of size_t

2016-11-16 Thread Mikko Rapeli
On Wed, Aug 24, 2016 at 05:02:56PM +0200, Arnd Bergmann wrote: > On Monday, August 22, 2016 8:33:17 PM CEST Mikko Rapeli wrote: > > diff --git a/arch/arm/include/uapi/asm/signal.h > > b/arch/arm/include/uapi/asm/signal.h > > index 33073bd..859f2de 100644 > > ---

Re: [PATCH v05 27/72] linux/if.h linux/hdlc/ioctl.h: move IFNAMSIZ definition to hdlc/ioctl.h

2016-11-15 Thread Mikko Rapeli
;>> On Tue, Aug 23, 2016 at 1:30 AM, David Miller wrote: > >>>> From: Mikko Rapeli > >>>> Date: Mon, 22 Aug 2016 20:32:44 +0200 > >>>> > >>>>> Fixes userspace compiler error: > >>>>> > >>>>

Re: [PATCH v05 14/72] include/uapi/asm-generic/ipcbuf.h: include linux/posix_types.h

2016-11-15 Thread Mikko Rapeli
On Wed, Aug 24, 2016 at 05:36:22PM +0200, Arnd Bergmann wrote: > On Monday, August 22, 2016 8:32:31 PM CEST Mikko Rapeli wrote: > > Fixes userspace compilation error: > > > > error: unknown type name ‘__kernel_key_t’ > > > > Signed-off-by: Mikko Rapeli >

Re: [PATCH v05 69/72] uapi rose.h: glibc netrose/rose.h header file compatibility fixes

2016-08-30 Thread Mikko Rapeli
On Mon, Aug 29, 2016 at 12:34:25PM -0700, David Ranch wrote: > Hello Mikko, > > Somewhat related, the ax25.h file from libax25-devel also has conflicts with > the Glibc's ax.25.h. This creates trouble so if we could get a fix for > that, that would be appreciated as well though it might be a Glib

Re: [PATCH v05 06/72] include/uapi/linux/hsi/cs-protocol.h: include linux/time.h

2016-08-28 Thread Mikko Rapeli
On Mon, Aug 22, 2016 at 10:52:20PM +0200, Sebastian Reichel wrote: > Hi, > > On Mon, Aug 22, 2016 at 08:32:23PM +0200, Mikko Rapeli wrote: > > Fixes userspace compilation errors due to missing timespec definition. > > > > Signed-off-by: Mikko Rapeli > > -

[PATCH v06] uapi dm-log-userspace.h: use __u32, __s32, __u64 and __s64 from linux/types.h

2016-08-27 Thread Mikko Rapeli
Fixes userspace compilation errors like: linux/dm-log-userspace.h:416:2: error: unknown type name ‘uint64_t’ Signed-off-by: Mikko Rapeli Cc: Bart Van Assche --- include/uapi/linux/dm-log-userspace.h | 53 ++- 1 file changed, 27 insertions(+), 26 deletions

Re: [PATCH v05 69/72] uapi rose.h: glibc netrose/rose.h header file compatibility fixes

2016-08-27 Thread Mikko Rapeli
On Fri, Aug 26, 2016 at 05:38:00PM +0200, walter harms wrote: > perhaps this not tested snipped would make sure that > you have included linux/rose.h ? > > #ifndef ROSE_KERNEL_H > #include > #endif > > #include Sorry, I did not quite get this. has conflicting definitions with glibc . The pat

Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h

2016-08-25 Thread Mikko Rapeli
On Thu, Aug 25, 2016 at 04:24:11AM +, Bart Van Assche wrote: > On 08/23/16 13:42, Mikko Rapeli wrote: > > On Tue, Aug 23, 2016 at 02:28:19PM +, Bart Van Assche wrote: > >> On 08/23/16 06:57, Bart Van Assche wrote: > >>> On 08/22/16 11:32, Mikko Rap

Re: [PATCH v05 66/72] uapi icmp.h: glibc netinet/ip_icmp.h header file compatibility fixes

2016-08-23 Thread Mikko Rapeli
On Mon, Aug 22, 2016 at 04:32:51PM -0700, David Miller wrote: > You have to post this properly to the netdev list. > > If netdev is not CC:'d it doesn't get properly logged in patchwork, > and won't be applied. Sorry, get_maintainers.pl did not find netdev list for these patches. Could you updat

Re: [PATCH v05 47/72] include/uapi/linux/coda.h: use __kernel_pid_t and add u_short etc definitions for userspace

2016-08-23 Thread Mikko Rapeli
> https://github.com/0day-ci/linux/commits/Mikko-Rapeli/Userspace-compile-test-and-fixes-for-exported-uapi-header-files/20160823-034928 > config: x86_64-randconfig-v0-08230740 (attached as .config) > compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 > reproduce: > # save the attach

Re: [PATCH v05 08/72] rds.h: use __u8, __u16, __s16, __u32 and __s64 from linux/types.h

2016-08-23 Thread Mikko Rapeli
On Mon, Aug 22, 2016 at 02:52:58PM -0400, Sowmini Varadhan wrote: > On (08/22/16 20:32), Mikko Rapeli wrote: > > > > Fixes userspace compilation errors like: > > > > linux/rds.h:96:2: error: unknown type name ‘uint8_t’ > > > > Signed-off-by: Mikko Rapeli

Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h

2016-08-23 Thread Mikko Rapeli
On Tue, Aug 23, 2016 at 02:28:19PM +, Bart Van Assche wrote: > On 08/23/16 06:57, Bart Van Assche wrote: > > On 08/22/16 11:32, Mikko Rapeli wrote: > >> - * uint32_t (*get_region_size)(struct dm_dirty_log *log); > >> + * __u32 (*get_region_size)(struct dm_dirty_log *

Re: [PATCH v05 54/72] include/uapi/xen/privcmd.h: fix compilation in userspace

2016-08-23 Thread Mikko Rapeli
On Tue, Aug 23, 2016 at 11:13:52AM -0700, Stefano Stabellini wrote: > On Tue, 23 Aug 2016, Russell King - ARM Linux wrote: > > On Mon, Aug 22, 2016 at 08:33:11PM +0200, Mikko Rapeli wrote: > > > xen/interface/xen.h is not exported from kernel headers so remove the > >

Re: [PATCH v05 34/72] include/uapi/linux/errqueue.h: include linux/time.h

2016-08-23 Thread Mikko Rapeli
Thanks! It never occurred to me to test kernel documentation builds. I will have a look now. -Mikko

Re: [PATCH v05 50/72] include/uapi/linux/fuse.h: use linux/types.h also in userspace

2016-08-23 Thread Mikko Rapeli
On Tue, Aug 23, 2016 at 09:16:22AM +0200, Miklos Szeredi wrote: > On Mon, Aug 22, 2016 at 8:33 PM, Mikko Rapeli wrote: > > Kernel headers should not use stdint.h. > > > > NACK. > > This header is used by more than one OS. Having a different version > for differ

Re: [PATCH v05 06/72] include/uapi/linux/hsi/cs-protocol.h: include linux/time.h

2016-08-22 Thread Mikko Rapeli
On Mon, Aug 22, 2016 at 10:52:20PM +0200, Sebastian Reichel wrote: > Hi, > > On Mon, Aug 22, 2016 at 08:32:23PM +0200, Mikko Rapeli wrote: > > Fixes userspace compilation errors due to missing timespec definition. > > > > Signed-off-by: Mikko Rapeli > > -

Re: [PATCH v05 38/72] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

2016-08-22 Thread Mikko Rapeli
On Mon, Aug 22, 2016 at 12:39:38PM -0700, Stephen Hemminger wrote: > On Mon, 22 Aug 2016 20:32:55 +0200 > Mikko Rapeli wrote: > > > Fixes userspace compiler error: > > > > error: unknown type name ‘uint32_t’ > > > > Signed-off-by: Mikko Rapeli > >

Re: [PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h

2016-08-22 Thread Mikko Rapeli
On Mon, Aug 22, 2016 at 12:37:45PM -0700, Stephen Hemminger wrote: > On Mon, 22 Aug 2016 20:32:38 +0200 > Mikko Rapeli wrote: > > > Fixes userspace compilation error: > > > > error: ‘IFNAMSIZ’ undeclared here (not in a function) > > > > Signed-off-by:

[PATCH v05 71/72] uapi term*.h: glibc termios.h header file compatibility fixes

2016-08-22 Thread Mikko Rapeli
#define NCCS 32 ^ Signed-off-by: Mikko Rapeli --- include/uapi/asm-generic/termbits.h | 3 +++ include/uapi/asm-generic/termios.h | 5 + include/uapi/linux/libc-compat.h| 28 3 files changed, 36 insertions(+) diff --git a/include/uapi/asm-generic/termbits.h b/i

[PATCH v05 51/72] include/linux/ipmi-fru.h: use linux/types.h instead of stdint.h

2016-08-22 Thread Mikko Rapeli
Kernel headers should use linux/types.h types. Signed-off-by: Mikko Rapeli --- include/linux/ipmi-fru.h | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/include/linux/ipmi-fru.h b/include/linux/ipmi-fru.h index 4d3a763..ceecf1f 100644 --- a

[PATCH v05 22/72] include/uapi/linux/if_tunnel.h: include linux/if.h, linux/ip.h and linux/in6.h

2016-08-22 Thread Mikko Rapeli
Fixes userspace compilation errors like: error: field ‘iph’ has incomplete type error: field ‘prefix’ has incomplete type Signed-off-by: Mikko Rapeli --- include/uapi/linux/if_tunnel.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/if_tunnel.h b/include/uapi/linux

[PATCH v05 59/72] include/uapi/linux/errqueue.h: include time.h in userspace

2016-08-22 Thread Mikko Rapeli
linux/time.h conflicts with userspace header time.h. Try to be compatible for kernel and userspace. Signed-off-by: Mikko Rapeli --- include/uapi/linux/errqueue.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/linux/errqueue.h b/include/uapi/linux/errqueue.h index 6b1cdc6

[PATCH v05 61/72] include/uapi/rdma/rdma_user_rxe.h: include in.h and in6.h

2016-08-22 Thread Mikko Rapeli
struct sockaddr_in _sockaddr_in; ^~~~ rdma/rdma_user_rxe.h:61:23: error: field ‘_sockaddr_in6’ has incomplete type struct sockaddr_in6 _sockaddr_in6; ^ Signed-off-by: Mikko Rapeli --- include/uapi/rdma/rdma_user_rxe.h | 2 ++ 1 file

[PATCH v05 53/72] include/linux/xz.h: use linux/types.h types instead of stdint.h

2016-08-22 Thread Mikko Rapeli
Kernel headers should use linux/types.h types. Signed-off-by: Mikko Rapeli --- include/linux/xz.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/include/linux/xz.h b/include/linux/xz.h index 64cffa6..7686511 100644 --- a/include/linux/xz.h +++ b/include/linux

[PATCH v05 58/72] include/uapi/linux/elfcore.h: remove non-compiling userspace parts

2016-08-22 Thread Mikko Rapeli
compiles but is generally not usable for things like core dump parsing but luckily userspace users already know this and have their own modified version of the needed definitions and headers. But at least this compiles now. Signed-off-by: Mikko Rapeli --- include/uapi/linux/elfcore.h | 21

[PATCH v05 67/72] uapi uio.h: glibc sys/uio.h header file compatibility fixes

2016-08-22 Thread Mikko Rapeli
Fixes this userspace compile error when glibc sys/uio.h is included before linux/uio.h: linux/uio.h:16:8: error: redefinition of ‘struct iovec’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/libc-compat.h | 10 ++ include/uapi/linux/uio.h | 4 +++- 2 files changed, 13

[PATCH v05 70/72] uapi time.h: glibc time.h header file compatibility fixes

2016-08-22 Thread Mikko Rapeli
al’ linux/time.h:67:0: warning: "TIMER_ABSTIME" redefined Signed-off-by: Mikko Rapeli --- include/uapi/linux/libc-compat.h | 37 + include/uapi/linux/time.h| 18 -- 2 files changed, 53 insertions(+), 2 deletions(-) diff --git a/include

[PATCH v05 64/72] include/uapi/linux/ipx.h: fix conflicting defitions with glibc netipx/ipx.h

2016-08-22 Thread Mikko Rapeli
ipx_interface_definition’ ./linux/ipx.h:49:8: error: redefinition of ‘struct ipx_config_data’ ./linux/ipx.h:58:8: error: redefinition of ‘struct ipx_route_def’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/ipx.h | 13 - include/uapi/linux/libc-compat.h | 26

[PATCH v05 20/72] include/uapi/linux/rds.h: include linux/socket.h and linux/types.h

2016-08-22 Thread Mikko Rapeli
Fixes userspace compilation errors like: error: unknown type name ‘__be32’ error: field ‘dest_addr’ has incomplete type struct sockaddr_storage dest_addr; Signed-off-by: Mikko Rapeli Acked-by: Sowmini Varadhan --- include/uapi/linux/rds.h | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v05 63/72] include/uapi/sound/Kbuild: remove sound/asoc.h from userspace

2016-08-22 Thread Mikko Rapeli
here. ^ Signed-off-by: Mikko Rapeli --- include/uapi/sound/Kbuild | 1 - 1 file changed, 1 deletion(-) diff --git a/include/uapi/sound/Kbuild b/include/uapi/sound/Kbuild index 691984c..6d8b203 100644 --- a/include/uapi/sound/Kbuild +++ b/include/uapi/sound/Kbuild @@ -1,6 +1,5 @@ # UAPI

[PATCH v05 56/72] include/uapi/xen/evtchn.h: include xen/privcmd.h

2016-08-22 Thread Mikko Rapeli
It has definition of domid_t. Fixes userspace compiler error when xen/privcmd.h is compiled alone: xen/evtchn.h:100:2: error: unknown type name ‘domid_t’ domid_t domid; ^~~ Signed-off-by: Mikko Rapeli --- include/uapi/xen/evtchn.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH v05 50/72] include/uapi/linux/fuse.h: use linux/types.h also in userspace

2016-08-22 Thread Mikko Rapeli
Kernel headers should not use stdint.h. Signed-off-by: Mikko Rapeli Cc: Arnd Bergmann Cc: Miklos Szeredi --- include/uapi/linux/fuse.h | 452 +++--- 1 file changed, 224 insertions(+), 228 deletions(-) diff --git a/include/uapi/linux/fuse.h b/include

[PATCH v05 68/72] uapi ax25.h: glibc netax25/ax25.h header file compatibility fixes

2016-08-22 Thread Mikko Rapeli
efinition of ‘struct ax25_ctl_struct’ linux/ax25.h:98:8: error: redefinition of ‘struct ax25_info_struct’ linux/ax25.h:111:8: error: redefinition of ‘struct ax25_fwd_struct’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/ax25.h| 22 + include/uapi/linu

[PATCH v05 24/72] include/uapi/linux/ipv6_route.h: include linux/in6.h

2016-08-22 Thread Mikko Rapeli
Fixes userspace compile errors like: error: field ‘rtmsg_dst’ has incomplete type struct in6_addr rtmsg_dst; Signed-off-by: Mikko Rapeli --- include/uapi/linux/ipv6_route.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/ipv6_route.h b/include/uapi/linux/ipv6_route.h

[PATCH v05 23/72] include/uapi/linux/ipv6_route.h: include linux/in6.h

2016-08-22 Thread Mikko Rapeli
Fixes userspace compile errors like: error: field ‘mf6cc_origin’ has incomplete type struct sockaddr_in6 mf6cc_origin; /* Origin of mcast */ Signed-off-by: Mikko Rapeli --- include/uapi/linux/mroute6.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/mroute6.h b

[PATCH v05 60/72] arch/arm/include/uapi/asm/signal.h: use __kernel_size_t instead of size_t

2016-08-22 Thread Mikko Rapeli
Fixes uapi header compilation error from userspace on ARCH=arm: asm/signal.h:112:2: error: unknown type name ‘size_t’ size_t ss_size; Signed-off-by: Mikko Rapeli --- arch/arm/include/uapi/asm/signal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/include/uapi

[PATCH v05 52/72] include/linux/sdb.h: use linux/types.h types instead of stdint.h

2016-08-22 Thread Mikko Rapeli
Kernel headers should use linux/types.h types. Signed-off-by: Mikko Rapeli --- include/linux/sdb.h | 62 + 1 file changed, 29 insertions(+), 33 deletions(-) diff --git a/include/linux/sdb.h b/include/linux/sdb.h index fbb76a4..e9ff976 100644

[PATCH v05 19/72] include/uapi/linux/socket.h: include sys/socket.h in userspace

2016-08-22 Thread Mikko Rapeli
This libc header has sockaddr definition for userspace. Fixes userspace compilation errors like these from kernel headers including only linux/socket.h: error: field ‘ifru_addr’ has incomplete type struct sockaddr ifru_addr; Signed-off-by: Mikko Rapeli --- include/uapi/linux/socket.h | 4

[PATCH v05 54/72] include/uapi/xen/privcmd.h: fix compilation in userspace

2016-08-22 Thread Mikko Rapeli
ef for ARM is ugly but did not find better solutions for it. Fixes userspace compilation error: xen/privcmd.h:38:31: fatal error: xen/interface/xen.h: No such file or directory Signed-off-by: Mikko Rapeli Cc: David Vrabel --- arch/arm/include/asm/xen/interface.h | 2 +- include/uapi/xen/pri

[PATCH v05 69/72] uapi rose.h: glibc netrose/rose.h header file compatibility fixes

2016-08-22 Thread Mikko Rapeli
rose.h:74:8: error: redefinition of ‘struct rose_cause_struct’ linux/rose.h:79:8: error: redefinition of ‘struct rose_facilities_struct’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/libc-compat.h | 30 ++ include/uapi/linux/rose.h| 15 +++ 2

[PATCH v05 57/72] coda_psdev.h: move upc_req definition from uapi to kernel side headers

2016-08-22 Thread Mikko Rapeli
_short uc_opcode; /* copied from data to save lookup */ ^ ./linux/coda_psdev.h:19:2: error: unknown type name ‘wait_queue_head_t’ wait_queue_head_t uc_sleep; /* process' wait queue */ ^ Signed-off-by: Mikko Rapeli --- include/linux/coda_psdev.h | 11 +++ include

[PATCH v05 21/72] include/uapi/linux/if_pppox.h: include linux/if.h

2016-08-22 Thread Mikko Rapeli
Fixes userspace compilation error: error: ‘IFNAMSIZ’ undeclared here (not in a function) Signed-off-by: Mikko Rapeli --- include/uapi/linux/if_pppox.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_pppox.h b/include/uapi/linux/if_pppox.h index e128769..473c3c4 100644

[PATCH v05 65/72] uapi fcntl.h: glibc fcntl.h header file compatibility fixes

2016-08-22 Thread Mikko Rapeli
fined asm-generic/fcntl.h:21:0: warning: "O_RDWR" redefined asm-generic/fcntl.h:195:8: error: redefinition of ‘struct flock’ linux/fcntl.h:16:0: warning: "F_DUPFD_CLOEXEC" redefined Signed-off-by: Mikko Rapeli --- include/uapi/asm-generic/fcntl.h | 6 ++ include/uapi/lin

[PATCH v05 72/72] uapi route.h: glibc net/route.h compat fix

2016-08-22 Thread Mikko Rapeli
Fixes this userspace compile error when net/route.h is included before linux/route.h: linux/route.h:30:8: error: redefinition of ‘struct rtentry’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/libc-compat.h | 10 ++ include/uapi/linux/route.h | 4 +++- 2 files changed, 13

[PATCH v05 66/72] uapi icmp.h: glibc netinet/ip_icmp.h header file compatibility fixes

2016-08-22 Thread Mikko Rapeli
Fixes this userspace compile error when glibc netinet/ip_icmp.h is included before linux/icmp.h: linux/icmp.h:68:8: error: redefinition of ‘struct icmphdr’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/icmp.h| 4 +++- include/uapi/linux/libc-compat.h | 10 ++ 2 files

[PATCH v05 55/72] include/uapi/xen/gntdev.h: include xen/privcmd.h and define grant_ref_t

2016-08-22 Thread Mikko Rapeli
Both are needed to compile wihtout compiler warnings in userspace. Fixes these userspace compile errors: xen/gntdev.h:151:4: error: unknown type name ‘grant_ref_t’ grant_ref_t ref; ^ xen/gntdev.h:153:4: error: unknown type name ‘domid_t’ domid_t domid; ^ Signed-off-by: Mikko

  1   2   3   4   5   >