it later.
Hey guys,
I notice that these patches are not in acme's perf/core branch. Can they be
applied there too please?
Thanks
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
smime.p7s
_msr ([kernel.kallsyms])
>
> The new syntax cannot be mixed with normal overriding.
Tested-by: Milian Wolff <milian.wo...@kdab.com>
Works a charm.
But I notice that this functionality is missing in other places too. Most
notably, I would like to be able to configure `perf stat` in a
gt;
> The new syntax cannot be mixed with normal overriding.
Tested-by: Milian Wolff
Works a charm.
But I notice that this functionality is missing in other places too. Most
notably, I would like to be able to configure `perf stat` in a similar way.
Such that one could do:
perf stat -e +c
Commit-ID: 2538b9e2450ae255337c04356e9e0f8cb9ec48d9
Gitweb: http://git.kernel.org/tip/2538b9e2450ae255337c04356e9e0f8cb9ec48d9
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Fri, 2 Jun 2017 16:37:52 +0200
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Commit
Commit-ID: 2538b9e2450ae255337c04356e9e0f8cb9ec48d9
Gitweb: http://git.kernel.org/tip/2538b9e2450ae255337c04356e9e0f8cb9ec48d9
Author: Milian Wolff
AuthorDate: Fri, 2 Jun 2017 16:37:52 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 5 Jun 2017 14:18:05 -0300
perf report
Commit-ID: 5ea0416f51cc93436bbe497c62ab49fd9cb245b6
Gitweb: http://git.kernel.org/tip/5ea0416f51cc93436bbe497c62ab49fd9cb245b6
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Thu, 1 Jun 2017 23:00:21 +0200
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Commit
Commit-ID: 5ea0416f51cc93436bbe497c62ab49fd9cb245b6
Gitweb: http://git.kernel.org/tip/5ea0416f51cc93436bbe497c62ab49fd9cb245b6
Author: Milian Wolff
AuthorDate: Thu, 1 Jun 2017 23:00:21 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 5 Jun 2017 14:18:03 -0300
perf report
On Tuesday, June 6, 2017 3:33:49 AM CEST Namhyung Kim wrote:
> On Sat, Jun 3, 2017 at 10:51 PM, Milian Wolff <milian.wo...@kdab.com> wrote:
> > On Montag, 22. Mai 2017 14:48:18 CEST Namhyung Kim wrote:
> >> On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote:
&
On Tuesday, June 6, 2017 3:33:49 AM CEST Namhyung Kim wrote:
> On Sat, Jun 3, 2017 at 10:51 PM, Milian Wolff wrote:
> > On Montag, 22. Mai 2017 14:48:18 CEST Namhyung Kim wrote:
> >> On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote:
> >> > The origina
On Montag, 22. Mai 2017 14:48:18 CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote:
> > The original patch that introduced inline frame output in the
> > various browsers used this suffix already. The new centralized
> > approach t
On Montag, 22. Mai 2017 14:48:18 CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote:
> > The original patch that introduced inline frame output in the
> > various browsers used this suffix already. The new centralized
> > approach t
On Freitag, 2. Juni 2017 21:49:10 CEST Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 02, 2017 at 06:21:44PM +0200, Milian Wolff escreveu:
> > On Freitag, 2. Juni 2017 17:23:41 CEST Arnaldo Carvalho de Melo wrote:
> > > Looks ok, having both implementations matching and the
On Freitag, 2. Juni 2017 21:49:10 CEST Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 02, 2017 at 06:21:44PM +0200, Milian Wolff escreveu:
> > On Freitag, 2. Juni 2017 17:23:41 CEST Arnaldo Carvalho de Melo wrote:
> > > Looks ok, having both implementations matching and the
On Freitag, 2. Juni 2017 17:23:41 CEST Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 02, 2017 at 04:37:52PM +0200, Milian Wolff escreveu:
> > In some situations the libdw unwinder stopped working properly.
> > I.e. with libunwind we see:
> >
> > ~
> >
>
On Freitag, 2. Juni 2017 17:23:41 CEST Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 02, 2017 at 04:37:52PM +0200, Milian Wolff escreveu:
> > In some situations the libdw unwinder stopped working properly.
> > I.e. with libunwind we see:
> >
> > ~
> >
>
<a...@redhat.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/unwind-libdw.c | 8
1 file changed, 8 insertions(+)
diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/u
: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Milian Wolff
---
tools/perf/util/unwind-libdw.c | 8
1 file changed, 8 insertions(+)
diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c
index da45c4be5fb3..7755a5e0fe5e 100644
--- a/tools/perf/util/unwind-libdw.c
+++ b
.
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/unwind-libdw.c | 8
1 file changed, 8 insertions(+)
diff --git a/tools/pe
.
Cc: Arnaldo Carvalho de Melo
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Milian Wolff
---
tools/perf/util/unwind-libdw.c | 8
1 file changed, 8 insertions(+)
diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c
index b4c20124d2ee..da45c4be5fb3 100644
cycles:
~
With this patch applied, the libdw unwinder will produce the same
output as the libunwind unwinder.
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Milian Wolff <milian.wo...
cycles:
~
With this patch applied, the libdw unwinder will produce the same
output as the libunwind unwinder.
Cc: Arnaldo Carvalho de Melo
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Milian Wolff
---
tools/perf/util/unwind-libdw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On Mittwoch, 24. Mai 2017 17:02:37 CEST Namhyung Kim wrote:
> On Wed, May 24, 2017 at 03:42:59PM +0200, Milian Wolff wrote:
> > On Wednesday, May 24, 2017 1:46:04 PM CEST Milian Wolff wrote:
> > > On Monday, May 22, 2017 11:06:43 AM CEST Namhyung Kim wrote:
> > > >
On Mittwoch, 24. Mai 2017 17:02:37 CEST Namhyung Kim wrote:
> On Wed, May 24, 2017 at 03:42:59PM +0200, Milian Wolff wrote:
> > On Wednesday, May 24, 2017 1:46:04 PM CEST Milian Wolff wrote:
> > > On Monday, May 22, 2017 11:06:43 AM CEST Namhyung Kim wrote:
> > > >
On Wednesday, May 24, 2017 1:46:04 PM CEST Milian Wolff wrote:
> On Monday, May 22, 2017 11:06:43 AM CEST Namhyung Kim wrote:
> > Hi Milian,
> >
> > On Thu, May 18, 2017 at 10:05:36PM +0200, Milian Wolff wrote:
> > > On Donnerstag, 18. Mai 2017 21
On Wednesday, May 24, 2017 1:46:04 PM CEST Milian Wolff wrote:
> On Monday, May 22, 2017 11:06:43 AM CEST Namhyung Kim wrote:
> > Hi Milian,
> >
> > On Thu, May 18, 2017 at 10:05:36PM +0200, Milian Wolff wrote:
> > > On Donnerstag, 18. Mai 2017 21
On Monday, May 22, 2017 11:06:43 AM CEST Namhyung Kim wrote:
> Hi Milian,
>
> On Thu, May 18, 2017 at 10:05:36PM +0200, Milian Wolff wrote:
> > On Donnerstag, 18. Mai 2017 21:34:04 CEST Milian Wolff wrote:
> > > This series of patches completely reworks the way inline
On Monday, May 22, 2017 11:06:43 AM CEST Namhyung Kim wrote:
> Hi Milian,
>
> On Thu, May 18, 2017 at 10:05:36PM +0200, Milian Wolff wrote:
> > On Donnerstag, 18. Mai 2017 21:34:04 CEST Milian Wolff wrote:
> > > This series of patches completely reworks the way inline
On Monday, May 22, 2017 2:48:18 PM CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote:
> > The original patch that introduced inline frame output in the
> > various browsers used this suffix already. The new centralized
> > approach t
On Monday, May 22, 2017 2:48:18 PM CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote:
> > The original patch that introduced inline frame output in the
> > various browsers used this suffix already. The new centralized
> > approach t
On Monday, May 22, 2017 2:11:58 PM CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:11PM +0200, Milian Wolff wrote:
> > Instead of showing the (repeated) DSO name of the non-inlined
> > frame, we now show the "(inlined)" suffix instead.
> >
> >
On Monday, May 22, 2017 2:11:58 PM CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:11PM +0200, Milian Wolff wrote:
> > Instead of showing the (repeated) DSO name of the non-inlined
> > frame, we now show the "(inlined)" suffix instead.
> >
> >
On Monday, May 22, 2017 2:19:46 PM CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:07PM +0200, Milian Wolff wrote:
> > +
> > + if (strcmp(funcname, base_sym->name) == 0) {
> > + // reuse the real, existing symbol
>
> I don't know whether it's
On Monday, May 22, 2017 2:19:46 PM CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:07PM +0200, Milian Wolff wrote:
> > +
> > + if (strcmp(funcname, base_sym->name) == 0) {
> > + // reuse the real, existing symbol
>
> I don't know whether it's
included. Adding a
> non-debugging feature as a non-default command line option is really as if
> we didn't do anything: very few if any people will use it, and it might
> bitrot in the future without people noticing.
>
> So we need apply some thought into making it available to two
thing: very few if any people will use it, and it might
> bitrot in the future without people noticing.
>
> So we need apply some thought into making it available to two orders of
> magnitude more people! If someone types 'perf report' we should give the
> best selection of all the f
Commit-ID: 4d53b9d546f9f4505e6e3d58c8eed894d6f684e7
Gitweb: http://git.kernel.org/tip/4d53b9d546f9f4505e6e3d58c8eed894d6f684e7
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Wed, 24 May 2017 15:21:28 +0900
Committer: Ingo Molnar <mi...@kernel.org>
CommitDate: Wed,
Commit-ID: b21cc97810932a551f7aac46f0b89c469c828b3f
Gitweb: http://git.kernel.org/tip/b21cc97810932a551f7aac46f0b89c469c828b3f
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Wed, 24 May 2017 15:21:24 +0900
Committer: Ingo Molnar <mi...@kernel.org>
CommitDate: Wed,
Commit-ID: 4d53b9d546f9f4505e6e3d58c8eed894d6f684e7
Gitweb: http://git.kernel.org/tip/4d53b9d546f9f4505e6e3d58c8eed894d6f684e7
Author: Milian Wolff
AuthorDate: Wed, 24 May 2017 15:21:28 +0900
Committer: Ingo Molnar
CommitDate: Wed, 24 May 2017 08:41:48 +0200
perf report: Do not drop
Commit-ID: b21cc97810932a551f7aac46f0b89c469c828b3f
Gitweb: http://git.kernel.org/tip/b21cc97810932a551f7aac46f0b89c469c828b3f
Author: Milian Wolff
AuthorDate: Wed, 24 May 2017 15:21:24 +0900
Committer: Ingo Molnar
CommitDate: Wed, 24 May 2017 08:41:48 +0200
perf report: Fix memory
Commit-ID: 28071f51839e393f697d0d1df0b223a4bc373606
Gitweb: http://git.kernel.org/tip/28071f51839e393f697d0d1df0b223a4bc373606
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Wed, 24 May 2017 15:21:27 +0900
Committer: Ingo Molnar <mi...@kernel.org>
CommitDate: Wed,
Commit-ID: 28071f51839e393f697d0d1df0b223a4bc373606
Gitweb: http://git.kernel.org/tip/28071f51839e393f697d0d1df0b223a4bc373606
Author: Milian Wolff
AuthorDate: Wed, 24 May 2017 15:21:27 +0900
Committer: Ingo Molnar
CommitDate: Wed, 24 May 2017 08:41:48 +0200
perf report: Always honor
Commit-ID: 7d4df089d77306914426a604c890175f91a9a459
Gitweb: http://git.kernel.org/tip/7d4df089d77306914426a604c890175f91a9a459
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Wed, 24 May 2017 15:21:23 +0900
Committer: Ingo Molnar <mi...@kernel.org>
CommitDate: Wed,
Commit-ID: 1982ad48fc82c284a5cc55697a012d3357e84d01
Gitweb: http://git.kernel.org/tip/1982ad48fc82c284a5cc55697a012d3357e84d01
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Wed, 24 May 2017 15:21:25 +0900
Committer: Ingo Molnar <mi...@kernel.org>
CommitDate: Wed,
Commit-ID: 7d4df089d77306914426a604c890175f91a9a459
Gitweb: http://git.kernel.org/tip/7d4df089d77306914426a604c890175f91a9a459
Author: Milian Wolff
AuthorDate: Wed, 24 May 2017 15:21:23 +0900
Committer: Ingo Molnar
CommitDate: Wed, 24 May 2017 08:41:47 +0200
perf report: Don't crash
Commit-ID: 1982ad48fc82c284a5cc55697a012d3357e84d01
Gitweb: http://git.kernel.org/tip/1982ad48fc82c284a5cc55697a012d3357e84d01
Author: Milian Wolff
AuthorDate: Wed, 24 May 2017 15:21:25 +0900
Committer: Ingo Molnar
CommitDate: Wed, 24 May 2017 08:41:48 +0200
perf report: Fix off
On Donnerstag, 18. Mai 2017 21:34:04 CEST Milian Wolff wrote:
> This series of patches completely reworks the way inline frames are handled.
> Instead of querying for the inline nodes on-demand in the individual tools,
> we now create proper callchain nodes for inlined frames. The a
On Donnerstag, 18. Mai 2017 21:34:04 CEST Milian Wolff wrote:
> This series of patches completely reworks the way inline frames are handled.
> Instead of querying for the inline nodes on-demand in the individual tools,
> we now create proper callchain nodes for inlined frames. The a
...@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/symbol-elf.c | 2 +-
tools/perf/util/symbol-minimal.c | 2 +-
tools/perf/util/symbol.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/symbol-
The input string is not modified and thus can be passed
in as a pointer to const data.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/symbol-elf.c | 2 +-
tools/perf/util/symbol-minimal.c | 2
<a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/callchain.c | 2
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 26 --
tools/perf/util/callchain.h | 5 +++--
tools/perf/util/machine.c | 19 +---
tools/perf/util/srcline.c | 53
transparently display inlined
frames without having to patch their code.
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com&g
hello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/callchain.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index 211ed3713
. This allows us to efficiently lookup
the symbol for a given name without first having to append the
suffix before the lookup.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 10
transparently display inlined
frames without having to patch their code.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/dso.c | 2 +
tools/perf/util/dso.h | 1 +
tools/perf/util/machine.c
c: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/evsel_fprintf.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
Signed-off-by: Milian Wolff
---
tools/perf/util/evsel_fprintf.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c
index f2c6c5ee11e8..5b9e89257aa7 100644
--- a/tools/perf/util/evsel_fprintf.c
+++ b/tools
ijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/ui/browsers/hists.c | 183 +++-
tools/perf/ui/stdio/hist.c | 80 +-
tools/perf/util/evsel_fprintf.c |
| |
| --0.85%--cabs
~
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo.
A follow-up commit will make inline frames first-class citizens
in the callchain, thereby obsoleting all of this special code.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/ui/browsers/hists.c | 183
| |
| --0.85%--cabs
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/tools/perf/util/callchain.c b
__libc_start_main
| _start
...
# NOTE: the first and last entry of the inline stack have the correct symbol
and srcline now
both function and srcline is shown, as well as the (inlined) suffix
only the basename of the srcline is shown
~
Milian Wolff (7):
perf
e correct symbol
and srcline now
both function and srcline is shown, as well as the (inlined) suffix
only the basename of the srcline is shown
~
Milian Wolff (7):
perf report: remove code to handle inline frames from browsers
perf util: take elf_name as const string in dso__de
On Mittwoch, 17. Mai 2017 08:13:16 CEST Namhyung Kim wrote:
> On Tue, May 16, 2017 at 03:18:13PM +0200, Milian Wolff wrote:
> > On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote:
> > > On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote:
> > > > On M
On Mittwoch, 17. Mai 2017 08:13:16 CEST Namhyung Kim wrote:
> On Tue, May 16, 2017 at 03:18:13PM +0200, Milian Wolff wrote:
> > On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote:
> > > On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote:
> > > > On M
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tool
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/srcline.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
v3:
- use actual command output in commit message
v2:
- rebase a
linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/srcline.c | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
v3:
- minimize code changes
v2:
- directly create list in correct order as suggested by Namhyung
diff --git a/tools/p
the list
and also ensures that all callers construct the list in the right
order.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/srcline.c | 18 --
1 file changed, 4 insertions(+), 14
On Donnerstag, 18. Mai 2017 11:55:38 CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 10:38:22AM +0200, Milian Wolff wrote:
> > The very last inlined frame, i.e. the one furthest away from the
> > non-inlined frame, was silently dropped. This is apparent when
> > comparin
On Donnerstag, 18. Mai 2017 11:55:38 CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 10:38:22AM +0200, Milian Wolff wrote:
> > The very last inlined frame, i.e. the one furthest away from the
> > non-inlined frame, was silently dropped. This is apparent when
> > comparin
On Donnerstag, 18. Mai 2017 11:48:20 CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 10:37:59AM +0200, Milian Wolff wrote:
> > So far, the inlined nodes where only reversed when we built perf
> > against libbfd. If that was not available, the addr2line fallback
> >
On Donnerstag, 18. Mai 2017 11:48:20 CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 10:37:59AM +0200, Milian Wolff wrote:
> > So far, the inlined nodes where only reversed when we built perf
> > against libbfd. If that was not available, the addr2line fallback
> >
linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/srcline.c | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
v2:
- directly create list in correct order as suggested by Namhyung
diff --git a/tools/perf/util/srcline
libc-2.25.so)
bd9 _start (/tmp/a.out)
~
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-o
the list
and also ensures that all callers construct the list in the right
order.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/srcline.c | 23 ---
1 file changed, 8 insertions
libc-2.25.so)
bd9 _start (/tmp/a.out)
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/srcline.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
v2:
- re
rame for any but the very first frame.
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milia
<dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/srcline.c | 23 +--
1 file changed, 1
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/unwind-libdw.c | 6 +-
tools/perf/util/unwind-libunwind-local.c | 11 +++
2 files changed, 16 insertions(+), 1 deletion(-)
v2:
- use unw_is_signal_frame to
Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/srcline.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
v2:
- keep behavior of old function when strdup failed
- set ret to 1 if we found any inline node
diff --git a/tools/perf/util
On Mittwoch, 17. Mai 2017 07:12:21 CEST Namhyung Kim wrote:
> On Tue, May 16, 2017 at 06:26:47PM +0200, Milian Wolff wrote:
> > On Dienstag, 16. Mai 2017 18:17:26 CEST Milian Wolff wrote:
> > > On Dienstag, 16. Mai 2017 16:38:29 CEST Namhyung Kim wrote:
> > > > On T
On Mittwoch, 17. Mai 2017 07:12:21 CEST Namhyung Kim wrote:
> On Tue, May 16, 2017 at 06:26:47PM +0200, Milian Wolff wrote:
> > On Dienstag, 16. Mai 2017 18:17:26 CEST Milian Wolff wrote:
> > > On Dienstag, 16. Mai 2017 16:38:29 CEST Namhyung Kim wrote:
> > > > On T
the token
> to be a number, it's good to show the warning there.
>
> Cc: Milian Wolff <milian.wo...@kdab.com>
> Cc: Frederic Weisbecker <fweis...@gmail.com>
> Signed-off-by: Namhyung Kim <namhy...@kernel.org>
Thank you, that annoyed me too. Tested and reviewed it,
the token
> to be a number, it's good to show the warning there.
>
> Cc: Milian Wolff
> Cc: Frederic Weisbecker
> Signed-off-by: Namhyung Kim
Thank you, that annoyed me too. Tested and reviewed it, works fine - thanks!
Bye
--
Milian Wolff | milian.wo...@kdab.com | Software Engin
On Wednesday, May 17, 2017 6:20:49 AM CEST Namhyung Kim wrote:
> On Tue, May 16, 2017 at 11:53:59PM +0200, Milian Wolff wrote:
> > When a filename was found in addr2line it was duplicated via strdup
> > but never freed. Now we pass NULL and handle this gracefully i
On Wednesday, May 17, 2017 6:20:49 AM CEST Namhyung Kim wrote:
> On Tue, May 16, 2017 at 11:53:59PM +0200, Milian Wolff wrote:
> > When a filename was found in addr2line it was duplicated via strdup
> > but never freed. Now we pass NULL and handle this gracefully i
On Wednesday, May 17, 2017 6:26:45 AM CEST Namhyung Kim wrote:
> On Tue, May 16, 2017 at 11:54:22PM +0200, Milian Wolff wrote:
> > So far, the inlined nodes where only reversed when we built perf
> > against libbfd. If that was not available, the addr2line fallback
> >
On Wednesday, May 17, 2017 6:26:45 AM CEST Namhyung Kim wrote:
> On Tue, May 16, 2017 at 11:54:22PM +0200, Milian Wolff wrote:
> > So far, the inlined nodes where only reversed when we built perf
> > against libbfd. If that was not available, the addr2line fallback
> >
<dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/srcline.c | 13 ++---
1 file changed, 6 insertions(+)
Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/srcline.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
index df051a52393c..62cf42c36955 100644
--- a/tools/perf/util/srcline.c
+++ b
libc-2.25.so)
bd9 _start (/tmp/a.out)
~
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-o
<a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/srcline.c | 28
libc-2.25.so)
bd9 _start (/tmp/a.out)
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/srcline.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff -
Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/srcline.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
index 62cf42c36955
n
>20511 __libc_start_main (/usr/lib/libc-2.25.so)
> 8ba _start (/home/namhyung/tmp/perf/a.out)
> ...
>
> Cc: Jin Yao <yao@linux.intel.com>
> Cc: Milian Wolff <milian.wo...@kdab.com>
Acked, tested and reviewed by me, too.
Tha
main (/usr/lib/libc-2.25.so)
> 8ba _start (/home/namhyung/tmp/perf/a.out)
> ...
>
> Cc: Jin Yao
> Cc: Milian Wolff
Acked, tested and reviewed by me, too.
Thanks a lot!
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland)
On Dienstag, 16. Mai 2017 18:17:26 CEST Milian Wolff wrote:
> On Dienstag, 16. Mai 2017 16:38:29 CEST Namhyung Kim wrote:
> > On Tue, May 16, 2017 at 10:59:51AM +0200, Milian Wolff wrote:
> > > As the documentation for dwfl_frame_pc says, frames that
> > > are no act
On Dienstag, 16. Mai 2017 18:17:26 CEST Milian Wolff wrote:
> On Dienstag, 16. Mai 2017 16:38:29 CEST Namhyung Kim wrote:
> > On Tue, May 16, 2017 at 10:59:51AM +0200, Milian Wolff wrote:
> > > As the documentation for dwfl_frame_pc says, frames that
> > > are no act
On Dienstag, 16. Mai 2017 16:38:29 CEST Namhyung Kim wrote:
> On Tue, May 16, 2017 at 10:59:51AM +0200, Milian Wolff wrote:
> > As the documentation for dwfl_frame_pc says, frames that
> > are no activation frames need to have their program counter
> > decremented by
401 - 500 of 571 matches
Mail list logo
