and
a result of a copy paste.
Reviewed-by: Mukesh Ojha
But, i would want other to comment on this, whether we really want this
kind of effort coming forward.
or can it be not done by some scripting?
Cheers,
-Mukesh
---
drivers/staging/vt6656/baseband.h | 2 +-
drivers/staging/vt6656
On 3/31/2019 2:15 PM, Oded Gabbay wrote:
GIT does not like extra blank lines at the end of the file, so this patch
removes those lines.
Signed-off-by: Oded Gabbay
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
.../misc/habanalabs/include/goya/asic_reg/cpu_ca53_cfg_masks.h | 1
but not the include.
Remove the now-unnecessary include of . No functional change
intended.
Signed-off-by: Bjorn Helgaas
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/i2c/busses/i2c-isch.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-isch.c b/drivers/i
On 3/31/2019 2:53 AM, Colin King wrote:
From: Colin Ian King
Currently the for-loop using an unsigned int for the loop counter
which is problematic when comparing it to the signed int
gt->gpio_cs_count. This is an issue because if the signed int is
negative (for example, the call to of_gpio_
On 3/31/2019 2:53 AM, Colin King wrote:
From: Colin Ian King
Currently the for-loop using an unsigned int for the loop counter
which is problematic when comparing it to the signed int
gt->gpio_cs_count. This is an issue because if the signed int is
negative (for example, the call to of_gpio_
On 3/31/2019 11:02 AM, Fuqian Huang wrote:
If the cmd is RCPK_GET_STRUCT, copy_to_user will copy
info to user space. As info->port.ops is the address of
a constant object rocket_port_ops (assigned in init_r_port),
a kernel address leakage happens.
This patch sets all the pointer fields to NULL
-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/leds/leds-blinkm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
index 851c1920b63c..11b771fb933b 100644
--- a/drivers/leds/leds-blinkm.c
+++ b/drivers/leds/leds-blinkm.c
@@ -594,7 +594,6 @@ sta
int, which turns into a more discrete:
vdso: 2 pages (1 code, 1 data)
Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
Signed-off-by: Matteo Croce
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
arch/arm64/kernel/vdso.c | 4 ++--
1 file changed, 2 insert
pointers, and do the cast the other way around.
But there's no absolutely right answer here, and nobody should ever
use copy_user_generic() directly (ie it is very much meant to be only
used as a internal helper for the cases that get the pointer
annotations right).
Signed-off-by: Ben Dooks
n->tbl->family == AF_INET6)
Signed-off-by: Hariprasad Kelam
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
Changes in V2:
-Divide patch to only address spare error
---
include/trace/events/neigh.h | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/
On 3/25/2019 11:44 PM, helg...@kernel.org wrote:
From: Bjorn Helgaas
Fix spelling errors and format function comments consistently. Changes
whitespace and comments only; no functional change intended.
Signed-off-by: Bjorn Helgaas
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
On 3/30/2019 11:12 AM, Aneesh Kumar K.V wrote:
mm/debug.c: In function ‘dump_mm’:
include/linux/kern_levels.h:5:18: warning: format ‘%llx’ expects argument of
type ‘long long unsigned int’, but argument 19 has type ‘long int’ [-Wformat=]
~~~^
Signed-off-by: Aneesh Kumar K.V
x this by making status a u32. (Not tested).
Fixes: cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe
controller")
Signed-off-by: Colin Ian King
---
drivers/pci/controller/pcie-rockchip-ep.c | 2 +-
Looks valid to me.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
1
bot+0d1fcd7268b21bace...@syzkaller.appspotmail.com
Fixes: 44e63c4a0263 ("fs/binfmt_elf.c: free PT_INTERP filename ASAP")
---
Patch looks valid to me as interpreter may be NULL and it later get
tried to dereferencing inside allow_write_access
under label out_free_dentry.
Reviewed-by
/add check for
of _get_div() in the divider_ro_round_rate_parent()
Signed-off-by: nixiaoming
Please fix the commit text.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/clk/clk-divider.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/clk-divider.c b/drivers/clk
cmd(padapter, psta, true, false);
}
Get rid of this {}.fix this .
Now patch looks good after Dan comment.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
}
Fair
Reviewed-by: Mukesh Ojha
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8b305d2f2a8a..4ece87fcc166 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1893,9 +1893,10 @@ T: git
git://git.kernel.org/pub/scm
On 3/29/2019 9:14 PM, Masahiro Yamada wrote:
No one includes this.
Signed-off-by: Masahiro Yamada
---
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
Version: 5.1-rc2
arch/arm/include/asm/limits.h | 12
1 file changed, 12 deletions(-)
delete mode 100644 arch/arm/include
(ptr)` is wrong. Since `uval`
is only used once inside the macro, just get rid of __uval and use `(uval)`
directly.
Signed-off-by: Jann Horn
Looks good to me.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
arch/x86/include/asm/uaccess.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions
match the new name
of this file.
Fixes: 6a498e06ba22 ("MAINTAINERS: Add entry for the Nuvoton NPCM architecture")
Reported-by: Joe Perches
Signed-off-by: Brendan Higgins
Signed-off-by: Tomer Maimon
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
MAINTAINERS | 2 +-
1 file
On 3/29/2019 5:56 PM, David Hildenbrand wrote:
These are leftovers from the pre-"general non-lru movable page" era.
Signed-off-by: David Hildenbrand
---
include/linux/balloon_compaction.h | 15 ---
1 file changed, 15 deletions(-)
Reviewed-by: Mukesh Ojha
Cheer
On 3/29/2019 6:18 PM, laurentiu.tu...@nxp.com wrote:
From: Laurentiu Tudor
Make sure to free the i2c adapter on the error exit path.
Signed-off-by: Laurentiu Tudor
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/i2c/busses/i2c-imx.c | 4 +++-
1 file changed, 3 insertions(+), 1
np_root != rnp)
+ /* irqs remain disabled. */
+ raw_spin_unlock_rcu_node(rnp_root);
Looks good as it will balance the lock .if it is the root_node, which
was not there earlier, and unlock was happening without any lock on root.
Reviewed-by: Mukesh Ojha
C
eric Weisbecker
Cc: x...@kernel.org
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
kernel/time/tick-broadcast.c | 4
1 file changed, 4 insertions(+)
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index 0283523de045..7541cbca695e 100644
--- a/kernel/time/tick-br
On 3/29/2019 5:16 PM, nixiaoming wrote:
The _get_div function has a branch with a return value of 0
Add a check on the return value of _get_div to avoid divide-by-zero
Signed-off-by: nixiaoming
Fix the below minor comments..
Otherwise things look good..you can take mine
Reviewed-by: Mukesh
On 3/29/2019 7:16 AM, Axel Lin wrote:
Signed-off-by: Axel Lin
Yeah indeed! but where is commit text atleast a one-liner.
Otherwise looks good to me.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/regulator/vctrl-regulator.c | 4 +---
1 file changed, 1 insertion(+), 3
r.
Signed-off-by: Baoquan He
Acked-by: Michal Hocko
Reviewed-by: Rafael J. Wysocki
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/base/memory.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index cb
On 3/29/2019 1:59 PM, Baoquan He wrote:
The code comment above sparse_add_one_section() is obsolete and
incorrect, clean it up and write new one.
Signed-off-by: Baoquan He
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
v2->v3:
Normalize the code comment to use '/**' a
mpact.
Signed-off-by: Neeraj Upadhyay
Looks good to me.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
kernel/rcu/tree_plugin.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index 3960294..08bcd87 100644
--- a/kerne
good to me.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/gpio/gpiolib-of.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index 6a3ec575a404ed9f..3a6bb53d89dfed32 100644
--- a/drivers/gpio/gpiolib
er.
could have been more specific in the commit,but
Looks good to me to be removed.
Reviewed-by: Mukesh Ojha
-Mukesh
@piter->sg will point to the sg holding this page and
- * @piter->sg_pgoffset to the page's page offset within the sg. The iteration
- * will stop either when a
ed-by: Mukesh Ojha
-Mukesh
---
arch/x86/include/asm/tlbflush.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
index f4204bf377fc..90926e8dd1f8 100644
--- a/arch/x86/include/asm/tlbflush.h
+++ b/arch/x86/includ
o_user_ptr(A ? B : C)`. This currently doesn't
work as intended.
Fixes: f09174c501f8 ("x86: add user_atomic_cmpxchg_inatomic at uaccess.h")
Signed-off-by: Jann Horn
Looks good to me.
Reviewed-by: Mukesh Ojha
-Mukesh
---
Can we take this patch through the x86 tree with the fol
.
Reviewed-by: Mukesh Ojha
-Mukesh.
---
drivers/tty/n_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index 9cdb0fa3c4bf..66630787fbf9 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -550,7 +550,7 @@ static ssize_t
it by setting appropriate error code."
Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller")
Signed-off-by: Dan Carpenter
Other wise change looks good .
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/irqchip/irq-ls1x.c | 1 +
1 file changed, 1 insert
: Geert Uytterhoeven
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/gpio/gpiolib-of.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index 8b9c3ab70f6eade4..257be7bac032a855 100644
--- a/drivers/gpio/gpiolib-of.
hip);
+err_free_irqchip_mask:
same here.
After reviewing back and forth it looks good, apart from the naming.
Please fix.
Reviewed-by: Mukesh Ojha
-Mukesh
gpiochip_free_valid_mask(chip);
err_remove_irqchip_mask:
gpiochip_irqchip_free_valid_mask(chip);
ned-off-by: Geert Uytterhoeven
Looks good to be removed.
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/gpio/gpiolib.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index ed4da07effe0ac40..ec326bd84b1f1c50 100644
--- a/drivers/gpio/gpiol
uot;MIPS: SGI-IP27: rework HUB interrupts")
Reported-by: Dan Carpenter
Signed-off-by: Thomas Bogendoerfer
Reviewed-by: Mukesh Ojha
-Mukesh
---
arch/mips/sgi-ip27/ip27-irq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/mips/sgi-ip27/ip27-irq.c b/arch/m
convert 'const char *' type into 'char *' to fix the warning.
Fixes:3ddeac6705aba(tools: bpftool: use 4 context mode for the NFP
disasm)
Signed-off-by: Bo YU
Reviewed-by: Mukesh Ojha
-Mukesh
---
tools/bpf/bpftool/jit_disasm.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
On 3/28/2019 7:47 PM, Dan Carpenter wrote:
The "result" variable isn't initialized on this error path.
Fixes: 55e331cf7ebe ("drivers: add support for the TI VLYNQ bus")
Signed-off-by: Dan Carpenter
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/vlynq/vlynq.c |
ch trigger global-out-of-bounds bug and may leak kernel info.
Also other qedi dbg function may have the same issue, this patch
fix this.
Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver
framework.")
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
-
, cnt);
- if (rv)
- return rv;
-
- *ppos += cnt;
- return cnt;
+ return simple_read_from_buffer(usr_buf, size, ppos, buf, cnt);
Looks good to me.
Remove the unused variable.
Reviewed-by: Mukesh Ojha
-Mukesh
}
static ssize_t gpio_mockup_debugfs_write(struct file *file,
On 3/28/2019 3:36 PM, Jiri Slaby wrote:
Hi,
since commit 1901fb2604fbcd53201f38725182ea807581159e
Author: Kay Sievers
Date: Sat Oct 7 21:55:55 2006 +0200
Driver core: fix "driver" symlink timing
driver_sysfs_remove seems to be misplaced in the fail path of
really_probe. When driver_s
-Id: I3bbb07589b7b6e0e1b3bea572b5eb4f6b09774d6
Signed-off-by: Mukesh Ojha
Cc: Gaurav Kohli
Cc: Peter Hutterer
Cc: Martin Kepplinger
Cc: "Paul E. McKenney"
---
drivers/input/misc/uinput.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index 26ec
On 3/28/2019 2:53 PM, Ding Xiang wrote:
The variable will check in debugfs_remove_recursive, so
the NULL check here is not needed
Signed-off-by: Ding Xiang
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/fmc/fmc-debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
-Id: I3bbb07589b7b6e0e1b3bea572b5eb4f6b09774d6
Signed-off-by: Mukesh Ojha
Cc:Gaurav Kohli
Cc:Peter Hutterer
Cc:Martin Kepplinger
Cc:"Paul E. McKenney"
---
drivers/input/misc/uinput.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index 26ec
Thanks for making the change suggested.
Should not this be v3.
Please add version detail properly including what changes you made in
which version after ---, that makes the patch easy to review.
Thanks.
Mukesh
On 3/28/2019 10:17 AM, Lingutla Chandrasekhar wrote:
If user updates any cpu's
On 3/23/2019 5:04 PM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate headers which are included twice.
Signed-off-by: Jagadeesh Pagadala
Reviewed-by: Mukesh Ojha
-Mukesh
---
arch/arm/mm/mmu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mm
On 3/28/2019 2:50 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate header which is included twice.
Signed-off-by: Jagadeesh Pagadala
Reviewed-by: Mukesh Ojha
-Mukesh
---
arch/sh/boards/mach-sh03/rtc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a
On 3/28/2019 2:58 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate header which is included twice.
Signed-off-by: Jagadeesh Pagadala
Looks good to me. but did you tested at least the compilation with these
patches ?
Reviewed-by: Mukesh Ojha
-Mukesh
On 3/28/2019 3:19 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate header which is included twice.
Signed-off-by: Jagadeesh Pagadala
Reviewed-by: Mukesh Ojha
-Mukesh
---
tools/testing/selftests/powerpc/tm/tm-vmx-unavail.c | 1 -
1 file changed, 1 deletion
On 3/28/2019 8:47 AM, Hariprasad Kelam wrote:
fix spelling mistake "overriden" -> "overridden"
This fix resolves warning reported by checkpatch tool.
Signed-off-by: Hariprasad Kelam
Reviewed-by: Mukesh Ojha
-Mukesh
---
Changes in V2:
-Make co
On 3/28/2019 3:49 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate header which is included twice.
Signed-off-by: Jagadeesh Pagadala
Reviewed-by: Mukesh Ojha
-Mukesh
---
kernel/trace/trace.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel
utla Chandrasekhar
Please fix the commit text minor comments.
otherwise , looks good.
Reviewed-by: Mukesh Ojha
-Mukesh
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index edfcf8d982e4..1739d7e1952a 100644
--- a/drivers/base/arch_topology.c
+++ b/driver
On 3/28/2019 12:41 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate header which is included twice.
Signed-off-by: Jagadeesh Pagadala
Reviewed-by: Mukesh Ojha
-Mukesh
---
arch/arm/mach-sa1100/hackkit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a
On 3/22/2019 7:34 PM, Yue Haibing wrote:
From: YueHaibing
Fix sparse warning:
security/selinux/hooks.c:3389:5: warning:
symbol 'selinux_kernfs_init_security' was not declared. Should it be static?
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
-Mukesh
---
securi
nused-but-set-parameter]
It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
asoc_simple_debug_info()"), so can be removed.
Signed-off-by: YueHaibing
Acked-by: Kuninori Morimoto
Reviewed-by: Mukesh Ojha
-Mukesh
---
v2: fix patch title
---
sound/soc/generic/
On 3/25/2019 4:13 AM, Kangjie Lu wrote:
When kzalloc fails, "platform_state->inited = 1" is a NULL pointer
dereference. The fix returns VCHIQ_ERROR in case it failed to
avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh Ojha
-Mukesh
---
uot;Add virtio gpu driver.")
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
-Mukesh
---
v2: fix patch prefix
---
drivers/gpu/drm/virtio/virtgpu_ttm.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c
b/drivers/gpu/drm/virtio/virtgpu_ttm.c
i
or the return value of kzalloc,
which may lead to NULL-pointer dereference.
The patch fixes the two issues.
Signed-off-by: Kangjie Lu
Otherwise looks good.
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/thunderbolt/property.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
On 3/26/2019 2:55 AM, Aditya Pakki wrote:
uuid in add_switch is allocted via kmemdup which can fail. The patch
logs the error and cleans up the allocated memory for switch.
Signed-off-by: Aditya Pakki
Reviewed-by: Mukesh Ojha
-Mukesh
---
v2: replace WARN_ONCE with tb_sw_warn, as
Signed-off-by: Aditya Pakki
Reviewed-by: Mukesh Ojha
-Mukesh
---
v2: Move the signed by above the version change log
v1: A check is unnecessary as match is never used.
---
sound/soc/codecs/sirf-audio-codec.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/
On 3/26/2019 11:58 AM, lantianyu1...@gmail.com wrote:
From: Lan Tianyu
The Hyperv vIOMMU file name should be "hyperv-iommu.c" rather
s/vIOMMU /IOMMU
than "hyperv_iommu.c". This patch is to fix it.
Signed-off-by: Lan Tianyu
Othewise looks fine.
Reviewed-by: M
dereferences.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh Ojha
-Mukesh
---
removed "unlikely"
---
drivers/usb/host/u132-hcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c
index 934584f0a20a..6d5b532b03f8 100644
--- a/d
ks good.
Reviewed-by: Mukesh Ojha
-Mukesh
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e17ebf7..403247d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7175,7 +7175,7 @@ F:drivers/net/hyperv/
F:drivers/sc
On 3/26/2019 7:43 AM, Masahiro Yamada wrote:
The pattern drivers/dmaengine/uniphier-mdmac.c has no match in the
source tree.
The correct path is drivers/dma/uniphier-mdmac.c
Reported-by: Joe Perches
Signed-off-by: Masahiro Yamada
Reviewed-by: Mukesh Ojha
-Mukesh
---
MAINTAINERS
ooks good.
Reviewed-by: Mukesh Ojha
-Mukesh
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3e5a5d263f29..d2c5852a3c8d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2007,7 +2007,7 @@ F:drivers/i2c/busses/i2c-qup.c
F:d
On 3/26/2019 3:49 AM, Kangjie Lu wrote:
If __get_free_pages() fails, the patch returns -ENOMEM to avoid
NULL pointer dereference.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh Ojha
-Mukesh
---
v3: remove "unlikely", as suggested by Bjorn Helgaas.
v2: caller is redefined to
On 3/27/2019 6:21 PM, Mukesh Ojha wrote:
On 3/26/2019 6:14 PM, Fabrice Gasnier wrote:
Enabling CONFIG_DEBUG_ATOMIC_SLEEP=y triggers this BUG message:
BUG: sleeping function called from invalid context at
kernel/irq/chip.c...
Call stack is as follows:
- __might_sleep
- handle_nested_irq
")
Signed-off-by: Fabrice Gasnier
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/iio/adc/Kconfig | 1 +
drivers/iio/adc/stm32-adc.c | 32 ++--
2 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kc
On 3/27/2019 4:38 AM, Jann Horn wrote:
sparse complains that Yama defines functions and a variable as non-static
even though they don't exist in any header. Fix it by making them static.
Signed-off-by: Jann Horn
Reviewed-by: Mukesh Ojha
---
security/yama/yama_lsm.c | 6 +++--
On 3/9/2019 10:49 AM, Kangjie Lu wrote:
get_skb may fail and return NULL. The fix returns "ENOMEM"
when it fails to avoid NULL dereference.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh OJha
---
drivers/infiniband/hw/cxgb4/cm.c | 3 +++
1 file changed, 3 insertions(+)
di
On 3/9/2019 10:49 AM, Kangjie Lu wrote:
get_skb may fail and return NULL. The fix returns "ENOMEM"
when it fails to avoid NULL dereference.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh Ojha
---
drivers/infiniband/hw/cxgb4/cm.c | 3 +++
1 file changed, 3 insertions(+)
di
On 3/23/2019 2:32 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate header which is included twice.
Signed-off-by: Jagadeesh Pagadala
Reviewed-by: Mukesh Ojha
---
arch/sh/boards/mach-dreamcast/irq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch
Sparse complains yama_task_prctl can be static. Fix it by making
it static.
Signed-off-by: Mukesh Ojha
---
security/yama/yama_lsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
index 57cc607..9c5a15b 100644
--- a
On 3/27/2019 5:23 AM, Huang Zijiang wrote:
The of_find_device_by_node() takes a reference to the underlying device
structure, we should release that reference.
Signed-off-by: Huang Zijiang
---
arch/arm/mach-socfpga/pm.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
On 3/25/2019 11:07 PM, Steven Price wrote:
of_parse_phandle_with_args() requires the caller to call of_node_put() on
the returned args->np pointer. Otherwise the reference count will remain
incremented.
However, in this case, since we don't actually use the returned pointer,
we can simply pass
On 3/25/2019 1:26 PM, Lee Jones wrote:
On Fri, 22 Mar 2019, Kangjie Lu wrote:
Hi Lee Jones,
Can you review this patch?
Don't poke.
I have a very long list of reviews on my TODO. Poking only surfaces
your patch to the top of my Inbox, and since I review patches in
reverse chronological order
On 3/23/2019 7:38 AM, YueHaibing wrote:
Fixes gcc '-Wunused-but-set-variable' warning:
sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
sound/soc/generic/simple-card-utils.c:164:18: warning:
parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
It's n
.
Thanks,
Mukesh
On 3/25/2019 12:15 PM, Mukesh Ojha wrote:
On 3/25/2019 4:42 AM, Kangjie Lu wrote:
In case devm_kzalloc fails, the patch returns -ENOMEM to avoid
potential NULL pointer dereference.
Signed-off-by: Kangjie Lu
---
sound/soc/codecs/rt5663.c | 2 ++
1 file changed, 2 insertions
On 3/25/2019 4:42 AM, Kangjie Lu wrote:
In case devm_kzalloc fails, the patch returns -ENOMEM to avoid
potential NULL pointer dereference.
Signed-off-by: Kangjie Lu
---
sound/soc/codecs/rt5663.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/rt5663.c b/sound/soc/cod
On 3/21/2019 7:40 PM, Yue Haibing wrote:
From: YueHaibing
If dccp_feat_push_change fails, we forget free the mem
which is alloced by kmemdup in dccp_feat_clone_sp_val.
Reported-by: Hulk Robot
Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
Signed-off-by: YueH
On 3/21/2019 11:19 AM, Mika Westerberg wrote:
On Thu, Mar 21, 2019 at 02:09:41AM +0530, Mukesh Ojha wrote:
On 3/20/2019 9:59 PM, Mika Westerberg wrote:
On Wed, Mar 20, 2019 at 11:24:45AM -0500, Aditya Pakki wrote:
In enumerate_services, ida_simple_get on failure can return an error and
On 3/21/2019 1:39 PM, Richard Weinberger wrote:
Am Donnerstag, 21. März 2019, 08:54:55 CET schrieb Mukesh Ojha:
Acked-by: Mukesh Ojha
I guess you mean Reviewed-by?
As i am unsure about future scope of this func. i.e why Acked.
Acked-by is usually something I expect from the code author
or
On 3/21/2019 1:48 AM, Richard Weinberger wrote:
Am Mittwoch, 20. März 2019, 21:05:37 CET schrieb Mukesh Ojha:
On 3/20/2019 7:39 PM, Yue Haibing wrote:
From: YueHaibing
There is no callers in tree, and can be removed.
Signed-off-by: YueHaibing
---
fs/ubifs/auth.c | 18
On 3/21/2019 1:25 AM, Frank Rowand wrote:
On 3/20/19 3:49 AM, Mukesh Ojha wrote:
Existing check of `fn` against NULL inside OF match table
is redundant. Remove the check.
Signed-off-by: Mukesh Ojha
Cc: Rob Herring
Cc: Frank Rowand
Cc: Pantelis Antoniou
Cc: devicet...@vger.kernel.org
g the change.
Reviewed-by: Mukesh Ojha
-Mukesh
static int tb_switch_add_dma_port(struct tb_switch *sw)
@@ -1372,7 +1378,9 @@ static int tb_switch_add_dma_port(struct tb_switch *sw)
if (status) {
tb_sw_info(sw, "switch flash authentication failed\n");
-
vice_node *np,
+static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
struct device_node *parent)
{
return
Acked-by: Mukesh Ojha
Thanks,
Mukesh
brcmstb_l2_intc_of_init(np, parent, &l2_lvl_intc_init);
On 3/20/2019 9:59 PM, Mika Westerberg wrote:
On Wed, Mar 20, 2019 at 11:24:45AM -0500, Aditya Pakki wrote:
In enumerate_services, ida_simple_get on failure can return an error and
leaks memory during device_register failure. The patch ensures that
the dev_set_name is set on non failure cases,
*)skb_put(skb, totalpacketlen), &reserved_page_packet,
totalpacketlen);
Reviewed-by: Mukesh Ojha
On 3/20/2019 10:51 PM, Aditya Pakki wrote:
hwxmits is allocated via kcalloc and not checked for failure before its
No need to mention kcalloc as the other place allocates the memory
through kmalloc.
Otherwise looks good.
Acked-by: Mukesh Ojha
dereference. The patch fixes this problem
);
-
- return 0;
-}
-
-/**
* ubifs_bad_hash - Report hash mismatches
* @c: UBIFS file-system description object
* @node: the node
Looks fine to be removed.
Acked-by: Mukesh Ojha
-Mukesh
@@ struct imx_sc_msg_resp_pad_get {
u32 val;
} __packed;
-struct imx_sc_ipc *pinctrl_ipc_handle;
+static struct imx_sc_ipc *pinctrl_ipc_handle;
int imx_pinctrl_sc_ipc_init(struct platform_device *pdev)
{
Reviewed-by: Mukesh Ojha
tic struct kcore_list kcore_modules;
static void __init add_modules_range(void)
{
if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {
Acked-by: Mukesh Ojha
vice_node *np,
+static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
struct device_node *parent)
{
return brcmstb_l2_intc_of_init(np, parent, &l2_lvl_intc_init);
Reviewed-by: Mukesh Ojha
Thanks,
Mukesh
;
@@ -81,7 +81,7 @@ void sbwdog_set(char __iomem *wdog, unsigned long t)
*
* wdog is the iomem address of the cfg register
*/
-void sbwdog_pet(char __iomem *wdog)
+static void sbwdog_pet(char __iomem *wdog)
{
spin_lock(&sbwd_lock);
__raw_writeb(__raw_readb(wdog) | 1, wdo
riv->phydm.internal)
+ return 0;
_rtl_phydm_init_com_info(rtlpriv, ic, params);
Reviewed-by: Mukesh Ojha
Thanks,
Mukesh
_arg = page_address(pg);
hv_get_vp_index(msr_vp_index);
Looks good to me.
Reviewed-by: Mukesh Ojha
Thanks.
Mukesh
wed-by: Mukesh Ojha
Can you fix that cleanly ? or i will do?
Cheers,
Mukesh
_rtl_phydm_init_com_info(rtlpriv, ic, params);
odm_init_all_timers(dm);
201 - 300 of 343 matches
Mail list logo
