viewed-by: Mukesh Ojha
Can you fix that cleanly ? Otherwise i will do.
Cheers,
Mukesh
_rtl_phydm_init_com_info(rtlpriv, ic, params);
odm_init_all_timers(dm);
On 3/19/2019 10:52 PM, Aditya Pakki wrote:
ida_simple_get on failure can return an error. The patch ensures that
the dev_set_name is set on non failure cases.
Signed-off-by: Aditya Pakki
---
We should add check against `ida_simple_get` instead of svc->id >= 0 and
clean up svc.
Also, It
ood to me.
Reviewed-by: Mukesh Ojha
but, we should add check for `tb_sw_read ` this as well.
Cheers,
Mukesh
static int tb_switch_add_dma_port(struct tb_switch *sw)
@@ -1372,7 +1375,9 @@ static int tb_switch_add_dma_port(struct tb_switch *sw)
if (status) {
tb_sw_info(sw
Existing check of `fn` against NULL inside OF match table
is redundant. Remove the check.
Signed-off-by: Mukesh Ojha
Cc: Rob Herring
Cc: Frank Rowand
Cc: Pantelis Antoniou
Cc: devicet...@vger.kernel.org
---
include/linux/of.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Please read the guideline as well before sending patch.
you need to maintain patchset version as well, e.g: in which patchset
what is changed on whose comments.
-Mukesh
On 12/14/2018 3:49 PM, jotun9...@gmail.com wrote:
From: Sungkyung Kim
Fix coding style of osf.c
Signed-off-by: Sungkyu
On 12/14/2018 12:34 PM, jotun9...@gmail.com wrote:
From: Sungkyung Kim
Fix coding style of osf.c
Signed-off-by: Sungkyung Kim
---
block/partitions/osf.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/partitions/osf.c b/block/partitions/osf.c
index 4b87
Commit-ID: 43b9e4febc66b98d83cc1560196d56ac7fef3c32
Gitweb: https://git.kernel.org/tip/43b9e4febc66b98d83cc1560196d56ac7fef3c32
Author: Mukesh Ojha
AuthorDate: Tue, 27 Nov 2018 14:43:32 +0530
Committer: Ingo Molnar
CommitDate: Tue, 11 Dec 2018 15:01:48 +0100
perf/core: Declare the
Hi All,
Can you please review the change ?
Thanks,
Mukesh
On 11/27/2018 2:43 PM, Mukesh Ojha wrote:
Sparse reports the current declaration of percpu variable with
below warning
warning: incorrect type in initializer (different address spaces)
expected void const [noderef
Sparse reports the current declaration of percpu variable with
below warning
warning: incorrect type in initializer (different address spaces)
expected void const [noderef] *__vpp_verify
got struct perf_cpu_context *
Fix it by declaring it properly.
Signed-off-by: Mukesh Ojha
On 9/5/2018 5:03 PM, Thomas Gleixner wrote:
On Tue, 4 Sep 2018, Neeraj Upadhyay wrote:
If takedown_cpu() fails during _cpu_down(), st->state is reset,
by calling cpuhp_reset_state(). This results in an additional
increment of st->state, which results in CPUHP_AP_SMPBOOT_THREADS
state being sk
* skipped during rollback. So, don't use it here.
+*/
+ st->rollback = true;
+ st->target = prev_state;
+ st->bringup = !st->bringup;
Acked-by: Mukesh Ojha
looks valid for this case.
__cpuhp_kick_ap(st);
}
Commit-ID: 6fb86d97207880c1286cd4cb3a7e6a598afbc727
Gitweb: https://git.kernel.org/tip/6fb86d97207880c1286cd4cb3a7e6a598afbc727
Author: Mukesh Ojha
AuthorDate: Tue, 28 Aug 2018 12:24:54 +0530
Committer: Thomas Gleixner
CommitDate: Fri, 31 Aug 2018 14:13:03 +0200
cpu/hotplug: Remove
Commit-ID: 935aad3015fb4afc0b7ef6e6c18175b95461de47
Gitweb: https://git.kernel.org/tip/935aad3015fb4afc0b7ef6e6c18175b95461de47
Author: Mukesh Ojha
AuthorDate: Tue, 28 Aug 2018 12:24:54 +0530
Committer: Thomas Gleixner
CommitDate: Thu, 30 Aug 2018 12:59:30 +0200
cpu/hotplug: Remove
Commit-ID: 13ba17bee18e321b073b49a88dcab10881f757da
Gitweb: https://git.kernel.org/tip/13ba17bee18e321b073b49a88dcab10881f757da
Author: Mukesh Ojha
AuthorDate: Fri, 24 Aug 2018 18:03:53 +0530
Committer: Thomas Gleixner
CommitDate: Thu, 30 Aug 2018 12:56:40 +0200
notifier: Remove
from the structure and its usage.
Signed-off-by: Mukesh Ojha
Cc: Peter Zijlstra
Cc: Ingo Molnar
---
kernel/cpu.c | 25 -
1 file changed, 4 insertions(+), 21 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index ed44d7d..c544baf 100644
--- a/kernel/cpu.c
+++ b
When notifier converted to state-machine in hotplug, we missed to
remove header file from some of the files.
So, Remove it with this.
Signed-off-by: Mukesh Ojha
---
fs/buffer.c| 1 -
kernel/printk/printk.c | 1 -
lib/percpu_counter.c | 1 -
mm/page-writeback.c| 1 -
mm
On 8/21/2018 7:27 PM, Thomas Gleixner wrote:
On Tue, 21 Aug 2018, Mukesh Ojha wrote:
Hi All,
This is about one of field in struct cpuhp_step
* @skip_onerr: Do not invoke the functions on error rollback
* Will go away once the notifiers are gone
bool
Hi All,
This is about one of field in struct cpuhp_step
* @skip_onerr: Do not invoke the functions on error rollback
* Will go away once the notifiers are gone
bool skip_onerr;
Why this field was introduced, can anyone explain the history behind ?
As i
On 8/17/2018 6:28 PM, Al Viro wrote:
On Fri, Aug 17, 2018 at 03:39:22PM +0530, Mukesh Ojha wrote:
Hi Al Viro,
Is there is reason we have kept data->found++, if the dentry already there
in shrink list ?
static enum d_walk_ret select_collect(
...
if (dentry->d
Hi Al Viro,
Is there is reason we have kept data->found++, if the dentry already
there in shrink list ?
static enum d_walk_ret select_collect(
...
if (dentry->d_flags & DCACHE_SHRINK_LIST) {
data->found++;
} else {
..
If the dentry is already there on shrink
Commit-ID: d018031f562b9c2eff038969ab1955a370c52d8f
Gitweb: https://git.kernel.org/tip/d018031f562b9c2eff038969ab1955a370c52d8f
Author: Mukesh Ojha
AuthorDate: Tue, 24 Jul 2018 20:17:48 +0530
Committer: Thomas Gleixner
CommitDate: Mon, 30 Jul 2018 21:30:52 +0200
cpu/hotplug: Clarify
On 7/30/2018 5:49 PM, Thomas Gleixner wrote:
Mukesh,
On Thu, 26 Jul 2018, Mukesh Ojha wrote:
Hi All,
Can i get input on this ?
Sure.
Thanks,
Mukesh
On 7/24/2018 8:17 PM, Mukesh Ojha wrote:
The input you get is that it's unprofessional to poke people after TWO days
about a patch
Hi All,
Can i get input on this ?
Thanks,
Mukesh
On 7/24/2018 8:17 PM, Mukesh Ojha wrote:
After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead"
Hi All,
Please review V2 where i will be updating(minor) commit text.
Thanks.
Mukesh
On 7/24/2018 8:07 PM, Mukesh Ojha wrote:
After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
instead of CPUHP_TIMERS_DEAD the
After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead"
for timer looks to be invalid. So, better to name it as
"timers:prepare".
After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead"
for timer looks to invalid. So, better to name it as
"timers:prepare".
Signed-o
Adding stable and lkml.
Sorry for spam others.
-Mukesh
On 7/23/2018 1:57 PM, Mukesh Ojha wrote:
Hi All,
I wanted to discuss about one of the corner case exists in 4.9 kernel
(4.9.x) where
If hotplug of one of the CPU fails due to failure in one of the callback,
which is to be called after
operly.
Originally-by: Thomas Gleixner
Signed-off-by: Mukesh Ojha
---
Changes in V5:
* Took extra variable `inject_sleeptime` to take care of injecting sleeptime
inside timekeeping_resume().
* Inverted the return logic inside timekeeping_skipresume() instead of doing
it in rtc_resume().
* Upda
On 7/17/2018 2:31 AM, John Stultz wrote:
On Mon, Jul 16, 2018 at 1:40 PM, Mukesh Ojha wrote:
Currently, there exists a corner case assuming when there is
only one clocksource e.g RTC, and system failed to go to
suspend mode. While resume rtc_resume() injects the sleeptime
as
On 7/17/2018 2:20 AM, Thomas Gleixner wrote:
On Tue, 17 Jul 2018, Mukesh Ojha wrote:
@@ -102,7 +102,7 @@ static int rtc_resume(struct device *dev)
struct timespec64 sleep_time;
int err;
- if (timekeeping_rtc_skipresume())
+ if (!timekeeping_rtc_skipresume
nd failed)
Originally-by: Thomas Gleixner
Signed-off-by: Mukesh Ojha
---
Changes in V4:
* Changes as suggested by John
- Changed the variable name from sleeptime_injected to suspend_timing_needed
- Changed the boolean logic.
Changes in v3:
* Updated commit subject and description.
* Up
On 7/16/2018 10:44 PM, John Stultz wrote:
On Mon, Jul 16, 2018 at 9:30 AM, John Stultz wrote:
On Mon, Jul 16, 2018 at 9:17 AM, Mukesh Ojha wrote:
On 7/13/2018 10:50 PM, John Stultz wrote:
On Fri, Jul 13, 2018 at 12:13 AM, Mukesh Ojha
On 7/11/2018 1:43 AM, John Stultz wrote:
I worry
On 7/13/2018 10:50 PM, John Stultz wrote:
On Fri, Jul 13, 2018 at 12:13 AM, Mukesh Ojha wrote:
Hi John,
Thanks for your response
Please find my comments inline.
On 7/11/2018 1:43 AM, John Stultz wrote:
On Fri, Jul 6, 2018 at 6:17 AM, Mukesh Ojha wrote:
Currently, there exists a corner
Hi John,
Thanks for your response
Please find my comments inline.
On 7/11/2018 1:43 AM, John Stultz wrote:
On Fri, Jul 6, 2018 at 6:17 AM, Mukesh Ojha wrote:
Currently, there exists a corner case assuming when there is
only one clocksource e.g RTC, and system failed to go to
suspend mode
nd failed)
Originally-by: Thomas Gleixner
Signed-off-by: Mukesh Ojha
---
Changes in v3:
* Updated commit subject and description.
* Updated the patch as per the fix given by Thomas Gleixner.
Changes in v2:
* Updated the commit text.
* Removed extra variable and used the earl
Hi Thomas,
Could you raise a formal patch on this as you are the author now?
Thanks,
Mukesh
On 6/25/2018 8:34 PM, Thomas Gleixner wrote:
On Mon, 25 Jun 2018, Mukesh Ojha wrote:
On 6/23/2018 2:57 AM, Thomas Gleixner wrote:
@@ -1671,7 +1685,6 @@ void timekeeping_resume(void)
struct
Hi Thomas,
Thanks you very much for your time and reply.
On 6/23/2018 2:57 AM, Thomas Gleixner wrote:
On Wed, 30 May 2018, Mukesh Ojha wrote:
Currently, for both non-stop clocksource and persistent clock
there is a corner case, when a driver failed to go suspend mode.
rtc_resume() injects
Any input on this ?
Thanks,
Mukesh
On 5/30/2018 5:14 PM, Mukesh Ojha wrote:
Currently, for both non-stop clocksource and persistent clock
there is a corner case, when a driver failed to go suspend mode.
rtc_resume() injects the sleeptime as timekeeping_rtc_skipresume()
returned '
=>
rtc_resume()
Failure case:
{failure in sleep path} {sleeptime_injected=false}
rtc_suspend() =>rtc_resume()
Signed-off-by: Mukesh Ojha
---
Changes in v2:
* Updated the commit text.
* Removed extra variable and used the earl
Hi John,
On 5/30/2018 7:50 AM, John Stultz wrote:
On Tue, May 29, 2018 at 2:49 AM, Mukesh Ojha wrote:
Currently, for both non-stop clocksource and persistent clock
there is a corner case, when a driver failed to go suspend mode
rtc_resume() injects the sleeptime as timekeeping_rtc_skipresume
esume()
Signed-off-by: Mukesh Ojha
---
Changes from Resend:
* updated commit text.
kernel/time/timekeeping.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 427e33d..c022d82 100644
--- a/kernel/ti
On 5/29/2018 2:18 PM, Vinod Koul wrote:
On 29-05-18, 13:45, Mukesh Ojha wrote:
Currently, for both non-stop clocksource and persistent clock
there is a corner case, when a driver failed to go suspend mode
rtc_resume injects the sleeptime as timekeeping_rtc_skipresume
returned 'false&#x
tc_resume()
Change-Id: I98928761c98cec21a3033a55d3e10fb34138f38c
Signed-off-by: Mukesh Ojha
---
kernel/time/timekeeping.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 427e33d..c022d82 100644
--- a/kernel/time/timekeeping.c
+++ b/ker
301 - 343 of 343 matches
Mail list logo
