Provide a function for copying init_mm. This function will be later used
for setting a temporary mm.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
include/linux/sched/task.h | 1
that would set a temporary mm for
patching, which is initialized after some static-keys are
enabled/disabled.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Dave Hansen
Cc: Masami Hiramatsu
Co-Developed-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 7 ++-
1 file changed
text_poke() already ensures that the written value is the correct one
and fails if that is not the case. There is no need for an additional
comparison. Remove it.
Signed-off-by: Nadav Amit
---
arch/x86/kernel/kgdb.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff
that would set a temporary mm for
patching, which is initialized after some static-keys are
enabled/disabled.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Dave Hansen
Cc: Masami Hiramatsu
Co-Developed-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 7 ++-
1 file changed
text_poke() already ensures that the written value is the correct one
and fails if that is not the case. There is no need for an additional
comparison. Remove it.
Signed-off-by: Nadav Amit
---
arch/x86/kernel/kgdb.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff
not conservative enough when mapping pages,
as it always tries to map 2 pages, even when a single one is sufficient.
So try to be more conservative, and do not map more than needed.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Suggested-by: Thomas Gleixner
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/kernel/alternative.c | 28 +---
arch/x86/kernel/module.c | 2 +-
include/linux/filter.h| 6 ++
kernel
not conservative enough when mapping pages,
as it always tries to map 2 pages, even when a single one is sufficient.
So try to be more conservative, and do not map more than needed.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Suggested-by: Thomas Gleixner
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/kernel/alternative.c | 28 +---
arch/x86/kernel/module.c | 2 +-
include/linux/filter.h| 6 ++
kernel
Hiramatsu
Tested-by: Masami Hiramatsu
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/pgtable.h | 3 +++
arch/x86/include/asm/text-patching.h | 2 ++
arch/x86/kernel/alternative.c| 3 +++
arch/x86/mm/init_64.c| 35
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index ed5fe274a7d8..994c13e2867d 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index ed5fe274a7d8..994c13e2867d 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86
Hiramatsu
Tested-by: Masami Hiramatsu
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/pgtable.h | 3 +++
arch/x86/include/asm/text-patching.h | 2 ++
arch/x86/kernel/alternative.c| 3 +++
arch/x86/mm/init_64.c| 35
> On Nov 20, 2018, at 4:42 AM, Peter Zijlstra wrote:
>
> On Tue, Nov 13, 2018 at 05:07:20AM -0800, Nadav Amit wrote:
>> v4->v5:
>> - Fix Xen breakage [Damian Tometzki]
>> - BUG_ON() when poking_mm initialization fails [PeterZ]
>> - Better comments on "
> On Nov 20, 2018, at 4:42 AM, Peter Zijlstra wrote:
>
> On Tue, Nov 13, 2018 at 05:07:20AM -0800, Nadav Amit wrote:
>> v4->v5:
>> - Fix Xen breakage [Damian Tometzki]
>> - BUG_ON() when poking_mm initialization fails [PeterZ]
>> - Better comments on "
> On Nov 20, 2018, at 10:23 AM, H. Peter Anvin wrote:
>
> On 11/20/18 10:18 AM, Peter Zijlstra wrote:
>>> Can't we make this test in text_poke() directly, please?
>>
>> He does that in 9/10 iirc.
>
> No, in 9/10 he does that change locally for the jump_label, but there is
> absolutely no
> On Nov 20, 2018, at 10:23 AM, H. Peter Anvin wrote:
>
> On 11/20/18 10:18 AM, Peter Zijlstra wrote:
>>> Can't we make this test in text_poke() directly, please?
>>
>> He does that in 9/10 iirc.
>
> No, in 9/10 he does that change locally for the jump_label, but there is
> absolutely no
at 8:20 PM, Masahiro Yamada wrote:
> On Sat, Nov 17, 2018 at 6:02 AM Nadav Amit wrote:
>> From: Masahiro Yamada
>> Sent: November 16, 2018 at 7:45:45 AM GMT
>>> To: Nadav Amit
>>> Cc: Ingo Molnar , Michal Marek ,
>>> Thomas Gleixner , Borislav Pet
at 8:20 PM, Masahiro Yamada wrote:
> On Sat, Nov 17, 2018 at 6:02 AM Nadav Amit wrote:
>> From: Masahiro Yamada
>> Sent: November 16, 2018 at 7:45:45 AM GMT
>>> To: Nadav Amit
>>> Cc: Ingo Molnar , Michal Marek ,
>>> Thomas Gleixner , Borislav Pet
From: Masahiro Yamada
Sent: November 16, 2018 at 7:45:45 AM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , Linux Kernel Mailing List
>
> Subject: Re: [PATCH v2 1/2]
From: Masahiro Yamada
Sent: November 16, 2018 at 7:45:45 AM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , Linux Kernel Mailing List
>
> Subject: Re: [PATCH v2 1/2]
From: Masahiro Yamada
Sent: November 16, 2018 at 7:37:46 AM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , Linux Kernel Mailing List
>
> Subject: Re: [PATCH v2 2/2]
From: Masahiro Yamada
Sent: November 16, 2018 at 7:37:46 AM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , Linux Kernel Mailing List
>
> Subject: Re: [PATCH v2 2/2]
file. Since this is less efficient, this
compilation mode is only used when distcc or icecc are used.
Note that the assembly stage should also be distributed, if distcc is
configured using "CFLAGS=-DENABLE_REMOTE_ASSEMBLE".
Reported-by: Logan Gunthorpe
Signed-off-by: Nadav Amit
---
Changes in macros.S should trigger the recompilation of all C files, as
the macros might need to affect their compilation.
Acked-by: Ingo Molnar
Signed-off-by: Nadav Amit
---
scripts/Makefile.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.build b
the patches through tip. Please advise
if you disagree.
v1->v2:
* Remove whitespaces [Ingo]
* Automatically enable split compilation when distcc or icecc are used
Nadav Amit (2):
Makefile: Fix distcc compilation with x86 macros
x86: set a dependency on macros.S
Makefile | 4 +++-
a
file. Since this is less efficient, this
compilation mode is only used when distcc or icecc are used.
Note that the assembly stage should also be distributed, if distcc is
configured using "CFLAGS=-DENABLE_REMOTE_ASSEMBLE".
Reported-by: Logan Gunthorpe
Signed-off-by: Nadav Amit
---
Changes in macros.S should trigger the recompilation of all C files, as
the macros might need to affect their compilation.
Acked-by: Ingo Molnar
Signed-off-by: Nadav Amit
---
scripts/Makefile.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.build b
the patches through tip. Please advise
if you disagree.
v1->v2:
* Remove whitespaces [Ingo]
* Automatically enable split compilation when distcc or icecc are used
Nadav Amit (2):
Makefile: Fix distcc compilation with x86 macros
x86: set a dependency on macros.S
Makefile | 4 +++-
a
From: Xavier Deguillard
Julien will be replacing me as the vmw_balloon maintainer.
Cc: Julien Freche
Signed-off-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a78d45755881
From: Xavier Deguillard
Julien will be replacing me as the vmw_balloon maintainer.
Cc: Julien Freche
Signed-off-by: Xavier Deguillard
Signed-off-by: Nadav Amit
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a78d45755881
From: Logan Gunthorpe
Sent: November 15, 2018 at 1:19:45 AM GMT
> To: Nadav Amit , Ingo Molnar
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , LKML
> Subject: Re: [PAT
From: Logan Gunthorpe
Sent: November 15, 2018 at 1:19:45 AM GMT
> To: Nadav Amit , Ingo Molnar
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , LKML
> Subject: Re: [PAT
From: Logan Gunthorpe
Sent: November 14, 2018 at 7:29:38 AM GMT
> To: Nadav Amit , Ingo Molnar
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , LKML
> Subject: Re: [PAT
From: Logan Gunthorpe
Sent: November 14, 2018 at 7:29:38 AM GMT
> To: Nadav Amit , Ingo Molnar
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , LKML
> Subject: Re: [PAT
orce text_mutex in
text_poke*()")
Suggested-by: Peter Zijlstra
Acked-by: Jiri Kosina
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 3 +-
arch/x86/kernel/alternative.c| 72 +---
arch/x86/kernel/kgdb.c | 15 --
3 files changed,
text_poke() already ensures that the written value is the correct one
and fails if that is not the case. There is no need for an additional
comparison. Remove it.
Signed-off-by: Nadav Amit
---
arch/x86/kernel/kgdb.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/arch/x86/kernel
ext_mutex use instead [masami]
- Comment fix [peterz]
- Removed remainders of text_poke return value [masami]
- Use __weak for poking_init instead of macros [masami]
- Simplify error handling in poking_init [masami]
Andy Lutomirski (1):
x86/mm: temporary mm struct
Nadav Amit (9):
Fix "
Hiramatsu
Tested-by: Masami Hiramatsu
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/pgtable.h | 3 +++
arch/x86/include/asm/text-patching.h | 2 ++
arch/x86/kernel/alternative.c| 3 +++
arch/x86/mm/init_64.c| 35
text_poke() already ensures that the written value is the correct one
and fails if that is not the case. There is no need for an additional
comparison. Remove it.
Signed-off-by: Nadav Amit
---
arch/x86/kernel/kgdb.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/arch/x86/kernel
ext_mutex use instead [masami]
- Comment fix [peterz]
- Removed remainders of text_poke return value [masami]
- Use __weak for poking_init instead of macros [masami]
- Simplify error handling in poking_init [masami]
Andy Lutomirski (1):
x86/mm: temporary mm struct
Nadav Amit (9):
Fix "
Hiramatsu
Tested-by: Masami Hiramatsu
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/pgtable.h | 3 +++
arch/x86/include/asm/text-patching.h | 2 ++
arch/x86/kernel/alternative.c| 3 +++
arch/x86/mm/init_64.c| 35
orce text_mutex in
text_poke*()")
Suggested-by: Peter Zijlstra
Acked-by: Jiri Kosina
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 3 +-
arch/x86/kernel/alternative.c| 72 +---
arch/x86/kernel/kgdb.c | 15 --
3 files changed,
: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/mmu_context.h | 32 ++
1 file changed, 32 insertions(+)
diff --git a/arch/x86/include/asm
Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Suggested-by: Thomas Gleixner
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/kernel/alternative.c | 28 +---
arch/x86/kernel/module.c | 2 +-
include/linux/filter.h| 6 ++
kernel
not conservative enough when mapping pages,
as it always tries to map 2 pages, even when a single one is sufficient.
So try to be more conservative, and do not map more than needed.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
Provide a function for copying init_mm. This function will be later used
for setting a temporary mm.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
include/linux/sched/task.h | 1
not conservative enough when mapping pages,
as it always tries to map 2 pages, even when a single one is sufficient.
So try to be more conservative, and do not map more than needed.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
Provide a function for copying init_mm. This function will be later used
for setting a temporary mm.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
include/linux/sched/task.h | 1
: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/mmu_context.h | 32 ++
1 file changed, 32 insertions(+)
diff --git a/arch/x86/include/asm
Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Suggested-by: Thomas Gleixner
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/kernel/alternative.c | 28 +---
arch/x86/kernel/module.c | 2 +-
include/linux/filter.h| 6 ++
kernel
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index ed5fe274a7d8..994c13e2867d 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86
that would set a temporary mm for
patching, which is initialized after some static-keys are
enabled/disabled.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Dave Hansen
Cc: Masami Hiramatsu
Co-Developed-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 7 ++-
1 file changed
The return value of text_poke_early() and text_poke_bp() is useless.
Remove it.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 4 ++--
arch/x86/kernel/alternative.c| 11
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index ed5fe274a7d8..994c13e2867d 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86
that would set a temporary mm for
patching, which is initialized after some static-keys are
enabled/disabled.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Dave Hansen
Cc: Masami Hiramatsu
Co-Developed-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 7 ++-
1 file changed
The return value of text_poke_early() and text_poke_bp() is useless.
Remove it.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 4 ++--
arch/x86/kernel/alternative.c| 11
From: Nadav Amit
Sent: November 13, 2018 at 5:55:34 PM GMT
> To: Ingo Molnar
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , LKML ,
> Logan Gunthorpe
> Subject:
From: Nadav Amit
Sent: November 13, 2018 at 5:55:34 PM GMT
> To: Ingo Molnar
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , X86 ML , Linux Kbuild mailing
> list , LKML ,
> Logan Gunthorpe
> Subject:
From: Andy Lutomirski
Sent: November 13, 2018 at 5:47:16 PM GMT
> To: Nadav Amit
> Cc: Igor Stoppa , Kees Cook ,
> Peter Zijlstra , Mimi Zohar ,
> Matthew Wilcox , Dave Chinner ,
> James Morris , Michal Hocko , Kernel
> Hardening , linux-integrity
> , LSM List
>
From: Andy Lutomirski
Sent: November 13, 2018 at 5:47:16 PM GMT
> To: Nadav Amit
> Cc: Igor Stoppa , Kees Cook ,
> Peter Zijlstra , Mimi Zohar ,
> Matthew Wilcox , Dave Chinner ,
> James Morris , Michal Hocko , Kernel
> Hardening , linux-integrity
> , LSM List
>
From: Ingo Molnar
Sent: November 13, 2018 at 11:30:00 AM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , x...@kernel.org, linux-kbu...@vger.kernel.org,
> linux-kernel@vger.kernel.org
> Su
From: Ingo Molnar
Sent: November 13, 2018 at 11:30:00 AM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , Masahiro Yamada
> , Michal Marek ,
> Thomas Gleixner , Borislav Petkov , H.
> Peter Anvin , x...@kernel.org, linux-kbu...@vger.kernel.org,
> linux-kernel@vger.kernel.org
> Su
file. Since this is less efficient, this
compilation mode is only used when make is called with the "DISTCC=y"
parameter.
Note that the assembly stage should also be distributed, if distcc is
configured using "CFLAGS=-DENABLE_REMOTE_ASSEMBLE".
Reported-by: Logan Gunthorpe
file. Since this is less efficient, this
compilation mode is only used when make is called with the "DISTCC=y"
parameter.
Note that the assembly stage should also be distributed, if distcc is
configured using "CFLAGS=-DENABLE_REMOTE_ASSEMBLE".
Reported-by: Logan Gunthorpe
Changes in macros.S should trigger the recompilation of all C files, as
the macros might need to affect their compilation.
Signed-off-by: Nadav Amit
---
scripts/Makefile.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
Changes in macros.S should trigger the recompilation of all C files, as
the macros might need to affect their compilation.
Signed-off-by: Nadav Amit
---
scripts/Makefile.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
There has been a complaint that the recent use of assembly macros in C
files broke distcc. The first patch fixes this issue.
The second patch adds a dependency for all C files on macros.S, to
trigger their recompilation when the relevant macros change.
Nadav Amit (2):
Makefile: Fix distcc
There has been a complaint that the recent use of assembly macros in C
files broke distcc. The first patch fixes this issue.
The second patch adds a dependency for all C files on macros.S, to
trigger their recompilation when the relevant macros change.
Nadav Amit (2):
Makefile: Fix distcc
Peter,
I have put you as a “Co-Developed-by”, since the patch ended up as being the
single line that you wrote in the correspondence of the previous version.
I would therefore need to ask for your signed-off-by.
Regards,
Nadav
From: Nadav Amit
Sent: November 10, 2018 at 11:17:24 PM GMT
Peter,
I have put you as a “Co-Developed-by”, since the patch ended up as being the
single line that you wrote in the correspondence of the previous version.
I would therefore need to ask for your signed-off-by.
Regards,
Nadav
From: Nadav Amit
Sent: November 10, 2018 at 11:17:24 PM GMT
From: Peter Zijlstra
Sent: November 11, 2018 at 11:52:20 PM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , LKML , X86
> ML , H. Peter Anvin , Thomas Gleixner
> , Borislav Petkov , Dave Hansen
> , Andy Lutomirski , Kees Cook
> , Dave Hansen , Masami
> Hiramatsu
> Subject:
From: Peter Zijlstra
Sent: November 11, 2018 at 11:52:20 PM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , LKML , X86
> ML , H. Peter Anvin , Thomas Gleixner
> , Borislav Petkov , Dave Hansen
> , Andy Lutomirski , Kees Cook
> , Dave Hansen , Masami
> Hiramatsu
> Subject:
From: Peter Zijlstra
Sent: November 11, 2018 at 2:59:36 PM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , linux-kernel@vger.kernel.org,
> x...@kernel.org, H. Peter Anvin , Thomas Gleixner
> , Borislav Petkov , Dave Hansen
> , Andy Lutomirski , Kees Cook
> , Dave Hansen , M
From: Peter Zijlstra
Sent: November 11, 2018 at 2:59:36 PM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , linux-kernel@vger.kernel.org,
> x...@kernel.org, H. Peter Anvin , Thomas Gleixner
> , Borislav Petkov , Dave Hansen
> , Andy Lutomirski , Kees Cook
> , Dave Hansen , M
From: Damian Tometzki
Sent: November 11, 2018 at 7:11:42 PM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , linux-kernel@vger.kernel.org>,
> x...@kernel.org>, H. Peter Anvin , Thomas Gleixner
> , Borislav Petkov , Dave Hansen
> , Andy Lutomirski , Kees Cook
> , Pete
From: Damian Tometzki
Sent: November 11, 2018 at 7:11:42 PM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , linux-kernel@vger.kernel.org>,
> x...@kernel.org>, H. Peter Anvin , Thomas Gleixner
> , Borislav Petkov , Dave Hansen
> , Andy Lutomirski , Kees Cook
> , Pete
From: Peter Zijlstra
Sent: November 11, 2018 at 2:43:27 PM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , linux-kernel@vger.kernel.org,
> x...@kernel.org, H. Peter Anvin , Thomas Gleixner
> , Borislav Petkov , Dave Hansen
> , Kees Cook , Dave Hansen
>
> Subject: Re:
From: Peter Zijlstra
Sent: November 11, 2018 at 2:43:27 PM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , linux-kernel@vger.kernel.org,
> x...@kernel.org, H. Peter Anvin , Thomas Gleixner
> , Borislav Petkov , Dave Hansen
> , Kees Cook , Dave Hansen
>
> Subject: Re:
From: Peter Zijlstra
Sent: November 11, 2018 at 3:05:53 PM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , linux-kernel@vger.kernel.org,
> x...@kernel.org, H. Peter Anvin , Thomas Gleixner
> , Borislav Petkov , Dave Hansen
> , Andy Lutomirski , Kees Cook
> , Dave Hansen , M
From: Peter Zijlstra
Sent: November 11, 2018 at 3:05:53 PM GMT
> To: Nadav Amit
> Cc: Ingo Molnar , linux-kernel@vger.kernel.org,
> x...@kernel.org, H. Peter Anvin , Thomas Gleixner
> , Borislav Petkov , Dave Hansen
> , Andy Lutomirski , Kees Cook
> , Dave Hansen , M
text_poke return value [masami]
- Use __weak for poking_init instead of macros [masami]
- Simplify error handling in poking_init [masami]
Andy Lutomirski (1):
x86/mm: temporary mm struct
Nadav Amit (9):
Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"
x86/jump_
Lockdep-enforce text_mutex in
text_poke*()")
Suggested-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 3 +-
arch/x86/kernel/alternative.c| 72 +---
arch/x86/kernel/kgdb.c | 15 --
3 files changed,
text_poke return value [masami]
- Use __weak for poking_init instead of macros [masami]
- Simplify error handling in poking_init [masami]
Andy Lutomirski (1):
x86/mm: temporary mm struct
Nadav Amit (9):
Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"
x86/jump_
Lockdep-enforce text_mutex in
text_poke*()")
Suggested-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 3 +-
arch/x86/kernel/alternative.c| 72 +---
arch/x86/kernel/kgdb.c | 15 --
3 files changed,
that would set a temporary mm for
patching, which is initialized after some static-keys are
enabled/disabled.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Dave Hansen
Cc: Masami Hiramatsu
Co-Developed-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 7 ++-
1 file changed
Provide a function for copying init_mm. This function will be later used
for setting a temporary mm.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
include/linux/sched/task.h | 1
that would set a temporary mm for
patching, which is initialized after some static-keys are
enabled/disabled.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Dave Hansen
Cc: Masami Hiramatsu
Co-Developed-by: Peter Zijlstra
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 7 ++-
1 file changed
Provide a function for copying init_mm. This function will be later used
for setting a temporary mm.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
include/linux/sched/task.h | 1
Hiramatsu
Tested-by: Masami Hiramatsu
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/pgtable.h | 3 +++
arch/x86/include/asm/text-patching.h | 2 ++
arch/x86/kernel/alternative.c| 3 +++
arch/x86/mm/init_64.c| 39
text_poke() already ensures that the written value is the correct one
and fails if that is not the case. There is no need for an additional
comparison. Remove it.
Signed-off-by: Nadav Amit
---
arch/x86/kernel/kgdb.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/arch/x86/kernel
: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/mmu_context.h | 20
1 file changed, 20 insertions(+)
diff --git a/arch/x86/include/asm
text_poke() already ensures that the written value is the correct one
and fails if that is not the case. There is no need for an additional
comparison. Remove it.
Signed-off-by: Nadav Amit
---
arch/x86/kernel/kgdb.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/arch/x86/kernel
: Peter Zijlstra
Cc: Dave Hansen
Reviewed-by: Masami Hiramatsu
Tested-by: Masami Hiramatsu
Signed-off-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/mmu_context.h | 20
1 file changed, 20 insertions(+)
diff --git a/arch/x86/include/asm
Hiramatsu
Tested-by: Masami Hiramatsu
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/pgtable.h | 3 +++
arch/x86/include/asm/text-patching.h | 2 ++
arch/x86/kernel/alternative.c| 3 +++
arch/x86/mm/init_64.c| 39
Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Suggested-by: Thomas Gleixner
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/kernel/alternative.c | 28 +---
arch/x86/kernel/module.c | 2 +-
include/linux/filter.h| 6 ++
kernel
not conservative enough when mapping pages,
as it always tries to map 2 pages, even when a single one is sufficient.
So try to be more conservative, and do not map more than needed.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
The return value of text_poke_early() and text_poke_bp() is useless.
Remove it.
Cc: Andy Lutomirski
Cc: Kees Cook
Cc: Peter Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Signed-off-by: Nadav Amit
---
arch/x86/include/asm/text-patching.h | 4 ++--
arch/x86/kernel/alternative.c| 11
Signed-off-by: Nadav Amit
---
arch/x86/kernel/jump_label.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index ed5fe274a7d8..7947df599e58 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86/kernel
Zijlstra
Cc: Dave Hansen
Cc: Masami Hiramatsu
Suggested-by: Thomas Gleixner
Suggested-by: Andy Lutomirski
Signed-off-by: Nadav Amit
---
arch/x86/kernel/alternative.c | 28 +---
arch/x86/kernel/module.c | 2 +-
include/linux/filter.h| 6 ++
kernel
701 - 800 of 2169 matches
Mail list logo