Re: [PATCH v6 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Hi Brian, On 2017年12月07日 05:52, Brian Norris wrote: Hi Nickey, others, I just want to highlight a thing or two here. Otherwise, my 'Reviewed-by' still basically stands (FWIW). On Wed, Dec 06, 2017 at 05:08:21PM +0800, Nickey Yang wrote: Add the ROCKCHIP DSI controller driver that uses

Re: [PATCH v6 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Hi Brian, On 2017年12月07日 05:52, Brian Norris wrote: Hi Nickey, others, I just want to highlight a thing or two here. Otherwise, my 'Reviewed-by' still basically stands (FWIW). On Wed, Dec 06, 2017 at 05:08:21PM +0800, Nickey Yang wrote: Add the ROCKCHIP DSI controller driver that uses

[PATCH v7 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> Signed-off-by: Brian Norris <briannor...@chromium.org> Reviewed-by: Brian Norris <briannor...@chromium.org> Revi

[PATCH v7 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul --- changes: v2: add err_pllref, remove unnecessary encoder.enable & dis

[PATCH v7 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

;briannor...@chromium.org> Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> Link:https://patchwork.kernel.org/patch/10078493/ --- Changes v4: - Add From tag,update subject line - keep patch "drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove" in this piece together. v5: - r

[PATCH v7 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

From: Brian Norris Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris Signed-off-by: Nickey Yang Link:https

[PATCH v7 2/3] dt-bindings: display: rockchip: update DSI controller

This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> Reviewed-by: Brian Norris <

[PATCH v7 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

func dw_mipi_encoder_disable name to dw_mipi_dsi_encoder_disable v7: 1/3: add missing platform_set_drvdata in stm part. Nickey Yang (3): drm/bridge/synopsys: dsi: stop clobbering drvdata dt-bindings: display: rockchip: update DSI controller drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver .../display

[PATCH v7 2/3] dt-bindings: display: rockchip: update DSI controller

This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang Reviewed-by: Brian Norris --- .../display/rockchip

[PATCH v7 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

func dw_mipi_encoder_disable name to dw_mipi_dsi_encoder_disable v7: 1/3: add missing platform_set_drvdata in stm part. Nickey Yang (3): drm/bridge/synopsys: dsi: stop clobbering drvdata dt-bindings: display: rockchip: update DSI controller drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver .../display

[PATCH v6 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> Signed-off-by: Brian Norris <briannor...@chromium.org> Reviewed-by: Brian Norris <briannor...@chromium.org> Revi

[PATCH v6 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul --- change: v2: add err_pllref, remove unnecessary encoder.enable & dis

[PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

;briannor...@chromium.org> Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> Link:https://patchwork.kernel.org/patch/10078493/ --- Changes v4: - Add From tag,update subject line - keep patch "drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove" in this piece together. v5: - r

[PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

From: Brian Norris Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris Signed-off-by: Nickey Yang Link:https

[PATCH v6 2/3] dt-bindings: display: rockchip: update DSI controller

This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> Reviewed-by: Brian Norris <

[PATCH v6 2/3] dt-bindings: display: rockchip: update DSI controller

This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang Reviewed-by: Brian Norris --- .../display/rockchip

[PATCH v6 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

func dw_mipi_encoder_disable name to dw_mipi_dsi_encoder_disable Nickey Yang (3): drm/bridge/synopsys: dsi: stop clobbering drvdata dt-bindings: display: rockchip: update DSI controller drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 +- drive

[PATCH v6 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

func dw_mipi_encoder_disable name to dw_mipi_dsi_encoder_disable Nickey Yang (3): drm/bridge/synopsys: dsi: stop clobbering drvdata dt-bindings: display: rockchip: update DSI controller drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 +- drive

[PATCH v5 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> Signed-off-by: Brian Norris <briannor...@chromium.org> Reviewed-by: Brian Norris <briannor...@chromium.org> Revi

[PATCH v5 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang Signed-off-by: Brian Norris Reviewed-by: Brian Norris Reviewed-by: Sean Paul --- Changes: v2: add err_pllref, remove unnecessary encoder.enable & dis

[PATCH v5 2/3] dt-bindings: display: rockchip: update DSI controller

This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> Reviewed-by: Brian Norris <

[PATCH v5 2/3] dt-bindings: display: rockchip: update DSI controller

This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang Reviewed-by: Brian Norris --- Changes v5: - add review tag

[PATCH v5 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

ans "drm/bridge/synopsys: stop clobbering drvdata" add review tag and add some comments v5: 1/3: fix stm part remove() directly referencing the static dw_mipi_dsi_stm_plat_data struct. 3/3: keep our power domain enabled while touching GRF Nickey Yang (3): drm/bridge/syno

[PATCH v5 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

ans "drm/bridge/synopsys: stop clobbering drvdata" add review tag and add some comments v5: 1/3: fix stm part remove() directly referencing the static dw_mipi_dsi_stm_plat_data struct. 3/3: keep our power domain enabled while touching GRF Nickey Yang (3): drm/bridge/syno

[PATCH v5 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

;briannor...@chromium.org> Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> Link:https://patchwork.kernel.org/patch/10078493/ --- Changes v4: - Add From tag,update subject line - keep patch "drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove" in this piece together. v5: -

[PATCH v5 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

From: Brian Norris Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris Signed-off-by: Nickey Yang Link:https

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Hi Brian, On 2017年12月06日 02:56, Brian Norris wrote: Hi Nickey, On Tue, Dec 05, 2017 at 05:14:11PM +0800, Nickey Yang wrote: On 2017年12月01日 18:07, Philippe CORNU wrote: On 12/01/2017 10:11 AM, Nickey Yang wrote: On 2017年12月01日 16:32, Philippe CORNU wrote: I am sorry to say that but you can

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Hi Brian, On 2017年12月06日 02:56, Brian Norris wrote: Hi Nickey, On Tue, Dec 05, 2017 at 05:14:11PM +0800, Nickey Yang wrote: On 2017年12月01日 18:07, Philippe CORNU wrote: On 12/01/2017 10:11 AM, Nickey Yang wrote: On 2017年12月01日 16:32, Philippe CORNU wrote: I am sorry to say that but you can

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Hi Philippe, On 2017年12月01日 18:07, Philippe CORNU wrote: Hi Nickey, On 12/01/2017 10:11 AM, Nickey Yang wrote: Hi Philippe, On 2017年12月01日 16:32, Philippe CORNU wrote: Dear Nickey, Many thanks for your patch. I am sorry to say that but you can not add my "Acked-by" to this pat

Re: [PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

Hi Philippe, On 2017年12月01日 18:07, Philippe CORNU wrote: Hi Nickey, On 12/01/2017 10:11 AM, Nickey Yang wrote: Hi Philippe, On 2017年12月01日 16:32, Philippe CORNU wrote: Dear Nickey, Many thanks for your patch. I am sorry to say that but you can not add my "Acked-by" to this pat

Re: [PATCH v3 4/5] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Hi Matthias, On 2017年11月29日 04:48, Matthias Kaehlcke wrote: El Tue, Nov 28, 2017 at 07:20:05PM +0800 Nickey Yang ha dit: Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. v2: add err_pllref, remove unnecessary encoder.enable

Re: [PATCH v3 4/5] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Hi Matthias, On 2017年11月29日 04:48, Matthias Kaehlcke wrote: El Tue, Nov 28, 2017 at 07:20:05PM +0800 Nickey Yang ha dit: Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. v2: add err_pllref, remove unnecessary encoder.enable

[PATCH v4 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> Reviewed-by: Brian Norris <briannor...@chromium.org> Reviewed-by: Sean Paul <seanp...@chromium.org> --- Chang

[PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

;briannor...@chromium.org> Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> Reviewed-by: Matthias Kaehlcke <m...@chromium.org> Reviewed-by: Archit Taneja <arch...@codeaurora.org> Acked-by: Philippe Cornu <philippe.co...@st.com> Link:https://patchwork.kernel.org/patch/1007

[PATCH v4 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

ans "drm/bridge/synopsys: stop clobbering drvdata" add review tag and add some comments Nickey Yang (3): drm/bridge/synopsys: dsi: stop clobbering drvdata dt-bindings: display: rockchip: update DSI controller drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver .../display

[PATCH v4 3/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang Reviewed-by: Brian Norris Reviewed-by: Sean Paul --- Changes log: v2: add err_pllref, remove unnecessary encoder.enable & disable correct spelling mist

[PATCH v4 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata

From: Brian Norris Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris Signed-off-by: Nickey Yang Reviewed

[PATCH v4 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

ans "drm/bridge/synopsys: stop clobbering drvdata" add review tag and add some comments Nickey Yang (3): drm/bridge/synopsys: dsi: stop clobbering drvdata dt-bindings: display: rockchip: update DSI controller drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver .../display

[PATCH v4 2/3] dt-bindings: display: rockchip: update DSI controller

This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- Changes in v4: - keep the

[PATCH v4 2/3] dt-bindings: display: rockchip: update DSI controller

This patch update describe panel/port links, including unit addresses in documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang --- Changes in v4: - keep the -cells properties .../display

Re: [PATCH v3 5/6] dt-bindings: add the rockchip, dual-channel for dw-mipi-dsi

Hi Archit, On 2017年10月26日 12:53, Archit Taneja wrote: On 10/25/2017 09:21 AM, Nickey Yang wrote: Configure dsi slave channel when driving a panel which needs 2 DSI links. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- .../devicetree/bindings/display/ro

Re: [PATCH v3 5/6] dt-bindings: add the rockchip, dual-channel for dw-mipi-dsi

Hi Archit, On 2017年10月26日 12:53, Archit Taneja wrote: On 10/25/2017 09:21 AM, Nickey Yang wrote: Configure dsi slave channel when driving a panel which needs 2 DSI links. Signed-off-by: Nickey Yang --- .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++   1 file

Re: [PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Hi Archit, On 2017年11月28日 14:27, Archit Taneja wrote: Hi, Thanks a lot for working on this. Some comments below. Those comments have fixed in patch_v3 https://patchwork.kernel.org/patch/10079857/ Thanks for review. On 11/28/2017 07:25 AM, Nickey Yang wrote: Add the ROCKCHIP DSI

Re: [PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Hi Archit, On 2017年11月28日 14:27, Archit Taneja wrote: Hi, Thanks a lot for working on this. Some comments below. Those comments have fixed in patch_v3 https://patchwork.kernel.org/patch/10079857/ Thanks for review. On 11/28/2017 07:25 AM, Nickey Yang wrote: Add the ROCKCHIP DSI

[PATCH v3 5/5] arm64: dts: rockchip: update mipi node for RK3399

This patch update mipi node for RK3399 DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH v3 5/5] arm64: dts: rockchip: update mipi node for RK3399

This patch update mipi node for RK3399 DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip

[PATCH v3 2/5] drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove

Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. So adjust it. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/g

[PATCH v3 2/5] drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove

Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. So adjust it. Signed-off-by: Nickey Yang --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 8

[PATCH v3 4/5] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

use of_device_get_match_data(), change some ‘bind()’ logic into 'probe()' add 'dev_set_drvdata()' Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/gpu/drm/rockchip/Kconfig|2 +- drivers/gpu/drm/rockchip/Makefile |2 +- drivers/gpu/drm/rockch

[PATCH v3 4/5] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

use of_device_get_match_data(), change some ‘bind()’ logic into 'probe()' add 'dev_set_drvdata()' Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/Kconfig|2 +- drivers/gpu/drm/rockchip/Makefile |2 +- drivers/gpu/drm/rockchip/dw-mipi-dsi.c |

[PATCH v3 3/5] dt-bindings: display: rockchip: update DSI controller

This patch update documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++

[PATCH v3 3/5] dt-bindings: display: rockchip: update DSI controller

This patch update documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++ 1 file changed, 19 insertions(+), 4

[PATCH v3 0/5] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

DSI controller driver: call dw_mipi_dsi_unbind() in dw_mipi_dsi_rockchip_unbind() fix typo, use of_device_get_match_data(), change some ‘bind()’ logic into 'probe()' add 'dev_set_drvdata()' Nickey Yang (5): drm/bridge/synopsys: stop clobbering drvdata drm/st

[PATCH v3 1/5] drm/bridge/synopsys: stop clobbering drvdata

Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris Reviewed-by: Matthias Kaehlcke

[PATCH v3 1/5] drm/bridge/synopsys: stop clobbering drvdata

Bridge drivers/helpers shouldn't be clobbering the drvdata, since a parent driver might need to own this. Instead, let's return our 'dw_mipi_dsi' object and have callers pass that back to us for removal. Signed-off-by: Brian Norris Reviewed-by: Matthias Kaehlcke Reviewed-by: Archit Taneja

[PATCH v3 0/5] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

DSI controller driver: call dw_mipi_dsi_unbind() in dw_mipi_dsi_rockchip_unbind() fix typo, use of_device_get_match_data(), change some ‘bind()’ logic into 'probe()' add 'dev_set_drvdata()' Nickey Yang (5): drm/bridge/synopsys: stop clobbering drvdata drm/st

Re: [PATCH 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

on't think you've caught them all here yet. I'll repeat a few. Not sure if I've caught them all. [1] https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/780120 On Tue, Nov 28, 2017 at 09:13:35AM +0800, Nickey Yang wrote: Add the ROCKCHIP DSI controller driver that uses th

Re: [PATCH 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

on't think you've caught them all here yet. I'll repeat a few. Not sure if I've caught them all. [1] https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/780120 On Tue, Nov 28, 2017 at 09:13:35AM +0800, Nickey Yang wrote: Add the ROCKCHIP DSI controller driver that uses th

[PATCH v2 3/3] arm64: dts: rockchip: update mipi node for RK3399

This patch update mipi node for RK3399 DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH v2 3/3] arm64: dts: rockchip: update mipi node for RK3399

This patch update mipi node for RK3399 DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip

[PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/gpu/drm/rockchip/Kconfig|2 +- drivers/gpu/drm/rockchip/Makefile |2 +- drive

[PATCH v2 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/Kconfig|2 +- drivers/gpu/drm/rockchip/Makefile |2 +- drivers/gpu/drm/rockchip/dw-mipi-dsi.c

[PATCH v2 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

err_pllref???remove unnecessary encoder.enable & disable correct spelling mistakes Nickey Yang (3): dt-bindings: display: rockchip: update DSI controller drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver arm64: dts: rockchip: update mipi node for RK3399 .../display/rock

[PATCH v2 1/3] dt-bindings: display: rockchip: update DSI controller

This patch update documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++

[PATCH v2 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

err_pllref???remove unnecessary encoder.enable & disable correct spelling mistakes Nickey Yang (3): dt-bindings: display: rockchip: update DSI controller drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver arm64: dts: rockchip: update mipi node for RK3399 .../display/rock

[PATCH v2 1/3] dt-bindings: display: rockchip: update DSI controller

This patch update documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++ 1 file changed, 19 insertions(+), 4

[PATCH 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/gpu/drm/rockchip/Kconfig|2 +- drivers/gpu/drm/rockchip/Makefile |2 +- drive

[PATCH 2/3] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/Kconfig|2 +- drivers/gpu/drm/rockchip/Makefile |2 +- drivers/gpu/drm/rockchip/dw-mipi-dsi.c

[PATCH 3/3] arm64: dts: rockchip: update mipi node for RK3399

This patch update mipi node for RK3399 DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH 3/3] arm64: dts: rockchip: update mipi node for RK3399

This patch update mipi node for RK3399 DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip

[PATCH 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

We now have a generic dw-mipi-dsi bridge driver.So we send this patchs to moving rockchip dw-mipi-dsi driver to that in order to add new features(dual mipi support). Update ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Nickey Yang (3): dt

[PATCH 0/3] Update ROCKCHIP DSI driver that uses dw-mipi-dsi bridge

We now have a generic dw-mipi-dsi bridge driver.So we send this patchs to moving rockchip dw-mipi-dsi driver to that in order to add new features(dual mipi support). Update ROCKCHIP DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Nickey Yang (3): dt

[PATCH 1/3] dt-bindings: display: rockchip: update DSI controller

This patch update documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++

[PATCH 1/3] dt-bindings: display: rockchip: update DSI controller

This patch update documentation of device tree bindings for the rockchip DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Nickey Yang --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 23 ++ 1 file changed, 19 insertions(+), 4

[PATCH v3 5/6] dt-bindings: add the rockchip,dual-channel for dw-mipi-dsi

Configure dsi slave channel when driving a panel which needs 2 DSI links. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bi

[PATCH v3 5/6] dt-bindings: add the rockchip,dual-channel for dw-mipi-dsi

Configure dsi slave channel when driving a panel which needs 2 DSI links. Signed-off-by: Nickey Yang --- .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockchip

[PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

an 1000. 3、Make the previously configured Feedback divider(LSB) factors effective Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 93 ++ 1 file changed, 62 insertions(+), 31 deletions(-) diff --git a/drivers/

[PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

an 1000. 3、Make the previously configured Feedback divider(LSB) factors effective Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 93 ++ 1 file changed, 62 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/d

[PATCH v3 4/6] drm/rockchip/dsi: add dual mipi channel support

This patch add dual mipi channel support: 1.add definition of dsi1 register and grf operation. 2.dsi0 and dsi1 will work in master and slave mode when driving dual mipi panel. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c

[PATCH v3 6/6] arm64: dts: rockchip: add mipi_dsi1 support for rk3399

This patch adds the mipi_dsi1 related needed information. e.g.: interrupts, grf, clocks, ports and so on. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 1 file changed, 39 insertions(+) diff

[PATCH v3 4/6] drm/rockchip/dsi: add dual mipi channel support

This patch add dual mipi channel support: 1.add definition of dsi1 register and grf operation. 2.dsi0 and dsi1 will work in master and slave mode when driving dual mipi panel. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 377 drivers

[PATCH v3 6/6] arm64: dts: rockchip: add mipi_dsi1 support for rk3399

This patch adds the mipi_dsi1 related needed information. e.g.: interrupts, grf, clocks, ports and so on. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 1 file changed, 39 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip

[PATCH v3 2/6] drm/rockchip/dsi: correct phy parameter setting

As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0> should depend on frequency,so fix it. Reviewed-by: Sean Paul <seanp...@chromium.org> Reviewed-by: Matthias Kaehlcke <m...@chromium.org> Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/

[PATCH v3 1/6] drm/rockchip/dsi: Define and use macros for PHY register addresses

Replace the hardcoded register address numerical values with macros to clarify the code. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 129 ++--- 1 file changed, 85 insertions(+), 44 deletions(-) diff

[PATCH v3 2/6] drm/rockchip/dsi: correct phy parameter setting

As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0> should depend on frequency,so fix it. Reviewed-by: Sean Paul Reviewed-by: Matthias Kaehlcke Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 98 -- 1 file changed, 7

[PATCH v3 1/6] drm/rockchip/dsi: Define and use macros for PHY register addresses

Replace the hardcoded register address numerical values with macros to clarify the code. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 129 ++--- 1 file changed, 85 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw

[PATCH v2 7/8] arm64: dts: rockchip: add a grf clk for dw-mipi-dsi

The clk of grf must be enabled before writing grf register for rk3399. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi

[PATCH v2 6/8] arm64: dts: rockchip: rk3399: Correct MIPI DPHY PLL clock

Mipi-dphy's ref_clk connect to clk_dphy_pll inside rk3399. clk_24m -> Gate11[14] -> clk_mipidphy_ref -> Gate21[0] -> clk_dphy_pll So correct it. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +- 1 file changed, 1 insert

[PATCH v2 7/8] arm64: dts: rockchip: add a grf clk for dw-mipi-dsi

The clk of grf must be enabled before writing grf register for rk3399. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399

[PATCH v2 6/8] arm64: dts: rockchip: rk3399: Correct MIPI DPHY PLL clock

Mipi-dphy's ref_clk connect to clk_dphy_pll inside rk3399. clk_24m -> Gate11[14] -> clk_mipidphy_ref -> Gate21[0] -> clk_dphy_pll So correct it. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 4/8] drm/rockchip/dsi: correct phy parameter setting

As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0> should depend on frequency,so fix it. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 98 -- 1 file changed, 70 insertions(+), 28

[PATCH v2 8/8] arm64: dts: rockchip: add mipi_dsi1 support for rk3399

This patch adds the mipi_dsi1 related needed information. e.g.: interrupts, grf, clocks, ports and so on. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 1 file changed, 39 insertions(+) diff

[PATCH v2 4/8] drm/rockchip/dsi: correct phy parameter setting

As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0> should depend on frequency,so fix it. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 98 -- 1 file changed, 70 insertions(+), 28 deletions(-) diff --git a/dri

[PATCH v2 8/8] arm64: dts: rockchip: add mipi_dsi1 support for rk3399

This patch adds the mipi_dsi1 related needed information. e.g.: interrupts, grf, clocks, ports and so on. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 1 file changed, 39 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip

[PATCH v2 5/8] drm/rockchip/dsi: Use DRM_DEV_ERROR instead of dev_err

Rockchip driver has been moved to using the DRM_DEV_ERROR log messages, so change all instances of dev_err. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 62 +- 1 file changed, 31 insertions(+), 31 del

[PATCH v2 2/8] drm/rockchip/dsi: add dual mipi channel support

This patch add dual mipi channel support: 1.add definition of dsi1 register and grf operation. 2.dsi0 and dsi1 will work in master and slave mode when driving dual mipi panel. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c

[PATCH v2 1/8] drm/rockchip/dsi: correct Feedback divider setting

an 1000. 3、Make the previously configured Feedback divider(LSB) factors effective 4、Add the definition of the MIPI PHY register. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 219 ++--- 1 file changed, 146 i

[PATCH v2 3/8] dt-bindings: add the rockchip,dual-channel for dw-mipi-dsi

Configure dsi slave channel when driving a panel which needs 2 DSI links. Signed-off-by: Nickey Yang <nickey.y...@rock-chips.com> --- .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bi

[PATCH v2 5/8] drm/rockchip/dsi: Use DRM_DEV_ERROR instead of dev_err

Rockchip driver has been moved to using the DRM_DEV_ERROR log messages, so change all instances of dev_err. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 62 +- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/gpu

[PATCH v2 2/8] drm/rockchip/dsi: add dual mipi channel support

This patch add dual mipi channel support: 1.add definition of dsi1 register and grf operation. 2.dsi0 and dsi1 will work in master and slave mode when driving dual mipi panel. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 390 drivers

  1   2   >