Re: [PATCH v2] net: macb: do not scan PHYs manually

2016-04-28 Thread Nicolas Ferre
if (IS_ERR(phydev)) { > - err = PTR_ERR(phydev); > - break; > - } > - } > - > - if (err) > - goto err_out_unregister_bus; > - } > } else { > if (pdata) > bp->mii_bus->phy_mask = pdata->phy_mask; > -- Nicolas Ferre

[GIT PULL] at91: dt for 4.7 #2

2016-04-27 Thread Nicolas Ferre
- sama5d4: definition of watchdog IRQ property - addition of the new shutdown controller to sama5d2 & sama5d2 Xplained Florian Vallee (1): ARM: dts: at91: fix typo in sama5d2 PIN_PD24 description Nicolas Ferre (3):

[GIT PULL] at91: defconfig for 4.7 #1

2016-04-27 Thread Nicolas Ferre
: multi_v7_defconfig: add HLCDC drivers as modules Nicolas Ferre (7): ARM: at91/defconfig: add the HDMA controller to sama5_defconfig ARM: at91/defconfig: add HLCDC driver to sama5_defconfig ARM: at91/defconfig: add PDMIC driver to sama5_defconfig ARM: multi_v7_defconfig: add Atmel watchdog

Re: [PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

2016-04-27 Thread Nicolas Ferre
e and basically maintaining this DT file, I think that I'll be informed if people try an unlikely arrangement of patches on this board. So either way, I'm okay. But I do think it's not worth thinking too much about this case. Bye, -- Nicolas Ferre

[PATCH 4/4] ARM: multi_v7_defconfig: add the Atmel sama5d2-compatible ADC driver

2016-04-26 Thread Nicolas Ferre
Add the new sama5d2-compatible ADC driver as a module. Signed-off-by: Nicolas Ferre --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 6a62ebbcae28..1aed38fd4337 100644

[PATCH 3/4] ARM: multi_v7_defconfig: add the Atmel Audio microphone interface PDMIC

2016-04-26 Thread Nicolas Ferre
Add the Atmel Pulse Density Modulation Interface Controller (PDMIC) driver as a module. It's used by sama5d2 SoC for instance. Signed-off-by: Nicolas Ferre --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arc

[PATCH 1/4] ARM: multi_v7_defconfig: add Atmel watchdog timers

2016-04-26 Thread Nicolas Ferre
Add both Atmel watchdog timers to the multi_v7_defconfig. They are added as part of the kernel because it's a core piece of the system. Signed-off-by: Nicolas Ferre --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/multi_v7_defc

[PATCH 2/4] ARM: multi_v7_defconfig: add Atmel ISI (Image Sensor Interface) driver

2016-04-26 Thread Nicolas Ferre
Add the Atmel Image Sensor Interface (ISI) VIDEO driver as a module. Signed-off-by: Nicolas Ferre --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index d72ee27cecae

[PATCH] ARM: at91/defconfig: add PDMIC driver to sama5_defconfig

2016-04-26 Thread Nicolas Ferre
Add Pulse Density Modulation Interface Controller (PDMIC) driver compilation for sama5 default configuration. Is used by sama5d2 SoC for instance. Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs

[PATCH] ARM: at91/defconfig: add HLCDC driver to sama5_defconfig

2016-04-26 Thread Nicolas Ferre
Add the LCD DRM driver with all its dependencies: - the MFD driver - the backlight PWM - the simple panel driver Remove the CONFIG_FB as it is not needed on any sama5 device. Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH] ARM: at91/defconfig: add the HDMA controller to sama5_defconfig

2016-04-26 Thread Nicolas Ferre
Selection of the HDMAC option is now needed to allow some sama5 devices to have the DMA driver compiled. Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig

[PATCH] ARM: dts: at91: sama5d2: add slow clock to watchdog node

2016-04-26 Thread Nicolas Ferre
As the watchdog timer needs the slow clock, add it to the currently defined wdt node. Reported-by: Alexandre Belloni Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/sama5d2.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2

[PATCH] ARM: dts: at91: sama5d2: add shutdown controller node

2016-04-26 Thread Nicolas Ferre
Add the SAMA5D2-Compatible Shutdown Controller node to sama5d2.dtsi and the use of it in the sama5d2 Xplained board dts file. Enable the RTC wakeup event and the "wake up" button support through the input "0" that is present on the board. Signed-off-by: Nicolas Ferre --- ar

[PATCH] ARM: dts: at91: sama5d4: add watchdog interrupt property

2016-04-26 Thread Nicolas Ferre
The "interrupts" property is missing from the watchdog node. Add it with highest priority value of 7. Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/sama5d4.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.

[PATCH] ARM: dts: at91: VInCo: fix phy reset gpio flag

2016-04-26 Thread Nicolas Ferre
Fix gpio active flag for the phy reset-gpios property. The line is active low instead of active high. Actually, this flags was never used by the macb driver. Reported-by: Sergei Shtylyov Cc: Andrew Lunn Cc: David Miller Signed-off-by: Nicolas Ferre --- Hi, Thanks for having reported this bug

[PATCH] ARM: dts: at91: fix typo in sama5d2 PIN_PD24 description

2016-04-26 Thread Nicolas Ferre
ed subject] Signed-off-by: Nicolas Ferre --- Hi, I'll queue this patch in at91-4.7-dt branch. thanks, bye. arch/arm/boot/dts/sama5d2-pinfunc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-

[PATCH] kbuild: fix call to adjust_autoksyms.sh when output directory specified

2016-04-25 Thread Nicolas Ferre
USED_KSYMS option is specified. Signed-off-by: Nicolas Ferre Fixes: 23121ca2b56b ("kbuild: create/adjust generated/autoksyms.h") Cc: Nicolas Pitre Cc: Rusty Russell --- Hi Nicolas, I found this issue while running on today's Linux-next with my ARM cross-compiler. I suspect it's t

Re: [PATCH 03/41] Documentation: arm: fix spelling mistakes

2016-04-25 Thread Nicolas Ferre
Le 25/04/2016 02:24, Eric Engestrom a écrit : > Signed-off-by: Eric Engestrom Hi, thanks for the patch: Acked-by: Nicolas Ferre > --- > Documentation/arm/Atmel/README | 2 +- > Documentation/arm/keystone/knav-qmss.txt | 2 +- So, who will take care of this patch: can

Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-19 Thread Nicolas Ferre
ot;) > Cc: sta...@vger.kernel.org #v4.4 and later Yes, and I can add: Acked-by: Nicolas Ferre and more important: On a sama5d2 Xplained board: Tested-by: Nicolas Ferre Thanks, bye. > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [PATCH 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-04-19 Thread Nicolas Ferre
cfg); >>> + } >>> + >>> + val |= subdev->hsync_active | subdev->vsync_active | >>> + subdev->pclk_sample | ISC_PFE_CFG0_MODE_PROGRESSIVE; >>> + mask = ISC_PFE_CFG0_BPS_MASK | ISC_PFE_CFG0_HPOL_MASK | >>> + ISC_PFE_CFG0_VPOL_MASK | ISC_PFE_CFG0_PPOL_MASK | >>> + ISC_PFE_CFG0_MODE_MASK; >>> + >>> + regmap_update_bits(regmap, ISC_PFE_CFG0, mask, val); >>> + >>> + regmap_update_bits(regmap, ISC_RLP_CFG, ISC_RLP_CFG_MODE_MASK, >>> + current_fmt->reg_rlp_mode); >>> + >>> + regmap_update_bits(regmap, ISC_DCFG, ISC_DCFG_IMODE_MASK, >>> + current_fmt->reg_dcfg_imode); >>> + >>> + isc_set_pipeline(regmap, pipeline); >>> + >>> + /* Update profile */ >>> + regmap_update_bits(regmap, ISC_CTRLEN, >>> + ISC_CTRLEN_UPPRO_MASK, ISC_CTRLEN_UPPRO); >>> + >>> + regmap_read(regmap, ISC_CTRLSR, &val); >>> + while (val & ISC_CTRLSR_UPPRO) { >>> + cpu_relax(); >>> + regmap_read(regmap, ISC_CTRLSR, &val); >>> + } >> >> You need an exit condition here too in case the hardware gets stuck for some >> reason. It shouldn't happen in theory, and always does in practice :-) Absolutely. > Accept, I will add the number of iterations or a timer. Do you think > which is better? Is there any hints in the datasheet? Is the checking of CTRLSR is advised in the datasheet as well? Otherwise, you can contact the ISC designer to ask him what makes more sense to him. Laurent, thanks a lot for your valuable review! Bye, -- Nicolas Ferre

[RESEND PATCH] drm/panel: simple-panel: set appropriate mode type

2016-04-15 Thread Nicolas Ferre
e. In some cases the user provided mode is preferred over the simple panel ones, which might result in unpredictable behavior. Signed-off-by: Boris Brezillon Reviewed-by: Nicolas Ferre Tested-by: Nicolas Ferre --- drivers/gpu/drm/panel/panel-simple.c | 8 1 file changed, 8 insertions(+)

Re: [PATCH] drm: panel: simple-panel: set appropriate mode type

2016-04-15 Thread Nicolas Ferre
Le 28/05/2015 16:25, Boris Brezillon a écrit : > Hi Thierry, > > Could you have a look at this patch (a.k.a. ping) ? It's been a long time and... It seems that this patch doesn't apply anymore but: Reviewed-by: Nicolas Ferre So, I'm updating it and resending right now.

Re: [PATCH] tty/serial: atmel: fix hardware handshake selection

2016-04-15 Thread Nicolas Ferre
A controller can't drive RTS (as explain in the commit message). > Ensure that hardware flow control stays disabled when DMA is used and FIFOs > are not available. > > Signed-off-by: Alexandre Belloni Yes, I agree with the fix: Acked-by: Nicolas Ferre We can also add the foll

Re: [PATCH v6 04/50] mtd: nand: atmel: use mtd_ooblayout_xxx() helpers where appropriate

2016-04-13 Thread Nicolas Ferre
tly accessed. > > Signed-off-by: Boris Brezillon Thanks for the quick rework Boris! Reviewed-by: Nicolas Ferre > --- > drivers/mtd/nand/atmel_nand.c | 50 > +++ > 1 file changed, 31 insertions(+), 19 deletions(-) > > diff --git a/dri

Re: [PATCH v5 04/50] mtd: nand: atmel: use mtd_ooblayout_xxx() helpers where appropriate

2016-04-13 Thread Nicolas Ferre
* This only works on large pages because the ECC controller > + * waits for NAND_CMD_RNDOUTSTART after the NAND_CMD_RNDOUT. > + * Anyway, for small pages, the first ECC byte is at offset > + * 0 in the OOB area. >*/ > chip->cmdfunc(mtd, NAND_CMD_RNDOUT, > - mtd->writesize + eccpos[0], -1); > + mtd->writesize + oobregion.offset, -1); > } > > /* the ECC controller needs to read the ECC just after the data */ > - ecc_pos = oob + eccpos[0]; > + ecc_pos = oob + oobregion.offset; > chip->read_buf(mtd, ecc_pos, eccbytes); > > /* check if there's an error */ > -- Nicolas Ferre

Re: [PATCH v5 22/50] mtd: nand: atmel: switch to mtd_ooblayout_ops

2016-04-13 Thread Nicolas Ferre
Le 30/03/2016 18:14, Boris Brezillon a écrit : > Implementing the mtd_ooblayout_ops interface is the new way of exposing > ECC/OOB layout to MTD users. > > Signed-off-by: Boris Brezillon It seems good: Reviewed-by: Nicolas Ferre Bye, > --- > drivers/mtd/nand

Re: [PATCH 02/12] mtd: nand: atmel: rely on generic DT parsing done in nand_scan_ident()

2016-04-13 Thread Nicolas Ferre
ezillon It seems okay: Reviewed-by: Nicolas Ferre Thanks Boris, bye, > --- > drivers/mtd/nand/atmel_nand.c | 133 > +++--- > 1 file changed, 73 insertions(+), 60 deletions(-) > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/m

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 12/04/2016 15:54, Sergei Shtylyov a écrit : > Hello. > > On 4/12/2016 12:22 PM, Nicolas Ferre wrote: > >>>> With the 'phylib' now being aware of the "reset-gpios" PHY node >>>> property, >>>> there should be no need to f

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
Le 12/04/2016 15:40, Andrew Lunn a écrit : > On Tue, Apr 12, 2016 at 11:22:10AM +0200, Nicolas Ferre wrote: >> Le 11/04/2016 04:28, Andrew Lunn a écrit : >>> On Sat, Apr 09, 2016 at 01:25:03AM +0300, Sergei Shtylyov wrote: >>>> With the 'phylib' now be

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
ut currently works. > >>> You potentially need to add a new property and deprecate the old one. >> >>I would like to avoid that... > > You will need the agreement from the at91-vinco maintainer. If the at91-vinco has to be modified, you have my agreement that it can be modified. Bye, -- Nicolas Ferre

Re: [PATCH RFT 2/2] macb: kill PHY reset code

2016-04-12 Thread Nicolas Ferre
to it seems correct to me (I mean, with proper flag specification). > property, i.e. active low. The new code in the previous patch does > however take the flags into account. Did you check if there are any > device trees which have flags, which were never used, but are now > going to be used and thus break... Flag was used and you are saying that it's taken into account in new code... So, what's the issue? I see a difference in the way the "value" of gpiod_* functions is used. There may be a misunderstanding here... Bye, -- Nicolas Ferre

[GIT PULL] at91: dt for 4.7 #1

2016-03-29 Thread Nicolas Ferre
ntroller's node Cyrille Pitchen (1): ARM: dts: at91: sama5d2: add SFR node Ludovic Desroches (1): ARM: dts: at91: sama5d2: add chipid node Nicolas Ferre (1): ARM: dts: at91: sama5d2: add LCD controller .../devicetree/bindings/arm/atmel-a

[GIT PULL] at91: soc for 4.7 #1

2016-03-29 Thread Nicolas Ferre
arch/arm/mach-at91/soc.h | 12 +++- 4 files changed, 97 insertions(+), 20 deletions(-) -- Nicolas Ferre

[PATCH v2 1/3] ARM: at91: use chipid device for soc detection

2016-03-29 Thread Nicolas Ferre
-by: Alexandre Belloni Acked-by: Rob Herring Signed-off-by: Nicolas Ferre [a...@arndb.de: suggest to use static functions to reduce scope] --- .../devicetree/bindings/arm/atmel-at91.txt | 4 ++ arch/arm/mach-at91/soc.c | 81 +- 2 files

Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection

2016-03-29 Thread Nicolas Ferre
> >> + >> +int __init at91_get_cidr_exid_from_chipid(u32 *cidr, u32 *exid) >> +{ >> > > These should both be 'static', right? Absolutely. I modify this right now and repost a patch. Bye, -- Nicolas Ferre

Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection

2016-03-29 Thread Nicolas Ferre
Le 23/03/2016 14:47, Alexandre Belloni a écrit : > On 23/03/2016 at 12:22:49 +0100, Nicolas Ferre wrote : >> Le 18/03/2016 11:34, Alexandre Belloni a écrit : >>> On 18/03/2016 at 08:21:19 +0100, Ludovic Desroches wrote : >>>> So far, the CIDR and EXID registers we

Re: [PATCH] ARM: at91/dt: sama5d2: add LCD controller

2016-03-29 Thread Nicolas Ferre
Le 10/03/2016 14:31, Nicolas Ferre a écrit : > Note to myself: change the $subject line to: > ARM: dts: at91: sama5d2: add LCD controller > > :-) With $subject changed, queued in at91-4.7-dt branch. > Le 10/03/2016 14:25, Nicolas Ferre a écrit : >> Add LCD controller n

Re: [PATCH] clockevents/drivers/timer-atmel-pit: fix double free_irq

2016-03-29 Thread Nicolas Ferre
against the > next tree of today. Sure, we can still take it now. We will certainly embed it in a future TC rework. Thanks. > So I will apply this to get rid of the warning. And if you manage not to > use the PIT during boot then we won't have the free_irq() mess which is > good. > > Sebastian > -- Nicolas Ferre

Re: [PATCH] arm: at91: do not disable/enable clocks in a row

2016-03-29 Thread Nicolas Ferre
oni > Acked-by: Alexandre Belloni > Signed-off-by: Sebastian Andrzej Siewior Absolutely makes sense: Acked-by: Nicolas Ferre Thanks. > --- > drivers/clocksource/tcb_clksrc.c | 33 + > 1 file changed, 29 insertions(+), 4 deletions(-) > &

Re: [PATCH 1/1] net: macb: remove BUG_ON() and reset the queue to handle RX errors

2016-03-24 Thread Nicolas Ferre
standing for a long time in my backlog ;-). Acked-by: Nicolas Ferre Bye, > --- > drivers/net/ethernet/cadence/macb.c | 59 > ++--- > 1 file changed, 49 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c >

Re: [PATCH 1/1] net: macb: replace macb_writel() call by queue_writel() to update queue ISR

2016-03-24 Thread Nicolas Ferre
nterrupt Disable Register > IMR: Interrupt Mask Register > > Signed-off-by: Cyrille Pitchen > Fixes: bfbb92c44670 ("net: macb: Handle the RXUBR interrupt on all devices") Acked-by: Nicolas Ferre Thanks! > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1

Re: [PATCH v5 0/2] power: reset: support for Atmel alternative Shutdown Controller

2016-03-24 Thread Nicolas Ferre
Le 23/03/2016 22:11, Sebastian Reichel a écrit : > Hi Nicolas, > > On Wed, Mar 23, 2016 at 12:18:46PM +0100, Nicolas Ferre wrote: >> Le 16/03/2016 14:19, Nicolas Ferre a écrit : >>> This is a series to add driver for a new Atmel Shutdown Controller. This >>>

Re: [RESEND PATCH] ARM: at91/dt: sama5d2: add SFR node

2016-03-23 Thread Nicolas Ferre
Le 17/03/2016 17:04, Ludovic Desroches a écrit : > From: Cyrille Pitchen > > This SFR node is looked up by the I2S controller driver to tune the > SFR_I2SCLKSEL register. > > Signed-off-by: Cyrille Pitchen > Signed-off-by: Ludovic Desroches Acked-by: Nicolas Ferre

Re: [PATCH 1/3] ARM: at91: use chipid device for soc detection

2016-03-23 Thread Nicolas Ferre
| 81 >> +- We may need to split this patch in 2 for going through separate arm-soc branches: what do you think Alexandre? Anyway, I can do it myself: no need to re-send a version: Acked-by: Nicolas Ferre We'll queue it in our upcoming at91-4.7

Re: [PATCH v5 0/2] power: reset: support for Atmel alternative Shutdown Controller

2016-03-23 Thread Nicolas Ferre
Le 16/03/2016 14:19, Nicolas Ferre a écrit : > This is a series to add driver for a new Atmel Shutdown Controller. This new > IP > is extensible and some features will be added later (see the TODO section). > Its extensible nature led to write a new binding so that wake-up sourc

[GIT PULL] at91: fixes for 4.6 #1

2016-03-22 Thread Nicolas Ferre
ined: don't disable hsmci regulator ARM: dts: at91: sama5d4 Xplained: don't disable hsmci regulator arch/arm/boot/dts/at91-sama5d3_xplained.dts | 1 + arch/arm/boot/dts/at91-sama5d4_xplained.dts | 1 + 2 files changed, 2 insertions(+) -- Nicolas Ferre

Re: [PATCH] ARM: at91/dt: sama5d3 xplained: don't disable hsmci regulator

2016-03-22 Thread Nicolas Ferre
91/dt: sama5d3 xplained: add fixed > regulator for vmmc0") > Cc: sta...@vger.kernel.org #4.3 and later Acked-by: Nicolas Ferre Like the one about sama5d4 Xplained, I changed the $subject prefix and stacked both on top of at91-4.6-fixes branch that I plan to send to arm-soc soon. Bye

Re: [PATCH] ARM: at91/dt: sama5d4 xplained: don't disable hsmci regulator

2016-03-22 Thread Nicolas Ferre
91/dt: sama5d4 xplained: add regulators for > v(q)mmc1 supplies") > Cc: sta...@vger.kernel.org #4.3 and later Acked-by: Nicolas Ferre And changed the $subject prefix to the new convention: "ARM: dts: at91:" Thanks, bye. > --- > arch/arm/boot/dts/at91-sama5d4

Re: [PATCH 1/5] net: macb: Fix coding style error message

2016-03-20 Thread Nicolas Ferre
Le 13/03/2016 20:10, Moritz Fischer a écrit : > checkpatch.pl gave the following error: > > ERROR: space required before the open parenthesis '(' > + for(; p < end; p++, offset += 4) > > Signed-off-by: Moritz Fischer Acked-by: Nicolas Ferre > --- >

[PATCH v5 0/2] power: reset: support for Atmel alternative Shutdown Controller

2016-03-20 Thread Nicolas Ferre
ile header Changes in v2: - add MODULE_DEVICE_TABLE as advised by Sebastian Reichel - review indentation and braces to correct errors pointed out by checkpatch Nicolas Ferre (2): ARM: dts: at91: shdwc binding: add new shutdown controller documentation power: reset: at91-shdwc: add new shutd

Re: [PATCH v2 1/2] drm: bridge: sil902x

2016-03-20 Thread Nicolas Ferre
Le 06/01/2016 13:25, Boris Brezillon a écrit : > Add basic support for the sil902x RGB -> HDMI bridge. > This driver does not support audio output yet. > > Signed-off-by: Boris Brezillon You can add my: Tested-by: Nicolas Ferre I tested it on a SAMA5D4 Xplained board with a De

Re: [PATCH 0/5] net: macb: Checkpatch cleanups

2016-03-19 Thread Nicolas Ferre
ding style error message > net: macb: Fix coding style warnings > net: macb: Address checkpatch 'check' suggestions > net: macb: Use ether_addr_copy over memcpy > net: macb: Fix simple typo. > > drivers/net/ethernet/cadence/macb.c | 153 > +++++--- > 1 file changed, 70 insertions(+), 83 deletions(-) > -- Nicolas Ferre

Re: [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy

2016-03-19 Thread Nicolas Ferre
Le 13/03/2016 20:10, Moritz Fischer a écrit : > Checkpatch suggests using ether_addr_copy over memcpy > to copy the mac address. > > Signed-off-by: Moritz Fischer Yes: Acked-by: Nicolas Ferre > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1 file changed, 1 ins

Re: [PATCH v4 2/2] power: reset: at91-shdwc: add new shutdown controller driver

2016-03-19 Thread Nicolas Ferre
Le 14/03/2016 21:22, Alexandre Belloni a écrit : > On 10/03/2016 at 16:37:40 +0100, Nicolas Ferre wrote : >> +ATMEL AT91 Alternative Shutdown Controller > > Can't that be sama5d2 instead of alternative? > >> +M: Nicolas Ferre >> +S: Supported >> +F:

[PATCH v5 1/2] ARM: dts: at91: shdwc binding: add new shutdown controller documentation

2016-03-19 Thread Nicolas Ferre
The new shutdown controller compatible with sama5d2 has a new binding documentation and properties. Signed-off-by: Nicolas Ferre Cc: devicet...@vger.kernel.org Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell doc --- Changes in v5: - change naming for this driver: instead

[PATCH v5 2/2] power: reset: at91-shdwc: add new shutdown controller driver

2016-03-19 Thread Nicolas Ferre
some values are encoded in a configuration structure. Signed-off-by: Nicolas Ferre --- Changes in v5: - Instead of the "alternate shdwc" we choose a more specific "sama5d2-compatible shdwc" wording. Change file name, in Kconfig, and the MAINTAINERS file: at91-shdwc.c -&g

Re: [PATCH 2/5] net: macb: Fix coding style warnings

2016-03-19 Thread Nicolas Ferre
function comments, to do it in a separate patch (series). > Also splitting this to more patches will be better. Just by categories > but that's just my opinion. Well, yes... but I won't be too picky for such a patch. So here is my: Acked-by: Nicolas Ferre Thank for your feedback, bye, -- Nicolas Ferre

Re: [PATCH] clockevents/drivers/timer-atmel-pit: fix double free_irq

2016-03-19 Thread Nicolas Ferre
Le 17/03/2016 21:09, Alexandre Belloni a écrit : > clockevents_exchange_device() changes the state from detached to shutdown > and so at that point the IRQ has not yet been requested. > > Signed-off-by: Alexandre Belloni Acked-by: Nicolas Ferre > --- > > Hi Sebastian,

Re: [PATCH 3/5] net: macb: Address checkpatch 'check' suggestions

2016-03-19 Thread Nicolas Ferre
Le 13/03/2016 20:10, Moritz Fischer a écrit : > This commit deals with a bunch of checkpatch suggestions > that without changing behavior make checkpatch happier. > > Signed-off-by: Moritz Fischer Acked-by: Nicolas Ferre > --- > drivers/net/ethernet/c

Re: [PATCH 5/5] net: macb: Fix simple typo.

2016-03-19 Thread Nicolas Ferre
> * descriptor access. >> */ >> static bool hw_is_native_io(void __iomem *addr) >> > > Remove dot at the end of subject and feel free to add my: > Acked-by: Michal Simek Yes, same for me, no dot. But anyway, here is my: Acked-by: Nicolas Ferre Thanks Moritz for the patches and Michal for the reviews. Bye, -- Nicolas Ferre

[PATCH v4 2/2] power: reset: at91-shdwc: add new shutdown controller driver

2016-03-10 Thread Nicolas Ferre
some values are encoded in a configuration structure. Signed-off-by: Nicolas Ferre --- Changes in v4: - fix warning found by 0-day robot: large integer implicitly truncated to unsigned type [-Woverflow] - move to the property debounce-delay-us - move to atmel,wakeup-active-high boolean - add entry

[PATCH] net: macb: fix default configuration for GMAC on AT91

2016-03-10 Thread Nicolas Ferre
terface (GMII or MII). Reported-by: Romain HENRIET Signed-off-by: Nicolas Ferre --- drivers/net/ethernet/cadence/macb.c | 13 +++-- drivers/net/ethernet/cadence/macb.h | 2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/eth

[PATCH v4 1/2] ARM: dts: at91: shdwc binding: add new shutdown controller documentation

2016-03-10 Thread Nicolas Ferre
The new shutdown controller compatible with sama5d2 has a new binding documentation and properties. Signed-off-by: Nicolas Ferre Cc: devicet...@vger.kernel.org Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell --- Changes in v4: - change property to debounce-delay-us so that

[PATCH v4 0/2] power: reset: support for Atmel alternative Shutdown Controller

2016-03-10 Thread Nicolas Ferre
ning of pm_power_off handler - allow to compile it as a module - add COMPILE_TEST directive in Kconfig - update description in file header Changes in v2: - add MODULE_DEVICE_TABLE as advised by Sebastian Reichel - review indentation and braces to correct errors pointed out by checkpatch Nicolas Ferre (

Re: [PATCH] ARM: at91/dt: sama5d2: add LCD controller

2016-03-10 Thread Nicolas Ferre
Note to myself: change the $subject line to: ARM: dts: at91: sama5d2: add LCD controller :-) Le 10/03/2016 14:25, Nicolas Ferre a écrit : > Add LCD controller node that binds to the atmel_hlcdc DRM driver. > > Signed-off-by: Nicolas Ferre > --- > arch/arm/boot/dts/sa

[PATCH] ARM: at91/dt: sama5d2: add LCD controller

2016-03-10 Thread Nicolas Ferre
Add LCD controller node that binds to the atmel_hlcdc DRM driver. Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/sama5d2.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi index 78996bdbd3df

Re: [PATCH 0/3] net: macb: Fix coding style issues

2016-03-07 Thread Nicolas Ferre
ischer (3): > net: macb: Fix coding style error message > net: macb: Fix more coding style issues > net: macb: Address checkpatch 'check' suggestions > > drivers/net/ethernet/cadence/macb.c | 157 > ++++---- > 1 file changed, 71 insertions(+), 86 deletions(-) > -- Nicolas Ferre

Re: [PATCH v3 1/2] ARM: at91/dt: shdwc binding: add new shutdown controller documentation

2016-03-07 Thread Nicolas Ferre
Le 03/10/2015 19:02, Alexandre Belloni a écrit : > On 30/09/2015 at 18:22:00 +0200, Nicolas Ferre wrote : >> +SHDWC Shutdown Controller (Alternative) >> + >> +1) shdwc node >> + >> +required properties: >> +- compatible: should be "atmel,sama5d2-shdwc&qu

Re: [TRIVIAL PATCH] treewide: Remove unnecessary 0x prefixes before %pa extension uses

2016-03-07 Thread Nicolas Ferre
dma_chan *atchan) {} > static void atc_dump_lli(struct at_dma_chan *atchan, struct at_lli *lli) > { > dev_crit(chan2dev(&atchan->chan_common), > - " desc: s%pad d%pad ctrl0x%x:0x%x l0x%pad\n", > + " desc: s%pad d%pad ctrl

Re: [GIT PULL] at91: dt for 4.6 #2

2016-03-03 Thread Nicolas Ferre
ou can just update the date rather than creating a >>> new key. >>> >> >> You probably want to pull his key, it was updated today. >> > > Ah, of course. Yes, with advices from Alexandre and Maxime, I did it just before signing my tag. Thanks for the heads up. Bye, -- Nicolas Ferre

[GIT PULL] at91: dt for 4.6 #2

2016-03-02 Thread Nicolas Ferre
M: dts: at91: sama5d2 Xplained: add user push button Nicolas Ferre (1): ARM: dts: at91: sama5d2: add dma properties to UART nodes Romain Izard (2): ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node ARM: dts: at91: sama5d2: add nand0 and nfc0 nodes Wenyou Yang (1):

Re: [PATCH 01/14] pinctrl: at91: use __maybe_unused to hide pm functions

2016-03-02 Thread Nicolas Ferre
ilently drop them instead of warning. > > Signed-off-by: Arnd Bergmann Indeed, nice like this: Acked-by: Nicolas Ferre Thanks, bye. > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pi

Re: [PATCH] ARM: at91: avoid defining CONFIG_* symbols in source code

2016-03-02 Thread Nicolas Ferre
O_P2V(CONFIG_DEBUG_UART_PHYS) > > As Russell pointed out, we should never #define a macro starting > with CONFIG_ in a source file, as that is rather confusing. > > This renames the macro to avoid the symbol clash. > > Signed-off-by: Arnd Bergmann > Suggested-by: Rus

Re: [PATCH 4/6] usb: ehci-atmel: use __maybe_unused to hide pm functions

2016-03-02 Thread Nicolas Ferre
#ifdef and instead uses a __maybe_unused > annotation to let the compiler know it can silently drop > the function definition. > > Signed-off-by: Arnd Bergmann Acked-by: Nicolas Ferre > --- > drivers/usb/host/ehci-atmel.c | 6 ++ > 1 file changed, 2 insertions(+), 4 de

Re: [PATCH 3/6] usb: ohci-at91: use __maybe_unused to hide pm functions

2016-03-02 Thread Nicolas Ferre
#ifdef and instead uses a __maybe_unused > annotation to let the compiler know it can silently drop > the function definition. > > Signed-off-by: Arnd Bergmann Acked-by: Nicolas Ferre Thanks Arnd, bye. > --- > drivers/usb/host/ohci-at91.c | 8 +++- > 1 file changed

[RESEND PATCH v2] ASoC: atmel_ssc_dai: distinguish the different SSC

2016-03-02 Thread Nicolas Ferre
From: Songjun Wu Cpu_dai id always equals 0, can't distinguish the different SSC. Use platform_device id to record and distinguish the different SSC. Signed-off-by: Songjun Wu Signed-off-by: Nicolas Ferre --- v2: correct my tag to use a "Signed-off-by". drivers/misc/atmel-ss

Re: [RESEND PATCH] ASoC: atmel_ssc_dai: distinguish the different SSC

2016-03-02 Thread Nicolas Ferre
Le 02/03/2016 02:04, Mark Brown a écrit : > On Tue, Mar 01, 2016 at 10:54:29AM +0100, Nicolas Ferre wrote: > >> >> Signed-off-by: Songjun Wu >> Acked-by: Nicolas Ferre >> --- > > I can't look at patches that aren't signed off, please see > Sub

[PATCH 3/3] ARM: dts: at91: sama5d2 Xplained: add leds node

2016-03-01 Thread Nicolas Ferre
From: Wenyou Yang Add the three leds on the sama5d2 Xplained board with their pinctrl node. The blue led is positioned with the "heartbeat" trigger. Signed-off-by: Wenyou Yang [nicolas.fe...@atmel.com: add commit message and adapt to newer kernel] Signed-off-by: Nicolas Ferre ---

[PATCH 0/3] ARM: dts: at91: add more devices to sama5d2 Xplained

2016-03-01 Thread Nicolas Ferre
This little series is for adding more nodes to the SAMA5D2 Xplained board and complete the USB ones. Cyrille Pitchen (1): ARM: dts: at91: sama5d2 Xplained: set pin muxing for usb gadget and usb host Ludovic Desroches (1): ARM: dts: at91: sama5d2 Xplained: add user push button Wenyou Yang

[PATCH 1/3] ARM: dts: at91: sama5d2 Xplained: set pin muxing for usb gadget and usb host

2016-03-01 Thread Nicolas Ferre
adget). Signed-off-by: Cyrille Pitchen Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts index 75341ee

[PATCH 2/3] ARM: dts: at91: sama5d2 Xplained: add user push button

2016-03-01 Thread Nicolas Ferre
From: Ludovic Desroches Add the push button named "PB USER" with code 0x104. Associated pinctrl node is also added. Signed-off-by: Ludovic Desroches Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 18 ++ 1 file changed, 18 insertion

[PATCH 2/2] ARM: dts: at91-sama5d2_xplained: add classD node

2016-03-01 Thread Nicolas Ferre
From: Songjun Wu Enable Class D audio amplifier on the SAMA5D2 Xplained board. Signed-off-by: Songjun Wu [nicolas.fe...@atmel.com: split and adapt patch to newer kernel] Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 1 file changed, 16

[PATCH 1/2] ARM: dts: at91: sama5d2: add classD node

2016-03-01 Thread Nicolas Ferre
: Nicolas Ferre --- Hi, Note that this node needs the audio PLL clock which is not submitted yet. So, this series can't be applied right now: we have to wait for the audio PLL driver and binding to be accepted and included first. I send it right now so that it's not forgotten and easye

Re: [PATCH] ARM: dts: at91: sama5d2: add dma properties to UART nodes

2016-03-01 Thread Nicolas Ferre
Le 26/01/2016 17:30, Nicolas Ferre a écrit : > The dmas/dma-names properties are added to the UART nodes. Note that > additional > properties are needed to enable them at the board level: check bindings for > details. > > Signed-off-by: Nicolas Ferre Added to at91-4.6-dt. By

[RESEND PATCH] ASoC: atmel_ssc_dai: distinguish the different SSC

2016-03-01 Thread Nicolas Ferre
From: Songjun Wu Cpu_dai id always equals 0, can't distinguish the different SSC. Use platform_device id to record and distinguish the different SSC. Signed-off-by: Songjun Wu Acked-by: Nicolas Ferre --- drivers/misc/atmel-ssc.c| 1 + sound/soc/atmel/atmel_ssc_dai.c

Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node

2016-03-01 Thread Nicolas Ferre
rrupt line. > > Signed-off-by: Romain Izard Acked-by: Nicolas Ferre And queued on at91-4.5-dt. Thanks! Bye, > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts > b/ar

Re: linux-next: manual merge of the clk tree with the arm-soc tree

2016-03-01 Thread Nicolas Ferre
commit: >> >> 99a81706526f ("clk: at91: remove IRQ handling and use polling") >> >> from the arm-soc tree and commit: >> >> 8c1b1e54faed ("clk: at91: Remove impossible checks for >> of_clk_get_parent_count()") >> >> from the clk tree. > > And the same for drivers/clk/at91/clk-master.c Stephen, Both fixes seem good. Thanks! Bye, -- Nicolas Ferre

Re: [PATCH v2] tty/serial: at91: restore dynamic driver binding

2016-02-25 Thread Nicolas Ferre
Le 25/02/2016 18:08, Romain Izard a écrit : > 2016-02-25 17:09 GMT+01:00 Greg Kroah-Hartman > : >> On Thu, Feb 25, 2016 at 11:01:07AM +0100, Nicolas Ferre wrote: >>> Le 25/02/2016 10:23, Romain Izard a écrit : >>>> In commit c39dfebc7798956fd2140ae6321786ff35da30

Re: [PATCH v2] tty/serial: at91: restore dynamic driver binding

2016-02-25 Thread Nicolas Ferre
low my advice for not including unneeded changes in of the last patch chunk, there's no use delaying the patch just for this. So, here is my: Acked-by: Nicolas Ferre Thanks, bye. PS: another advice: please include linux-arm-kernel as well in your CC list for work on the AT91 platforms:

Re: [PATCH v2] clocksource: atmel-pit: register as a sched_clock

2016-02-24 Thread Nicolas Ferre
an provide you one as a workaround before that we rework the TC driver completely. It has it's own flaws (like re-using a compatible string or preventing the use of the "tclib") but is certainly handy. Bye, -- Nicolas Ferre

Re: [PATCH] tty/serial: at91: restore dynamic driver binding

2016-02-24 Thread Nicolas Ferre
.suppress_bind_attrs= true, > + .name = "atmel_usart", > + .of_match_table = of_match_ptr(atmel_serial_dt_ids), The 2 modifications above are not related to the patch: keep them like they were event if it's not as pretty as you would like... > }, > }; > > Thanks, bye. -- Nicolas Ferre

Re: [PATCH v3] mtd: atmel_nand: move the hsmc_clk from nfc node to nand node

2016-02-23 Thread Nicolas Ferre
dev_warn(&pdev->dev, "NFC clock missing, update your Device > Tree"); > - } > - > nfc->is_initialized = true; > dev_info(&pdev->dev, "NFC is probed.\n"); > > return 0; > } > > -static int atmel_nand_nfc_remove(struct platform_device *pdev) > -{ > - struct atmel_nfc *nfc = &nand_nfc; > - > - if (!IS_ERR(nfc->clk)) > - clk_disable_unprepare(nfc->clk); > - > - return 0; > -} > - > static const struct atmel_nand_nfc_caps sama5d3_nfc_caps = { > .rb_mask = NFC_SR_RB_EDGE0, > }; > @@ -2447,7 +2453,6 @@ static struct platform_driver atmel_nand_nfc_driver = { > .of_match_table = of_match_ptr(atmel_nand_nfc_match), > }, > .probe = atmel_nand_nfc_probe, > - .remove = atmel_nand_nfc_remove, > }; > > static struct platform_driver atmel_nand_driver = { > -- Nicolas Ferre

Re: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node

2016-02-22 Thread Nicolas Ferre
clocks = <&hsmc_clk>; > status = "disabled"; > > nfc@9000 { > @@ -306,7 +307,6 @@ > 0xfc05c000 0x0070 /* NFC HSMC > regs */ >

Re: [PATCH] mtd: atmel_nand: move the hsmc_clk from nfc node to nand node

2016-02-22 Thread Nicolas Ferre
lized = true; > dev_info(&pdev->dev, "NFC is probed.\n"); > > return 0; > } > > -static int atmel_nand_nfc_remove(struct platform_device *pdev) > -{ > - struct atmel_nfc *nfc = &nand_nfc; > - > - if (!IS_ERR(nfc->clk)) > - clk_disable_unprepare(nfc->clk); > - > - return 0; > -} > - > static const struct atmel_nand_nfc_caps sama5d3_nfc_caps = { > .rb_mask = NFC_SR_RB_EDGE0, > }; > @@ -2447,7 +2445,6 @@ static struct platform_driver atmel_nand_nfc_driver = { > .of_match_table = of_match_ptr(atmel_nand_nfc_match), > }, > .probe = atmel_nand_nfc_probe, > - .remove = atmel_nand_nfc_remove, > }; > > static struct platform_driver atmel_nand_driver = { > -- Nicolas Ferre

Re: [PATCH v2 01/15] arm: use of_platform_default_populate() to populate default bus

2016-02-22 Thread Nicolas Ferre
NULL) > soc_dev = soc_device_to_device(soc); > > - of_platform_populate(NULL, of_default_bus_match_table, NULL, soc_dev); > + of_platform_default_populate(NULL, NULL, soc_dev); > at91sam9x5_pm_init(); > } For AT91: Acked-by: Nicolas Ferre Thanks, bye. -- Nicolas Ferre

[GIT PULL] at91: fixes for 4.5 #1

2016-01-28 Thread Nicolas Ferre
interrupt Mohamed Jamsheeth Hajanajubudeen (1): ARM: dts: at91: sama5d4: fix instance id of DBGU Nicolas Ferre (2): ARM: dts: at91: sama5d2 xplained: add phy address and IRQ for macb0 ARM: dts: at91: sama5d4 xplained: fix phy0 IRQ type Wenyou Yang (1): ARM: dts: at91

Re: [PATCH v3 1/3] spi: atmel: add support for the internal chip-select of the spi controller

2016-01-27 Thread Nicolas Ferre
Le 27/01/2016 16:53, Måns Rullgård a écrit : > Nicolas Ferre writes: > >> Le 05/01/2016 22:50, Måns Rullgård a écrit : >>> Cyrille Pitchen writes: >>> >>>> This patch relies on the CSAAT (Chip Select Active After Transfer) feature >>>> intro

[PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform

2016-01-27 Thread Nicolas Ferre
discussion] Reported-by: Mans Rullgard Fixes: 4820303480a1 ("spi: atmel: add support for the internal chip-select of the spi controller") Cc: # 4.2+ Signed-off-by: Nicolas Ferre --- drivers/spi/spi-atmel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-atmel.c b/drive

Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-27 Thread Nicolas Ferre
Le 27/01/2016 16:51, Nicolas Ferre a écrit : > Le 27/01/2016 15:04, Arnd Bergmann a écrit : >> The macb_clk_init function returns three clock pointers, unless >> the it fails to get the first ones. We correctly handle the >> failure case by propagating the error from macb_p

Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-27 Thread Nicolas Ferre
clk *pclk, *hclk, *tx_clk; > ^ > > This shuts up the misleading warnings by ensuring that the > macb_clk_init() always stores something into all three pointers. > > Signed-off-by: Arnd Bergmann Okay Arnd, thanks! Acked-by: Nicolas Ferre > --- > driver

<    1   2   3   4   5   6   7   8   9   10   >