Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-20 Thread Péter Ujfalusi
Hi Alice, On 4/19/21 7:27 AM, Alice Guo (OSS) wrote: > From: Alice Guo > > Update all the code that use soc_device_match because add support for > soc_device_match returning -EPROBE_DEFER. > > Signed-off-by: Alice Guo > --- > drivers/bus/ti-sysc.c | 2 +- >

Re: [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX

2021-04-06 Thread Péter Ujfalusi
On 4/6/21 8:10 PM, Pratyush Yadav wrote: > On 06/04/21 10:25PM, Pratyush Yadav wrote: >> On 06/04/21 06:33PM, Péter Ujfalusi wrote: >>> >>> >>> On 4/6/21 6:09 PM, Pratyush Yadav wrote: >>>> On 04/04/21 04:24PM, Péter Ujfalusi wrote: >>>

Re: [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX

2021-04-06 Thread Péter Ujfalusi
On 4/6/21 6:09 PM, Pratyush Yadav wrote: > On 04/04/21 04:24PM, Péter Ujfalusi wrote: >> Hi Pratyush, >> >> On 3/30/21 8:33 PM, Pratyush Yadav wrote: >>> The CSI2RX subsystem uses PSI-L DMA to transfer frames to memory. It can >>> have up to 32 threads but

Re: [PATCH 13/16] media: ti-vpe: csi2rx: Add CSI2RX support

2021-04-04 Thread Péter Ujfalusi
Hi Pratyush, +1 from me also to the points Tomi raised. few minor comments on the DMAengie side. On 3/30/21 8:33 PM, Pratyush Yadav wrote: > TI's J721E uses the Cadence CSI2RX and DPHY peripherals to facilitate > capture over a CSI-2 bus. > > The Cadence CSI2RX IP acts as a bridge between the

Re: [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX

2021-04-04 Thread Péter Ujfalusi
Hi Pratyush, On 3/30/21 8:33 PM, Pratyush Yadav wrote: > The CSI2RX subsystem uses PSI-L DMA to transfer frames to memory. It can > have up to 32 threads but the current driver only supports using one. So > add an entry for that one thread. If you are absolutely sure that the other threads are

Re: [PATCH 15/17] ASoC: ti: omap-mcsp: remove duplicate test

2021-03-28 Thread Péter Ujfalusi
Hi Pierre, On 3/26/21 11:59 PM, Pierre-Louis Bossart wrote: > cppcheck warning: > > sound/soc/ti/omap-mcbsp.c:379:11: style: The if condition is the same > as the previous if condition [duplicateCondition] > > if (mcbsp->irq) { > ^ > sound/soc/ti/omap-mcbsp.c:376:11: note: First

Re: [PATCH 14/17] ASoC: ti: omap-abe-twl6040: remove useless assignment

2021-03-28 Thread Péter Ujfalusi
On 3/26/21 11:59 PM, Pierre-Louis Bossart wrote: > cppcheck warning: > > sound/soc/ti/omap-abe-twl6040.c:173:10: style: Variable 'ret' is > assigned a value that is never used. [unreadVariable] > int ret = 0; > ^ Thanks, Acked-by: Peter Ujfalusi > > Signed-off-by: Pierre-Louis

Re: [PATCH] dmaengine: ti: k3-udma: Fix NULL pointer dereference error

2021-02-10 Thread Péter Ujfalusi
Hi Kishon, On 2/9/21 2:02 PM, Kishon Vijay Abraham I wrote: > bcdma_get_*() and udma_get_*() checks if bchan/rchan/tchan/rflow is > already allocated by checking if it has a NON NULL value. For the > error cases, bchan/rchan/tchan/rflow will have error value > and bcdma_get_*() and udma_get_*()

Re: [PATCH] dmaengine: ti: k3-udma: Fix NULL pointer dereference error

2021-02-09 Thread Péter Ujfalusi
Hi Kishon, On 2/9/21 2:45 PM, Kishon Vijay Abraham I wrote: > Hi Peter, > > On 09/02/21 5:53 pm, Péter Ujfalusi wrote: >> Hi Kishon, >> >> On 2/9/21 11:00 AM, Kishon Vijay Abraham I wrote: >>> bcdma_get_*() and udma_get_*() checks if bchan/rchan/tchan/rflow

Re: [PATCH] dmaengine: ti: k3-udma: Fix NULL pointer dereference error

2021-02-09 Thread Péter Ujfalusi
Hi Kishon, On 2/9/21 11:00 AM, Kishon Vijay Abraham I wrote: > bcdma_get_*() and udma_get_*() checks if bchan/rchan/tchan/rflow is > already allocated by checking if it has a NON NULL value. For the > error cases, bchan/rchan/tchan/rflow will have error value > and bcdma_get_*() and udma_get_*()

Re: [PATCH] dmaengine: ti: k3-udma: Fix a resource leak in an error handling path

2021-01-26 Thread Péter Ujfalusi
Hi, On 1/24/21 9:09 AM, Christophe JAILLET wrote: In 'dma_pool_create()', we return -ENOMEM, but don't release the resources already allocated, as in all the other error handling paths. Go to 'err_res_free' instead of returning directly. Interesting that I only had error for the bcdma

Re: [PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card

2021-01-26 Thread Péter Ujfalusi
Hi Pavel, On 1/24/21 11:27 AM, Pavel Machek wrote: From: Tony Lindgren We can have multiple connections on a single McBSP instance configured with audio graph card when using TDM (Time Division Multiplexing). Let's allow that by configuring dais dynamically. Still we have _one_ DAI per

Re: [PATCH 2/2] dmaengine: ti: k3-udma: Add support for burst_size configuration for mem2mem

2021-01-12 Thread Péter Ujfalusi
Hi Vinod, On 1/12/21 12:16 PM, Vinod Koul wrote: > On 14-12-20, 10:13, Peter Ujfalusi wrote: >> The UDMA and BCDMA can provide higher throughput if the burst_size of the >> channel is changed from it's default (which is 64 bytes) for Ultra-high >> and high capacity channels. >> >> This

Re: [PATCH] dmaengine: ti: k3-udma: Set rflow count for BCDMA split channels

2021-01-12 Thread Péter Ujfalusi
Hi Vignesh, On 1/12/21 4:14 PM, Vignesh Raghavendra wrote: BCDMA RX channels have one flow per channel, therefore set the rflow_cnt to rchan_cnt. Without this patch, request for BCDMA RX channel allocation fails as rflow_cnt is 0 thus fails to reserve a rflow for the channel. Good catch,

Re: [PATCH 1/3] thermal: ti-soc-thermal: Fix stuck sensor with continuous mode for 4430

2020-12-31 Thread Péter Ujfalusi
Hi Tony, On 12/30/20 10:43 AM, Tony Lindgren wrote: > At least for 4430, trying to use the single conversion mode eventually > hangs the thermal sensor. This can be quite easily seen with errors: > > thermal thermal_zone0: failed to read out thermal zone (-5) > > Also, trying to read the

Re: [PATCH] leds: leds-pwm: Convert to use devm_get_pwm

2012-11-12 Thread Péter Ujfalusi
On 11/10/2012 02:48 AM, Bryan Wu wrote: > On Wed, Nov 7, 2012 at 3:42 AM, Peter Ujfalusi wrote: >> Update the driver to use the new API for requesting pwm so we can take >> advantage of the pwm_lookup table to find the correct pwm to be used for the >> LED functionality. >> If the devm_get_pwm

Re: [PATCH] leds: leds-pwm: Convert to use devm_get_pwm

2012-11-12 Thread Péter Ujfalusi
On 11/10/2012 02:48 AM, Bryan Wu wrote: On Wed, Nov 7, 2012 at 3:42 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote: Update the driver to use the new API for requesting pwm so we can take advantage of the pwm_lookup table to find the correct pwm to be used for the LED functionality. If the

Re: [PATCH 3/3] pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of PMICs

2012-11-08 Thread Péter Ujfalusi
On 11/08/2012 01:29 PM, Grazvydas Ignotas wrote: >> But I want to note that I'm currently trying to clean up the mess around >> twl-core. In my view we have quite a bit of redundancy in there. The PWM A/B >> is for driving the LED A/B outputs. We should have only these modules for >> PWM/LED in

Re: [PATCH 3/3] pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of PMICs

2012-11-08 Thread Péter Ujfalusi
On 11/08/2012 01:29 PM, Grazvydas Ignotas wrote: But I want to note that I'm currently trying to clean up the mess around twl-core. In my view we have quite a bit of redundancy in there. The PWM A/B is for driving the LED A/B outputs. We should have only these modules for PWM/LED in twl-core:

Re: [PATCH 3/3] pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of PMICs

2012-11-07 Thread Péter Ujfalusi
On 11/07/2012 07:12 PM, Grazvydas Ignotas wrote: >> +static int twl4030_pwmled_config(struct pwm_chip *chip, struct pwm_device >> *pwm, >> + int duty_ns, int period_ns) >> +{ >> + int duty_cycle = (duty_ns * TWL4030_LED_MAX) / period_ns; >> + u8 on_time; >>

Re: [PATCH 2/3] pwm: New driver to support PWMs on TWL4030/6030 series of PMICs

2012-11-07 Thread Péter Ujfalusi
On 11/07/2012 06:50 PM, Grazvydas Ignotas wrote: >> +static int twl4030_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) >> +{ >> + int ret; >> + u8 val; >> + >> + ret = twl_i2c_read_u8(TWL4030_MODULE_INTBR, , TWL4030_GPBR1_REG); >> + if (ret < 0) { >> +

Re: [PATCH 2/3] pwm: New driver to support PWMs on TWL4030/6030 series of PMICs

2012-11-07 Thread Péter Ujfalusi
On 11/07/2012 06:50 PM, Grazvydas Ignotas wrote: +static int twl4030_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) +{ + int ret; + u8 val; + + ret = twl_i2c_read_u8(TWL4030_MODULE_INTBR, val, TWL4030_GPBR1_REG); + if (ret 0) { +

Re: [PATCH 3/3] pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of PMICs

2012-11-07 Thread Péter Ujfalusi
On 11/07/2012 07:12 PM, Grazvydas Ignotas wrote: +static int twl4030_pwmled_config(struct pwm_chip *chip, struct pwm_device *pwm, + int duty_ns, int period_ns) +{ + int duty_cycle = (duty_ns * TWL4030_LED_MAX) / period_ns; + u8 on_time; + u8

Re: [PATCH] CLK: clk-twl6040: Initial clock driver for OMAP4+ McPDM fclk clock

2012-10-30 Thread Péter Ujfalusi
Hi Mike, On 10/29/2012 06:30 PM, Mike Turquette wrote: > Peter, > > The patch looks good to me. To be clear, you wan this to go through > clk-next or the mfd tree for avoiding conflicts? clk-next is the best place for it I think. The MFD part to register the device can still wait till we have

Re: [PATCH] CLK: clk-twl6040: Initial clock driver for OMAP4+ McPDM fclk clock

2012-10-30 Thread Péter Ujfalusi
Hi Mike, On 10/29/2012 06:30 PM, Mike Turquette wrote: Peter, The patch looks good to me. To be clear, you wan this to go through clk-next or the mfd tree for avoiding conflicts? clk-next is the best place for it I think. The MFD part to register the device can still wait till we have ccf

Re: [PATCH 0/2] Input: twl*-vibra probe cleanups (devm_* conversion)

2012-10-15 Thread Péter Ujfalusi
Hi Dmitry, On 06/15/2012 12:22 PM, Peter Ujfalusi wrote: > Hello, > > Convert the twl4030, twl6040 vibra drivers to use devm_ at probe time to clean > up the code a bit. > The twl6040-vibra driver needed bigger change since the ordering of the > initialization was not correct. Would it be

Re: [PATCH 0/2] Input: twl*-vibra probe cleanups (devm_* conversion)

2012-10-15 Thread Péter Ujfalusi
Hi Dmitry, On 06/15/2012 12:22 PM, Peter Ujfalusi wrote: Hello, Convert the twl4030, twl6040 vibra drivers to use devm_ at probe time to clean up the code a bit. The twl6040-vibra driver needed bigger change since the ordering of the initialization was not correct. Would it be possible to

Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-09 Thread Péter Ujfalusi
On 10/08/2012 07:35 PM, Tony Lindgren wrote: > - omap-dma.c and omap-pcm.c can test the arch locally as > omap1 and omap2 cannot be compiled together because of > conflicting compiler flags > sound/soc/omap/omap-pcm.c |9 +++-- Tony: is this going to be included in 3.7?

Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-09 Thread Péter Ujfalusi
On 10/08/2012 07:35 PM, Tony Lindgren wrote: - omap-dma.c and omap-pcm.c can test the arch locally as omap1 and omap2 cannot be compiled together because of conflicting compiler flags sound/soc/omap/omap-pcm.c |9 +++-- Tony: is this going to be included in 3.7?