On Tue, Jul 26, 2016 at 01:19:37PM +0800, Bob Liu wrote:
> The current VBD layer reserves buffer space for each attached device based on
> three statically configured settings which are read at boot time.
> * max_indirect_segs: Maximum amount of segments.
> * max_ring_page_order: Maximum order of
On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote:
>
> On 07/25/2016 06:53 PM, Roger Pau Monné wrote:
> ..[snip..]
> >>>> * We get the device lock and blk_mq_freeze_queue() in
> >>>> dynamic_reconfig_device(),
> >>>>and then h
On Mon, Jul 25, 2016 at 06:29:22PM +0800, Bob Liu wrote:
>
> On 07/25/2016 05:20 PM, Roger Pau Monné wrote:
> > On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote:
> >>
> >> On 07/22/2016 07:45 PM, Roger Pau Monné wrote:
> >>> On Fri, Jul 2
On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote:
>
> On 07/22/2016 07:45 PM, Roger Pau Monné wrote:
> > On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote:
> >>
> >> On 07/22/2016 05:34 PM, Roger Pau Monné wrote:
> >>> On Fri, Jul 2
On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote:
>
> On 07/22/2016 05:34 PM, Roger Pau Monné wrote:
> > On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote:
> >>
> >> On 07/22/2016 03:45 PM, Roger Pau Monné wrote:
> >>> On Thu, Jul 2
On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote:
>
> On 07/22/2016 03:45 PM, Roger Pau Monné wrote:
> > On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote:
> >>
> >> On 07/21/2016 04:57 PM, Roger Pau Monné wrote:
> ..[snip]..
> >>>>
On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote:
>
> On 07/21/2016 04:57 PM, Roger Pau Monné wrote:
> > On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote:
> >> The current VBD layer reserves buffer space for each attached device based
> >> on
&g
On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote:
> The current VBD layer reserves buffer space for each attached device based on
> three statically configured settings which are read at boot time.
> * max_indirect_segs: Maximum amount of segments.
> * max_ring_page_order: Maximum order of
On Fri, Jul 15, 2016 at 05:31:48PM +0800, Bob Liu wrote:
> blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not
> as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits
> with initial correct values.
Hm, great, and as usual in Linux there isn't even
On Fri, Jul 15, 2016 at 05:31:47PM +0800, Bob Liu wrote:
> Two places didn't get updated when 64KB page granularity was introduced, this
> patch fix them.
>
> Signed-off-by: Bob Liu
Acked-by: Roger Pau Monné
On Thu, Jul 07, 2016 at 03:42:02AM -0600, Jan Beulich wrote:
> >>> On 07.07.16 at 11:32, wrote:
> > On Thu, Jul 07, 2016 at 01:40:54AM -0600, Jan Beulich wrote:
> >> The ioctl can be called prior to full device setup having completed.
> >>
> >> Signed-off-by: Jan Beulich
> >> ---
> >> drivers/b
On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> The functions such get passed to have been taking pointers to const
> since at least 2.6.16.
>
> Signed-off-by: Jan Beulich
Acked-by: Roger Pau Monné
Although the wording in the commit message looks weird to me, b
On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote:
> ... as being the simpler variant.
>
> Signed-off-by: Jan Beulich
> ---
> drivers/block/xen-blkfront.c |7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfr
On Thu, Jul 07, 2016 at 02:06:12AM -0600, Jan Beulich wrote:
> ... as being the simpler variant.
>
> Signed-off-by: Jan Beulich
Acked-by: Roger Pau Monné
Acked-by: Roger Pau Monné
> ---
> drivers/block/xen-blkfront.c | 43
> +++
> 1 file changed, 19 insertions(+), 24 deletions(-)
>
> --- 4.7-rc6-prefer-xenbus_scanf.orig/drivers/block/xen-blkfront.c
> +++ 4.7-rc6-prefer-xenbu
Acked-by: Roger Pau Monné
On Thu, Jul 07, 2016 at 01:40:54AM -0600, Jan Beulich wrote:
> The ioctl can be called prior to full device setup having completed.
>
> Signed-off-by: Jan Beulich
> ---
> drivers/block/xen-blkfront.c |6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> --- 4.7-rc6-xen.orig/drive
On Thu, Jul 07, 2016 at 01:38:13AM -0600, Jan Beulich wrote:
> Commit 9d092603cc ("xen-blkback: do not leak mode property") left one
> path unfixed; correct this.
>
> Signed-off-by: Jan Beulich
Acked-by: Roger Pau Monné
On Wed, Apr 13, 2016 at 11:15:15AM +0100, Matt Fleming wrote:
> On Wed, 13 Apr, at 11:02:02AM, Roger Pau Monné wrote:
> >
> > With my FreeBSD committer hat:
> >
> > The FreeBSD kernel doesn't contain an EFI entry point, it just contains one
> > single e
On Wed, Apr 13, 2016 at 12:12:25AM +0200, Luis R. Rodriguez wrote:
[...]
> Also, x86 does have a history of short DT use. Just pointing that its there as
> an option as well. I'll Cc you on some thread about that.
I don't see how this is relevant to the conversation that's going on:
How many x86
On Wed, Apr 06, 2016 at 04:02:40PM +0100, Matt Fleming wrote:
[...]
> One place that struck me as suitable for this "hypercall in an EFI
> service stub" approach is the trouble with doing ACPI reboot as
> documented here,
>
> http://lists.xen.org/archives/html/xen-devel/2016-02/msg01609.html
>
On Fri, Apr 08, 2016 at 11:58:54PM +0200, Luis R. Rodriguez wrote:
> On Fri, Apr 08, 2016 at 03:16:14PM +0100, George Dunlap wrote:
> > On 07/04/16 19:51, Luis R. Rodriguez wrote:
> > > While Andrew's position is right in that perhaps only Xen tools have to
> > > deal
> > > with the HVMLite specif
On Tue, Apr 12, 2016 at 02:02:52PM -0700, Andy Lutomirski wrote:
> On Sun, Apr 10, 2016 at 10:12 PM, Juergen Gross wrote:
> > On 08/04/16 22:40, Luis R. Rodriguez wrote:
> >> On Wed, Apr 06, 2016 at 10:40:08AM +0100, David Vrabel wrote:
> >>> On 06/04/16 03:40, Luis R. Rodriguez wrote:
>
> >>
El 26/2/16 a les 16:10, Boris Ostrovsky ha escrit:
> On 02/26/2016 09:42 AM, Brian Gerst wrote:
>> On Fri, Feb 26, 2016 at 8:51 AM, Boris Ostrovsky
>> wrote:
>>> On 02/26/2016 05:53 AM, Roger Pau Monné wrote:
>>>> El 25/2/16 a les 16:16, Boris Ostrovsky ha
El 25/2/16 a les 16:16, Boris Ostrovsky ha escrit:
> PV guests need to have their .bss zeroed out since it is not guaranteed
> to be cleared by Xen's domain builder
I guess I'm missing something, but elf_load_image (in libelf-loader.c)
seems to be able to clear segments (it will zero the memory be
n dropping the "blback" part.
>
> This will make it possible to have the .-:
>
> [1.xvda-0]
> [1.xvda-1]
>
> And we enough space to make it go up to:
>
> [32100.xvdfg9-5]
>
> Signed-off-by: Konrad Rzeszutek Wilk
Acked-by: Roger Pau Monné
According to:
http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg03505.html
Should this have a:
Reported-by: Jan Beulich
Thanks!
El 4/2/16 a les 11:04, David Vrabel ha escrit:
> On 01/02/16 15:38, Boris Ostrovsky wrote:
>> HVMlite guests need to be viewed as having APIC, otherwise smpboot code,
>> for example, will complain.
>
> I think we should consider always giving HVMlite guests an emulated
> APIC. I think this elimin
El 23/01/16 a les 17.12, Konrad Rzeszutek Wilk ha escrit:
> On January 23, 2016 11:01:06 AM EST, "H. Peter Anvin" wrote:
>> On January 23, 2016 7:34:33 AM PST, Konrad Rzeszutek Wilk
>> wrote:
>>>
However, this stub belongs in Linux, not in the Xen toolstack. That
way, when the Linux bo
El 22/01/16 a les 22.35, Boris Ostrovsky ha escrit:
> HVMlite guests need PCI frontend and always have PV devices
We still haven't discussed how to perform pci-passthrough for HVMlite
guests. I admit there's a big chance that we are going to use the PV
pcifront driver but there's no guarantee abou
El 22/01/16 a les 13.34, Wei Liu ha escrit:
> The comment at the beginning of the file is the canonical source of
> licenses for this module. Currently it contains GPL and MIT license.
> Fix the code to reflect the reality.
>
> Signed-off-by: Wei Liu
Acked-by: Roger Pau Monné
Thanks.
El 20/01/16 a les 22.33, Luis R. Rodriguez ha escrit:
> On Wed, Jan 20, 2016 at 1:00 PM, Konrad Rzeszutek Wilk
> wrote:
>>> +static bool x86_init_fn_supports_subarch(struct x86_init_fn *fn)
>>> +{
>>> + if (!fn->supp_hardware_subarch) {
>>> + pr_err("Init sequence fails to declares
El 14/12/15 a les 16.27, Konrad Rzeszutek Wilk ha escrit:
> On Sat, Dec 12, 2015 at 07:25:55PM -0500, Boris Ostrovsky wrote:
>> Using MMUEXT_TLB_FLUSH_MULTI doesn't buy us much since the hypervisor
>> will likely perform same IPIs as would have the guest.
>>
>
> But if the VCPU is asleep, doing it
ted.
> The block code will set the mimimum size supported and we may be able
> to support directly any change in the block framework that lower down
> the minimal size of a request.
>
> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html
>
> Signed-off-by:
El 12/11/15 a les 19.04, Julien Grall ha escrit:
> On 12/11/15 17:51, Roger Pau Monné wrote:
>> El 12/11/15 a les 18.30, Julien Grall ha escrit:
>>> Hi,
>>>
>>> On 12/11/15 16:40, Roger Pau Monné wrote:
>>>>> [1] http://lists.xen.org/archives/html
El 12/11/15 a les 18.30, Julien Grall ha escrit:
> Hi,
>
> On 12/11/15 16:40, Roger Pau Monné wrote:
>>> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html
>>>
>>> Signed-off-by: Julien Grall
>>
>> LGTM, only a couple of typos
ted.
> The block code will set the mimimum size supported and we may be able
> to support directly any change in the block framework that lower down
> the minimal size of a request.
>
> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html
>
> Signed-off-by: J
ted.
> The block code will set the mimimum size supported and we may be able
> to support directly any change in the block framework that lower down
> the minimal size of a request.
>
> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html
>
> Signed-off-
El 12/10/15 a les 20.00, Julien Grall ha escrit:
> On 06/10/15 11:06, Roger Pau Monné wrote:
>> El 06/10/15 a les 11.58, Julien Grall ha escrit:
>>> Hi Roger,
>>>
>>> On 06/10/2015 10:39, Roger Pau Monné wrote:
>>>> El 05/10/15 a les 19.05, Julien
El 10/10/15 a les 10.30, Bob Liu ha escrit:
>
> On 10/03/2015 01:02 AM, Roger Pau Monné wrote:
>> El 05/09/15 a les 14.39, Bob Liu ha escrit:
>>> Split per ring information to an new structure:blkfront_ring_info, also
>>> rename
>>> per blkfront_in
El 10/10/15 a les 6.08, Bob Liu ha escrit:
> On 10/05/2015 10:55 PM, Roger Pau Monné wrote:
>> The same for the pool of persistent grants, it should be per-device and
>> not per-ring.
>>
>> And I think this issue is far worse than the others, because a frontend
>>
El 07/10/15 a les 12.50, Bob Liu ha escrit:
>
> On 10/05/2015 11:08 PM, Roger Pau Monné wrote:
>> El 05/09/15 a les 14.39, Bob Liu ha escrit:
>>> Prepare patch for multi hardware queues/rings, the ring number was set to 1
>>> by
>>> force.
>>
&
El 07/10/15 a les 12.39, Bob Liu ha escrit:
> On 10/05/2015 10:40 PM, Roger Pau Monné wrote:
>> El 05/09/15 a les 14.39, Bob Liu ha escrit:
>>> @@ -2267,6 +2335,12 @@ static int __init xlblk_init(void)
>>> xen_blkif_max_ring_order = 0;
>>> }
&g
El 06/10/15 a les 11.58, Julien Grall ha escrit:
> Hi Roger,
>
> On 06/10/2015 10:39, Roger Pau Monné wrote:
>> El 05/10/15 a les 19.05, Julien Grall ha escrit:
>>> On 05/10/15 17:01, Roger Pau Monné wrote:
>>>> El 11/09/15 a les 21.32, Julien Grall
El 05/10/15 a les 19.05, Julien Grall ha escrit:
> On 05/10/15 17:01, Roger Pau Monné wrote:
>> El 11/09/15 a les 21.32, Julien Grall ha escrit:
>>> The minimal size of request in the block framework is always PAGE_SIZE.
>>> It means that when 64KB guest is support, t
El 22/09/15 a les 12.59, Ian Campbell ha escrit:
> On Mon, 2015-09-14 at 17:23 +0200, Roger Pau Monné wrote:
>> I'm not saying that we shouldn't take those patches, I'm just saying
>> that IMHO this is a workaround, and I would like to see a plan and
>> some
if for example the first request is completed but the
second is not? Could we leave the disk in a bad state as a consequence
of this?
> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html
>
> Signed-off-by: Julien Grall
>
> ---
> Cc: Konrad Rzeszutek Wilk
>
El 11/09/15 a les 21.31, Julien Grall ha escrit:
> The code to get a request is always the same. Therefore we can factorize
> it in a single function.
>
> Signed-off-by: Julien Grall
Acked-by: Roger Pau Monné
--
To unsubscribe from this list: send the line "unsubscribe lin
El 03/10/15 a les 2.34, Bob Liu ha escrit:
>
> On 10/03/2015 01:02 AM, Roger Pau Monné wrote:
>> El 05/09/15 a les 14.39, Bob Liu ha escrit:
>> In order to make this easier to review, do you think you can leave
>> blkfront_info as "info" for now, and do the ren
El 05/09/15 a les 14.39, Bob Liu ha escrit:
> Backend advertises "multi-queue-max-queues" to front, and then read back the
> final negotiated queues/rings from "multi-queue-num-queues" which is wrote by
> blkfront.
>
> Signed-off-by: Bob Liu
> ---
> drivers/block/xen-blkback/blkback.c |8 +++
El 05/09/15 a les 14.39, Bob Liu ha escrit:
> Prepare patch for multi hardware queues/rings, the ring number was set to 1 by
> force.
This should be:
Preparatory patch for multiple hardware queues (rings). The number of
rings is unconditionally set to 1.
But frankly this description is not helpf
El 05/09/15 a les 14.39, Bob Liu ha escrit:
> Split per ring information to an new structure:xen_blkif_ring, so that one vbd
> device can associate with one or more rings/hardware queues.
>
> This patch is a preparation for supporting multi hardware queues/rings.
>
> Signed-off-by: Arianna Avanzi
El 05/09/15 a les 14.39, Bob Liu ha escrit:
> Split per ring information to an new structure:xen_blkif_ring, so that one vbd
> device can associate with one or more rings/hardware queues.
>
> This patch is a preparation for supporting multi hardware queues/rings.
>
> Signed-off-by: Arianna Avanzi
El 05/09/15 a les 14.39, Bob Liu ha escrit:
> The max number of hardware queues for xen/blkfront is set by parameter
> 'max_queues', while the number xen/blkback supported is notified through
> xenstore("multi-queue-max-queues").
>
> The negotiated number was the smaller one, and was written back
El 05/09/15 a les 14.39, Bob Liu ha escrit:
> The per device io_lock became a coarser grained lock after multi-queues/rings
> was introduced, this patch converts it to a fine-grained per ring lock.
>
> NOTE: The per dev_info structure was no more protected by any lock.
I would rewrite this as:
N
El 05/09/15 a les 14.39, Bob Liu ha escrit:
> Prepare patch for multi hardware queues/rings, the ring number was set to 1 by
> force.
>
> * Use 'nr_rings' in per dev_info to identify how many hw queues/rings are
> supported, and a pointer *rinfo for all its rings.
> * Rename 'nr_ring_pages' => '
El 05/09/15 a les 14.39, Bob Liu ha escrit:
> Split per ring information to an new structure:blkfront_ring_info, also rename
> per blkfront_info to blkfront_dev_info.
^ removed.
>
> A ring is the representation of a hardware queue, every vbd device can
> associate
> with one or more blkfront_ri
El 02/10/15 a les 18.12, Wei Liu ha escrit:
> On Fri, Oct 02, 2015 at 06:04:35PM +0200, Roger Pau Monné wrote:
>> El 05/09/15 a les 14.39, Bob Liu ha escrit:
>>> Document multi queues/rings of xen-block.
>>>
>>> Signed-off-by: Bob Liu
>>
>> As said
El 05/09/15 a les 14.39, Bob Liu ha escrit:
> Document multi queues/rings of xen-block.
>
> Signed-off-by: Bob Liu
As said by Konrad, you should send this against the Xen public headers
also (or even before). I have a comment below.
> ---
> include/xen/interface/io/blkif.h | 32 +
El 14/09/15 a les 16.54, Stefano Stabellini ha escrit:
> On Mon, 14 Sep 2015, Roger Pau Monné wrote:
>> IMHO this splitting is just a workaround for the fact that we don't have
>> a 64KB PV block protocol, and this is the real problem that should be
>> solved.
>
>
Hello,
El 14/09/15 a les 14.47, Julien Grall ha escrit:
> On 14/09/15 13:08, Roger Pau Monné wrote:
>>> I'd like to see a basic support of 64KB page granularity upstream before
>>> starting to think about performance improvement. And there is still a
>>>
El 14/09/15 a les 13.21, Julien Grall ha escrit:
> On 14/09/15 12:04, Roger Pau Monné wrote:
>> Hello,
>>
>> El 14/09/15 a les 12.40, Julien Grall ha escrit:
>>> Hi Roger,
>>>
>>> On 14/09/15 09:56, Roger Pau Monné wrote:
>>>> E
Hello,
El 14/09/15 a les 12.40, Julien Grall ha escrit:
> Hi Roger,
>
> On 14/09/15 09:56, Roger Pau Monné wrote:
>> El 07/09/15 a les 17.33, Julien Grall ha escrit:
>>> Hi all,
>>>
>>> ARM64 Linux is supporting both 4KB and 64KB page granularity. Al
El 07/09/15 a les 17.33, Julien Grall ha escrit:
> Hi all,
>
> ARM64 Linux is supporting both 4KB and 64KB page granularity. Although, Xen
> hypercall interface and PV protocol are always based on 4KB page granularity.
>
> Any attempt to boot a Linux guest with 64KB pages enabled will result to a
El 10/09/15 a les 13.48, Julien Grall ha escrit:
> On 10/09/15 12:32, Andrew Turner wrote:
>> On Thu, 10 Sep 2015 16:41:56 +0800
>> Shannon Zhao wrote:
>>
>>> From: Shannon Zhao
>>>
>>> These EFI stub parameters are used to internal communication between
>>> EFI stub and Linux kernel and EFI stub
El 07/09/15 a les 13.35, Bob Liu ha escrit:
>
> On 09/07/2015 07:10 PM, Julien Grall wrote:
>> On 07/09/15 07:07, Bob Liu wrote:
>>> Hi Julien,
>>
>> Hi Bob,
>>
>>> On 09/04/2015 09:51 PM, Julien Grall wrote:
>>>> Hi Roger,
>&
MEMORY_HOTPLUG for the problem to happen.
>
> Reported-by: Roger Pau Monné
> Signed-off-by: Juergen Gross
Tested-by: Roger Pau Monné
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
El 04/09/15 a les 14.05, Juergen Gross ha escrit:
> Instead of using physical addresses for accounting of extra memory
> areas available for ballooning switch to pfns as this is much less
> error prone regarding partial pages.
>
> Reported-by: Roger Pau Monné
> Signed-off
. Due to
this mismatch, blkback can allocate the request pool multiple times, without
freeing it.
In order to fix it, move the freeing of requests to xen_blkif_disconnect to
restore the symmetry between request allocation and freeing.
Reported-by: Julien Grall
Signed-off-by: Roger Pau Monn
Hello,
The following commit:
commit fa84f27e21200dbe7d18c21af424d1de703b7567
Author: Juergen Gross
Date: Wed Aug 19 18:52:34 2015 +0200
xen: avoid early crash of memory limited dom0
Which is queued in:
git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.3
Is giving me the
El 04/09/15 a les 9.47, Juergen Gross ha escrit:
> On 09/04/2015 09:37 AM, Roger Pau Monné wrote:
>> Hello,
>>
>> El 04/09/15 a les 7.07, Juergen Gross ha escrit:
>>> Could you try the attached patch? It should do the job. It is booting
>>> fine on my lapto
areas available for ballooning switch to pfns as this is much less
> error prone regarding partial pages.
Thanks for taking care of this! I've tested it on the box that has
non-page aligned memory ranges and it works fine, only a couple of
comments below.
> Reported-by: Rog
El 03/09/15 a les 17.20, Juergen Gross ha escrit:
> On 09/03/2015 05:01 PM, David Vrabel wrote:
>> On 03/09/15 15:55, Juergen Gross wrote:
>>> On 09/03/2015 04:52 PM, David Vrabel wrote:
>>>> On 03/09/15 15:45, David Vrabel wrote:
>>>>> On 03/09/15 15:
El 03/09/15 a les 14.25, Juergen Gross ha escrit:
> On 09/03/2015 02:05 PM, Roger Pau Monne wrote:
>> On systems with memory maps with ranges that don't end at page
>> boundaries,
>> like:
>>
>> [...]
>> (XEN) 0010 -
El 03/09/15 a les 14.05, Roger Pau Monne ha escrit:
> On systems with memory maps with ranges that don't end at page boundaries,
> like:
>
> [...]
> (XEN) 0010 - dfdf9c00 (usable)
> (XEN) dfdf9c00 - dfe4bc00 (ACPI NVS)
> [...]
&
a_mem array are aligned to page boundaries.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: Boris Ostrovsky
Cc: David Vrabel
Cc: Juergen Gross
Cc: xen-de...@lists.xenproject.org
---
AFAICT this patch needs to be backported to 3.19, 4.0, 4.1 and 4.2.
---
arch/x86/xen/setup.c | 6
a_mem array are aligned to page boundaries.
Signed-off-by: Roger Pau Monné
---
AFAICT this patch needs to be backported to 3.19, 4.0, 4.1 and 4.2.
---
arch/x86/xen/setup.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index 55f388e..dcf5865 1
El 20/08/15 a les 2.40, Julien Grall ha escrit:
> Hi,
>
> Ping? I'm missing some reviews on block and netfront code.
Sorry, I didn't realize some of the patches were changed and the Ack
dropped. I think I've reviewed everything related to block.
Roger.
--
To unsubscribe from this list: send the
could be improved by sharing the page between
> multiple grants.
>
> Signed-off-by: Julien Grall
LGTM:
Acked-by: Roger Pau Monné
> ---
>
> Cc: Konrad Rzeszutek Wilk
> Cc: "Roger Pau Monné"
> Cc: Boris Ostrovsky
> Cc: David Vrabel
>
> Improvem
^first ^in
> This could be improved by share the page with multiple grants.
^sharing
>
> Signed-off-by: Julien Grall
LGTM:
Acked-by: Roger Pau Monné
Just one question.
[...]
> @@ -559,73 +669,30 @@ static int blkif_queue_r
indirect grant, the other for bio page.
>
> Signed-off-by: Julien Grall
Thanks, this looks fine:
Acked-by: Roger Pau Monné
Roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo in
Signed-off-by: Bob Liu
Acked-by: Roger Pau Monné
Should be backported to stable branches.
Roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordo
sted, we can split the part of blkfront_connect that checks for
> optional features, like persistent grants, indirect descriptors and
> flush/barrier features to a separate function and call it from both
> blkfront_connect and blkif_recover
>
> Signed-off-by: Bob Liu
Acked-by: Rog
ed-off-by: Bob Liu
Thanks, this looks correct indeed. If we are using persistent grants the
indirect_pages list should always be empty because blkfront has
pre-allocated enough persistent pages to fill all requests on the ring.
Acked-by: Roger Pau Monné
Should be backported to stable branc
^ initial^ used.
> This could be improved by share the page with multiple grants.
^ sharing the page between
>
> Signed-off-by: Julien Grall
> Cc: Konrad Rzeszutek Wilk
> Cc: Roger Pau Monné
> Cc:
indirect grant, the other for bio page.
>
> Signed-off-by: Julien Grall
> Cc: Konrad Rzeszutek Wilk
> Cc: Roger Pau Monné
> Cc: Boris Ostrovsky
> Cc: David Vrabel
> ---
> Changes in v2:
> - Patch added
> ---
> drivers/block/xen-blkfront.c | 85
&g
Julien Grall
> Cc: Konrad Rzeszutek Wilk
> Cc: Roger Pau Monné
> Cc: Boris Ostrovsky
> Cc: David Vrabel
Acked-by: Roger Pau Monné
With one style fix.
[...]
> static struct grant *get_grant(grant_ref_t *gref_head,
> - unsigned long pfn,
>
only used for read/write request.
>
> Rather than having a function with 2 distinct execution path, separate
> the function in 2. This will also remove one level of tabulation.
>
> Signed-off-by: Julien Grall
> Cc: Konrad Rzeszutek Wilk
> Cc: Roger Pau Monné
> Cc: Boris O
El 21/07/15 a les 5.30, Bob Liu ha escrit:
> There is a bug when migrate from !feature-persistent host to
> feature-persistent
> host, because domU still think new host/backend don't support persistent.
> Dmesg like:
> backed has not unmapped grant: 839
> backed has not unmapped grant: 773
> backe
El 21/07/15 a les 5.30, Bob Liu ha escrit:
> This BUG_ON() in blkif_free() is incorrect, because indirect page can be added
> to list info->indirect_pages in blkif_completion() no matter
> feature_persistent
> is true or false.
>
> Signed-off-by: Bob Liu
Acked-by: Roger
El 21/07/15 a les 5.30, Bob Liu ha escrit:
> This BUG_ON() will be triggered when previous purge work haven't finished.
> It's reasonable under pretty extreme load and should not panic the system.
>
> Signed-off-by: Bob Liu
> ---
> drivers/block/xen-blkback/blkback.c |4 +++-
> 1 file change
Cc: xen-de...@lists.xen.org; David Vrabel; just...@spectralogic.com;
>>> konrad.w...@oracle.com; Roger Pau Monne; Paul Durrant; Julien Grall; linux-
>>> ker...@vger.kernel.org
>>> Subject: Re: [PATCH 3/3] xen/block: add multi-page ring support
>>>
>>>
&g
El 26/05/15 a les 2.06, Bob Liu ha escrit:
> In connect_ring, we can know exactly how many pages are used for the shared
> ring and also whether feature-persistent is enabled, delay pending_req
> allocation here so that we won't waste too much memory.
I would very much prefer for this to be a pre-
El 26/05/15 a les 2.11, Bob Liu ha escrit:
> When migrate from !feature-persistent host to feature-persistent host, domU
> still think new host/backend don't support persistent.
> Dmesg like:
> backed has not unmapped grant: 839
> backed has not unmapped grant: 773
> backed has not unmapped grant:
El 21/05/15 a les 15.03, Bob Liu ha escrit:
> On 05/21/2015 07:22 PM, Roger Pau Monné wrote:
>> El 20/05/15 a les 15.10, Bob Liu ha escrit:
>>> + err = xenbus_scanf(XBT_NIL, dev->otherend,
>>> + ring_ref_name,
El 20/05/15 a les 15.10, Bob Liu ha escrit:
> Extend xen/block to support multi-page ring, so that more requests can be
> issued
> by using more than one pages as the request ring between blkfront and backend.
> As a result, the performance can get improved significantly.
>
> We got some impressi
' and
> 'multi-queue' features.
>
> Changes in v2:
> - Re-write the commit message to be more clear.
>
> Signed-off-by: Bob Liu
With that fixed:
Acked-by: Roger Pau Monné
Roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&
El 20/05/15 a les 15.21, Julien Grall ha escrit:
> Hi,
>
> On 20/05/15 14:10, Bob Liu wrote:
>> ---
>> drivers/block/xen-blkback/blkback.c | 12
>> drivers/block/xen-blkback/common.h | 3 +-
>> drivers/block/xen-blkback/xenbus.c | 85 +---
>> drivers/block/xen-b
El 14/05/15 a les 19.00, Julien Grall ha escrit:
> From: Julien Grall
>
> Make the code less confusing to read now that Linux may not have the
> same page size as Xen.
>
> Signed-off-by: Julien Grall
Acked-by: Roger Pau Monné
--
To unsubscribe from this list: send the
gt; Signed-off-by: Julien Grall
Acked-by: Roger Pau Monné
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
El 14/05/15 a les 19.00, Julien Grall ha escrit:
> From: Julien Grall
>
> Signed-off-by: Julien Grall
Acked-by: Roger Pau Monné
Note that Bob multipage ring patches also remove this.
Roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
th
201 - 300 of 553 matches
Mail list logo
