Re: [PATCH 00/13] [RFC] Rust support

2021-04-15 Thread Paul Zimmerman
On Fri, Apr 16, 2021 at 06:02:33 +0100, Wedson Almeida Filho wrote: > On Fri, Apr 16, 2021 at 04:25:34AM +, Al Viro wrote: > >>> Are you stating [what you perceive as] a fact or just venting? If the >>> former, >>> would you mind enlightening us with some evidence? >> >> How about "not everyo

Re: Linux 5.11-rc4

2021-01-18 Thread Paul Zimmerman
On Mon, Jan 18, 2021 at 14:35:20 -0800, Guenter Roeck wrote: > On Sun, Jan 17, 2021 at 04:56:46PM -0800, Linus Torvalds wrote: >> Things continue to look fairly normal for this release: 5.11-rc4 is >> solidly average in size, and nothing particularly scary stands out. >> >> In the diff itself, the

Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1 (BISECTED)

2019-04-08 Thread Paul Zimmerman
On Sun, Apr 7, 2019 at 10:53 PM Martin Kepplinger wrote: > > On 21.03.19 14:41, Jarkko Sakkinen wrote: > > On Tue, Mar 19, 2019 at 04:03:37PM -0700, Paul Zimmerman wrote: > >> So I bisected this down to: > >> > >> # first bad commit: [a3fbfae82b4cb3ff9928e

Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1 (BISECTED)

2019-03-19 Thread Paul Zimmerman
08 PM Paul Zimmerman wrote: > > Hmm, looks like my original email didn't make it to the linux-integrity > list, maybe the two attachments were too big. You can read it on the > linux-kernel list here: > https://marc.info/?l=linux-kernel&m=155294522323580 > > On Mon, Mar 1

Re: Regression in suspend-to-ram (TPM related) with 5.1-rc1

2019-03-18 Thread Paul Zimmerman
On Mon, Mar 18, 2019 at 2:39 PM Paul Zimmerman wrote: < snip > > It takes about 45 minutes to do a full kernel rebuild on this machine, > so doing a full bisection would be a little painful. Actually, that was because I had the Linux disk attached via USB. I have it connected in

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread Paul Zimmerman
On Tue, 05 Feb 2019 18:52:18 -0800, Joe Perches wrote: > On Tue, 2019-02-05 at 19:27 -0700, Paul Zimmerman wrote: >> On Tue, 2019-02-05, Joe Perches wrote: >>> On Tue, 2019-02-05 at 12:04 -0800, Eric Dumazet wrote: >>> > On 02/05/2019 10:42 AM, Joe Perches wrote:

Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing

2019-02-05 Thread Paul Zimmerman
On Tue, 2019-02-05, Joe Perches wrote: > On Tue, 2019-02-05 at 12:04 -0800, Eric Dumazet wrote: >> >> On 02/05/2019 10:42 AM, Joe Perches wrote: >> > It's declared after a pointer so it is already is 2 byte aligned. >> > >> > A lot of drivers wouldn't work otherwise. >> >> Maybe these drivers ar

[PATCH RESEND] MAINTAINERS: update maintainer entry for dwc2 driver

2015-01-15 Thread Paul Zimmerman
Update the MAINTAINERS entry for the dwc2 driver to show John Youn as the new maintainer Signed-off-by: Paul Zimmerman --- Resending with linux-usb and linux-kernel in CC MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

RE: [PATCH] MAINTAINERS: update maintainer entry for dwc2 driver

2015-01-15 Thread Paul Zimmerman
Adding linux-usb and linux-kernel to CC. -- Paul > -Original Message- > From: Paul Zimmerman > Sent: Thursday, January 15, 2015 11:44 AM > To: gre...@linuxfoundation.org; ba...@ti.com; John Youn > (johny...@synopsys.com) > Cc: 'r.bald...@samsung.com'; &#x

[PATCH] Revert "usb: dwc2: add bus suspend/resume for dwc2"

2015-01-15 Thread Paul Zimmerman
/resume on platforms where it does work correctly. Signed-off-by: Paul Zimmerman --- Based on Felipe's testing/next branch. drivers/usb/dwc2/hcd.c | 88 ++-- 1 files changed, 11 insertions(+), 77 deletions(-) diff --git a/drivers/usb/dwc2/hc

[PATCH] usb: phy: make GPIOs optional for the generic phy

2015-01-14 Thread Paul Zimmerman
>From 47bd18e210fecf701d493c27884e13c69bc449ea Mon Sep 17 00:00:00 2001 From: Paul Zimmerman Date: Wed, 14 Jan 2015 18:15:58 -0800 Subject: [PATCH] usb: phy: make GPIOs optional for the generic phy The use of GPIOs should be optional for the generic phy, otherwise the Altera SOCFPGA platform

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Wednesday, January 14, 2015 2:50 PM > > On Wed, Jan 14, 2015 at 10:45:26PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Wednesday, January 14, 2015 2:40 PM > > > &

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Wednesday, January 14, 2015 2:40 PM > > On Wed, Jan 14, 2015 at 10:28:54PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Wednesday, January 14, 2015 1:46 PM > > > &

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Wednesday, January 14, 2015 1:46 PM > > On Wed, Jan 14, 2015 at 04:41:23PM -0500, Alan Stern wrote: > > > > > This is really, really odd. Register accesses are atomic, so the lock > > > > > isn't really doing anything. Besides, you're calling > >

RE: [PATCH v2] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-14 Thread Paul Zimmerman
's issue, it's certainly a harmless patch, so Acked-by: Paul Zimmerman But I suspect Felipe will want a better changelog, I don't think just a URL is good enough. -- Paul > --- > > Changelog: > > v2: > - fixed comment from Paul Zimmerman > > v1: https://l

RE: [PATCH] usb: dwc2: call dwc2_is_controller_alive() under spinlock

2015-01-13 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Tuesday, January 13, 2015 2:58 AM > > This patch fixes bug described here: > https://lkml.org/lkml/2014/12/22/185 > > Signed-off-by: Robert Baldyga > --- > drivers/usb/dwc2/core_intr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 d

RE: New maintainer for dwc2

2015-01-12 Thread Paul Zimmerman
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Monday, January 12, 2015 5:02 PM > > On Mon, Jan 12, 2015 at 11:14:54PM +, Paul Zimmerman wrote: > > Hi everyone, > > > > I will be leaving Synopsys on Friday, Jan 16th, so the d

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-12 Thread Paul Zimmerman
> From: Paul Zimmerman > Sent: Saturday, January 10, 2015 3:52 PM > > > From: Yunzhi Li [mailto:l...@rock-chips.com] > > Sent: Saturday, January 10, 2015 8:07 AM > > > > 在 2015/1/9 10:15, Paul Zimmerman 写道: > > >> [...] > > >>

New maintainer for dwc2

2015-01-12 Thread Paul Zimmerman
Hi everyone, I will be leaving Synopsys on Friday, Jan 16th, so the dwc2 driver will need a new maintainer. I am recommending John Youn as the new maintainer. On the plus side, John has quite a bit of experience with the dwc2 controller, and has previous experience submitting kernel patches (fo

RE: dwc2: problems with IN requests completion in linux-next

2015-01-12 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Monday, December 22, 2014 6:13 AM > > I have recently noticed problem with DWC2 driver in latest linux-next. I > use it in gadget only mode at Samsung platform (Odroid U3) but I believe > the bug can be reproduced at another platforms.

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-10 Thread Paul Zimmerman
> From: Yunzhi Li [mailto:l...@rock-chips.com] > Sent: Saturday, January 10, 2015 8:07 AM > > 在 2015/1/9 10:15, Paul Zimmerman 写道: > >> [...] > >>/* > >> - * Attempt to find a generic PHY, then look for an old style > >> - * USB PHY, finally

RE: [PATCH v3 00/30] usb: updates for dwc2 gadget driver

2015-01-09 Thread Paul Zimmerman
CCing more of the Samsung folks and linux-kernel. Robert, Marek, can you test this series on your platform, please? If I don't hear from you soon, I'll just ack it and we can deal with any breakage later. -- Paul > From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] > Sent: Friday, Januar

RE: [PATCH v7 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2015-01-08 Thread Paul Zimmerman
> From: Yunzhi Li [mailto:l...@rock-chips.com] > Sent: Friday, December 12, 2014 7:10 AM > > Get PHY parameters from devicetree and power off usb PHY during > system suspend. > > Signed-off-by: Yunzhi Li > Acked-by: Paul Zimmerman > > --- > > Chang

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2015-01-05 Thread Paul Zimmerman
/patch/5325111/ > > Thanks, > > - Kever > On 01/06/2015 09:23 AM, Paul Zimmerman wrote: > >> From: Kever Yang [mailto:kever.y...@rock-chips.com] > >> Sent: Wednesday, November 12, 2014 4:42 PM > >> > >> On 11/13/2014 07:22 AM, Doug Anderson wrote: >

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2015-01-05 Thread Paul Zimmerman
gt;> We also update the lx_state for hsotg state. > >> > >> This patch has tested on rk3288 with suspend/resume. > >> > >> Signed-off-by: Kever Yang > >> Acked-by: Paul Zimmerman > >> --- > >> > >> Changes in v3: > &g

RE: [PATCH] drivers: usb: dwc2: remove 'force' parameter from kill_all_requests()

2015-01-05 Thread Paul Zimmerman
; s3c_hsotg_core_init_disconnected(hsotg); > s3c_hsotg_core_connect(hsotg); > @@ -2588,7 +2581,7 @@ static int s3c_hsotg_ep_disable(struct usb_ep *ep) > > spin_lock_irqsave(&hsotg->lock, flags); > /* terminate all

RE: query on DWC3

2014-12-13 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of sundeep subbaraya > Sent: Friday, December 12, 2014 9:13 PM > > Hi Felipe, > > In DWC3 driver, for three stage Control OUT transfer there is a check: > >else if (!IS_ALIGNED(req->request.length,

RE: [PATCH] usb: dwc2: gadget: kill requests with 'force' in s3c_hsotg_udc_stop()

2014-12-11 Thread Paul Zimmerman
> * @ep: The endpoint to check. > @@ -2933,7 +2937,7 @@ static int s3c_hsotg_udc_stop(struct usb_gadget *gadget, > > /* all endpoints should be shutdown */ > for (ep = 1; ep < hsotg->num_of_eps; ep++) > - s3c_hsotg_ep_disable(&hsotg->eps[ep].ep); &

RE: [PATCH v3 3/5] usb: dwc2: add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Paul Zimmerman
+ } else { > + if (dwc2->lx_state == DWC2_L0) > + return 0; > + phy_exit(dwc2->phy); > + phy_power_off(dwc2->phy); > + > + } > return ret; > } > > @@ -241,8 +268,13 @@ static int __maybe_unused dwc2_resume(struct d

RE: [PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-08 Thread Paul Zimmerman
> From: Yunzhi Li [mailto:l...@rock-chips.com] > Sent: Sunday, December 07, 2014 7:58 PM > > On 2014/12/6 3:04, Paul Zimmerman wrote: > >> From: Yunzhi Li [mailto:l...@rock-chips.com] > >> Sent: Friday, December 05, 2014 4:52 AM > >> > >> Get PHY

RE: [PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-05 Thread Paul Zimmerman
> From: Yunzhi Li [mailto:l...@rock-chips.com] > Sent: Friday, December 05, 2014 4:52 AM > > Get PHY parameters from devicetree and power off usb PHY during > system suspend. > > Signed-off-by: Yunzhi Li > --- > > drivers/usb/dwc2/gadget.c | 33 - > drivers/us

RE: [PATCH] usb: gadget: USB3 support to the legacy printer driver

2014-11-18 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Tuesday, November 18, 2014 12:47 PM > > On Tue, Nov 18, 2014 at 03:41:43PM -0500, Jorge Ramirez-Ortiz wrote: > > > > notice that the original PLX driver was still far from the theo

RE: [PATCHv7 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-11-14 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, November 11, 2014 9:14 AM > > From: Dinh Nguyen > > Since the dwc2 hcd driver is currently not looking for a clock node during > init, we should not completely fail if there isn't a clock provided. >

RE: [PATCHv7 7/8] usb: dwc2: move usb_disabled() call to host driver only

2014-11-14 Thread Paul Zimmerman
> @@ -157,9 +157,6 @@ static int dwc2_driver_probe(struct platform_device *dev) > int retval; > int irq; > > - if (usb_disabled()) > - return -ENODEV; > - > match = of_match_device(dwc2_of_match_table, &dev->dev); >

RE: [PATCHv7 5/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-11-14 Thread Paul Zimmerman
67b..3552602 100644 > --- a/drivers/usb/dwc2/platform.c > +++ b/drivers/usb/dwc2/platform.c > @@ -196,6 +196,14 @@ static int dwc2_driver_probe(struct platform_device *dev) > return irq; > } > > + dev_dbg(hsotg->dev, "registering common handler for irq%d\n", > + irq); > + retval = devm_request_irq(hsotg->dev, irq, > + dwc2_handle_common_intr, IRQF_SHARED, > + dev_name(hsotg->dev), hsotg); > + if (retval) > + return retval; > + > res = platform_get_resource(dev, IORESOURCE_MEM, 0); > hsotg->regs = devm_ioremap_resource(&dev->dev, res); > if (IS_ERR(hsotg->regs)) Acked-by: Paul Zimmerman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [PATCHv7 3/8] usb: dwc2: convert to use dev_pm_ops API

2014-11-14 Thread Paul Zimmerman
.driver = { > .name = dwc2_driver_name, > .of_match_table = dwc2_of_match_table, > + .pm = &dwc2_dev_pm_ops, > }, > .probe = dwc2_driver_probe, > .remove = dwc2_driver_remove, > - .suspend = dwc2_suspend, >

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2014-11-14 Thread Paul Zimmerman
> From: jwer...@google.com [mailto:jwer...@google.com] On Behalf Of Julius > Werner > Sent: Thursday, November 13, 2014 8:50 PM > > > I will figure out how to make dwc2 detect the device connect after auto > > suspend, > > or disable the auto suspend feature for the dwc2 hcd. > > I think auto-su

RE: [PATCH v2] usb: dwc2: add bus suspend/resume for dwc2

2014-11-06 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, November 06, 2014 9:40 AM > > On Thu, Nov 06, 2014 at 06:21:42PM +0100, Romain Perier wrote: > > > > 2014-11-06 2:30 GMT+01:00 Kever Yang : > > > > > > +static int _dwc2_hcd_suspend(struct usb_hcd *hcd) > > > +{ > > > + struct dwc2

RE: [PATCHv6 4/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler

2014-10-31 Thread Paul Zimmerman
e interrupt conditions that was in gadget, as those are > > handled > > by dwc2 common interrupt handler. > > > > Signed-off-by: Dinh Nguyen > > Acked-by: Paul Zimmerman > > --- > > v5: remove individual devm_request_irq from gadget and hcd, and plac

RE: [PATCH] usb: dwc2: add bus suspend/resume for dwc2

2014-10-31 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@gmail.com] On Behalf Of Kever Yang > Sent: Friday, October 31, 2014 7:03 AM > > This patch adds suspend/resume for dwc2 hcd controller. > > Signed-off-by: Kever Yang > --- > > drivers/usb/dwc2/hcd.c | 74 > ++---

RE: [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

2014-10-28 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, October 28, 2014 4:26 PM > > Since the dwc2 hcd driver is currently not looking for a clock node during > init, we should not completely fail if there isn't a clock provided. > For dual-role mode, we wi

RE: [PATCHv6 8/8] usb: dwc2: move usb_disabled() call to host driver only

2014-10-28 Thread Paul Zimmerman
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, October 28, 2014 4:26 PM > > Now that platform.c will get built for both Host and Gadget, if we leave the > usb_disabled() call in platform.c, it results in the following build error > when (!USB && USB

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, October 28, 2014 12:01 PM > > On Tue, Oct 28, 2014 at 06:55:50PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Tuesday, October 28, 2014 11:51 AM > > > &

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, October 28, 2014 11:51 AM > > On Tue, Oct 28, 2014 at 06:47:08PM +, Paul Zimmerman wrote: > > > From: Huang Rui [mailto:ray.hu...@amd.com] > > > Sent: Tuesday, October 28, 2014 4:54 AM > > &

RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported

2014-10-28 Thread Paul Zimmerman
> From: Huang Rui [mailto:ray.hu...@amd.com] > Sent: Tuesday, October 28, 2014 4:54 AM > > It enables hibernation if the function is set in coreConsultant. > > Suggested-by: Felipe Balbi > Signed-off-by: Huang Rui > --- > drivers/usb/dwc3/core.c | 1 + > 1 file changed, 1 insertion(+) > > dif

RE: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-23 Thread Paul Zimmerman
> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Wednesday, October 22, 2014 5:26 AM > > On Monday, October 20, 2014 01:52:06 PM dingu...@opensource.altera.com wrote: > > From: Dinh Nguyen > > > > config USB_DWC2_PLATFORM > > bool "DWC2 Platform" > > - depends on

RE: [PATCH] usb: serial: Fix indentation style issue

2014-10-22 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Greg KH > Sent: Wednesday, October 22, 2014 7:19 AM > > On Wed, Oct 22, 2014 at 11:51:12AM +0200, Johan Hovold wrote: > > On Sat, Oct 11, 2014 at 07:20:49AM -0700, Greg Kroah-Hartman wrote: > > > On Sa

RE: [PATCHv5 2/7] usb: dwc2: Move gadget probe function into platform code

2014-10-22 Thread Paul Zimmerman
> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Wednesday, October 22, 2014 4:16 AM > > On Monday, October 20, 2014 01:52:01 PM dingu...@opensource.altera.com wrote: > > From: Dinh Nguyen > > > > This patch will aggregate the probing of gadget/hcd driver into platform.

RE: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

2014-10-22 Thread Paul Zimmerman
> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] > Sent: Tuesday, October 21, 2014 1:48 PM > > diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig > index f93807b..1ea702e 100644 > --- a/drivers/usb/dwc2/Kconfig > +++ b/drivers/usb/dwc2/Kconfig > @@ -1,5 +1,5 @@ > config US

RE: [PATCH v2 16/16] usb: dwc3: enable usb suspend phy

2014-10-20 Thread Paul Zimmerman
> From: Huang Rui [mailto:ray.hu...@amd.com] > Sent: Monday, October 20, 2014 2:01 AM > > On Mon, Oct 20, 2014 at 04:41:54PM +0800, Huang Rui wrote: > > On Fri, Oct 17, 2014 at 01:48:19PM -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Fri, Oct

RE: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-17 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, October 17, 2014 11:52 AM > > On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote: > > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > > Sent: Thursday, October 16, 2014 9:44 PM >

RE: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement

2014-10-17 Thread Paul Zimmerman
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > Sent: Thursday, October 16, 2014 9:44 PM > > modified the function to have a single return statement at the end > instead of multiple return statement in the middle of the function > to improve the readability of the code. > > This pat

RE: [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-17 Thread Paul Zimmerman
t; } > > /* for non control endpoints, set PID to D0 */ > @@ -2579,6 +2581,7 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, > /* enable the endpoint interrupt */ > s3c_hsotg_ctrl_epint(hsotg, index, dir_in, 1); > > +error: > spin_unlock_irqres

RE: [PATCH v2 16/16] usb: dwc3: enable usb suspend phy

2014-10-17 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, October 17, 2014 8:00 AM > > On Fri, Oct 17, 2014 at 04:53:41PM +0800, Huang Rui wrote: > > AMD NL needs to suspend usb3 ss phy, but this doesn't enable on simulation > > board. > > > > Signed-off-by: Huang Rui > > --- > > drivers/usb/dw

RE: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement

2014-10-17 Thread Paul Zimmerman
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > Sent: Friday, October 17, 2014 3:03 AM > > On Fri, Oct 17, 2014 at 09:02:00AM +, David Laight wrote: > > From: Of Sudip Mukherjee > > > modified the function to have a single return statement at the end > > > instead of multiple ret

RE: [PATCH v2 2/2] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-16 Thread Paul Zimmerman
; The sparse warning was fixed by releasing the spinlock before return. > > > > > > This patch depends on the previous patch of the series. > > > > > > Signed-off-by: Sudip Mukherjee > > > > this should be patch one so it can be backported to stable kern

RE: [PATCH] usb: dwc2: gadget: sparse warning of context imbalance

2014-10-14 Thread Paul Zimmerman
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > Sent: Friday, October 10, 2014 6:10 AM > > sparse was giving the following warning: > warning: context imbalance in 's3c_hsotg_ep_enable' > - different lock contexts for basic block > > we were returning ENOMEM while still

RE: [PATCH v3 0/6] usb: hub: convert khubd into workqueue

2014-09-20 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alan Stern > Sent: Friday, September 19, 2014 12:39 PM > > On Fri, 19 Sep 2014, Petr Mladek wrote: > > > The 3rd version of the patchset is slightly reordered and refactored > > as suggested earlier.

[PATCH] usb: dwc2: add T: line to MAINTAINERS showing Felipe's tree

2014-09-19 Thread Paul Zimmerman
Starting with v3.18-rc, patches for dwc2 will go through Felipe's tree. Add a T: line to MAINTAINERS to document this. Signed-off-by: Paul Zimmerman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 809ecd6..bffd59c 100644 --- a/MAINTA

Take dwc2 driver through Felipe's tree?

2014-09-19 Thread Paul Zimmerman
Hi Greg, How would you feel about Felipe taking the dwc2 driver into his tree? There has been quite a bit of increased activity with dwc2 lately, and I know you already have more than enough stuff on your plate already. So this would mean one less thing for you to worry about. Plus it would mean a

RE: [PATCHv4 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-09-19 Thread Paul Zimmerman
> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Friday, September 19, 2014 7:50 AM > > Unfortunately after second look there are even more problems with Kconfig > changes, please see below. > > > > > > >> if USB_DWC2 > > >> > > >> +choice > > >> +bool "DWC2 Mo

RE: [PATCHv4 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-09-18 Thread Paul Zimmerman
> From: Dinh Nguyen [mailto:dingu...@opensource.altera.com] > Sent: Thursday, September 18, 2014 8:54 AM > > On 09/12/2014 10:49 AM, Bartlomiej Zolnierkiewicz wrote: > > > > [ added linux-kernel ML to cc: ] > > > > Hi, > > > > On Tuesday, August 26, 2014 11:19:52 AM dingu...@opensource.altera.com

RE: [PATCH 0/2] usb: dwc2: Revert patches causing problems

2014-09-11 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Paul Zimmerman > Sent: Thursday, September 11, 2014 1:10 PM > > > From: Paul Zimmerman > > Sent: Thursday, September 11, 2014 12:11 PM > > > > > From: Rober

RE: [PATCH 0/2] usb: dwc2: Revert patches causing problems

2014-09-11 Thread Paul Zimmerman
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Thursday, September 11, 2014 1:20 PM > > On Thu, Sep 11, 2014 at 07:11:20PM +, Paul Zimmerman wrote: > > > From: Robert Baldyga [mailto:r.bald...@samsung.com] > > > Sent: Thursd

RE: [PATCH 0/2] usb: dwc2: Revert patches causing problems

2014-09-11 Thread Paul Zimmerman
> From: Paul Zimmerman > Sent: Thursday, September 11, 2014 12:11 PM > > > From: Robert Baldyga [mailto:r.bald...@samsung.com] > > Sent: Thursday, September 11, 2014 5:53 AM > > > > These two patches breaks dwc2 driver. The first one causes build break, > &

RE: [PATCH 0/2] usb: dwc2: Revert patches causing problems

2014-09-11 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Thursday, September 11, 2014 5:53 AM > > These two patches breaks dwc2 driver. The first one causes build break, > the second breaks gadget at Samsung platforms. > > Best regards > Robert Baldyga > > Robert Baldyga (2): > Revert "us

RE: [PATCH RESEND v3 00/12] usb: dwc2/gadget: fix series

2014-08-19 Thread Paul Zimmerman
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, August 19, 2014 9:16 AM > > On Tue, Aug 19, 2014 at 03:46:58PM +, Paul Zimmerman wrote: > > > From: Robert Baldyga [mailto:r.bald...@samsung.com] > > > Sent: Tuesday, August 1

RE: [PATCH RESEND v3 00/12] usb: dwc2/gadget: fix series

2014-08-19 Thread Paul Zimmerman
a (3): > usb: dwc2/gadget: assign TX FIFO dynamically > usb: dwc2/gadget: disable clock when it's not needed > usb: dwc2/gadget: avoid disabling ep0 > > drivers/usb/dwc2/core.h | 3 + > drivers/usb/dwc2/gadget.c | 184 > +++--

RE: [PATCH RFC] usb: gadget: dwc2: make driver run on a version 3.10a instance of DWC_OTG

2014-08-13 Thread Paul Zimmerman
> From: Neil Armstrong [mailto:narmstr...@neotion.com] > Sent: Wednesday, August 13, 2014 5:17 AM > > We are trying to make a driver run on our PCD only instance of Synopsys > DWC_OTG IP with the following parameters : > - Dedicated Fifos : Yes > - Descriptor DMA : Yes > - PHY : 8bit UTMI+ (may ne

RE: [PATCH] usb: dwc2: Read GNPTXFSIZ when in forced HOST mode.

2014-08-07 Thread Paul Zimmerman
> From: diand...@google.com [mailto:diand...@google.com] On Behalf Of Doug > Anderson > Sent: Thursday, August 07, 2014 5:12 PM > > On Thu, Aug 7, 2014 at 1:18 PM, Paul Zimmerman > wrote: > >> From: Doug Anderson [mailto:diand...@chromium.org] > >> Sent

RE: [PATCH v4 2/4] usb: dwc2: add compatible data for rockchip soc

2014-08-07 Thread Paul Zimmerman
> From: diand...@google.com [mailto:diand...@google.com] On Behalf Of Doug > Anderson > Sent: Thursday, August 07, 2014 1:53 PM > > On Thu, Aug 7, 2014 at 11:26 AM, Paul Zimmerman > wrote: > >> From: Kever Yang [mailto:kever.y...@gmail.com] On Behalf Of Kever Yang >

RE: [PATCH] usb: dwc2: Read GNPTXFSIZ when in forced HOST mode.

2014-08-07 Thread Paul Zimmerman
gt; + gnptxfsiz = readl(hsotg->regs + GNPTXFSIZ); > hptxfsiz = readl(hsotg->regs + HPTXFSIZ); > + dev_dbg(hsotg->dev, "gnptxfsiz=%08x\n", gnptxfsiz); > dev_dbg(hsotg->dev, "hptxfsiz=%08x\n", hptxfsiz); > gusbcfg = readl(hsotg->regs

RE: [PATCH v4 2/4] usb: dwc2: add compatible data for rockchip soc

2014-08-07 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@gmail.com] On Behalf Of Kever Yang > Sent: Thursday, August 07, 2014 2:35 AM > > This patch add compatible data for dwc2 controller found on > rk3066, rk3188 and rk3288 processors from rockchip. > > Signed-off-by: Kever Yang >

RE: [PATCH v4 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

2014-08-06 Thread Paul Zimmerman
ole and host role. Some boards always want to use host mode > > and some other boards want to use gadget mode. We use the dts setting > > to set dwc2's mode, rather than fixing it to whatever hardware says. > > > > Signed-off-by: Kever Yang > > Acked-by: Pau

RE: [PATCH v3 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

2014-08-05 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@rock-chips.com] > Sent: Monday, August 04, 2014 6:46 PM > > On 08/05/2014 12:34 AM, Doug Anderson wrote: > > > Normally I'd say that you should have added Paul's "Acked-by" since > > you fixed his nit and he told you to include his Acked-by when his nit > > w

RE: Kernel Debugging Support

2014-08-04 Thread Paul Zimmerman
> From: Nick Krause [mailto:xerofo...@gmail.com] > Sent: Monday, August 04, 2014 3:50 PM > > On Mon, Aug 4, 2014 at 5:55 PM, Paul Zimmerman > wrote: > >> From: valdis.kletni...@vt.edu [mailto:valdis.kletni...@vt.edu] > >> Sent: Monday, August 04, 2014 1:28 PM &g

RE: Kernel Debugging Support

2014-08-04 Thread Paul Zimmerman
> From: valdis.kletni...@vt.edu [mailto:valdis.kletni...@vt.edu] > Sent: Monday, August 04, 2014 1:28 PM > > On Mon, 04 Aug 2014 19:40:15 -, Paul Zimmerman said: > > > Ah, you didn't read far enough down the page :) > > I'm willing to bet a large piz

RE: [PATCH v3 00/12] usb: dwc2/gadget: fix series

2014-08-04 Thread Paul Zimmerman
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Monday, August 04, 2014 12:11 PM > > On Mon, Aug 04, 2014 at 06:58:23PM +, Paul Zimmerman wrote: > > > From: Paul Zimmerman > > > Sent: Friday, July 18, 2014 12:19 PM >

RE: Kernel Debugging Support

2014-08-04 Thread Paul Zimmerman
> From: valdis.kletni...@vt.edu [mailto:valdis.kletni...@vt.edu] > Sent: Monday, August 04, 2014 12:23 PM > > On Mon, 04 Aug 2014 19:07:53 -, Paul Zimmerman said: > > > Are you sure about that? Last I heard, xHCI debug support was a logo > > requirement from Micros

RE: Kernel Debugging Support

2014-08-04 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Sarah Sharp > Sent: Monday, August 04, 2014 9:47 AM > > Please Cc the new xHCI driver maintainer, Mathias Nyman. I'm officially > retired from USB development and have moved onto other projects. :) >

RE: [PATCH v3 00/12] usb: dwc2/gadget: fix series

2014-08-04 Thread Paul Zimmerman
> From: Paul Zimmerman > Sent: Friday, July 18, 2014 12:19 PM > > > From: Robert Baldyga [mailto:r.bald...@samsung.com] > > Sent: Friday, July 18, 2014 4:39 AM > > > > This patchset contains fixes for dwc2 gadget driver. It touches PHY, > > FIFO configur

RE: [PATCH v2 2/2] usb: dwc2: add dr_mode support for dwc2

2014-07-31 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@rock-chips.com] > Sent: Wednesday, July 30, 2014 6:06 PM > > Some devices with A female host port and without use of usb_id pin > will need this for the otg controller works as device role > during firmware period and works as host role in rich os. > > Signed

RE: [PATCH v2 2/4] usb: dwc2: add compatible data for rockchip soc

2014-07-31 Thread Paul Zimmerman
m_device *dev) > > static const struct of_device_id dwc2_of_match_table[] = { > { .compatible = "brcm,bcm2835-usb", .data = ¶ms_bcm2835 }, > + { .compatible = "rockchip,rk3066-usb", .data = ¶ms_rk3066 }, > { .compatible = "snps,dwc2", .data = NUL

RE: [PATCH 4/4] usb: dwc2: add dr_mode support for dwc2

2014-07-30 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@rock-chips.com] > Sent: Tuesday, July 29, 2014 6:35 PM > > Some devices with A female host port and without use of usb_id pin > will need this for the otg controller works as device role > during firmware period and works as host role in rich os. > > Signed-o

RE: [PATCH 3/4] usb: dwc2: add compatible data for rockchip soc

2014-07-30 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@rock-chips.com] > Sent: Tuesday, July 29, 2014 6:35 PM > > This patch add compatible data for dwc2 controller found on > rk3066, rk3188 and rk3288 processors from rockchip. > > Signed-off-by: Kever Yang > --- > drivers/usb/dwc2/platform.c | 29 +++

RE: [PATCH 1/4] Documentation: dt-bindings: add dt binding info for Rockchip dwc2

2014-07-30 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@rock-chips.com] > Sent: Tuesday, July 29, 2014 6:31 PM > > This add necessary dwc2 binding documentation for Rockchip socs: > rk3066, rk3188 and rk3288 > > add dr_mode as optional properties. > > Signed-off-by: Kever Yang > --- > Documentation/devicetree/b

RE: [PATCH v3 00/12] usb: dwc2/gadget: fix series

2014-07-18 Thread Paul Zimmerman
dwc2/gadget.c | 184 > +++--- > 2 files changed, 111 insertions(+), 76 deletions(-) For the entire series: Acked-by: Paul Zimmerman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [PATCH] usb: xhci: Fix Set TR Dequeue Pointer cycle state for quirky xHCs

2014-07-17 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Maciej Puzio > Sent: Thursday, July 17, 2014 11:25 AM > > Tested-by: Maciej Puzio > > On Tue, Jul 8, 2014 at 2:01 PM, Julius Werner wrote: > > Commit 1f81b6d22 "usb: xhci: Prefer endpoint context de

RE: [PATCH v2 00/12] usb: dwc2/gadget: fix series

2014-07-16 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Wednesday, July 16, 2014 3:22 AM > > This patchset contains fixes for dwc2 gadget driver. It touches PHY, > FIFO configuration, initialization sequence and adds many other small fixes. > > Best regards > Robert Baldyga > Samsung R&D In

RE: [PATCH v2 10/12] usb: dwc2/gadget: assign TX FIFO dynamically

2014-07-16 Thread Paul Zimmerman
rnel.org] On Behalf Of Paul Zimmerman > Sent: Wednesday, July 16, 2014 12:58 PM > > > From: Robert Baldyga [mailto:r.bald...@samsung.com] > > Sent: Wednesday, July 16, 2014 3:22 AM > > > > Because we have not enough memory to have each TX FIFO of size at least 3072 >

RE: [PATCH v2 10/12] usb: dwc2/gadget: assign TX FIFO dynamically

2014-07-16 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Wednesday, July 16, 2014 3:22 AM > > Because we have not enough memory to have each TX FIFO of size at least 3072 > bytes (the maximum single packet size), we create four FIFOs of lenght 1024, > and four of length 3072 bytes, and assing

RE: [PATCH] usb: dwc2: remove incomplete DMA support from gadget code

2014-07-08 Thread Paul Zimmerman
> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnier...@samsung.com] > Sent: Tuesday, July 08, 2014 7:55 AM > > The commit 5b7d70c6dbf2 ("USB: Gadget driver for Samsung HS/OtG > block") which added this driver also introduced the inactive DMA > support (due to hardware limitations of DMA buffers al

RE: [PATCH 00/11] usb: dwc2/gadget: fix series

2014-06-23 Thread Paul Zimmerman
, I have a couple of questions/suggestions on patches #6 and #10. Other than that, for the entire series, Acked-by: Paul Zimmerman I think we should also have Felipe's ACK for the parts that concern the PHY framework and the gadget API. -- Paul -- To unsubscribe from this list: send the line &qu

RE: [PATCH 10/11] usb: dwc2/gadget: assign TX FIFO dynamically

2014-06-23 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Monday, June 23, 2014 12:51 AM > > Because we have not enough memory to have each TX FIFO of size at least 3072 > bytes (the maximum single packet size), we create four FIFOs of lenght 1024, > and four of length 3072 bytes, and assing t

RE: [PATCH 06/11] usb: dwc2/gadget: ensure that all fifos have correct memory buffers

2014-06-23 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Monday, June 23, 2014 12:51 AM > > From: Marek Szyprowski > > Print warning if FIFOs are configured in such a way that they don't fit > into the SPRAM available on the s3c hsotg module. > > Signed-off-by: Marek Szyprowski > Signed-o

RE: [PATCH -next 24/26] usb: Use dma_zalloc_coherent

2014-06-16 Thread Paul Zimmerman
> From: Joe Perches [mailto:j...@perches.com] > Sent: Sunday, June 15, 2014 1:38 PM > > Use the zeroing function instead of dma_alloc_coherent & memset(,0,) > > Signed-off-by: Joe Perches > --- > drivers/usb/dwc2/hcd_ddma.c | 20 +++- > drivers/usb/host/uhci-hcd.c | 7 +++ >

RE: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-04 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alan Stern > Sent: Wednesday, June 04, 2014 6:57 AM > > On Wed, 4 Jun 2014, Yang,Wei wrote: > > > On 06/04/2014 09:45 AM, Peter Chen wrote: > > > > > >> commit d18f7116a5ddb8263fe62b05ad63e5ceb5875791

RE: [PATCH] usb: dwc3: Keeping 'resource' related code together

2014-06-03 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Vivek Gautam > Sent: Tuesday, June 03, 2014 3:40 AM > > Putting together the code related to getting the 'IORESOURCE_MEM' > and assigning the same to dwc->xhci_resources, for increasing > the readabili

FWD:

2014-05-22 Thread paul-zimmerman
Hey! http://emkainsaat.com.tr/_redirect?ohaduwjgisuh20600214 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.

RE: [PATCH] DWC2: intializes the spin_lock earlier in the probe

2014-05-22 Thread Paul Zimmerman
> From: Jean-Jacques Hiblot [mailto:jjhib...@traphandler.com] > Sent: Thursday, May 22, 2014 5:10 AM > > The spinlock hsotg->lock is intialized at the end of the probe. However it > may be used from within dwc2_hcd_init(). This patch moves the > initialization before the call to dwc2_hcd_init(). T

  1   2   >