Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2016-01-06 Thread Paul.Thacker
On 01/05/2016 03:50 PM, One Thousand Gnomes wrote: > >> +#define PIC32_SDEV_NAME "ttyS" >> +#define PIC32_SDEV_MAJORTTY_MAJOR >> +#define PIC32_SDEV_MINOR64 > > No. Same goes for you as every one of the forty other people a year who > try and claim their console is ttyS. If it's

Re: [PATCH v2 10/14] serial: pic32_uart: Add PIC32 UART driver

2016-01-05 Thread Paul.Thacker
On 12/20/2015 09:14 AM, Andy Shevchenko wrote: > On Tue, Dec 15, 2015 at 12:42 AM, Joshua Henderson > wrote: >> From: Andrei Pistirica >> >> This adds UART and a serial console driver for Microchip PIC32 class >> devices. >> >> Signed-off-by: Andrei Pistirica >> Signed-off-by: Joshua Henderson

RE: [PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

2015-12-17 Thread Paul.Thacker
On 12/16/2015 3:48 AM, Ulf Hansson wrote: > > [...] > > > +static int pic32_sdhci_probe(struct platform_device *pdev) { > > + struct device *dev = &pdev->dev; > > + struct sdhci_host *host; > > + struct resource *iomem; > > + struct pic32_sdhci_pdata *sdhci_pdata; > > +

RE: [PATCH v2 12/14] mmc: sdhci-pic32: Add PIC32 SDHCI host controller driver

2015-12-16 Thread Paul.Thacker
On 12/14/2015 5:33 PM, Andy Green wrote: > Hi... looks good, just some small general comments. > > On 15 December 2015 at 06:42, Joshua Henderson > wrote: > > From: Andrei Pistirica > > > > This driver supports the SDHCI host controller found on a PIC32. > > > > Signed-off-by: Andrei Pistirica

RE: [PATCH 11/14] mmc: sdhci-pic32: Add PIC32 SDHC host controller driver

2015-11-29 Thread Paul.Thacker
On 11/25/2015 8:55 AM, Ulf Hansson wrote: > On 21 November 2015 at 01:17, Joshua Henderson > wrote: > > From: Andrei Pistirica > > > > This driver supports the SDHCI host controller found on the PIC32 in > > DMA or PIO mode. > > > > Signed-off-by: Andrei Pistirica > > Signed-off-by: Joshua Hende