them up and
include
into my set.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger
actually doesn't need it. I could do some
blind modifications, but cannot test them, and this is out of my scope at all.
As mentioned in the commit msg, i need only 0003 and 0004 from there. Can they
be picked up independently? They don't need 0002 by
themselves, only 0005 needs it.
Kind regards
ng to chip datasheet i have. They are
actually chip-specific, but i wrote them in board
file because on different boards you may use different banks, and therefore
different pins. Or, if you don't use SROMc at all, you
can configure all pins to do something else.
Kind regards,
Pavel Fedin
Expert
Implement handling properties in subnodes and adding child devices to the
system. Child devices will not be added if configuration fails.
Since the driver now does more than suspend-resume support, dependency on
CONFIG_PM is removed.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
ar
The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO
initialization is required.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 +++
arch/arm/boot/dts/exynos5410.dtsi | 6 +
2
Add documentation for new subnode properties, allowing bank configuration.
Based on u-boot implementation, but heavily reworked.
Also, fix size of SROMc mapping in the example.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
.../bindings/arm/samsung/exynos-srom.txt
}
> +
> + return ret;
> +}
Factoring out this loop is unnecessary, because i could just 'return 0' in the
loop
instead of 'error = true'. Byt my idea is to go through all banks anyway, just
in
case, to diagnose all of them. So that the user will be able to spot and fix all
broke
> Although this is different board, but okay.
I am curious too, so i examined SMSC datasheet. The IRQ is fully programmable
on
chip's side too, and our driver indeed defaults to active-low. You can switch it
to active-high by addint smsc,irq-active-high property. But i just copied
settings from
and child devices will not be probed.
- These additional properties now have "samsung,srom-XXX" format
- Fixed code style, now better understood.
v2 => v3:
- Fixed up SROMc region size in the device tree
- Reordered patches, documentation goes first now
v1 => v2:
- Fixed some typos and bad labels
This machine uses own SoC device tree file, add missing part.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
arch/arm/boot/dts/exynos5410.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5410.dtsi
b/arch/arm/boot/dts/exynos5410.dtsi
index 4
This machine uses own SoC device tree file, add missing part.
We insert the complete description, with ranges, because we are going to
connect devices to it. Values in ranges are SoC-specific, so they go here
in order not to duplicate them for every machine.
Signed-off-by: Pavel Fedin
---
arch
d.
- These additional properties now have "samsung,srom-XXX" format
- Fixed code style, now better understood.
v2 => v3:
- Fixed up SROMc region size in the device tree
- Reordered patches, documentation goes first now
v1 => v2:
- Fixed some typos and bad labels in
Implement handling properties in subnodes and adding child devices to the
system. Child devices will not be added if configuration fails.
Since the driver now does more than suspend-resume support, dependency on
CONFIG_PM is removed.
Signed-off-by: Pavel Fedin
---
arch/arm/mach-exynos/Kconfig
Add documentation for new subnode properties, allowing bank configuration.
Based on u-boot implementation, but heavily reworked.
Signed-off-by: Pavel Fedin
---
.../bindings/arm/samsung/exynos-srom.txt | 68 +-
1 file changed, 66 insertions(+), 2 deletions(-)
diff
The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO
initialization is required.
Signed-off-by: Pavel Fedin
---
arch/arm/boot/dts/exynos5410-smdk5410.dts | 40 +++
1 file changed, 40 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5410
Implement handling properties in subnodes and adding child devices to the
system. Child devices will not be added if configuration fails.
Since the driver now does more than suspend-resume support, dependency on
CONFIG_PM is removed.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
ar
Add documentation for new subnode properties, allowing bank configuration.
Based on u-boot implementation, but heavily reworked.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
.../bindings/arm/samsung/exynos-srom.txt | 68 +-
1 file changed, 66 inse
This machine uses own SoC device tree file, add missing part.
We insert the complete description, with ranges, because we are going to
connect devices to it. Values in ranges are SoC-specific, so they go here
in order not to duplicate them for every machine.
Signed-off-by: Pavel Fedin <p
The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO
initialization is required.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
arch/arm/boot/dts/exynos5410-smdk5410.dts | 40 +++
1 file changed, 40 insertions(+)
diff --git a/arch/ar
d.
- These additional properties now have "samsung,srom-XXX" format
- Fixed code style, now better understood.
v2 => v3:
- Fixed up SROMc region size in the device tree
- Reordered patches, documentation goes first now
v1 => v2:
- Fixed some typos and bad labels in
rst, but it didn't work, and ranges translation
> > gave me something really weird (like addr = 0x80 and
> > size = 0x0404).
>
> Did you change the address-cells to <1>?
Of course i did.
I don't quote the rest because i simply agree to what you've said. Will respi
rst, but it didn't work, and ranges translation
> > gave me something really weird (like addr = 0x80 and
> > size = 0x0404).
>
> Did you change the address-cells to <1>?
Of course i did.
I don't quote the rest because i simply agree to what you've said. Will respi
I know, sorry, this is MS Outlook (not Express), and it's impossible
to configure it this way (if i just set up word wrap, it starts to
corrupt patches). I am now trying to wrap the text by hands, i hope
it's better. And i cannot use anything else because... You know why. :)
Kind regards,
Pav
t; the chip should have been already set up. In order to be able to function
> > during probe, it is changed to use PMT_CTRL register.
> >
> > The problem could be observed on SMDK5410 board.
> >
> > Signed-off-by: Pavel Fedin
>
> I'm pretty sure this is going
t; the chip should have been already set up. In order to be able to function
> > during probe, it is changed to use PMT_CTRL register.
> >
> > The problem could be observed on SMDK5410 board.
> >
> > Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
>
> I'm
I know, sorry, this is MS Outlook (not Express), and it's impossible
to configure it this way (if i just set up word wrap, it starts to
corrupt patches). I am now trying to wrap the text by hands, i hope
it's better. And i cannot use anything else because... You know why. :)
Kind regards,
Pav
a bus-specific extra. It's similar to "reg" property having
different meanings for different buses.
> Probably you can check suggestions from Krzysztof, where he pointed out
> some hint on how other places this is getting used.
Did you read them? I did, and they do exactly th
that i
essentially copy some information from it into Linux doc. Is
it okay to do this?
If you still dislike the array, i'll redo is a set of properties like
samsung,srom-tacs, samsung,srom-tcos, etc.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
to function
during probe, it is changed to use PMT_CTRL register.
The problem could be observed on SMDK5410 board.
Signed-off-by: Pavel Fedin
---
drivers/net/ethernet/smsc/smsc911x.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/smsc
change binding of "smsc,lan9115"
> which is already documented here [1]. These samsung specific srom
> properties should be in srom node or its subnode, but not in this way.
So, if you look at gpmc-eth.txt, you'll see that this approach is perfectly
valid (this is a repl
g here, I am not able to find V4 1/4 and 3/4 in this mailing
> list.
Which mailing list is "this"? I've just rechecked, i've got my messages back
on both (linux-samsung-soc and linux-arm-kernel).
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
Hello!
> -Original Message-
> From: linux-samsung-soc-ow...@vger.kernel.org
> [mailto:linux-samsung-soc-ow...@vger.kernel.org]
> On Behalf Of Pankaj Dubey
> Sent: Thursday, October 29, 2015 8:28 PM
> To: Pavel Fedin
> Cc: devicet...@vger.kernel.org; linux-arm-ker..
g here, I am not able to find V4 1/4 and 3/4 in this mailing
> list.
Which mailing list is "this"? I've just rechecked, i've got my messages back
on both (linux-samsung-soc and linux-arm-kernel).
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
Hello!
> -Original Message-
> From: linux-samsung-soc-ow...@vger.kernel.org
> [mailto:linux-samsung-soc-ow...@vger.kernel.org]
> On Behalf Of Pankaj Dubey
> Sent: Thursday, October 29, 2015 8:28 PM
> To: Pavel Fedin
> Cc: devicet...@vger.kernel.org; linux-arm-ker..
change binding of "smsc,lan9115"
> which is already documented here [1]. These samsung specific srom
> properties should be in srom node or its subnode, but not in this way.
So, if you look at gpmc-eth.txt, you'll see that this approach is perfectly
valid (this is a repl
to function
during probe, it is changed to use PMT_CTRL register.
The problem could be observed on SMDK5410 board.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drive
that i
essentially copy some information from it into Linux doc. Is
it okay to do this?
If you still dislike the array, i'll redo is a set of properties like
samsung,srom-tacs, samsung,srom-tcos, etc.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
a bus-specific extra. It's similar to "reg" property having
different meanings for different buses.
> Probably you can check suggestions from Krzysztof, where he pointed out
> some hint on how other places this is getting used.
Did you read them? I did, and they do exactly th
The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO
initialization is required.
Signed-off-by: Pavel Fedin
---
arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 +++
1 file changed, 41 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5410
Add documentation for new subnode properties, allowing bank configuration.
Based on u-boot implementation, but heavily reworked.
Signed-off-by: Pavel Fedin
---
.../bindings/arm/samsung/exynos-srom.txt | 50 +-
1 file changed, 48 insertions(+), 2 deletions(-)
diff
Implement handling properties in subnodes and adding child devices to the
system. Child devices will not be added if configuration fails.
Since the driver now does more than suspend-resume support, dependency on
CONFIG_PM is removed.
Signed-off-by: Pavel Fedin
---
arch/arm/mach-exynos/Kconfig
ave "samsung,srom-XXX" format
- Fixed code style, now better understood.
v2 => v3:
- Fixed up SROMc region size in the device tree
- Reordered patches, documentation goes first now
v1 => v2:
- Fixed some typos and bad labels in device tree
- Improved documentation
Pavel Fedin (4):
This machine uses own SoC device tree file, add missing part.
Signed-off-by: Pavel Fedin
---
arch/arm/boot/dts/exynos5410.dtsi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5410.dtsi
b/arch/arm/boot/dts/exynos5410.dtsi
index 4603356..da6a8fa0e
This machine uses own SoC device tree file, add missing part.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
arch/arm/boot/dts/exynos5410.dtsi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5410.dtsi
b/arch/arm/boot/dts/exynos5410.dtsi
Add documentation for new subnode properties, allowing bank configuration.
Based on u-boot implementation, but heavily reworked.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
.../bindings/arm/samsung/exynos-srom.txt | 50 +-
1 file changed, 48 inse
The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO
initialization is required.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 +++
1 file changed, 41 insertions(+)
diff --git a/arch/ar
Implement handling properties in subnodes and adding child devices to the
system. Child devices will not be added if configuration fails.
Since the driver now does more than suspend-resume support, dependency on
CONFIG_PM is removed.
Signed-off-by: Pavel Fedin <p.fe...@samsung.com>
---
ar
ave "samsung,srom-XXX" format
- Fixed code style, now better understood.
v2 => v3:
- Fixed up SROMc region size in the device tree
- Reordered patches, documentation goes first now
v1 => v2:
- Fixed some typos and bad labels in device tree
- Improved documentation
Pavel Fedin (4):
Hello!
> You may need to fetch again?
> Anyway the branch is v4.4-next/driver-samsung or tags/samsung-driver...
> Or just for-next should be fine I think.
Thank you very much, already found it, and even posted my series, you should
have already seen it.
Kind regards,
Pavel Fed
Hello!
> You may need to fetch again?
> Anyway the branch is v4.4-next/driver-samsung or tags/samsung-driver...
> Or just for-next should be fine I think.
Thank you very much, already found it, and even posted my series, you should
have already seen it.
Kind regards,
Pavel Fed
Hello!
> Applied, this whole series.
Where can i find the recent code to base my series on? I looked at
linux-samsung.git but was unable to find it there.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the l
Hello!
> Applied, this whole series.
Where can i find the recent code to base my series on? I looked at
linux-samsung.git but was unable to find it there.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the l
5410. By the way, what is current status? If this is final
revision, can i post my Ethernet support patchset on top
of it?
Tested-by: Pavel Fedin
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "
5410. By the way, what is current status? If this is final
revision, can i post my Ethernet support patchset on top
of it?
Tested-by: Pavel Fedin <p.fe...@samsung.com>
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list:
Hello!
> can we add the "depends on ... && PM" now, later, once
> you'll extend it, you remove it again?
Yes, you can. However, i think i'll post my patches as soon as the code gets
integrated into some repository, before it even goes
to the RC. So, it's up to you.
K
Hello!
> can we add the "depends on ... && PM" now, later, once
> you'll extend it, you remove it again?
Yes, you can. However, i think i'll post my patches as soon as the code gets
integrated into some repository, before it even goes
to the RC. So, it's up to you.
K
30862.html.
Patch 0003 has been acked-by, and nothing more since
that.
Actually, only 0002 and 0003 of this series are needed for the pin controller.
0001 has been accepted
(27284129522e7e2a5b89e80bd44ea3345f79c9e8).
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Rese
d be "proper" for
> the time being (which could mean !PM dependency). If there is a need,
> then the dependency will be removed.
I can do it later if you prefer.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send
d be "proper" for
> the time being (which could mean !PM dependency). If there is a need,
> then the dependency will be removed.
I can do it later if you prefer.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send
30862.html.
Patch 0003 has been acked-by, and nothing more since
that.
Actually, only 0002 and 0003 of this series are needed for the pin controller.
0001 has been accepted
(27284129522e7e2a5b89e80bd44ea3345f79c9e8).
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Rese
mall problem with their code. "bank" parameter is
device-wide, therefore you
cannot configure more than one bank. For SMDK boards it's OK, but in future you
may run into problem
with this.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To uns
ommentations?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
mall problem with their code. "bank" parameter is
device-wide, therefore you
cannot configure more than one bank. For SMDK boards it's OK, but in future you
may run into problem
with this.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To uns
ommentations?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
Hello!
> From: Pavel Fedin
>
> After GICv2m was enabled for 32-bit ARM kernel, a warning popped up:
Thank you for the cooperation, i'm now back from my vacation.
What about the first patch in the series, which actually enables GICv2m on 32
bits? I don't see it anywhere
Hello!
> From: Pavel Fedin <p.fe...@samsung.com>
>
> After GICv2m was enabled for 32-bit ARM kernel, a warning popped up:
Thank you for the cooperation, i'm now back from my vacation.
What about the first patch in the series, which actually enables GICv2m on 32
bits? I don't
Commit-ID: 157add60cb35913b8a848a3d7e6456b8ed134796
Gitweb: http://git.kernel.org/tip/157add60cb35913b8a848a3d7e6456b8ed134796
Author: Pavel Fedin
AuthorDate: Sun, 13 Sep 2015 12:14:33 +0100
Committer: Thomas Gleixner
CommitDate: Tue, 15 Sep 2015 17:06:29 +0200
irqchip/GICv2m: Fix
Commit-ID: 157add60cb35913b8a848a3d7e6456b8ed134796
Gitweb: http://git.kernel.org/tip/157add60cb35913b8a848a3d7e6456b8ed134796
Author: Pavel Fedin <p.fe...@samsung.com>
AuthorDate: Sun, 13 Sep 2015 12:14:33 +0100
Committer: Thomas Gleixner <t...@linutronix.de>
CommitDate:
tract the proper
> information from the device tree. We are going to piggyback on that for
> the next versions of the patch.
Where can i take a look at the code?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: sen
the device tree. We are going to piggyback on that for
the next versions of the patch.
Where can i take a look at the code?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
034..18e3757 100644
> --- a/include/linux/irqchip/arm-gic-v3.h
> +++ b/include/linux/irqchip/arm-gic-v3.h
> @@ -389,6 +389,8 @@ int its_cpu_init(void);
> int its_init(struct device_node *node, struct rdists *rdists,
>struct irq_domain *domain);
>
> +typedef u32 (*its_
, struct rdists *rdists,
struct irq_domain *domain);
+typedef u32 (*its_pci_requester_id_t)(struct pci_dev *, u16);
+void set_its_pci_requester_id(its_pci_requester_id_t fn);
#endif
#endif
--
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
Tested-by: Pavel Fedin
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
> -Original Message-
> From: Eric Auger [mailto:eric.au...@linaro.org]
> Sent: Monday, August 03, 2015 6:31 PM
> To: eric.au...@st.com; eric.au...@linaro.org;
>
Tested-by: Pavel Fedin p.fe...@samsung.com
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
-Original Message-
From: Eric Auger [mailto:eric.au...@linaro.org]
Sent: Monday, August 03, 2015 6:31 PM
To: eric.au...@st.com; eric.au...@linaro.org
ich
> returns -EINVAL atm. So I plan to introduce this capability already with
> the ITS emulation series, so we can just pick it up in the IRQ routing
> series.
Then may be you follow https://lkml.org/lkml/2015/7/7/115 and replace flag
with something like
KVM_SIGNAL_EXT_MSI ioctl ? After all
Certain platforms (e. g. BSD-based ones) define some ELF constants according
to host.
This patch fixes problems with cross-building Linux kernel on these platforms
(e. g. building ARM
32-bit version on x86-64 host).
Signed-off-by: Pavel Fedin
---
If you are not fond of mentioning Cygwin
t away
completely and invent
KVM_SIGNAL_EXT_MSI ioctl for sending MSIs with device ID. This would also be
consistent IMO.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&q
use
KVM_SIGNAL_MSI already uses them
in absolutely the same manner. That's my point and nothing more.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
point and nothing more.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
completely and invent
KVM_SIGNAL_EXT_MSI ioctl for sending MSIs with device ID. This would also be
consistent IMO.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Certain platforms (e. g. BSD-based ones) define some ELF constants according
to host.
This patch fixes problems with cross-building Linux kernel on these platforms
(e. g. building ARM
32-bit version on x86-64 host).
Signed-off-by: Pavel Fedin p.fe...@samsung.com
---
If you are not fond
series, so we can just pick it up in the IRQ routing
series.
Then may be you follow https://lkml.org/lkml/2015/7/7/115 and replace flag
with something like
KVM_SIGNAL_EXT_MSI ioctl ? After all you were one of people who voted against
using flags.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung
> Just so I'm sure I understand: The way the kernel differentiates between
> no-devid and devid==0, is whether or not the devid flag is set, correct?
Yes, exactly.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list
true;
kvm_msi_via_irqfd_allowed = true;
}
--- cut ---
I can post my sets as RFCs to qemu mailing list, if you want to take a look at
the whole change
set.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: se
ed qemu now has kvm_msi_flags global variable which
defaults to 0. ITS
code, then, if activated, changes it to KVM_MSI_VALID_DEVID, and qemu starts
supplying device IDs to
the related calls.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe
as RFCs to qemu mailing list, if you want to take a look at
the whole change
set.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
Just so I'm sure I understand: The way the kernel differentiates between
no-devid and devid==0, is whether or not the devid flag is set, correct?
Yes, exactly.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send
kvm_msi_flags global variable which
defaults to 0. ITS
code, then, if activated, changes it to KVM_MSI_VALID_DEVID, and qemu starts
supplying device IDs to
the related calls.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send
Hi!
> OK so both of you say the same thing. Will respin accordingly
You may also want to add this:
Tested-by: Pavel Fedin
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line "unsubscribe linu
Hi!
OK so both of you say the same thing. Will respin accordingly
You may also want to add this:
Tested-by: Pavel Fedin p.fe...@samsung.com
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe from this list: send the line unsubscribe linux
Hello!
> OK thanks for sharing. I need some more time to study qemu code too.
I am currently working on supporting this in qemu. Not ready yet, need some
time. But, with API i
suggest, things are really much-much simpler.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Resea
keep using the type for homogeneity.
Homogeneity is perfect IMHO.
If that would be simpler for you, i could post a patch for this which i made
on top of your series.
Sorry, i don't have time to respin the whole thing, busy with qemu GICv3 fight
:)
Kind regards,
Pavel Fedin
Expert Engineer
Samsun
else
schedule_work(>inject);
--- cut ---
You apparently missed KVM_IRQ_ROUTING_EXTENDED_MSI here, as well as in
irqfd_update(). But, if you
accept my API proposal, this becomes irrelevant.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
change i suggest (using KVM_MSI_VALID_DEVID flag), we could get rid
of all these if()'s
here. Just forward all parameters to vGIC implementation code and let it do its
checks.
> default:
> return -EINVAL;
> }
> --
> 1.9.1
>
> --
> To unsubscribe
ruct kvm_irq_routing_msi msi;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Kind regards,
Pavel Fedin
Expe
;
struct kvm_irq_routing_msi msi;
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research
:
return -EINVAL;
}
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics
schedule_work(irqfd-inject);
--- cut ---
You apparently missed KVM_IRQ_ROUTING_EXTENDED_MSI here, as well as in
irqfd_update(). But, if you
accept my API proposal, this becomes irrelevant.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
--
To unsubscribe
is perfect IMHO.
If that would be simpler for you, i could post a patch for this which i made
on top of your series.
Sorry, i don't have time to respin the whole thing, busy with qemu GICv3 fight
:)
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
Hello!
OK thanks for sharing. I need some more time to study qemu code too.
I am currently working on supporting this in qemu. Not ready yet, need some
time. But, with API i
suggest, things are really much-much simpler.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research
101 - 200 of 238 matches
Mail list logo
