[PATCH 4/6] staging/xgifb: Remove unused variables

2013-02-02 Thread Peter Huewe
Pindex and Pdata are unused - remove tempbx is unused - remove Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/xgifb/vb_setmode.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb

[PATCH 5/6] staging/xgifb: Remove redundant if statement

2013-02-02 Thread Peter Huewe
The code checks twice for if (pVBInfo-VBInfo SetCRT2ToTV) without any changes in between - we can remove the second check. And while at it we can also save the temp variable and use tempbx directly. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/xgifb/vb_setmode.c | 34

[PATCH] staging/comedi/adl_pci8164: Don't assign string

2013-01-28 Thread Peter Huewe
Assigning a string is really bad, and since we only have 1 char strings here we can simply use a char to store the value and change the format specifier. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/adl_pci8164.c | 28 +- 1 files changed, 14 insertions

[PATCH] staging/comedi/adl_pci8164: Don't assign string

2013-01-28 Thread Peter Huewe
Assigning a string is really bad, and since we only have 1 char strings here we can simply use a char to store the value and change the format specifier. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/adl_pci8164.c | 28 +- 1 files

[PATCH] staging/omapdrm: Use kmemdup rather than duplicating its implementation

2013-01-25 Thread Peter Huewe
Found with coccicheck. The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Peter Huewe --- drivers/staging/omapdrm/omap_gem.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/omapdrm/omap_gem.c

[PATCH] staging/media/go7007: Use kmemdup rather than duplicating its implementation

2013-01-25 Thread Peter Huewe
Found with coccicheck. The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Peter Huewe --- drivers/staging/media/go7007/go7007-driver.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media

[PATCH] staging/csr: Use kmemdup rather than duplicating its implementation

2013-01-25 Thread Peter Huewe
Found with coccicheck. The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Peter Huewe --- drivers/staging/csr/drv.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/csr/drv.c b/drivers

[PATCH] staging/media/solo6x10: Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR

2013-01-25 Thread Peter Huewe
Found with coccicheck. The semantic patch that makes this change is available in scripts/coccinelle/api/ptr_ret.cocci. Signed-off-by: Peter Huewe --- drivers/staging/media/solo6x10/v4l2.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media

[PATCH] staging/media/solo6x10: Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR

2013-01-25 Thread Peter Huewe
Found with coccicheck. The semantic patch that makes this change is available in scripts/coccinelle/api/ptr_ret.cocci. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/media/solo6x10/v4l2.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH] staging/csr: Use kmemdup rather than duplicating its implementation

2013-01-25 Thread Peter Huewe
Found with coccicheck. The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/csr/drv.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/csr/drv.c

[PATCH] staging/media/go7007: Use kmemdup rather than duplicating its implementation

2013-01-25 Thread Peter Huewe
Found with coccicheck. The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/media/go7007/go7007-driver.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] staging/omapdrm: Use kmemdup rather than duplicating its implementation

2013-01-25 Thread Peter Huewe
Found with coccicheck. The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/omapdrm/omap_gem.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging

Re: [PATCH] staging/comedi: Move comedi_pci_auto_unconfig to drivers.c

2013-01-24 Thread Peter Huewe
Am Donnerstag, 24. Januar 2013, 11:02:35 schrieb Ian Abbott: > On 2013-01-22 23:03, Peter Huewe wrote: > > Since comedi_pci_auto_unconfig cannot be inlined anymore after > > > > staging/comedi: Use comedi_pci_auto_unconfig directly for > > pci_driver.remove > >

Re: [PATCH] staging/comedi: Move comedi_pci_auto_unconfig to drivers.c

2013-01-24 Thread Peter Huewe
Am Donnerstag, 24. Januar 2013, 11:02:35 schrieb Ian Abbott: On 2013-01-22 23:03, Peter Huewe wrote: Since comedi_pci_auto_unconfig cannot be inlined anymore after staging/comedi: Use comedi_pci_auto_unconfig directly for pci_driver.remove is applied, it makes sense to move

[PATCH] staging/comedi: Move comedi_pci_auto_unconfig to drivers.c

2013-01-22 Thread Peter Huewe
Since comedi_pci_auto_unconfig cannot be inlined anymore after staging/comedi: Use comedi_pci_auto_unconfig directly for pci_driver.remove is applied, it makes sense to move it drivers.c Signed-off-by: Peter Huewe --- drivers/staging/comedi/comedidev.h |5 + drivers/staging/comedi

[PATCH] staging/comedi: Use comedi_pci_auto_unconfig directly for pci_driver.remove

2013-01-22 Thread Peter Huewe
ate code and saves some bytes. Signed-off-by: Peter Huewe --- Maybe we should move the implementation now to drivers.c, because now it cannot be inlined anymore. This would save some more bytes in the .kos but comedi_pci_auto_unconfig then has to become an exported symbol. drivers/staging/com

[PATCH] staging/comedi: use comedi_usb_driver_(un)register for init/deinit

2013-01-22 Thread Peter Huewe
Instead of coding calling comedi_driver_(un)register and usb_(de)register directly we can use the comedi_usb_driver_(un)register wrapper. This removes some boilerplate and is less error prone. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/dt9812.c | 25

[PATCH] staging/comedi: use comedi_usb_driver_(un)register for init/deinit

2013-01-22 Thread Peter Huewe
Instead of coding calling comedi_driver_(un)register and usb_(de)register directly we can use the comedi_usb_driver_(un)register wrapper. This removes some boilerplate and is less error prone. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/dt9812.c | 25

[PATCH] staging/comedi: Use comedi_pci_auto_unconfig directly for pci_driver.remove

2013-01-22 Thread Peter Huewe
code and saves some bytes. Signed-off-by: Peter Huewe peterhu...@gmx.de --- Maybe we should move the implementation now to drivers.c, because now it cannot be inlined anymore. This would save some more bytes in the .kos but comedi_pci_auto_unconfig then has to become an exported symbol. drivers

[PATCH] staging/comedi: Move comedi_pci_auto_unconfig to drivers.c

2013-01-22 Thread Peter Huewe
Since comedi_pci_auto_unconfig cannot be inlined anymore after staging/comedi: Use comedi_pci_auto_unconfig directly for pci_driver.remove is applied, it makes sense to move it drivers.c Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/comedidev.h |5 + drivers

[PATCH v2] staging/comedi: Add pci_driver.name to skel driver

2013-01-21 Thread Peter Huewe
This patch adds the comedi_driver.name to pci_driver.name to the skel driver, so we can remove the workaround in drivers.c Signed-off-by: Peter Huewe --- missed a comma, sorry drivers/staging/comedi/drivers/skel.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCH] staging/iio: Use correct argument for sizeof

2013-01-21 Thread Peter Huewe
-by: Peter Huewe --- drivers/staging/iio/iio_hwmon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/iio/iio_hwmon.c b/drivers/staging/iio/iio_hwmon.c index c7a5f97..97ad645 100644 --- a/drivers/staging/iio/iio_hwmon.c +++ b/drivers/staging/iio/iio_hwmon.c

[PATCH 1/2] staging/comedi: Add pci_driver.name to skel driver

2013-01-21 Thread Peter Huewe
This patch adds the comedi_driver.name to pci_driver.name to the skel driver, so we can remove the workaround in drivers.c Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/skel.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 2/2] staging/comedi: remove workaround for !pci_driver.name

2013-01-21 Thread Peter Huewe
All pci drivers in drivers/ have the pci_driver.name field set, so we can remove this workaround and the accompanying todo. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi

[PATCH] staging/comedi: Use bool initializations

2013-01-21 Thread Peter Huewe
Found with coccicheck. The semantic patch that makes this output is available in scripts/coccinelle/misc/boolinit.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Peter Huewe --- drivers/staging/comedi/comedi_fops.c |4 ++-- 1 files

[PATCH] staging/comedi: Use bool initializations

2013-01-21 Thread Peter Huewe
Found with coccicheck. The semantic patch that makes this output is available in scripts/coccinelle/misc/boolinit.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/comedi_fops.c

[PATCH 1/2] staging/comedi: Add pci_driver.name to skel driver

2013-01-21 Thread Peter Huewe
This patch adds the comedi_driver.name to pci_driver.name to the skel driver, so we can remove the workaround in drivers.c Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/skel.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCH 2/2] staging/comedi: remove workaround for !pci_driver.name

2013-01-21 Thread Peter Huewe
All pci drivers in drivers/ have the pci_driver.name field set, so we can remove this workaround and the accompanying todo. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH] staging/iio: Use correct argument for sizeof

2013-01-21 Thread Peter Huewe
-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/iio/iio_hwmon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/iio/iio_hwmon.c b/drivers/staging/iio/iio_hwmon.c index c7a5f97..97ad645 100644 --- a/drivers/staging/iio/iio_hwmon.c +++ b/drivers/staging

[PATCH v2] staging/comedi: Add pci_driver.name to skel driver

2013-01-21 Thread Peter Huewe
This patch adds the comedi_driver.name to pci_driver.name to the skel driver, so we can remove the workaround in drivers.c Signed-off-by: Peter Huewe peterhu...@gmx.de --- missed a comma, sorry drivers/staging/comedi/drivers/skel.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

[PATCH 2/8] staging/comedi/ni_daq_dio24: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 29 + 1 files changed, 1 insertions(+), 28 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 4/8] staging/comedi/quatech_daqp_cs: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Also removed the superflous #ifdef MODULE Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 18 +- 1 files changed, 1 insertions(+), 17 deletions

[PATCH 6/8] staging/comedi/das08_cs: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/das08_cs.c | 26 +- 1 files changed, 1 insertions(+), 25 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 8/8] staging/comedi/ni_labpc_cs: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/ni_labpc_cs.c | 31 +- 1 files changed, 1 insertions(+), 30 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 5/8] staging/comedi/cb_das16_cs: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/cb_das16_cs.c | 25 + 1 files changed, 1 insertions(+), 24 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 7/8] staging/comedi/ni_daq_700: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/ni_daq_700.c | 25 + 1 files changed, 1 insertions(+), 24 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 1/8 v2] staging/comedi: Add macro for registering a comedi PCMCIA driver

2013-01-14 Thread Peter Huewe
This patch introduces a new macro 'module_comedi_pcmcia_driver' for comedi PCMCIA drivers which do not do anything special in module init/exit. This eliminates a lot of boilerplate. Adapted from 'module_comedi_pci_driver' Signed-off-by: Peter Huewe --- v2: Removed unnecessary stuff. Thanks

[PATCH 3/8] staging/comedi/ni_mio_cs: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Also removed the superflous #ifdef MODULE Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/ni_mio_cs.c | 20 +--- 1 files changed, 1 insertions(+), 19 deletions

[PATCH 1/8 v2] staging/comedi: Add macro for registering a comedi PCMCIA driver

2013-01-14 Thread Peter Huewe
This patch introduces a new macro 'module_comedi_pcmcia_driver' for comedi PCMCIA drivers which do not do anything special in module init/exit. This eliminates a lot of boilerplate. Adapted from 'module_comedi_pci_driver' Signed-off-by: Peter Huewe peterhu...@gmx.de --- v2: Removed unnecessary

[PATCH 3/8] staging/comedi/ni_mio_cs: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Also removed the superflous #ifdef MODULE Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/ni_mio_cs.c | 20 +--- 1 files changed, 1 insertions

[PATCH 5/8] staging/comedi/cb_das16_cs: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/cb_das16_cs.c | 25 + 1 files changed, 1 insertions(+), 24 deletions(-) diff --git

[PATCH 7/8] staging/comedi/ni_daq_700: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/ni_daq_700.c | 25 + 1 files changed, 1 insertions(+), 24 deletions(-) diff --git a/drivers

[PATCH 8/8] staging/comedi/ni_labpc_cs: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/ni_labpc_cs.c | 31 +- 1 files changed, 1 insertions(+), 30 deletions(-) diff --git

[PATCH 6/8] staging/comedi/das08_cs: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/das08_cs.c | 26 +- 1 files changed, 1 insertions(+), 25 deletions(-) diff --git a/drivers

[PATCH 4/8] staging/comedi/quatech_daqp_cs: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Also removed the superflous #ifdef MODULE Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 18 +- 1 files changed, 1 insertions

[PATCH 2/8] staging/comedi/ni_daq_dio24: Convert to module_comedi_pcmcia_driver

2013-01-14 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 29 + 1 files changed, 1 insertions(+), 28 deletions(-) diff --git

[PATCH 6/8] staging/comedi/das08_cs: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/das08_cs.c | 26 +- 1 files changed, 1 insertions(+), 25 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 5/8] staging/comedi/cb_das16_cs: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/cb_das16_cs.c | 25 + 1 files changed, 1 insertions(+), 24 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 7/8] staging/comedi/ni_daq_700: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/ni_daq_700.c | 25 + 1 files changed, 1 insertions(+), 24 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 8/8] staging/comedi/ni_labpc_cs: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/ni_labpc_cs.c | 31 +- 1 files changed, 1 insertions(+), 30 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 3/8] staging/comedi/ni_mio_cs: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Also removed the superflous #ifdef MODULE Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/ni_mio_cs.c | 20 +--- 1 files changed, 1 insertions(+), 19 deletions

[PATCH 4/8] staging/comedi/quatech_daqp_cs: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Also removed the superflous #ifdef MODULE Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 18 +- 1 files changed, 1 insertions(+), 17 deletions

[PATCH 2/8] staging/comedi/ni_daq_dio24: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 29 + 1 files changed, 1 insertions(+), 28 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 1/8] staging/comedi: Add macro for registering a comedi PCMCIA driver

2013-01-12 Thread Peter Huewe
This patch introduces a new macro 'module_comedi_pcmcia_driver' for comedi PCMCIA drivers which do not do anything special in module init/exit. This eliminates a lot of boilerplate. Adapted from 'module_comedi_pci_driver' Signed-off-by: Peter Huewe --- drivers/staging/comedi/comedidev.h | 22

[PATCH 1/8] staging/comedi: Add macro for registering a comedi PCMCIA driver

2013-01-12 Thread Peter Huewe
This patch introduces a new macro 'module_comedi_pcmcia_driver' for comedi PCMCIA drivers which do not do anything special in module init/exit. This eliminates a lot of boilerplate. Adapted from 'module_comedi_pci_driver' Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi

[PATCH 2/8] staging/comedi/ni_daq_dio24: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 29 + 1 files changed, 1 insertions(+), 28 deletions(-) diff --git

[PATCH 3/8] staging/comedi/ni_mio_cs: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Also removed the superflous #ifdef MODULE Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/ni_mio_cs.c | 20 +--- 1 files changed, 1 insertions

[PATCH 4/8] staging/comedi/quatech_daqp_cs: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Also removed the superflous #ifdef MODULE Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/quatech_daqp_cs.c | 18 +- 1 files changed, 1 insertions

[PATCH 7/8] staging/comedi/ni_daq_700: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/ni_daq_700.c | 25 + 1 files changed, 1 insertions(+), 24 deletions(-) diff --git a/drivers

[PATCH 8/8] staging/comedi/ni_labpc_cs: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/ni_labpc_cs.c | 31 +- 1 files changed, 1 insertions(+), 30 deletions(-) diff --git

[PATCH 5/8] staging/comedi/cb_das16_cs: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/cb_das16_cs.c | 25 + 1 files changed, 1 insertions(+), 24 deletions(-) diff --git

[PATCH 6/8] staging/comedi/das08_cs: Convert to module_comedi_pcmcia_driver

2013-01-12 Thread Peter Huewe
This patch removes the boring init/exit functions with the new module_comedi_pcmcia_driver macro. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/staging/comedi/drivers/das08_cs.c | 26 +- 1 files changed, 1 insertions(+), 25 deletions(-) diff --git a/drivers

[PATCH] staging/csr: Fix dereference before check

2013-01-07 Thread Peter Huewe
'priv' (see line 2474) drivers/staging/csr/sme_sys.c:3045 CsrWifiRouterCtrlWapiRxPktReqHandler() warn: variable dereferenced before check 'priv' (see line 3039) We put the check before the dereferencing and prevent an oops and fix the warning. Signed-off-by: Peter Huewe --- drivers/staging/csr

[PATCH] staging/csr: Fix dereference before check

2013-01-07 Thread Peter Huewe
'priv' (see line 2474) drivers/staging/csr/sme_sys.c:3045 CsrWifiRouterCtrlWapiRxPktReqHandler() warn: variable dereferenced before check 'priv' (see line 3039) We put the check before the dereferencing and prevent an oops and fix the warning. Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers

[PATCH] fs/autofs: Fix sparse warning: context imbalance in 'autofs4_d_automount' - different lock contexts for basic block

2013-01-03 Thread Peter Huewe
with the (>fs_lock) held if sbi->version <= 4 and simple_empty(dentry) == false so the warning seems valid. --> Add an spin_unlock in this case before we jump to done Unfortunately compile tested only. Reported-by: Fengguang Wu Signed-off-by: Peter Huewe --- fs/autofs4/root.c |4 +

[PATCH net-next/master] ethernet/broadcom/tg3: Fix sparse warning: constant 0x7fffffffffffffff is so big it is long long

2013-01-03 Thread Peter Huewe
Sparse complains that: drivers/net/ethernet/broadcom/tg3.c:5670:55: sparse: constant 0x7fff is so big it is long long (on x86/32 bit) so we suffix the constant with LL in the header file. Reported-by: Fengguang Wu Signed-off-by: Peter Huewe --- drivers/net/ethernet/broadcom/tg3.h

[PATCH net-next/master] ethernet/broadcom/tg3: Fix sparse warning: constant 0x7fffffffffffffff is so big it is long long

2013-01-03 Thread Peter Huewe
Sparse complains that: drivers/net/ethernet/broadcom/tg3.c:5670:55: sparse: constant 0x7fff is so big it is long long (on x86/32 bit) so we suffix the constant with LL in the header file. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Peter Huewe peterhu...@gmx.de

[PATCH] fs/autofs: Fix sparse warning: context imbalance in 'autofs4_d_automount' - different lock contexts for basic block

2013-01-03 Thread Peter Huewe
with the (sbi-fs_lock) held if sbi-version = 4 and simple_empty(dentry) == false so the warning seems valid. -- Add an spin_unlock in this case before we jump to done Unfortunately compile tested only. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Peter Huewe peterhu...@gmx.de --- fs

[PATCH] char/tpm: Use struct dev_pm_ops for power management

2012-12-05 Thread Peter Huewe
This patch converts the suspend and resume functions for tpm_i2c_stm_st33 to the new dev_pm_ops. Signed-off-by: Peter Huewe --- Note: I'm sending this patch on behalf of myself only and nobody else, especially not my employer - and I'm doing this in my spare time. I have to inform you that I'm

[PATCH] char/tpm: Use struct dev_pm_ops for power management

2012-12-05 Thread Peter Huewe
This patch converts the suspend and resume functions for tpm_i2c_stm_st33 to the new dev_pm_ops. Signed-off-by: Peter Huewe peterhu...@gmx.de --- Note: I'm sending this patch on behalf of myself only and nobody else, especially not my employer - and I'm doing this in my spare time. I have

[PATCH v3] char/tpm: Use true and false for bools

2012-11-29 Thread Peter Huewe
patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Peter Huewe --- v3 for this tiny patch... shame on me. drivers/char/tpm/tpm_tis.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index 6bdf267

[PATCH v3] char/tpm: Use true and false for bools

2012-11-29 Thread Peter Huewe
patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Peter Huewe peterhu...@gmx.de --- v3 for this tiny patch... shame on me. drivers/char/tpm/tpm_tis.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm

Re: [PATCH] char/tpm: Use true and false for bools

2012-11-28 Thread Peter Huewe
Am Donnerstag, 29. November 2012, 01:25:19 schrieb Al Viro: > On Thu, Nov 29, 2012 at 01:20:37AM +0100, Peter Huewe wrote: > > - itpm = (probe == 0) ? 0 : 1; > > + itpm = (probe == 0) ? false : true; > > Charming. Not that original had been better, bu

[PATCH v2] char/tpm: Use true and false for bools

2012-11-28 Thread Peter Huewe
patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Peter Huewe --- v2: Removed/changed that silly itpm = (probe == 0) ? 0 : 1; since probe is here either 0 or 1 -- thanks Al for noticing. This section and the probing of the itpm can probably be improved anyway, but I'll wrap

[PATCH] char/tpm: Use true and false for bools

2012-11-28 Thread Peter Huewe
patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Peter Huewe --- drivers/char/tpm/tpm_tis.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index 6bdf267..70d4ea5 100644 --- a/drivers/char/tpm

[PATCH] char/tpm: Use true and false for bools

2012-11-28 Thread Peter Huewe
patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/char/tpm/tpm_tis.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index 6bdf267..70d4ea5 100644

[PATCH v2] char/tpm: Use true and false for bools

2012-11-28 Thread Peter Huewe
patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Peter Huewe peterhu...@gmx.de --- v2: Removed/changed that silly itpm = (probe == 0) ? 0 : 1; since probe is here either 0 or 1 -- thanks Al for noticing. This section and the probing of the itpm can probably be improved anyway, but I'll

Re: [PATCH] char/tpm: Use true and false for bools

2012-11-28 Thread Peter Huewe
Am Donnerstag, 29. November 2012, 01:25:19 schrieb Al Viro: On Thu, Nov 29, 2012 at 01:20:37AM +0100, Peter Huewe wrote: - itpm = (probe == 0) ? 0 : 1; + itpm = (probe == 0) ? false : true; Charming. Not that original had been better, but... Yeah. Sorry it's late

Re: [PATCH] TPM: Switch to __packed instead of __attribute__((packed))

2012-11-22 Thread Peter Huewe
Am Mittwoch, 21. November 2012, 21:56:45 schrieb Jason Gunthorpe: > This seems to be preferred these days. > > Signed-off-by: Jason Gunthorpe Looks good to me Reviewed-by: Peter Huewe Thanks, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH] TPM: Switch to __packed instead of __attribute__((packed))

2012-11-22 Thread Peter Huewe
Am Mittwoch, 21. November 2012, 21:56:45 schrieb Jason Gunthorpe: This seems to be preferred these days. Signed-off-by: Jason Gunthorpe jguntho...@obsidianresearch.com Looks good to me Reviewed-by: Peter Huewe peterhu...@gmx.de Thanks, Peter -- To unsubscribe from this list: send the line

[PATCH v2] char/tpm: simplify duration calculation and eliminate smatch warning.

2012-11-15 Thread Peter Huewe
/tpm.c:360 tpm_calc_ordinal_duration() error: buffer overflow 'tpm_protected_ordinal_duration' 12 <= 243 Signed-off-by: Peter Huewe --- v2: Smatch not sparse and TSC instead of TCS ;) drivers/char/tpm/tpm.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --

[PATCH v2] char/tpm: simplify duration calculation and eliminate smatch warning.

2012-11-15 Thread Peter Huewe
/tpm.c:360 tpm_calc_ordinal_duration() error: buffer overflow 'tpm_protected_ordinal_duration' 12 = 243 Signed-off-by: Peter Huewe peterhu...@gmx.de --- v2: Smatch not sparse and TSC instead of TCS ;) drivers/char/tpm/tpm.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions

[PATCH 2/2] char/tpm: simplify duration calculation and eliminate sparse warning.

2012-11-12 Thread Peter Huewe
/tpm.c:360 tpm_calc_ordinal_duration() error: buffer overflow 'tpm_protected_ordinal_duration' 12 <= 243 Signed-off-by: Peter Huewe --- drivers/char/tpm/tpm.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c in

[PATCH 1/2] char/tpm: Remove duplicated lookup table

2012-11-12 Thread Peter Huewe
The entries in tpm_protected_ordinal_duration are exactly the same as the first 12 in tpm_ordinal_duration, so we can simply remove this one, and save some bytes. This does not change the behavior of the driver. Signed-off-by: Peter Huewe --- This patch reflects only my opinion and work

[PATCH 1/2] char/tpm: Remove duplicated lookup table

2012-11-12 Thread Peter Huewe
The entries in tpm_protected_ordinal_duration are exactly the same as the first 12 in tpm_ordinal_duration, so we can simply remove this one, and save some bytes. This does not change the behavior of the driver. Signed-off-by: Peter Huewe peterhu...@gmx.de --- This patch reflects only my opinion

[PATCH 2/2] char/tpm: simplify duration calculation and eliminate sparse warning.

2012-11-12 Thread Peter Huewe
/tpm.c:360 tpm_calc_ordinal_duration() error: buffer overflow 'tpm_protected_ordinal_duration' 12 = 243 Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/char/tpm/tpm.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/char/tpm/tpm.c b/drivers/char

[tip:perf/core] perf/x86: Fix sparse warnings

2012-10-30 Thread tip-bot for Peter Huewe
Commit-ID: 95d18aa2b6c05351181934b3bc34ce038cc7b637 Gitweb: http://git.kernel.org/tip/95d18aa2b6c05351181934b3bc34ce038cc7b637 Author: Peter Huewe AuthorDate: Mon, 29 Oct 2012 21:48:17 +0100 Committer: Ingo Molnar CommitDate: Tue, 30 Oct 2012 10:10:52 +0100 perf/x86: Fix sparse

[tip:perf/core] perf/x86: Fix sparse warnings

2012-10-30 Thread tip-bot for Peter Huewe
Commit-ID: 95d18aa2b6c05351181934b3bc34ce038cc7b637 Gitweb: http://git.kernel.org/tip/95d18aa2b6c05351181934b3bc34ce038cc7b637 Author: Peter Huewe peterhu...@gmx.de AuthorDate: Mon, 29 Oct 2012 21:48:17 +0100 Committer: Ingo Molnar mi...@kernel.org CommitDate: Tue, 30 Oct 2012 10:10:52

[PATCH] net/phy/bcm87xx: Add MODULE_LICENSE("GPL") to GPL driver

2012-09-21 Thread Peter Huewe
and conditions of the GNU General * Public License. See the file "COPYING" in the main directory of this * archive for more details. I think it's safe to add the MODULE_LICENSE("GPL") macro and thus remove the kernel taint. Cc: sta...@vger.kernel.org Signed-off-by: Peter Huewe

[PATCH 2/2] extcon: unregister compat link on cleanup

2012-09-21 Thread Peter Huewe
Since extcon registers this compat link at device registration (extcon_dev_register), we should probably remove them at deregistration/cleanup. Cc: sta...@vger.kernel.org Signed-off-by: Peter Huewe --- drivers/extcon/extcon_class.c |5 + 1 files changed, 5 insertions(+), 0 deletions

[PATCH 1/2] extcon: Unregister compat class at module unload to fix oops

2012-09-21 Thread Peter Huewe
0 9f451e58: [<6007e3c3>] sys_init_module+0xa3/0x280 9f451e88: [<6001e2ad>] handle_syscall+0x8d/0x90 9f451ea8: [<60033370>] userspace+0x405/0x531 9f451ee8: [<6001e380>] copy_chunk_to_user+0x0/0x40 9f451ef8: [<6001e5cd>] do_op_one_page+0x14d/0x220 9f451fd8: [<60

[PATCH 1/2] extcon: Unregister compat class at module unload to fix oops

2012-09-21 Thread Peter Huewe
fixes this. Cc: sta...@vger.kernel.org Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/extcon/extcon_class.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/extcon/extcon_class.c b/drivers/extcon/extcon_class.c index f6419f9..6e914d0 100644

[PATCH 2/2] extcon: unregister compat link on cleanup

2012-09-21 Thread Peter Huewe
Since extcon registers this compat link at device registration (extcon_dev_register), we should probably remove them at deregistration/cleanup. Cc: sta...@vger.kernel.org Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/extcon/extcon_class.c |5 + 1 files changed, 5 insertions

[PATCH] net/phy/bcm87xx: Add MODULE_LICENSE(GPL) to GPL driver

2012-09-21 Thread Peter Huewe
and conditions of the GNU General * Public License. See the file COPYING in the main directory of this * archive for more details. I think it's safe to add the MODULE_LICENSE(GPL) macro and thus remove the kernel taint. Cc: sta...@vger.kernel.org Signed-off-by: Peter Huewe peterhu...@gmx.de

[PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency

2012-09-14 Thread Peter Huewe
dependency and prevents the driver from being build on platforms with no HAS_IOMEM Signed-off-by: Peter Huewe --- drivers/mtd/nand/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 8ca4176..3e2f75d 100644

[PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency

2012-09-14 Thread Peter Huewe
dependency and prevents the driver from being build on platforms with no HAS_IOMEM Signed-off-by: Peter Huewe peterhu...@gmx.de --- drivers/mtd/nand/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 8ca4176

[PATCH] char/tpm: Add new driver for Infineon I2C TIS TPM

2012-08-07 Thread Peter Huewe
ication_tis_version_12/ [2] http://trousers.sourceforge.net/ [3] http://sourceforge.net/projects/trousers/files/TSS%20API%20test%20suite/0.3/ Signed-off-by: Peter Huewe --- Full patch, against 3.6-rc1 Sorry for the inconvenience. I did remove the signed-off-by, acked-by and reviewed-by tags as this i

[PATCH] char/tpm: Add new driver for Infineon I2C TIS TPM

2012-08-07 Thread Peter Huewe
://trousers.sourceforge.net/ [3] http://sourceforge.net/projects/trousers/files/TSS%20API%20test%20suite/0.3/ Signed-off-by: Peter Huewe peter.hu...@infineon.com --- Full patch, against 3.6-rc1 Sorry for the inconvenience. I did remove the signed-off-by, acked-by and reviewed-by tags as this is a new

[PATCH] char/tpm: Use struct dev_pm_ops for power management.

2012-08-06 Thread Peter Huewe
callback routines. Signed-off-by: Peter Huewe --- Thanks Kent and Rafael - much better this way ;) drivers/char/tpm/tpm_i2c_infineon.c | 30 +- 1 files changed, 1 insertions(+), 29 deletions(-) diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm

[PATCH] char/tpm: Use struct dev_pm_ops for power management.

2012-08-06 Thread Peter Huewe
callback routines. Signed-off-by: Peter Huewe peter.hu...@infineon.com --- Thanks Kent and Rafael - much better this way ;) drivers/char/tpm/tpm_i2c_infineon.c | 30 +- 1 files changed, 1 insertions(+), 29 deletions(-) diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b

<    2   3   4   5   6   7   8   >