Re: [PATCH v4 0/8] ARM: davinci: complete the conversion to using the reset framework

On Tue, 2018-03-27 at 11:39 +0530, Sekhar Nori wrote: > Hi Bart, > > On Friday 23 March 2018 10:46 PM, Bartosz Golaszewski wrote: > > 2018-03-23 18:08 GMT+01:00 Stephen Boyd : > > > Quoting Bartosz Golaszewski (2018-03-23 09:55:47) > > > > 2018-03-23 17:49 GMT+01:00 Stephen Boyd

Re: [PATCH v4 0/8] ARM: davinci: complete the conversion to using the reset framework

On Tue, 2018-03-27 at 11:39 +0530, Sekhar Nori wrote: > Hi Bart, > > On Friday 23 March 2018 10:46 PM, Bartosz Golaszewski wrote: > > 2018-03-23 18:08 GMT+01:00 Stephen Boyd : > > > Quoting Bartosz Golaszewski (2018-03-23 09:55:47) > > > > 2018-03-23 17:49 GMT+01:00 Stephen Boyd : > > > > >

Re: [RFC 2/2] reset: reset-zynqmp: Adding support for Xilinx zynqmp reset controller.

Hi, On Sun, 2018-03-25 at 00:41 +0530, chinnikishore...@gmail.com wrote: > From: Nava kishore Manne > > Add a reset controller driver for Xilinx Zynq UltraScale+ MPSoC. > The zynqmp reset-controller has the ability to reset lines > connected to different blocks and peripheral

Re: [RFC 2/2] reset: reset-zynqmp: Adding support for Xilinx zynqmp reset controller.

Hi, On Sun, 2018-03-25 at 00:41 +0530, chinnikishore...@gmail.com wrote: > From: Nava kishore Manne > > Add a reset controller driver for Xilinx Zynq UltraScale+ MPSoC. > The zynqmp reset-controller has the ability to reset lines > connected to different blocks and peripheral in the Soc. > >

Re: [PATCH v4 1/8] reset: modify the way reset lookup works for board files

On Fri, 2018-03-23 at 14:04 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Commit 7af1bb19f1d7 ("reset: add support for non-DT systems") > introduced reset control lookup mechanism for boards that still use > board files. > > The routine used to

Re: [PATCH v4 1/8] reset: modify the way reset lookup works for board files

On Fri, 2018-03-23 at 14:04 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Commit 7af1bb19f1d7 ("reset: add support for non-DT systems") > introduced reset control lookup mechanism for boards that still use > board files. > > The routine used to register lookup entries takes

Re: [PATCH v3 1/8] reset: modify the way reset lookup works for board files

Hi Bartosz, On Fri, 2018-03-23 at 12:47 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Commit 7af1bb19f1d7 ("reset: add support for non-DT systems") > introduced reset control lookup mechanism for boards that still use > board files. > > The

Re: [PATCH v3 1/8] reset: modify the way reset lookup works for board files

Hi Bartosz, On Fri, 2018-03-23 at 12:47 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Commit 7af1bb19f1d7 ("reset: add support for non-DT systems") > introduced reset control lookup mechanism for boards that still use > board files. > > The routine used to register lookup

Re: [PATCH v2 1/8] reset: modify the way reset lookup works for board files

On Fri, 2018-03-23 at 11:46 +0100, Bartosz Golaszewski wrote: > 2018-03-23 11:24 GMT+01:00 Philipp Zabel <p.za...@pengutronix.de>: > > Hi Bartosz, > > > > On Fri, 2018-03-23 at 10:36 +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bgolasz

Re: [PATCH v2 1/8] reset: modify the way reset lookup works for board files

On Fri, 2018-03-23 at 11:46 +0100, Bartosz Golaszewski wrote: > 2018-03-23 11:24 GMT+01:00 Philipp Zabel : > > Hi Bartosz, > > > > On Fri, 2018-03-23 at 10:36 +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > Com

Re: [PATCH] reset: uniphier: add ethernet reset control support for PXs3

On Fri, 2018-03-23 at 19:16 +0900, Masahiro Yamada wrote: > 2018-03-23 14:12 GMT+09:00 Kunihiko Hayashi : > > Add reset lines for ethernet controller on PXs3 SoC. > > > > Signed-off-by: Kunihiko Hayashi > > --- > >

Re: [PATCH] reset: uniphier: add ethernet reset control support for PXs3

On Fri, 2018-03-23 at 19:16 +0900, Masahiro Yamada wrote: > 2018-03-23 14:12 GMT+09:00 Kunihiko Hayashi : > > Add reset lines for ethernet controller on PXs3 SoC. > > > > Signed-off-by: Kunihiko Hayashi > > --- > > drivers/reset/reset-uniphier.c | 2 ++ > > 1 file changed, 2 insertions(+) > >

Re: [PATCH v2 1/8] reset: modify the way reset lookup works for board files

Hi Bartosz, On Fri, 2018-03-23 at 10:36 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Commit 7af1bb19f1d7 ("reset: add support for non-DT systems") > introduced reset control lookup mechanism for boards that still use > board files. > > The

Re: [PATCH v2 1/8] reset: modify the way reset lookup works for board files

Hi Bartosz, On Fri, 2018-03-23 at 10:36 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Commit 7af1bb19f1d7 ("reset: add support for non-DT systems") > introduced reset control lookup mechanism for boards that still use > board files. > > The routine used to register lookup

Re: [PATCH v3 1/2] dt-bindings: reset: add STM32MP1 resets

Hi Gabriel, On Mon, 2018-03-19 at 08:25 +0100, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch adds the reset binding entry for STM32MP1 > > Signed-off-by: Gabriel Fernandez > Reviewed-by: Rob Herring

Re: [PATCH v3 1/2] dt-bindings: reset: add STM32MP1 resets

Hi Gabriel, On Mon, 2018-03-19 at 08:25 +0100, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch adds the reset binding entry for STM32MP1 > > Signed-off-by: Gabriel Fernandez > Reviewed-by: Rob Herring thank you, both applied to reset/next. regards Philipp

Re: [PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

Hi Gabriel, this looks mostly good to me, a few questions and comments below: On Wed, 2018-03-14 at 17:30 +0100, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > stm32mp1 RCC IP 1 has a reset SET register and a reset CLEAR register. > > Writing '0' on

Re: [PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

Hi Gabriel, this looks mostly good to me, a few questions and comments below: On Wed, 2018-03-14 at 17:30 +0100, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > stm32mp1 RCC IP 1 has a reset SET register and a reset CLEAR register. > > Writing '0' on reset SET register has no

Re: [PATCH] [v3] gpu: ipu-v3: prg: avoid possible array underflow

Hi Arnd, On Thu, 2018-03-15 at 17:19 +0100, Arnd Bergmann wrote: > gcc-8 reports that we access an array with a negative index > in an error case: > > drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable': > drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below

Re: [PATCH] [v3] gpu: ipu-v3: prg: avoid possible array underflow

Hi Arnd, On Thu, 2018-03-15 at 17:19 +0100, Arnd Bergmann wrote: > gcc-8 reports that we access an array with a negative index > in an error case: > > drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable': > drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below

Re: [PATCH 0/2] Introduce STM32MP1 Reset driver

Hi Gabriel, On Tue, 2018-03-13 at 17:34 +0100, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch-set enables the reset of STM32MP1. > It uses the reset simple driver by introducing the clear register offset > parameter. > STM32MP1 reset IP has a

Re: [PATCH 0/2] Introduce STM32MP1 Reset driver

Hi Gabriel, On Tue, 2018-03-13 at 17:34 +0100, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch-set enables the reset of STM32MP1. > It uses the reset simple driver by introducing the clear register offset > parameter. > STM32MP1 reset IP has a register to assert by

Re: [PATCH] reset: uniphier: add Pro4/Pro5/PXs2 audio systems reset control

On Thu, 2018-03-08 at 17:12 +0900, Masahiro Yamada wrote: > 2018-03-08 17:09 GMT+09:00 Katsuhiro Suzuki : > > Add reset lines for audio subsystem (AIO) on UniPhier > > Pro4/Pro5/PXs2 SoCs. > > > > Signed-off-by: Katsuhiro Suzuki > >

Re: [PATCH] reset: uniphier: add Pro4/Pro5/PXs2 audio systems reset control

On Thu, 2018-03-08 at 17:12 +0900, Masahiro Yamada wrote: > 2018-03-08 17:09 GMT+09:00 Katsuhiro Suzuki : > > Add reset lines for audio subsystem (AIO) on UniPhier > > Pro4/Pro5/PXs2 SoCs. > > > > Signed-off-by: Katsuhiro Suzuki > > --- > > > Acked-by: Masahiro Yamada Thank you, applied to

Re: [PATCH] reset: imx7: add 'depends on HAS_IOMEM' to fix unmet dependency

Hi Masahiro, On Tue, 2018-03-06 at 20:15 +0900, Masahiro Yamada wrote: > This config select's MFD_SYSCON, but does not depend on HAS_IOMEM. > > Compile testing on architecture without HAS_IOMEM causes "unmet > direct dependencies" in Kconfig phase. > > Detected by "make ARCH=score

Re: [PATCH] reset: imx7: add 'depends on HAS_IOMEM' to fix unmet dependency

Hi Masahiro, On Tue, 2018-03-06 at 20:15 +0900, Masahiro Yamada wrote: > This config select's MFD_SYSCON, but does not depend on HAS_IOMEM. > > Compile testing on architecture without HAS_IOMEM causes "unmet > direct dependencies" in Kconfig phase. > > Detected by "make ARCH=score

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

Hi Fabio, On Thu, 2018-03-01 at 13:43 -0300, Fabio Estevam wrote: > On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > > > Oh, this only works for csi ports that have pinctrl in their csi port > > node, like: > > > > _csi0 {

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

Hi Fabio, On Thu, 2018-03-01 at 13:43 -0300, Fabio Estevam wrote: > On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel wrote: > > > Oh, this only works for csi ports that have pinctrl in their csi port > > node, like: > > > > _csi0 { > > pinctrl-name

Re: [PATCH 1/6] reset: qcom: AOSS (Always on subsystem) reset controller

Hi sibis, thank you for the patch. I have a few questions and comments below. On Fri, 2018-03-02 at 14:53 +0530, sibis wrote: > Add reset controller driver for Qualcomm SDM845 SoC to > control reset signals provided by AOSS for Modem, Venus > ADSP, GPU, Camera, Wireless, Display subsystem > >

Re: [PATCH 1/6] reset: qcom: AOSS (Always on subsystem) reset controller

Hi sibis, thank you for the patch. I have a few questions and comments below. On Fri, 2018-03-02 at 14:53 +0530, sibis wrote: > Add reset controller driver for Qualcomm SDM845 SoC to > control reset signals provided by AOSS for Modem, Venus > ADSP, GPU, Camera, Wireless, Display subsystem > >

Re: [PATCH] reset: ti-rstctrl: use the reset-simple driver

Hi Tony, On Thu, 2018-03-01 at 10:14 -0800, Tony Lindgren wrote: > * Tony Lindgren <t...@atomide.com> [180116 07:03]: > > * Philipp Zabel <p.za...@pengutronix.de> [180116 09:52]: > > > Looks good to me. Can I move the compatible property when applying? > >

Re: [PATCH] reset: ti-rstctrl: use the reset-simple driver

Hi Tony, On Thu, 2018-03-01 at 10:14 -0800, Tony Lindgren wrote: > * Tony Lindgren [180116 07:03]: > > * Philipp Zabel [180116 09:52]: > > > Looks good to me. Can I move the compatible property when applying? > > > > Oops, here's a better version. I also left out

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

On Thu, 2018-03-01 at 13:02 -0300, Fabio Estevam wrote: > On Thu, Mar 1, 2018 at 1:09 AM, Gustavo A. R. Silva > wrote: > > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. > > The proper pointer to be passed as argument is pinctrl > > instead of priv->vdev. > > > >

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

On Thu, 2018-03-01 at 13:02 -0300, Fabio Estevam wrote: > On Thu, Mar 1, 2018 at 1:09 AM, Gustavo A. R. Silva > wrote: > > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. > > The proper pointer to be passed as argument is pinctrl > > instead of priv->vdev. > > > > This issue was detected

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

evice *pdev) > priv->dev->of_node = pdata->of_node; > pinctrl = devm_pinctrl_get_select_default(priv->dev); > if (IS_ERR(pinctrl)) { > - ret = PTR_ERR(priv->vdev); > + ret = PTR_ERR(pinctrl); > goto free; > } Thanks, Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

;of_node = pdata->of_node; > pinctrl = devm_pinctrl_get_select_default(priv->dev); > if (IS_ERR(pinctrl)) { > - ret = PTR_ERR(priv->vdev); > + ret = PTR_ERR(pinctrl); > goto free; > } Thanks, Acked-by: Philipp Zabel regards Philipp

Re: [PATCH v6] reset: add support for non-DT systems

On Wed, 2018-02-28 at 14:08 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The reset framework only supports device-tree. There are some platforms > however, which need to use it even in legacy, board-file based mode. > > An example of such

Re: [PATCH v6] reset: add support for non-DT systems

On Wed, 2018-02-28 at 14:08 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The reset framework only supports device-tree. There are some platforms > however, which need to use it even in legacy, board-file based mode. > > An example of such architecture is the DaVinci family

Re: [PATCH v5] reset: add support for non-DT systems

On Tue, 2018-02-27 at 19:07 +0100, Bartosz Golaszewski wrote: > 2018-02-27 17:10 GMT+01:00 Philipp Zabel <p.za...@pengutronix.de>: > > Hi Bartosz, > > > > thank you for the update. > > > > On Fri, 2018-02-23 at 12:39 +0100, Bartosz Golaszewski wrote: >

Re: [PATCH v5] reset: add support for non-DT systems

On Tue, 2018-02-27 at 19:07 +0100, Bartosz Golaszewski wrote: > 2018-02-27 17:10 GMT+01:00 Philipp Zabel : > > Hi Bartosz, > > > > thank you for the update. > > > > On Fri, 2018-02-23 at 12:39 +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Gol

Re: [PATCH v5] reset: add support for non-DT systems

Hi Bartosz, thank you for the update. On Fri, 2018-02-23 at 12:39 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The reset framework only supports device-tree. There are some platforms > however, which need to use it even in legacy, board-file

Re: [PATCH v5] reset: add support for non-DT systems

Hi Bartosz, thank you for the update. On Fri, 2018-02-23 at 12:39 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The reset framework only supports device-tree. There are some platforms > however, which need to use it even in legacy, board-file based mode. > > An example of

Re: [PATCH v8 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

On Tue, 2018-02-27 at 10:07 +0800, Yong Deng wrote: > Add binding documentation for Allwinner V3s CSI. > > Acked-by: Maxime Ripard > Acked-by: Sakari Ailus > Reviewed-by: Rob Herring > Signed-off-by: Yong Deng

Re: [PATCH v8 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

On Tue, 2018-02-27 at 10:07 +0800, Yong Deng wrote: > Add binding documentation for Allwinner V3s CSI. > > Acked-by: Maxime Ripard > Acked-by: Sakari Ailus > Reviewed-by: Rob Herring > Signed-off-by: Yong Deng > --- > .../devicetree/bindings/media/sun6i-csi.txt| 59 >

Re: [PATCH v4] reset: add support for non-DT systems

On Tue, 2018-02-20 at 10:40 -0600, David Lechner wrote: [...] > > In your case the platform code that adds the lookup may be identical to > > the code that registers the struct reset_controller_dev, but that > > doesn't have to be the case. I'm not sure how that is supposed to work > > for the phy

Re: [PATCH v4] reset: add support for non-DT systems

On Tue, 2018-02-20 at 10:40 -0600, David Lechner wrote: [...] > > In your case the platform code that adds the lookup may be identical to > > the code that registers the struct reset_controller_dev, but that > > doesn't have to be the case. I'm not sure how that is supposed to work > > for the phy

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

Hi Geert, On Thu, 2018-02-22 at 09:50 +0100, Geert Uytterhoeven wrote: [...] > > > @@ -127,8 +134,15 @@ static int vfio_platform_get_reset(struct > > > vfio_platform_device *vdev) > > > vdev->of_reset = vfio_platform_lookup_reset(vdev->compat, > > >

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

Hi Geert, On Thu, 2018-02-22 at 09:50 +0100, Geert Uytterhoeven wrote: [...] > > > @@ -127,8 +134,15 @@ static int vfio_platform_get_reset(struct > > > vfio_platform_device *vdev) > > > vdev->of_reset = vfio_platform_lookup_reset(vdev->compat, > > >

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

Hi Geert, I have a suggestion to avoid having to use the IS_ERR_OR_NULL macro, see below: On Tue, 2018-02-13 at 17:36 +0100, Geert Uytterhoeven wrote: > Vfio-platform requires reset support, provided either by ACPI, or, on DT > platforms, by a device-specific reset driver matching against the >

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

Hi Geert, I have a suggestion to avoid having to use the IS_ERR_OR_NULL macro, see below: On Tue, 2018-02-13 at 17:36 +0100, Geert Uytterhoeven wrote: > Vfio-platform requires reset support, provided either by ACPI, or, on DT > platforms, by a device-specific reset driver matching against the >

Re: [PATCH v2 0/3] reset: simple: enable for ASPEED SoCs

Hi Joel, On Tue, 2018-02-20 at 12:13 +1030, Joel Stanley wrote: > v2: Fix typos in bindings document, add Rob's ack > > This series that enables the simple reset driver for the ASPEED SoCs. Thanks, I have applied patches 1 (with fixup for a whitespace issue that git complained about) and 2 to

Re: [PATCH v2 0/3] reset: simple: enable for ASPEED SoCs

Hi Joel, On Tue, 2018-02-20 at 12:13 +1030, Joel Stanley wrote: > v2: Fix typos in bindings document, add Rob's ack > > This series that enables the simple reset driver for the ASPEED SoCs. Thanks, I have applied patches 1 (with fixup for a whitespace issue that git complained about) and 2 to

Re: [PATCH v4] reset: add support for non-DT systems

Hi Bartosz, David, On Mon, 2018-02-19 at 18:21 -0600, David Lechner wrote: > On 02/19/2018 10:58 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > The reset framework only supports device-tree. There are some platforms > > however, which need to use

Re: [PATCH v4] reset: add support for non-DT systems

Hi Bartosz, David, On Mon, 2018-02-19 at 18:21 -0600, David Lechner wrote: > On 02/19/2018 10:58 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > The reset framework only supports device-tree. There are some platforms > > however, which need to use it even in legacy,

Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

Hi Gustavo, On Wed, 2018-02-14 at 14:57 -0600, Gustavo A. R. Silva wrote: > Hi all, > > I was just wondering about the status of this patch. It is en route as commit dcd71a9292b1 ("staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR") in Hans' for-v4.17a branch:

Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

Hi Gustavo, On Wed, 2018-02-14 at 14:57 -0600, Gustavo A. R. Silva wrote: > Hi all, > > I was just wondering about the status of this patch. It is en route as commit dcd71a9292b1 ("staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR") in Hans' for-v4.17a branch:

Re: [PATCH] gpu: ipu-v3: make const arrays int_reg static, shrinks object size

Hi Colin, On Wed, 2018-02-14 at 18:45 +, Colin King wrote: > From: Colin Ian King > > Don't populate the const read-only arrays int_reg on the stack but instead > make them static. Makes the object code smaller by over 80 bytes: > > Before: >text data

Re: [PATCH] gpu: ipu-v3: make const arrays int_reg static, shrinks object size

Hi Colin, On Wed, 2018-02-14 at 18:45 +, Colin King wrote: > From: Colin Ian King > > Don't populate the const read-only arrays int_reg on the stack but instead > make them static. Makes the object code smaller by over 80 bytes: > > Before: >text data bss dec hex

Re: [PATCH] gpu: ipu-v3: prg: fix device node leak in ipu_prg_lookup_by_phandle

Hi Tobias, On Thu, 2018-02-15 at 15:35 +0100, Tobias Jordan wrote: > Before returning, call of_node_put() for the device node returned by > of_parse_phandle(). > > Fixes: ea9c260514c1 ("gpu: ipu-v3: add driver for Prefetch Resolve Gasket") > Signed-off-by: Tobias Jordan

Re: [PATCH] gpu: ipu-v3: prg: fix device node leak in ipu_prg_lookup_by_phandle

Hi Tobias, On Thu, 2018-02-15 at 15:35 +0100, Tobias Jordan wrote: > Before returning, call of_node_put() for the device node returned by > of_parse_phandle(). > > Fixes: ea9c260514c1 ("gpu: ipu-v3: add driver for Prefetch Resolve Gasket") > Signed-off-by: Tobias Jordan > --- >

Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

t; Cc: he...@sntech.de > Acked-by: Neil Armstrong <narmstr...@baylibre.com> > Signed-off-by: Jernej Skrabec <jernej.skra...@siol.net> For i.MX: Tested-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp

Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

t; Cc: he...@sntech.de > Acked-by: Neil Armstrong > Signed-off-by: Jernej Skrabec For i.MX: Tested-by: Philipp Zabel Acked-by: Philipp Zabel regards Philipp

Re: [PATCH v3] reset: add support for non-DT systems

Hi Bartosz, On Mon, 2018-02-19 at 13:34 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The reset framework only supports device-tree. There are some platforms > however, which need to use it even in legacy, board-file based mode. > > An example of

Re: [PATCH v3] reset: add support for non-DT systems

Hi Bartosz, On Mon, 2018-02-19 at 13:34 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The reset framework only supports device-tree. There are some platforms > however, which need to use it even in legacy, board-file based mode. > > An example of such architecture is the

Re: [PATCH 1/3] dt-bindings: aspeed-lpc: Add reset controller

On Mon, 2018-02-19 at 17:24 +1030, Joel Stanley wrote: > This describes the reset controller present in the LPC address space. > > Signed-off-by: Joel Stanley > --- > .../devicetree/bindings/mfd/aspeed-lpc.txt | 21 > + > 1 file changed, 21

Re: [PATCH 1/3] dt-bindings: aspeed-lpc: Add reset controller

On Mon, 2018-02-19 at 17:24 +1030, Joel Stanley wrote: > This describes the reset controller present in the LPC address space. > > Signed-off-by: Joel Stanley > --- > .../devicetree/bindings/mfd/aspeed-lpc.txt | 21 > + > 1 file changed, 21 insertions(+) > > diff

Re: [PATCH 3/3] reset: simple: Allow user selection of driver

On Mon, 2018-02-19 at 17:24 +1030, Joel Stanley wrote: > Currently this driver is only user selectable if COMPILE_TEST is turned > on. Users may wish to select (and deselect) it, so remove this > restriction. I would like to keep user visible options to a minimum unless there is a good reason.

Re: [PATCH 3/3] reset: simple: Allow user selection of driver

On Mon, 2018-02-19 at 17:24 +1030, Joel Stanley wrote: > Currently this driver is only user selectable if COMPILE_TEST is turned > on. Users may wish to select (and deselect) it, so remove this > restriction. I would like to keep user visible options to a minimum unless there is a good reason.

Re: [PATCH 0/3] reset: simple: enable for ASPEED SoCs

Hi Joel, On Mon, 2018-02-19 at 17:24 +1030, Joel Stanley wrote: > Hello Philip, > > Here is a series that enables the simple reset driver for the ASPEED > SoCs. You may recall I posted a patch back in May 2017 with a > similar idea[1]. I was happy to see that you merged a driver that solves >

Re: [PATCH 0/3] reset: simple: enable for ASPEED SoCs

Hi Joel, On Mon, 2018-02-19 at 17:24 +1030, Joel Stanley wrote: > Hello Philip, > > Here is a series that enables the simple reset driver for the ASPEED > SoCs. You may recall I posted a patch back in May 2017 with a > similar idea[1]. I was happy to see that you merged a driver that solves >

Re: [PATCH v8 0/7] TDA1997x HDMI video reciver

On Wed, 2018-02-07 at 23:19 +0100, Hans Verkuil wrote: > On 02/07/2018 11:05 PM, Tim Harvey wrote: > > On Wed, Feb 7, 2018 at 1:09 AM, Hans Verkuil wrote: > > > On 02/07/18 09:22, Hans Verkuil wrote: > > > > On 02/07/2018 12:29 AM, Tim Harvey wrote: > > > > > Media Controller

Re: [PATCH v8 0/7] TDA1997x HDMI video reciver

On Wed, 2018-02-07 at 23:19 +0100, Hans Verkuil wrote: > On 02/07/2018 11:05 PM, Tim Harvey wrote: > > On Wed, Feb 7, 2018 at 1:09 AM, Hans Verkuil wrote: > > > On 02/07/18 09:22, Hans Verkuil wrote: > > > > On 02/07/2018 12:29 AM, Tim Harvey wrote: > > > > > Media Controller ioctls: > > > > >

Re: [PATCH v3 1/7] drm/panel: simple: add support for Ampire AM-800480AYTZQW-00H

Hi Jagan, On Sun, 2018-02-04 at 23:19 +0530, Jagan Teki wrote: > This adds support for the Ampire AM-800480AYTZQW-00H 7.0" WGA LCD, > which can be supported by the simple panel driver. > > Signed-off-by: Jagan Teki > Reviewed-by: Rob Herring > --- >

Re: [PATCH v3 1/7] drm/panel: simple: add support for Ampire AM-800480AYTZQW-00H

Hi Jagan, On Sun, 2018-02-04 at 23:19 +0530, Jagan Teki wrote: > This adds support for the Ampire AM-800480AYTZQW-00H 7.0" WGA LCD, > which can be supported by the simple panel driver. > > Signed-off-by: Jagan Teki > Reviewed-by: Rob Herring > --- > Changes for v3: > - collect Rob reiew tag >

Re: [RFT PATCH v3 4/6] uvcvideo: queue: Simplify spin-lock usage

On Tue, 2018-01-16 at 19:23 +0200, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 12 January 2018 11:19:26 EET Kieran Bingham wrote: > > Both uvc_start_streaming(), and uvc_stop_streaming() are called from > > userspace context. As such, they do not need to save

Re: [RFT PATCH v3 4/6] uvcvideo: queue: Simplify spin-lock usage

On Tue, 2018-01-16 at 19:23 +0200, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 12 January 2018 11:19:26 EET Kieran Bingham wrote: > > Both uvc_start_streaming(), and uvc_stop_streaming() are called from > > userspace context. As such, they do not need to save

Re: [PATCH] [RESEND] gpu: ipu-v3: prg: avoid possible array underflow

Hi Arnd, On Tue, 2018-01-16 at 15:31 +0100, Arnd Bergmann wrote: > gcc-8 reports that we access an array with a negative index > in an error case: > > drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable': > drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below

Re: [PATCH] [RESEND] gpu: ipu-v3: prg: avoid possible array underflow

Hi Arnd, On Tue, 2018-01-16 at 15:31 +0100, Arnd Bergmann wrote: > gcc-8 reports that we access an array with a negative index > in an error case: > > drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable': > drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below

Re: [PATCH] reset: ti-rstctrl: use the reset-simple driver

Hi Tony, On Mon, 2018-01-15 at 17:11 -0800, Tony Lindgren wrote: > We can support the RSTCTRL reset registers on many TI SoCs with > reset-simple. > > Cc: Dave Gerlach <d-gerl...@ti.com> > Cc: Mark Rutland <mark.rutl...@arm.com> > Cc: Nishant Menon <n...@

Re: [PATCH] reset: ti-rstctrl: use the reset-simple driver

Hi Tony, On Mon, 2018-01-15 at 17:11 -0800, Tony Lindgren wrote: > We can support the RSTCTRL reset registers on many TI SoCs with > reset-simple. > > Cc: Dave Gerlach > Cc: Mark Rutland > Cc: Nishant Menon > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Suman Anna

Re: [RFT PATCH v3 0/6] Asynchronous UVC

vices and other platforms, so I'd appreciate if > anyone can test this on a range of USB cameras. FWIW, Tested-by: Philipp Zabel <philipp.za...@gmail.com> with a Lite-On internal Laptop Webcam, Logitech C910 (USB2 isoc), Oculus Sensor (USB3 isoc), and Microsoft HoloLens Sensors (USB3 bulk). regards Philipp

Re: [RFT PATCH v3 0/6] Asynchronous UVC

ppreciate if > anyone can test this on a range of USB cameras. FWIW, Tested-by: Philipp Zabel with a Lite-On internal Laptop Webcam, Logitech C910 (USB2 isoc), Oculus Sensor (USB3 isoc), and Microsoft HoloLens Sensors (USB3 bulk). regards Philipp

Re: [PATCH] gpu: ipu-v3: make array 'int_reg' static, shrinks object size

Hi Colin, On Sat, 2018-01-06 at 17:28 +, Colin King wrote: > From: Colin Ian King > > Don't populate the const read-only array 'int_reg' on the stack but instead > make it static. Makes the object code smaller by over 80 bytes: > > Before: >text data

Re: [PATCH] gpu: ipu-v3: make array 'int_reg' static, shrinks object size

Hi Colin, On Sat, 2018-01-06 at 17:28 +, Colin King wrote: > From: Colin Ian King > > Don't populate the const read-only array 'int_reg' on the stack but instead > make it static. Makes the object code smaller by over 80 bytes: > > Before: >text data bss dec hex

Re: [PATCH 2/3] reset: meson-axg: add compatible string for Meson-AXG SoC

Hi Yixun, On Wed, 2017-12-13 at 22:07 +0800, Yixun Lan wrote: > Hi Philipp > > On 11/10/2017 04:46 PM, Yixun Lan wrote: > > Try to add compatible string explictly to support new Meson-AXG SoC. > > > > Signed-off-by: Yixun Lan > > --- > > drivers/reset/reset-meson.c | 2

Re: [PATCH 2/3] reset: meson-axg: add compatible string for Meson-AXG SoC

Hi Yixun, On Wed, 2017-12-13 at 22:07 +0800, Yixun Lan wrote: > Hi Philipp > > On 11/10/2017 04:46 PM, Yixun Lan wrote: > > Try to add compatible string explictly to support new Meson-AXG SoC. > > > > Signed-off-by: Yixun Lan > > --- > > drivers/reset/reset-meson.c | 2 ++ > > 1 file changed,

Re: [PATCH] mux: add SPDX identifiers to all mux source files

ac44aa209 100644 > --- a/drivers/mux/mmio.c > +++ b/drivers/mux/mmio.c > @@ -1,11 +1,8 @@ > +// SPDX-License-Identifier: GPL-2.0 Acked-by: Philipp Zabel <p.za...@pengutronix.de> > /* > * MMIO register bitfield-controlled multiplexer driver > * > * Copyright (C)

Re: [PATCH] mux: add SPDX identifiers to all mux source files

a/drivers/mux/mmio.c > +++ b/drivers/mux/mmio.c > @@ -1,11 +1,8 @@ > +// SPDX-License-Identifier: GPL-2.0 Acked-by: Philipp Zabel > /* > * MMIO register bitfield-controlled multiplexer driver > * > * Copyright (C) 2017 Pengutronix, Philipp Zabel > - * > - * This pro

Re: linux-next: build failure after merge of the etnaviv tree

Hi Stephen, Lucas, On Thu, 2017-11-30 at 10:53 +1100, Stephen Rothwell wrote: > Hi Lucas, > > On Tue, 28 Nov 2017 11:44:46 +1100 Stephen Rothwell > wrote: > > > > After merging the etnaviv tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > >

Re: linux-next: build failure after merge of the etnaviv tree

Hi Stephen, Lucas, On Thu, 2017-11-30 at 10:53 +1100, Stephen Rothwell wrote: > Hi Lucas, > > On Tue, 28 Nov 2017 11:44:46 +1100 Stephen Rothwell > wrote: > > > > After merging the etnaviv tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > >

Re: [PATCH] drm/mediatek: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

init(dev, attach->dmabuf->size); > > if (IS_ERR(mtk_gem)) > - return ERR_PTR(PTR_ERR(mtk_gem)); > + return ERR_CAST(mtk_gem)); > > expected = sg_dma_address(sg->sgl); > for_each_sg(sg->sgl, s, sg->nents, i) { Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp

Re: [PATCH] drm/mediatek: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

gt; if (IS_ERR(mtk_gem)) > - return ERR_PTR(PTR_ERR(mtk_gem)); > + return ERR_CAST(mtk_gem)); > > expected = sg_dma_address(sg->sgl); > for_each_sg(sg->sgl, s, sg->nents, i) { Acked-by: Philipp Zabel regards Philipp

Re: [PATCH 6/8] drm/mediatek: Add mfd support for mt8173

patches, Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp

Re: [PATCH 5/8] mfd: mtk-mmsys: Add mt8173 nodes

On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote: > Add devices for the mt8173 SoC. > > Signed-off-by: Matthias Brugger <mbrug...@suse.com> Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp

Re: [PATCH 6/8] drm/mediatek: Add mfd support for mt8173

On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote: > Use the MFD device for SoC mt8173. Probing via devicetree > is no longer needed for any SoC, so delete it. > > Signed-off-by: Matthias Brugger Apart from the mmsys_private issue noted in previous patches, Reviewed-by: P

Re: [PATCH 5/8] mfd: mtk-mmsys: Add mt8173 nodes

On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote: > Add devices for the mt8173 SoC. > > Signed-off-by: Matthias Brugger Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH 3/8] drm/mediatek: mt2701: switch to mfd probing.

On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote: > With the mtk-mmsys MFD device in place, we switch the probing for > mt2701 from device-tree to mfd. > > Signed-off-by: Matthias Brugger > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 32

Re: [PATCH 3/8] drm/mediatek: mt2701: switch to mfd probing.

On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote: > With the mtk-mmsys MFD device in place, we switch the probing for > mt2701 from device-tree to mfd. > > Signed-off-by: Matthias Brugger > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 32 +--- > 1 file

Re: [PATCH 2/8] mfd: mtk-mmsys: Add mmsys driver

Hi Matthias, On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote: > The MMSYS subsystem includes clocks and drm components. > This patch adds a MFD device to probe both drivers from the same > device tree compatible. > > Signed-off-by: Matthias Brugger > --- >

Re: [PATCH 2/8] mfd: mtk-mmsys: Add mmsys driver

Hi Matthias, On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote: > The MMSYS subsystem includes clocks and drm components. > This patch adds a MFD device to probe both drivers from the same > device tree compatible. > > Signed-off-by: Matthias Brugger > --- > drivers/mfd/Kconfig |

<    1   2   3   4   5   6   7   8   9   10   >