Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 79 +++---
1 file changed, 40 insertions(+), 39 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
For some reason the newlines are not used everywhere. Fix as needed.
Reported-by: Joe Perches
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c| 74 +--
drivers/soundwire/cadence_master.c | 12 ++--
drivers/soundwire
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 59 +++
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 70ca27ccad85
While not strictly necessary, balanced parentheses help with code
readability.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soundwire/cadence_master.c
b
No need for explicit test against true
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index
No need for explicit test against true
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 8c653a563534..2852ce293fd4 100644
Extra newline does not improve readability.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index 50181752c2a4
No need for explicit test against true
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/mipi_disco.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/mipi_disco.c b/drivers/soundwire/mipi_disco.c
index 95efa82dc73b
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c | 66 -
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 688848637099
tools complain here and the location of the newline does not improve
readability.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 863bf418e342
and make the code more readable
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index efdcefc62e1a..423dc6d17999 100644
the same as in v3.
Changes since v2:
fixed inversion of devm_kcalloc parameters, detected while rebasing
additional patches.
Changes since v1:
added missing newlines in new patch (suggested by Joe Perches)
Pierre-Louis Bossart (22):
soundwire: Kconfig: fix help format
soundwire: fix SPDX
No C++ comments in .h files
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.h| 4 ++--
drivers/soundwire/cadence_master.h | 4 ++--
drivers/soundwire/intel.h | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git
Move to the regular help format, --help-- is no longer recommended.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index
e:
Before:
$ more /sys/bus/acpi/devices/device\:38/adr
0x5d07
After:
$ more /sys/bus/acpi/devices/device\:38/adr
0x10025d07
Signed-off-by: Pierre-Louis Bossart
---
v2: only use 64 bits when required to avoid compatibility issues
(feedback from Vinod and Rafael)
drivers/acpi/device_s
On 5/1/19 5:23 AM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a hda_dsp_rom_msg message, fix it.
Signed-off-by: Colin Ian King
Acked-by: Pierre-Louis Bossart
Thanks for the fix!
---
sound/soc/sof/intel/hda.c | 2 +-
1 file changed, 1 insertion(+), 1
On 4/16/19 3:09 AM, Rafael J. Wysocki wrote:
On Tue, Apr 16, 2019 at 5:29 AM Vinod Koul wrote:
On 15-04-19, 10:18, Pierre-Louis Bossart wrote:
Standards such as the MIPI DisCo for SoundWire 1.0 specification
assume the _ADR field is 64 bits.
_ADR is defined as an "Integer" r
On 4/30/19 11:30 AM, Andy Shevchenko wrote:
On Tue, Apr 30, 2019 at 10:52:29AM -0500, Pierre-Louis Bossart wrote:
When the DSDT tables expose devices with subdevices and a set of
hierarchical _DSD properties, the data returned by
acpi_get_next_subnode() is incorrect, with the results suggesting
On 4/30/19 9:54 AM, Vfiinod Koul wrote:
On 30-04-19, 08:38, Pierre-Louis Bossart wrote:
On 4/30/19 3:51 AM, Vinod Koul wrote:
On 15-04-19, 08:09, Pierre-Louis Bossart wrote:
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
drivers/soundwire
d_node()")', so
this should probably go to linux-stable all the way to 4.12
Signed-off-by: Pierre-Louis Bossart
---
drivers/acpi/property.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index 5815356ea6ad..efc74f912f39 10064
My patch-bot would reject a patch that tried to do multiple types of
different cleanups on the same file(s). Has done so for _years_, this
is not a new thing.
If there are tools let's use them (all the fixes in this series were
reported by tools). Can you share pointers and location of
On 4/30/19 3:51 AM, Vinod Koul wrote:
On 15-04-19, 08:09, Pierre-Louis Bossart wrote:
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
drivers/soundwire/bus.c| 87
drivers/soundwire/bus.h| 16
a sst->pdata->resindex_dma_base
being set to -1.
Signed-off-by: Ross Zwisler
Cc: sta...@vger.kernel.org
Acked-by: Pierre-Louis Bossart
Thanks Ross!
FWIW we should start deprecating this driver now and transition to SOF.
I'll double-check how the upcoming 1.3 release works on my Pixel
2015/
On 4/26/19 11:47 AM, Ross Zwisler wrote:
Currently in sst_dsp_new() if we get an error return from sst_dma_new()
we just print an error message and then still complete the function
successfully. This means that we are trying to run without sst->dma
properly set up, which will result in NULL
On 4/24/19 6:41 AM, Anders Roxell wrote:
When building bytcht_es8316 the following warning shows up:
../sound/soc/intel/boards/bytcht_es8316.c: In function
‘snd_byt_cht_es8316_mc_probe’:
../sound/soc/intel/boards/bytcht_es8316.c:508:11: warning: cast from pointer to
integer of different size
c49b32d3c09 ('soundwire: select REGMAP_SOUNDWIRE')
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index 84876a74874f..d382d80d2fe1 100644
--- a/drivers/soundwire/Kconfig
+++ b/dri
: 7c22ce6e2184 ('03fc8746f7915b5a391d8227f7e1')
Signed-off-by: Pierre-Louis Bossart
---
drivers/base/regmap/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
index 6ad5ef48b61e..c12e3f1fb110 100644
--- a/drivers/base
eless depend in REGMAP_SOUNDWIRE (select will ignore dependencies)
Reordered patches to avoid circular dependencies with git bisect
Pierre-Louis Bossart (2):
soundwire: fix SOUNDWIRE_BUS option
regmap: soundwire: fix Kconfig select/depend issue
drivers/base/regmap/Kconfig | 2 +-
drivers/sound
On 4/15/19 7:57 AM, Pierre-Louis Bossart wrote:
On 4/14/19 5:04 AM, Vinod Koul wrote:
On 10-04-19, 22:16, Pierre-Louis Bossart wrote:
SoundWire support will be provided in Linux with the Sound Open
Firmware (SOF) on Intel platforms. Before we start adding the missing
pieces
enum sdw_command_response
cdns_xfer_msg_defer(struct sdw_bus *bus,
- struct sdw_msg *msg, struct sdw_defer *defer)
+ struct sdw_msg *msg, struct sdw_defer *defer)
this one too..
static int cdns_port_params(struct sdw_bus *bus,
- struct sdw_port_params
-but-set-variable]
It is never used since introduction in
commit ba57f68235cf ("ASoC: Intel: create haswell folder and move haswell platform
files in")
Signed-off-by: YueHaibing
Acked-by: Pierre-Louis Bossart
Thanks!
---
v2: also remove the variable declaration and the sta
On 4/17/19 10:11 AM, Yue Haibing wrote:
From: YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
sound/soc/intel/haswell/sst-haswell-ipc.c: In function 'hsw_stream_message':
sound/soc/intel/haswell/sst-haswell-ipc.c:669:29: warning: variable
'stage_type' set but not used
diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
index 19c8efb9a5ee..84876a74874f 100644
--- a/drivers/soundwire/Kconfig
+++ b/drivers/soundwire/Kconfig
@@ -4,7 +4,7 @@
menuconfig SOUNDWIRE
bool "SoundWire support"
- ---help---
+ help
Not sure if
by: Pierre-Louis Bossart
---
drivers/acpi/device_sysfs.c | 3 +--
include/acpi/acpi_bus.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 8940054d6250..f8d73ae42529 100644
--- a/drivers/acpi/device_sysfs.c
+++
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
drivers/soundwire/bus.c| 87
drivers/soundwire/bus.h| 16 +--
drivers/soundwire/bus_type.c | 4 +-
drivers/soundwire/cadence_master.c | 87
On 4/14/19 5:04 AM, Vinod Koul wrote:
On 10-04-19, 22:16, Pierre-Louis Bossart wrote:
SoundWire support will be provided in Linux with the Sound Open
Firmware (SOF) on Intel platforms. Before we start adding the missing
pieces, there are a number of warnings and style issues reported
On 4/14/19 5:13 AM, Vinod Koul wrote:
On 11-04-19, 14:28, Pierre-Louis Bossart wrote:
0-day/Kbuild starts complaining about missed module dependencies and
compilation issues. Since codecs and soc drivers need to be compilable
independently, let's fix this using the following model:
I have
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index cb6a331f4..0b5bcc209 100644
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -9,6 +9,7 @@
#include
#include
#include
+#include
Why not add asm/io.h which
Removing SOUNDWIRE_BUS Kconfig did clean it up and made it bit more
align with others
Good point, but no. This is intentional and follows the Kconfig pattern
pattern described by Takashi at https://lkml.org/lkml/2017/11/17/47
yes, this SOUNDWIRE is overkill for now, but let's assume
On 4/12/19 5:06 AM, Srinivas Kandagatla wrote:
On 11/04/2019 20:28, Pierre-Louis Bossart wrote:
0-day/Kbuild starts complaining about missed module dependencies and
compilation issues. Since codecs and soc drivers need to be compilable
independently, let's fix this using the following
Thanks for the reviews
The mechanism should be
config CODEC_XYX_SDW
depends on SOUNDWIRE
select REGMAP_SOUNDWIRE
config REGMAP_SOUNDWIRE
depends on SOUNDWIRE
select SOUNDWIRE_BUS
To be noted, in general you can't do put both depends-on and select.
The select
REGMAP_SOUNDWIRE.
Fixes: 7c22ce6e2184 ('03fc8746f7915b5a391d8227f7e1')
Signed-off-by: Pierre-Louis Bossart
---
drivers/base/regmap/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
index 6ad5ef48b61e..4e422afe3c0d
SOUNDWIRE_BUS can be selected independendly by the SOC driver
(e.g. SOUNDWIRE_INTEL) or the codec driver (via REGMAP_SOUNDWIRE).
Remove wrong-way link between SOUNDWIRE_BUS and REGMAP_SOUNDWIRE
Fixes: 6c49b32d3c09 ('soundwire: select REGMAP_SOUNDWIRE')
Signed-off-by: Pierre-Louis Bossart
---
|
v
REGMAP_SOUNDWIRE --- select ---> SOUNDWIRE_BUS
Pierre-Louis Bossart (2):
regmap: soundwire: fix Kconfig select/depend issue
soundwire: fix SOUNDWIRE_BUS option
drivers/base/regmap/Kconfig | 3 ++-
drivers/soundwire/Kconfig | 1 -
2 files changed, 2 insertions(+)
inversion of devm_kcalloc parameters, detected while rebasing
additional patches.
Changes since v1:
added missing newlines in new patch (suggested by Joe Perches)
Pierre-Louis Bossart (5):
soundwire: intel: fix inversion in devm_kcalloc parameters
soundwire: fix style issues
soundwire: bus: remove
no need to reset return value.
Detected with cppcheck:
[drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a
value that is never used.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
No need for explicit initialization of page and ssp fields, they are
already zeroed with a memset.
Detected with cppcheck:
[drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is
reassigned a value before the old one has been used.
Signed-off-by: Pierre-Louis Bossart
---
driv
For some reason the newlines are not used everywhere. Fix as needed.
Reported-by: Joe Perches
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c| 74 +--
drivers/soundwire/cadence_master.c | 12 ++--
drivers/soundwire/intel.c | 12
this.
Fix Kconfig help, spelling, SPDX format, alignment, spurious
parentheses, bool comparisons to true/false, macro argument
protection.
No new functionality added.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
drivers/soundwire/bus.c| 87
the number of elements and size are inverted, fix.
This probably only worked because the number of properties is
hard-coded to 1.
Fixes: 71bb8a1b059e ('soundwire: intel: Add Intel Master driver')
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 4 ++--
1 file changed, 2
this.
Fix Kconfig help, spelling, SPDX format, alignment, spurious
parentheses, bool comparisons to true/false, macro argument
protection.
No new functionality added.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
drivers/soundwire/bus.c| 87
no need to reset return value.
Detected with cppcheck:
[drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a
value that is never used.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
For some reason the newlines are not used everywhere. Fix as needed.
Reported-by: Joe Perches
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c| 74 +--
drivers/soundwire/cadence_master.c | 12 ++--
drivers/soundwire/intel.c | 12
No need for explicit initialization of page and ssp fields, they are
already zeroed with a memset.
Detected with cppcheck:
[drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is
reassigned a value before the old one has been used.
Signed-off-by: Pierre-Louis Bossart
---
driv
newlines in new patch (suggested by Joe Perches)
Pierre-Louis Bossart (4):
soundwire: fix style issues
soundwire: bus: remove useless initializations
soundwire: stream: remove useless initialization of local variable
soundwire: add missing newlines in dynamic debug logs
drivers/soundwire
On 4/8/19 2:12 AM, Jan Kotas wrote:
On 5 Apr 2019, at 17:04, Pierre-Louis Bossart
wrote:
On 4/5/19 2:26 AM, Jan Kotas wrote:
ret = pm_runtime_get_sync(slave->bus->dev);
- if (ret < 0)
+ if (ret < 0 && ret != -EACCES)
There was a patch submitted
Thanks for the review Joe,
@@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave
*slave)
mutex_unlock(>bus->bus_lock);
if (dev_num < 0) {
dev_err(slave->bus->dev, "Get dev_num failed: %d",
-
this.
Fix Kconfig help, spelling, SPDX format, alignment, spurious
parentheses, bool comparisons to true/false, macro argument
protection.
No new functionality added.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Kconfig | 2 +-
drivers/soundwire/bus.c| 87
No need for explicit initialization of page and ssp fields, they are
already zeroed with a memset.
Detected with cppcheck:
[drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is
reassigned a value before the old one has been used.
Signed-off-by: Pierre-Louis Bossart
---
driv
no need to reset return value.
Detected with cppcheck:
[drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a
value that is never used.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
as is is a good
solution (email bounces, etc). I also don't think providing a
non-Intel address is correct since the work was funded by Intel. Is
there a recommended practice here?
Pierre-Louis Bossart (3):
soundwire: fix style issues
soundwire: bus: remove useless initializations
soundwire: stream: remove
On 3/25/19 8:12 AM, Mark Brown wrote:
On Sat, Mar 23, 2019 at 09:55:46AM -0400, Pierre-Louis Bossart wrote:
I'd like to highlight that there is a fundamental flaw in the way the
machine drivers are handled. Since we don't have a hook for the machine
driver in the BIOS, the DSP driver creates
t is already set, but it is not
cleared if the device is subsequently removed. Adding a remove function
to clear the pointer fixes the problem.
Makes sense
Acked-by: Pierre-Louis Bossart
I'd like to highlight that there is a fundamental flaw in the way the
machine drivers are handled. Since we d
lue);
+
+ if (!w_param_text)
+ return;
Acked-by: Pierre-Louis Bossart
next time, try using git format-patch -v2 to signal it's an updated
version, it helps reviewers. Thanks!
+
for (count = 0 ; count < num_params; count++)
devm_kfree(card->dev, (void *)w_param_t
The only minor annoyance I'm experiencing now, is a large amount of debug
output from something in kernel log when audio is played on the system:
writing to lpe: : 01 01 01 01 00 00 08 00 ff ff ff ff 55 00 00 00
U...
writing to lpe: : 01 01 01 01 00 00 1a 00 ff ff
On 1/24/19 11:16 PM, Mogens Jensen wrote:
‐‐‐ Original Message ‐‐‐
On Tuesday, January 22, 2019 7:27 PM, Pierre-Louis Bossart
wrote:
On 1/20/19 11:55 PM, Mogens Jensen wrote:
The only minor annoyance I'm experiencing now, is a large amount of debug
output from something
changes are legitimate. To move forward, maybe it's not worth spending too
much time on a grand unification of string theory, there are simpler
solutions: the Intel machine drivers already do get the platform driver name
as an platform_data argument, so we could modify the dailinks platform
After:
textdata bss dec hex filename
140158896 224 231355a5f bytcht_es8316.o
(gcc version 8.2.0 x86_64)
Signed-off-by: Colin Ian King
Acked-by: Pierre-Louis Bossart
---
V2: also fix up bytcr_rt5640.c and bytcr_rt5651.c, thanks to
Pierre-Louis Bossart
diff --git a/sound/soc/intel/boards/bytcht_es8316.c
b/sound/soc/intel/boards/bytcht_es8316.c
index fa9c4cf97686..1364e4e601d8 100644
--- a/sound/soc/intel/boards/bytcht_es8316.c
+++ b/sound/soc/intel/boards/bytcht_es8316.c
@@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping
On 1/22/19 7:36 PM, Curtis Malainey wrote:
Curtis Malainey | Software Engineer | cujomalai...@google.com | 650-898-3849
On Wed, Jan 23, 2019 at 4:11 AM Pierre-Louis Bossart
wrote:
The issue was that we were seeing a memory corruption bug on an AMD
chromebooks with that function already
The issue was that we were seeing a memory corruption bug on an AMD
chromebooks with that function already (not observed on Intel). I was
testing some SOF integrations and was seeing this in the kernel logs.
I had Dylan verify my logic before I sent the patch because it took so
long to
On 1/20/19 11:55 PM, Mogens Jensen wrote:
The only minor annoyance I'm experiencing now, is a large amount of debug
output from something in kernel log when audio is played on the system:
writing to lpe: : 01 01 01 01 00 00 08 00 ff ff ff ff 55 00 00 00
U...
writing to
On 1/15/19 3:16 PM, Pierre-Louis Bossart wrote:
Beyond the fact that the platform_name seems to be totally useless,
additional tests show that the patch ('ASoC: soc-core: defer card probe
until all component is added to list') adds a new restriction which
contradicts existing error checks
diff --git a/sound/soc/intel/skylake/skl-debug.c
b/sound/soc/intel/skylake/skl-debug.c
index 5d7ac2ee7a3c..bb28db734fb7 100644
--- a/sound/soc/intel/skylake/skl-debug.c
+++ b/sound/soc/intel/skylake/skl-debug.c
@@ -43,7 +43,7 @@ static ssize_t skl_print_pins(struct skl_module_pin *m_pin,
Beyond the fact that the platform_name seems to be totally useless,
additional tests show that the patch ('ASoC: soc-core: defer card probe
until all component is added to list') adds a new restriction which
contradicts existing error checks.
None of the Intel machine drivers set the dailink
On 1/14/19 6:06 PM, Mark Brown wrote:
On Fri, Jan 11, 2019 at 03:49:08PM -0600, Pierre-Louis Bossart wrote:
Adding some traces I can see that the the platform name we use doesn't seem
compatible with your logic. All the Intel boards used a constant platform
name matching the PCI ID, see e.g
On 1/14/19 6:06 PM, Mark Brown wrote:
On Fri, Jan 11, 2019 at 03:49:08PM -0600, Pierre-Louis Bossart wrote:
Adding some traces I can see that the the platform name we use doesn't seem
compatible with your logic. All the Intel boards used a constant platform
name matching the PCI ID, see e.g
Thanks for the overnight fix. This update fixes the issue on my
Skylake XPS13 test device (blind testing since I don't understand what
the code does).
Tested-by: Pierre-Louis Bossart
I need to take this back, this set of changes (initial+fix) causes an
error with our HDMI support
the issue on my Skylake
XPS13 test device (blind testing since I don't understand what the code
does).
Tested-by: Pierre-Louis Bossart
Fixes: 8780cf1142a5 ("ASoC: soc-core: defer card probe until all component is added
to list")
Reported-by: Pierre-Louis Bossart
Signed-off-by: Ajit Pand
While debugging Skylake audio stuff, I came across a kernel oops
introduced by this commit.
It's quite late here and my brain is fried, submitting as is but my
money is on the use of link->platform->of_node which is quite unlikely
to work on ACPI platforms.
and btw you may want to fix the
().
Fixes: 0d3e91da0750 ("ASoC: Intel: bytcht_es8316: Add external speaker mux
support")
Signed-off-by: Wei Yongjun
Acked-by: Pierre-Louis Bossart
---
v1 -> v2: fix snd_byt_cht_es8316_mc_remove() instead, suggested by Dan.
---
sound/soc/intel/boards/bytcht_es8316.c | 3 ++-
1 fi
On 1/4/19 6:34 PM, Azat Khuzhin wrote:
This is unfortunately a known issue with this driver, Takashi and I had
a couple of email threads on this. Even without errors removing the
module doesn't seem to release all resources. I don't like this at all,
and for the Sound Open Firmware (SOF)
-Louis Bossart
---
sound/soc/codecs/rt274.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c
index e2855ab9a2c6..9e88f7b25d38 100644
--- a/sound/soc/codecs/rt274.c
+++ b/sound/soc/codecs/rt274.c
@@ -381,10 +381,10
Reported by Sparse:
da7219.c:841:57: warning: dubious: x & !y
Cc: Adam Thomson
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/da7219.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index ce165047
Reported by Coccinelle:
sound/soc/codecs/tscs42xx.c:392:5-31: WARNING: Comparison to bool
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/tscs42xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c
index
Reported by Coccinelle:
nau8824.c:810:6-12: ERROR: Assignment of bool to non-0/1 constant
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/nau8824.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c
index
: Assignment of bool to 0/1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/max98927.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/max98927.c b/sound/soc/codecs/max98927.c
index 065303a46535..e53d2007f3be 100644
--- a/sound/soc/codecs/max98927.c
ned-off-by: Bard liao
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5645.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index 52ce380c8f3a..9a0751978090 100644
--- a/sound/
Reported by Coccinelle:
mt6351.c:1418:5-8: Unneeded variable: "ret". Return "0" on line 1437
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/mt6351.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/codecs/mt6351.c b/sound/soc/c
From: Bard liao
The buf in rl6347a_hw_read is __be32.
Cc: Oder Chiou
Signed-off-by: Bard liao
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rl6347a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rl6347a.c b/sound/soc/codecs/rl6347a.c
-aad.c:157:37:got restricted __le16 [usertype]
Cc: Adam Thomson
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/da7219-aad.c | 2 +-
sound/soc/codecs/da7219.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/da7219-aad.c b/sound/soc
-Louis Bossart
---
sound/soc/codecs/rt286.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index 0b0f748bffbe..c9457c247a03 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -296,10 +296,10 @@ static
Missing or spurious parameter descriptions. Fix warnings with W=1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/nau8825.c | 1 +
sound/soc/codecs/rt5514.c | 1 +
sound/soc/codecs/rt5677.c | 8
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs
:348:5-7: WARNING: Comparison to bool
sound/soc/codecs/rt298.c:351:5-8: WARNING: Comparison to bool
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt298.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/rt298.c b/sound/soc/codecs/rt298.c
Reported by Coccinelle:
sound/soc/codecs/rt5640.c:980:2-17: WARNING: Assignment of bool to 0/1
sound/soc/codecs/rt5640.c:984:2-17: WARNING: Assignment of bool to 0/1
sound/soc/codecs/rt5640.c:2825:1-16: WARNING: Assignment of bool to 0/1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs
Fix warnings with W=1
If these variables are useful then this driver should be modified to
expose them.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/max98090.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs
Reported by Coccinelle:
sound/soc/codecs/rt5651.c:750:2-17: WARNING: Assignment of bool to 0/1
sound/soc/codecs/rt5651.c:754:2-17: WARNING: Assignment of bool to 0/1
sound/soc/codecs/rt5651.c:2192:1-16: WARNING: Assignment of bool to 0/1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs
Reported by Coccinelle:
sound/soc/codecs/cs4271.c:226:2-16: WARNING: Assignment of bool to 0/1
sound/soc/codecs/cs4271.c:229:2-16: WARNING: Assignment of bool to 0/1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/cs4271.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
No reason why this is global, fix warnings with W=1
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/dmic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/dmic.c b/sound/soc/codecs/dmic.c
index da921da50ef0..de041369e5a7 100644
--- a/sound/soc
Fix warnings with W=1
If these variables are useful this driver should be modified to expose
them.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/es8316.c | 4
1 file changed, 4 deletions(-)
diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c
index e97d12d578b0
901 - 1000 of 1453 matches
Mail list logo
