Re: [PATCH] drivers: staging: Add driver for Amplicon PCIe215

2017-09-01 Thread Piotr Gregor
On Fri, Sep 01, 2017 at 08:57:50AM +0200, Greg Kroah-Hartman wrote: > On Thu, Aug 31, 2017 at 05:54:58PM +0100, Piotr Gregor wrote: > > This is a small and simple driver for handling of external > > interrupt signal asserted on pins of Amplicon's PCIe215 board. > > There

[PATCH] drivers: staging: Add driver for Amplicon PCIe215

2017-08-31 Thread Piotr Gregor
exity at the cost of being generic. In some cases the simpler, more compact solution may be preferred. The purpose of this driver is therefore to handle interrupt feature of the PCIe215, while being small, simple and reliable. Signed-off-by: Piotr Gregor --- drivers/staging/Kc

[PATCH] drivers: pci: Add in description of pci_set_power_state

2017-08-02 Thread Piotr Gregor
Add two reasons of returning 0 value to the description of the pci_set_power_state to include the cases when: - the transition is to D1 or D2 but D1 and D2 are not supported - the transition is to D3 but D3 is not supported. Signed-off-by: Piotr Gregor --- drivers/pci/pci.c | 2 ++ 1 file

Re: [PATCH] staging: comedi: comedi_fops: do not call blocking ops when !TASK_RUNNING

2017-08-01 Thread Piotr Gregor
t_fault()` checks when enabled. Fix it by setting the current task > state back to `TASK_RUNNING` a bit earlier before calling these > functions. > > Reported-by: Piotr Gregor > Signed-off-by: Ian Abbott > Cc: # 4.5+ > --- > Note: stable kernel versions 4.4 and earl

Re: [PATCH] drivers: staging: comedi: Add ftrace support

2017-07-19 Thread Piotr Gregor
On Wed, Jul 19, 2017 at 2:25 PM, Dan Carpenter wrote: > Everyone please delete this confidential email. Piotr is leakier than > the Trump administration! > Sanity level of Dan's assessments is less than half the average level of Hillary's supporter!

Re: [PATCH] drivers: staging: comedi: Add ftrace support

2017-07-19 Thread Piotr Gregor
On Wed, Jul 19, 2017 at 04:21:06PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 19, 2017 at 02:57:28PM +0100, Piotr Gregor wrote: > > + * Id : Description > > + * 0 Enter the interrupt of amplc_dio200_common > > + * 1 Called from same ISR of amplc_dio200_com

[PATCH] drivers: staging: comedi: Add ftrace support

2017-07-19 Thread Piotr Gregor
EMPT RT Thu Jul 13 08:42:02 BST 2017 x86_64 GNU/Linux RAM: 8GB Signed-off-by: Piotr Gregor --- drivers/staging/comedi/drivers/Makefile| 2 ++ .../staging/comedi/drivers/amplc_dio200_common.c | 5 +++ drivers/staging/comedi/drivers/comedi-trace.h | 42 ++

[PATCH] drivers: staging: comedi: Add ftrace support

2017-07-19 Thread Piotr Gregor
EMPT RT Thu Jul 13 08:42:02 BST 2017 x86_64 GNU/Linux RAM: 8GB Signed-off-by: Piotr Gregor --- drivers/staging/comedi/drivers/Makefile| 2 ++ .../staging/comedi/drivers/amplc_dio200_common.c | 5 +++ drivers/staging/comedi/drivers/comedi-trace.h | 42 ++

Re: [BUG] x86/mm: Found insecure W+X mapping at address ffff88000005f000/0xffff88000005f000

2017-07-18 Thread Piotr Gregor
On Tue, Jul 18, 2017 at 02:11:35PM +0200, Thomas Gleixner wrote: > On Tue, 18 Jul 2017, Piotr Gregor wrote: > > > > Dmesg reports insecure W+X mapping found at address > > 8805f000/0x8805f000 > > > > on 4.4.70 kernel patched with -rt83 patch:

[BUG] x86/mm: Found insecure W+X mapping at address ffff88000005f000/0xffff88000005f000

2017-07-18 Thread Piotr Gregor
Hi Thomas, Dmesg reports insecure W+X mapping found at address 8805f000/0x8805f000 on 4.4.70 kernel patched with -rt83 patch: # uname -a Linux piotrpc 4.4.70-rt83 #1 SMP PREEMPT RT Thu Jul 13 08:42:02 BST 2017 x86_64 GNU/Linux [4.888146] Serial: 8250/16550 driver, 4 ports,

Re: [BUG] drivers: staging: comedi: do not call blocking ops when !TASK_RUNNING; state=1

2017-07-17 Thread Piotr Gregor
rself? cheers, Piotr On Mon, Jul 17, 2017 at 05:02:45PM +0100, Ian Abbott wrote: > On 17/07/17 15:48, Piotr Gregor wrote: > >Calling blocking operations from wrong context. > >Kernel: > > > >Linux piotrpc 4.4.70-rt83 #1 SMP PREEMPT RT Thu Jul 13 08:42:

[BUG] drivers: staging: comedi: do not call blocking ops when !TASK_RUNNING; state=1

2017-07-17 Thread Piotr Gregor
Calling blocking operations from wrong context. Kernel: Linux piotrpc 4.4.70-rt83 #1 SMP PREEMPT RT Thu Jul 13 08:42:02 BST 2017 x86_64 GNU/Linux [ 80.542018] NOHZ: local_softirq_pending 80 [ 125.175471] [ cut here ] [ 125.175491] WARNING: CPU: 0 PID: 1497 at kernel/s

RE: [PATCH 01/32] tracing: Add hist_field_name() accessor

2017-07-12 Thread Piotr Gregor
Hi Tom, Which repo and branch do you push these changes into? cheers, Piotr -Original Message- From: linux-rt-users-ow...@vger.kernel.org [mailto:linux-rt-users-ow...@vger.kernel.org] On Behalf Of Tom Zanussi Sent: 26 June 2017 23:49 To: rost...@goodmis.org Cc: t...@linutronix.de; mhira

Re: [PATCH] PCI: Move test of INTx masking to pci_setup_device

2017-06-18 Thread Piotr Gregor
On Sat, Jun 17, 2017 at 08:14:33PM -0500, Bjorn Helgaas wrote: > On Sat, Jun 17, 2017 at 06:45:44PM +0100, Piotr Gregor wrote: > > Hi Bjorn, > > > > The pci_cfg_access_lock is most likely not needed there. > > The assignment by return type is indeed preferred in this

Re: [PATCH] PCI: Move test of INTx masking to pci_setup_device

2017-06-17 Thread Piotr Gregor
) || PCI_VERSION_PRIOR_TO_23) /* test OK or PCI prior to r2.3 */ return 0; return 1; cheers, Piotr On Fri, Jun 16, 2017 at 05:54:46PM -0500, Bjorn Helgaas wrote: > On Fri, May 26, 2017 at 10:02:25PM +0100, Piotr Gregor wrote: > > The test for INTx masking via con

[PATCH] PCI: Move test of INTx masking to pci_setup_device

2017-05-26 Thread Piotr Gregor
this feature broken and it has passed * pci_test_intx_masking() test. */ return !pdev->broken_intx_masking; } so current users of pci_intx_mask_supported: uio and vfio, keep their code unchanged. Signed-off-by: Piotr Gregor --- drivers/pci/pci.

[PATCH] PCI: Move test of INTx masking to pci_setup_device

2017-05-25 Thread Piotr Gregor
* and it's INTx masking feature works properly. */ return !pdev->broken_intx_masking; } so current users of pci_intx_mask_supported: uio and vfio, keep their code unchanged. Signed-off-by: Piotr Gregor --- drivers/pci/pci.

Re: [PATCH] PCI: Move test of INTx masking to pci_setup_device

2017-05-25 Thread Piotr Gregor
Very good suggestions. Will be reflected in changed patch.

[PATCH] PCI: Move test of INTx masking to pci_setup_device

2017-05-25 Thread Piotr Gregor
) { /* * INTx masking is supported if device passed INTx test * and it's INTx masking feature works properly. */ return (pdev->intx_mask_support && !pdev->broken_intx_masking); } Signed-off-by: Piotr Gregor --- drivers/pci/pci

Re: [PATCH] pci: Handle the case when PCI_COMMAND register hasn't changed in INTx masking test

2017-05-23 Thread Piotr Gregor
On Tue, May 23, 2017 at 04:45:31PM -0500, Bjorn Helgaas wrote: > On Tue, May 23, 2017 at 08:14:26PM +0100, Piotr Gregor wrote: > > Would the pci_setup_device() be a good place to move this check to? > > Seems like a reasonable place. Will upload new patch moving test of INTx mas

Re: [PATCH] pci: Handle the case when PCI_COMMAND register hasn't changed in INTx masking test

2017-05-23 Thread Piotr Gregor
elgaas wrote: >> > Hi Piotr, >> > >> > On Wed, May 10, 2017 at 01:30:01PM +0100, Piotr Gregor wrote: >> > > The check for interrupt masking support is done by reading >> > > the PCI_COMMAND config word >> > > >> > > pci_read_config_w

[PATCH] pci: Handle the case when PCI_COMMAND register hasn't changed in INTx masking test

2017-05-10 Thread Piotr Gregor
command not being changed at all. Signed-off-by: Piotr Gregor --- drivers/pci/pci.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index b01bd5b..67a611e 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c

Comedi TODO list in context of amplc_dio200_pci driver

2017-05-04 Thread Piotr Gregor
Hi Ian, In TODO file of Comedi PCI subsystem (drivers/staging/comedi/TODO) we can read the following: 1 TODO: 2 - checkpatch.pl cleanups 3 - Lindent 4 - remove all wrappers 5 - audit userspace interface 6 - Fix coverity 1195261 7 - cleanup the individual

[PATCH] drivers: staging: comedi: fix function prototypes

2016-12-14 Thread Piotr Gregor
Add names of parameters to function prototypes in comedi PCI. Checkpatch reports now no errors. Signed-off-by: Piotr Gregor --- drivers/staging/comedi/comedi_pci.h | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/comedi/comedi_pci.h b

[PATCH] arch: x86: kernel: fixed unused label issue

2016-12-14 Thread Piotr Gregor
should be enclosed in a do - while loop which probably is a false alarm here as PATCH_SITE macro defines a case in switch local to native_patch function not meant to be used in other places. Signed-off-by: Piotr Gregor --- arch/x86/kernel/paravirt_patch_64.c | 67

[PATCH] include/linux/kernel.h: fixed coding style issues

2016-12-13 Thread Piotr Gregor
Apply coding style suggested by Documentation/CodingStyle and checkpatch.pl script. Fix 59 warnings and 24 errors reported by checkpatch.pl Signed-off-by: Piotr Gregor --- include/linux/kernel.h | 180 + 1 file changed, 106 insertions(+), 74