From: "Lad, Prabhakar"
this patch does the following:
a> uses devm_kzalloc() instead of kzalloc and cleanup the error path
b> uses devm_ioremap() instead of ioremap and cleanup the error path
c> uses devm_request_irq() instead of request_irq and cleanup the error path
Signed-off-by: Lad, Prabhak
On Tue, Jan 13, 2015 at 1:39 PM, Maxime Ripard
wrote:
> On Tue, Jan 13, 2015 at 11:53:01AM +0000, Prabhakar Lad wrote:
>> On Tue, Jan 13, 2015 at 11:43 AM, Tomi Valkeinen
>> wrote:
>> > On 08/01/15 10:17, Lad, Prabhakar wrote:
>> >> this patch checks the
g in a garbage error code...
>
Agreed I have just aligned this to rest of the code in this function.
Maxime if you are OK I'll post a patch returning error then and there ?
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
as not able to utilize my holidays
in proper way :D
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
alized
>> > here, but for the sanity of gcc output explicitly initialize it.
>> > Same goes for the 'end' variable.
>>
>> Prabhakar Lad also sent a patch for this already, which was lacking
>> a good patch description. Your patch does this slightly better bu
ll accepted for
> 3.19.
>
OK will post a v4 tonight fixing all the below issues.
FYI: Looking at the response of Mauro on 'soc-camera: 1st set for 3.19'
he wont accept it!
Thanks,
--Prabhakar Lad
> On 12/04/2014 12:12 AM, Lad, Prabhakar wrote:
>> From: Benoit Parrot
>
; Please explain why the compiler thinks there is a bug, why you
> are sure that there isn't, and why you picked '0' as the
> initialization value.
>
Its a false positive, to suppress the warning '0' was picked.
Thanks,
--Prabhakar Lad
--
To unsubscribe from t
(unsigned long) vga_res.start;
>
> This does look quite ugly... Where does the warning come from in the
> first place. Isn't vga_res.start (resource_size_t) the size of a pointer?
>
Yes looks ugly, I am not sure what you meant from 'where does this warning
come from' its
virtio64)cpu_to_le64(val);
> + else
> + return (__force __virtio64)val;
> +}
> +
Nitpicking, could remove the else for the all above functions and
align the return appropriately ?
Apart from that patch looks good.
Acked-by: Lad, Prabhakar
Thanks,
--Prabha
3 Sequence: 119 Field: None Timestamp: 76.711771s
test MMAP: OK
test USERPTR: OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Total: 42, Succeeded: 42, Failed: 0, Warnings: 0
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsub
Hi Michal,
On Tue, Dec 2, 2014 at 9:36 AM, Michal Simek wrote:
> On 12/02/2014 10:31 AM, Prabhakar Lad wrote:
>> Hi Michal,
>>
>> Thanks for the patch.
>>
>> On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek wrote:
>>> Modules can use this function for cr
| 1 +
> 1 file changed, 1 insertion(+)
>
don’t you need to add an entry in include/linux/genalloc.h ?
Thanks,
--Prabhakar Lad
> diff --git a/lib/genalloc.c b/lib/genalloc.c
> index cce4dd68c40d..2e65d206b01c 100644
> --- a/lib/genalloc.c
> +++ b/lib/genalloc.c
> @@ -598,6 +598,7
Hi Hans,
On Mon, Dec 1, 2014 at 11:26 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
>
> On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote:
>> On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote:
>> > On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote:
>>
Hi Hans,
On Tue, Dec 2, 2014 at 7:32 AM, Hans Verkuil wrote:
> On 12/01/2014 11:27 PM, Prabhakar Lad wrote:
>> Hi Hans,
>>
>> On Mon, Dec 1, 2014 at 11:00 AM, Hans Verkuil wrote:
>>> On 12/01/2014 11:11 AM, Hans Verkuil wrote:
>>>> Hi all,
>>&
Hi Hans,
On Tue, Dec 2, 2014 at 7:26 AM, Hans Verkuil wrote:
> On 12/01/2014 11:17 PM, Prabhakar Lad wrote:
>> Hi Hans,
>>
>> Thanks for the review.
>>
>> On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil wrote:
>>> Hi all,
>>>
>>> Than
take a decision
on this quickly I can post a v2 soon.
> One question, unrelated to this patch series:
>
> Prabhakar, would it make sense to look at the various existing TI sources
> as well and rename them to make it more explicit for which SoCs they are
> meant? Most are pretty vagu
Hi Hans,
Thanks for the review.
On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil wrote:
> Hi all,
>
> Thanks for the patch, review comments are below.
>
> For the next version I would appreciate if someone can test this driver with
> the latest v4l2-compliance from the v4l-utils git repo. If possib
--
> include/uapi/linux/virtio_scsi.h | 74
>
> include/uapi/linux/Kbuild| 1 +
Probably worth making a separate patch for this ? as it doesnt
match with patch description aswel.
Apart from that patch looks good.
Acked-by: Lad, Prabhakar
Hi Laurent,
On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart
wrote:
> On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote:
>> On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote:
>> > Hi Prabhakar,
>>
>> [Snip]
>>
>> >> > Sure. Tha
he
> configuration store. The userspace subdev API would use the configuration
> store from the file handle.
>
are planning to work/post any time soon ? Or are you OK with suggestion from
Hans ?
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe li
> I originally wrote them like that in order to avoid writing essentially the
> same code three times over. If there will be more targets, the same repeats
> further, should one write those functions open for all different macro
> arguments. That's why it was a macro to begin with.
Hi Laurent,
On Sat, Nov 29, 2014 at 6:11 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
>
> On Friday 28 November 2014 17:06:52 Prabhakar Lad wrote:
>> On Thu, Nov 27, 2014 at 9:32 PM, Laurent Pinchart wrote:
>> > Hi Prabhakar,
>>
>> [Snip]
>>
>
lease cannot be dropped
as it does some usb_autopm_get/put_interface() calls which I am not aware of.
Thanks,
--Prabhakar Lad
>> ret = vb2_queue_init(&queue->queue);
>> if (ret)
>> return ret;
>
> --
> Regards,
>
> Laurent Pinc
t; The queue lock field isn't initialized by the uvcvideo driver, so you can't
> use vb2_ops_wait_prepare|finish().
>
Oops not sure what happened here I just took the patch from [1]
and added commit message. anyway will post a single patch v3.
[1] https://patchwork.kernel.org/patch/5
Hi,
On Tue, Nov 25, 2014 at 3:18 PM, Prabhakar Lad
wrote:
> Hi Mauro,
>
> On Tue, Nov 25, 2014 at 3:04 PM, Mauro Carvalho Chehab
> wrote:
>> Em Tue, 18 Nov 2014 10:57:48 +
> [Snip]
>>
>> -static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *ind
ne address is wrong");
> return -EINVAL;
> }
> + return 0;
the control wont reach here! may be you can remove the complete else
part outside ?
with that change,
Reported-by: Lad, Prabhakar
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> }
>
one where the
> __V4L2_SUBDEV_MK_GET_TRY
> is removed and these three try functions are just written as proper
> static inlines. I find it very obfuscated code.
>
the functions were initially inline itself which were changes into
macro's later.
> In addition, because it is a ma
7;t try to stand in its way. It would be nice
> to see a real changelog on the patch, though.
>
Sorry there is no movement of code to other file. And I dont see any
reason why anybody reading will go haywire its a standard v4l2 thing.
The subject explains it all, If you still want me to e
gt;> @@ -642,7 +642,6 @@ struct v4l2_subdev_fh {
>> #define to_v4l2_subdev_fh(fh) \
>> container_of(fh, struct v4l2_subdev_fh, vfh)
>>
>> -#if defined(CONFIG_VIDEO_V4L2_SUBDEV_API)
>
>
> Wouldn't you need to drop these from struct v4l2_subdev_fh as well?
---
For all the above,
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> drivers/media/i2c/vs6624.c| 18
> 46 files changed, 382 insertions(+), 382 deletions(-)
>
> diff --git a/drivers/media/i2c/adv7170.c b/drivers/media/i2c/adv7170.c
> index 04bb297..40a1a
| 4 +-
[snip]
> include/media/davinci/vpbe.h | 2 +-
> include/media/davinci/vpbe_venc.h | 5 +-
For all the above.
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a me
dia/davinci_vpfe/dm365_ipipeif.c | 100
> ++---
> drivers/staging/media/davinci_vpfe/dm365_isif.c| 90 +--
> drivers/staging/media/davinci_vpfe/dm365_resizer.c | 98 ++--
> .../staging/media/davinci_vpfe/vpfe_mc_capture.c | 18 ++--
For all the above
Hi,
Thanks for the patch!
On Thu, Nov 6, 2014 at 1:04 PM, Sudip Mukherjee
wrote:
> we are getting struct clk using clk_get before calling
> clk_prepare_enable. but if clk_prepare_enable fails, then we are
> jumping to fail_mutex_unlock where we are just unlocking the mutex,
> but we are not free
the others for 3.19. Just post
> an
> updated version for this one and I'll pick it up later.
>
I fixed it and posted the patch. To avoid conflicts I have rebased the patch on
for-v3.19a branch of your tree.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: sen
apture.ko] undefined!
>
> That's because vpif_lock symbol is not exported.
>
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> Reported-by: Stephen Rothwell
> Signed-off-by: Mauro Carvalho Chehab
>
> diff --git a/drivers/media/platform/davinci/vpif.c
> b/drivers/med
Hi Mauro,
Please pull the following patches for davinci media which include
trivial cleanups.
Thanks,
--Prabhakar Lad
The following changes since commit 3c0d394ea7022bb9666d9df97a5776c4bcc3045c:
[media] dib8000: improve the message that reports per-layer locks
(2014-07-07 09:59:01 -0300
at least one PHY's child is defined in DT, otherwise rollback to
> mdiobus_register().
>
> Reviewed-by: Santosh Shilimkar
> Acked-by: Mugunthan V N
> Signed-off-by: Grygorii Strashko
Reviewed-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> ---
> Hi Santosh,
>
>
em
> See http://www.ti.com/lit/ug/spruhj5/spruhj5.pdf
>
> Hence, reuse Davinci MDIO driver for Keystone 2 and
> enable TI networking for Keystone 2 devices
>
> Reviewed-by: Santosh Shilimkar
> Acked-by: Mugunthan V N
> Signed-off-by: Grygorii Strashko
Reviewed-by: L
to make a config that would build that code. But i believe
> that warning is still better than misbehaviour.
>
It wont cause any compile warning.
Applied for v3.17
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a me
XYNOS_CPUFREQ) += exynos-cpufreq.o
>> obj-$(CONFIG_ARM_EXYNOS4210_CPUFREQ) += exynos4210-cpufreq.o
>
> It took one year and 5 kernel releases to catch this again?
>
For a long time I was been working on DA850 itself, so couldn’t
notice it :(.
> Acked-by: Viresh Kumar
goto exit;
>> }
>>
>> - addr = ioremap(mem->start, resource_size(mem));
>> - if (!addr) {
>> - dev_err(&pdev->dev, "failed to map can port\n");
>> - ret = -ENOMEM;
>> - goto exit_
led cppcheck.
>
> Signed-off-by: Rickard Strandqvist
The commit message and header needs to be improved, apart from that rest of the
patch looks good.
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> ---
> drivers/media/v4l2-core/v4l2-dv-timings.c |4 ++--
> 1 file changed, 2
Hi Paul,
Thanks for the patch.
On Thu, May 22, 2014 at 8:42 PM, Paul Bolle wrote:
> A check for CONFIG_DM644X_VIDEO_PORT_ENABLE was added in v2.6.32. The
> related Kconfig symbol was never added so this check has always
> evaluated to false. Remove that check.
>
Applied.
Thanks,
t; Why to remove those parameters? Please _ALWAYS_ describe your patches.
>
My bad! will take care next time.
Thanks,
--Prabhakar Lad
> My crystal ball is malfunctioning today, so I was unable to scry the
> reasons for this patch.
>
> Thanks,
> Mauro
>
>> ---
>> dr
cating next week so will take me at-least
2-3 weeks for me to get back the boards and get in action.
Regards,
--Prabhakar Lad
> Regards,
>
> Hans
>
> On 05/16/2014 03:33 PM, Lad, Prabhakar wrote:
>> From: "Lad, Prabhakar"
>>
>> Hi,
>>
>
>>
>> common->started = ret;
>> vpif_config_addr(ch, ret);
>> + /* Get the next frame from the buffer queue */
>> + common->next_frm = common->cur_frm =
>> + list_entry(common->dma_queue.next,
>>
On Wed, May 21, 2014 at 1:04 AM, Andrew Morton
wrote:
> On Tue, 20 May 2014 16:49:00 +0100 Mel Gorman wrote:
>
>> Prabhakar Lad reported the following problem
>>
>> I see following issue on DA850 evm,
>> git bisect points me to
>> commit id: 975c
Supported)
>> test VIDIOC_S_FMT: OK (Not Supported)
>> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>>
>> Codec ioctls:
>> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
>> test VIDIOC_G_EN
You might want split this patch so that others can pick it
> up
>
Thanks for picking it up.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
; Cc: Florian Fainelli
> Cc: Sergei Shtylyov
> Cc: Lad, Prabhakar
> Cc: David S. Miller
> Cc: net...@vger.kernel.org
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> ---
> drivers/net/phy/mdio_bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
h. The obsolete
> COMMON_CLK_DEBUG option has been removed from two of them on my branch
> by savedefconfig, and we will address the remaining one in another
> patch.
>
OK will post the updated patch dropping these 3 files.
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send
should have no functional changes.
>
> Signed-off-by: Stratos Karafotis
For patches 1 & 2: Acked-by: Lad, Prabhakar
and for patch 3: Acked-and-tested-by: Lad, Prabhakar
Thanks,
--Prabhakar lad
> ---
> drivers/cpufreq/acpi-cpufreq.c | 9 +++---
> drivers
2 has type 'int'
[-Wformat=]
pr_debug("table entry %lu: %u kHz\n", pos - table, freq);
Thanks,
--Prabhakar Lad
> Signed-off-by: Stratos Karafotis
> ---
> drivers/cpufreq/acpi-cpufreq.c | 9 +++---
> drivers/cpufreq/arm_big_little.c | 16 +--
vm_mdiobus_alloc/devm_mdiobus_free
> net: davinci_mdio: use devm_* api
> net: davinci_mdio: drop pinctrl_pm_select_default_state from probe
> net: davinci_mdio: simplify IO memory mapping
>
Tested on DA850EVM.
Acked-and-tested-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> Docume
kel_buffer, vb2);
>
> Why is this a type? The vb2_buffer member in struct skel_buffer is called
> 'vb', so this should be correct.
>
Oops may be I overlooked, sorry for the noise.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-
6c15b3 100644
>> --- a/drivers/media/platform/davinci/vpif_capture.c
>> +++ b/drivers/media/platform/davinci/vpif_capture.c
>
> ...
>
>> static int vpif_buffer_init(struct vb2_buffer *vb)
>> {
>> - struct vpif_cap_buffer *buf = container_of(vb,
>> -
From: "Lad, Prabhakar"
This patch adds missing #gpio-cells and also adds a
usage example for leds.
Reported-by: Alexander Holler
Signed-off-by: Lad, Prabhakar
---
.../devicetree/bindings/gpio/gpio-davinci.txt | 21
1 file changed, 21 insertions(+)
diff --git a/Doc
Hi Michael,
On Mon, Feb 24, 2014 at 11:01 AM, Prabhakar Lad
wrote:
> Hi Michael,
>
> On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker
> wrote:
>> Hi Laurent,
>>
>> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
>>> Hi Michael,
>>>
>>>
ively, pushing all the remaining changes
> in one go (or removing the definition of IRQF_DISABLED) may be the final
> solution.
>
> I hope to be able to answer your question by the end of the week.
>
gentle ping. should I pick it up ?
Regards,
--Prabhakar Lad
--
To unsubscribe from th
From: "Lad, Prabhakar"
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/omap3isp/isp.c|2 +-
drivers/media/platform/omap3isp/ispccdc.c|2 +-
drivers/media/platform/omap3isp/ispccp2.c|4 ++--
drivers/media/platform/omap3isp/isphist.c|2 +-
drivers/medi
From: "Lad, Prabhakar"
This patch series include fixing some typos and
removal of unwanted comments.
Lad, Prabhakar (3):
media: omap3isp: fix typos
media: omap3isp: ispccdc: remove unwanted comments
media: omap3isp: rename the variable names in description
drivers/media/platform/omap3is
From: "Lad, Prabhakar"
this patch renames the variable in the description to
match it appropriately to function definition.
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/omap3isp/isp.h| 12 ++--
drivers/media/platform/omap3isp/ispccdc.c|8
drivers/
From: "Lad, Prabhakar"
this patch removes the description of members which
does not exists for ispccdc_lsc structure.
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/omap3isp/ispccdc.h |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/media/platform/omap3isp/ispccdc.
From: "Lad, Prabhakar"
This patch fixes couple of typos in the comments
for da8xx-fb.c file.
Signed-off-by: Lad, Prabhakar
---
drivers/video/da8xx-fb.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index a1d74dd
On Tue, Feb 4, 2014 at 3:29 PM, Amit Grover wrote:
> Adding V4L2 controls for horizontal and vertical search range in pixels
> for motion estimation module in video encoder.
>
> Signed-off-by: Swami Nathan
> Signed-off-by: Amit Grover
Acked-by: Lad, Prabhakar
Regards,
nd if you see VIDEO_V4L2_SUBDEV_API depends on MEDIA_CONTROLLER
config so there is no point in adding this dependency.
Thanks,
--Prabhakar Lad
> Signed-off-by: Marcus Folkesson
> ---
> drivers/media/i2c/Kconfig |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
From: "Lad, Prabhakar"
this patch fixes a typo in mach/hardware.h, by
replacing "ths" to "this".
Signed-off-by: Lad, Prabhakar
---
arch/arm/mach-davinci/include/mach/hardware.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-davinci/include/mach/hardware.h
Hi Sachin,
On Thu, Jan 23, 2014 at 3:38 PM, Sachin Kamat wrote:
> Hi Prabhakar,
>
> On 23 January 2014 15:26, Prabhakar Lad wrote:
>> From: "Lad, Prabhakar"
>>
>> In the gen_pool_dma_alloc() the dma pointer can be NULL
>> and while assigning gen_pool
From: "Lad, Prabhakar"
In the gen_pool_dma_alloc() the dma pointer can be NULL
and while assigning gen_pool_virt_to_phys(pool, vaddr) to
dma caused the following crash on da850 evm,
Unable to handle kernel NULL pointer dereference at virtual address
pgd = c0004000
[] *pgd=00
From: "Lad, Prabhakar"
This patch drops CONFIG_REGULATOR_DUMMY as this obsolete.
Signed-off-by: Lad, Prabhakar
---
arch/arm/configs/da8xx_omapl_defconfig |1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/configs/da8xx_omapl_defconfig
b/arch/arm/configs/da8xx_omapl_defconfig
index
_full_constraints(); call in .init_machine
but results
the same. Any pointer would be helpfull.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.o
changed, 58 insertions(+), 6 deletions(-)
>>
This patch from the outset looks OK, but you need to split up
into two, first adding a v4l control and second one using it up in the driver.
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu
On Wed, Jan 22, 2014 at 5:56 PM, Russell King - ARM Linux
wrote:
> On Wed, Jan 22, 2014 at 05:54:29PM +0530, Prabhakar Lad wrote:
>> Hi Russell,
>>
>> On Fri, Jan 17, 2014 at 1:07 PM, Prabhakar Lad
>> wrote:
>> > Hi,
>> >
>> > On Linux-next b
Hi Russell,
On Fri, Jan 17, 2014 at 1:07 PM, Prabhakar Lad
wrote:
> Hi,
>
> On Linux-next branch I see following errors for davinci_all_defconfig
> & da8xx_omapl_defconfig configs,
>
> arch/arm/Kconfig:1966:error: recursive dependency detected!
> arch/arm/Kconfig:
From: "Lad, Prabhakar"
clk_set_rate(), clk_prepare_enable() functions can fail, so check the return
values to avoid surprises.
Signed-off-by: Lad, Prabhakar
---
Changes for v2:
1: Called regulator_bulk_disable() in the error path
drivers/media/i2c/mt9p031.c | 15 ---
1 file c
From: "Lad, Prabhakar"
clk_set_rate(), clk_prepare_enable() functions can fail, so check the return
values to avoid surprises.
Signed-off-by: Lad, Prabhakar
---
drivers/media/i2c/mt9v032.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/mt9v03
From: "Lad, Prabhakar"
clk_set_rate(), clk_prepare_enable() functions can fail, so check the return
values to avoid surprises.
Signed-off-by: Lad, Prabhakar
---
drivers/media/i2c/mt9p031.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/mt9p
Hi Brain,
On Fri, Jan 17, 2014 at 10:46 AM, Prabhakar Lad
wrote:
> Hi Brian,
>
> On Fri, Jan 17, 2014 at 3:02 AM, Brian Norris
> wrote:
>> On Wed, Jan 15, 2014 at 01:38:26PM +0530, Prabhakar Lad wrote:
>>> From: "Lad, Prabhakar"
>>>
>>>
d by ZBOOT_ROM
#
# configuration written to .config
#
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read th
Hi Brian,
On Fri, Jan 17, 2014 at 3:02 AM, Brian Norris
wrote:
> On Wed, Jan 15, 2014 at 01:38:26PM +0530, Prabhakar Lad wrote:
>> From: "Lad, Prabhakar"
>>
>> This patch removes the unnecessary labels from
>> the error path in probe function which did
From: "Lad, Prabhakar"
This patch fixes following sparse warning
davinci_mdio.c:85:27: warning: symbol 'default_pdata' was not declared. Should
it be static?
Also makes the default_pdata as a constant.
Signed-off-by: Lad, Prabhakar
---
drivers/net/ethernet/ti/davinci_mdio.c |2 +-
1 file
From: "Lad, Prabhakar"
This patch removes the unnecessary labels from
the error path in probe function which did nothing
than just returning error values, Thus simplifying code
path and improved readability.
Signed-off-by: Lad, Prabhakar
---
drivers/mtd/nand/davinci_nand.c | 31 ++---
On Tue, Dec 24, 2013 at 6:57 PM, Grygorii Strashko
wrote:
> On 12/24/2013 01:20 PM, Prabhakar Lad wrote:
>>
>> Hi Grygorii,
>>
>> Thanks for the patch.
>>
>> On Tue, Dec 24, 2013 at 5:11 PM, Grygorii Strashko
>> wrote:
>>>
>>> The s
> + struct irq_chip *irq_chip;
> + gpio_get_irq_chip_cb_t gpio_get_irq_chip;
> +
> + /*
> +* Use davinci_gpio_get_irq_chip by default to handle non DT cases
> +*/
> + gpio_get_irq_chip = davinci_gpio_get_irq_chip;
> + match = of_match_device(of
using IRQ Chip.
>
> Documentation:
> http://www.ti.com/lit/ug/sprugv1/sprugv1.pdf
>
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Sekhar Nori
> Cc: devicet...@vger.kernel.org
>
> Acked-by: Santosh Shilimkar
> Signed-off-by: Grygorii Strashko
Acked-by:
are enabled
> and correct gpio_to_irq_banked() to handle this properly.
>
> Cc: Linus Walleij
> Cc: Alexandre Courbot
> Cc: Sekhar Nori
>
> Acked-by: Santosh Shilimkar
> Signed-off-by: Grygorii Strashko
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
--
To unsubscribe
Hi Hans,
On Fri, Dec 20, 2013 at 7:00 PM, Hans Verkuil wrote:
> Hi Prabhakar,
>
> On 12/20/2013 02:02 PM, Prabhakar Lad wrote:
>> Hi Hans,
>>
>> On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil wrote:
>>> I just made a patch myself that I added to the pull reque
ke up in linux-media but its
present DLOS [1].
I posted it the same day when you pinged me about this issue. Anyway your patch
too didnt reach me and I also cannot find it in the ML. May be you
directly issued the pull ?
[1] https://patchwork.kernel.org/patch/3362211/
Regards,
--Prabhakar Lad
--
To u
mplicit declaration of function ‘msleep’
>
Will you pick this patch or shall I go ahead and issue a pull to Mauro ?
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordo
Hi Linus,
On Fri, Dec 13, 2013 at 2:01 AM, Linus Walleij wrote:
> On Wed, Dec 11, 2013 at 6:52 PM, Prabhakar Lad
> wrote:
>
>> From: "Lad, Prabhakar"
>>
>> This patch replaces the __raw_readl/writel with
>> {readl|writel}_relaxed(), Altough the code
2 GPIO lines;
> - only unbanked irqs;
>
> See Documentation:
> Keystone - http://www.ti.com/lit/ug/sprugv1/sprugv1.pdf
>
> [1] Depends on patch:
> "[PATCH 1/2] gpio: davinci: Fix a check for unbanked gpio"
> https://lkml.org/lkml/2013/11/8/22
>
> [2] and de
From: "Lad, Prabhakar"
This patch replaces the __raw_readl/writel with
{readl|writel}_relaxed(), Altough the code runs on ARMv5
based SOCs, changing this will help copying the code
for other uses.
Signed-off-by: Lad, Prabhakar
---
This patch is part of series [1] rest of the patches
are Acked
Hi Linus,
On Fri, Nov 29, 2013 at 1:17 PM, Linus Walleij wrote:
> On Thu, Nov 21, 2013 at 7:15 PM, Prabhakar Lad
> wrote:
>
>> From: "Lad, Prabhakar"
>>
>> This patch series does the following
>> 1> Ports the driver to use irqdomain.
>> 2&g
er for Keystone SoCs when needed. At same time, kept
> Davinci GPIO driver enabled for Davinci SoCs by default.
>
> Signed-off-by: Grygorii Strashko
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
m.
>
> Signed-off-by: Grygorii Strashko
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Sekhar,
On Mon, Nov 25, 2013 at 4:04 PM, Sekhar Nori wrote:
> Prabhakar,
>
> On Monday 25 November 2013 09:42 AM, Prabhakar Lad wrote:
>> Hi Taras,
>>
>> On Fri, Nov 22, 2013 at 3:38 PM, Taras Kondratiuk
>> wrote:
>>> On 21 November 2013 20
Hi Sekhar,
Thanks for the review.
On Mon, Nov 25, 2013 at 4:30 PM, Sekhar Nori wrote:
> On Thursday 21 November 2013 11:45 PM, Prabhakar Lad wrote:
>> From: KV Sujith
>>
>> This patch adds OF parser support for davinci gpio
>> driver and also appropriate docume
Hi Taras,
On Fri, Nov 22, 2013 at 3:38 PM, Taras Kondratiuk
wrote:
> On 21 November 2013 20:15, Prabhakar Lad wrote:
>> From: "Lad, Prabhakar"
>>
>> This patch replaces the __raw_readl/writel with
>> readl and writel, Altough the code runs on ARMv5
&
Hi Grygorii,
Thanks for the review.
On Fri, Nov 8, 2013 at 9:09 PM, Grygorii Strashko
wrote:
> On 11/08/2013 12:11 PM, Prabhakar Lad wrote:
>>
>> From: "Lad, Prabhakar"
>>
>> the devm_*() helper prints error messages in case of
>> errors no need to do
Hi Grygorii,
Thanks for the review.
On Mon, Nov 11, 2013 at 8:48 PM, Grygorii Strashko
wrote:
> On 11/08/2013 12:11 PM, Prabhakar Lad wrote:
[Snip]
>> @@ -134,6 +137,40 @@ davinci_gpio_set(struct gpio_chip *chip, unsigned
>> offset, int value)
>> writel((1 &
1 - 100 of 645 matches
Mail list logo
