Re: [PATCH 3/3] clockevents: Switch state to ONESHOT_STOPPED for unused clockevent devices

2015-03-29 Thread Preeti U Murthy
device */ + clockevents_set_state(dev, CLOCK_EVT_STATE_ONESHOT_STOPPED); goto out; } Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 2/3] clockevents: Restart clockevent device before using it again

2015-03-29 Thread Preeti U Murthy
)) + clockevents_set_state(dev, CLOCK_EVT_STATE_ONESHOT); + if (!tick_program_event( hrtimer_get_expires(ts-sched_timer), 0)) break; Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com -- To unsubscribe from

Re: [PATCH] sched/fair: fix update the nohz.next_balance even if we haven't done any load balance

2015-03-27 Thread Preeti U Murthy
Besides, are we really going to gain measurable performance with this patch? Regards Preeti U Murthy > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH V2] sched: Improve load balancing in the presence of idle CPUs

2015-03-27 Thread Preeti U Murthy
Hi Morten, On 03/27/2015 08:08 PM, Morten Rasmussen wrote: > Hi Preeti, > > On Thu, Mar 26, 2015 at 01:02:44PM +0000, Preeti U Murthy wrote: >> Fix this, by checking if a CPU was woken up to do nohz idle load >> balancing, before it does load balancing upon itself. This way

Re: [PATCH V2] sched: Improve load balancing in the presence of idle CPUs

2015-03-27 Thread Preeti U Murthy
Hi Wanpeng, Jason, On 03/27/2015 10:37 AM, Jason Low wrote: > On Fri, 2015-03-27 at 10:12 +0800, Wanpeng Li wrote: >> Hi Preeti, >> On Thu, Mar 26, 2015 at 06:32:44PM +0530, Preeti U Murthy wrote: >>> >>> 1. An ILB CPU was chosen from the first numa domain to tri

[tip:sched/core] sched: Improve load balancing in the presence of idle CPUs

2015-03-27 Thread tip-bot for Preeti U Murthy
Commit-ID: d4573c3e1c992668f5dcd57d1c2ced56ae9650b9 Gitweb: http://git.kernel.org/tip/d4573c3e1c992668f5dcd57d1c2ced56ae9650b9 Author: Preeti U Murthy AuthorDate: Thu, 26 Mar 2015 18:32:44 +0530 Committer: Ingo Molnar CommitDate: Fri, 27 Mar 2015 09:36:09 +0100 sched: Improve load

[tip:sched/core] sched: Improve load balancing in the presence of idle CPUs

2015-03-27 Thread tip-bot for Preeti U Murthy
Commit-ID: d4573c3e1c992668f5dcd57d1c2ced56ae9650b9 Gitweb: http://git.kernel.org/tip/d4573c3e1c992668f5dcd57d1c2ced56ae9650b9 Author: Preeti U Murthy pre...@linux.vnet.ibm.com AuthorDate: Thu, 26 Mar 2015 18:32:44 +0530 Committer: Ingo Molnar mi...@kernel.org CommitDate: Fri, 27 Mar

Re: [PATCH] sched/fair: fix update the nohz.next_balance even if we haven't done any load balance

2015-03-27 Thread Preeti U Murthy
with this patch? Regards Preeti U Murthy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH V2] sched: Improve load balancing in the presence of idle CPUs

2015-03-27 Thread Preeti U Murthy
Hi Morten, On 03/27/2015 08:08 PM, Morten Rasmussen wrote: Hi Preeti, On Thu, Mar 26, 2015 at 01:02:44PM +, Preeti U Murthy wrote: Fix this, by checking if a CPU was woken up to do nohz idle load balancing, before it does load balancing upon itself. This way we allow idle CPUs across

Re: [PATCH V2] sched: Improve load balancing in the presence of idle CPUs

2015-03-27 Thread Preeti U Murthy
Hi Wanpeng, Jason, On 03/27/2015 10:37 AM, Jason Low wrote: On Fri, 2015-03-27 at 10:12 +0800, Wanpeng Li wrote: Hi Preeti, On Thu, Mar 26, 2015 at 06:32:44PM +0530, Preeti U Murthy wrote: 1. An ILB CPU was chosen from the first numa domain to trigger nohz idle load balancing [Given

Re: [PATCH V2] sched: Improve load balancing in the presence of idle CPUs

2015-03-26 Thread Preeti U Murthy
Hi Wanpeng On 03/27/2015 07:42 AM, Wanpeng Li wrote: > Hi Preeti, > On Thu, Mar 26, 2015 at 06:32:44PM +0530, Preeti U Murthy wrote: >> >> 1. An ILB CPU was chosen from the first numa domain to trigger nohz idle >> load balancing [Given the experiment, upto 6 CPUs per core

[PATCH V2] sched: Improve load balancing in the presence of idle CPUs

2015-03-26 Thread Preeti U Murthy
in quicker spread of load, instead of performing load balancing within the local sched domain hierarchy of the ILB CPU alone under circumstances such as above. Signed-off-by: Preeti U Murthy --- Changes from V1: 1. Added relevant comments 2. Wrapped lines to a fixed width in the changelog kernel

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-26 Thread Preeti U Murthy
/me goes run (and install, its a fairly new box) more benches. I use ebizzy benchmark to test performance regressions. But for this particular patch, I recollect that I did a code walk through to verify the correctness of the patch and not a performance test. Let me run ebizzy against this patch and

[PATCH] sched: Improve load balancing in the presence of idle CPUs

2015-03-26 Thread Preeti U Murthy
which results in quicker spread of load, instead of performing load balancing within the local sched domain hierarchy of the ILB CPU alone under circumstances such as above. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-26 Thread Preeti U Murthy
Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com Preeti, what benchmarks did you use on power8 smt to verify performance? I'm seeing a slight but statistically significant regression on my ivb-ep kernel build when I match the build concurrency to my core count. /me goes run (and install

[PATCH V2] sched: Improve load balancing in the presence of idle CPUs

2015-03-26 Thread Preeti U Murthy
in quicker spread of load, instead of performing load balancing within the local sched domain hierarchy of the ILB CPU alone under circumstances such as above. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- Changes from V1: 1. Added relevant comments 2. Wrapped lines to a fixed width

Re: [PATCH V2] sched: Improve load balancing in the presence of idle CPUs

2015-03-26 Thread Preeti U Murthy
Hi Wanpeng On 03/27/2015 07:42 AM, Wanpeng Li wrote: Hi Preeti, On Thu, Mar 26, 2015 at 06:32:44PM +0530, Preeti U Murthy wrote: 1. An ILB CPU was chosen from the first numa domain to trigger nohz idle load balancing [Given the experiment, upto 6 CPUs per core could be potentially idle

[PATCH] sched: Improve load balancing in the presence of idle CPUs

2015-03-26 Thread Preeti U Murthy
which results in quicker spread of load, instead of performing load balancing within the local sched domain hierarchy of the ILB CPU alone under circumstances such as above. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- kernel/sched/fair.c |3 +-- 1 file changed, 1 insertion

Re: [tip:timers/urgent] timers/tick/broadcast-hrtimer: Fix suspicious RCU usage in idle loop

2015-03-25 Thread Preeti U Murthy
Hi, Can you please add sta...@vger.kernel.org to the Cc? Without the patch, we get RCU warnings during bootup. Hence the patch is important for the stable kernels as well. Regards Preeti U Murthy On 03/23/2015 05:54 PM, tip-bot for Preeti U Murthy wrote: > Commit

Re: [tip:timers/urgent] timers/tick/broadcast-hrtimer: Fix suspicious RCU usage in idle loop

2015-03-25 Thread Preeti U Murthy
Hi, Can you please add sta...@vger.kernel.org to the Cc? Without the patch, we get RCU warnings during bootup. Hence the patch is important for the stable kernels as well. Regards Preeti U Murthy On 03/23/2015 05:54 PM, tip-bot for Preeti U Murthy wrote: Commit-ID

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-24 Thread Preeti U Murthy
Ping. On 03/16/2015 10:22 AM, Preeti U Murthy wrote: > Hi Peter, Ingo, Thomas, > > Can you please take a look at the conversation on this thread ? > This fix is urgent. > > Regards > Preeti U Murthy > > On 03/02/2015 08:26 PM, Peter Zijlstra wrote: >> On Fri,

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-24 Thread Preeti U Murthy
Ping. On 03/16/2015 10:22 AM, Preeti U Murthy wrote: Hi Peter, Ingo, Thomas, Can you please take a look at the conversation on this thread ? This fix is urgent. Regards Preeti U Murthy On 03/02/2015 08:26 PM, Peter Zijlstra wrote: On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U

[tip:timers/urgent] timers/tick/broadcast-hrtimer: Fix suspicious RCU usage in idle loop

2015-03-23 Thread tip-bot for Preeti U Murthy
Commit-ID: a127d2bcf1fbc8c8e0b5cf0dab54f7d3ff50ce47 Gitweb: http://git.kernel.org/tip/a127d2bcf1fbc8c8e0b5cf0dab54f7d3ff50ce47 Author: Preeti U Murthy AuthorDate: Wed, 18 Mar 2015 16:19:27 +0530 Committer: Ingo Molnar CommitDate: Mon, 23 Mar 2015 10:50:05 +0100 timers/tick/broadcast

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-23 Thread Preeti U Murthy
> sibling. We further need to have a child for this to make sense. > > +1. The above is precisely why we need this patch. Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[tip:timers/urgent] timers/tick/broadcast-hrtimer: Fix suspicious RCU usage in idle loop

2015-03-23 Thread tip-bot for Preeti U Murthy
Commit-ID: a127d2bcf1fbc8c8e0b5cf0dab54f7d3ff50ce47 Gitweb: http://git.kernel.org/tip/a127d2bcf1fbc8c8e0b5cf0dab54f7d3ff50ce47 Author: Preeti U Murthy pre...@linux.vnet.ibm.com AuthorDate: Wed, 18 Mar 2015 16:19:27 +0530 Committer: Ingo Molnar mi...@kernel.org CommitDate: Mon, 23 Mar

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-23 Thread Preeti U Murthy
? Yeah, because it makes sense that way? ;-) The we want to move things to the child's sibling, not the parent's sibling. We further need to have a child for this to make sense. +1. The above is precisely why we need this patch. Regards Preeti U Murthy -- To unsubscribe from this list: send

[PATCH V2] tick/broadcast-hrtimer : Fix suspicious RCU usage in idle loop

2015-03-18 Thread Preeti U Murthy
non-idle. As an aside it is helpful to point out that the clock event device that is programmed here is not a per-cpu clock device; it is a pseudo clock device, used by the broadcast framework alone. The per-cpu clock device programming never goes through bc_set_next(). Signed-off-by: Preeti U

[PATCH V2] tick/broadcast-hrtimer : Fix suspicious RCU usage in idle loop

2015-03-18 Thread Preeti U Murthy
non-idle. As an aside it is helpful to point out that the clock event device that is programmed here is not a per-cpu clock device; it is a pseudo clock device, used by the broadcast framework alone. The per-cpu clock device programming never goes through bc_set_next(). Signed-off-by: Preeti U

Re: [PATCH] tick/broadcast-hrtimer : Fix suspicious RCU usage in idle loop

2015-03-16 Thread Preeti U Murthy
On 03/16/2015 08:26 PM, Peter Zijlstra wrote: > On Thu, Mar 05, 2015 at 10:06:30AM +0530, Preeti U Murthy wrote: >> >> On 03/02/2015 08:23 PM, Peter Zijlstra wrote: >>> On Thu, Feb 26, 2015 at 08:52:02AM +0530, Preeti U Murthy wrote: >>>> The hrtimer mode of b

Re: [PATCH] tick/broadcast-hrtimer : Fix suspicious RCU usage in idle loop

2015-03-16 Thread Preeti U Murthy
On 03/16/2015 08:26 PM, Peter Zijlstra wrote: > On Thu, Mar 05, 2015 at 10:06:30AM +0530, Preeti U Murthy wrote: >> >> On 03/02/2015 08:23 PM, Peter Zijlstra wrote: >>> On Thu, Feb 26, 2015 at 08:52:02AM +0530, Preeti U Murthy wrote: >>>> The hrtimer mode of b

Re: [PATCH] tick/broadcast-hrtimer : Fix suspicious RCU usage in idle loop

2015-03-16 Thread Preeti U Murthy
On 03/16/2015 08:26 PM, Peter Zijlstra wrote: On Thu, Mar 05, 2015 at 10:06:30AM +0530, Preeti U Murthy wrote: On 03/02/2015 08:23 PM, Peter Zijlstra wrote: On Thu, Feb 26, 2015 at 08:52:02AM +0530, Preeti U Murthy wrote: The hrtimer mode of broadcast queues hrtimers in the idle entry path

Re: [PATCH] tick/broadcast-hrtimer : Fix suspicious RCU usage in idle loop

2015-03-16 Thread Preeti U Murthy
On 03/16/2015 08:26 PM, Peter Zijlstra wrote: On Thu, Mar 05, 2015 at 10:06:30AM +0530, Preeti U Murthy wrote: On 03/02/2015 08:23 PM, Peter Zijlstra wrote: On Thu, Feb 26, 2015 at 08:52:02AM +0530, Preeti U Murthy wrote: The hrtimer mode of broadcast queues hrtimers in the idle entry path

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-15 Thread Preeti U Murthy
Hi Peter, Ingo, Thomas, Can you please take a look at the conversation on this thread ? This fix is urgent. Regards Preeti U Murthy On 03/02/2015 08:26 PM, Peter Zijlstra wrote: > On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: >> The problem reported in the

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-15 Thread Preeti U Murthy
Hi Peter, Ingo, Thomas, Can you please take a look at the conversation on this thread ? This fix is urgent. Regards Preeti U Murthy On 03/02/2015 08:26 PM, Peter Zijlstra wrote: On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: The problem reported in the changelog

Re: [PATCH] tick/broadcast-hrtimer : Fix suspicious RCU usage in idle loop

2015-03-04 Thread Preeti U Murthy
On 03/02/2015 08:23 PM, Peter Zijlstra wrote: > On Thu, Feb 26, 2015 at 08:52:02AM +0530, Preeti U Murthy wrote: >> The hrtimer mode of broadcast queues hrtimers in the idle entry >> path so as to wakeup cpus in deep idle states. > > Callgraph please.

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-04 Thread Preeti U Murthy
On 03/02/2015 08:26 PM, Peter Zijlstra wrote: > On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: >> The problem reported in the changelog of this patch is causing severe >> regressions very frequently on our machines for certain usecases. It would >> help to

Re: [PATCH] tick/broadcast-hrtimer : Fix suspicious RCU usage in idle loop

2015-03-04 Thread Preeti U Murthy
On 03/02/2015 08:23 PM, Peter Zijlstra wrote: On Thu, Feb 26, 2015 at 08:52:02AM +0530, Preeti U Murthy wrote: The hrtimer mode of broadcast queues hrtimers in the idle entry path so as to wakeup cpus in deep idle states. Callgraph please... cpuidle_idle_call() | clockevents_notify

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-03-04 Thread Preeti U Murthy
On 03/02/2015 08:26 PM, Peter Zijlstra wrote: On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote: The problem reported in the changelog of this patch is causing severe regressions very frequently on our machines for certain usecases. It would help to put in a fix in place first

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-27 Thread Preeti U Murthy
On 02/26/2015 11:01 AM, Preeti U Murthy wrote: > On 02/23/2015 11:03 PM, Nicolas Pitre wrote: >> On Mon, 23 Feb 2015, Nicolas Pitre wrote: >> >>> On Mon, 23 Feb 2015, Peter Zijlstra wrote: >>> >>>> The reported function that fails: bL_switcher_res

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-27 Thread Preeti U Murthy
On 02/26/2015 11:01 AM, Preeti U Murthy wrote: On 02/23/2015 11:03 PM, Nicolas Pitre wrote: On Mon, 23 Feb 2015, Nicolas Pitre wrote: On Mon, 23 Feb 2015, Peter Zijlstra wrote: The reported function that fails: bL_switcher_restore_cpus() is called in the error paths of the former

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-25 Thread Preeti U Murthy
thought it would be best to put them forth. But why are tick devices being shutdown that early ? Is there any specific advantage to this? Taking/handing over tick duties should be done before __cpu_die(), but shutdown of tick devices should be done after this phase. This seems more

[PATCH] tick/broadcast-hrtimer : Fix suspicious RCU usage in idle loop

2015-02-25 Thread Preeti U Murthy
with RCU_NONIDLE which informs RCU that the cpu is momentarily non-idle. Signed-off-by: Preeti U Murthy Reviewed-by: Paul E. McKenney --- kernel/time/tick-broadcast-hrtimer.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/kernel/time/tick-broadcast-hrtimer.c b

[PATCH] tick/broadcast-hrtimer : Fix suspicious RCU usage in idle loop

2015-02-25 Thread Preeti U Murthy
with RCU_NONIDLE which informs RCU that the cpu is momentarily non-idle. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com Reviewed-by: Paul E. McKenney paul...@linux.vnet.ibm.com --- kernel/time/tick-broadcast-hrtimer.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-25 Thread Preeti U Murthy
devices should be done after this phase. This seems more natural, doesn't it? Regards Preeti U Murthy Nicolas -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-18 Thread Preeti U Murthy
On 02/18/2015 06:36 PM, Peter Zijlstra wrote: > On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote: >> >> Look at the changelog, > > Heh, yah, clearly I tl;dr'd that. Indeed. > >> it explains why tick_takeover must be called >> *before* _

[RESEND PATCH] driver/cpuidle-powernv: Avoid endianness conversions while parsing DT

2015-02-18 Thread Preeti U Murthy
We currently read the information about idle states from the DT so as to populate the cpuidle table. Use those APIs to read from the DT that can avoid endianness conversions of the property values in the cpuidle driver. Signed-off-by: Preeti U Murthy Acked-by: Michael Ellerman --- Based on top

[RESEND PATCH] driver/cpuidle-powernv: Avoid endianness conversions while parsing DT

2015-02-18 Thread Preeti U Murthy
We currently read the information about idle states from the DT so as to populate the cpuidle table. Use those APIs to read from the DT that can avoid endianness conversions of the property values in the cpuidle driver. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com Acked-by: Michael

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-18 Thread Preeti U Murthy
On 02/18/2015 06:36 PM, Peter Zijlstra wrote: On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote: Look at the changelog, Heh, yah, clearly I tl;dr'd that. Indeed. it explains why tick_takeover must be called *before* __cpu_die(). Since you reported this, can you test

Re: [PATCH V4] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-17 Thread Preeti U Murthy
On 02/18/2015 11:21 AM, Rafael J. Wysocki wrote: > On Wednesday, February 18, 2015 10:13:23 AM Preeti U Murthy wrote: >> >> On 02/17/2015 11:23 PM, Rafael J. Wysocki wrote: >>> On Tuesday, February 17, 2015 01:29:10 PM Preeti U Murthy wrote: >>>> Hi Rafael,

Re: [PATCH V4] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-17 Thread Preeti U Murthy
On 02/17/2015 11:23 PM, Rafael J. Wysocki wrote: > On Tuesday, February 17, 2015 01:29:10 PM Preeti U Murthy wrote: >> Hi Rafael, > > Hi, > >> Can you please pull this patch ? > > Sorry, I wasn't sure whether or not the patch was for me to take and then > I'v

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-17 Thread Preeti U Murthy
On 02/17/2015 04:09 PM, Peter Zijlstra wrote: >> [PATCH 11/35] clockevents: Cleanup dead cpu explicitely n Tue, Feb 17, 2015 at 09:33:45AM +0530, Preeti U Murthy wrote: >> On 02/16/2015 05:45 PM, Peter Zijlstra wrote: >> >>>> From: Thomas Gleixner >> >&

Re: [PATCH V4] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-17 Thread Preeti U Murthy
Hi Rafael, Can you please pull this patch ? Another patch based on top of this is waiting to be pulled: [PATCH] driver/cpuidle-powernv: Avoid endianness conversions while parsing DT Regards Preeti U Murthy On 02/03/2015 11:50 AM, Preeti U Murthy wrote: > The device tree now expo

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-17 Thread Preeti U Murthy
On 02/17/2015 04:09 PM, Peter Zijlstra wrote: [PATCH 11/35] clockevents: Cleanup dead cpu explicitely n Tue, Feb 17, 2015 at 09:33:45AM +0530, Preeti U Murthy wrote: On 02/16/2015 05:45 PM, Peter Zijlstra wrote: From: Thomas Gleixner t...@linutronix.de @@ -428,7 +428,7 @@ static int __ref

Re: [PATCH V4] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-17 Thread Preeti U Murthy
On 02/18/2015 11:21 AM, Rafael J. Wysocki wrote: On Wednesday, February 18, 2015 10:13:23 AM Preeti U Murthy wrote: On 02/17/2015 11:23 PM, Rafael J. Wysocki wrote: On Tuesday, February 17, 2015 01:29:10 PM Preeti U Murthy wrote: Hi Rafael, Hi, Can you please pull this patch ? Sorry

Re: [PATCH V4] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-17 Thread Preeti U Murthy
On 02/17/2015 11:23 PM, Rafael J. Wysocki wrote: On Tuesday, February 17, 2015 01:29:10 PM Preeti U Murthy wrote: Hi Rafael, Hi, Can you please pull this patch ? Sorry, I wasn't sure whether or not the patch was for me to take and then I've been traveling lately. Applied now. Hi

Re: [PATCH V4] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-17 Thread Preeti U Murthy
Hi Rafael, Can you please pull this patch ? Another patch based on top of this is waiting to be pulled: [PATCH] driver/cpuidle-powernv: Avoid endianness conversions while parsing DT Regards Preeti U Murthy On 02/03/2015 11:50 AM, Preeti U Murthy wrote: The device tree now exposes the residency

Re: [PATCH V4] tick/hotplug: Handover time related duties before cpu offline

2015-02-16 Thread Preeti U Murthy
On 02/17/2015 07:28 AM, Michael Ellerman wrote: > On Sat, 2015-01-31 at 09:44 +0530, Preeti U Murthy wrote: >> These duties include do_timer to update jiffies and broadcast wakeups on >> those >> platforms which do not have an external device to handle wakeup of cpus from &

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-16 Thread Preeti U Murthy
dead_cpu(cpu); >>+ tick_takeover(cpu); Why is tick_handover() called after __cpu_die()? And the function tick_takeover() is not introduced until the next patch. tick_broadcast_takeover_bc() is the function used instead in this patch. Regards Preeti U Murthy -- To unsubscribe from t

Re: [PATCH 33/35] tick: Make hrtimer broadcasting opt-in

2015-02-16 Thread Preeti U Murthy
On 02/16/2015 05:45 PM, Peter Zijlstra wrote: Reviewed-by: Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please re

Re: [PATCH 33/35] tick: Make hrtimer broadcasting opt-in

2015-02-16 Thread Preeti U Murthy
On 02/16/2015 05:45 PM, Peter Zijlstra wrote: Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V4] tick/hotplug: Handover time related duties before cpu offline

2015-02-16 Thread Preeti U Murthy
On 02/17/2015 07:28 AM, Michael Ellerman wrote: On Sat, 2015-01-31 at 09:44 +0530, Preeti U Murthy wrote: These duties include do_timer to update jiffies and broadcast wakeups on those platforms which do not have an external device to handle wakeup of cpus from deep idle states

Re: [PATCH 32/35] clockevents: Fix cpu down race for hrtimer based broadcasting

2015-02-16 Thread Preeti U Murthy
); + tick_takeover(cpu); Why is tick_handover() called after __cpu_die()? And the function tick_takeover() is not introduced until the next patch. tick_broadcast_takeover_bc() is the function used instead in this patch. Regards Preeti U Murthy -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v2] clockevents: Introduce mode specific callbacks

2015-02-12 Thread Preeti U Murthy
print_name_offset(m, dev->set_mode); > + SEQ_printf(m, "\n"); > + } else { > + if (dev->set_mode_shutdown) { > + SEQ_printf(m, " shutdown: "); > + print_name_offset(m, dev->set_mode_shutdown); > +

Re: [PATCH v2] clockevents: Introduce mode specific callbacks

2015-02-12 Thread Preeti U Murthy
, \n); + } + } SEQ_printf(m, event_handler: ); print_name_offset(m, dev-event_handler); Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-11 Thread Preeti U Murthy
On 02/09/2015 11:44 PM, Steven Noonan wrote: > On Mon, Feb 9, 2015 at 9:56 AM, Steven Noonan wrote: >> On Mon, Feb 9, 2015 at 3:51 AM, Preeti U Murthy >> wrote: >>> Hi Steven, >>> >>> On 02/09/2015 01:02 PM, Steven Noonan wrote: >>>> On Su

Re: [RFCv3 PATCH 01/48] sched: add utilization_avg_contrib

2015-02-11 Thread Preeti U Murthy
ontrib - old_contrib; When the entity is not a task, shouldn't the utilization_avg_contrib be updated like this : se->avg.utilization_avg_contrib = group_cfs_rq(se)->utilization_load_avg ? and then the delta with old_contrib be passed ? Or is this being updated someplace that I have missed ? Regards Pre

Re: [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-11 Thread Preeti U Murthy
On 02/09/2015 11:44 PM, Steven Noonan wrote: On Mon, Feb 9, 2015 at 9:56 AM, Steven Noonan ste...@uplinklabs.net wrote: On Mon, Feb 9, 2015 at 3:51 AM, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: Hi Steven, On 02/09/2015 01:02 PM, Steven Noonan wrote: On Sun, Feb 8, 2015 at 8:49 PM

Re: [RFCv3 PATCH 01/48] sched: add utilization_avg_contrib

2015-02-11 Thread Preeti U Murthy
this : se-avg.utilization_avg_contrib = group_cfs_rq(se)-utilization_load_avg ? and then the delta with old_contrib be passed ? Or is this being updated someplace that I have missed ? Regards Preeti U Murthy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-09 Thread Preeti U Murthy
Hi Steven, On 02/09/2015 01:02 PM, Steven Noonan wrote: > On Sun, Feb 8, 2015 at 8:49 PM, Preeti U Murthy > wrote: >> The powerclamp driver injects idle periods to stay within the thermal >> constraints. >> The driver does a fake idle by spawning per-cpu thr

Re: [PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-09 Thread Preeti U Murthy
Hi Steven, On 02/09/2015 01:02 PM, Steven Noonan wrote: On Sun, Feb 8, 2015 at 8:49 PM, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: The powerclamp driver injects idle periods to stay within the thermal constraints. The driver does a fake idle by spawning per-cpu threads that call

[PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-08 Thread Preeti U Murthy
in this patch is valid. a. This patch exports the functions to set the quota and period of task groups. b. This patch removes the constraint of not being able to set the root task grp's bandwidth. Signed-off-by: Preeti U Murthy --- V1: https://lkml.org/lkml/2014/12/21/23 V1 tried to throttle cfs_rqs

[PATCH V2] idle/intel_powerclamp: Redesign idle injection to use bandwidth control mechanism

2015-02-08 Thread Preeti U Murthy
in this patch is valid. a. This patch exports the functions to set the quota and period of task groups. b. This patch removes the constraint of not being able to set the root task grp's bandwidth. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- V1: https://lkml.org/lkml/2014/12/21/23 V1

[PATCH] arch/cpuidle-powernv: Avoid endianness conversions while parsing DT

2015-02-02 Thread Preeti U Murthy
We currently read the information about idle states from the DT so as to find out the cpu idle states supported by the platform. Use those APIs to read from the DT that can avoid endianness conversions of the property values. Signed-off-by: Preeti U Murthy --- arch/powerpc/platforms/powernv

[PATCH] driver/cpuidle-powernv: Avoid endianness conversions while parsing DT

2015-02-02 Thread Preeti U Murthy
We currently read the information about idle states from the DT so as to populate the cpuidle table. Use those APIs to read from the DT that can avoid endianness conversions of the property values in the cpuidle driver. Signed-off-by: Preeti U Murthy --- This patch is based ontop of the mainline

[PATCH V4] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-02 Thread Preeti U Murthy
does not expose residency values, use default values as a fallback mechanism. While at it, use better APIs to parse the powermgmt device tree node. Signed-off-by: Preeti U Murthy Acked-by: Stewart Smith Acked-by: Michael Ellerman --- Changes from the previous versions: https://lkml.org/lkml/2015/2

Re: [PATCH V3] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-02 Thread Preeti U Murthy
On 02/02/2015 12:09 PM, Michael Ellerman wrote: > On Mon, 2015-02-02 at 10:40 +0530, Preeti U Murthy wrote: >> The device tree now exposes the residency values for different idle states. >> Read >> these values instead of calculating residency from the latency values. The

[PATCH V4] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-02 Thread Preeti U Murthy
does not expose residency values, use default values as a fallback mechanism. While at it, use better APIs to parse the powermgmt device tree node. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com Acked-by: Stewart Smith stew...@linux.vnet.ibm.com Acked-by: Michael Ellerman m

[PATCH] arch/cpuidle-powernv: Avoid endianness conversions while parsing DT

2015-02-02 Thread Preeti U Murthy
We currently read the information about idle states from the DT so as to find out the cpu idle states supported by the platform. Use those APIs to read from the DT that can avoid endianness conversions of the property values. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- arch

[PATCH] driver/cpuidle-powernv: Avoid endianness conversions while parsing DT

2015-02-02 Thread Preeti U Murthy
We currently read the information about idle states from the DT so as to populate the cpuidle table. Use those APIs to read from the DT that can avoid endianness conversions of the property values in the cpuidle driver. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- This patch

Re: [PATCH V3] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-02 Thread Preeti U Murthy
On 02/02/2015 12:09 PM, Michael Ellerman wrote: On Mon, 2015-02-02 at 10:40 +0530, Preeti U Murthy wrote: The device tree now exposes the residency values for different idle states. Read these values instead of calculating residency from the latency values. The values exposed in the DT

[PATCH V3] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-01 Thread Preeti U Murthy
does not expose residency values, use default values as a fallback mechanism. While at it, use better APIs to parse the powermgmt device tree node so as to avoid endianness transformation. Signed-off-by: Preeti U Murthy --- Changes from V2: https://lkml.org/lkml/2015/1/27/1054 1. Used APIs

[tip:sched/core] sched/idle: Add missing checks to the exit condition of cpu_idle_poll()

2015-02-01 Thread tip-bot for Preeti U Murthy
Commit-ID: ff6f2d29bd31cdfa1ac494a8b26d2af8ba887d59 Gitweb: http://git.kernel.org/tip/ff6f2d29bd31cdfa1ac494a8b26d2af8ba887d59 Author: Preeti U Murthy AuthorDate: Wed, 21 Jan 2015 16:27:25 +0530 Committer: Ingo Molnar CommitDate: Fri, 30 Jan 2015 19:38:52 +0100 sched/idle: Add missing

[tip:sched/core] sched/idle: Add missing checks to the exit condition of cpu_idle_poll()

2015-02-01 Thread tip-bot for Preeti U Murthy
Commit-ID: ff6f2d29bd31cdfa1ac494a8b26d2af8ba887d59 Gitweb: http://git.kernel.org/tip/ff6f2d29bd31cdfa1ac494a8b26d2af8ba887d59 Author: Preeti U Murthy pre...@linux.vnet.ibm.com AuthorDate: Wed, 21 Jan 2015 16:27:25 +0530 Committer: Ingo Molnar mi...@kernel.org CommitDate: Fri, 30 Jan

[PATCH V3] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-02-01 Thread Preeti U Murthy
does not expose residency values, use default values as a fallback mechanism. While at it, use better APIs to parse the powermgmt device tree node so as to avoid endianness transformation. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- Changes from V2: https://lkml.org/lkml/2015/1/27

[PATCH V4] tick/hotplug: Handover time related duties before cpu offline

2015-01-30 Thread Preeti U Murthy
the broadcast timer upon itself so as to seamlessly continue both these operations. It fixes the bug reported here: http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html Signed-off-by: Preeti U Murthy --- Changes from V3: https://lkml.org/lkml/2015/1/20/236 1. Move handover of broadcast

[PATCH V4] tick/hotplug: Handover time related duties before cpu offline

2015-01-30 Thread Preeti U Murthy
the broadcast timer upon itself so as to seamlessly continue both these operations. It fixes the bug reported here: http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- Changes from V3: https://lkml.org/lkml/2015/1/20/236 1

Re: [PATCH] cpuidle/powernv: Enter fastsleep on checking if deep idle states are allowed

2015-01-29 Thread Preeti U Murthy
On 09/15/2014 02:22 PM, Preeti U Murthy wrote: > On 09/15/2014 12:29 PM, Michael Ellerman wrote: >> On Fri, 2014-09-12 at 16:31 +0530, Preeti U Murthy wrote: >>> Today the procfs interface /proc/sys/kernel/powersave-nap is used to control >>> entry into deep idle

Re: [PATCH] cpuidle/powernv: Enter fastsleep on checking if deep idle states are allowed

2015-01-29 Thread Preeti U Murthy
On 09/15/2014 02:22 PM, Preeti U Murthy wrote: On 09/15/2014 12:29 PM, Michael Ellerman wrote: On Fri, 2014-09-12 at 16:31 +0530, Preeti U Murthy wrote: Today the procfs interface /proc/sys/kernel/powersave-nap is used to control entry into deep idle states beyond snooze. Check for the value

Re: [PATCH V3] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-28 Thread Preeti U Murthy
On 01/29/2015 03:01 AM, Richard Cochran wrote: > On Wed, Jan 28, 2015 at 03:32:58PM +0530, Preeti U Murthy wrote: >> Thomas ping. Would you be posting this patch? > > FYI, Thomas is temporarily out of action, in bed with the flu. Oh I am sorry to hear that! Let me post ou

Re: [PATCH V3] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-28 Thread Preeti U Murthy
On 01/27/2015 09:01 AM, Preeti U Murthy wrote: > On 01/22/2015 04:45 PM, Thomas Gleixner wrote: >> On Thu, 22 Jan 2015, Preeti U Murthy wrote: >>> On 01/21/2015 05:16 PM, Thomas Gleixner wrote: >>> How about when the cpu that is going offline receives a timer interrupt

Re: [PATCH V2] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-01-28 Thread Preeti U Murthy
On 01/28/2015 02:45 PM, Stewart Smith wrote: > Preeti U Murthy writes: >> The device tree now exposes the residency values for different idle states. >> Read >> these values instead of calculating residency from the latency values. The >> values >> exposed in

Re: [PATCH V2] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-01-28 Thread Preeti U Murthy
On 01/28/2015 02:45 PM, Stewart Smith wrote: Preeti U Murthy pre...@linux.vnet.ibm.com writes: The device tree now exposes the residency values for different idle states. Read these values instead of calculating residency from the latency values. The values exposed in the DT are validated

Re: [PATCH V3] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-28 Thread Preeti U Murthy
On 01/27/2015 09:01 AM, Preeti U Murthy wrote: On 01/22/2015 04:45 PM, Thomas Gleixner wrote: On Thu, 22 Jan 2015, Preeti U Murthy wrote: On 01/21/2015 05:16 PM, Thomas Gleixner wrote: How about when the cpu that is going offline receives a timer interrupt just before setting its state

Re: [PATCH V3] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-28 Thread Preeti U Murthy
On 01/29/2015 03:01 AM, Richard Cochran wrote: On Wed, Jan 28, 2015 at 03:32:58PM +0530, Preeti U Murthy wrote: Thomas ping. Would you be posting this patch? FYI, Thomas is temporarily out of action, in bed with the flu. Oh I am sorry to hear that! Let me post out a patch based on Thomas's

[PATCH V2] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-01-27 Thread Preeti U Murthy
does not expose residency values, use default values as a fallback mechanism. While at it, handle some cleanups. Signed-off-by: Preeti U Murthy --- Changes from V1: https://lkml.org/lkml/2015/1/19/221 1. Used a better API for reading the DT property values. 2. Code cleanups drivers/cpuidle

[PATCH V2] cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-01-27 Thread Preeti U Murthy
does not expose residency values, use default values as a fallback mechanism. While at it, handle some cleanups. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- Changes from V1: https://lkml.org/lkml/2015/1/19/221 1. Used a better API for reading the DT property values. 2. Code cleanups

Re: cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-01-26 Thread Preeti U Murthy
On 01/23/2015 10:29 AM, Michael Ellerman wrote: > On Tue, 2015-20-01 at 11:26:49 UTC, Preeti U Murthy wrote: >> @@ -177,34 +178,39 @@ static int powernv_add_idle_states(void) >> return nr_idle_states; >> } >> >> -idle_state_la

Re: [PATCH V3] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-26 Thread Preeti U Murthy
On 01/22/2015 04:45 PM, Thomas Gleixner wrote: > On Thu, 22 Jan 2015, Preeti U Murthy wrote: >> On 01/21/2015 05:16 PM, Thomas Gleixner wrote: >> How about when the cpu that is going offline receives a timer interrupt >> just before setting its state to CPU_DEAD ? That is

Re: cpuidle/powernv: Read target_residency value of idle states from DT if available

2015-01-26 Thread Preeti U Murthy
On 01/23/2015 10:29 AM, Michael Ellerman wrote: On Tue, 2015-20-01 at 11:26:49 UTC, Preeti U Murthy wrote: @@ -177,34 +178,39 @@ static int powernv_add_idle_states(void) return nr_idle_states; } -idle_state_latency = of_get_property(power_mgt

Re: [PATCH V3] tick/broadcast: Make movement of broadcast hrtimer robust against hotplug

2015-01-26 Thread Preeti U Murthy
On 01/22/2015 04:45 PM, Thomas Gleixner wrote: On Thu, 22 Jan 2015, Preeti U Murthy wrote: On 01/21/2015 05:16 PM, Thomas Gleixner wrote: How about when the cpu that is going offline receives a timer interrupt just before setting its state to CPU_DEAD ? That is still possible right given

<    1   2   3   4   5   6   7   8   9   10   >