Re: [PATCH v2 2/4] rtc: Add support for the MediaTek MT2712 RTC

2019-08-23 Thread Ran Bi
On Thu, 2019-08-22 at 15:36 +0200, Alexandre Belloni wrote: > On 22/08/2019 21:26:01+0800, Ran Bi wrote: > > On Thu, 2019-08-22 at 14:46 +0200, Alexandre Belloni wrote: > > > On 22/08/2019 20:34:14+0800, Ran Bi wrote: > > > > > > + /* RTC need POWERKEY1

Re: [PATCH v2 1/4] bindings: rtc: add bindings for MT2712 RTC

2019-08-23 Thread Ran Bi
Hi, > > +Required properties: > > +- compatible : Should be "mediatek,mt2712-rtc" : for MT2712 SoC > > +- reg : Specifies base physical address and size of the > > registers; > > +- interrupts : Should contain the interrupt for RTC alarm; > > No clocks for

Re: [PATCH v2 2/4] rtc: Add support for the MediaTek MT2712 RTC

2019-08-22 Thread Ran Bi
On Thu, 2019-08-22 at 14:46 +0200, Alexandre Belloni wrote: > On 22/08/2019 20:34:14+0800, Ran Bi wrote: > > > > + /* RTC need POWERKEY1/2 match, then goto normal work mode */ > > > > + mt2712_writel(rtc, MT2712_POWERKEY1, MT2712_POWERKEY1_KEY); > &

Re: [PATCH v2 2/4] rtc: Add support for the MediaTek MT2712 RTC

2019-08-22 Thread Ran Bi
Hi, > > + > > +#define MTK_RTC_DEVKBUILD_MODNAME > > You probably shouldn't do that and have a static string for the driver > name. I probably doesn't matter much though because DT is used to probe > the driver. > Will change it at next patch. > > +/* we map HW YEAR 0 to 2000

Re: [PATCH v2 2/4] rtc: Add support for the MediaTek MT2712 RTC

2019-08-22 Thread Ran Bi
On Thu, 2019-08-22 at 11:20 +0200, Alexandre Belloni wrote: > On 22/08/2019 11:12:29+0200, Matthias Brugger wrote: > > > > > > On 01/08/2019 13:01, Ran Bi wrote: > > > This add support for the MediaTek MT2712 RTC. It was SoC based RTC, but > > > had diff

Re: [PATCH v2 2/4] rtc: Add support for the MediaTek MT2712 RTC

2019-08-22 Thread Ran Bi
On Thu, 2019-08-22 at 11:12 +0200, Matthias Brugger wrote: > > On 01/08/2019 13:01, Ran Bi wrote: > > This add support for the MediaTek MT2712 RTC. It was SoC based RTC, but > > had different architecture compared with MT7622 RTC. > > > > Signed-off-by: Ran Bi &g

Re: [PATCH v4 10/10] rtc: Add support for the MediaTek MT6358 RTC

2019-08-06 Thread Ran Bi
Hi Belloni, On Mon, 2019-08-05 at 09:23 +0200, Alexandre Belloni wrote: > Hi, > > The subject should be: > > "rtc: mt6397: Add support for the MediaTek MT6358 RTC" Will be changed at next patch. > > +struct mtk_rtc_compatible { > > I would name that struct mtk_rtc_data > > > + u32

[PATCH v2 2/4] rtc: Add support for the MediaTek MT2712 RTC

2019-08-01 Thread Ran Bi
This add support for the MediaTek MT2712 RTC. It was SoC based RTC, but had different architecture compared with MT7622 RTC. Signed-off-by: Ran Bi --- drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile | 1 + drivers/rtc/rtc-mt2712.c | 444 +++ 3

[PATCH v2 4/4] MAINTAINERS: add MT2712 RTC files

2019-08-01 Thread Ran Bi
This patch add MT2712 RTC related files to MAINTAINERS. Signed-off-by: Ran Bi --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 783569e3c4b4..11f73a4c75eb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1892,7 +1892,9 @@ M:Sean Wang L

[PATCH v2 3/4] arm64: dts: add RTC nodes for MT2712

2019-08-01 Thread Ran Bi
This patch add device node for MT2712 RTC. Signed-off-by: Ran Bi --- arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi index 43307bad3f0d..31166c17c39a 100644

[PATCH v2 0/4] Add Support for MediaTek MT2712 RTC

2019-08-01 Thread Ran Bi
of functions 6. use devm_request_threaded_irq() to replace request_threaded_irq() 7. add mt2712 rtc related files into MAINTAINERS Ran Bi (4): bindings: rtc: add bindings for MT2712 RTC rtc: Add support for the MediaTek MT2712 RTC arm64: dts: add RTC nodes for MT2712 MAINTAINERS: add

[PATCH v2 1/4] bindings: rtc: add bindings for MT2712 RTC

2019-08-01 Thread Ran Bi
Document the binding for MT2712 RTC implemented by rtc-mt2712. Signed-off-by: Ran Bi Reviewed-by: Rob Herring --- .../devicetree/bindings/rtc/rtc-mt2712.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/rtc-mt2712.txt

Re: [PATCH 2/3] rtc: Add support for the MediaTek MT2712 RTC

2019-07-17 Thread Ran Bi
un out, RTC will lost it's registers value and time data at next boot up. We even cannot know what the date and time it shows. We want to check this state here and set a default RTC date. Do you think it's no need here and the date should be set by system? > > + ret = request_threaded_irq(rtc->irq, NULL, > > devm_request_threaded_irq would remove the need for out_free_irq and > mtk_rtc_remove(). > Will change it at next patch. And will remove mtk_rtc_remove() function. -- Ran Bi, MediaTek

Re: [PATCH v2 5/7] power: reset: add driver for mt6323 poweroff

2019-07-04 Thread Ran Bi
On Wed, 2019-07-03 at 18:48 +0200, Frank Wunderlich wrote: > From: Josef Friedl > > Suggested-by: Frank Wunderlich > Signed-off-by: Josef Friedl > Signed-off-by: Frank Wunderlich > --- > drivers/power/reset/Kconfig | 10 +++ > drivers/power/reset/Makefile | 1 + >

[PATCH 0/3] Add Support for MediaTek MT2712 RTC

2019-07-01 Thread Ran Bi
This patchset add support to MT2712 RTC. MT2712 RTC is a SoC based RTC with different architecture compared to MT7622 RTC. Ran Bi (3): bindings: rtc: add bindings for MT2712 RTC rtc: Add support for the MediaTek MT2712 RTC arm64: dts: add rtc nodes for MT2712 .../devicetree/bindings/rtc

[PATCH 1/3] bindings: rtc: add bindings for MT2712 RTC

2019-07-01 Thread Ran Bi
Document the binding for MT2712 RTC implemented by rtc-mt2712. Signed-off-by: Ran Bi --- .../devicetree/bindings/rtc/rtc-mt2712.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/rtc-mt2712.txt diff --git a/Documentation

[PATCH 3/3] arm64: dts: add rtc nodes for MT2712

2019-07-01 Thread Ran Bi
This patch add device node for MT2712 rtc. Signed-off-by: Ran Bi --- arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi index 43307bad3f0d..31166c17c39a 100644

[PATCH 2/3] rtc: Add support for the MediaTek MT2712 RTC

2019-07-01 Thread Ran Bi
This add support for the MediaTek MT2712 RTC. It was SoC based RTC, but had different architecture compared with MT7622 RTC. Signed-off-by: Ran Bi --- drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile | 1 + drivers/rtc/rtc-mt2712.c | 495 +++ 3

Re: [PATCH v3 08/10] arm64: dts: mt6358: add PMIC MT6358 related nodes

2019-05-08 Thread Ran Bi
On Fri, 2019-05-03 at 17:31 +0800, Hsin-Hsiung Wang wrote: > add PMIC MT6358 related nodes which is for MT8183 platform > > Signed-off-by: Hsin-Hsiung Wang > --- > arch/arm64/boot/dts/mediatek/mt6358.dtsi | 358 +++ > 1 file changed, 358 insertions(+) > create mode 100644