On Tue, Feb 19, 2008 at 09:22:27AM -0800, H. Peter Anvin wrote:
> Rasmus Andersen wrote:
[...]
> You have at least one file on a device mapper device (possibly an LVM
> module), and LILO doesn't understand it.
Hi Peter, and thanks for your reply. That was indeed the issue, my
Hello,
I have just upgraded from 2.6.22 to 2.6.24.2 and after booting into the
new kernel and seeing that everything went right, I wanted to make the
new kernel the default boot kernel. But running LILO I got
Fatal: Linux experimental device 0x04x needs to be defined.
Check 'man lilo.conf'
Hello,
I was hoping that you could help me interpret these SATA errors from my
brand new Western Digital disk (at end). Also, this disk seems to refuse
smart commands:
# smartctl -s on -o on -S on /dev/sda
smartctl version 5.37 [i686-pc-linux-gnu] Copyright (C) 2002-6 Bruce
Allen
Home page is ht
On Mon, May 28, 2007 at 11:57:55AM +0200, Rasmus Andersen wrote:
> My main problem is that a check/repair run of my RAID1 device reports
> errors. Not always the same number of errors and not monotonously
> increasing. It has not always been like this but I have not been able to
> link
Hello,
I have for some time been facing some RAID1 issues which I finally have
been able to take the time to write about. I hope you can help me shed
some light on this.
My main problem is that a check/repair run of my RAID1 device reports
errors. Not always the same number of errors and not mono
Hello,
Let me first start by saying that if a better place to ask these
quesions is to be found, please let me know.
I have a 2.6.20 kernel running a raid 1 set with two SATA disks.
Recently (on an older (gentoo-specific) kernel) I started getting
entries like this after my weekly 'echo check >
/
Hi.
The following patch makes drivers/net/tokenring/ibmtr.c
call iounmap before it returns on error paths, makes it
not use check_region(), makes it check the return
of request_region and init_trdev and adds a few comment
strings on #endifs.
It applies against 246ac5 and my writing this patch w
On Sun, Jun 24, 2001 at 07:14:00PM -0400, Michael H. Warfield wrote:
[...]
> I'm responsible for the kernel / driver integration end of it
> anyways.
>
> I'll find out what's up with Doug, but this is my issue to deal
> with anyways. And yes, I'm looking at it. I've got a couple of
On Sun, Jun 24, 2001 at 07:14:00PM -0400, Michael H. Warfield wrote:
> On Sun, Jun 24, 2001 at 11:06:06PM +0200, Rasmus Andersen wrote:
> > Hi.
>
> > (My last mail to [EMAIL PROTECTED] bounced. Is there another
> > maintainer for drivers/char/ip2main.c somewhere?)
&
Hi.
The patch below adds a check for create_proc_entry return code
in drivers/media/video/videodev.c. It applies against 245-ac16
and 246p6.
--- linux-245-ac16-clean/drivers/media/video/videodev.c Sun May 27 22:15:23 2001
+++ linux-245-ac16/drivers/media/video/videodev.c Sun Jun 24 23:33:
Hi.
The following patch tries to avoid a potential null pointer
dereference. It applies against 245-ac16 and 246p6. The
dereference was originally reported by the Stanford team.
--- linux-245-ac16-clean/drivers/media/video/i2c-parport.c Thu Jul 13 01:24:33
2000
+++ linux-245-ac16/drivers/
Hi.
(My last mail to [EMAIL PROTECTED] bounced. Is there another
maintainer for drivers/char/ip2main.c somewhere?)
The patch below tries to avoid dereferencing (potential)
NULL pointers. It was reported by the Stanford team way
back and applies against 245ac16 and 246p6. It could
probably be don
On Sun, Jun 24, 2001 at 10:52:31PM +0200, Eric Lammerts wrote:
[...]
> There are zillions of functions called 'init_module' in the kernel.
> I think my suggestion was better (and it had a \n at the end!)
Agreed. Actually, 'ouch' on point two :) BTW, was it intentional
that you dropped the mainta
On Sat, Jun 23, 2001 at 02:30:06PM -0300, Arnaldo Carvalho de Melo wrote:
[...]
> printk(KERN_ERR __FUNCTION__ "Out of memory.");
>
> Then if you move the code to other function or if you change the name of
> the function you don't have to go all over the code doing
> s/old_function_name/new_fun
Hi.
The following patch adds some checks for kmalloc returning NULL
to fs/jffs/intrep.c along with some way of getting that propagated
back. Applies against 245ac16 and 246p5. These dereferences were
reported by the Stanford team a way back.
--- linux-245-ac16-clean/fs/jffs/intrep.c Thu J
Hi.
The patch below adds a kmalloc check to drivers/pcmcmia/rsrc_mgr.c.
Against 245-ac16 but aplies to 256p6 also. Reported a while back
by the stanford team.
--- linux-245-ac16-clean/drivers/pcmcia/rsrc_mgr.c Sat May 19 20:59:21 2001
+++ linux-245-ac16/drivers/pcmcia/rsrc_mgr.cSat Ju
On Fri, Jun 22, 2001 at 05:21:06PM -0300, Arnaldo Carvalho de Melo wrote:
> Hi Rasmus,
>
> I've fixed this ones and its already in 2.4.6-pre5, please take a
> look and see if something is missing.
These patches are very close so I'll of course retract mine[1].
The only thing I'll recommend
Hi.
The patch below adds one instance of vmalloc return code checking
and a number of error path resource release cleanups in build_maps.
It is against 245-ac16.
(The vmalloc non-check was reported by the Stanford team a
while back.)
--- linux-245-ac16-clean/drivers/mtd/ftl.c Sun May 27
Hi.
The following patch #ifdefs a function to be in its preprocessor
scope and eliminates the use of check_region, adds '\n' to printk's,
adds checks for kmalloc and does error path resource releasing
in ip2_init_board. All in drivers/char/ip2main.c and against
245ac16.
(The kmalloc part of this
On Tue, Jun 19, 2001 at 10:41:51AM +0100, Jeremy Sanders wrote:
> I've found a patch which fixes the hanging problem, so I guess it's not
> linux-kernel which is at fault. Get it from Wayne Davison at:
Works for me too.
--
Rasmus([EMAIL PROTECTED])
"Men kick friendship around like a
On Tue, Jun 12, 2001 at 11:23:02AM -0400, Disconnect wrote:
> On Tue, 12 Jun 2001, David S. Miller did have cause to say:
>
> > Look everyone, it was determined to be a deadlock because of some
> > interaction between how rsync sets up it's communication channels
> > with the ssh subprocess, read
On Tue, Jun 12, 2001 at 02:59:12PM +0100, Jeremy Sanders wrote:
> I'm getting numerous rsync (v2.4.6) problems under Linux 2.4.2 (RedHat
> 7.1) or stock 2.4.4 on several machines. rsync often hangs copying files
> from NFS or local disks to local disks. Strangely the problem is fixed by
> stracing
Hi.
The patch below fixes what I believe is a bug in hysdn_net.c.
I cannot see how we can proceed under _any_ circumstances
after the kmalloc fails. Applies against 245ac1.
--- linux-245-ac1-clean/drivers/isdn/hysdn/hysdn_net.c Sun May 27 22:15:22 2001
+++ linux-245-ac1/drivers/isdn/hysdn/hysd
(Forgot l-k again... :<)
- Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> -
Hi.
The following patch removes two superfluous initializations
from aironet4500_proc.c, making the .o ~12K smaller in
size. It applies against 245ac1 and was discovered by Adam
Ritcher
Hi.
The following patch makes irttp_read_proc restore_flags()
in error cases too. Applies against 245ac1.
--- linux-245-ac1-clean/net/irda/irttp.cSun May 27 22:15:34 2001
+++ linux-245-ac1/net/irda/irttp.c Sun May 27 22:37:59 2001
@@ -1598,7 +1598,7 @@
self = (struct tsap_c
Hi.
The following patch fixes an interrupt flag bug in irtty.c
as per the stanford team's report way back. Applies against
224-ac18.
--- linux-244-ac18-clean/drivers/net/irda/irtty.c Sat May 19 20:59:17 2001
+++ linux-244-ac18/drivers/net/irda/irtty.c Sun May 27 21:56:14 2001
@@ -971,
Hi.
The following patch adds a missing restore_flags as per the
stanford team's report way back. Applies against 244ac18.
--- linux-244-ac18-clean/drivers/net/hamradio/soundmodem/sm_wss.c Wed Jul 19
01:55:19 2000
+++ linux-244-ac18/drivers/net/hamradio/soundmodem/sm_wss.c Sun May 27
Forgot l-k when sending this off..
- Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> -
Hi.
The following patch fixes a missing rio_spin_unlock_irqrestore
in drivers/char/rio/rioroute.c as per the stanford team's
report a way back. It applies against 244ac18.
--
Forgot l-k when sending this off...
- Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> -
Hi.
The following patch fixes a buggy variable reuse i drivers/char/
rio/riotable.c (244-ac18) as reported by the stanford team way
back.
--- linux-244-ac18-clean/drivers/ch
(Forgot l-k when sending this off to [EMAIL PROTECTED] :/)
Hi.
The following patch tries to eliminate the interrupt flag bugs
identified by the stanford team a while back in drivers/net/wan/
comx-hw-mixcom.c. It moves request_region and request_irq outside
the cli()/restore_flags() pair as they
Hi.
The following patch tries to correct the interrupt bugs found
by the stanford team a long time ago in drivers/net/irda/irport.c.
Applies against 2.4.4-ac18.
--- linux-244-ac18-clean/drivers/net/irda/irport.c Sat May 19 20:59:17 2001
+++ linux-244-ac18/drivers/net/irda/irport.cSat M
On Fri, May 25, 2001 at 11:11:23PM +0200, Jens Axboe wrote:
[...]
> This isn't right. Granted the locking isn't straight forward here, but
> take a look at ide_write_setting -> ide_spin_wait_hwgroup and the
> latters return value.
Yes, Andre set me straight here. My apologies for being lazy and
Hi.
The following patch changes an __init to __initdata. Applies against
2.4.4-ac11.
--- linux-244-ac11-clean/drivers/video/matrox/matroxfb_base.c Sat May 19 20:58:43
2001
+++ linux-244-ac11/drivers/video/matrox/matroxfb_base.c Sun May 20 23:55:24 2001
@@ -2483,7 +2483,7 @@
return 0;
(I forgot to cc l-k on this one when it went to andre.)
Hi.
This patch adds a spin_unlock_irqsave to ide_spin_wait_hwgroup as
reported by the Stanford team way back. It applies against 244ac16.
--- linux-244-ac16-clean/drivers/ide/ide.c Fri May 25 21:11:08 2001
+++ linux-244-ac16/drivers/
On Fri, May 25, 2001 at 01:47:52PM -0700, Andre Hedrick wrote:
>
> Not valid because the jump to that part of the code is protected.
> If a polling response for a valid status and no timeout, is detected then
> it attempts to the command for real only after success or a test.
>
> Otherwise it wo
Hi.
This trivial patch adds a kmalloc check to ide-tape.c::
idetape_onstream_read_back_buffer as per the Stanford team's report
way back. It applies against 244ac16.
Reading the code I was not sure if it was OK to just return
or more should be done. Please sanity check this.
--- linux-244-ac11-
Hi.
The following patch adds a number of checks for kmalloc returns
to drivers/ide/ide-probe.c. It applies against ac16.
One comment: This patch adds 'drive-present = 0' to the
code path for the EXABYTE case. I could not discern if this was a
shortcoming of the original code or not. Please comme
Hi.
This patch adds a check for the return value from kmalloc in
ide_cdrom_open. Applies against ac16.
--- linux-244-ac16-clean/drivers/ide/ide-cd.c Fri May 25 21:11:08 2001
+++ linux-244-ac16/drivers/ide/ide-cd.c Fri May 25 21:30:20 2001
@@ -2869,12 +2869,12 @@
int ide_cdrom_open (struct in
Hi.
The following patch changes an __init to an __initdata. Applies
against 2.4.4-ac16.
--- linux-244-ac16-clean/arch/ppc/kernel/feature.c Sat May 19 21:06:18 2001+++
linux-244-ac16/arch/ppc/kernel/feature.cMon May 21 00:04:35 2001
@@ -267,7 +267,7 @@
static struct board_features_t {
On Thu, May 24, 2001 at 09:00:20AM -0700, Jonathan Lundell wrote:
[...]
>
> Fine. But:
>
> At 3:02 AM +0200 2001-05-24, Andrzej Krzysztofowicz wrote:
> >-printk(version);
> >+#ifdef MODULE
> >+printk("s", version);
> > printed_version = 1;
> >+#endif /* MODULE */
>
> ...is playing i
Hi.
The following trivial patch against 2.4.4(-ac11) makes ps2esdi compile.
--- linux-244-ac10-clean/drivers/block/ps2esdi.cSat May 19 21:06:29 2001
+++ linux-244-ac10/drivers/block/ps2esdi.c Sun May 20 14:47:04 2001
@@ -953,10 +953,10 @@
break;
}
if(
Disclaimer: I know nothing of this device/hw, the scsi protocol or
anything remotely applicable the functioning of this driver. The
stuff below is just nit-picking and PITA-ing :) Pro-active kernel
janitoring, if you like.
On Sat, May 12, 2001 at 11:43:04AM -0500, James Bottomley wrote:
[...]
> +
On Tue, Feb 27, 2001 at 10:02:11AM +, Russell King wrote:
> Hi,
>
> I'm seeing odd behaviour with rsync over ssh between two x86 machines -
> one if the is an UP PIII (Katmai) running 2.4.2 (isdn-gw) and the other
> is an UP Pentium 75-200 (pilt-gw) running 2.2.15pre13 with some custom
> seri
On Sun, Feb 25, 2001 at 02:46:15PM +, Alan Cox wrote:
> > I am sorry but have I inverted the arguments to the memcpy_*io calls?
> > Or are you referring to something other than the arguments here?
>
> You seem to have swapped the source/dest over in memcpy_toio cases and I need
> to convince
>
> Im running PIO. However while I agree with that one Im dubious about the
> inverts on the memcpy_*io bits
>
I am sorry but have I inverted the arguments to the memcpy_*io calls?
Or are you referring to something other than the arguments here?
--
Rasmus([EMAIL PROTECTED])
"Science
On Sun, Feb 25, 2001 at 02:05:42PM +, Alan Cox wrote:
[...]
> > (An indication of how often this code path is used can be found in
> > the fact that the previous define of NCR5380_write had its payload
> > and address mixed up, probably making for wierd results should
> > the code ever be exec
Hi.
(Does anybody know who the maintainer for this code is?)
The patch below moves drivers/scsi/g_NCR5380.c from using isa_{read,
write, memcpy} to ioremap and the equivalent non-isa functions. It
also fixes an 'unused variable' warning and exchanges check_region for
request_region (and fixes a
Hi.
(I have not been able to find a probable current maintainer for
this code.)
The following patch makes drivers/scsi/seagate.c use ioremap
instead of isa_{read, write} (I have not been able to find
a fitting place to put an iounmap since the driver does not
have a release function). The patch
On Mon, Feb 19, 2001 at 11:09:33PM +0100, Rasmus Andersen wrote:
[...]
(I'll just continue talking to myself in the hope that somebody
will read this and be inspired.)
In order to clear things up I should clearly state that my rsync
problem manifests itself under local operation. Ie., &
Hi.
For some time up through the testX kernels I used rsync to
update my "dirty" tree after applying the latest patches to the
clean tree. At some point this stopped working (more about that
later) but as new kernels were coming fast at that time I did
not think much of it, assuming that cleverer
Hi.
This patch tries to fix the potential rss accounting race where we
change mm->rss without holding page_table_lock.
My reasoning for the correctness of the patch below is as follows.
First I cover the lock pairs added by the patch (top to bottom)
and then the places it does not touch.
Adde
On Tue, Jan 30, 2001 at 08:18:56AM +, David Howells wrote:
> >...
> > + spin_lock(&mm->page_table_lock);
> > mm->rss++;
> > + spin_unlock(&mm->page_table_lock);
> >...
>
> Would it not be better to use some sort of atomic add/subtract/clear operation
> rather than a spinlock? (Which w
Hi.
The following patch makes drivers/scsi/sym53c8xx.c and (by way of
sym53c8xx_comm.h::sym53c8xx__detect) ncr53c8xx.c do a
pci_enable_device after finding a device.
It applies against ac12 and 241p11.
Comments?
--- linux-ac11-clean/drivers/scsi/sym53c8xx.c Mon Jan 1 19:23:21 2001
+++ linu
Hi.
(I have not been able to find a probable current maintainer for
this code.)
The following patch makes drivers/scsi/seagate.c use ioremap
instead of isa_{read, write}.
It applies against ac12 and 241p11.
Please comment, esp. on the size of the remappings.
--- linux-ac12-clean/drivers/scsi
(Forgot l-k. Please cc [EMAIL PROTECTED] on replies to this mail.)
- Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> -
Hi.
The following patch makes drivers/scsi/dmx3191d.c call
pci_enable_device before probing resources and replaces
a check_region+request_regio
Hi.
The following patch makes drivers/scsi/eata.c wait with probing
pci resources until we have called pci_enable_device. This is recommended
due to hot-plug considerations (according to Jeff Garzik).
It applies against ac12 and 241p11.
Comments?
--- linux-ac12-clean/drivers/scsi/eata.c
Hi.
The following patch makes drivers/scsi/BusLogic.c wait with probing
pdev->irq and pdev->resource[] until we call pci_enable_device. This
is recommended due to hot-plug considerations (according to Jeff Garzik).
It applies against ac12 and 241p11.
Comments?
--- linux-ac12-clean/drivers/scs
On Mon, Jan 29, 2001 at 07:30:01PM -0200, Rik van Riel wrote:
> On Mon, 29 Jan 2001, Rasmus Andersen wrote:
>
> > Please comment. Or else I will continue to sumbit it :)
>
> The following will hang the kernel on SMP, since you're
> already holding the spinloc
Hi.
This patch tries to fix the potential rss accounting race where we
fiddle with mm->rss without holding the page_table_lock.
In addition to the places this patch touches there are some places
in fs/ where mm->rss is touched. But I am not sure of the finer
points of this code, so perhaps someb
On Mon, Jan 29, 2001 at 02:51:18PM -0600, Timur Tabi wrote:
> ** Reply to message from [EMAIL PROTECTED] on Mon, 29 Jan 2001 20:44:55 + (GMT)
>
>
> > make pdfdocs
>
> [ttabi@one DocBook]$ make pdfdocs
> Makefile:140: /Rules.make: No such file or directory
You have to be in the top level di
On Fri, Jan 26, 2001 at 10:13:35PM +0100, Rasmus Andersen wrote:
> Hi.
[...]
>
> But I am in way over my head here so please be gentle when you point
> out my mistake.
>
Already someone did :) I was too sloppy in checking my facts; it is only
-ac11 that has the 'int nr_io
Hi.
In arch/i386/kernel we declare nr_ioapics in both io_apic.c and mpparse.c.
I guess that one of them should be an 'extern' declaration? In the patch
below I have guessed that it is io_apic.c that is missing it since (AFAICS)
never assign to nr_ioapic in this file.
But I am in way over my hea
Hi.
The following two patches removes an #ifdef CONFIG_PCI in
drivers/parport/parport_pc.c by adding a nop definition of
pci_match_device to include/linux/pci.h. It incidentially
also removes a compiler warning when CONFIG_PCI is not
set.
Applies against ac11 and 241p10 (the latter with a bit o
Hi.
I apparently forgot to cc the lists on this one. Replies should be cc'ed
to [EMAIL PROTECTED] also.
Thanks.
- Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> -
Date: Tue, 23 Jan 2001 23:37:14 +0100
From: Rasmus Andersen <[EMAIL PROTECTED]>
To: [EMAIL P
Hi.
The following patch makes drivers/scsi/wd7000.c use request_region
instead of check_region+request_region. It also drops a panic() and
changes error paths to be forward gotos (in part necessary by the
request_region change).
It applies cleanly against ac10 and 241p9.
Comments?
--- linux-
(Too fast again and forgot to cc the lists. If anyone replies to this
mail, please cc [EMAIL PROTECTED] Thanks.)
- Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> -
Hi.
The following patch makes drivers/scsi/u14-35f.c drop check_region in
favour of checking the retur
(Forgot to cc lk. If anyone have comments please cc [EMAIL PROTECTED]
Thanks.)
- Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> -
Hi.
The following patch makes drives/scsi/tmscsim.c use request_region
instead of check_region+request_region. It applies cleanly agains
Hi.
The following patch adds a check for scsi_register's return code to
drivers/scsi/qlogicisp.c. It applies cleanly against ac10 and 241p9.
Comments?
--- linux-ac10-clean/drivers/scsi/qlogicisp.c Sat Jan 20 15:17:13 2001
+++ linux-ac10/drivers/scsi/qlogicisp.c Sat Jan 20 23:05:47 2001
@@ -6
Hi.
(I am guessing you as the maintainer of this code. If you are not,
I apologize for your inconvenience.)
The following patch makes drivers/scsi/qlogicfc.c check the
return code of scsi_register, adds a missing pci64_free_consistent on
an error path and makes it use request_region exclusively
Hi.
(I have not been able to find a probable maintainer for this code.)
The follow patch makes drivers/scsi/qlogicfas.c use the return code
from request_region instead of a call to check_region. It also
adds a missing free_irq on an error path and makes us check the
return from scsi_register.
I
Hi.
The following patch makes drivers/scsi/qla1280.c use the return code
of request_region instead of a call to check_region. It applies cleanly
against ac10 and 241p9.
Comments?
--- linux-ac10-clean/drivers/scsi/qla1280.c Wed Dec 6 21:06:18 2000
+++ linux-ac10/drivers/scsi/qla1280.c Sa
Hi.
The following patch makes drivers/scsi/ips.c use the return code
of request_region instead of calling check_region. It also moves
some resource freeing to ips_free since that made my error path
cleaner.
It applies cleanly against ac10 and 241p9.
Please comment.
--- linux-ac10-clean/driver
On Tue, Jan 23, 2001 at 12:42:42AM +0100, Rasmus Andersen wrote:
(This is another updated patch with the comments from my earlier mail
still valid.)
--- linux-ac10-clean/drivers/scsi/inia100.c Sun Nov 12 04:01:11 2000
+++ linux-ac10/drivers/scsi/inia100.c Tue Jan 23 21:23:47 2001
On Tue, Jan 23, 2001 at 12:40:26AM +0100, Rasmus Andersen wrote:
(This is another updated patch with the comments from the earlier mail
still valid.)
--- linux-ac10-clean/drivers/scsi/g_NCR5380.c Sat Jan 20 15:17:13 2001
+++ linux-ac10/drivers/scsi/g_NCR5380.c Tue Jan 23 21:05:44 2001
On Tue, Jan 23, 2001 at 12:37:18AM +0100, Rasmus Andersen wrote:
Hi.
This is an updated patch since I messed the one from yesterday up. The
comments still apply, though. Apologies for the extra mails.
--- linux-ac10-clean/drivers/scsi/fastlane.cMon Oct 16 21:51:16 2000
+++ linux-ac10
On Tue, Jan 23, 2001 at 12:45:20AM +0100, Rasmus Andersen wrote:
(This is another updated patch with the comments from the earlier mail
still valid.)
--- linux-ac10-clean/drivers/scsi/megaraid.cSat Jan 20 15:17:13 2001
+++ linux-ac10/drivers/scsi/megaraid.c Tue Jan 23 23:06:14 2001
On Tue, Jan 23, 2001 at 12:29:54AM +0100, Rasmus Andersen wrote:
(This is another updated patch with the comments from the earlier mail
still valid.)
--- linux-ac10-clean/drivers/scsi/NCR53c406a.c Mon Sep 18 22:36:24 2000
+++ linux-ac10/drivers/scsi/NCR53c406a.cTue Jan 23 21:09:09
On Tue, Jan 23, 2001 at 12:27:36AM +0100, Rasmus Andersen wrote:
Hi again.
I completely messed up a large part of the patches posted yesterday due
to lack of sleep and being clinically braindead (the compile test was
run in the wrong tree...).
So I'll be posting some new patches that act
On Tue, Jan 23, 2001 at 11:19:38PM +1100, Keith Owens wrote:
> On Tue, 23 Jan 2001 12:16:11 +,
> Anders Karlsson <[EMAIL PROTECTED]> wrote:
> >Even if it is a pristine kernel tree? What function does the 'make
> >mrproper' fill on an unused kernel tree?
>
> Depends on how you removed the old
Hi.
The following patch makes drivers/scsi/megaraid.c check the return
code of ioremap and converts the affected code paths to forward
gotos error handling. It applies cleanly against ac10 and with a
little fuzz against 241p9.
Please comment.
--- linux-ac10-clean/drivers/scsi/megaraid.cSat
Hi.
The following patch makes drivers/scsi/inia100.c refrain from
calling panic(), makes it check the return code of request_region
and makes it release a lot of resources on error.
It applies cleanly against ac10 and 241p9.
Comments?
--- linux-ac10-clean/drivers/scsi/inia100.c Sun Nov 1
Hi.
The following patch makes drivers/scsi/hosts.c check kmalloc's
return code, drops some gratitious zero initializations and
makes it a little less panicky.
It applies cleanly against ac10 and 241p9.
Please comment.
--- linux-ac10-clean/drivers/scsi/hosts.c Mon Oct 30 23:44:29 2000
++
Hi.
(I have not been able to find a maintainer for this code.)
The following patch makes drivers/scsi/g_NCR5380.c check the
return code of request_region instead of using check_region.
Ditto for request_mem_region.
It applies cleanly against ac10 and 241p9.
Comments?
--- linux-ac10-clean/dri
Hi.
(I have not been able to find a maintainer for this code.)
The following patch makes drivers/scsi/fastlane.c check the return
code of request_irq and converts (some) error paths to use forward
gotos.
It applies cleanly against ac10 and 241p9.
Comments?
--- linux-ac10-clean/drivers/scsi/f
Hi.
The following patch makes drivers/scsi/cpqfcTSinit.c check the
return code of ioremap, makes it use the return code of
request_region instead of check_region and converts the touched
code to use forward gotos on error paths.
It applies cleanly against ac10 and 241p9.
Comments?
--- linux-
Hi.
The following patch makes drivers/scsi/aic7xxx.c use the return
code of request_region instead of check_region. Since this
touched a lot of error paths I converted them to forward gotos
while I was there anyway.
It applies cleanly against ac10 and 241p9.
Comments?
--- linux-ac10-clean/dri
(Sorry, forgot lk.)
Hi.
The following patch makes drivers/scsi/3w-.c use the return
code from request_region instead of check_region.
It applies cleanly against ac10 and 241p9.
Comments?
--- linux-ac10-clean/drivers/scsi/3w-.c Thu Nov 9 02:09:50 2000
+++ linux-ac10/drivers/scsi
Hi.
(I hope you are the NCR53c406a maintainer. If not, I apologize for
the inconvenience and hope you can redirect me.)
The following patch makes drivers/scsi/NCR53c406a.c use the return
code of request_region instead of check_region and makes it release
the proper resources in its error paths.
Hi.
(I have not been able to determine a probable maintainer for this
code.)
The following patch makes drivers/scsi/aha1740.c use the return
code of request_region instead of check_region. The change
necessitated some changes to the folllowing error paths so I
changed those to be forwards gotos.
Hi.
(I hope I haven't missed any relevant lists :) )
The following patch makes drivers/scsi/53c7xx.c check the return code
of request_region and release the irq properly in the error path.
It applies cleanly against ac10 and 241p9.
Comments?
--- linux-ac10-clean/drivers/scsi/53c7xx.c Su
(Ooops. Forgot to cc linux-kernel.)
- Forwarded message from Rasmus Andersen <[EMAIL PROTECTED]> -
Hi.
The following patch makes drivers/scsi/sun3x_esp.c check the return
value of request_irq.
Comments?
--- linux-ac9/drivers/scsi/sun3x_esp.c~ Thu Jan 4 22:00:55 2001
+++ lin
Hi.
The following patch makes drivers/scsi/sgiwd93.c check the return code
from request_irq and get_free_pages. It also removes a line already done
a bit higher up (the dma_cache_wback_inv one).
Please comment.
--- linux-ac9/drivers/scsi/sgiwd93.c.orgSun Jan 14 21:33:29 2001
+++ linux
Hi.
(I have not been able to find a maintainer for this code.)
The following patch makes drivers/scsi/mvme147.c check the return code
from request_irq and scsi_register. It applies cleanly against 240p3
and ac9.
Please comment.
--- linux/drivers/scsi/mvme147.cTue Nov 28 02:57:34 2000
Hi.
(I have not been able to find a maintainer for this code.)
This patch makes drivers/scsi/dec_esp.c check the return code of
request_irq. It applies cleanly against 240p3 and ac9.
In the search_tc_slot loop I made it continue the search on failure
for one slot. Would this be correct?
Please
Hi.
The following patch makes drivers/scsi/blz1230.c check request_irq's
return code. It applies cleanly against 240p3 and ac9.
It also swaps two lines in an existing error path (esp_deallocate/
scsi_unregister) since this seems wrong.
Comments?
--- linux-ac9/drivers/scsi/blz1230.c.org
Hi again.
The following patch should correct the request_irq mistake. (The zero return
on failure seems to be required by scsi/scsi.c and is what everybody else
does.)
Other comments? :)
--- linux-ac9/drivers/scsi/atari_scsi.c.org Sun Jan 14 19:41:56 2001
+++ linux-ac9/drivers/scsi/atari_s
On Sun, Jan 14, 2001 at 04:29:11PM -0500, Jeff Garzik wrote:
> request_irq returns zero on success, not on failure. Further, you need
> to return the request_irq error value back to the caller, if possible.
My, that was embarassing. I'll change this as soon as I trust myself
with a keyboard ag
On Sun, Jan 14, 2001 at 07:49:35PM +0100, Rasmus Andersen wrote:
> Comments?
>
Well, Hans Grobler had some. the patch below tries to accommodate them by
adding scsi_unregister() and wd33c93_release() to the earlier patch.
Sorry for the multiple mailings.
(Any other) comments? :)
---
Hi again and sorry for the noise.
Hans Grobler kindly pointed me towards scsi_unregister which I heppily had
ignored. The following patch includes this function in the exit paths.
Otherwise it is identical to the earlier one.
--- linux-ac9/drivers/scsi/atari_scsi.c.org Sun Jan 14 19:41:56 2
Hi.
The following patch makes drivers/scsi/atari_scsi.c check request_irq's
return code. It applies cleanly against 240p3 and ac9.
Comments?
--- linux-ac9/drivers/scsi/atari_scsi.c~Tue Nov 28 02:57:34 2000
+++ linux-ac9/drivers/scsi/atari_scsi.c Sun Jan 14 19:28:00 2001
@@ -690,19 +690
1 - 100 of 208 matches
Mail list logo
