Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-02-10 Thread Richard Genoud
2017-02-10 14:34 GMT+01:00 Krzysztof Kozlowski : > On Thu, Feb 09, 2017 at 11:26:48AM +0100, Richard Genoud wrote: >> I did some tests with XU3 and XU4, playing with USB2 and USB3 quirks >> (snps,dis_u{2,3}_susphy_quirk) >> >> kernel for the tests: next-20170206 &g

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-02-09 Thread Richard Genoud
2017-01-27 8:29 GMT+01:00 Richard Genoud : > On 25/01/2017 15:17, Krzysztof Kozlowski wrote: >> On Wed, Jan 25, 2017 at 3:48 PM, Marek Szyprowski >> wrote: >>> Hi Krzysztof, >>> >>> On 2017-01-25 08:55, Krzysztof Kozlowski wrote: >>>> &

Re: Fractional divider on the Atmel USART controller

2017-02-06 Thread Richard Genoud
Hi Ludovic, On 06/02/2017 14:42, Ludovic Desroches wrote: > Hello Romain, > > On Mon, Feb 06, 2017 at 12:56:42PM +0100, Romain Izard wrote: >> Hello, >> >> On Atmel SAMA5D2, when trying to configure a serial port for 3 Mbauds >> operation, I do not always get the requested baud rate. If the hardw

Re: Fractional divider on the Atmel USART controller

2017-02-06 Thread Richard Genoud
Hi Romain, On 06/02/2017 12:56, Romain Izard wrote: > Hello, > > On Atmel SAMA5D2, when trying to configure a serial port for 3 Mbauds > operation, I do not always get the requested baud rate. If the hardware > flow control is disabled by software, the line works correctly. But if I > set the crts

Re: [PATCH] tty/serial: atmel: ensure state is restored after suspending

2017-02-06 Thread Richard Genoud
Hi Alexandre, On 03/02/2017 23:53, Alexandre Belloni wrote: > When going to suspend, the UART registers may be lost because the power to > VDDcore is cut. This is not an issue in the normal case but when > no_console_suspend is used, we need to restore the registers in order to > get a functional

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-01-26 Thread Richard Genoud
On 25/01/2017 15:17, Krzysztof Kozlowski wrote: > On Wed, Jan 25, 2017 at 3:48 PM, Marek Szyprowski > wrote: >> Hi Krzysztof, >> >> On 2017-01-25 08:55, Krzysztof Kozlowski wrote: >>> >>> On Wed, Jan 25, 2017 at 7:51 AM, Anand Moon wrote: >>>

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-01-25 Thread Richard Genoud
On 24/01/2017 19:22, Krzysztof Kozlowski wrote: > On Tue, Jan 24, 2017 at 02:48:09PM +0100, Richard Genoud wrote: >> Since commit 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all cores"), >> the USB ports on odroid-XU4 don't work anymore. > > Hi, > &

[PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-01-24 Thread Richard Genoud
e disabled temporarily while what's wrong with DCW3 is figured out. Tested on Odroid XU4 Suggested-by: Felipe Balbi Tested-by: Richard Genoud Signed-off-by: Richard Genoud Cc: sta...@vger.kernel.org # 4.4+ Fixes: 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all cores") --- arc

Re: [BISSECTED]: BUG: usb: dwc3: usb ports not working anymore on odroid-XU4

2017-01-23 Thread Richard Genoud
2017-01-23 12:45 GMT+01:00 Felipe Balbi : > > Hi, > > Richard Genoud writes: >> On 19/01/2017 09:03, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Richard Genoud writes: >>>> Hi, >>>> Since commit c499ff71ff2a2 ("u

Re: [BISSECTED]: BUG: usb: dwc3: usb ports not working anymore on odroid-XU4

2017-01-19 Thread Richard Genoud
On 19/01/2017 09:03, Felipe Balbi wrote: > > Hi, > > Richard Genoud writes: >> Hi, >> Since commit c499ff71ff2a2 ("usb: dwc3: core: re-factor init and exit paths") >> (merged in 4.8), the usb ports on odroid-XU4 don't work anymore. >> >>

[BISSECTED]: BUG: usb: dwc3: usb ports not working anymore on odroid-XU4

2017-01-18 Thread Richard Genoud
Hi, Since commit c499ff71ff2a2 ("usb: dwc3: core: re-factor init and exit paths") (merged in 4.8), the usb ports on odroid-XU4 don't work anymore. [ Actually, it's commit 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all cores"), cf below ] Inserting an usb key (USB2.0) on the USB3.0 port resul

Re: [PATCH] tty/serial: atmel_serial: BUG: stop DMA from transmitting in stop_tx

2017-01-02 Thread Richard Genoud
2017-01-02 12:13 GMT+01:00 Nicolas Ferre : > Le 13/12/2016 à 17:27, Richard Genoud a écrit : >> If we don't disable the transmitter in atmel_stop_tx, the DMA buffer >> continues to send data until it is emptied. >> This cause problems with the flow control (CTS is asse

Re: [PATCH] tty/serial: atmel: RS485 half duplex w/DMA: enable RX after TX is done

2017-01-02 Thread Richard Genoud
2017-01-02 12:53 GMT+01:00 Alexandre Belloni : > On 06/12/2016 at 13:05:33 +0100, Richard Genoud wrote : >> When using RS485 in half duplex, RX should be enabled when TX is >> finished, and stopped when TX starts. >> >> Before commit 0058f0871efe7b01c6 ("tty/serial:

[PATCH] tty/serial: atmel_serial: BUG: stop DMA from transmitting in stop_tx

2016-12-13 Thread Richard Genoud
m(DMA) Tested for regressions on sama5d2-xplained(Fifo) and at91sam9g20ek(PDC) Cc: (beware, this won't apply before 4.3) Signed-off-by: Richard Genoud --- drivers/tty/serial/atmel_serial.c | 11 +++ 1 file changed, 11 insertions(+) NB: this is not for the 4.10 merge window, I'

[PATCH] tty/serial: atmel: RS485 half duplex w/DMA: enable RX after TX is done

2016-12-06 Thread Richard Genoud
ial: atmel: fix RS485 half duplex with DMA") because RX was never disabled before. Moving atmel_start_rx() in atmel_complete_tx_dma() corrects the problem. Cc: sta...@vger.kernel.org Reported-by: Gil Weber Tested-by: Gil Weber Signed-off-by: Richard Genoud --- drivers/tty/serial

Re: [PATCH v6] tty/serial: at91: fix hardware handshake on Atmel platforms

2016-10-28 Thread Richard Genoud
2016-10-28 11:51 GMT+02:00 Uwe Kleine-König : > On Fri, Oct 28, 2016 at 01:13:31AM +0200, Alexandre Belloni wrote: >> On 27/10/2016 at 20:02:29 +0200, Uwe Kleine-König wrote : >> > Hello Richard, >> > >> > On Thu, Oct 27, 2016 at 06:04:06PM +0200, Richard Genou

Re: [PATCH v6] tty/serial: at91: fix hardware handshake on Atmel platforms

2016-10-28 Thread Richard Genoud
2016-10-27 20:02 GMT+02:00 Uwe Kleine-König : > Hello Richard, > > On Thu, Oct 27, 2016 at 06:04:06PM +0200, Richard Genoud wrote: >> diff --git a/drivers/tty/serial/atmel_serial.c >> b/drivers/tty/serial/atmel_serial.c >> index fd8aa1f4ba78..168b10cad47b 100644

[PATCH v6] tty/serial: at91: fix hardware handshake on Atmel platforms

2016-10-27 Thread Richard Genoud
he list may not be exhaustive Cc: #4.4+ (beware, missing atmel_port variable) Fixes: 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when hardware handshake is enabled") Signed-off-by: Richard Genoud Acked-by: Alexandre Belloni --- drivers/tty/serial/atmel_serial.c | 26 +

Re: [PATCH] tty/serial: at91: fix hardware handshake on Atmel platforms

2016-10-26 Thread Richard Genoud
2016-10-26 17:35 GMT+02:00 Alexandre Belloni : > Richard, > > On 26/10/2016 at 16:55:02 +0200, Richard Genoud wrote : >> On 25/10/2016 19:17, Uwe Kleine-König wrote: >> Quote from the commit message: >> " Commit 1cf6e8fc8341 ("tty/serial: at91: fix RTS

Re: [PATCH] tty/serial: at91: fix hardware handshake on Atmel platforms

2016-10-26 Thread Richard Genoud
On 25/10/2016 19:17, Uwe Kleine-König wrote: > Hello, > > On Tue, Oct 25, 2016 at 06:11:35PM +0200, Richard Genoud wrote: >> commit 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when >> hardware handshake is enabled"), despite its title, broke hardwar

Re: [PATCH] tty/serial: at91: fix hardware handshake on Atmel platforms

2016-10-25 Thread Richard Genoud
On 25/10/2016 18:22, Alexandre Belloni wrote: > Hi, > > On 25/10/2016 at 18:11:35 +0200, Richard Genoud wrote : >> commit 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when >> hardware handshake is enabled"), despite its title, broke hardware >>

[PATCH] tty/serial: at91: fix hardware handshake on Atmel platforms

2016-10-25 Thread Richard Genoud
: - Correct patch 1 with the error found by kbuild. - Add Alexandre's Acked-by on patch 2 - Rewrite patch 3 logic in the light of the on-going discussion with Cyrille and Alexandre. * the list may not be exhaustive Signed-off-by: Richard Genoud --- drivers/tty/serial/atmel_serial.c

Re: [PATCH 2/2] power/reset: at91-poweroff: timely shitdown LPDDR memories

2016-10-13 Thread Richard Genoud
2016-10-13 14:27 GMT+02:00 Jean-Jacques Hiblot : > 2016-10-13 13:03 GMT+02:00 Alexandre Belloni > : >> On 12/10/2016 at 14:48:27 +0200, Jean-Jacques Hiblot wrote : >>> > +static void at91_lpddr_poweroff(void) >>> > +{ >>> > + asm volatile( >>> > + /* Align to cache lines */ >>>

Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs

2016-10-07 Thread Richard Genoud
Le Tue, 4 Oct 2016 09:25:25 +0200, Uwe Kleine-König a écrit : > On Fri, Sep 30, 2016 at 01:04:28PM +0200, Richard Genoud wrote: > > 2016-09-30 11:12 GMT+02:00 Uwe Kleine-König > > : > > > Hello Richard, > > > > > > On Fri, Sep 30, 2016 at 10:58:00AM

Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs

2016-09-30 Thread Richard Genoud
2016-09-30 13:54 GMT+02:00 Alexandre Belloni : > On 30/09/2016 at 13:45:47 +0200, Richard Genoud wrote : >> 2016-09-30 13:16 GMT+02:00 Alexandre Belloni >> : >> > On 30/09/2016 at 13:04:28 +0200, Richard Genoud wrote : >> >> Anyway, the problematics setups

Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs

2016-09-30 Thread Richard Genoud
2016-09-30 13:16 GMT+02:00 Alexandre Belloni : > On 30/09/2016 at 13:04:28 +0200, Richard Genoud wrote : >> Anyway, the problematics setups are all the setups with USMODE_HWHS >> enabled on platform without Fifos or PDC, >> i.e. all platforms but sama5d2 (Cyrille, co

Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs

2016-09-30 Thread Richard Genoud
2016-09-30 11:12 GMT+02:00 Uwe Kleine-König : > Hello Richard, > > On Fri, Sep 30, 2016 at 10:58:00AM +0200, Richard Genoud wrote: >> Commit 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when >> hardware handshake is enabled") broke the hardware ha

[PATCHv4 3/3] tty/serial: at91: fix hardware handshake on SAM9x5 (without GPIOs)

2016-09-30 Thread Richard Genoud
with and without DMA Signed-off-by: Richard Genoud Fixes: 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when hardware handshake is enabled") --- drivers/tty/serial/atmel_serial.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/dri

[PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs

2016-09-30 Thread Richard Genoud
t mctrl_gpio_use_rtscts" Signed-off-by: Richard Genoud Acked-by: Alexandre Belloni Fixes: 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when hardware handshake is enabled") --- drivers/tty/serial/atmel_serial.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletio

[PATCHv4 0/3] Fix hardware handshake on SAM9x5 platforms

2016-09-30 Thread Richard Genoud
the logic in patch 3/3. Changes since v1: - Correct patch 1 with the error found by kbuild. - Add Alexandre's Acked-by on patch 2 - Rewrite patch 3 logic in the light of the on-going discussion with Cyrille and Alexandre. NB: patch 2 NEEDS patch 1 to compile. Richard Genoud (3): ser

[PATCHv4 1/3] serial: mctrl_gpio: implement mctrl_gpio_use_rtscts

2016-09-30 Thread Richard Genoud
This function returns true if CTS and RTS are used as GPIOs. Some drivers (like atmel_serial) needs to know if the flow control is handled by the controller or by GPIOs. Signed-off-by: Richard Genoud --- drivers/tty/serial/serial_mctrl_gpio.c | 7 +++ drivers/tty/serial/serial_mctrl_gpio.h

Re: [PATCH] MAINTAINERS: update entry for atmel_serial driver

2016-09-28 Thread Richard Genoud
gt; diff --git a/MAINTAINERS b/MAINTAINERS > [] >> +MICROCHIP / ATMEL AT91 / AT32 SERIAL DRIVER >> +M: Richard Genoud >> +S: Maintained >> +F: drivers/tty/serial/atmel_serial.c >> +F: include/linux/atmel_serial.h > > Thanks Richard. > > include/linux is

Re: [PATCH] MAINTAINERS: update entry for atmel_serial driver

2016-09-28 Thread Richard Genoud
; I'm happy that Richard is taking over the maintenance of this >> driver. >> >> Signed-off-by: Nicolas Ferre > > Can I get an ack from Richard that he agrees with this? absolutely ! Acked-by: Richard Genoud > thanks, > > greg k-h thanks ! -- for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?

Re: [PATCHv3 1/3] serial: mctrl_gpio: implement mctrl_gpio_use_rtscts

2016-09-27 Thread Richard Genoud
2016-09-27 17:12 GMT+02:00 Uwe Kleine-König : > Hello, > > On Tue, Sep 27, 2016 at 04:13:11PM +0200, Richard Genoud wrote: >> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c >> b/drivers/tty/serial/serial_mctrl_gpio.c >> index d2da6aa7f27d..0e5525a64c2a 100644

[PATCHv3 0/3] Fix hardware handshake on SAM9x5 platforms

2016-09-27 Thread Richard Genoud
ld. - Add Alexandre's Acked-by on patch 2 - Rewrite patch 3 logic in the light of the on-going discussion with Cyrille and Alexandre. NB: patch 2 NEEDS patch 1 to compile. Richard Genoud (3): serial: mctrl_gpio: implement mctrl_gpio_use_rtscts tty/serial: at91: fix hardware handshake w

[PATCHv3 2/3] tty/serial: at91: fix hardware handshake with GPIOs

2016-09-27 Thread Richard Genoud
t mctrl_gpio_use_rtscts" Signed-off-by: Richard Genoud Acked-by: Alexandre Belloni Fixes: 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when hardware handshake is enabled") --- drivers/tty/serial/atmel_serial.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletio

[PATCHv3 1/3] serial: mctrl_gpio: implement mctrl_gpio_use_rtscts

2016-09-27 Thread Richard Genoud
This function returns true if CTS and RTS are used as GPIOs. Some drivers (like atmel_serial) needs to know if the flow control is handled by the controller or by GPIOs. Signed-off-by: Richard Genoud --- drivers/tty/serial/serial_mctrl_gpio.c | 8 drivers/tty/serial

[PATCHv3 3/3] tty/serial: at91: fix hardware handshake on SAM9x5 (without GPIOs)

2016-09-27 Thread Richard Genoud
with and without DMA Signed-off-by: Richard Genoud Fixes: 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when hardware handshake is enabled") --- drivers/tty/serial/atmel_serial.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/dri

Re: [PATCHv2 2/3] tty/serial: at91: fix hardware handshake with GPIOs

2016-09-27 Thread Richard Genoud
2016-09-22 15:20 GMT+02:00 Uwe Kleine-König : > On Mon, Sep 12, 2016 at 11:47:32AM +0200, Richard Genoud wrote: >> Commit 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when >> hardware handshake is enabled") broke the hardware handshake when GPIOs >> w

Re: [PATCHv2 1/3] serial: mctrl_gpio: implement mctrl_gpio_use_rtscts

2016-09-26 Thread Richard Genoud
2016-09-22 15:14 GMT+02:00 Uwe Kleine-König : > On Mon, Sep 12, 2016 at 11:47:31AM +0200, Richard Genoud wrote: >> This function returns true if CTS and RTS are used as GPIOs. >> Some drivers (like atmel_serial) needs to know if the flow control is >> handled by the c

Re: [PATCH] usb: gadget: udc: atmel: fix endpoint name

2016-09-26 Thread Richard Genoud
;>> >> (generic_handle_irq+0x24/0x34) >>> >> [] (generic_handle_irq) from [] >>> >> (__handle_domain_irq+0x54/0xa8) >>> >> [] (__handle_domain_irq) from [] >>> >> (__irq_svc+0x54/0x70) >>> >> [] (__irq_svc) fro

[REGRESSION] BISECTED : ethernet gadget not working anymore on several atmel platforms

2016-09-15 Thread Richard Genoud
Since: commit c32b5bcfa3c43a3c9bb59f65b5e76adb7384c4c8 Author: Alexandre Belloni Date: Tue Jul 12 22:45:59 2016 +0200 ARM: dts: at91: Fix USB endpoint nodes Endpoint nodes have a reg property. Add their mandatory unit-address. Booting with an USB gadget configured as Ethernet gadget +

Re: [PATCHv2 3/3] tty/serial: at91: fix hardware handshake on SAM9x5 (without GPIOs)

2016-09-14 Thread Richard Genoud
2016-09-13 15:45 GMT+02:00 Alexandre Belloni : > On 12/09/2016 at 12:50:38 +0200, Richard Genoud wrote : >> >> diff --git a/drivers/tty/serial/atmel_serial.c >> >> b/drivers/tty/serial/atmel_serial.c >> >> index e9b4fbf88c2d..32154e7231ce 100644 >&g

[PATCH] BUG: atmel_serial: Interrupts not disabled on close

2016-09-12 Thread Richard Genoud
f9c7f87 ("serial: atmel: convert to irq handling provided mctrl-gpio"), this code was just removed. Calling atmel_disable_ms() disables the interrupts and everything works fine again. Tested on at91sam9g35-cm (This patch doesn't apply on -stable kernels, fixes for 4.4 and 4.7 will be

Re: [PATCHv2 3/3] tty/serial: at91: fix hardware handshake on SAM9x5 (without GPIOs)

2016-09-12 Thread Richard Genoud
2016-09-12 11:53 GMT+02:00 Alexandre Belloni : > On 12/09/2016 at 11:47:33 +0200, Richard Genoud wrote : >> Commit 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when >> hardware handshake is enabled") broke the hardware handshake on SAM9x5 >> platforms

[PATCHv2 1/3] serial: mctrl_gpio: implement mctrl_gpio_use_rtscts

2016-09-12 Thread Richard Genoud
This function returns true if CTS and RTS are used as GPIOs. Some drivers (like atmel_serial) needs to know if the flow control is handled by the controller or by GPIOs. Signed-off-by: Richard Genoud --- drivers/tty/serial/serial_mctrl_gpio.c | 8 drivers/tty/serial

[PATCHv2 3/3] tty/serial: at91: fix hardware handshake on SAM9x5 (without GPIOs)

2016-09-12 Thread Richard Genoud
with and without DMA Signed-off-by: Richard Genoud Fixes: 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when hardware handshake is enabled") --- drivers/tty/serial/atmel_serial.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/driver

[PATCHv2 0/3] Fix handware handshake on SAM9x5 platforms

2016-09-12 Thread Richard Genoud
s hardware handshake when CTS/RTS pins are not GPIOs. Changes since v1: - Correct patch 1 with the error found by kbuild. - Add Alexandre's Acked-by on patch 2 - Rewrite patch 3 logic in the light of the on-going discussion with Cyrille and Alexandre. NB: patch 2 NEEDS patch 1 to compile. Ri

[PATCHv2 2/3] tty/serial: at91: fix hardware handshake with GPIOs

2016-09-12 Thread Richard Genoud
t mctrl_gpio_use_rtscts" Signed-off-by: Richard Genoud Acked-by: Alexandre Belloni Fixes: 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when hardware handshake is enabled") --- drivers/tty/serial/atmel_serial.c | 11 --- 1 file changed, 8 insertions(+), 3 deletio

Re: [PATCH 3/3] tty/serial: at91: fix hardware handshake when DMA is not used

2016-09-09 Thread Richard Genoud
Hi Alex, Cyrille, I did some tests to clear this HW handcheck history out. NB: all those tests are with a 4.8-rc5 kernel on a AT91SAM9G35-CM board. I couldn't test the PDC since, as Cyrille said, there's no such thing on SAM9G35 USARTs. The modes that DON'T WORK are: ATMEL_US_USMODE_HWHS + DMA

[PATCH 2/3] tty/serial: at91: fix hardware handshake with GPIOs

2016-09-07 Thread Richard Genoud
t mctrl_gpio_use_rtscts" Signed-off-by: Richard Genoud Fixes: 1cf6e8fc8341 ("tty/serial: at91: fix RTS line management when hardware handshake is enabled") --- drivers/tty/serial/atmel_serial.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/tt

[PATCH 3/3] tty/serial: at91: fix hardware handshake when DMA is not used

2016-09-07 Thread Richard Genoud
ode requires using the DMA channel for reception." So, according to this, it *should* be possible to use automatic hardware handshake with the DMA and without FIFO (sam9x5 have no FIFOs like samad controllers) NB: -stable is not Cced because it doesn't cleanly apply on 4.1+ Signed-off-by

[PATCH 1/3] serial: mctrl_gpio: implement mctrl_gpio_use_rtscts

2016-09-07 Thread Richard Genoud
This function returns true if CTS and RTS are used as GPIOs. Some drivers (like atmel_serial) needs to know if the flow control is handled by the controller or by GPIOs. Signed-off-by: Richard Genoud --- drivers/tty/serial/serial_mctrl_gpio.c | 8 drivers/tty/serial/serial_mctrl_gpio.h

[BUG] [BISECTED] atmel_serial: Oops in mctrl_gpio_irq_handle

2016-09-05 Thread Richard Genoud
Hi, Since: commit 18dfef9c7f87b75bbb0fb66a634f7c13a45b9f8d Author: Uwe Kleine-König Date: Sun Oct 18 21:34:45 2015 +0200 serial: atmel: convert to irq handling provided mctrl-gpio An Oops happens when using hardware flow control with GPIOs. Steps to trigger the oops: - Set gpios to

Re: [BISECTED] Regression v4.6-rc1 : nanosleep doesn't return on AT91SAM9

2016-05-11 Thread Richard Genoud
2016-05-10 17:18 GMT+02:00 Nicolas Ferre : > Le 10/05/2016 16:59, Richard Genoud a écrit : >> 2016-05-10 16:47 GMT+02:00 Boris Brezillon >> : >>> Hi Richard, >>> >>> On Tue, 10 May 2016 16:25:25 +0200 >>> Richard Genoud wrote: >>&g

Re: [BISECTED] Regression v4.6-rc1 : nanosleep doesn't return on AT91SAM9

2016-05-10 Thread Richard Genoud
2016-05-10 17:18 GMT+02:00 Nicolas Ferre : > Le 10/05/2016 16:59, Richard Genoud a écrit : >> 2016-05-10 16:47 GMT+02:00 Boris Brezillon >> : >>> Hi Richard, >>> >>> On Tue, 10 May 2016 16:25:25 +0200 >>> Richard Genoud wrote: >>&g

Re: [BISECTED] Regression v4.6-rc1 : nanosleep doesn't return on AT91SAM9

2016-05-10 Thread Richard Genoud
2016-05-10 16:47 GMT+02:00 Boris Brezillon : > Hi Richard, > > On Tue, 10 May 2016 16:25:25 +0200 > Richard Genoud wrote: > >> 2016-05-10 15:58 GMT+02:00 Richard Genoud : >> > Hi, >> > >> > Starting with 4.6-rc1, a sleep 1 doesn't return :

Re: [BISECTED] Regression v4.6-rc1 : nanosleep doesn't return on AT91SAM9

2016-05-10 Thread Richard Genoud
2016-05-10 15:58 GMT+02:00 Richard Genoud : > Hi, > > Starting with 4.6-rc1, a sleep 1 doesn't return : > > execve("/bin/sleep", ["sleep", "1"], ["USER=root", "SHLVL=1", > "OLDPWD=/var", "HOME=/", "TE

[BISECTED] Regression v4.6-rc1 : nanosleep doesn't return on AT91SAM9

2016-05-10 Thread Richard Genoud
Hi, Starting with 4.6-rc1, a sleep 1 doesn't return : execve("/bin/sleep", ["sleep", "1"], ["USER=root", "SHLVL=1", "OLDPWD=/var", "HOME=/", "TERM=vt102", "PATH=/sbin:/usr/sbin:/bin:/usr/bin", "SHELL=/bin/sh", "PWD=/"]) = 0 uname({sysname="Linux", nodename="LNS", release="4.5.0-09406-g46e595a17dc

Re: [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios

2016-04-29 Thread Richard Genoud
> @@ -32,8 +32,6 @@ enum mctrl_gpio_idx { > UART_GPIO_RI = UART_GPIO_RNG, > UART_GPIO_RTS, > UART_GPIO_DTR, > - UART_GPIO_OUT1, > - UART_GPIO_OUT2, > UART_GPIO_MAX, > }; > > -- > 1.9.1 > It seems all right now ! Reviewed-by: Richard Genoud

Re: [PATCH] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios

2016-04-27 Thread Richard Genoud
2016-04-22 17:10 GMT+02:00 Geert Uytterhoeven : > The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs. > It doesn't make much sense to emulate GPIOs using other GPIOs, hence > drop support for that. > > Signed-off-by: Geert Uytterhoeven > --- > drivers/tty/serial/serial_mctrl_

Re: stty blocks forever when the line is already opened (and the tx buffer can't be flushed)

2016-01-27 Thread Richard Genoud
2016-01-27 10:14 GMT+01:00 Richard Genoud : > 2016-01-26 18:13 GMT+01:00 Peter Hurley : >> Hi Richard, >> >> On 01/26/2016 08:19 AM, Richard Genoud wrote: >>> [ sorry for the noise, I forgot to Cc the lkml ] >>> >>> Hi, >>> I've foun

Re: stty blocks forever when the line is already opened (and the tx buffer can't be flushed)

2016-01-27 Thread Richard Genoud
2016-01-26 18:13 GMT+01:00 Peter Hurley : > Hi Richard, > > On 01/26/2016 08:19 AM, Richard Genoud wrote: >> [ sorry for the noise, I forgot to Cc the lkml ] >> >> Hi, >> I've found a case were calling >> stty -F /dev/ttyS1 clocal >> blocks forever

Re: stty blocks forever when the line is already opened (and the tx buffer can't be flushed)

2016-01-26 Thread Richard Genoud
[ sorry for the noise, I forgot to Cc the lkml ] Hi, I've found a case were calling stty -F /dev/ttyS1 clocal blocks forever. And I don't know if it's a very old bug or if it's meant to be like that. Here is how to reproduce the lock : NB: there's NO modem on ttyS1 stty -F /dev/ttyS1 clocal cread

[PATCH] trivial: cpufreq-dt: correct dead link in documentation

2015-11-03 Thread Richard Genoud
ned-off-by: Richard Genoud --- Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt index e41c98ffbccb..dd3929e85

[PATCH] trivial: dt-bindings: correct path in documentation

2015-11-03 Thread Richard Genoud
As opp.txt was moved from: Documentation/devicetree/bindings/power/ to Documentation/devicetree/bindings/opp/ in the commit 3566c5b277a4 ("PM / OPP: Create a directory for opp bindings"), the vendor bindings should also go in that directory. Signed-off-by: Richard Genoud --- Doc

[PATCH] trivial: cpufreq: ARM big LITTLE: correct dead link in documentation

2015-11-03 Thread Richard Genoud
ned-off-by: Richard Genoud --- Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt b/Documentation/devicetree/bindings/cpufreq/arm_big_little_dt.txt index 07

Re: [PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options

2015-04-26 Thread Richard Genoud
2015-04-26 18:11 GMT+02:00 Maxime Ripard : > Hi Richard, > > On Sun, Apr 26, 2015 at 12:15:38PM +0200, Richard Genoud wrote: >> The A10 has 8 uarts, only uart0 and uart1 where filled. >> This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi. >> >&

[PATCH] ARM: sunxi: dts: Add A10 uarts pin muxing options

2015-04-26 Thread Richard Genoud
The A10 has 8 uarts, only uart0 and uart1 where filled. This patch adds all the missing uarts(2 to 7) pin muxing to the dtsi. Signed-off-by: Richard Genoud --- arch/arm/boot/dts/sun4i-a10.dtsi | 84 ++ 1 file changed, 84 insertions(+) Based on V4.0 uart4_a

Re: [PATCH] UBI: add missing kmem_cache_free() in process_pool_aeb error path

2014-09-10 Thread Richard Genoud
2014-09-09 23:43 GMT+02:00 Richard Weinberger : > Am 09.09.2014 14:25, schrieb Richard Genoud: >> I ran into this error after a ubiupdatevol, because I forgot to backport >> e9110361a9a4 UBI: fix the volumes tree sorting criteria. >> >> UBI error: process_pool_aeb: orph

[PATCH] UBI: add missing kmem_cache_free() in process_pool_aeb error path

2014-09-09 Thread Richard Genoud
: scanning is finished Freeing the cache in the error path fixes the Slab error. Tested on at91sam9g35 (3.14.18+fastmap backports) Signed-off-by: Richard Genoud Cc: stable # >= 3.10 --- drivers/mtd/ubi/fastmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/ubi/fastmap.c b/driv

[PATCH] tty: doc: Fix typos in serial/tty

2014-09-03 Thread Richard Genoud
Correct spelling typos in serial/tty Signed-off-by: Richard Genoud --- Documentation/serial/tty.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/serial/tty.txt b/Documentation/serial/tty.txt index 540db41dfd5d..1e52d67d0abf 100644 --- a/Documentation

Re: [PATCH V4 5/5] usb-phy: samsung-usb3: Remove older phy-samsung-usb3 driver

2014-04-16 Thread Richard Genoud
Hi Vivek, 2014-04-09 13:34 GMT+02:00 Vivek Gautam : > Hi Tomasz, > ' > > On Wed, Apr 9, 2014 at 4:43 PM, Tomasz Figa wrote: >> Hi Vivek, >> > Thanks for reviewing the patch series. > >> >> On 08.04.2014 16:36, Vivek Gautam wrote: >>> >>> Removing this older USB 3.0 DRD controller PHY driver, sinc

Re: [PATCH] rt2x00: Endless loop on hub port power down

2014-04-04 Thread Richard Genoud
2014-04-04 16:13 GMT+02:00 Stanislaw Gruszka : > On Fri, Apr 04, 2014 at 11:58:26AM +0200, Richard Genoud wrote: >> On 04/04/2014 10:04, Stanislaw Gruszka wrote: >> > On Thu, Apr 03, 2014 at 04:48:56PM +0200, Richard Genoud wrote: >> >> I've met an endless (or

Re: [PATCH] rt2x00: BUG: remove double loop on REGISTER_BUSY_COUNT

2014-04-04 Thread Richard Genoud
2014-04-04 16:06 GMT+02:00 Stanislaw Gruszka : > On Fri, Apr 04, 2014 at 11:01:06AM +0200, Jakub Kiciński wrote: >> On Fri, 4 Apr 2014 10:19:09 +0200, Stanislaw Gruszka wrote: >> > On Thu, Apr 03, 2014 at 05:37:01PM +0200, Jakub Kiciński wrote: >> > > On Thu, 3 Ap

Re: [PATCH] rt2x00: Endless loop on hub port power down

2014-04-04 Thread Richard Genoud
On 04/04/2014 10:04, Stanislaw Gruszka wrote: > On Thu, Apr 03, 2014 at 04:48:56PM +0200, Richard Genoud wrote: >> I've met an endless (or at least very long) loop if I power down the usb >> port on witch a usb wifi key is plugged. >> (Ok, it's not very smart to p

Re: [PATCH] rt2x00: BUG: remove double loop on REGISTER_BUSY_COUNT

2014-04-03 Thread Richard Genoud
2014-04-03 17:37 GMT+02:00 Jakub Kiciński : > On Thu, 3 Apr 2014 16:12:07 +0200, Richard Genoud wrote: >> rt2x00usb_register_read_lock() calls rt2x00usb_vendor_req_buff_lock() >> that calls rt2x00usb_vendor_request() which is already looping up to >> REGISTER_BUSY_COUNT time

[PATCH] rt2x00: Endless loop on hub port power down

2014-04-03 Thread Richard Genoud
hub-ctrl.c The following patch prevents the endless loop, but I'm really not sure that The Right Way To Do It (R) Signed-off-by: Richard Genoud --- drivers/net/wireless/rt2x00/rt2x00usb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.c

[PATCH] rt2x00: BUG: remove double loop on REGISTER_BUSY_COUNT

2014-04-03 Thread Richard Genoud
rt2x00usb_register_read_lock() calls rt2x00usb_vendor_req_buff_lock() that calls rt2x00usb_vendor_request() which is already looping up to REGISTER_BUSY_COUNT times. So this loop is not needed. Signed-off-by: Richard Genoud --- drivers/net/wireless/rt2x00/rt2x00usb.c | 9 +++-- 1 file

Re: [PATCH] trivial: gpiolib: typo in gpiochip_is_requested comment

2014-02-20 Thread Richard Genoud
2014-02-20 14:48 GMT+01:00 Jiri Kosina : > On Tue, 11 Feb 2014, Richard Genoud wrote: > >> Signed-off-by: Richard Genoud >> --- >> drivers/gpio/gpiolib.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpio/g

[PATCH] trivial: gpiolib: typo in gpiochip_is_requested comment

2014-02-11 Thread Richard Genoud
Signed-off-by: Richard Genoud --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 80da9f1940c9..a0b96695c519 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1646,7 +1646,7

[PATCH] trivial: gpio: update path to documentation

2014-02-11 Thread Richard Genoud
Signed-off-by: Richard Genoud --- include/linux/gpio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/gpio.h b/include/linux/gpio.h index b581b13d29d9..85aa5d0b9357 100644 --- a/include/linux/gpio.h +++ b/include/linux/gpio.h @@ -3,7 +3,7 @@ #include

Re: [PATCH] gpio: take in account the active low flag when configuring the gpio as an ouput

2014-02-10 Thread Richard Genoud
, &desc->flags)) { > gpiod_err(desc, > -- > 1.8.5.3 > Tested-by: Richard Genoud I was just missing that for my gpio modem lines ! Thanks ! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@

[PATCH 1/2] get_maintainer: Fix detection of git repository

2014-01-30 Thread Richard Genoud
Since git v1.7.7, the .git directory can be a file when, for example, the kernel is a submodule of another git super project. So, the check "-d .git" is not working anymore in this case. Using a more generic check like "-e .git" corrects this behaviour. Signed-off-by: Richard

[PATCH 2/2] checkpatch: Fix detection of git repository

2014-01-30 Thread Richard Genoud
Since git v1.7.7, the .git directory can be a file when, for example, the kernel is a submodule of another git super project. So, the check "-d .git" is not working anymore in this case. Using a more generic check like "-e .git" corrects this behaviour. Signed-off-by: Richard

Re: Unstable kernels work after 2.6.3x

2014-01-27 Thread Richard Genoud
2014-01-23 Alexey Vlasov : > Hello, > > I've already written that after release of version 2.6.32 something > strange happened either in the kernel or with its base features, namely > since then there was not released even a single kernel, which would at > least on my hosting work consistently and

Re: [PATCH] spi: atmel: add support for changing message transfer speed

2014-01-08 Thread Richard Genoud
2014/1/8 Mark Brown : > On Wed, Jan 08, 2014 at 11:15:13AM +0100, Richard Genoud wrote: > >> It seems that this patch got lost (or I missed something). >> As it will now conflict with Wenyou patch "Refactor spi-atmel to use >> SPI framework queue", >> s

Re: [PATCH] spi: atmel: Refactor spi-atmel to use SPI framework queue

2014-01-08 Thread Richard Genoud
-next branch of > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git > > It is tested on sama5d3xek and at91sam9m10g45ek board. And the bug I was seeing with SPI_IOC_MESSAGE (cf https://lkml.org/lkml/2013/10/8/269 ) is now gone ! Tested on at91sam9g35-ek Tested-by: Richard Genoud

Re: [PATCH] spi: atmel: add support for changing message transfer speed

2014-01-08 Thread Richard Genoud
2013/11/8 Mark Brown : > On Thu, Nov 07, 2013 at 10:34:06AM +0100, Richard Genoud wrote: >> The only speed available was max_speed (the maximum speed declared for a >> device). >> This patch adds the support for spi_tranfer->speed_hz parameter. >> We can now set

Re: [PATCH] Make the mtdblock read/write skip the bad nand sector

2013-11-25 Thread Richard Genoud
2013/11/25 Ezequiel Garcia : > On Mon, Nov 25, 2013 at 09:29:11AM +0800, Hans Zhang wrote: >> On 2013/11/22 19:45, Ezequiel Garcia wrote: >> >> Thanks for your reply. >> >> This is for my embed system upgrade, I reserved one nand partition for >> >> filesystem >> >> environment which will load to

[PATCH] spi: atmel: add support for changing message transfer speed

2013-11-07 Thread Richard Genoud
The only speed available was max_speed (the maximum speed declared for a device). This patch adds the support for spi_tranfer->speed_hz parameter. We can now set a different speed for each spi message. Signed-off-by: Richard Genoud --- drivers/spi/spi-atmel.c |

Re: SPI zero-length transfer: What should it do ?

2013-11-05 Thread Richard Genoud
[Sorry, for the resend, I didn't pay attention and used Mark's old email address] 2013/11/5 Richard Genoud : > Hi, > > As I was coding something like this: > static struct spi_ioc_transfer *xfer; > struct spi_frame *rx_frame; > xf

SPI zero-length transfer: What should it do ?

2013-11-05 Thread Richard Genoud
Hi, As I was coding something like this: static struct spi_ioc_transfer *xfer; struct spi_frame *rx_frame; xfer = calloc(nb, sizeof(*xfer)); for (i = 0; i < nb; i++) { xfer[i].tx_buf = (unsigned long)tx_buf; xfer[i].rx_buf = (unsigne

Re: [BUG] spi/spi-atmel: DMA rx buffer corruption with SPI_IOC_MESSAGE

2013-10-21 Thread Richard Genoud
2013/10/21 Yang, Wenyou : > Hi Richard, > >> -Original Message----- >> From: Richard Genoud [mailto:richard.gen...@gmail.com] >> Sent: 2013年10月17日 19:01 >> To: Yang, Wenyou >> Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Ferre, Nicolas; >

Re: sun4i_handle_irq: WARNING at net/ipv4/tcp_input.c:2711 tcp_fastretrans_alert

2013-10-17 Thread Richard Genoud
2013/8/23 Maxime Ripard : > Hi Richard, > > On Wed, Aug 21, 2013 at 11:47:20AM +0200, Richard GENOUD wrote: >> Hi Maxime, Stephan >> >> I just realise that, *sometimes*, I have some warnings on my cubieboard >> (6 since the 22 of july, and the board is runnning

Re: [BUG] spi/spi-atmel: DMA rx buffer corruption with SPI_IOC_MESSAGE

2013-10-17 Thread Richard Genoud
2013/10/8 Richard Genoud : > Hi all, > > I finally found the bug I saw months ago, before "[PATCH v8 3/8] > spi/spi-atmel: add dmaengine support" was merged. > > Here it is: > > When the ioctl SPI_IOC_MESSAGE is used with small and big buffers, > the big RX bu

Re: [BUG] spi/spi-atmel: DMA rx buffer corruption with SPI_IOC_MESSAGE

2013-10-08 Thread Richard Genoud
2013/10/8 Mark Brown : > On Tue, Oct 08, 2013 at 12:44:16PM +0200, Richard Genoud wrote: > >> I'm attaching the test software that I used ( ./spi_test /dev/spidevx.x ) > > Looks like the attachment got forgotten? arg !!! thanks ! here it is. (I hope !! Since this

Re: [BUG] spi/spi-atmel: DMA rx buffer corruption with SPI_IOC_MESSAGE

2013-10-08 Thread Richard Genoud
2013/10/8 Mark Brown : > On Tue, Oct 08, 2013 at 12:44:16PM +0200, Richard Genoud wrote: > >> I'm attaching the test software that I used ( ./spi_test /dev/spidevx.x ) > > Looks like the attachment got forgotten? arg !!! thanks ! here it is. #include #include #incl

[BUG] spi/spi-atmel: DMA rx buffer corruption with SPI_IOC_MESSAGE

2013-10-08 Thread Richard Genoud
Hi all, I finally found the bug I saw months ago, before "[PATCH v8 3/8] spi/spi-atmel: add dmaengine support" was merged. Here it is: When the ioctl SPI_IOC_MESSAGE is used with small and big buffers, the big RX buffer is corrupted with bytes from the big TX buffer. (Small means size < DMA_MIN_

Re: [PATCH 7/7] UBI: Add some asserts to ubi_attach_fastmap()

2013-09-30 Thread Richard Genoud
ust not happen), raise a > * fat warning and fall back to scanning mode. > -- > 1.8.3.1 > Tested-by: Richard Genoud -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

<    1   2   3   4   5   >