Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-08-01 Thread Robert Richter
Mark, On 30.07.14 16:46:26, Mark Rutland wrote: diff --git a/arch/arm64/boot/dts/thunder-88xx.dts b/arch/arm64/boot/dts/thunder-88xx.dts new file mode 100644 index ..4cf20ac9138b --- /dev/null +++ b/arch/arm64/boot/dts/thunder-88xx.dts @@ -0,0 +1,387 @@ +/* + *

Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-08-01 Thread Robert Richter
Olof, On 30.07.14 11:14:23, Olof Johansson wrote: On Wed, Jul 30, 2014 at 8:06 AM, Robert Richter r...@kernel.org wrote: From: Radha Mohan Chintakuntla rchintakun...@cavium.com Add initial device tree nodes for Cavium Thunder SoCs with support of 48 cores and gicv3. The dts file requires

Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-08-01 Thread Robert Richter
Mark, On 31.07.14 12:33:01, Mark Rutland wrote: On Thu, Jul 31, 2014 at 12:12:33PM +0100, Ganapatrao Kulkarni wrote: We mark RAM used by ATF as secure-RAM, however we don't support secure/non-secure address aliasing. i.e, a DRAM address that can be referenced from both a secure PA

Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-07-31 Thread Robert Richter
On 31.07.14 10:22:19, Rob Herring wrote: > On Thu, Jul 31, 2014 at 7:34 AM, Robert Richter wrote: > > On 30.07.14 11:37:38, Rob Herring wrote: > >> On Wed, Jul 30, 2014 at 10:46 AM, Mark Rutland > >> wrote: > >> > On Wed, Jul 30, 2014 at 04:06:31PM +0

Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-07-31 Thread Robert Richter
On 30.07.14 11:37:38, Rob Herring wrote: > On Wed, Jul 30, 2014 at 10:46 AM, Mark Rutland wrote: > > On Wed, Jul 30, 2014 at 04:06:31PM +0100, Robert Richter wrote: > >> From: Radha Mohan Chintakuntla > >> +/ { > >> + model = "Cavium ThunderX CN88XX

Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-07-31 Thread Robert Richter
On 31.07.14 12:24:13, Arnd Bergmann wrote: > On Wednesday 30 July 2014, Robert Richter wrote: > > +/* > > + * Cavium Thunder DTS file > > + * > > + * Copyright (C) 2013, Cavium Inc. > > + * > > + * This program is free software; you can redistribute it a

Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-07-31 Thread Robert Richter
Rob and Arnd, On 30.07.14 11:37:38, Rob Herring wrote: > >> +/* > >> + * Cavium Thunder DTS file > >> + * > >> + * Copyright (C) 2013, Cavium Inc. > >> + * > >> + * This program is free software; you can redistribute it and/or > >> + * modify it under the terms of the GNU General Public License

Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-07-31 Thread Robert Richter
Rob and Arnd, On 30.07.14 11:37:38, Rob Herring wrote: +/* + * Cavium Thunder DTS file + * + * Copyright (C) 2013, Cavium Inc. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by

Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-07-31 Thread Robert Richter
On 31.07.14 12:24:13, Arnd Bergmann wrote: On Wednesday 30 July 2014, Robert Richter wrote: +/* + * Cavium Thunder DTS file + * + * Copyright (C) 2013, Cavium Inc. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General

Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-07-31 Thread Robert Richter
On 30.07.14 11:37:38, Rob Herring wrote: On Wed, Jul 30, 2014 at 10:46 AM, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Jul 30, 2014 at 04:06:31PM +0100, Robert Richter wrote: From: Radha Mohan Chintakuntla rchintakun...@cavium.com +/ { + model = Cavium ThunderX CN88XX Family

Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-07-31 Thread Robert Richter
On 31.07.14 10:22:19, Rob Herring wrote: On Thu, Jul 31, 2014 at 7:34 AM, Robert Richter r...@kernel.org wrote: On 30.07.14 11:37:38, Rob Herring wrote: On Wed, Jul 30, 2014 at 10:46 AM, Mark Rutland mark.rutl...@arm.com wrote: On Wed, Jul 30, 2014 at 04:06:31PM +0100, Robert Richter

[PATCH 4/5] arm64, defconfig: Enable Cavium Thunder SoC in defconfig

2014-07-30 Thread Robert Richter
From: Robert Richter This patch enables Thunder SoCs in the arm64 defconfig. This is esp. useful to add Thunder platforms to automated builds based on arm64 defconfig. Signed-off-by: Robert Richter --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64

[PATCH 3/5] arm64, thunder: document devicetree bindings for Cavium Thunder SoC

2014-07-30 Thread Robert Richter
From: Radha Mohan Chintakuntla This patch adds documentation for the devicetree bindings used by the DT files of Cavium Thunder SoC platforms. Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: Robert Richter --- Documentation/devicetree/bindings/arm/cavium-thunder.txt | 10

[PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-07-30 Thread Robert Richter
Chintakuntla Signed-off-by: Robert Richter --- arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/thunder-88xx.dts | 387 +++ 2 files changed, 388 insertions(+) create mode 100644 arch/arm64/boot/dts/thunder-88xx.dts diff --git a/arch/arm64/boot/dts

[PATCH 5/5] arm64, defconfig: Enable tmpfs mount option

2014-07-30 Thread Robert Richter
From: Robert Richter Making it more convinient to run the arm64 default kernel as distros like Ubuntu need this option. Signed-off-by: Robert Richter --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs

[PATCH 1/5] arm64, thunder: Add Kconfig option for Cavium Thunder SoC Family

2014-07-30 Thread Robert Richter
From: Radha Mohan Chintakuntla Increase maximum numbers of cpus to 32. This relates to current maximal possible cpu number. Increasing this to 64 cpus will be a separate patch not part of this enablement patches. Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: Robert Richter --- arch

[PATCH 0/5] arm64, thunder: Enable Cavium Thunder SoC Family

2014-07-30 Thread Robert Richter
From: Robert Richter This initial patches enable Cavium Thunder SoC Family. The patches add Kconfig and devicetree support and then add Thunder to the defconfig. The last patch is unrelated to Thunder and enables the tmpfs mount option for a more convinient use of defconfig with distros

[PATCH 0/5] arm64, thunder: Enable Cavium Thunder SoC Family

2014-07-30 Thread Robert Richter
From: Robert Richter rrich...@cavium.com This initial patches enable Cavium Thunder SoC Family. The patches add Kconfig and devicetree support and then add Thunder to the defconfig. The last patch is unrelated to Thunder and enables the tmpfs mount option for a more convinient use of defconfig

[PATCH 5/5] arm64, defconfig: Enable tmpfs mount option

2014-07-30 Thread Robert Richter
From: Robert Richter rrich...@cavium.com Making it more convinient to run the arm64 default kernel as distros like Ubuntu need this option. Signed-off-by: Robert Richter rrich...@cavium.com --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs

[PATCH 1/5] arm64, thunder: Add Kconfig option for Cavium Thunder SoC Family

2014-07-30 Thread Robert Richter
...@cavium.com Signed-off-by: Robert Richter rrich...@cavium.com --- arch/arm64/Kconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index a474de346be6..e989d8cab8c7 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -128,6 +128,11 @@ source

[PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC

2014-07-30 Thread Robert Richter
-by: Radha Mohan Chintakuntla rchintakun...@cavium.com Signed-off-by: Robert Richter rrich...@cavium.com --- arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/thunder-88xx.dts | 387 +++ 2 files changed, 388 insertions(+) create mode 100644 arch

[PATCH 3/5] arm64, thunder: document devicetree bindings for Cavium Thunder SoC

2014-07-30 Thread Robert Richter
From: Radha Mohan Chintakuntla rchintakun...@cavium.com This patch adds documentation for the devicetree bindings used by the DT files of Cavium Thunder SoC platforms. Signed-off-by: Radha Mohan Chintakuntla rchintakun...@cavium.com Signed-off-by: Robert Richter rrich...@cavium.com

[PATCH 4/5] arm64, defconfig: Enable Cavium Thunder SoC in defconfig

2014-07-30 Thread Robert Richter
From: Robert Richter rrich...@cavium.com This patch enables Thunder SoCs in the arm64 defconfig. This is esp. useful to add Thunder platforms to automated builds based on arm64 defconfig. Signed-off-by: Robert Richter rrich...@cavium.com --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1

Re: [RFC PATCH v1 65/70] oprofile, timer_int: _FROZEN Cleanup

2014-07-28 Thread Robert Richter
On 22.07.14 21:59:41, Chen, Gong wrote: > Remove XXX_FROZEN state from oprofile/timer_int. > > Signed-off-by: Chen, Gong Acked-by: Robert Richter > --- > drivers/oprofile/timer_int.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/driver

Re: [RESEND RFC PATCH v1 0/70] Gloabl CPU Hot-plug flag _FROZEN Clean up

2014-07-28 Thread Robert Richter
On 27.07.14 02:36:43, Chen, Gong wrote: > On Fri, Jul 25, 2014 at 05:00:02PM +0200, Robert Richter wrote: > > > Back to long time ago (about 1.5 years), Thomas began the work > > > for CPU hot-plug, one first thing is CPU hotplug flag cleanup. > > > Paul

Re: [RESEND RFC PATCH v1 0/70] Gloabl CPU Hot-plug flag _FROZEN Clean up

2014-07-28 Thread Robert Richter
On 27.07.14 02:36:43, Chen, Gong wrote: On Fri, Jul 25, 2014 at 05:00:02PM +0200, Robert Richter wrote: Back to long time ago (about 1.5 years), Thomas began the work for CPU hot-plug, one first thing is CPU hotplug flag cleanup. Paul hoped all the _FROZEN variants of the notifier

Re: [RFC PATCH v1 65/70] oprofile, timer_int: _FROZEN Cleanup

2014-07-28 Thread Robert Richter
On 22.07.14 21:59:41, Chen, Gong wrote: Remove XXX_FROZEN state from oprofile/timer_int. Signed-off-by: Chen, Gong gong.c...@linux.intel.com Acked-by: Robert Richter r...@kernel.org --- drivers/oprofile/timer_int.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [RESEND RFC PATCH v1 0/70] Gloabl CPU Hot-plug flag _FROZEN Clean up

2014-07-25 Thread Robert Richter
On 22.07.14 21:58:36, Chen, Gong wrote: > Back to long time ago (about 1.5 years), Thomas began the work > for CPU hot-plug, one first thing is CPU hotplug flag cleanup. > Paul hoped all the _FROZEN variants of the notifier actions > can be removed at that time. Now here it is. > > Patch 1 ~ 69:

Re: [RESEND RFC PATCH v1 0/70] Gloabl CPU Hot-plug flag _FROZEN Clean up

2014-07-25 Thread Robert Richter
On 22.07.14 21:58:36, Chen, Gong wrote: Back to long time ago (about 1.5 years), Thomas began the work for CPU hot-plug, one first thing is CPU hotplug flag cleanup. Paul hoped all the _FROZEN variants of the notifier actions can be removed at that time. Now here it is. Patch 1 ~ 69: remove

Re: [PATCH 07/31] drivers/oprofile: Replace __get_cpu_var uses for address calculation

2014-07-19 Thread Robert Richter
On 18.07.14 19:28:50, Tejun Heo wrote: > On Fri, Jun 20, 2014 at 02:31:22PM -0500, Christoph Lameter wrote: > > Replace the uses of __get_cpu_var for address calculation with this_cpu_ptr. > > > > Cc: Robert Richter > > Cc: oprofile-l...@lists.sf.net > >

Re: [PATCH 07/31] drivers/oprofile: Replace __get_cpu_var uses for address calculation

2014-07-19 Thread Robert Richter
On 18.07.14 19:28:50, Tejun Heo wrote: On Fri, Jun 20, 2014 at 02:31:22PM -0500, Christoph Lameter wrote: Replace the uses of __get_cpu_var for address calculation with this_cpu_ptr. Cc: Robert Richter r...@kernel.org Cc: oprofile-l...@lists.sf.net Signed-off-by: Christoph Lameter c

Re: crazy idea (was: Re: [PATCH] perf tool: Carve out ctype.h et al)

2014-06-30 Thread Robert Richter
On 30.06.14 12:01:15, Borislav Petkov wrote: > Well, do you have it as a standalong program? If so, you can put it in > a repo somewhere and we can start hacking away and playing with it. If > not, we will have to copy the perf code *into* the RAS daemon first so > that we can have a separate

Re: crazy idea (was: Re: [PATCH] perf tool: Carve out ctype.h et al)

2014-06-30 Thread Robert Richter
On 30.06.14 12:01:15, Borislav Petkov wrote: Well, do you have it as a standalong program? If so, you can put it in a repo somewhere and we can start hacking away and playing with it. If not, we will have to copy the perf code *into* the RAS daemon first so that we can have a separate source

Re: [PATCH] tools:perf: move tools/perf/util to tools/lib/perf_util

2014-06-13 Thread Robert Richter
On 12.06.14 16:01:20, Borislav Petkov wrote: > Additionally, if you'd like, we could sync among each other on who does > what. Maybe Robert would like to help too. As long as I stick with the persistent event kernel patches I don't think I will have the time to work on further userspace changes.

Re: [PATCH v3 2/5] acpi, apei, ghes: Introduce ARCH_HAS_ACPI_APEI_NMI to make NMI error notification a GHES feature.

2014-06-13 Thread Robert Richter
On 13.06.14 13:02:57, Tomasz Nowicki wrote: > Currently APEI depends on x86 architecture. It is because of NMI hardware > error notification of GHES which is currently supported by x86 only. > However, many other APEI features can be still used perfectly by other > architectures. > > This commit

Re: [PATCH v3 1/5] apei, mce: Factor out APEI architecture specific MCE calls.

2014-06-13 Thread Robert Richter
On 13.06.14 13:02:56, Tomasz Nowicki wrote: > This commit abstracts MCE calls and provides weak corresponding default > implementation for those architectures which do not need arch specific > actions. Each platform willing to do additional architectural actions > should provides desired function

Re: [RFC v2 1/7] perf: add data_{offset,size} to user_page

2014-06-13 Thread Robert Richter
On 11.06.14 18:41:44, Alexander Shishkin wrote: > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index 853bc1c..ef95af4 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -488,9 +488,14 @@ struct perf_event_mmap_page { >

Re: [PATCH v3 5/5] acpi, apei, ghes: Factor out ioremap virtual memory for IRQ and NMI context.

2014-06-13 Thread Robert Richter
On 13.06.14 13:03:00, Tomasz Nowicki wrote: > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index 21aeac5..93a4d0b 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -113,12 +113,11 @@ static DEFINE_RAW_SPINLOCK(ghes_nmi_lock); > */ > > /* > - *

Re: [PATCH v3 4/5] apei, ghes, nmi: Factor out NMI arch-specific calls.

2014-06-13 Thread Robert Richter
On 13.06.14 13:02:59, Tomasz Nowicki wrote: > Similar to MCE related patch, all NMI architectural calls are abstracted. > Also, we are providing corresponding X86 functions' content. We don't need to abstract nmi calls for archs that don't support nmis. Just disable the code with #ifdefs

Re: [PATCH v3 0/5] APEI: Make APEI architecture independent.

2014-06-13 Thread Robert Richter
On 13.06.14 13:02:55, Tomasz Nowicki wrote: > V2->V3 > - address Robert's comment > - disable ACPI_APEI_NMI selection so that it is hard selected by arch Kconfig > - rename ACPI_APEI_NMI to ARCH_HAS_ACPI_APEI_NMI Btw, it would be easier to wait a bit with reposting a new patch set until there are

Re: [PATCH v3 3/5] acpi, apei, ghes: Introduce more generic mechanism to init/deinit GHES error notifications.

2014-06-13 Thread Robert Richter
On 13.06.14 13:02:58, Tomasz Nowicki wrote: > @@ -811,6 +819,8 @@ static int ghes_notify_nmi(unsigned int cmd, struct > pt_regs *regs) > int sev, sev_global = -1; > int ret = NMI_DONE; > > + BUG_ON(!IS_ENABLED(ARCH_HAS_ACPI_APEI_NMI)); > + Now that we have the

Re: [PATCH v3 3/5] acpi, apei, ghes: Introduce more generic mechanism to init/deinit GHES error notifications.

2014-06-13 Thread Robert Richter
On 13.06.14 13:02:58, Tomasz Nowicki wrote: @@ -811,6 +819,8 @@ static int ghes_notify_nmi(unsigned int cmd, struct pt_regs *regs) int sev, sev_global = -1; int ret = NMI_DONE; + BUG_ON(!IS_ENABLED(ARCH_HAS_ACPI_APEI_NMI)); + Now that we have the ARCH_HAS_ACPI_APEI_NMI

Re: [PATCH v3 0/5] APEI: Make APEI architecture independent.

2014-06-13 Thread Robert Richter
On 13.06.14 13:02:55, Tomasz Nowicki wrote: V2-V3 - address Robert's comment - disable ACPI_APEI_NMI selection so that it is hard selected by arch Kconfig - rename ACPI_APEI_NMI to ARCH_HAS_ACPI_APEI_NMI Btw, it would be easier to wait a bit with reposting a new patch set until there are no

Re: [PATCH v3 4/5] apei, ghes, nmi: Factor out NMI arch-specific calls.

2014-06-13 Thread Robert Richter
On 13.06.14 13:02:59, Tomasz Nowicki wrote: Similar to MCE related patch, all NMI architectural calls are abstracted. Also, we are providing corresponding X86 functions' content. We don't need to abstract nmi calls for archs that don't support nmis. Just disable the code with #ifdefs depending

Re: [PATCH v3 5/5] acpi, apei, ghes: Factor out ioremap virtual memory for IRQ and NMI context.

2014-06-13 Thread Robert Richter
On 13.06.14 13:03:00, Tomasz Nowicki wrote: diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index 21aeac5..93a4d0b 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -113,12 +113,11 @@ static DEFINE_RAW_SPINLOCK(ghes_nmi_lock); */ /* - * Two

Re: [RFC v2 1/7] perf: add data_{offset,size} to user_page

2014-06-13 Thread Robert Richter
On 11.06.14 18:41:44, Alexander Shishkin wrote: diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h index 853bc1c..ef95af4 100644 --- a/include/uapi/linux/perf_event.h +++ b/include/uapi/linux/perf_event.h @@ -488,9 +488,14 @@ struct perf_event_mmap_page {

Re: [PATCH v3 1/5] apei, mce: Factor out APEI architecture specific MCE calls.

2014-06-13 Thread Robert Richter
On 13.06.14 13:02:56, Tomasz Nowicki wrote: This commit abstracts MCE calls and provides weak corresponding default implementation for those architectures which do not need arch specific actions. Each platform willing to do additional architectural actions should provides desired function

Re: [PATCH v3 2/5] acpi, apei, ghes: Introduce ARCH_HAS_ACPI_APEI_NMI to make NMI error notification a GHES feature.

2014-06-13 Thread Robert Richter
On 13.06.14 13:02:57, Tomasz Nowicki wrote: Currently APEI depends on x86 architecture. It is because of NMI hardware error notification of GHES which is currently supported by x86 only. However, many other APEI features can be still used perfectly by other architectures. This commit adds

Re: [PATCH] tools:perf: move tools/perf/util to tools/lib/perf_util

2014-06-13 Thread Robert Richter
On 12.06.14 16:01:20, Borislav Petkov wrote: Additionally, if you'd like, we could sync among each other on who does what. Maybe Robert would like to help too. As long as I stick with the persistent event kernel patches I don't think I will have the time to work on further userspace changes.

Re: [PATCH v2 2/5] acpi, apei, ghes: Introduce ACPI_APEI_NMI to make NMI error notification a GHES feature.

2014-06-12 Thread Robert Richter
On 28.05.14 09:39:27, Tomasz Nowicki wrote: > +config ACPI_APEI_NMI > + bool "NMI error notification support" > + default y > + depends on ACPI_APEI_GHES && X86 > + help > + Firmware first mode can use NMI notification mechanism to report > errors > + to operating

Re: [PATCH v2 1/5] apei, mce: Factor out APEI architecture specific MCE calls.

2014-06-12 Thread Robert Richter
On 28.05.14 09:39:26, Tomasz Nowicki wrote: > This commit abstracts MCE calls and provides weak corresponding default > implementation for those architectures which do not need arch specific > actions. Each platform willing to do additional architectural actions > should provides desired function

Re: [PATCH v2 1/5] apei, mce: Factor out APEI architecture specific MCE calls.

2014-06-12 Thread Robert Richter
On 28.05.14 09:39:26, Tomasz Nowicki wrote: This commit abstracts MCE calls and provides weak corresponding default implementation for those architectures which do not need arch specific actions. Each platform willing to do additional architectural actions should provides desired function

Re: [PATCH v2 2/5] acpi, apei, ghes: Introduce ACPI_APEI_NMI to make NMI error notification a GHES feature.

2014-06-12 Thread Robert Richter
On 28.05.14 09:39:27, Tomasz Nowicki wrote: +config ACPI_APEI_NMI + bool NMI error notification support + default y + depends on ACPI_APEI_GHES X86 + help + Firmware first mode can use NMI notification mechanism to report errors + to operating system. This

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Robert Richter
On 23.05.14 07:01:41, Bjorn Helgaas wrote: > [I guess I've been using the wrong term here. I think "ECS" just > refers to the extended config space itself, and I should have been > saying "IO ECS" or "EnableCf8ExtCfg".] > > My understanding was that if we don't enable IO ECS and we don't have >

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Robert Richter
On 22.05.14 20:54:54, Bjorn Helgaas wrote: > I'm going to go out on a limb and guess that Windows does not enable > ECS, so it probably uses ECAM. Therefore, I suspect Linux's parsing > of MCFG is broken in some way, and we probably *could* use ECAM in all > these cases I'm seeing. Even if ECS

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Robert Richter
On 22.05.14 20:54:54, Bjorn Helgaas wrote: I'm going to go out on a limb and guess that Windows does not enable ECS, so it probably uses ECAM. Therefore, I suspect Linux's parsing of MCFG is broken in some way, and we probably *could* use ECAM in all these cases I'm seeing. Even if ECS is

Re: [PATCH V5 3/4] x86/PCI: Stop enabling ECS for AMD CPUs after Fam16h

2014-05-23 Thread Robert Richter
On 23.05.14 07:01:41, Bjorn Helgaas wrote: [I guess I've been using the wrong term here. I think ECS just refers to the extended config space itself, and I should have been saying IO ECS or EnableCf8ExtCfg.] My understanding was that if we don't enable IO ECS and we don't have MCFG, we

Re: [RFC 1/2] perf: add data_{offset,size} to user_page

2014-05-15 Thread Robert Richter
On 15.05.14 18:08:29, Alexander Shishkin wrote: > @@ -488,9 +488,14 @@ struct perf_event_mmap_page { >* In this case the kernel will not over-write unread data. >* >* See perf_output_put_handle() for the data ordering. > + * > + * data_{offset,size} indicate the

Re: [RFC 2/2] perf: add AUX area to ring buffer for raw data streams

2014-05-15 Thread Robert Richter
On 15.05.14 18:08:30, Alexander Shishkin wrote: > From: Peter Zijlstra > > This patch introduces "AUX space" in the perf mmap buffer, intended for > exporting high bandwidth data streams to userspace, such as instruction > flow traces. > > AUX space is a ring buffer, defined by

Re: [RFC 2/2] perf: add AUX area to ring buffer for raw data streams

2014-05-15 Thread Robert Richter
On 15.05.14 18:08:30, Alexander Shishkin wrote: From: Peter Zijlstra pet...@infradead.org This patch introduces AUX space in the perf mmap buffer, intended for exporting high bandwidth data streams to userspace, such as instruction flow traces. AUX space is a ring buffer, defined by

Re: [RFC 1/2] perf: add data_{offset,size} to user_page

2014-05-15 Thread Robert Richter
On 15.05.14 18:08:29, Alexander Shishkin wrote: @@ -488,9 +488,14 @@ struct perf_event_mmap_page { * In this case the kernel will not over-write unread data. * * See perf_output_put_handle() for the data ordering. + * + * data_{offset,size} indicate the

Re: [PATCH v4 00/16] perf, persistent: Add persistent events

2014-05-09 Thread Robert Richter
On 08.05.14 20:23:44, Borislav Petkov wrote: > On Wed, May 07, 2014 at 06:44:07PM +0200, Robert Richter wrote: > > With transparently I mean that the process even does not know that the > > same event is already running by another process. The kernel detects > > this

Re: [PATCH v4 00/16] perf, persistent: Add persistent events

2014-05-09 Thread Robert Richter
On 08.05.14 20:36:29, Borislav Petkov wrote: > On Wed, May 07, 2014 at 07:01:55PM +0200, Robert Richter wrote: > > For general-purpose... Why 512k buffers are ok? Depending on the > > event, smaller buffers are maybe good enough, esp. since they are > > permanently enabled and

Re: [PATCH v4 00/16] perf, persistent: Add persistent events

2014-05-09 Thread Robert Richter
On 08.05.14 20:36:29, Borislav Petkov wrote: On Wed, May 07, 2014 at 07:01:55PM +0200, Robert Richter wrote: For general-purpose... Why 512k buffers are ok? Depending on the event, smaller buffers are maybe good enough, esp. since they are permanently enabled and use system resources

Re: [PATCH v4 00/16] perf, persistent: Add persistent events

2014-05-09 Thread Robert Richter
On 08.05.14 20:23:44, Borislav Petkov wrote: On Wed, May 07, 2014 at 06:44:07PM +0200, Robert Richter wrote: With transparently I mean that the process even does not know that the same event is already running by another process. The kernel detects this and maps the request to that event

Re: [PATCH V3 1/3] x86/PCI: Fix PCI root numa_node info on AMD family15h

2014-05-08 Thread Robert Richter
On 08.05.14 10:21:07, Suravee Suthikulanit wrote: > The reason I put it all these comments here is because it took us a while to > discuss what to do with this file going forward. There were some confusions. > Therefore, I just want to document it here. > > Also, the check for (boot_cpu_data.x86

Re: [PATCH V3 1/3] x86/PCI: Fix PCI root numa_node info on AMD family15h

2014-05-08 Thread Robert Richter
On 08.05.14 09:39:55, Suravee Suthikulanit wrote: > On 5/8/2014 4:01 AM, Robert Richter wrote: > >On 08.05.14 10:59:05, Robert Richter wrote: > >>On 07.05.14 13:58:45, suravee.suthikulpa...@amd.com wrote: > >>>@@ -113,10 +122,17 @@ static int __in

Re: [PATCH V3 1/3] x86/PCI: Fix PCI root numa_node info on AMD family15h

2014-05-08 Thread Robert Richter
On 08.05.14 10:59:05, Robert Richter wrote: > On 07.05.14 13:58:45, suravee.suthikulpa...@amd.com wrote: > > @@ -113,10 +122,17 @@ static int __init early_fill_mp_bus_info(void) > > info = alloc_pci_root_info(min_bus, max_

Re: [PATCH V3 1/3] x86/PCI: Fix PCI root numa_node info on AMD family15h

2014-05-08 Thread Robert Richter
On 07.05.14 13:58:45, suravee.suthikulpa...@amd.com wrote: > @@ -113,10 +122,17 @@ static int __init early_fill_mp_bus_info(void) > info = alloc_pci_root_info(min_bus, max_bus, node, link); > } > > + /* > + * The following code is only supported until Fam11h. > +

Re: [PATCH V3 1/3] x86/PCI: Fix PCI root numa_node info on AMD family15h

2014-05-08 Thread Robert Richter
On 07.05.14 13:58:45, suravee.suthikulpa...@amd.com wrote: @@ -113,10 +122,17 @@ static int __init early_fill_mp_bus_info(void) info = alloc_pci_root_info(min_bus, max_bus, node, link); } + /* + * The following code is only supported until Fam11h. + *

Re: [PATCH V3 1/3] x86/PCI: Fix PCI root numa_node info on AMD family15h

2014-05-08 Thread Robert Richter
On 08.05.14 10:59:05, Robert Richter wrote: On 07.05.14 13:58:45, suravee.suthikulpa...@amd.com wrote: @@ -113,10 +122,17 @@ static int __init early_fill_mp_bus_info(void) info = alloc_pci_root_info(min_bus, max_bus, node, link); } + /* +* The following code

Re: [PATCH V3 1/3] x86/PCI: Fix PCI root numa_node info on AMD family15h

2014-05-08 Thread Robert Richter
On 08.05.14 09:39:55, Suravee Suthikulanit wrote: On 5/8/2014 4:01 AM, Robert Richter wrote: On 08.05.14 10:59:05, Robert Richter wrote: On 07.05.14 13:58:45, suravee.suthikulpa...@amd.com wrote: @@ -113,10 +122,17 @@ static int __init early_fill_mp_bus_info(void) info

Re: [PATCH V3 1/3] x86/PCI: Fix PCI root numa_node info on AMD family15h

2014-05-08 Thread Robert Richter
On 08.05.14 10:21:07, Suravee Suthikulanit wrote: The reason I put it all these comments here is because it took us a while to discuss what to do with this file going forward. There were some confusions. Therefore, I just want to document it here. Also, the check for (boot_cpu_data.x86

Re: [PATCH v4 00/16] perf, persistent: Add persistent events

2014-05-07 Thread Robert Richter
On 06.05.14 20:58:26, Borislav Petkov wrote: > On Tue, May 06, 2014 at 02:39:07PM +0200, Robert Richter wrote: > > I rather would change the ioctl to > > > > id = ioctl(PERF_EVENT_IOC_SET_PERSIST, arg); > > > > arg != 0: create persistent event (unclaim)

Re: [PATCH v4 00/16] perf, persistent: Add persistent events

2014-05-07 Thread Robert Richter
On 06.05.14 20:53:59, Borislav Petkov wrote: > On Tue, May 06, 2014 at 02:39:07PM +0200, Robert Richter wrote: > > Events could also be shared transparently. This means, if there is > > already an event running with the same attr, it could be reused. Not > > sure if

Re: [PATCH v4 00/16] perf, persistent: Add persistent events

2014-05-07 Thread Robert Richter
On 06.05.14 20:53:59, Borislav Petkov wrote: On Tue, May 06, 2014 at 02:39:07PM +0200, Robert Richter wrote: Events could also be shared transparently. This means, if there is already an event running with the same attr, it could be reused. Not sure if this makes sense much and is also

Re: [PATCH v4 00/16] perf, persistent: Add persistent events

2014-05-07 Thread Robert Richter
On 06.05.14 20:58:26, Borislav Petkov wrote: On Tue, May 06, 2014 at 02:39:07PM +0200, Robert Richter wrote: I rather would change the ioctl to id = ioctl(PERF_EVENT_IOC_SET_PERSIST, arg); arg != 0: create persistent event (unclaim) arg == 0: delete persistent event (claim

Re: [PATCH v4 00/16] perf, persistent: Add persistent events

2014-05-06 Thread Robert Richter
> Robert Richter : > This patch set implements the necessary kernel changes for persistent > events. I was reviewing the code again after a while. It demonstrates how persistent events can be used esp. for kernel enabled tracing. It also allows people to play with it. The initial

Re: [PATCH v4 00/16] perf, persistent: Add persistent events

2014-05-06 Thread Robert Richter
Robert Richter r...@kernel.org: This patch set implements the necessary kernel changes for persistent events. I was reviewing the code again after a while. It demonstrates how persistent events can be used esp. for kernel enabled tracing. It also allows people to play with it. The initial use

Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities

2014-04-30 Thread Robert Richter
On 30.04.14 02:50:21, Suravee Suthikulpanit wrote: > Actually, if ECS is needed by IBS, then wouldn't this still be needed for > every family since 10h and later (except family11h). Yes, but you have stated that pci mmconfig should work on families > 10h. Thus, ECS would work there out-of-the-box

Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities

2014-04-30 Thread Robert Richter
On 29.04.14 15:40:28, Myron Stowe wrote: > On Tue, Apr 29, 2014 at 1:14 PM, Borislav Petkov wrote: > > So sounds to me like we want to get rid of the whole IO ECS deal > > altogether then. > > > > Now, I'm wondering whether we should kill it completely since I don't > > think anyone cares about

Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities

2014-04-30 Thread Robert Richter
On 18.04.14 20:53:23, Myron Stowe wrote: > From: Suravee Suthikulpanit > - start = reg & 0xff00; /* 39:16 on 31:8*/ > - start <<= 8; > - reg = read_pci_config(bus, slot, 1, 0x84 + (i << 3)); > + start = (reg & 0xff00UL) << 8; /* 39:16

Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities

2014-04-30 Thread Robert Richter
On 18.04.14 20:53:23, Myron Stowe wrote: From: Suravee Suthikulpanit suravee.suthikulpa...@amd.com - start = reg 0xff00; /* 39:16 on 31:8*/ - start = 8; - reg = read_pci_config(bus, slot, 1, 0x84 + (i 3)); + start = (reg 0xff00UL)

Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities

2014-04-30 Thread Robert Richter
On 29.04.14 15:40:28, Myron Stowe wrote: On Tue, Apr 29, 2014 at 1:14 PM, Borislav Petkov b...@alien8.de wrote: So sounds to me like we want to get rid of the whole IO ECS deal altogether then. Now, I'm wondering whether we should kill it completely since I don't think anyone cares

Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities

2014-04-30 Thread Robert Richter
On 30.04.14 02:50:21, Suravee Suthikulpanit wrote: Actually, if ECS is needed by IBS, then wouldn't this still be needed for every family since 10h and later (except family11h). Yes, but you have stated that pci mmconfig should work on families 10h. Thus, ECS would work there out-of-the-box

Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities

2014-04-29 Thread Robert Richter
In addition to Boris I have the following: On 18.04.14 20:53:23, Myron Stowe wrote: > +#define AMD_PCIE_CF8(bus, dev, fn, reg) \ > + (0x8000 | \ > + ((reg & 0xF00) << 16) | \ > + ((bus & 0xF) << 16) | \ > + ((dev

Re: [PATCH 04/16] perf, mmap: Factor out perf_get_fd()

2014-04-29 Thread Robert Richter
On 25.04.14 16:52:05, Peter Zijlstra wrote: > But no, I don't think that helps, its still true that the moment you get > a fd another thread can immediately close(). That would drop the last > ref and free it, meanwhile perf_event_open() is happily poking at it. > > Now I think you could cure

Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities

2014-04-29 Thread Robert Richter
On 29.04.14 09:33:09, Andreas Herrmann wrote: > On Mon, Apr 28, 2014 at 11:40:36PM +0200, Borislav Petkov wrote: > > On Mon, Apr 28, 2014 at 02:50:29PM -0600, Bjorn Helgaas wrote: > > > This I/O ECS thing seems likely to cause future problems. My > > > understanding (based on sec 2.8 of [1]) is

Re: [PATCH] oprofile: Fix format string mismatch in oprofile_perf.c

2014-04-29 Thread Robert Richter
On 29.04.14 09:22:20, Masanari Iida wrote: > Fix format string mismatch in oprofile_perf_create_files. Please provide a compiler warning. > > Signed-off-by: Masanari Iida > --- > drivers/oprofile/oprofile_perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] oprofile: Fix format string mismatch in oprofile_perf.c

2014-04-29 Thread Robert Richter
On 29.04.14 09:22:20, Masanari Iida wrote: Fix format string mismatch in oprofile_perf_create_files. Please provide a compiler warning. Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/oprofile/oprofile_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities

2014-04-29 Thread Robert Richter
On 29.04.14 09:33:09, Andreas Herrmann wrote: On Mon, Apr 28, 2014 at 11:40:36PM +0200, Borislav Petkov wrote: On Mon, Apr 28, 2014 at 02:50:29PM -0600, Bjorn Helgaas wrote: This I/O ECS thing seems likely to cause future problems. My understanding (based on sec 2.8 of [1]) is that

Re: [PATCH 04/16] perf, mmap: Factor out perf_get_fd()

2014-04-29 Thread Robert Richter
On 25.04.14 16:52:05, Peter Zijlstra wrote: But no, I don't think that helps, its still true that the moment you get a fd another thread can immediately close(). That would drop the last ref and free it, meanwhile perf_event_open() is happily poking at it. Now I think you could cure this by

Re: [PATCH v2 2/5] x86/PCI: Support additional MMIO range capabilities

2014-04-29 Thread Robert Richter
In addition to Boris I have the following: On 18.04.14 20:53:23, Myron Stowe wrote: +#define AMD_PCIE_CF8(bus, dev, fn, reg) \ + (0x8000 | \ + ((reg 0xF00) 16) | \ + ((bus 0xF) 16) | \ + ((dev 0x1F) 11)

Re: [PATCH 04/16] perf, mmap: Factor out perf_get_fd()

2014-04-25 Thread Robert Richter
On 22.04.14 16:27:59, Peter Zijlstra wrote: > On Mon, Apr 07, 2014 at 05:04:26PM +0200, Jean Pihet wrote: > > From: Robert Richter > > > > This new function creates a new fd for an event. We need this later to > > get a fd from a persistent event. > >

Re: [PATCH 04/16] perf, mmap: Factor out perf_get_fd()

2014-04-25 Thread Robert Richter
On 22.04.14 16:27:59, Peter Zijlstra wrote: On Mon, Apr 07, 2014 at 05:04:26PM +0200, Jean Pihet wrote: From: Robert Richter robert.rich...@linaro.org This new function creates a new fd for an event. We need this later to get a fd from a persistent event. Signed-off-by: Robert

[tip:perf/core] perf/x86/amd/ibs: Fix waking up from S3 for AMD family 10h

2014-01-16 Thread tip-bot for Robert Richter
Commit-ID: bee09ed91cacdbffdbcd3b05de8409c77ec9fcd6 Gitweb: http://git.kernel.org/tip/bee09ed91cacdbffdbcd3b05de8409c77ec9fcd6 Author: Robert Richter AuthorDate: Wed, 15 Jan 2014 15:57:29 +0100 Committer: Ingo Molnar CommitDate: Thu, 16 Jan 2014 09:19:50 +0100 perf/x86/amd/ibs: Fix

Re: [PATCH] oprofile: check whether oprofile perf enabled in op_overflow_handler()

2014-01-16 Thread Robert Richter
(cc'ing Will) Weng, thanks for testing. On 16.01.14 17:33:04, Weng Meiling wrote: > Using the same test case, the problem also exists in the same kernel with the > new patch applied: > > > # opcontrol --start > > Using 2.6+ OProfile kernel interface. > Using log file

Re: [PATCH] oprofile: check whether oprofile perf enabled in op_overflow_handler()

2014-01-16 Thread Robert Richter
(cc'ing Will) Weng, thanks for testing. On 16.01.14 17:33:04, Weng Meiling wrote: Using the same test case, the problem also exists in the same kernel with the new patch applied: # opcontrol --start Using 2.6+ OProfile kernel interface. Using log file

[tip:perf/core] perf/x86/amd/ibs: Fix waking up from S3 for AMD family 10h

2014-01-16 Thread tip-bot for Robert Richter
Commit-ID: bee09ed91cacdbffdbcd3b05de8409c77ec9fcd6 Gitweb: http://git.kernel.org/tip/bee09ed91cacdbffdbcd3b05de8409c77ec9fcd6 Author: Robert Richter r...@kernel.org AuthorDate: Wed, 15 Jan 2014 15:57:29 +0100 Committer: Ingo Molnar mi...@kernel.org CommitDate: Thu, 16 Jan 2014 09:19:50

Re: [PATCH] perf, ibs: Fix waking up from S3 for AMD family 10h

2014-01-15 Thread Robert Richter
On 15.01.14 15:57:29, Robert Richter wrote: > @@ -816,6 +817,18 @@ static int force_ibs_eilvt_setup(void) > return ret; > } > > +void ibs_eilvt_setup(void) Grrr, this is not static. Could this be changed when the patch is applied assuming the rest is ok? Otherwise I will

<    6   7   8   9   10   11   12   13   14   15   >