In linus' git tree I found this problem. Is it also in the alsa tree?
please confirm it's the right fix. The patch was not yet tested.
--
duplicate test for "rj-master"
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8
in drivers/misc/thinkpad_acpi.c: 4137-4142 it reads:
/* safety net should the EC not support AUTO
* or FULLSPEED mode bits and just ignore them */
if (level TP_EC_FAN_FULLSPEED)
level |= 7; /* safety min speed 7 */
) {
if ((version 7) == 2)
esp-erev = fas100a; /* NCR53C9X */
else
esp-erev = espunknown;
Note the duplication of test 'if(family_code == 0x00)' and lines below
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git
In linus' git tree I found this problem. Is it also in the alsa tree?
please confirm it's the right fix. The patch was not yet tested.
--
duplicate test for rj-master
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
index
in drivers/misc/thinkpad_acpi.c, lines 4137-4142 it reads:
/* safety net should the EC not support AUTO
* or FULLSPEED mode bits and just ignore them */
if (level TP_EC_FAN_FULLSPEED)
level |= 7; /* safety min speed 7
is Not A Good Thing.
So, as a safety net, we now make sure to also set the fan level part of the
HFSP register to speed 7 for full-speed, and a minimum of speed 4 for auto
mode.
--
second TP_EC_FAN_FULLSPEED should be P_EC_FAN_AUTO
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers
the
memory to the device
DMA_FROM_DEVICE = PCI_DMA_FROMDEVICEdata is coming from
the device to the
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c
index 662c004..1e704f9 100644
'!' has a higher priority than '&': bitanding has no effect.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c
index a755605..01ebcec 100644
--- a/drivers/media/video/tvaudio.c
+++ b/drivers/media/video
'!' has a higher priority than '&': bitanding has no effect.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c
index 7dce318..65c67d1 100644
--- a/drivers/misc/asus-laptop.c
+++ b/drivers/misc/asus-laptop.c
@@ -32
'!' has a higher priority than '&': bitanding has no effect.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c
index 93ae747..5b28fa2 100644
--- a/drivers/video/sis/sis_main.c
+++ b/drivers/video/sis/sis_main.c
'!' has a higher priority than '&': bitanding has no effect.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c
index 1a7d778..1d13dd0 100644
--- a/drivers/video/i810/i810_main.c
+++ b/drivers/video/i810/i
'!' has a higher priority than '&': bitanding has no effect.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c
b/drivers/net/wireless/iwlwifi/iwl-4965.c
index 569347f..2439868 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965.c
+++
'!' has a higher priority than '': bitanding has no effect.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c
b/drivers/net/wireless/iwlwifi/iwl-4965.c
index 569347f..2439868 100644
--- a/drivers/net/wireless/iwlwifi/iwl-4965.c
+++ b/drivers/net
'!' has a higher priority than '': bitanding has no effect.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c
index 1a7d778..1d13dd0 100644
--- a/drivers/video/i810/i810_main.c
+++ b/drivers/video/i810/i810_main.c
'!' has a higher priority than '': bitanding has no effect.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c
index 93ae747..5b28fa2 100644
--- a/drivers/video/sis/sis_main.c
+++ b/drivers/video/sis/sis_main.c
@@ -427,7 +427,7
'!' has a higher priority than '': bitanding has no effect.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c
index 7dce318..65c67d1 100644
--- a/drivers/misc/asus-laptop.c
+++ b/drivers/misc/asus-laptop.c
@@ -322,7 +322,7
'!' has a higher priority than '': bitanding has no effect.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c
index a755605..01ebcec 100644
--- a/drivers/media/video/tvaudio.c
+++ b/drivers/media/video/tvaudio.c
@@ -1571,14
Untested patch below, please confirm it's the right fix.
--
duplicate use_dma_ppb_du, 2nd should be use_dma_ppb
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index c72e962..fbc10f9 100644
--- a/drivers/usb/
Untested patch below, please confirm it's the right fix (should it be some
other IFF_*?)
--
duplicate IFF_BROADCAST, remove 2nd
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c
index c0ed06d..a53acf4 100644
--- a/net/sched/sch_teql.c
Untested patch below, please confirm it's the right fix.
--
duplicate ENE_TEST_C9_PFENABLE_F0, 2nd should be *_F1
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/pcmcia/ti113x.h b/drivers/pcmcia/ti113x.h
index d29657b..87a5fd5 100644
--- a/drivers/pcmcia/ti113x.h
Untested patch below, please confirm it's the right fix.
--
duplicate NETIF_MSG_IFDOWN, 2nd should be NETIF_MSG_IFUP
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c
index f91ee70..ca3c3b3 100644
--- a/drivers/net/fec_mpc
In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy():
if (pause_adv & (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM))
Note that the two are the same and this is therefore equivalent to
if (pause_adv & ADVERTISE_1000XPSE_ASYM)
This appears to be incorrect, was maybe '|
In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy():
if (pause_adv (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM))
Note that the two are the same and this is therefore equivalent to
if (pause_adv ADVERTISE_1000XPSE_ASYM)
This appears to be incorrect, was maybe '|
Untested patch below, please confirm it's the right fix.
--
duplicate NETIF_MSG_IFDOWN, 2nd should be NETIF_MSG_IFUP
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c
index f91ee70..ca3c3b3 100644
--- a/drivers/net/fec_mpc52xx.c
Untested patch below, please confirm it's the right fix (should it be some
other IFF_*?)
--
duplicate IFF_BROADCAST, remove 2nd
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c
index c0ed06d..a53acf4 100644
--- a/net/sched/sch_teql.c
+++ b
Untested patch below, please confirm it's the right fix.
--
duplicate ENE_TEST_C9_PFENABLE_F0, 2nd should be *_F1
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/pcmcia/ti113x.h b/drivers/pcmcia/ti113x.h
index d29657b..87a5fd5 100644
--- a/drivers/pcmcia/ti113x.h
+++ b
Untested patch below, please confirm it's the right fix.
--
duplicate use_dma_ppb_du, 2nd should be use_dma_ppb
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index c72e962..fbc10f9 100644
--- a/drivers/usb/gadget
>>> On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote:
>>>> - if (val && 0x1)
>>>> + if (val & 0x1)
>> Joe Perches wrote:
>>> I think this pattern should be added to checkpatch
>>> + if ($line =
On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote:
- if (val 0x1)
+ if (val 0x1)
Joe Perches wrote:
I think this pattern should be added to checkpatch
+ if ($line =~ /\\\s*0[xX]/) {
On Thu, Jan 24, 2008 at 01:18:48AM +0100, Roel Kluin wrote:
I agree
Carlos Aguiar wrote:
> From: Juha Yrjola <[EMAIL PROTECTED]>
>
> Introduce new MMC multislot structure and change driver to use it.
> diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
It could be that I misunderstand, but...
> @@ -897,19 +1037,106 @@ static const struct
Carlos Aguiar wrote:
From: Juha Yrjola [EMAIL PROTECTED]
Introduce new MMC multislot structure and change driver to use it.
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
It could be that I misunderstand, but...
@@ -897,19 +1037,106 @@ static const struct mmc_host_ops
Joe Perches wrote:
> On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote:
>> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
>> ---
>> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
>> index ebf9e21..dcfb459 100644
>> --- a/arch/powerpc/boot
logical/bitand typo
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
index ebf9e21..dcfb459 100644
--- a/arch/powerpc/boot/4xx.c
+++ b/arch/powerpc/boot/4xx.c
@@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void)
logical/bitand typo
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
index ebf9e21..dcfb459 100644
--- a/arch/powerpc/boot/4xx.c
+++ b/arch/powerpc/boot/4xx.c
@@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void)
val
Joe Perches wrote:
On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote:
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
index ebf9e21..dcfb459 100644
--- a/arch/powerpc/boot/4xx.c
+++ b/arch/powerpc/boot/4xx.c
@@ -104,7 +104,7
/vio.c:309:EXPORT_SYMBOL(vio_unregister_device);
__cpu_init
arch/x86/kernel/topology.c:60:EXPORT_SYMBOL(arch_register_cpu);
--
EXPORT_SYMBOL'ed code mustn't be __*init.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/arm/mach-imx/generic.c b/arch/arm/mach-imx/generic.c
index
:EXPORT_SYMBOL(vio_unregister_device);
__cpu_init
arch/x86/kernel/topology.c:60:EXPORT_SYMBOL(arch_register_cpu);
--
EXPORT_SYMBOL'ed code mustn't be __*init.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/arm/mach-imx/generic.c b/arch/arm/mach-imx/generic.c
index 4cfc9d3..92e098a 100644
Paul Mundt wrote:
> On Fri, Jan 11, 2008 at 12:04:14PM +0100, Roel Kluin wrote:
>> Paul Mundt wrote:
>>> Take a look at how CONFIG_PCMCIA_DEBUG is handled.
>> In drivers/pcmcia/Makefile, when CONFIG_PCMCIA_DEBUG=y, it gives
>> EXTRA_CFLAGS += -DDEBUG
>>
Paul Mundt wrote:
> On Fri, Jan 11, 2008 at 10:45:30AM +0100, Roel Kluin wrote:
>> Paul Mundt wrote:
>>> On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote:
>>>> On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote:
>>>>> -#define DEBUG
Paul Mundt wrote:
> On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote:
>> On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote:
>>> -#define DEBUG(x,args...) printk(__FUNCTION__ ": " x,##args)
>>> +#define DEBUG(x, args...) printk("%s:
Paul Mundt wrote:
On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote:
On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote:
-#define DEBUG(x,args...) printk(__FUNCTION__ : x,##args)
+#define DEBUG(x, args...) printk(%s: , __func__, x, ##args)
Can this really be expected
Paul Mundt wrote:
On Fri, Jan 11, 2008 at 10:45:30AM +0100, Roel Kluin wrote:
Paul Mundt wrote:
On Fri, Jan 11, 2008 at 04:09:45AM +0100, Peter Stuge wrote:
On Thu, Jan 10, 2008 at 10:03:58PM +0100, Roel Kluin wrote:
-#define DEBUG(x,args...) printk(__FUNCTION__ : x,##args)
+#define DEBUG(x
Paul Mundt wrote:
On Fri, Jan 11, 2008 at 12:04:14PM +0100, Roel Kluin wrote:
Paul Mundt wrote:
Take a look at how CONFIG_PCMCIA_DEBUG is handled.
In drivers/pcmcia/Makefile, when CONFIG_PCMCIA_DEBUG=y, it gives
EXTRA_CFLAGS += -DDEBUG
which causes the definition of DEBUG as a macro
Randy Dunlap wrote:
> On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote:
>
>> diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h
>> index 3ed1df7..7b7498f 100644
>> --- a/drivers/net/wireless/arlan.h
>> +++ b/drivers/net/wireless/arlan.h
declared:
static const char __func__[] = "function-name";
As is DEBUG() - when active - will produce a syntax error.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/pcmcia/au1000_xxs1500.c b/drivers/pcmcia/au1000_xxs1500.c
index ce9d5c4..855e1d6 100644
---
Totally untested patch below from linus' git tree. The && is incorrect, right?
from drivers/net/wireless/arlan.h:390:
#define ARLAN_POWER 0x40
#define ARLAN_ACCESS0x80
Replace logical and by bit-and
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff -
Totally untested patch below from linus' git tree. The is incorrect, right?
from drivers/net/wireless/arlan.h:390:
#define ARLAN_POWER 0x40
#define ARLAN_ACCESS0x80
Replace logical and by bit-and
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/net
-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/pcmcia/au1000_xxs1500.c b/drivers/pcmcia/au1000_xxs1500.c
index ce9d5c4..855e1d6 100644
--- a/drivers/pcmcia/au1000_xxs1500.c
+++ b/drivers/pcmcia/au1000_xxs1500.c
@@ -56,7 +56,7 @@
#define PCMCIA_IRQ AU1000_GPIO_4
#if 0
Randy Dunlap wrote:
On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote:
diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h
index 3ed1df7..7b7498f 100644
--- a/drivers/net/wireless/arlan.h
+++ b/drivers/net/wireless/arlan.h
@@ -485,7 +485,7 @@ struct arlan_private
I have previously sent this to [EMAIL PROTECTED] and its
maintainer, but the error is still in linus' tree.
--
'!' has a higher priority than '&', so as was the bit test masks a binary.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/isdn/hardware/eicon/message.c
I have previously sent this to [EMAIL PROTECTED] and its
maintainer, but the error is still in linus' tree.
--
'!' has a higher priority than '', so as was the bit test masks a binary.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/isdn/hardware/eicon/message.c
b/drivers
bta->sampleshift
actually may evaluate to something like:
(1792000 / 15 ) >> bta->sampleshift
Isn't intended (HWBASE_AD * 4)/(bta->decimation >> bta->sampleshift)?
Then consider the patch below.
--
Fix operator precedence in return
Signed-off-by: Roel Kluin <[EMAIL PR
precedence errors
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/include/asm-h8300/timex.h b/include/asm-h8300/timex.h
index 2041314..23e6701 100644
--- a/include/asm-h8300/timex.h
+++ b/include/asm-h8300/timex.h
@@ -6,7 +6,7 @@
#ifndef _ASM_H8300_TIMEX_H
#define _ASM_H8300_TI
errors
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/include/asm-h8300/timex.h b/include/asm-h8300/timex.h
index 2041314..23e6701 100644
--- a/include/asm-h8300/timex.h
+++ b/include/asm-h8300/timex.h
@@ -6,7 +6,7 @@
#ifndef _ASM_H8300_TIMEX_H
#define _ASM_H8300_TIMEX_H
-#define
evaluate to something like:
(1792000 / 15 ) bta-sampleshift
Isn't intended (HWBASE_AD * 4)/(bta-decimation bta-sampleshift)?
Then consider the patch below.
--
Fix operator precedence in return
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/sound/oss/btaudio.c b/sound/oss/btaudio.c
) / (ETH_GSTRING_LEN * ETH_GSTRING_LEN)
Please confirm that the change is as wanted.
--
A lack of parentheses around defines causes unexpected results due to operator
precedences.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/e1000/e1000_ethtool.c
b/drivers/net
Roel Kluin wrote:
> Add parentheses to prevent operator precedence errors
>
> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
For the arch-ixp23xx part I should have added:
Acked-by: Lennert Buytenhek <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line &quo
paranoya? anyway, adding parentheses should be safe.
--
Add parentheses to prevent operator precedence errors
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/include/asm-arm/arch-ixp23xx/irqs.h
b/include/asm-arm/arch-ixp23xx/irqs.h
index e696395..27c5808 100644
--- a/include/a
paranoya? anyway, adding parentheses should be safe.
--
Add parentheses to prevent operator precedence errors
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/include/asm-arm/arch-ixp23xx/irqs.h
b/include/asm-arm/arch-ixp23xx/irqs.h
index e696395..27c5808 100644
--- a/include/asm-arm
Roel Kluin wrote:
Add parentheses to prevent operator precedence errors
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
For the arch-ixp23xx part I should have added:
Acked-by: Lennert Buytenhek [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
) / (ETH_GSTRING_LEN * ETH_GSTRING_LEN)
Please confirm that the change is as wanted.
--
A lack of parentheses around defines causes unexpected results due to operator
precedences.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/net/e1000/e1000_ethtool.c
b/drivers/net/e1000
Jeff Dike wrote:
> Turn um_virt_to_phys into virt_to_pte, cleaning up a horrid interface.
>
> It's also made non-static and declared in pgtable.h because it'll be
> needed when the stubs get a vma.
>
> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]>
> ---
> arch/um/kernel/skas/uaccess.c | 56
>
Mathieu Desnoyers wrote:
> Use the mutual exclusion provided by the text edit lock in the kprobes code.
> It
> allows coherent manipulation of the kernel code by other subsystems.
>
> Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECTED]>
> Acked-by: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]>
Mathieu Desnoyers wrote:
Use the mutual exclusion provided by the text edit lock in the kprobes code.
It
allows coherent manipulation of the kernel code by other subsystems.
Signed-off-by: Mathieu Desnoyers [EMAIL PROTECTED]
Acked-by: Ananth N Mavinakayanahalli [EMAIL PROTECTED]
CC:
Jeff Dike wrote:
Turn um_virt_to_phys into virt_to_pte, cleaning up a horrid interface.
It's also made non-static and declared in pgtable.h because it'll be
needed when the stubs get a vma.
Signed-off-by: Jeff Dike [EMAIL PROTECTED]
---
arch/um/kernel/skas/uaccess.c | 56
Ray Lee wrote:
> On Nov 7, 2007 10:34 AM, Roel Kluin <[EMAIL PROTECTED]> wrote:
>> If count reaches zero, the loop ends, but the postfix decrement subtracts it.
>> so, testing for 'count == 0' will not work.
>>
>> Signed-off-by: Roel Kluin <[EMAIL PROTECTE
If count reaches zero, the loop ends, but the postfix decrement subtracts it.
so, testing for 'count == 0' will not work.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/sound/oss/trident.c b/sound/oss/trident.c
index 96adc47..94b5fb4 100644
--- a/sound/oss/trident.c
+++ b
If count reaches zero, the loop ends, but the postfix decrement subtracts it.
so, testing for 'count == 0' will not work.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/sound/oss/trident.c b/sound/oss/trident.c
index 96adc47..94b5fb4 100644
--- a/sound/oss/trident.c
+++ b/sound/oss
Ray Lee wrote:
On Nov 7, 2007 10:34 AM, Roel Kluin [EMAIL PROTECTED] wrote:
If count reaches zero, the loop ends, but the postfix decrement subtracts it.
so, testing for 'count == 0' will not work.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/sound/oss/trident.c b/sound/oss
Al Viro wrote:
> On Tue, Nov 06, 2007 at 11:57:44PM +0100, Roel Kluin wrote:
>> 14 is added as an offset to the array dummy_packet (64 unsigned chars) to
>> serve as a destination address in a call to memset(). However, when added,
>> it is automatically scaled by the size o
Al Viro wrote:
> On Tue, Nov 06, 2007 at 11:43:12PM +0100, Roel Kluin wrote:
>> CDROM_PACKET_SIZE is added as an offset to the pointer to unsigned char
>> cmd[16].
>> The adjusted pointer is then used as a destination address in a call to
>> memset(). However, when
14 is added as an offset to the array dummy_packet (64 unsigned chars) to
serve as a destination address in a call to memset(). However, when added,
it is automatically scaled by the size of dummy_packet, which is 64. This
results in writing to unintended memory.
Signed-off-by: Roel Kluin
in the call
to memset() writing to unintended memory.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index a8130a4..548efcf 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -767,7 +767,7 @@ stat
14 is added as an offset to the array dummy_packet (64 unsigned chars) to
serve as a destination address in a call to memset(). However, when added,
it is automatically scaled by the size of dummy_packet, which is 64. This
results in writing to unintended memory.
Signed-off-by: Roel Kluin [EMAIL
in the call
to memset() writing to unintended memory.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index a8130a4..548efcf 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -767,7 +767,7 @@ static int pkt_generic_packet
Al Viro wrote:
On Tue, Nov 06, 2007 at 11:43:12PM +0100, Roel Kluin wrote:
CDROM_PACKET_SIZE is added as an offset to the pointer to unsigned char
cmd[16].
The adjusted pointer is then used as a destination address in a call to
memset(). However, when CDROM_PACKET_SIZE is added
Al Viro wrote:
On Tue, Nov 06, 2007 at 11:57:44PM +0100, Roel Kluin wrote:
14 is added as an offset to the array dummy_packet (64 unsigned chars) to
serve as a destination address in a call to memset(). However, when added,
it is automatically scaled by the size of dummy_packet, which is 64
Adrian Bunk wrote:
> Documentation/SubmitChecklist, point 1:
>
> <-- snip -->
>
> ...
> CC drivers/net/wan/lmc/lmc_main.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In
> function ‘lmc_ioctl’:
>
Kristof Provost wrote:
> On 2007-10-23 03:47:48 (+0200), Roel Kluin <[EMAIL PROTECTED]> wrote:
>> I think we should keep the lmc_tracing. Use this patch instead.
>>
>> --
>> Several returns before unlocking in lmc_ioctl
>>
>>
Jesper Nilsson wrote:
> static int
> e100_probe_transceiver(struct net_device* dev)
> {
> +#if !defined(CONFIG_ETRAX_NO_PHY)
> unsigned int phyid_high;
> unsigned int phyid_low;
> unsigned int oui;
> struct transceiver_ops* ops = NULL;
> + struct net_local *np =
Jesper Nilsson wrote:
static int
e100_probe_transceiver(struct net_device* dev)
{
+#if !defined(CONFIG_ETRAX_NO_PHY)
unsigned int phyid_high;
unsigned int phyid_low;
unsigned int oui;
struct transceiver_ops* ops = NULL;
+ struct net_local *np =
Kristof Provost wrote:
On 2007-10-23 03:47:48 (+0200), Roel Kluin [EMAIL PROTECTED] wrote:
I think we should keep the lmc_tracing. Use this patch instead.
--
Several returns before unlocking in lmc_ioctl
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/net
Adrian Bunk wrote:
Documentation/SubmitChecklist, point 1:
-- snip --
...
CC drivers/net/wan/lmc/lmc_main.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In
function ‘lmc_ioctl’:
Roel Kluin wrote:
> the file libvdeplug.h is missing
>
> There is a reference to http://wiki.virtualsquare.org/index.php/Main_Page in
> the Kconfig (also added by this commit).
> After reverting this commit the build continues. possibly the header
> libvdeplug.h was
Building uml with an allyesconfig and a few changes in UML only fails with:
...
CC arch/um/drivers/vde_user.o
/home/roel/dnld/src/kernel/git/linux-2.6/arch/um/drivers/vde_user.c:8:24:
error: libvdeplug.h: No such file or directory
Building uml with an allyesconfig and a few changes in UML only fails with:
...
CC arch/um/drivers/vde_user.o
/home/roel/dnld/src/kernel/git/linux-2.6/arch/um/drivers/vde_user.c:8:24:
error: libvdeplug.h: No such file or directory
Roel Kluin wrote:
the file libvdeplug.h is missing
There is a reference to http://wiki.virtualsquare.org/index.php/Main_Page in
the Kconfig (also added by this commit).
After reverting this commit the build continues. possibly the header
libvdeplug.h was forgotten?
Sorry for answering
Jan Engelhardt wrote:
> On Oct 28 2007 16:15, Roel Kluin wrote:
>> Wouldn't it be nice to be able to specify upon loading, or during runtime
>> to modules whether debug messages should be printed?
>
> modprobe ark3116 debug=1
>
> Nothing new.
Ok, than
Wouldn't it be nice to be able to specify upon loading, or during runtime
to modules whether debug messages should be printed?
- No kernel recompile needed for debugging.
- Less *_DEBUG options required in menuconfig.
How I think this could work:
Add to the module struct a bool to denote
Wouldn't it be nice to be able to specify upon loading, or during runtime
to modules whether debug messages should be printed?
- No kernel recompile needed for debugging.
- Less *_DEBUG options required in menuconfig.
How I think this could work:
Add to the module struct a bool to denote
Jan Engelhardt wrote:
On Oct 28 2007 16:15, Roel Kluin wrote:
Wouldn't it be nice to be able to specify upon loading, or during runtime
to modules whether debug messages should be printed?
modprobe ark3116 debug=1
Nothing new.
Ok, thanks and sorry, I didn't know that.
- A module could
Fix 'and' typo (PT_WRITE_OK is defined 2)
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/block/paride/pt.c b/drivers/block/paride/pt.c
index 9f4e67e..b91accf 100644
--- a/drivers/block/paride/pt.c
+++ b/drivers/block/paride/pt.c
@@ -664,7 +664,7 @@ static int p
Fix two 'and' typos
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index a8130a4..9cd6ba2 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -2202,11 +2202,11 @@ static int pkt_media_speed(struct pktcdvd_
Fix two 'and' typos
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index a8130a4..9cd6ba2 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -2202,11 +2202,11 @@ static int pkt_media_speed(struct pktcdvd_device *pd
Fix 'and' typo (PT_WRITE_OK is defined 2)
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/block/paride/pt.c b/drivers/block/paride/pt.c
index 9f4e67e..b91accf 100644
--- a/drivers/block/paride/pt.c
+++ b/drivers/block/paride/pt.c
@@ -664,7 +664,7 @@ static int pt_open(struct
This includes some that I think I have reported earlier:
in drivers/media/dvb/dvb-usb/au6610.c
and drivers/media/dvb/dvb-usb/gl861.c
--
Some more unlocking issues
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/char/drm/sis_mm.c b/drivers/char/drm/sis_mm.c
Several unlocking issues
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/net/9p/mux.c b/net/9p/mux.c
index f140147..c9f0805 100644
--- a/net/9p/mux.c
+++ b/net/9p/mux.c
@@ -222,8 +222,10 @@ static int p9_mux_poll_start(struct p9_conn *m)
}
Several unlocking issues
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/net/9p/mux.c b/net/9p/mux.c
index f140147..c9f0805 100644
--- a/net/9p/mux.c
+++ b/net/9p/mux.c
@@ -222,8 +222,10 @@ static int p9_mux_poll_start(struct p9_conn *m)
}
if (i
This includes some that I think I have reported earlier:
in drivers/media/dvb/dvb-usb/au6610.c
and drivers/media/dvb/dvb-usb/gl861.c
--
Some more unlocking issues
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/char/drm/sis_mm.c b/drivers/char/drm/sis_mm.c
index
Fix unlock on error
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c
index a0a9105..a6e6e78 100644
--- a/arch/mips/kernel/irixsig.c
+++ b/arch/mips/kernel/irixsig.c
@@ -426,6 +426,7 @@ asmlinkage int irix_sigprocma
101 - 200 of 279 matches
Mail list logo
