[PATCH v3] leds: Add DT support for leds-pca9532

2014-09-10 Thread Roland Stigge
This patch adds DT support for leds-pca9532. Signed-off-by: Roland Stigge --- Applies to v3.17-rc4 v3: Removed superfluous whitespace v2: Removed #ifdef statements Documentation/devicetree/bindings/leds/leds-pca9532.txt | 43 ++ drivers/leds/leds-pca9532.c

Re: [PATCH] leds: Add DT support for leds-pca9532

2014-09-10 Thread Roland Stigge
On 09/09/2014 08:08 PM, Arnd Bergmann wrote: > Is this a full PWM controller? If it is, it would be better to also > provide a #pwm-cells property and register the device with the PWM > subsystem to allow arbitrary users. > > If the PWM is only really usable for LED, it's probably enough to > leav

[PATCH v2] leds: Add DT support for leds-pca9532

2014-09-10 Thread Roland Stigge
This patch adds DT support for leds-pca9532. Signed-off-by: Roland Stigge --- Applies to v3.17-rc4 v2: Removed #ifdef statements Documentation/devicetree/bindings/leds/leds-pca9532.txt | 43 ++ drivers/leds/leds-pca9532.c | 47 2

[PATCH] leds: Add DT support for leds-pca9532

2014-09-09 Thread Roland Stigge
This patch adds DT support for leds-pca9532. Signed-off-by: Roland Stigge --- Applies to v3.17-rc4 Documentation/devicetree/bindings/leds/leds-pca9532.txt | 43 ++ drivers/leds/leds-pca9532.c | 47 2 files changed, 90 insertions

[PATCH] SPI: Fix error message

2014-09-09 Thread Roland Stigge
This patch fixes an error message typo ("not" missing). Signed-off-by: Roland Stigge --- drivers/spi/spi-pl022.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2136,7 +2136,7 @@ static int pl022_probe(struct

Re: [PATCH v2 05/12] ARM: lpc32xx: add MTD_SPI_NOR (new dependency for M25P80)

2014-05-01 Thread Roland Stigge
CONFIG_M25P80 etc. into a submenu under CONFIG_MTD_SPI_NOR? > > At the same time, drop the now-nonexistent CONFIG_MTD_CHAR symbol. > > Signed-off-by: Brian Norris > Cc: Roland Stigge > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- >

Re: [PATCH 2/7] ARM: lpc32xx: don't select HAVE_PWM

2014-02-10 Thread Roland Stigge
ARCH_LPC32XX > select CPU_ARM926T > select GENERIC_CLOCKEVENTS > select HAVE_IDE > - select HAVE_PWM > select USB_ARCH_HAS_OHCI > select USE_OF > help > Acked-by: Roland Stigge -- To unsubscribe from this list: send the line "unsubscrib

[PATCH] ARM: LPC32xx: Fix reset function

2013-09-04 Thread Roland Stigge
used anywhere else anymore. Signed-off-by: Roland Stigge -- Will provide a pull request for arm-soc when someone commented on this one. --- arch/arm/mach-lpc32xx/common.c | 29 ++--- 1 file changed, 6 insertions(+), 23 deletions(-) --- linux-2.6.orig/arch/arm/mach-lp

Re: [PATCH] MAX7301 GPIO: Reverting "Do not force SPI speed when using OF Platform"

2013-08-20 Thread Roland Stigge
> Signed-off-by: Christophe Leroy Acked-by: Roland Stigge Good, thanks! > > --- linux-3.11-rc6/drivers/gpio/gpio-max7301.c2013-08-17 > 21:09:17.0 +0200 > +++ linux/drivers/gpio/gpio-max7301.c 2013-08-18 06:31:52.0 +0200 > @@ -56,8 +56,7 @@ > i

Re: [PATCH 4/5] USB: lpc32xx: USB_LPC32XX need not depend on USB_PHY

2013-05-29 Thread Roland Stigge
-by: Roger Quadros Acked-by: Roland Stigge Tested-by: Roland Stigge Thanks! > CC: Roland Stigge > --- > drivers/usb/gadget/Kconfig |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > index

Re: [PATCH 19/21] USB: lpc32xx: ISP1301 needs USB_PHY

2013-04-25 Thread Roland Stigge
e to `isp1301_get_client' > drivers/built-in.o: In function `lpc32xx_udc_probe': > drivers/usb/gadget/lpc32xx_udc.c:3071: undefined reference to > `isp1301_get_client' > > Signed-off-by: Arnd Bergmann > Cc: linux-...@vger.kernel.org > Cc: Greg Kroah-Hartm

Re: [RESEND][PATCH RFT 2/2] pwm: lpc32xx: Don't change PWM_ENABLE bit in lpc32xx_pwm_config

2013-04-23 Thread Roland Stigge
On 04/23/2013 08:02 AM, Axel Lin wrote: > lpc32xx_pwm_config() is supposed to set duty_ns and period_ns, > it should not change PWM_ENABLE bit. > > Signed-off-by: Axel Lin Tested-by: Roland Stigge > --- > drivers/pwm/pwm-lpc32xx.c |7 +-- > 1 file change

Re: [RESEND][PATCH RFT 1/2] pwm: lpc32xx: Properly set PWM_ENABLE bit in lpc32xx_pwm_[enable|disable]

2013-04-23 Thread Roland Stigge
documents/user_manual/UM10326.pdf > > Signed-off-by: Axel Lin Tested-by: Roland Stigge > --- > Hi, > I don't have this hardware handy so I'd appreciate if someone can test this > patch serial. > > This patch serial was sent on https://lkml.org/lkml/2013/3/3

Re: [PATCH] ARM: LPC32xx: changed lpc23xx_restart to lpc32xx_restart

2013-04-02 Thread Roland Stigge
On 02/04/13 17:58, Olof Johansson wrote: > On Wed, Mar 06, 2013 at 09:18:58PM +0100, Martin Knoll wrote: >> This function has an odd name. This is probably a typo. > > You should cc the platform maintainer on these kind of patches (Roland > Stigge). > But it seems that he&

[PATCH] MAINTAINERS: Add maintainer for LPC32xx

2013-04-02 Thread Roland Stigge
This patch adds Roland Stigge as maintainer for NXP LPC32xx. Signed-off-by: Roland Stigge --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) --- linux-2.6.orig/MAINTAINERS +++ linux-2.6/MAINTAINERS @@ -4941,6 +4941,12 @@ W: logfs.org S: Maintained F: fs/logfs

Re: [PATCH] usb: Fix compile error by selecting USB_OTG_UTILS

2013-03-26 Thread Roland Stigge
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 On 03/26/2013 08:24 PM, Felipe Balbi wrote: > commit ? 1c2088812f095df77f4b3224b65db79d7111a300 Seems to be based on the assumption that only OTG needs a PHY. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG

Re: [PATCH] usb: Fix compile error by selecting USB_OTG_UTILS

2013-03-26 Thread Roland Stigge
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 On 03/26/2013 07:03 PM, Felipe Balbi wrote: > On Tue, Mar 26, 2013 at 06:36:01PM +0100, Roland Stigge wrote: >> The current lpc32xx_defconfig breaks like this, caused by recent >> phy restructuring: > > which commit actually

[PATCH] usb: Fix compile error by selecting USB_OTG_UTILS

2013-03-26 Thread Roland Stigge
_udc_probe': drivers/usb/gadget/lpc32xx_udc.c:3104: undefined reference to `isp1301_get_client' distcc[27867] ERROR: compile (null) on localhost failed make: *** [vmlinux] Error 1 This patch fixes this by selecting USB_OTG_UTILS in Kconfig which causes the phy driver to be built again. Signed-o

[PATCH] mmc: mmc_spi: Fix return value evaluation of irq_of_parse_and_map()

2013-01-30 Thread Roland Stigge
patch changes to comparison with 0 which is the error return value of irq_of_parse_and_map(). Tested on ARM that mmc_spi is working now. Signed-off-by: Roland Stigge diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c index 1534b58..d720b5e 100644 --- a/drivers/mmc/host

Re: [PATCH 5/6 v14] gpio: Add device tree support to block GPIO API

2013-01-28 Thread Roland Stigge
On 01/28/2013 12:39 PM, Stijn Devriendt wrote: >>> In the device-tree this is specified as: >>> >>> powr@0x20 { >>>// other properties >>> >>> gpios = <&gpio 4 0 >>>&gpio 5 0>; >>> }; >>> >>> Is this kind of integration also possible? >> >> You can reference the gpio block via

Re: [PATCH 5/6 v14] gpio: Add device tree support to block GPIO API

2013-01-27 Thread Roland Stigge
On 27/01/13 14:07, Stijn Devriendt wrote: >> +Example: >> + >> +blockgpio { >> +compatible = "linux,gpio-block"; >> + >> +block0 { >> +gpios = <&gpio 3 0 0>, >> +<&gpio 3 1 0>; >> +}; >>

Re: [PATCH 1/6 v14] gpio: Add a block GPIO API to gpiolib

2013-01-27 Thread Roland Stigge
On 27/01/13 14:19, Stijn Devriendt wrote: >> +Block GPIO >> +-- >> + >> +The above described interface concentrates on handling single GPIOs. >> However, >> +in applications where it is critical to set several GPIOs at once, this >> +interface doesn't work well, e.g. bit-banging protocols

Re: [PATCH 6/6 v14] gpio: Add block gpio to several gpio drivers

2013-01-27 Thread Roland Stigge
On 27/01/13 13:18, Stijn Devriendt wrote: >>> In my patch, I go out of the way of this kind of thing for a simple reason: >>> You may generate incorrect timing by doing this. >> >> You are right, certain things like synchronous on+off is not really >> possible. >> >> However, the above at least sup

Re: [PATCH 6/6 v14] gpio: Add block gpio to several gpio drivers

2013-01-24 Thread Roland Stigge
On 01/24/2013 01:02 PM, Stijn Devriendt wrote: >> +static void lpc32xx_gpio_set_block_p3(struct gpio_chip *chip, >> + unsigned long mask, >> + unsigned long values) >> +{ >> + struct lpc32xx_gpio_chip *group = to_lpc32xx_

Re: [PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-23 Thread Roland Stigge
On 23/01/13 02:03, Jonathan Corbet wrote: > On Tue, 22 Jan 2013 13:06:41 +0100 > Roland Stigge wrote: > >> This patch adds a character device interface to the block GPIO system. > > So I was looking at this, and a couple of things caught my eye... Good points you mention

[PATCH 2/6 v14] gpio: Add sysfs support to block GPIO API

2013-01-22 Thread Roland Stigge
This patch adds sysfs support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/sysfs-gpio | 20 ++ drivers/gpio/gpiolib.c | 252 ++- include/asm-generic/gpio.h | 11 + include/linux/gpio.h

[PATCH 4/6 v14] gpiolib: Fix default attributes for class

2013-01-22 Thread Roland Stigge
There is a race condition between creating a gpio or gpiochip device and adding default attributes. This patch fixes this by defining the default attributes as dev_attrs of the class. For this, it was necessary to create a separate gpiochip_class besides gpio_class. Signed-off-by: Roland Stigge

[PATCH 0/6 v14] gpio: Add block GPIO

2013-01-22 Thread Roland Stigge
special accessor functions for block wise GPIO access (only for some selected drivers since the feature is optional and not suitable for all GPIO hardware) * Fix for race condition in gpiolib on device creation Signed-off-by: Roland Stigge Tested by: Wolfgang Grandegger -- Testing branch

[PATCH 6/6 v14] gpio: Add block gpio to several gpio drivers

2013-01-22 Thread Roland Stigge
.) Signed-off-by: Roland Stigge For pinctrl-at91.c: Acked-by: Nicolas Ferre --- drivers/gpio/Kconfig |2 drivers/gpio/gpio-em.c| 23 ++ drivers/gpio/gpio-ge.c| 29 + drivers/gpio/gpio-generic.c | 56

[PATCH 3/6 v14] gpio: Add userland device interface to block GPIO

2013-01-22 Thread Roland Stigge
This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/dev-gpioblock | 34 drivers/gpio/gpiolib.c | 225 +++- include/linux/gpio.h| 13 + 3 files

[PATCH 1/6 v14] gpio: Add a block GPIO API to gpiolib

2013-01-22 Thread Roland Stigge
word: Once requested, it provides access to a group of GPIOs which can range over multiple GPIO chips. Signed-off-by: Roland Stigge --- Documentation/gpio.txt | 58 +++ drivers/gpio/gpiolib.c | 227 + include/asm-generic/gpio.h | 17 ++

[PATCH 5/6 v14] gpio: Add device tree support to block GPIO API

2013-01-22 Thread Roland Stigge
This patch adds device tree support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/devicetree/bindings/gpio/gpio-block.txt | 36 ++ drivers/gpio/Makefile |1 drivers/gpio/gpioblock-of.c | 100

Re: [PATCH RESEND 1/6 v13] gpio: Add a block GPIO API to gpiolib

2013-01-18 Thread Roland Stigge
Hi Stijn, On 01/18/2013 01:13 PM, Stijn Devriendt wrote: > Hi Roland, > > This mail has been long overdue due to issues with some internal > permission-tool. > Just to be clear, this is not a competing implementation, it's what we > currently use as-is. I'm just posting this as a reference to see

Re: [PATCH RESEND 6/6 v13] gpio: Add block gpio to several gpio drivers

2013-01-15 Thread Roland Stigge
On 01/15/2013 02:18 PM, Nicolas Ferre wrote: >> --- linux-2.6.orig/drivers/pinctrl/pinctrl-at91.c >> +++ linux-2.6/drivers/pinctrl/pinctrl-at91.c >> @@ -49,6 +49,7 @@ struct at91_gpio_chip { >> struct clk*clock;/* associated clock */ >> struct irq_domain*domain;/

[PATCH RESEND 2/6 v13] gpio: Add sysfs support to block GPIO API

2013-01-15 Thread Roland Stigge
This patch adds sysfs support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/sysfs-gpio | 20 ++ drivers/gpio/gpiolib.c | 252 ++- include/asm-generic/gpio.h | 11 + include/linux/gpio.h

[PATCH RESEND 1/6 v13] gpio: Add a block GPIO API to gpiolib

2013-01-15 Thread Roland Stigge
word: Once requested, it provides access to a group of GPIOs which can range over multiple GPIO chips. Signed-off-by: Roland Stigge --- Documentation/gpio.txt | 58 +++ drivers/gpio/gpiolib.c | 227 + include/asm-generic/gpio.h | 17 ++

[PATCH RESEND 3/6 v13] gpio: Add userland device interface to block GPIO

2013-01-15 Thread Roland Stigge
This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/dev-gpioblock | 34 drivers/gpio/gpiolib.c | 225 +++- include/linux/gpio.h| 13 + 3 files

[PATCH RESEND 6/6 v13] gpio: Add block gpio to several gpio drivers

2013-01-15 Thread Roland Stigge
.) Signed-off-by: Roland Stigge --- drivers/gpio/Kconfig |2 drivers/gpio/gpio-em.c| 23 ++ drivers/gpio/gpio-ge.c| 29 + drivers/gpio/gpio-generic.c | 56 + drivers/gpio/gpio-ks8695.c| 34

[PATCH RESEND 0/6 v13] gpio: Add block GPIO

2013-01-15 Thread Roland Stigge
special accessor functions for block wise GPIO access (only for some selected drivers since the feature is optional and not suitable for all GPIO hardware) * Fix for race condition in gpiolib on device creation Signed-off-by: Roland Stigge Tested by: Wolfgang Grandegger -- Testing branch

[PATCH RESEND 5/6 v13] gpio: Add device tree support to block GPIO API

2013-01-15 Thread Roland Stigge
This patch adds device tree support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/devicetree/bindings/gpio/gpio-block.txt | 36 ++ drivers/gpio/Makefile |1 drivers/gpio/gpioblock-of.c | 100

[PATCH RESEND 4/6 v13] gpiolib: Fix default attributes for class

2013-01-15 Thread Roland Stigge
There is a race condition between creating a gpio or gpiochip device and adding default attributes. This patch fixes this by defining the default attributes as dev_attrs of the class. For this, it was necessary to create a separate gpiochip_class besides gpio_class. Signed-off-by: Roland Stigge

[PATCH 6/6 v13] gpio: Add block gpio to several gpio drivers

2012-12-30 Thread Roland Stigge
.) Signed-off-by: Roland Stigge --- drivers/gpio/Kconfig |2 drivers/gpio/gpio-em.c| 23 ++ drivers/gpio/gpio-ge.c| 29 + drivers/gpio/gpio-generic.c | 56 + drivers/gpio/gpio-ks8695.c| 34

[PATCH 1/6 v13] gpio: Add a block GPIO API to gpiolib

2012-12-30 Thread Roland Stigge
word: Once requested, it provides access to a group of GPIOs which can range over multiple GPIO chips. Signed-off-by: Roland Stigge --- Documentation/gpio.txt | 58 +++ drivers/gpio/gpiolib.c | 227 + include/asm-generic/gpio.h | 17 ++

[PATCH 2/6 v13] gpio: Add sysfs support to block GPIO API

2012-12-30 Thread Roland Stigge
This patch adds sysfs support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/sysfs-gpio | 20 ++ drivers/gpio/gpiolib.c | 252 ++- include/asm-generic/gpio.h | 11 + include/linux/gpio.h

[PATCH 4/6 v13] gpiolib: Fix default attributes for class

2012-12-30 Thread Roland Stigge
There is a race condition between creating a gpio or gpiochip device and adding default attributes. This patch fixes this by defining the default attributes as dev_attrs of the class. For this, it was necessary to create a separate gpiochip_class besides gpio_class. Signed-off-by: Roland Stigge

[PATCH 0/6 v13] gpio: Add block GPIO

2012-12-30 Thread Roland Stigge
special accessor functions for block wise GPIO access (only for some selected drivers since the feature is optional and not suitable for all GPIO hardware) * Fix for race condition in gpiolib on device creation Signed-off-by: Roland Stigge Tested by: Wolfgang Grandegger -- Testing branch

[PATCH 3/6 v13] gpio: Add userland device interface to block GPIO

2012-12-30 Thread Roland Stigge
This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/dev-gpioblock | 34 drivers/gpio/gpiolib.c | 225 +++- include/linux/gpio.h| 13 + 3 files

[PATCH 5/6 v13] gpio: Add device tree support to block GPIO API

2012-12-30 Thread Roland Stigge
This patch adds device tree support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/devicetree/bindings/gpio/gpio-block.txt | 36 ++ drivers/gpio/Makefile |1 drivers/gpio/gpioblock-of.c | 100

Re: [PATCH 0/6 v12] gpio: Add block GPIO

2012-12-29 Thread Roland Stigge
On 29/12/12 13:13, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 13:01 Sat 29 Dec , Roland Stigge wrote: >> On 29/12/12 11:20, Jean-Christophe PLAGNIOL-VILLARD wrote: >>> On 17:49 Sun 23 Dec , Roland Stigge wrote: >>>> This set of patches adds: >>

Re: [PATCH 0/6 v12] gpio: Add block GPIO

2012-12-29 Thread Roland Stigge
Hi, On 29/12/12 11:20, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 17:49 Sun 23 Dec , Roland Stigge wrote: >> This set of patches adds: >> >> * Block GPIO API to gpiolib >> * Sysfs support for GPIO API, to provide userland access >> * Device interface fo

Re: [PATCH] samsung-laptop: Set keyboard backlight initially

2012-12-24 Thread Roland Stigge
On 24/12/12 09:41, Corentin Chary wrote: > On Sun, Dec 23, 2012 at 6:21 PM, Roland Stigge wrote: >> After boot, >> /sys/devices/platform/samsung/leds/samsung::kbd_backlight/brightness >> shows the maximum value (8) by readout, but the led is off. I need to >>

[PATCH] samsung-laptop: Set keyboard backlight initially

2012-12-23 Thread Roland Stigge
. Signed-off-by: Roland Stigge -- I'm encountering a similar issue after suspend/resume (led is off). Still wondering if and by which technique I should add a respective .resume() because the driver currently doesn't have pm support and also doesn't register as a driver. Any h

[PATCH 2/6 v12] gpio: Add sysfs support to block GPIO API

2012-12-23 Thread Roland Stigge
This patch adds sysfs support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/sysfs-gpio | 20 ++ drivers/gpio/gpiolib.c | 252 ++- include/asm-generic/gpio.h | 11 + include/linux/gpio.h

[PATCH 6/6 v12] gpio: Add block gpio to several gpio drivers

2012-12-23 Thread Roland Stigge
.) Signed-off-by: Roland Stigge --- drivers/gpio/gpio-em.c| 23 ++ drivers/gpio/gpio-generic.c | 56 + drivers/gpio/gpio-lpc32xx.c | 82 ++ drivers/gpio/gpio-max730x.c | 61

[PATCH 3/6 v12] gpio: Add userland device interface to block GPIO

2012-12-23 Thread Roland Stigge
This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/dev-gpioblock | 34 drivers/gpio/gpiolib.c | 225 +++- include/linux/gpio.h| 13 + 3 files

[PATCH 4/6 v12] gpiolib: Fix default attributes for class

2012-12-23 Thread Roland Stigge
There is a race condition between creating a gpio or gpiochip device and adding default attributes. This patch fixes this by defining the default attributes as dev_attrs of the class. For this, it was necessary to create a separate gpiochip_class besides gpio_class. Signed-off-by: Roland Stigge

[PATCH 5/6 v12] gpio: Add device tree support to block GPIO API

2012-12-23 Thread Roland Stigge
This patch adds device tree support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/devicetree/bindings/gpio/gpio-block.txt | 36 ++ drivers/gpio/Makefile |1 drivers/gpio/gpioblock-of.c | 100

[PATCH 1/6 v12] gpio: Add a block GPIO API to gpiolib

2012-12-23 Thread Roland Stigge
word: Once requested, it provides access to a group of GPIOs which can range over multiple GPIO chips. Signed-off-by: Roland Stigge --- Documentation/gpio.txt | 58 +++ drivers/gpio/gpiolib.c | 227 + include/asm-generic/gpio.h | 17 ++

[PATCH 0/6 v12] gpio: Add block GPIO

2012-12-23 Thread Roland Stigge
special accessor functions for block wise GPIO access (only for some selected drivers since the feature is optional and not suitable for all GPIO hardware) * Fix for race condition in gpiolib on device creation Signed-off-by: Roland Stigge Tested by: Wolfgang Grandegger -- Testing branch

Re: [PATCH 6/6 v11] gpio: Add block gpio to several gpio drivers

2012-12-20 Thread Roland Stigge
On 12/20/2012 09:07 AM, Wolfgang Grandegger wrote: > On 12/20/2012 08:08 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: >> On 22:22 Wed 19 Dec , Roland Stigge wrote: >>> This patch adds block GPIO support to several gpio drivers. >>> >>> This implements block

[PATCH 6/6 v11] gpio: Add block gpio to several gpio drivers

2012-12-19 Thread Roland Stigge
.) Signed-off-by: Roland Stigge --- arch/arm/mach-at91/gpio.c | 33 +++ drivers/gpio/gpio-em.c| 23 ++ drivers/gpio/gpio-generic.c | 56 + drivers/gpio/gpio-lpc32xx.c | 82

[PATCH 1/6 v11] gpio: Add a block GPIO API to gpiolib

2012-12-19 Thread Roland Stigge
word: Once requested, it provides access to a group of GPIOs which can range over multiple GPIO chips. Signed-off-by: Roland Stigge --- Documentation/gpio.txt | 58 +++ drivers/gpio/gpiolib.c | 227 + include/asm-generic/gpio.h | 17 ++

[PATCH 3/6 v11] gpio: Add userland device interface to block GPIO

2012-12-19 Thread Roland Stigge
This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/dev-gpioblock | 34 drivers/gpio/gpiolib.c | 224 +++- include/linux/gpio.h| 13 + 3 files

[PATCH 2/6 v11] gpio: Add sysfs support to block GPIO API

2012-12-19 Thread Roland Stigge
This patch adds sysfs support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/sysfs-gpio | 20 ++ drivers/gpio/gpiolib.c | 250 ++- include/asm-generic/gpio.h | 11 + include/linux/gpio.h

[PATCH 5/6 v11] gpio: Add device tree support to block GPIO API

2012-12-19 Thread Roland Stigge
This patch adds device tree support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/devicetree/bindings/gpio/gpio-block.txt | 36 ++ drivers/gpio/Makefile |1 drivers/gpio/gpioblock-of.c | 100

[PATCH 0/6 v11] gpio: Add block GPIO

2012-12-19 Thread Roland Stigge
special accessor functions for block wise GPIO access (only for some selected drivers since the feature is optional and not suitable for all GPIO hardware) * Fix for race condition in gpiolib on device creation Signed-off-by: Roland Stigge Tested by: Wolfgang Grandegger -- Changes since v10

[PATCH 4/6 v11] gpiolib: Fix default attributes for class

2012-12-19 Thread Roland Stigge
There is a race condition between creating a gpio or gpiochip device and adding default attributes. This patch fixes this by defining the default attributes as dev_attrs of the class. For this, it was necessary to create a separate gpiochip_class besides gpio_class. Signed-off-by: Roland Stigge

Re: [PATCH RESEND 5/6 v10] gpio: Add device tree support to block GPIO API

2012-12-18 Thread Roland Stigge
Hi Mark, On 12/17/2012 04:51 PM, Mark Rutland wrote: >> +static int __devinit gpioblock_of_probe(struct platform_device *pdev) >> +{ >> +struct device_node *block; >> +unsigned *gpios; >> +int ngpio; >> +int ret; >> +struct gpio_block *gb; >> + >> +for_each_available_child_

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Roland Stigge
On 17/12/12 20:47, Wolfgang Grandegger wrote: > On 12/17/2012 07:02 PM, Roland Stigge wrote: >> On 12/17/2012 06:37 PM, Wolfgang Grandegger wrote: >>> /* Do synchronous data output with a single write access */ >>> __raw_writel(~mask, pio + PIO_OWDR); >

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Roland Stigge
On 12/17/2012 06:37 PM, Wolfgang Grandegger wrote: > /* Do synchronous data output with a single write access */ > __raw_writel(~mask, pio + PIO_OWDR); > __raw_writel(mask, pio + PIO_OWER); > __raw_writel(val, pio + PIO_ODSR); > > For caching we would need a storage. Not su

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Roland Stigge
On 12/17/2012 05:28 PM, Wolfgang Grandegger wrote: > On 12/17/2012 02:51 PM, Roland Stigge wrote: >> Hi Wolfgang, >>> And I guess Russell is right: If possible, we should write outputs >>> simultaneously via ODSR (plus OWER/OWDR/OWSR) instead of separate set/clear. >

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Roland Stigge
Hi Wolfgang, On 12/17/2012 02:32 PM, Roland Stigge wrote: > And I guess Russell is right: If possible, we should write outputs > simultaneously via ODSR (plus OWER/OWDR/OWSR) instead of separate set/clear. > > I wonder if we need to save/restore the state of OWSR at every write >

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-17 Thread Roland Stigge
On 12/17/2012 12:51 PM, Wolfgang Grandegger wrote: >>> Without having an AT91 available right now, I guess the hardware >>> interface of this GPIO chip is different from the GPIO block API. While >>> the hardware has clear and set registers, the val parameter of >>> at91_gpiolib_set_block() should

Re: [PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-14 Thread Roland Stigge
Hi Wolfgang, thank you for the patch! On 14/12/12 18:58, Wolfgang Grandegger wrote: > +static void at91_gpiolib_set_block(struct gpio_chip *chip, unsigned long > mask, unsigned long val) > +{ > + struct at91_gpio_chip *at91_gpio = to_at91_gpio_chip(chip); > + void __iomem *pio = at91_gpi

[PATCH RESEND 2/6 v10] gpio: Add sysfs support to block GPIO API

2012-12-14 Thread Roland Stigge
This patch adds sysfs support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/sysfs-gpio | 20 ++ drivers/gpio/gpiolib.c | 250 ++- include/asm-generic/gpio.h | 11 + include/linux/gpio.h

[PATCH RESEND 0/6 v10] gpio: Add block GPIO

2012-12-14 Thread Roland Stigge
special accessor functions for block wise GPIO access * Fix for race condition in gpiolib on device creation Signed-off-by: Roland Stigge Tested by: Wolfgang Grandegger -- Changed since v9: * Changed IRQ flags for device interface's poll() from IRQF_TRIGGER_FALLING to IRQF_SHARED * Use

[PATCH RESEND 3/6 v10] gpio: Add userland device interface to block GPIO

2012-12-14 Thread Roland Stigge
This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/dev-gpioblock | 34 drivers/gpio/gpiolib.c | 224 +++- include/linux/gpio.h| 13 + 3 files

[PATCH RESEND 5/6 v10] gpio: Add device tree support to block GPIO API

2012-12-14 Thread Roland Stigge
This patch adds device tree support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/devicetree/bindings/gpio/gpio-block.txt | 36 +++ drivers/gpio/Makefile |1 drivers/gpio/gpioblock-of.c | 84

[PATCH RESEND 6/6 v10] gpio: Add block gpio to several gpio drivers

2012-12-14 Thread Roland Stigge
This patch adds block GPIO support to several gpio drivers. Signed-off-by: Roland Stigge --- drivers/gpio/gpio-em.c | 23 drivers/gpio/gpio-generic.c | 56 ++ drivers/gpio/gpio-lpc32xx.c | 82

[PATCH RESEND 1/6 v10] gpio: Add a block GPIO API to gpiolib

2012-12-14 Thread Roland Stigge
word: Once requested, it provides access to a group of GPIOs which can range over multiple GPIO chips. Signed-off-by: Roland Stigge --- Documentation/gpio.txt | 58 +++ drivers/gpio/gpiolib.c | 227 + include/asm-generic/gpio.h | 17 ++

[PATCH RESEND 4/6 v10] gpiolib: Fix default attributes for class

2012-12-14 Thread Roland Stigge
There is a race condition between creating a gpio or gpiochip device and adding default attributes. This patch fixes this by defining the default attributes as dev_attrs of the class. For this, it was necessary to create a separate gpiochip_class besides gpio_class. Signed-off-by: Roland Stigge

Re: [PATCH 0/6 v10] gpio: Add block GPIO

2012-12-07 Thread Roland Stigge
On 12/07/2012 06:02 PM, Alan Cox wrote: Currently we can set different permissions on different GPIO lines. Your driver change drives a truck through this facility. >> >> What I maybe misread in your concern: The dev interface is actually an >> "alternative to sysfs for block GPIO", not c

Re: [PATCH 0/6 v10] gpio: Add block GPIO

2012-12-07 Thread Roland Stigge
On 12/07/2012 01:06 PM, Roland Stigge wrote: > On 12/07/2012 11:36 AM, Alan Cox wrote: >>> * Device interface for userland access (alternative to sysfs) >> >> Currently we can set different permissions on different GPIO lines. Your >> driver change drives a truck

Re: [PATCH 0/6 v10] gpio: Add block GPIO

2012-12-07 Thread Roland Stigge
On 12/07/2012 11:36 AM, Alan Cox wrote: >> * Device interface for userland access (alternative to sysfs) > > Currently we can set different permissions on different GPIO lines. Your > driver change drives a truck through this facility. > > I'm not sure there is an elegant way to snoop on the perm

[PATCH 1/6 v10] gpio: Add a block GPIO API to gpiolib

2012-12-06 Thread Roland Stigge
word: Once requested, it provides access to a group of GPIOs which can range over multiple GPIO chips. Signed-off-by: Roland Stigge --- Documentation/gpio.txt | 58 +++ drivers/gpio/gpiolib.c | 227 + include/asm-generic/gpio.h | 17 ++

[PATCH 2/6 v10] gpio: Add sysfs support to block GPIO API

2012-12-06 Thread Roland Stigge
This patch adds sysfs support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/sysfs-gpio | 20 ++ drivers/gpio/gpiolib.c | 250 ++- include/asm-generic/gpio.h | 11 + include/linux/gpio.h

[PATCH 0/6 v10] gpio: Add block GPIO

2012-12-06 Thread Roland Stigge
special accessor functions for block wise GPIO access * Fix for race condition in gpiolib on device creation Signed-off-by: Roland Stigge Tested by: Wolfgang Grandegger -- Changed since v9: * Changed IRQ flags for device interface's poll() from IRQF_TRIGGER_FALLING to IRQF_SHARED * Use

[PATCH 4/6 v10] gpiolib: Fix default attributes for class

2012-12-06 Thread Roland Stigge
There is a race condition between creating a gpio or gpiochip device and adding default attributes. This patch fixes this by defining the default attributes as dev_attrs of the class. For this, it was necessary to create a separate gpiochip_class besides gpio_class. Signed-off-by: Roland Stigge

[PATCH 3/6 v10] gpio: Add userland device interface to block GPIO

2012-12-06 Thread Roland Stigge
This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/dev-gpioblock | 34 drivers/gpio/gpiolib.c | 224 +++- include/linux/gpio.h| 13 + 3 files

[PATCH 6/6 v10] gpio: Add block gpio to several gpio drivers

2012-12-06 Thread Roland Stigge
This patch adds block GPIO support to several gpio drivers. Signed-off-by: Roland Stigge --- drivers/gpio/gpio-em.c | 23 drivers/gpio/gpio-generic.c | 56 ++ drivers/gpio/gpio-lpc32xx.c | 82

[PATCH 5/6 v10] gpio: Add device tree support to block GPIO API

2012-12-06 Thread Roland Stigge
This patch adds device tree support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/devicetree/bindings/gpio/gpio-block.txt | 36 +++ drivers/gpio/Makefile |1 drivers/gpio/gpioblock-of.c | 84

Re: [PATCH 3/6 v9] gpio: Add userland device interface to block GPIO

2012-12-05 Thread Roland Stigge
Hi Wolfgang, On 05/12/12 20:01, Wolfgang Grandegger wrote: >> +for (i = 0; i < block->ngpio; i++) { >> +status = gpio_request(block->gpio[i], "gpioblock dev"); > > You could use the name of the GPIO block. OK. >> +if (status) >> +goto err1; >> + >

Re: [PATCH 0/6 v8] gpio: Add block GPIO

2012-12-05 Thread Roland Stigge
Hi Wolfgang, On 05/12/12 19:44, Wolfgang Grandegger wrote: >> * There is probably an explicit interrupt configuration necessary (via >> struct gpio_block, and devicetree, respectively) since there are >> constellations where gpio_to_irq() isn't working. E.g., in contrast to >> controllers which ar

[PATCH 2/6 v9] gpio: Add sysfs support to block GPIO API

2012-12-04 Thread Roland Stigge
This patch adds sysfs support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/sysfs-gpio | 20 ++ drivers/gpio/gpiolib.c | 250 ++- include/asm-generic/gpio.h | 11 + include/linux/gpio.h

[PATCH 3/6 v9] gpio: Add userland device interface to block GPIO

2012-12-04 Thread Roland Stigge
This patch adds a character device interface to the block GPIO system. Signed-off-by: Roland Stigge --- Documentation/ABI/testing/dev-gpioblock | 34 + drivers/gpio/gpiolib.c | 208 +++- include/linux/gpio.h| 10 + 3

[PATCH 1/6 v9] gpio: Add a block GPIO API to gpiolib

2012-12-04 Thread Roland Stigge
word: Once requested, it provides access to a group of GPIOs which can range over multiple GPIO chips. Signed-off-by: Roland Stigge --- Documentation/gpio.txt | 58 +++ drivers/gpio/gpiolib.c | 227 + include/asm-generic/gpio.h | 17 ++

Re: [PATCH 0/6 v8] gpio: Add block GPIO

2012-12-04 Thread Roland Stigge
Hi Wolfgang, On 03/12/12 10:17, Wolfgang Grandegger wrote: > I re-tried v8 on my AT91-SAM9G45 board and it works fine if > CONFIG_GPIO_SYSFS is enable. Unfortunately, the access via misc device > fails if CONFIG_GPIO_SYSFS is not set. That's due to gpio_block_export() > returning -ENOSYS in gpio_b

[PATCH 6/6 v9] gpio: Add block gpio to several gpio drivers

2012-12-04 Thread Roland Stigge
This patch adds block GPIO support to several gpio drivers. Signed-off-by: Roland Stigge --- drivers/gpio/gpio-em.c | 23 drivers/gpio/gpio-generic.c | 56 ++ drivers/gpio/gpio-lpc32xx.c | 82

[PATCH 4/6 v9] gpiolib: Fix default attributes for class

2012-12-04 Thread Roland Stigge
There is a race condition between creating a gpio or gpiochip device and adding default attributes. This patch fixes this by defining the default attributes as dev_attrs of the class. For this, it was necessary to create a separate gpiochip_class besides gpio_class. Signed-off-by: Roland Stigge

[PATCH 5/6 v9] gpio: Add device tree support to block GPIO API

2012-12-04 Thread Roland Stigge
This patch adds device tree support to the block GPIO API. Signed-off-by: Roland Stigge --- Documentation/devicetree/bindings/gpio/gpio-block.txt | 36 +++ drivers/gpio/Makefile |1 drivers/gpio/gpioblock-of.c | 84

  1   2   3   4   >